From patchwork Tue Aug 4 12:41:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 11700347 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5DC4A722 for ; Tue, 4 Aug 2020 12:41:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 32D01208C7 for ; Tue, 4 Aug 2020 12:41:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="e/emAKRK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 32D01208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63B2E8D0157; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5EB388D0081; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 528698D0157; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 40CFF8D0081 for ; Tue, 4 Aug 2020 08:41:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EC3BA1EE6 for ; Tue, 4 Aug 2020 12:41:38 +0000 (UTC) X-FDA: 77112847476.21.bikes68_550578726fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 2FECB180442C2 for ; Tue, 4 Aug 2020 12:41:38 +0000 (UTC) X-Spam-Summary: 1,0,0,64002509632aeb10,d41d8cd98f00b204,3f1cpxwokcniyb1f2m8bj94cc492.0ca96bil-aa8jy08.cf4@flex--andreyknvl.bounces.google.com,,RULES_HIT:41:152:355:379:541:800:960:973:988:989:1042:1260:1277:1313:1314:1345:1359:1431:1437:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2559:2562:2689:3138:3139:3140:3141:3142:3152:3352:3865:3866:3867:3868:3871:4250:4321:5007:6261:6653:6742:7903:9969:10004:10400:11026:11473:11658:11914:12043:12296:12297:12438:12555:12895:13069:13311:13357:13972:14096:14097:14181:14394:14659:14721:14877:21080:21444:21451:21627:21772:21990:30054:30055,0,RBL:209.85.221.73:@flex--andreyknvl.bounces.google.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100;04y8zffjynbcsadashdnj13cse4khoptn8z6wxrpyje7kuxau3kqgh5xzzqhjrt.ugyatqhx8hnuzg8n33n5zo9qsqpzn8b69dhy1e6h9t4eewzygmdmihr7y4u6ex4.4-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rul es:0:0:0 X-HE-Tag: bikes68_550578726fa6 X-Filterd-Recvd-Size: 4390 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 12:41:37 +0000 (UTC) Received: by mail-wr1-f73.google.com with SMTP id f14so12523852wrm.22 for ; Tue, 04 Aug 2020 05:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=FcKp4QRyFHBBCVHpXykl5mFo5C8EtuBz90+P1+03xoY=; b=e/emAKRKbJkdBeq2q9WKmzagPJvb8gdtqflMVkfA9U+GObzCW9ZK8iDv+fm06/lNOH ajIRbU5BrRbTrBBREu3uaJou2xzNyaOCp+XZbidInFpetFzQFW1x8pTzoRCyj341z+Lk wq4m5lWgeLtpP7STH34Cb53cG+ae0e77L4MzJmeQ/HMqzyEcxWEcW0LZlOw/BlZk7uoa dO5RcM67ErBDoGmZ9vvLhQ54jnpx36h7CmzrXwZGP0KVeFdh2JE5X6xOlJdqsCGf3JGH qx57794JnfkOQH/j1i6yWfIbZmc2qfK2k0FRmQtkn8Nc1oWCF+4s0O93QqCimgEugC/p C7cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=FcKp4QRyFHBBCVHpXykl5mFo5C8EtuBz90+P1+03xoY=; b=LI4pCD5h9fyvR+NPfknob4dHrMSJBDldG1vf0MOhtYIoVBbi+CYT70I+YP8ESb5GxG lAYXdn6qbtuS2qZuwmHFtULnTbQeBc/aeTQVzroCUyrJuEthu5UfLkDSVyopNWpdDH+p 3GxVnmpNYkELpIg+wp+B0bTyvQsKPFjQ/32+2vW+HisbdzUu+w+e+yoYM0G2syS3ykwT ml6IPAEFHveLXsOvJ0g2hfCpn+wUNtyiiQiykj1UsnW5GNZcJo1kVzOh9vyC7O2FEP3m p8w/prayITlvja60ZAGAehjPBXxONVEIZi5S7hi8ZaNERJGDntwnxDlEQxKI5bVmNgmu VljQ== X-Gm-Message-State: AOAM533f1TnLZKw88hJ9Uuh6PJntPacIEb88lV+QDOG4zLiZ3pauVqXQ tMVCxbWngP98cTW+rQOGB+eP4kkvWI4/UlGT X-Google-Smtp-Source: ABdhPJysUQ4oDqsJhy6xq9sHQOykVWtKsRJrE3eJ3umL4PptPqQvdYk0j95C1HF2RsOBJ7cfXSW95HsjwlUjMNSy X-Received: by 2002:a1c:b443:: with SMTP id d64mr4329306wmf.68.1596544895842; Tue, 04 Aug 2020 05:41:35 -0700 (PDT) Date: Tue, 4 Aug 2020 14:41:24 +0200 In-Reply-To: Message-Id: <12d8c678869268dd0884b01271ab592f30792abf.1596544734.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH v2 1/5] kasan: don't tag stacks allocated with pagealloc From: Andrey Konovalov To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Ard Biesheuvel , Arvind Sankar , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Walter Wu , Elena Petrova , Vincenzo Frascino , Catalin Marinas , Andrey Konovalov X-Rspamd-Queue-Id: 2FECB180442C2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch prepares Software Tag-Based KASAN for stack tagging support. With Tag-Based KASAN when kernel stacks are allocated via pagealloc (which happens when CONFIG_VMAP_STACK is not enabled), they get tagged. KASAN instrumentation doesn't expect the sp register to be tagged, and this leads to false-positive reports. Fix by resetting the tag of kernel stack pointers after allocation. Signed-off-by: Andrey Konovalov --- kernel/fork.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kernel/fork.c b/kernel/fork.c index efc5493203ae..75415f5e647c 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -261,7 +261,7 @@ static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, int node) THREAD_SIZE_ORDER); if (likely(page)) { - tsk->stack = page_address(page); + tsk->stack = kasan_reset_tag(page_address(page)); return tsk->stack; } return NULL; @@ -307,6 +307,7 @@ static unsigned long *alloc_thread_stack_node(struct task_struct *tsk, { unsigned long *stack; stack = kmem_cache_alloc_node(thread_stack_cache, THREADINFO_GFP, node); + stack = kasan_reset_tag(stack); tsk->stack = stack; return stack; } From patchwork Tue Aug 4 12:41:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 11700349 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D31AA1575 for ; Tue, 4 Aug 2020 12:41:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B13DB208C7 for ; Tue, 4 Aug 2020 12:41:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="El9eCMgZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B13DB208C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 613FB8D0158; Tue, 4 Aug 2020 08:41:41 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5C43F8D0081; Tue, 4 Aug 2020 08:41:41 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DB978D0158; Tue, 4 Aug 2020 08:41:41 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 3A7588D0081 for ; Tue, 4 Aug 2020 08:41:41 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id B79C3181AEF00 for ; Tue, 4 Aug 2020 12:41:40 +0000 (UTC) X-FDA: 77112847560.28.legs35_1917cdb26fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 14F7E6C1A for ; Tue, 4 Aug 2020 12:41:39 +0000 (UTC) X-Spam-Summary: 1,0,0,5071036ec5ab6f74,d41d8cd98f00b204,3glcpxwokcnu1e4i5pbemc7ff7c5.3fdc9elo-ddbm13b.fi7@flex--andreyknvl.bounces.google.com,,RULES_HIT:41:152:355:379:541:800:960:966:973:988:989:1260:1277:1313:1314:1345:1359:1431:1437:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2196:2199:2393:2559:2562:3138:3139:3140:3141:3142:3152:3352:3867:3870:3871:4250:4385:5007:6261:6653:6742:8603:8660:9969:10004:10400:11026:11658:11914:12050:12114:12296:12297:12438:12555:12895:12986:13069:13148:13221:13229:13230:13311:13357:14096:14097:14181:14394:14659:14721:21080:21444:21451:21627:21939:30054:30064,0,RBL:209.85.219.73:@flex--andreyknvl.bounces.google.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100;04yfgnx75fdyr7dnpmw1g8eoempckyc1ib3o691ocjw99ojegxumze4pwztkxwu.mxjztgkaynd6xbw6db8ajeo8oh8ykib5afx5zpfe111mt5h6wy13bqzmkmiqkua.e-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_ru les:0:0: X-HE-Tag: legs35_1917cdb26fa6 X-Filterd-Recvd-Size: 4312 Received: from mail-qv1-f73.google.com (mail-qv1-f73.google.com [209.85.219.73]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 12:41:39 +0000 (UTC) Received: by mail-qv1-f73.google.com with SMTP id l18so10053361qvq.16 for ; Tue, 04 Aug 2020 05:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=MkWKUi7xJlcxy+e8OWBoJNl1OXW3h1d9K35k1It603c=; b=El9eCMgZto7hrv7PDOK8sz2wSLBcDVP89TfYWUHfgVCBju0bnGiOsMLl6XBn8jPSjh qrgdXGRXN4HlmL1fOGf8voLbPZt1X18PEjYdDjjXTh3PKpwhCwvxfdH77PmSuIH6bHjH IzHWS/61LABdVG/cl9nv7tSaT02sva1I2t9kU4CCxKn2Fuq5zAhsavQCtRi26JwEs+Dl 9fQdx9ceg+7jPTrfJr2H/RPbendmsnMPAjmTuZXHQ5z0+weqjI1akX4ATVsuIjOK4K4K 9i8R5X/OYsJ9UZwUQgh+6iCBRktsvnPbggGzIRvclgIctl5ElMdM+aNZB9sDbsroXJJs M9ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=MkWKUi7xJlcxy+e8OWBoJNl1OXW3h1d9K35k1It603c=; b=J160BQZ2U9pszkqMXI2DH/M4AU1ruy5UWu1FTE8c6Cl6AvyhuBCpcD8ox8bqF/04ct 0x7wNtuT9MkwLIv1hy7vfnUtJXG/7PqCTRMdN3B6lckzPOviBO9axgE1op6Z4sHN5/Jn DY/deC6LR8Lp13IW6UV+FEYTboXnVtkZkg5rkpPAqlcIUrIByDgOGJScVFzy81moxh8S KhT6Fb8EIknIT81C1Ep7fnbqxJN90lt2rzJm7iH4qrJTclq48lpskhA7aI3lt0aV/HWP rsSEzZdMH3/4F8bmBqiZrRRfg1imixdSrxLRaXO0HN7PbKUOLnHnxqrSBC3cQK4p8+Zl vy3Q== X-Gm-Message-State: AOAM5310q3ChES/tK21Eu52xOxFxHYjhE+dDL4vg2+xk0/80RMoZZ5Dr 84yxklbmnjXwdrJUJokslt7aCdENOkkL0V42 X-Google-Smtp-Source: ABdhPJwC+zlXBovbZ5yMemFd6n1F3dx7E2v/1/0xLypGVzYOL4r1AHzTFwqN6hvHO5BmR1xUzcpuB+Tj4Xl/elq0 X-Received: by 2002:ad4:4152:: with SMTP id z18mr22181844qvp.42.1596544898043; Tue, 04 Aug 2020 05:41:38 -0700 (PDT) Date: Tue, 4 Aug 2020 14:41:25 +0200 In-Reply-To: Message-Id: <6514652d3a32d3ed33d6eb5c91d0af63bf0d1a0c.1596544734.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH v2 2/5] efi: provide empty efi_enter_virtual_mode implementation From: Andrey Konovalov To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Ard Biesheuvel , Arvind Sankar , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Walter Wu , Elena Petrova , Vincenzo Frascino , Catalin Marinas , Andrey Konovalov , kernel test robot X-Rspamd-Queue-Id: 14F7E6C1A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: When CONFIG_EFI is not enabled, we might get an undefined reference to efi_enter_virtual_mode() error, if this efi_enabled() call isn't inlined into start_kernel(). This happens in particular, if start_kernel() is annodated with __no_sanitize_address. Reported-by: kernel test robot Signed-off-by: Andrey Konovalov Acked-by: Ard Biesheuvel --- include/linux/efi.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/include/linux/efi.h b/include/linux/efi.h index 05c47f857383..73db1ae04cef 100644 --- a/include/linux/efi.h +++ b/include/linux/efi.h @@ -606,7 +606,11 @@ extern void *efi_get_pal_addr (void); extern void efi_map_pal_code (void); extern void efi_memmap_walk (efi_freemem_callback_t callback, void *arg); extern void efi_gettimeofday (struct timespec64 *ts); +#ifdef CONFIG_EFI extern void efi_enter_virtual_mode (void); /* switch EFI to virtual mode, if possible */ +#else +static inline void efi_enter_virtual_mode (void) {} +#endif #ifdef CONFIG_X86 extern efi_status_t efi_query_variable_store(u32 attributes, unsigned long size, From patchwork Tue Aug 4 12:41:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 11700351 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 831651575 for ; Tue, 4 Aug 2020 12:41:45 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 611B5208A9 for ; Tue, 4 Aug 2020 12:41:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="epaWaJlt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 611B5208A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2B8CB8D0159; Tue, 4 Aug 2020 08:41:43 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 2911D8D0081; Tue, 4 Aug 2020 08:41:43 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A6D28D0159; Tue, 4 Aug 2020 08:41:43 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0234.hostedemail.com [216.40.44.234]) by kanga.kvack.org (Postfix) with ESMTP id 022478D0081 for ; Tue, 4 Aug 2020 08:41:42 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B04E9180AD817 for ; Tue, 4 Aug 2020 12:41:42 +0000 (UTC) X-FDA: 77112847644.09.pest32_2311d0426fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 5AE82180AD802 for ; Tue, 4 Aug 2020 12:41:42 +0000 (UTC) X-Spam-Summary: 1,0,0,f3d19e28598384e2,d41d8cd98f00b204,3hfcpxwokcnc3g6k7rdgoe9hh9e7.5hfebgnq-ffdo35d.hk9@flex--andreyknvl.bounces.google.com,,RULES_HIT:41:152:355:379:541:800:960:973:988:989:1042:1260:1277:1313:1314:1345:1359:1431:1437:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2914:3138:3139:3140:3141:3142:3152:3353:3865:3867:3868:3870:3871:3872:4250:4321:4605:5007:6261:6653:6742:9969:10004:10400:11026:11658:11914:12043:12297:12438:12555:12895:13069:13311:13357:14181:14394:14659:14721:21080:21433:21444:21451:21627:21772:30054:30055:30070,0,RBL:209.85.221.74:@flex--andreyknvl.bounces.google.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100;04yggq4ben6gp44jr1ir894ns1sf8ocmxosqwkeuo1af7jknijni41a8cdpj9wq.38xcn5jjjbrwdproghfc5k464x7qgohp1jhq6j7gbdyn8meryehtquwkr3kxuzd.c-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: pest32_2311d0426fa6 X-Filterd-Recvd-Size: 4965 Received: from mail-wr1-f74.google.com (mail-wr1-f74.google.com [209.85.221.74]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 12:41:41 +0000 (UTC) Received: by mail-wr1-f74.google.com with SMTP id b18so9564662wrn.6 for ; Tue, 04 Aug 2020 05:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=KTaExCeIbMBtrg6f3KaFtKJ9kXln1IxZOo4x1K8ywoo=; b=epaWaJlt64ntx42FNABLMyLva14SlmdYcoGzzYGyrXWUnAJnxMu5GEZgilr7YOjQyg rwN+m322Ym4K72DntPYQLTQpUlUsvtp9hOED35dktAjWzCeoMAdqgWFu+8q67qvVGdd0 ASSvypkGepo2fVM74GawP/zGW8ARgykh7GWGHusAgWS8l/UBxb0pdkO0TYQ7EmgRfqVS +AhohRsPKYfLCyuszVYf5jaiW3P7HKDO0xMW0AxuHSElSjjWJ6UveE2t2MgCnIL+ItDv /1ed6bLGDRty9mFhZhCq6dEUtquKavGW9+Vz9/sId52Rf88V2RXw/k9gqiVHbxbaBWtN +9hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=KTaExCeIbMBtrg6f3KaFtKJ9kXln1IxZOo4x1K8ywoo=; b=H2m+h3aFc4kaM7WswoJb5CzR9rmpCZ2PaUGd6EqJjkODlhIn2t2vFdr1JAwWZKy8YB A+D7MtOCJwWLOr2yewxrNXiMtfQI6gkNngjpKHvKb7r2MWy11dbgbnOCA5m48FRoiHki unnNwbZ9GtpAtFU2NR5LErY5O1WgV+Y802ElHnE4YbGlMWtNltTQmBoY9TYuCpKhlZjI kakUkUX69yKyK8kE2K2t4JSLCRh13Rdigrh/Pb9npU5cEg5E7KxQz2rfOwloRw3mYtVS MUPDR5yEWdFaMX/s5+FmO9MBAdixmAG5Lk10b3fJUjZY/BRgYBGEc38jPuqDSInIXbl5 66uA== X-Gm-Message-State: AOAM530nMSM70gfur6txsBCyByIKz2ZNSIf8QkeanNidgADh1nwL2AeP ra4bu45eojbSonifZuQvfIGBnUf5qekMRME0 X-Google-Smtp-Source: ABdhPJwWjosW9Y2ZD4qtR2i07CuuW2KOWsc+Y1P+/2KrTNBkB6pCcdGVRsu0tHMa3wVdBR/M1mpyQCpyke7nl0k9 X-Received: by 2002:a7b:cd93:: with SMTP id y19mr492659wmj.0.1596544900281; Tue, 04 Aug 2020 05:41:40 -0700 (PDT) Date: Tue, 4 Aug 2020 14:41:26 +0200 In-Reply-To: Message-Id: <26fb6165a17abcf61222eda5184c030fb6b133d1.1596544734.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH v2 3/5] kasan, arm64: don't instrument functions that enable kasan From: Andrey Konovalov To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Ard Biesheuvel , Arvind Sankar , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Walter Wu , Elena Petrova , Vincenzo Frascino , Catalin Marinas , Andrey Konovalov X-Rspamd-Queue-Id: 5AE82180AD802 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch prepares Software Tag-Based KASAN for stack tagging support. With stack tagging enabled, KASAN tags stack variable in each function in its prologue. In start_kernel() stack variables get tagged before KASAN is enabled via setup_arch()->kasan_init(). As the result the tags for start_kernel()'s stack variables end up in the temporary shadow memory. Later when KASAN gets enabled, switched to normal shadow, and starts checking tags, this leads to false-positive reports, as proper tags are missing in normal shadow. Disable KASAN instrumentation for start_kernel(). Also disable it for arm64's setup_arch() as a precaution (it doesn't have any stack variables right now). Signed-off-by: Andrey Konovalov Acked-by: Catalin Marinas --- arch/arm64/kernel/setup.c | 2 +- init/main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c index 93b3844cf442..575da075a2b9 100644 --- a/arch/arm64/kernel/setup.c +++ b/arch/arm64/kernel/setup.c @@ -276,7 +276,7 @@ arch_initcall(reserve_memblock_reserved_regions); u64 __cpu_logical_map[NR_CPUS] = { [0 ... NR_CPUS-1] = INVALID_HWID }; -void __init setup_arch(char **cmdline_p) +void __init __no_sanitize_address setup_arch(char **cmdline_p) { init_mm.start_code = (unsigned long) _text; init_mm.end_code = (unsigned long) _etext; diff --git a/init/main.c b/init/main.c index 0ead83e86b5a..7e5e25d9fe42 100644 --- a/init/main.c +++ b/init/main.c @@ -827,7 +827,7 @@ void __init __weak arch_call_rest_init(void) rest_init(); } -asmlinkage __visible void __init start_kernel(void) +asmlinkage __visible void __init __no_sanitize_address start_kernel(void) { char *command_line; char *after_dashes; From patchwork Tue Aug 4 12:41:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 11700353 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F12BB722 for ; Tue, 4 Aug 2020 12:41:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CE510208A9 for ; Tue, 4 Aug 2020 12:41:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="al711nch" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE510208A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8AE178D015A; Tue, 4 Aug 2020 08:41:44 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 80E7D8D0081; Tue, 4 Aug 2020 08:41:44 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 661888D015A; Tue, 4 Aug 2020 08:41:44 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 51B2A8D0081 for ; Tue, 4 Aug 2020 08:41:44 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 09C13824805A for ; Tue, 4 Aug 2020 12:41:44 +0000 (UTC) X-FDA: 77112847728.01.whip40_0e1114926fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id CB86E100471EF for ; Tue, 4 Aug 2020 12:41:43 +0000 (UTC) X-Spam-Summary: 50,0,0,31bab967adc2d004,d41d8cd98f00b204,3hlcpxwokcnk5i8m9tfiqgbjjbg9.7jhgdips-hhfq57f.jmb@flex--andreyknvl.bounces.google.com,,RULES_HIT:41:152:355:379:541:800:960:967:973:982:988:989:1260:1277:1313:1314:1345:1359:1431:1437:1516:1518:1534:1540:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2525:2560:2563:2682:2685:2693:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3152:3867:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4250:4321:5007:6117:6261:6653:6742:8957:9025:9969:10004:10400:11026:11473:11658:11914:12043:12297:12438:12555:12895:12986:13069:13180:13229:13311:13357:14181:14394:14659:14721:21080:21444:21451:21627:21966:30054,0,RBL:209.85.219.74:@flex--andreyknvl.bounces.google.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100;04y8wx15snwemgmgtj474nh91rdkryc37z1abmtubhs469nps5zg114qfon6t1w.sczkcuhhof57c9qf7jei11canqsacnzz3qh95sy5cu7npadajtnc4ohnujur9op.g-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0. 5,0.5,Ne X-HE-Tag: whip40_0e1114926fa6 X-Filterd-Recvd-Size: 3993 Received: from mail-qv1-f74.google.com (mail-qv1-f74.google.com [209.85.219.74]) by imf27.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 12:41:43 +0000 (UTC) Received: by mail-qv1-f74.google.com with SMTP id p15so15325306qvv.7 for ; Tue, 04 Aug 2020 05:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=r3AVQip2xq9L4iLlC84/aNvGhdtcJ5cWyH3sWORBbtc=; b=al711nch3pGhu0oC1wlPaqYQVlVmmhVzmYHp/7d5LETFi5Rtuy1m2i6Q7VZyHZWzvU hgxHf9w/ckVjXi3fhG4d+LBft5K89LkjnHbAbhqXdJQf+gaDGnDI0gAmQvywiJ+Vcfpq fXUe1mXmVqZwCTV/bjfqcfsyDvqhOVJmyD48Oj7Db+FICYod8rKgX7Xwry1oDf2wkEup RR75P7hQf3YSyhtdZQyTtr0fFU1zbFApwbVSnzym/MadtAc0yGXWKQ+A2mW0MAhYz+R7 l9TXw52PMyujrl18cxAUf/X+TsTelw+wmXc4IeyF7EmwiAsMBbLJcMRtX980kmLZ8TUT wSNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=r3AVQip2xq9L4iLlC84/aNvGhdtcJ5cWyH3sWORBbtc=; b=SO5iC6qIDXMekf0P6iWHCDsm7HAnqtb/8t1SDzwwKxePqjkD3eVFlt19I4OKK7rbM9 oFIOIAl/p5YF2fG9Xx3H2NfLepWVHh/Wz8LnfaQc+lYziDn5TJpp5a1m/EdjAO5cIDY0 gcaHTcOmuJ8Ro/miBnDideLEKCTe1WX6E2233TYCeAkigpE7jfpwqzn16lKKUNVMKDgJ BcPqP85Yvd9dBYXzpp/RG/RLevpE4p5UX4xmOif3U6J+ezLBpDiz9d/SJtchVBi1L7Rj pfai30Led0S7iROjMC+UqzRmFsNSW5qBAKSvDWSBDASJTowK8bt2aHy+vKr0Y03C+ZLt Sh4g== X-Gm-Message-State: AOAM532vmzeWMuIRZemUumxOK9KEItygvRWRQjTHa38EM8PlleBuldOY F0auzNOjEXtDryyrAXLmJdt3g1xTy+b1S2i+ X-Google-Smtp-Source: ABdhPJxNVNohw+RMFq1uv1gOt0ICKpmDjLXFJp+5X/8n8NGst2h3rqGrz443ENowh4INA9/32k2O/16zVxLTFGJ0 X-Received: by 2002:ad4:438e:: with SMTP id s14mr21419425qvr.18.1596544902628; Tue, 04 Aug 2020 05:41:42 -0700 (PDT) Date: Tue, 4 Aug 2020 14:41:27 +0200 In-Reply-To: Message-Id: <99f7d90a4237431bf5988599fb41358e92876eb0.1596544734.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH v2 4/5] kasan: allow enabling stack tagging for tag-based mode From: Andrey Konovalov To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Ard Biesheuvel , Arvind Sankar , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Walter Wu , Elena Petrova , Vincenzo Frascino , Catalin Marinas , Andrey Konovalov X-Rspamd-Queue-Id: CB86E100471EF X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use CONFIG_KASAN_STACK to enable stack tagging. Note, that HWASAN short granules [1] are disabled. Supporting those will require more kernel changes. [1] https://clang.llvm.org/docs/HardwareAssistedAddressSanitizerDesign.html Signed-off-by: Andrey Konovalov --- scripts/Makefile.kasan | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/Makefile.kasan b/scripts/Makefile.kasan index 03757cc60e06..f4beee1b0013 100644 --- a/scripts/Makefile.kasan +++ b/scripts/Makefile.kasan @@ -44,7 +44,8 @@ else endif CFLAGS_KASAN := -fsanitize=kernel-hwaddress \ - -mllvm -hwasan-instrument-stack=0 \ + -mllvm -hwasan-instrument-stack=$(CONFIG_KASAN_STACK) \ + -mllvm -hwasan-use-short-granules=0 \ $(instrumentation_flags) endif # CONFIG_KASAN_SW_TAGS From patchwork Tue Aug 4 12:41:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrey Konovalov X-Patchwork-Id: 11700355 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 451BE722 for ; Tue, 4 Aug 2020 12:41:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 22FAC208A9 for ; Tue, 4 Aug 2020 12:41:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ea5YjJ7o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22FAC208A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C5CD58D015B; Tue, 4 Aug 2020 08:41:46 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id C0A208D0081; Tue, 4 Aug 2020 08:41:46 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF86B8D015B; Tue, 4 Aug 2020 08:41:46 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 936D58D0081 for ; Tue, 4 Aug 2020 08:41:46 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 67DD4824805A for ; Tue, 4 Aug 2020 12:41:46 +0000 (UTC) X-FDA: 77112847812.10.quiet05_4515ef026fa6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 3CC1516A040 for ; Tue, 4 Aug 2020 12:41:46 +0000 (UTC) X-Spam-Summary: 1,0,0,3690ecbfdd5faf3c,d41d8cd98f00b204,3ifcpxwokcns7kaobvhksidlldib.9ljifkru-jjhs79h.lod@flex--andreyknvl.bounces.google.com,,RULES_HIT:41:152:355:379:541:800:960:973:988:989:1260:1277:1313:1314:1345:1359:1431:1437:1516:1518:1534:1539:1568:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2901:3138:3139:3140:3141:3142:3152:3865:3866:3867:4321:5007:6261:6653:6742:9969:10004:10400:11026:11473:11658:11914:12043:12297:12555:12895:13069:13311:13357:14181:14394:14659:14721:21080:21444:21451:21627:30054,0,RBL:209.85.160.202:@flex--andreyknvl.bounces.google.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100;04yf1gmdxabhk84a88yno877frufmocqdqhzu94g64374u3ygc4u6wdpoz1txxs.9wo4mpijo339jzpwxwodcs7mp3knrtyk6x19bdey3bneqoc6akahh17k1aubj1k.a-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:25,LUA_SUMMARY:none X-HE-Tag: quiet05_4515ef026fa6 X-Filterd-Recvd-Size: 3873 Received: from mail-qt1-f202.google.com (mail-qt1-f202.google.com [209.85.160.202]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 4 Aug 2020 12:41:45 +0000 (UTC) Received: by mail-qt1-f202.google.com with SMTP id h10so29237681qtc.4 for ; Tue, 04 Aug 2020 05:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=OJV+wFsSuBAEdua9Kpud4j6ZGzVdRXqmU9/PZhjVLdc=; b=Ea5YjJ7o620kZq8eHnshiekvC4wpoxtU/m2L83KMHr56wGFqcLIiluwTTPIuK6jPtz NIbahZxx/kLpiZOWX4LifN1sYL8ve+GY+nJ4uXKX/NwgeJ66FB0oBHFDCJ7CnFI+jXp5 YfjHAXZMMGH3A1RBkM5ekVG/ygZ56FsWNDeUBLLVL1ABwVsRZPV6DZg8v5EyPdnyI/8q u9+woephvoS6hP7AP7QtlnSDcnrQ3oLlLY/jprakwQVQNuaNzYsx0faunrqjJ1Rwi828 vpjJ63tAJJETQeQAfpWW300WdlbW294wpGLA7b0wjZ0R/4TF1hESmC/l3kgC9ReY8bHQ oJZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=OJV+wFsSuBAEdua9Kpud4j6ZGzVdRXqmU9/PZhjVLdc=; b=pXpZNNTNa0q0aZRbUAPI/KBJq80+DSPxzHGifNsX+11wRS4EXXH6X/iu68CJ6p+fNM vFFxltc1vsTltAROrkxFG2UNgWhJ7fpjx+BbVtw4s11jukGSD+ceALuiqLL0G3UL8wPp DVdZoUC8HPyGT+HQboOn0hwhHclq8BGajlcbemVgOq+fnBARsQhDpZIGDZbx8sN7bzQC z7X7XC3yfHpnTYMeon/aYf0MR/adUpEQ2NRYtfn8cfPiB6d0c0NmRn3sYCH16HHo77R4 QLgI87z3QAX61ds3MH5c1zfKnsdGnqCzJ9a4YaVV20QMU6HxbwMwdz+Z+CX2QVG5qwSl /q9w== X-Gm-Message-State: AOAM532TH/ogEFM6WQcbNlY3dIGInYatkW5F4V6MD7lWh4t4w1r6bVGE g4i2yC9hmJL1oQeGotYEHfakVViyay2TR3ax X-Google-Smtp-Source: ABdhPJxMCD1uy5OtH/rfQcGvmBrhxSjZNftrKmDoPQf463mdE8fRrlNv8GbsPVw+FCZ38SV1RL/Err4XbOOp0GEM X-Received: by 2002:a0c:b604:: with SMTP id f4mr15297001qve.68.1596544904936; Tue, 04 Aug 2020 05:41:44 -0700 (PDT) Date: Tue, 4 Aug 2020 14:41:28 +0200 In-Reply-To: Message-Id: <3063ab1411e92bce36061a96e25b651212e70ba6.1596544734.git.andreyknvl@google.com> Mime-Version: 1.0 References: X-Mailer: git-send-email 2.28.0.163.g6104cc2f0b6-goog Subject: [PATCH v2 5/5] kasan: adjust kasan_stack_oob for tag-based mode From: Andrey Konovalov To: Andrew Morton Cc: Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Ard Biesheuvel , Arvind Sankar , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Walter Wu , Elena Petrova , Vincenzo Frascino , Catalin Marinas , Andrey Konovalov X-Rspamd-Queue-Id: 3CC1516A040 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Use OOB_TAG_OFF as access offset to land the access into the next granule. Suggested-by: Walter Wu Signed-off-by: Andrey Konovalov --- lib/test_kasan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/test_kasan.c b/lib/test_kasan.c index 7674616d0c37..5d3f496893ef 100644 --- a/lib/test_kasan.c +++ b/lib/test_kasan.c @@ -488,7 +488,7 @@ static noinline void __init kasan_global_oob(void) static noinline void __init kasan_stack_oob(void) { char stack_array[10]; - volatile int i = 0; + volatile int i = OOB_TAG_OFF; char *p = &stack_array[ARRAY_SIZE(stack_array) + i]; pr_info("out-of-bounds on stack\n");