From patchwork Wed Aug 5 07:52:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rolf Eike Beer X-Patchwork-Id: 11701527 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A38131392 for ; Wed, 5 Aug 2020 07:57:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A74921744 for ; Wed, 5 Aug 2020 07:57:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727801AbgHEH5z convert rfc822-to-8bit (ORCPT ); Wed, 5 Aug 2020 03:57:55 -0400 Received: from mx1.emlix.com ([188.40.240.192]:45506 "EHLO mx1.emlix.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726690AbgHEH5z (ORCPT ); Wed, 5 Aug 2020 03:57:55 -0400 X-Greylist: delayed 328 seconds by postgrey-1.27 at vger.kernel.org; Wed, 05 Aug 2020 03:57:55 EDT Received: from mailer.emlix.com (unknown [81.20.119.6]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.emlix.com (Postfix) with ESMTPS id 818925FCA2; Wed, 5 Aug 2020 09:52:25 +0200 (CEST) From: Rolf Eike Beer To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ralf Baechle , Paul Burton , Alexander Viro Subject: [PATCH] binfmt_elf: fix documented return value for load_elf_phdrs() Date: Wed, 05 Aug 2020 09:52:23 +0200 Message-ID: <6469675.ETGqQKjL3G@devpool35> Organization: emlix GmbH MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org This function has never returned anything but a plain NULL. Fixes: 6a8d38945cf4e6e819d6b550250615db763065a0 Signed-off-by: Rolf Eike Beer --- fs/binfmt_elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 9fe3b51c116a..251298d25c8c 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -428,7 +428,7 @@ static int elf_read(struct file *file, void *buf, size_t len, loff_t pos) * * Loads ELF program headers from the binary file elf_file, which has the ELF * header pointed to by elf_ex, into a newly allocated array. The caller is - * responsible for freeing the allocated data. Returns an ERR_PTR upon failure. + * responsible for freeing the allocated data. Returns NULL upon failure. */ static struct elf_phdr *load_elf_phdrs(const struct elfhdr *elf_ex, struct file *elf_file)