From patchwork Wed Aug 5 17:49:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11702029 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D47E61392 for ; Wed, 5 Aug 2020 17:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFDB521D95 for ; Wed, 5 Aug 2020 17:53:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q9JV4kpY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728890AbgHERxd (ORCPT ); Wed, 5 Aug 2020 13:53:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728846AbgHERtu (ORCPT ); Wed, 5 Aug 2020 13:49:50 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EC58C06174A for ; Wed, 5 Aug 2020 10:49:50 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id kr4so4957300pjb.2 for ; Wed, 05 Aug 2020 10:49:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I2x4nvf5u7YHLs/rvuQ2DKG/frGYuFxUPbbH8Ur2AHA=; b=Q9JV4kpY6x7rr59uNFknHTktXpZHrdBEwVgs+pj6+tYbhXtD+8Vq1jpB/CE8Rtrq01 yw00178LCzj72/VhQ8kxltmhrJLUabo5c0ZBaKhD4q0YRTZbiSsgXK3uzf8DMxz2br0z 29f7LNQHVjlyR8Cvg1XCtXYSGWssp3eeqBwNaLtZi5wkBV35Wvst1QZKEiS7ndrC8eBx BhqWqm0u016gQVy/eJAcsY5ugtuzwf9sqtWaIXnZcXMxR1/w+AYBNWgLyGnE701FEekH Q836879ssjjMrVB3vY0p62ZC4x2N5wJjgTDmFASgpayL7Tlhqojx5VJ1tG3ZkOpgo4Dg jrNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I2x4nvf5u7YHLs/rvuQ2DKG/frGYuFxUPbbH8Ur2AHA=; b=KxoxhxyMgmvspQQFP1nucawUSOhQYSswUvGzmgGsFHQH3o2irYqKHcKa/JZhU04sFd 5hX3UWZdCA6uDYYnLwFXQb4dfjqW+rJI/9bI06tzS76Y5X5GSfz3oQdyCilKGqQ67OT1 w2uudGmg2EGiYoIuhR7kyW2J2RrgYQ7yfewFGDvquwT3RBAat0GG8layDJkd748lULUO 2HC1B6jfyJPzUnSPvW55mmTeS/ypQVIBe3NIcon0E7q5RaVxInaXA6XUto6sdyZd1Jpb f42nTfdrwmjWnW6HXWDCBrCg5l7IeE8hFHkZGkvxujV22h2QbTOl68z7hN2QF0Y4vSSP Ye2Q== X-Gm-Message-State: AOAM531SAHCfGU/JF6MI1VOX6DBRKR5s0l+SCsQElZrBRZYElP7ug5na TsZXdQfmu2eoyNWABIHHxL+/F7MC2PM= X-Google-Smtp-Source: ABdhPJxfwwMkBIF1+5vLBRuEbMmCW6fEBxC03R+3/Pm+Kg/L8z5R8VFNrKIvHPZwWE9lHNf2nMLI4Q== X-Received: by 2002:a17:90a:f313:: with SMTP id ca19mr4575429pjb.226.1596649789229; Wed, 05 Aug 2020 10:49:49 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.185]) by smtp.gmail.com with ESMTPSA id z77sm4765150pfc.199.2020.08.05.10.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 10:49:48 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, christian.couder@gmail.com, kaartic.sivaraam@gmail.com, johannes.schindelin@gmx.de, liu.denton@gmail.com, Shourya Shukla , Christian Couder Subject: [PATCH 1/4] t7401: modernize style Date: Wed, 5 Aug 2020 23:19:18 +0530 Message-Id: <20200805174921.16000-2-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200805174921.16000-1-shouryashukla.oo@gmail.com> References: <20200805174921.16000-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The tests in 't7401-submodule-summary.sh' were written a long time ago and have some violations with respect to our CodingGuidelines such as incorrect spacing in usages of the redirection operator and absence of line feed between statements in case of the '|' (pipe) operator. Update it to match the CodingGuidelines. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 9bc841d085..4439fb7c17 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -16,12 +16,13 @@ add_file () { owd=$(pwd) cd "$sm" for name; do - echo "$name" > "$name" && + echo "$name" >"$name" && git add "$name" && test_tick && git commit -m "Add $name" done >/dev/null - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --verify HEAD | + cut -c1-7 cd "$owd" } commit_file () { @@ -125,7 +126,8 @@ commit_file sm1 && head3=$( cd sm1 && git reset --hard HEAD~2 >/dev/null && - git rev-parse --verify HEAD | cut -c1-7 + git rev-parse --verify HEAD | + cut -c1-7 ) test_expect_success 'modified submodule(backward)' " From patchwork Wed Aug 5 17:49:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11702023 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D9A9B14DD for ; Wed, 5 Aug 2020 17:52:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BBB912173E for ; Wed, 5 Aug 2020 17:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZSkqnsZo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728915AbgHERwa (ORCPT ); Wed, 5 Aug 2020 13:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728854AbgHERt4 (ORCPT ); Wed, 5 Aug 2020 13:49:56 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD8D9C0617A0 for ; Wed, 5 Aug 2020 10:49:55 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id i92so3467822pje.0 for ; Wed, 05 Aug 2020 10:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C1JuxiEFbBgSuA8iGZ0RpKI2x/jJRiy3MfqRBbgyn/Q=; b=ZSkqnsZo1UlwCZiHl6dLPCIezaQVGtRHmvsmJGTx/ifi9kdeJdOq0+b5YFlKNHEQ3R a88CdxopT6LfEPl1DPGdI4u1WPCpGtENDo9JHX3SmDCOdZd/+pSWJmLvJlg3s4CbsPsI /lLLitOxD8MF9CVrbcvOCQFbWlh+YMr1UbsIffmPO9k1/8Pgq+tLL2sZbVR6OFz4LRS4 e4e/BfTRSKmAvTawVq7cUdylB9t7Sfshzckn683bqSww5KvpwIUx57Z04W88xfgKbL46 nQGyvHRifRYNemGQuBySoiZmahfVsj9fxubfetUEM83sIg9xxf0mHf+7i0NFkM4o4NQ2 jzMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C1JuxiEFbBgSuA8iGZ0RpKI2x/jJRiy3MfqRBbgyn/Q=; b=l7osxsCARPyfYklfpVpNKWB+fiGoVAElkr2ddLo+VtFfh/LOZEwGP3C5Wjx0ET26Bv 09Cm8zu3GuzAkSRV+fY8ChxYvNhQONR4gEuOZ4lHVaxWnOMqIDuJw027Es3gXqBlqutz oGbMqEgcq5eAhxxBzgY2ZCOGTzV2rxB6TK09IdhnOaKFqj29ipKHIneeDEsPVM2jMLLh k/MKppBivV0Yhr48EIiAOI1tfJW2Zai3Pkr84t3tjq4oe+GAkaES5xAUwT+jh9hnXi4D Qc09zWYF0GRTgGRWUxuJvaiXHtQfKFfuA50pSPQiZ+vJvNgyyjoyDFr6cAfqPH1gyS0I ISYg== X-Gm-Message-State: AOAM532lsQbYHCJnW9P//sJcFmYfveamLbNRtujy0J8fWcpy/IaOp2A/ CsORk6cQabMWfW5Cjxa8wHv4/NQ03Sc= X-Google-Smtp-Source: ABdhPJwAUPUOpXjh6Fm0q1brexieUYu+s9WwH71m52Qtl+vfqk/4lXQ2QzlDjCfVAEJwbtVzas+M+g== X-Received: by 2002:a17:90a:9f44:: with SMTP id q4mr4587514pjv.66.1596649793104; Wed, 05 Aug 2020 10:49:53 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.185]) by smtp.gmail.com with ESMTPSA id z77sm4765150pfc.199.2020.08.05.10.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 10:49:52 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, christian.couder@gmail.com, kaartic.sivaraam@gmail.com, johannes.schindelin@gmx.de, liu.denton@gmail.com, Shourya Shukla , Christian Couder Subject: [PATCH 2/4] t7401: change test_i18ncmp syntax for clarity Date: Wed, 5 Aug 2020 23:19:19 +0530 Message-Id: <20200805174921.16000-3-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200805174921.16000-1-shouryashukla.oo@gmail.com> References: <20200805174921.16000-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Change the test_i18ncmp syntax from 'test_i18ncmp actual expected' to 'test_i18ncmp expected actual' to align it with the convention followed by other tests in the test script. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla Signed-off-by: Taylor Blau --- t/t7401-submodule-summary.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 4439fb7c17..18fefdb0ba 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -183,7 +183,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --cached' " < Add foo5 EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " test_expect_success 'typechanged submodule(submodule->blob), --files' " @@ -193,7 +193,7 @@ test_expect_success 'typechanged submodule(submodule->blob), --files' " > Add foo5 EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " rm -rf sm1 && @@ -204,7 +204,7 @@ test_expect_success 'typechanged submodule(submodule->blob)' " * sm1 $head4(submodule)->$head5(blob): EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " rm -f sm1 && @@ -217,7 +217,7 @@ test_expect_success 'nonexistent commit' " Warn: sm1 doesn't contain commit $head4_full EOF - test_i18ncmp actual expected + test_i18ncmp expected actual " commit_file From patchwork Wed Aug 5 17:49:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11702019 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E053614DD for ; Wed, 5 Aug 2020 17:52:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD6F42073E for ; Wed, 5 Aug 2020 17:52:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZsZK8jgH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729000AbgHERwF (ORCPT ); Wed, 5 Aug 2020 13:52:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728856AbgHERuB (ORCPT ); Wed, 5 Aug 2020 13:50:01 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F6A0C0617A1 for ; Wed, 5 Aug 2020 10:49:57 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id q17so25676876pls.9 for ; Wed, 05 Aug 2020 10:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=whHTi2PgYuIlHWf9MWsZT104mUeL4Ulx6vg3RpDG9VI=; b=ZsZK8jgHetoHDIzepqTfdpLISDLvcJqvWWCz5gYIqrbNniJA79cC1L/9KtMk4yRT5+ nUMqfqGSpINC7ORF5OhjWoXfzkL6jPtb2Z6ctExFQihX46lDMrTZwESxyQkU8Pp4nUEu T63wEJaF7/LvWPztA4jOrbraJYfhIQkLTvbmy28n0Ul1O1ggUZVIPFP5RctmIKGf/Ek8 Ct5mCZjOH+NKd/OS7TJUlUitZAxdzJ2K1i3NBFjtiv8YUqFOzCG+CbMKl78s0rsKtzz2 YWkQiicxoJUsOPMrL8cDhs251/xq+U1QPOQnLYvKuiLc4AtbBKZypvboFP3Gj6Qdjve8 jQHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=whHTi2PgYuIlHWf9MWsZT104mUeL4Ulx6vg3RpDG9VI=; b=hQpXOlboRe9LAbFBK9XRVqRJk0XDXr1VdCf//zVhLqBimX85io8VUMRJ+9//DL6X9q /3xU3OR1QzTMkVv2tAgqpxLY9P8217YKzknZHSquote2rUdcU6IW5vdGnIgZke21h1ri H7S4yE40JFVVcrhgLfqQRXvYyJlgqI7J9cKjwYx7MBrazB6haUKCOF0irqtmXSywnCIr p251atE1b82YMOVZKS6CjQp0pxIG6Bnm2c1RQpbvSWrgvw5tz5QJPV3WtX/GQOilJc8/ IQEJRZDLI9jvxI9KbxFCLOySQ1+mxFAWXQvaOCHGkJg84zonkKJAlWWHrbzfXSelRAbY Z2eA== X-Gm-Message-State: AOAM5307phmLmQ0hFzQlITCR/HYLAwYcCaBlYH3Hh5pUQ6/ruVk9nC+1 b6ZQedzZxEv3A2eRh9P6szaSVYwSUIc= X-Google-Smtp-Source: ABdhPJwIwAUXSSGDLvs0zTr0I5Aix3RWgDm0bPf60TQnk8xPwlOu6fLTqq9cVhcafcdm/xYsqHTxPg== X-Received: by 2002:a17:90b:4d06:: with SMTP id mw6mr4570666pjb.226.1596649796595; Wed, 05 Aug 2020 10:49:56 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.185]) by smtp.gmail.com with ESMTPSA id z77sm4765150pfc.199.2020.08.05.10.49.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 10:49:55 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, christian.couder@gmail.com, kaartic.sivaraam@gmail.com, johannes.schindelin@gmx.de, liu.denton@gmail.com, Shourya Shukla , Christian Couder Subject: [PATCH 3/4] t7401: ensure uniformity in the '--for-status' test Date: Wed, 5 Aug 2020 23:19:20 +0530 Message-Id: <20200805174921.16000-4-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200805174921.16000-1-shouryashukla.oo@gmail.com> References: <20200805174921.16000-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org The '--for-status' test got its expected output from stdin. This is inconsistent with the other tests in the test script which get their expected output from a file named 'expected'. So, change the syntax of the '--for-status' test for uniformity. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 18fefdb0ba..145914cd5a 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -285,13 +285,14 @@ EOF test_expect_success '--for-status' " git submodule summary --for-status HEAD^ >actual && - test_i18ncmp actual - <expected <<-EOF && * sm1 $head6...0000000: * sm2 0000000...$head7 (2): > Add foo9 EOF + test_i18ncmp expected actual " test_expect_success 'fail when using --files together with --cached' " From patchwork Wed Aug 5 17:49:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shourya Shukla X-Patchwork-Id: 11702021 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF25A1392 for ; Wed, 5 Aug 2020 17:52:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9EF52173E for ; Wed, 5 Aug 2020 17:52:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Jt+Pj6Nl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729042AbgHERwL (ORCPT ); Wed, 5 Aug 2020 13:52:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728858AbgHERuG (ORCPT ); Wed, 5 Aug 2020 13:50:06 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DABF7C0617A2 for ; Wed, 5 Aug 2020 10:50:01 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id y206so12863167pfb.10 for ; Wed, 05 Aug 2020 10:50:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CzQP0fpTEenofZBakSUNThJaAXN5CPnFNEIP1yxLOdU=; b=Jt+Pj6Nl0wgKUMBhM1rt4JIgtwadLKRX0d52QEBy2ZeF1MyVwelQtHcbd7Ukser+bu YmTwYAQV6cUJsIQYQ45kWBraQhQrtTEhBoPEgVqfDREsmNU3qQCsnuS6RCd2oSrJGf1a PYIG0WSJLGQn5LRmqgYmnkDTB+oJRMPOZTGXQ61yQFFymGtHfOqxjJzOcCslXLPlCWuw EW0Q89CEBMdIScb0f9tJCZG1rgneuHOiTZ9FjhgO/cCe7tIY72wKHdSjZm1tn8QGmO4q W9RyVGLp5/AnVcEkbqeYOtX4nw53MrC1gwK0XTpFHGSxHKvsjP4xOSKQQBWHALRCFry+ XgkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CzQP0fpTEenofZBakSUNThJaAXN5CPnFNEIP1yxLOdU=; b=RYT5Gz/AzEo9BEpQEqt1c+FT1zcNP1YwPxnUMSAknJcsFseN+//dQWuOx8+FlszM+x Co9atEvmsv0WXhqU27BYs8MQb05Lqnkpygqa5jKpmoKeaw6MnXjsZgbTkBb8Ii4yGeyp udDO1SDJE+71ywpGuLW5UBpdwKAIyYn5O+FNeMLasdBm4QHOWYcvGHNwNwsY00Eqs8z/ G+L+CDJLPfyi7jeiQZpVCuqFPhskk6yLi0wkUPHRFNCkNTTY/jDxgEaUWJ25vRJX5afX 1HiWpquCM0Qu0Hiqmb6bXoFq8aaIY0LcRtLZX4mlSEjaWMfNlD6Ist5j140eGyHgLZMD UYlg== X-Gm-Message-State: AOAM530IiDzVqtdlZ+zz2IIesAkLvgEZsimNAeDZKQZq5F0I06bM3mEm h/iwD/1N5B8OnvE9qd/ucPC68g/Pgo4= X-Google-Smtp-Source: ABdhPJy9byliB9mnGOaM9B4B3RjuoqyTuPyB9xaYfv18sRJWti3PuBnXNb2PRiqpXyBShsmhWt/TTw== X-Received: by 2002:a65:6817:: with SMTP id l23mr3973522pgt.428.1596649800477; Wed, 05 Aug 2020 10:50:00 -0700 (PDT) Received: from localhost.localdomain ([45.127.46.185]) by smtp.gmail.com with ESMTPSA id z77sm4765150pfc.199.2020.08.05.10.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 10:49:59 -0700 (PDT) From: Shourya Shukla To: git@vger.kernel.org Cc: gitster@pobox.com, christian.couder@gmail.com, kaartic.sivaraam@gmail.com, johannes.schindelin@gmx.de, liu.denton@gmail.com, Shourya Shukla , Christian Couder Subject: [PATCH 4/4] t7401: add a WARNING and a NEEDSWORK Date: Wed, 5 Aug 2020 23:19:21 +0530 Message-Id: <20200805174921.16000-5-shouryashukla.oo@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200805174921.16000-1-shouryashukla.oo@gmail.com> References: <20200805174921.16000-1-shouryashukla.oo@gmail.com> MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Add a WARNING regarding the usage of 'git add' instead of 'git submodule add' to add submodules to the superproject. Also add a NEEDSWORK regarding the outdated syntax and working of the test, which may need to be improved to obtain better and desired results. While at it, change the word 'test' to 'test script' in the test description to avoid ambiguity. Mentored-by: Christian Couder Mentored-by: Kaartic Sivaraam Signed-off-by: Shourya Shukla --- t/t7401-submodule-summary.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t/t7401-submodule-summary.sh b/t/t7401-submodule-summary.sh index 145914cd5a..2db4cf5cbf 100755 --- a/t/t7401-submodule-summary.sh +++ b/t/t7401-submodule-summary.sh @@ -5,8 +5,13 @@ test_description='Summary support for submodules -This test tries to verify the sanity of summary subcommand of git submodule. +This test script tries to verify the sanity of summary subcommand of git submodule. ' +# WARNING: This test script uses 'git add' instead of 'git submodule add' to add +# submodules to the superproject. Some submodule subcommands such as init and +# deinit might not work as expected in this script. + +# NEEDSWORK: This test script is old fashioned and may need a big cleanup. . ./test-lib.sh