From patchwork Mon Aug 17 06:54:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marius Zachmann X-Patchwork-Id: 11716499 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 514E1618 for ; Mon, 17 Aug 2020 06:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3DAFF207DF for ; Mon, 17 Aug 2020 06:54:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726171AbgHQGyg (ORCPT ); Mon, 17 Aug 2020 02:54:36 -0400 Received: from ms-10.1blu.de ([178.254.4.101]:55070 "EHLO ms-10.1blu.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726196AbgHQGyf (ORCPT ); Mon, 17 Aug 2020 02:54:35 -0400 Received: from [78.43.71.214] (helo=marius.fritz.box) by ms-10.1blu.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k7Z2O-0005sJ-9z; Mon, 17 Aug 2020 08:54:32 +0200 From: Marius Zachmann To: Guenter Roeck Cc: Marius Zachmann , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] hwmon: corsair-cpro: fix ccp_probe, add delay Date: Mon, 17 Aug 2020 08:54:28 +0200 Message-Id: <20200817065428.5974-1-mail@mariuszachmann.de> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Con-Id: 241080 X-Con-U: 0-mail X-Originating-IP: 78.43.71.214 Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Possibly because of the changes in usbhid/hid-core.c the first raw input report is not received during ccp_probe function and it will timeout. I am not sure, whether this behaviour is expected after hid_device_io_start or if I am missing something. As a solution this adds msleep(50) to ccp_probe so that all initial input reports can be received. Signed-off-by: Marius Zachmann --- drivers/hwmon/corsair-cpro.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.28.0 diff --git a/drivers/hwmon/corsair-cpro.c b/drivers/hwmon/corsair-cpro.c index 591929ec217a..6359409e6c71 100644 --- a/drivers/hwmon/corsair-cpro.c +++ b/drivers/hwmon/corsair-cpro.c @@ -10,6 +10,7 @@ #include #include +#include #include #include #include @@ -513,8 +514,8 @@ static int ccp_probe(struct hid_device *hdev, const struct hid_device_id *id) init_completion(&ccp->wait_input_report); hid_device_io_start(hdev); + msleep(50); /* make sure, events can be received */ - /* temp and fan connection status only updates when device is powered on */ ret = get_temp_cnct(ccp); if (ret) goto out_hw_close;