From patchwork Mon Aug 17 08:34:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717009 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CBF4215E6 for ; Mon, 17 Aug 2020 08:35:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B28B920758 for ; Mon, 17 Aug 2020 08:35:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mGaGN7JD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgHQIfd (ORCPT ); Mon, 17 Aug 2020 04:35:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbgHQIf2 (ORCPT ); Mon, 17 Aug 2020 04:35:28 -0400 Received: from mail-pj1-x1044.google.com (mail-pj1-x1044.google.com [IPv6:2607:f8b0:4864:20::1044]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FBDAC061388; Mon, 17 Aug 2020 01:35:28 -0700 (PDT) Received: by mail-pj1-x1044.google.com with SMTP id f9so7349135pju.4; Mon, 17 Aug 2020 01:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4nhWNM41f6BjKWP46DMIjPsIWGEGdOxdBi1jSC7XG8s=; b=mGaGN7JDJGgy/1WQUsKWaFTCgtC3rJsf9uTrL9370PCWKVjEpcQy9EI/xP8rVxFxDN DQIhtVNRxYd5wR3QuC/KZMts9WZPnoOmndIBmz7t+lB5n2DbwECCodBm/tqN8abCMd6W fKb81wMBVASTh9+YpvzvixeJADKQDAghKJ6T+AfCHs0fJnmHRSROgh+427SAETCDabE0 wt/mq0Z0DSqoHRUV9ZP3QzDHRLfplHZASTF3VWCHLT91w/d4h9XdXJm3+VCD5/vN2Jgn oEVypkDuBgsJrkHGE34tWKfqOJ3q+LX0nQ533oYNCTnFYVd4RZwp3maByR+ZeuvpmDue 63Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4nhWNM41f6BjKWP46DMIjPsIWGEGdOxdBi1jSC7XG8s=; b=cOcz8LI3ZNLbzvBXzBQpF8pkCXEjI3Iz/SY/8Kntp0/NWTADnATiP3/wC7Y/WV1D8z +0tXbNxjR+na0JJQOkgfv1NL/gNSDbF0PdPTiaWt5JUEjhOl/VSQK8YLGiTqzRo2zVT2 2y4kAKmW+EpO22+pZvy+42BHhPxVRzCmNLTIY+ylIOkQ6m3x/GRUVFSn9Tl9Ddm4KDIl t79Id1944dMl0YX0zZnulkvFs89QV+8GhgQ5Xo3EifwCFL9SNF2Ei33nyBsHvZHcHcF/ S7jmd/kFyraq0ESy4eM1tSytljV3NPRxII9UlmrdVzK5iWVrQoQo351XZFgO8Mt+6ypZ Z7qg== X-Gm-Message-State: AOAM532c6GInJdGUKMJNd8lWWePkCr8PHfFeQcN+waWGMyGmNeSO2I6s CuaT8Hwu0jn0b2mBXf0E2UU= X-Google-Smtp-Source: ABdhPJwpxyd4w90B/LHzc3wDMjJl+AoxneVsdWqfIUr98hR55sv5bW17uf9nyFyU9tMklV2BSez1zg== X-Received: by 2002:a17:90a:ce94:: with SMTP id g20mr11462006pju.61.1597653327838; Mon, 17 Aug 2020 01:35:27 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:35:27 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 01/10] mmc: atmel-mci: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:04:59 +0530 Message-Id: <20200817083508.22657-2-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/atmel-mci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c index 300901415aa2..562cf8eb993f 100644 --- a/drivers/mmc/host/atmel-mci.c +++ b/drivers/mmc/host/atmel-mci.c @@ -1719,9 +1719,9 @@ static void atmci_detect_change(struct timer_list *t) } } -static void atmci_tasklet_func(unsigned long priv) +static void atmci_tasklet_func(struct tasklet_struct *t) { - struct atmel_mci *host = (struct atmel_mci *)priv; + struct atmel_mci *host = from_tasklet(host, t, tasklet); struct mmc_request *mrq = host->mrq; struct mmc_data *data = host->data; enum atmel_mci_state state = host->state; @@ -2496,7 +2496,7 @@ static int atmci_probe(struct platform_device *pdev) host->mapbase = regs->start; - tasklet_init(&host->tasklet, atmci_tasklet_func, (unsigned long)host); + tasklet_setup(&host->tasklet, atmci_tasklet_func); ret = request_irq(irq, atmci_interrupt, 0, dev_name(&pdev->dev), host); if (ret) { From patchwork Mon Aug 17 08:35:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717011 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91AC915E6 for ; Mon, 17 Aug 2020 08:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 783B320758 for ; Mon, 17 Aug 2020 08:35:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mQOBeB8C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726974AbgHQIfg (ORCPT ); Mon, 17 Aug 2020 04:35:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbgHQIfe (ORCPT ); Mon, 17 Aug 2020 04:35:34 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1D5DC061388; Mon, 17 Aug 2020 01:35:33 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id m8so7889972pfh.3; Mon, 17 Aug 2020 01:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rAOJk5hAnNSTtMtpLoIzCa/FRMXNkXbdNwc80PFZokA=; b=mQOBeB8ChJKLfDqljKxvSwd0PnjUQ/BzQtjNW+Vy75CCx4C8fMgCLCTYVvx/9Cssvt 4IhjIHcRFPRfhqSTsByu9w1sXrC1wCtZPqNOH8l5wzsu8DPA90RejbEjRGB7ut04Sf4m SEPe1a7Ht+NnKbrgDuwpX/nUCHWdaJ7cUbsp296LU8v14szu29bMbAI2UJQD22WPN8z3 OexS3K8eSgQcvQjFlrTQjviBQHPP9tPz+6F6qvMEHI54ffXhMnySJ5b3xCkYcd73RpBY yleGz36hUmGZ6IWL9gBoLqXA38kJsqBg34drXD/z5c32bzwi2Ijer3Vs2pCrHCwOXWd2 71qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rAOJk5hAnNSTtMtpLoIzCa/FRMXNkXbdNwc80PFZokA=; b=MgG9+2g5y2a47zzOs2OLrlDQuZcL/YPGRXNwB0ahXkYlbAkBXdszZUPgjZzM/8ONo4 DcdfVfNWNPhuA1n3DOu1so2nUXZ98cQg6QusjyPqzHSKY6qEISmTQBrtmrl+KhDTaUKt lj7x8HIAsVebbIVxp9yC3a/PtKyylkzXt0kLA0Uw8NllSKghM/7AIANGXN8WEBe+2f2j q/hDJctaghBd5kwpFWT08jg+kUWUCB42Oh2Weizl66512WlcGoqYDQ60jYk70OnkaV3Y OlaMZ30gjf5xKUwuW3ol5IfDjThLpk++jWgcG5mlgYXDm9HPpWYn5/K/FnxnnmbRJTub vwlA== X-Gm-Message-State: AOAM530fj5NFQMNnHU1ybONH8nv+lPNWsZ/B0Bld5nO0MezPdZkfJ9Wl XIZgO+Pli2JhZNOq7zHbzQ0= X-Google-Smtp-Source: ABdhPJwX90Sf9NZvTGYZLIPY9xPs/XEZFGxusM3axVnX2JhCX2YL40nrZXPNmTB/JCWj3HS3vwJg1g== X-Received: by 2002:a62:7c97:: with SMTP id x145mr10750592pfc.155.1597653332809; Mon, 17 Aug 2020 01:35:32 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:35:32 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 02/10] mmc: au1xmmc: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:00 +0530 Message-Id: <20200817083508.22657-3-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/au1xmmc.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/mmc/host/au1xmmc.c b/drivers/mmc/host/au1xmmc.c index 9bb1910268ca..f9b1d69290a3 100644 --- a/drivers/mmc/host/au1xmmc.c +++ b/drivers/mmc/host/au1xmmc.c @@ -253,9 +253,9 @@ static void au1xmmc_finish_request(struct au1xmmc_host *host) mmc_request_done(host->mmc, mrq); } -static void au1xmmc_tasklet_finish(unsigned long param) +static void au1xmmc_tasklet_finish(struct tasklet_struct *t) { - struct au1xmmc_host *host = (struct au1xmmc_host *) param; + struct au1xmmc_host *host = from_tasklet(host, t, finish_task); au1xmmc_finish_request(host); } @@ -363,9 +363,9 @@ static void au1xmmc_data_complete(struct au1xmmc_host *host, u32 status) au1xmmc_finish_request(host); } -static void au1xmmc_tasklet_data(unsigned long param) +static void au1xmmc_tasklet_data(struct tasklet_struct *t) { - struct au1xmmc_host *host = (struct au1xmmc_host *)param; + struct au1xmmc_host *host = from_tasklet(host, t, data_task); u32 status = __raw_readl(HOST_STATUS(host)); au1xmmc_data_complete(host, status); @@ -1037,11 +1037,8 @@ static int au1xmmc_probe(struct platform_device *pdev) if (host->platdata) mmc->caps &= ~(host->platdata->mask_host_caps); - tasklet_init(&host->data_task, au1xmmc_tasklet_data, - (unsigned long)host); - - tasklet_init(&host->finish_task, au1xmmc_tasklet_finish, - (unsigned long)host); + tasklet_setup(&host->data_task, au1xmmc_tasklet_data); + tasklet_setup(&host->finish_task, au1xmmc_tasklet_finish); if (has_dbdma()) { ret = au1xmmc_dbdma_init(host); From patchwork Mon Aug 17 08:35:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717013 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88AB715E6 for ; Mon, 17 Aug 2020 08:35:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7005B207FF for ; Mon, 17 Aug 2020 08:35:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e1rw46Ln" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727097AbgHQIfn (ORCPT ); Mon, 17 Aug 2020 04:35:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbgHQIfi (ORCPT ); Mon, 17 Aug 2020 04:35:38 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D366AC061388; Mon, 17 Aug 2020 01:35:37 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id 17so7877418pfw.9; Mon, 17 Aug 2020 01:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=V+IY+0oce77n1O9F863vvzmAh9cNOoW4gGZxQ9nHc9A=; b=e1rw46Ln24gbKIg1ppq0fzzVXv+VpHghXbf9lAKfxsr2UawmfLW2T3Xl68u/n+z6UG Yk6eKFTOewcDwbK7nj37Yi28tnPWUMuM8Zdi4LhoBtd/xVsrG4qMTxyDZMRuAFByZDT8 pO3mIG7wYETBil7GuCzpqOCMZ5OL3obKg7vcxk1RHnAaWZqzoW8eoW4NIXeChY/nwTBL dt+GgPbOBnmtOVgUsKR2Mpa3w7qYVsJy7/pzvaPTEqwLHImusixvOmei2RLFxo1E5vcx O5Na8zNOJ910dHmJggjQYKZfa+cfdwTQD5a6v03q8SDH4/5kD98zLOYkNu4O5y7z9+fg X1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=V+IY+0oce77n1O9F863vvzmAh9cNOoW4gGZxQ9nHc9A=; b=hnDYnOK1obVuWZfT5Aj2q/oZepkzpOMYIf1b99otDmA+ue6uE5BbQgMC8lCF3Zr5Uo jD8yToI9aY3qqAO5laQmDjUc670yuIMeFZzWl941THabeHbSvferkCWxSRCuRJ6nV84R e84JU9Pu1MJ5ZLNMVPlBvRYWg236RTOfGs3JjWzSAHQksfEjWUkiufvBNPszPcqDuMEn r5uFfa4QSCMqLQmOTG8BqgWxc9dISMmBgWELEq8rqQ8PN3WjimkN96mx6ius/Jkm/iNX ymy1JTtEiaQMSaZqGiQGg84yTO4V/zAeII5aOyPnBdbpSpkAlhNCNVesKFJk4dr0yFPf cWeQ== X-Gm-Message-State: AOAM5338W8OzyCfDBbjEKjuw3dOV3vr2IFcZgSlcj8Fyjw++6akW6QA8 EEew97AdikSLbT+HXOBW3qE= X-Google-Smtp-Source: ABdhPJxdR0X4pzjphQ0xJ24hWd4Gij3HiSYXjTekxa2x2+d2jVKzh0raQSM/vy36I48/+J21wkO35g== X-Received: by 2002:a63:2fc3:: with SMTP id v186mr9030009pgv.158.1597653337480; Mon, 17 Aug 2020 01:35:37 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:35:37 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 03/10] mmc: cb710: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:01 +0530 Message-Id: <20200817083508.22657-4-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/cb710-mmc.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/host/cb710-mmc.c b/drivers/mmc/host/cb710-mmc.c index e84ed84ea4cc..3e8fd2850794 100644 --- a/drivers/mmc/host/cb710-mmc.c +++ b/drivers/mmc/host/cb710-mmc.c @@ -646,11 +646,12 @@ static int cb710_mmc_irq_handler(struct cb710_slot *slot) return 1; } -static void cb710_mmc_finish_request_tasklet(unsigned long data) +static void cb710_mmc_finish_request_tasklet(struct tasklet_struct *t) { - struct mmc_host *mmc = (void *)data; - struct cb710_mmc_reader *reader = mmc_priv(mmc); + struct cb710_mmc_reader *reader = from_tasklet(reader, t, + finish_req_tasklet); struct mmc_request *mrq = reader->mrq; + struct mmc_host *mmc = mrq->host; reader->mrq = NULL; mmc_request_done(mmc, mrq); @@ -718,8 +719,8 @@ static int cb710_mmc_init(struct platform_device *pdev) reader = mmc_priv(mmc); - tasklet_init(&reader->finish_req_tasklet, - cb710_mmc_finish_request_tasklet, (unsigned long)mmc); + tasklet_setup(&reader->finish_req_tasklet, + cb710_mmc_finish_request_tasklet); spin_lock_init(&reader->irq_lock); cb710_dump_regs(chip, CB710_DUMP_REGS_MMC); From patchwork Mon Aug 17 08:35:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717017 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A0AC71744 for ; Mon, 17 Aug 2020 08:35:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 838B420758 for ; Mon, 17 Aug 2020 08:35:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gulnIYNf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbgHQIfu (ORCPT ); Mon, 17 Aug 2020 04:35:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727001AbgHQIfn (ORCPT ); Mon, 17 Aug 2020 04:35:43 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3F7AC061388; Mon, 17 Aug 2020 01:35:42 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id k13so7132165plk.13; Mon, 17 Aug 2020 01:35:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jhwHA9iT6gG9p11YNGvMfQK3PrAipcXrN5ECqFQlHWA=; b=gulnIYNfT0Y3CUDDfpjFjMeTf1Vv4n2l9IELuyJwpgh/sK6hHAB9WSl4g1yK+dN++o niutqyw7Mv7WRnHhuP22dgamV6479B8guvy56zDjbSVfSsbQwpGDZb+B117fGn+dvabP 0Jp6eR0JwsH1EHtBoUf1a0JE0x0Z01+H0kSMahkxo75Vu6CVg+CYUE24ehpKXvEuGlLS ufpqKFXZMNhIwLB1bPwGtxn8gQD2J2deloI2HP/mKeQLgwF+LspuhdRE4EDZsLtNzQ81 +wSfasi/h8GuN8f48tx8G0hp44NQTWzT4nejdhxLYmHMEvc/7DdCD3oQwYN9ZLcArqSU LZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jhwHA9iT6gG9p11YNGvMfQK3PrAipcXrN5ECqFQlHWA=; b=pWEArk775/zlkNtsXC2gF9WtbtEt0JEFRcbbTfPdbuDStbhqTjEOP/z7fR6KeyM7qa keN0R9u+tXRg+HnxwPAYIx3obIulRLuBf3HUd1vRwK6DMMrWg/NsvQQbFVPGXTp1aypm B+pa2uSXEyj8RAaVfM+MKLizmBqkl0bmFt8X7Ij/JOoVLUBabnrjhTLUDW06S6ghclXm wV1P9kldeLSJPGbsJj/iYfqyxdOsEwDJfCQFSLks265AgPRlgChQz38BtAnKl03ZaBKK 5SKIL2hWx8PE3eN/XN1qifiFHVa+7qpqlaRR8qXgPqsH62fZ9kQL1er/EBMH5n+bPa4P /BMg== X-Gm-Message-State: AOAM531QF6x33ByINvgI3kQ0knXGA6KY0R4/xBzOQubK8ElGtPmUI+zW 3kVrHNEQNn4/fpzmNIfNeSAJsGZIja03Aw== X-Google-Smtp-Source: ABdhPJy9zElavpxqpBa2OrUYgtVBBx6wLtQaG23S5v8ec764n5rq7zXO2QFHjt/Y25P4vXHVCORDUQ== X-Received: by 2002:a17:90a:ff92:: with SMTP id hf18mr11858868pjb.107.1597653342408; Mon, 17 Aug 2020 01:35:42 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:35:41 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 04/10] mmc: dw_mmc: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:02 +0530 Message-Id: <20200817083508.22657-5-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/dw_mmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 35ae5737c622..574e5a7a697c 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -1952,9 +1952,9 @@ static bool dw_mci_clear_pending_data_complete(struct dw_mci *host) return true; } -static void dw_mci_tasklet_func(unsigned long priv) +static void dw_mci_tasklet_func(struct tasklet_struct *t) { - struct dw_mci *host = (struct dw_mci *)priv; + struct dw_mci *host = from_tasklet(host, t, tasklet); struct mmc_data *data; struct mmc_command *cmd; struct mmc_request *mrq; @@ -3312,7 +3312,7 @@ int dw_mci_probe(struct dw_mci *host) else host->fifo_reg = host->regs + DATA_240A_OFFSET; - tasklet_init(&host->tasklet, dw_mci_tasklet_func, (unsigned long)host); + tasklet_setup(&host->tasklet, dw_mci_tasklet_func); ret = devm_request_irq(host->dev, host->irq, dw_mci_interrupt, host->irq_flags, "dw-mci", host); if (ret) From patchwork Mon Aug 17 08:35:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717029 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 22E8015E6 for ; Mon, 17 Aug 2020 08:36:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B78220758 for ; Mon, 17 Aug 2020 08:36:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PX4S+d8S" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbgHQIfv (ORCPT ); Mon, 17 Aug 2020 04:35:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54242 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbgHQIfs (ORCPT ); Mon, 17 Aug 2020 04:35:48 -0400 Received: from mail-pl1-x644.google.com (mail-pl1-x644.google.com [IPv6:2607:f8b0:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78A0DC061389; Mon, 17 Aug 2020 01:35:47 -0700 (PDT) Received: by mail-pl1-x644.google.com with SMTP id t10so7139120plz.10; Mon, 17 Aug 2020 01:35:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IwFOYY367ULZT1BN2OrQmrKwLru5AbIHU/lvBoUtbvI=; b=PX4S+d8SSzqmcDvaTTsGyA2ivQ3CN5X25wDtmjJVfFwuC6bz5NXD3ayhO28oMCUbDO MUqFNlrjccbTVa7mJEjGjRjoKHHDjjb+sFzt4o1G4Hxsvv/AqTP3OMgAhUaz79u9aB8Z Gr79ENBofDZokJfNqjT+lmbmlNmUlR0ZZOw12uQXnw0fGlYkn7xD9QZjZ6NsGUHKSfRa cyMpT73GX9xDM53F+/nqaSYDLHmLabAJJ7rTdp+WL2aSNwO1f0GfwwpZGiV0oxAVM8EW 4pYtF71te6SFr2uNpao8D98UE3ueunxEu56vEUuGDYzn0sUPXGemS9DgUSWJ/i3hQEbT /DXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IwFOYY367ULZT1BN2OrQmrKwLru5AbIHU/lvBoUtbvI=; b=WZV/dXv6jMmVOboHg/i2QVS3gAwsiPwXzdH6PeRpRRmSbfmz1fs+pcgz8+6oxhS0wp Ku2EMcYvhjLZacXyS2JbnPQPSD/4K9ilcE7Sw8n7B435WAbtKRPRibDYWVXNuzR6Rv51 Ui46qSLP2J8suFQu80g9n59eB9g+WQYvBWy7cLITMRNvS7dT54+FFouVxVNN5we5+VCT a9viKxez1B/QOh9ul5Sj4OGCanEEsjYO2WuCsH1xx/M63B/FHvNpYRSdu9t8jugUfrbm 8PVlFN97vxhIClgwtE1GuKJN5OXZ3A27fNcAa20x4c7v4kjW1u4ttCkVIK3fXdTtp5Ch ZHLw== X-Gm-Message-State: AOAM530sP4QySvBE6fvAYt7EnPuDog4UnZKr43JvMXh3+W0PluHgVi24 jPkbeuPCe2IBAypeAZI8BMc= X-Google-Smtp-Source: ABdhPJzuuZWms7RUMkI6+RPWhuqqeB3lLRfxRvIP7v4EbXz/ZUmf08sunStIEL/0sx81A2cvBjvJvw== X-Received: by 2002:a17:902:441:: with SMTP id 59mr10581843ple.282.1597653347062; Mon, 17 Aug 2020 01:35:47 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:35:46 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 05/10] mmc: omap: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:03 +0530 Message-Id: <20200817083508.22657-6-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/omap.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index 33d7af7c7762..9852263cef4d 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -878,9 +878,9 @@ static void mmc_omap_cover_timer(struct timer_list *t) tasklet_schedule(&slot->cover_tasklet); } -static void mmc_omap_cover_handler(unsigned long param) +static void mmc_omap_cover_handler(struct tasklet_struct *t) { - struct mmc_omap_slot *slot = (struct mmc_omap_slot *)param; + struct mmc_omap_slot *slot = from_tasklet(slot, t, cover_tasklet); int cover_open = mmc_omap_cover_is_open(slot); mmc_detect_change(slot->mmc, 0); @@ -1269,8 +1269,7 @@ static int mmc_omap_new_slot(struct mmc_omap_host *host, int id) if (slot->pdata->get_cover_state != NULL) { timer_setup(&slot->cover_timer, mmc_omap_cover_timer, 0); - tasklet_init(&slot->cover_tasklet, mmc_omap_cover_handler, - (unsigned long)slot); + tasklet_setup(&slot->cover_tasklet, mmc_omap_cover_handler); } r = mmc_add_host(mmc); From patchwork Mon Aug 17 08:35:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717019 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EDD1A15E6 for ; Mon, 17 Aug 2020 08:35:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2FCB207FF for ; Mon, 17 Aug 2020 08:35:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fgRJUvQ3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726987AbgHQIf4 (ORCPT ); Mon, 17 Aug 2020 04:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727959AbgHQIfx (ORCPT ); Mon, 17 Aug 2020 04:35:53 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83129C061388; Mon, 17 Aug 2020 01:35:53 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id u10so7146225plr.7; Mon, 17 Aug 2020 01:35:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PEGr9s6HGNxR8mzsZcOi/x3TsiaJrj80ASltnmxTvts=; b=fgRJUvQ3c3dalXzfHwldW9gKnPepaFA36zwdwrOZRVqh2L6fA7py884ow8ug8OqjqD IXYG9u/RrsV/s3xQ+UtY82VEU38rTrg+lft/fF/mpTS54rK52fJcjKB0l0ghXLKb4LCO 9sPEQaWI0f8zNAJKjS03gBFwlFydMubz7ANuiB7h4WQRIYodmWW+08YmTS71hS2rp8Yn x1rwTpfTLlJTc0/0g1OvBEG/3Aj/fMkhVmbWXG6++VzeLX3NB6j0OXsItgc0qt47e86T 9G75ApMOq/zQD0jYL1rAMJXvsAFKLzTt7c6zwSqIuun1oDe3PY9LC24MvWdX0yidyK9d 7KOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PEGr9s6HGNxR8mzsZcOi/x3TsiaJrj80ASltnmxTvts=; b=TvDqkug+VMz3jZfn3vDZsZ492FulXD0J9EL6VWa1P4FP6WmWQYlaTGyTvwQ2ekhDae mx4fs4ApEeWcYHkJceLuzdjrmAnmri4lIzPlKSXdzKfmpvXJzplaLpxSGlishY+ovPX9 5FFNPIWJzr2uYD2s2y+XFc0AVkB9Nf7bL3grbp8oDHk7nptoXuMRoqncTGtd2lnxVnHA dFHwI2v/XlHwLxIych0L2EoPQMileNqJI0m2TtHecayz0YkEI0eO+6O6WbMNG/7XblZl B2RKrfSuaAUocPsEn7ZByDwG7VHWpdXIAGbDaV2hnxa/Hhu0iakk1dHAoUaw4DlOlrXj oFWQ== X-Gm-Message-State: AOAM532QR0FUc4frhtCOV4iRm06YpDcSf2DJtKGwzOl0A901G58OP6aY XXcBPzSUDkLOyvF3Q004EVk= X-Google-Smtp-Source: ABdhPJxHHjf2l9lVu7pUt2dTiicTOD/n6pAnbvbGFIvNk9geL9SzW87cnZs77W7gkbYWLQTahXgzUQ== X-Received: by 2002:a17:902:9a09:: with SMTP id v9mr10140335plp.331.1597653351613; Mon, 17 Aug 2020 01:35:51 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:35:51 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 06/10] mmc: renesas: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:04 +0530 Message-Id: <20200817083508.22657-7-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/renesas_sdhi.h | 1 + drivers/mmc/host/renesas_sdhi_core.c | 2 ++ drivers/mmc/host/renesas_sdhi_internal_dmac.c | 20 +++++++++---------- drivers/mmc/host/renesas_sdhi_sys_dmac.c | 9 ++++----- 4 files changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/mmc/host/renesas_sdhi.h b/drivers/mmc/host/renesas_sdhi.h index 14c64caefc64..79a86bccc0ec 100644 --- a/drivers/mmc/host/renesas_sdhi.h +++ b/drivers/mmc/host/renesas_sdhi.h @@ -48,6 +48,7 @@ struct tmio_mmc_dma { }; struct renesas_sdhi { + struct platform_device *pdev; struct clk *clk; struct clk *clk_cd; struct tmio_mmc_data mmc_data; diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c index 15e21894bd44..4a9319743eb6 100644 --- a/drivers/mmc/host/renesas_sdhi_core.c +++ b/drivers/mmc/host/renesas_sdhi_core.c @@ -975,6 +975,8 @@ int renesas_sdhi_probe(struct platform_device *pdev, goto eirq; } + priv->pdev = pdev; + dev_info(&pdev->dev, "%s base at %pa, max clock rate %u MHz\n", mmc_hostname(host->mmc), &res->start, host->mmc->f_max / 1000000); diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c b/drivers/mmc/host/renesas_sdhi_internal_dmac.c index 32ab991544ef..3d8866581043 100644 --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c @@ -218,9 +218,9 @@ renesas_sdhi_internal_dmac_start_dma(struct tmio_mmc_host *host, renesas_sdhi_internal_dmac_enable_dma(host, false); } -static void renesas_sdhi_internal_dmac_issue_tasklet_fn(unsigned long arg) +static void renesas_sdhi_internal_dmac_issue_tasklet_fn(struct tasklet_struct *t) { - struct tmio_mmc_host *host = (struct tmio_mmc_host *)arg; + struct tmio_mmc_host *host = from_tasklet(host, t, dma_issue); tmio_mmc_enable_mmc_irqs(host, TMIO_STAT_DATAEND); @@ -255,9 +255,11 @@ static bool renesas_sdhi_internal_dmac_complete(struct tmio_mmc_host *host) return true; } -static void renesas_sdhi_internal_dmac_complete_tasklet_fn(unsigned long arg) +static void renesas_sdhi_internal_dmac_complete_tasklet_fn(struct tasklet_struct *t) { - struct tmio_mmc_host *host = (struct tmio_mmc_host *)arg; + struct renesas_sdhi *priv = from_tasklet(priv, t, + dma_priv.dma_complete); + struct tmio_mmc_host *host = platform_get_drvdata(priv->pdev); spin_lock_irq(&host->lock); if (!renesas_sdhi_internal_dmac_complete(host)) @@ -289,12 +291,10 @@ renesas_sdhi_internal_dmac_request_dma(struct tmio_mmc_host *host, /* Each value is set to non-zero to assume "enabling" each DMA */ host->chan_rx = host->chan_tx = (void *)0xdeadbeaf; - tasklet_init(&priv->dma_priv.dma_complete, - renesas_sdhi_internal_dmac_complete_tasklet_fn, - (unsigned long)host); - tasklet_init(&host->dma_issue, - renesas_sdhi_internal_dmac_issue_tasklet_fn, - (unsigned long)host); + tasklet_setup(&priv->dma_priv.dma_complete, + renesas_sdhi_internal_dmac_complete_tasklet_fn); + tasklet_setup(&host->dma_issue, + renesas_sdhi_internal_dmac_issue_tasklet_fn); } static void diff --git a/drivers/mmc/host/renesas_sdhi_sys_dmac.c b/drivers/mmc/host/renesas_sdhi_sys_dmac.c index 13ff023fbee9..cd638e638db6 100644 --- a/drivers/mmc/host/renesas_sdhi_sys_dmac.c +++ b/drivers/mmc/host/renesas_sdhi_sys_dmac.c @@ -310,9 +310,9 @@ static void renesas_sdhi_sys_dmac_start_dma(struct tmio_mmc_host *host, } } -static void renesas_sdhi_sys_dmac_issue_tasklet_fn(unsigned long priv) +static void renesas_sdhi_sys_dmac_issue_tasklet_fn(struct tasklet_struct *t) { - struct tmio_mmc_host *host = (struct tmio_mmc_host *)priv; + struct tmio_mmc_host *host = from_tasklet(host, t, dma_issue); struct dma_chan *chan = NULL; spin_lock_irq(&host->lock); @@ -399,9 +399,8 @@ static void renesas_sdhi_sys_dmac_request_dma(struct tmio_mmc_host *host, goto ebouncebuf; init_completion(&priv->dma_priv.dma_dataend); - tasklet_init(&host->dma_issue, - renesas_sdhi_sys_dmac_issue_tasklet_fn, - (unsigned long)host); + tasklet_setup(&host->dma_issue, + renesas_sdhi_sys_dmac_issue_tasklet_fn); } renesas_sdhi_sys_dmac_enable_dma(host, true); From patchwork Mon Aug 17 08:35:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717021 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D129E15E4 for ; Mon, 17 Aug 2020 08:36:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B7C732072D for ; Mon, 17 Aug 2020 08:36:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KK+MLFHF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728021AbgHQIgA (ORCPT ); Mon, 17 Aug 2020 04:36:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbgHQIf5 (ORCPT ); Mon, 17 Aug 2020 04:35:57 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB52AC061388; Mon, 17 Aug 2020 01:35:56 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id g33so7777748pgb.4; Mon, 17 Aug 2020 01:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=EXTHOugKC7WcTyd29mBOhii65zA6nCGdQ46/CEABzfM=; b=KK+MLFHF8XZ4V5//pKO3B2MUptSmZ02kxeqix4cEQdwGDIuupQTYk4MV2iUy63dRvk BRSyDhvWiQGN6DuDg/ZYhEupr/fy2P3wtMUHvR59AlXgERg6L1lPSDVVO58NFnwmjbrl KAVdPjl9EuuJoJMQ+hAT4wDt0s0o+HR7exIsYHWhRjFmRFFLZG2K2LBav92cprDbBGT0 JgKpG9S+Ps7xbQkMiAtRdPEl/mDRz0VQEvbwXUczyHmEePAFzLNkmAYOJ98mOI9A3PyI hKnQFrOsyCZM9nPFivZH8PHJAZHLTlS+xnqhKIXWpTLuknIzNgYVjez3mqoovQd2vHW0 X0GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=EXTHOugKC7WcTyd29mBOhii65zA6nCGdQ46/CEABzfM=; b=IHT7Y64xBH5S90nhSkkllcBMCuCYjPeSbx1v9A+P1fJJLwd09rgsO7pxUeWKWhKpo6 uYe0rPi9+ktzAS5QAUbCBbC/Sbmkg81jbeIeBtF/elA2Pk3koyMYuVeBqxSfbYR5Qxjp gPYsSIrrT9Ib5gDp+pxD7klyEweDP9ha+UZq7OgxMfR5pEck+0hHAsBXXKpzB51WxwwU LH9gPKuczN8lmaab3b0iEZXqREcZp+Jvh6TeDU4IUR/aify2GkUnyQVbq3ujkPfl30Yx H0q3GJs6iz3TKc1iedtX9d2IN2UY1k+WrhjikWO6hmcrQOk+GCPowg5XJUuliN/P+1xa JIRQ== X-Gm-Message-State: AOAM533Pwe7JTi2mU+Bp0f/GX+t0LzKttUKqsV2aMj/YCHUk2fHOMiSm yx1eCYzmocmTqNbQV0RDXXk= X-Google-Smtp-Source: ABdhPJyRrFejCwuMRT4Xi+PdRIHIHc/YJ7utE/Qd53sctwPliCDJV+TjdjCkNXaEqtKVQVUDrD4xdw== X-Received: by 2002:a63:7505:: with SMTP id q5mr8919463pgc.312.1597653356453; Mon, 17 Aug 2020 01:35:56 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:35:55 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 07/10] mmc: s3cmci: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:05 +0530 Message-Id: <20200817083508.22657-8-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/s3cmci.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 444b2769ae2c..7540221d402d 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -549,9 +549,9 @@ static void do_pio_write(struct s3cmci_host *host) enable_imask(host, S3C2410_SDIIMSK_TXFIFOHALF); } -static void pio_tasklet(unsigned long data) +static void pio_tasklet(struct tasklet_struct *t) { - struct s3cmci_host *host = (struct s3cmci_host *) data; + struct s3cmci_host *host = from_tasklet(host, t, pio_tasklet); s3cmci_disable_irq(host, true); @@ -1565,7 +1565,7 @@ static int s3cmci_probe(struct platform_device *pdev) host->pdata = pdev->dev.platform_data; spin_lock_init(&host->complete_lock); - tasklet_init(&host->pio_tasklet, pio_tasklet, (unsigned long) host); + tasklet_setup(&host->pio_tasklet, pio_tasklet); if (host->is2440) { host->sdiimsk = S3C2440_SDIIMSK; From patchwork Mon Aug 17 08:35:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717023 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 02DAD15E6 for ; Mon, 17 Aug 2020 08:36:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF123207DF for ; Mon, 17 Aug 2020 08:36:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DhF6t+2Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727774AbgHQIgH (ORCPT ); Mon, 17 Aug 2020 04:36:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54292 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728033AbgHQIgC (ORCPT ); Mon, 17 Aug 2020 04:36:02 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4557C061388; Mon, 17 Aug 2020 01:36:01 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id l60so7464961pjb.3; Mon, 17 Aug 2020 01:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j1L+zCWhXn/joke0t0DEH3dC8tZXKifv8sB6Zyw25w8=; b=DhF6t+2YP62P4iucghZREd6z6ii87qeNjWHRLa58Jly/lbHh+MMjkxFsuXMKCdVKde kkL81Q/PjVnVxhRvGnr1pvI6akB26SaQsHG6Ocnaxgwn7vQhln4IJulE+Wg0ydo/JF2u rN0GW9sq70mmhZTq76lKYkveUQcW2GAQ/anH/cMJQRrs1tcybAyNp42almY/4uh9qMTh m0ECMMuhXMSDd+WhuP3ivVXLJGxVOiPeJeH7s6d6wlbzSL5XsTVxfeucrbrhR2trt0SA BvCYDOR/jscEP/NpGfw3GcyasWS8W6zkCLzDlAA9Cm+CtxDsdq+P6lqZ//Dngkveu/6R hg+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j1L+zCWhXn/joke0t0DEH3dC8tZXKifv8sB6Zyw25w8=; b=p1Dlzuw/qC4cRDkA1JsvSNzo18z8HsNRxAXLdHmxXg4XmibGNavzLy4Z0TB2Puw8kl ylsMpU7YBeSObSQEyDT9lkFK9wQvhOKHGAIx2dbK7Uxdu5ScvM05pcBYFEdPnKQNgF+V uR8GtdT54K4H6HnZm4I473/iwTdNumaqspMzktuvP0mIAT2NqFJBvHLu3fUugR457f9m vQmWKFh/t1ZoQ6mAI2bfiAVA0FvBhYENljyhaP9X9BOoF33NkUt4eQKlRy8M8zxCQciN IsbQaeMH07ufW+5asg8PEdbjkaY3MK6Tk/JO2c6Lcs6M3e0bxpqQzDY9sNQU+Vb7o0iY giOA== X-Gm-Message-State: AOAM532kFaqem2PHy4CnICV3v1yiTpQS6jqbnACig8Yogl61+8ZFd42W qVavMBepQ6z+5fYUN0vwdBs= X-Google-Smtp-Source: ABdhPJyc0TiP72f7uRdnYv6rQAyV9Lbfk3OCsMGXPxXNPAnOT6Q+GGj6oLVMmyApEYWY9WFadWlkig== X-Received: by 2002:a17:902:d90e:: with SMTP id c14mr10225733plz.37.1597653361223; Mon, 17 Aug 2020 01:36:01 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:36:00 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 08/10] mmc: tifm_sd: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:06 +0530 Message-Id: <20200817083508.22657-9-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/tifm_sd.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/tifm_sd.c b/drivers/mmc/host/tifm_sd.c index 5987656e0474..c64cf12b117a 100644 --- a/drivers/mmc/host/tifm_sd.c +++ b/drivers/mmc/host/tifm_sd.c @@ -731,9 +731,9 @@ static void tifm_sd_request(struct mmc_host *mmc, struct mmc_request *mrq) mmc_request_done(mmc, mrq); } -static void tifm_sd_end_cmd(unsigned long data) +static void tifm_sd_end_cmd(struct tasklet_struct *t) { - struct tifm_sd *host = (struct tifm_sd*)data; + struct tifm_sd *host = from_tasklet(host, t, finish_tasklet); struct tifm_dev *sock = host->dev; struct mmc_host *mmc = tifm_get_drvdata(sock); struct mmc_request *mrq; @@ -968,8 +968,7 @@ static int tifm_sd_probe(struct tifm_dev *sock) */ mmc->max_busy_timeout = TIFM_MMCSD_REQ_TIMEOUT_MS; - tasklet_init(&host->finish_tasklet, tifm_sd_end_cmd, - (unsigned long)host); + tasklet_setup(&host->finish_tasklet, tifm_sd_end_cmd); timer_setup(&host->timer, tifm_sd_abort, 0); mmc->ops = &tifm_sd_ops; From patchwork Mon Aug 17 08:35:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Allen X-Patchwork-Id: 11717025 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CDC3115E4 for ; Mon, 17 Aug 2020 08:36:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3D7C20758 for ; Mon, 17 Aug 2020 08:36:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qv7mQq3H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728077AbgHQIgI (ORCPT ); Mon, 17 Aug 2020 04:36:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726991AbgHQIgG (ORCPT ); Mon, 17 Aug 2020 04:36:06 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F482C061388; Mon, 17 Aug 2020 01:36:06 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id r11so7861482pfl.11; Mon, 17 Aug 2020 01:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=USxZmhIvAjMlSK/u/36V0VU77WjN451bESJJHVsL8wA=; b=qv7mQq3HvH/j9rO0ouzEgyfVi87JqUW2V4QAEydvCAbx2LQUKNcMXXgzySavPZqUj1 Ins64ROl4iTDAUvGdBA8KNLD+qJ/t3xoKL2bXmmDz5j5zNWkxsTNK2mzPi4cq8w4HysR qB91AJnJHOV6Dde1l3Zb4nVFb6yI5mMdYAxNbA6LQHMd/EO4U9zXKzCy7hR1yeo82Iqd /DBuYxjqUcNRlAfliC/SW47TbY/h4Ti/9Wzv2s7Zhfx+kFOkNFOjjKq6qZneTjwh/B/+ f1SWPbJG/98XE5yYyQRkSbXpN+KiMeDSwutkcFl9MLsZkE2xUQIj+HBAOxNRzYkv3mKd rdbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=USxZmhIvAjMlSK/u/36V0VU77WjN451bESJJHVsL8wA=; b=Ejstgtz9CPBhnoiNZI4Ik3/UghXlNudedLnfgxc9eYd7WcGaYT86h21uEA6o3waA5h J5RCWyV9OkU9oxv/Y+JveXsE2XtEOld7M2Hx8H5LzNNlc1V0pqXcbHOrh/21iaJGn9my lTU5ESfqqiQbA3NnUgRXicMbIgt+XnqcFy7hh3ziWcAfrKBBCu2eZXxrG9pF7MmMzj+Q 1S8EmifpbstpUZ3cIQrl/AFqXw2Ivnkd3l3zGc3PJ5cUGvc3+GTNDg52ZLI49NGnIxLi ySaNpmuIzPoqqfPOlp9wKzlSx3F8yfzv48jV1g1Inv7fj1azrzA9UG/50ywtbLxyGwj1 Lbmg== X-Gm-Message-State: AOAM530yJhpTV/6wUtb9Rx20e0tXtv20ey1doOms7+8KnUWphHyIou2f d39ldV5zoOCAuQAEU3uH8Qw= X-Google-Smtp-Source: ABdhPJx2KGwGED3Yc15krTxgUP+AmeFkGxZajP9xEdKcSOvV/rUk8mcmkjNLqknBvXOL5Fwv0WnNrQ== X-Received: by 2002:a63:6e4f:: with SMTP id j76mr8967691pgc.449.1597653365932; Mon, 17 Aug 2020 01:36:05 -0700 (PDT) Received: from localhost.localdomain ([49.207.202.98]) by smtp.gmail.com with ESMTPSA id h5sm18434068pfq.146.2020.08.17.01.36.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Aug 2020 01:36:05 -0700 (PDT) From: Allen Pais To: ludovic.desroches@microchip.com, ulf.hansson@linaro.org, manuel.lauss@gmail.com, mirq-linux@rere.qmqm.pl, jh80.chung@samsung.com, oakad@yahoo.com, yamada.masahiro@socionext.com, brucechang@via.com.tw, HaraldWelte@viatech.com Cc: keescook@chromium.org, inux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Allen Pais , Romain Perier Subject: [PATCH 09/10] mmc: uniphier: convert tasklets to use new tasklet_setup() API Date: Mon, 17 Aug 2020 14:05:07 +0530 Message-Id: <20200817083508.22657-10-allen.lkml@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200817083508.22657-1-allen.lkml@gmail.com> References: <20200817083508.22657-1-allen.lkml@gmail.com> Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org In preparation for unconditionally passing the struct tasklet_struct pointer to all tasklet callbacks, switch to using the new tasklet_setup() and from_tasklet() to pass the tasklet pointer explicitly. Signed-off-by: Romain Perier Signed-off-by: Allen Pais --- drivers/mmc/host/uniphier-sd.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/mmc/host/uniphier-sd.c b/drivers/mmc/host/uniphier-sd.c index f82baf99fd69..c822bb7beaca 100644 --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -81,9 +81,9 @@ static void uniphier_sd_dma_endisable(struct tmio_mmc_host *host, int enable) } /* external DMA engine */ -static void uniphier_sd_external_dma_issue(unsigned long arg) +static void uniphier_sd_external_dma_issue(struct tasklet_struct *t) { - struct tmio_mmc_host *host = (void *)arg; + struct tmio_mmc_host *host = from_tasklet(host, t, dma_issue); struct uniphier_sd_priv *priv = uniphier_sd_priv(host); uniphier_sd_dma_endisable(host, 1); @@ -190,8 +190,7 @@ static void uniphier_sd_external_dma_request(struct tmio_mmc_host *host, host->chan_rx = chan; host->chan_tx = chan; - tasklet_init(&host->dma_issue, uniphier_sd_external_dma_issue, - (unsigned long)host); + tasklet_setup(&host->dma_issue, uniphier_sd_external_dma_issue); } static void uniphier_sd_external_dma_release(struct tmio_mmc_host *host) @@ -228,9 +227,9 @@ static const struct tmio_mmc_dma_ops uniphier_sd_external_dma_ops = { .dataend = uniphier_sd_external_dma_dataend, }; -static void uniphier_sd_internal_dma_issue(unsigned long arg) +static void uniphier_sd_internal_dma_issue(struct tasklet_struct *t) { - struct tmio_mmc_host *host = (void *)arg; + struct tmio_mmc_host *host = from_tasklet(host, t, dma_issue); unsigned long flags; spin_lock_irqsave(&host->lock, flags); @@ -309,8 +308,7 @@ static void uniphier_sd_internal_dma_request(struct tmio_mmc_host *host, host->chan_tx = (void *)0xdeadbeaf; - tasklet_init(&host->dma_issue, uniphier_sd_internal_dma_issue, - (unsigned long)host); + tasklet_setup(&host->dma_issue, uniphier_sd_internal_dma_issue); } static void uniphier_sd_internal_dma_release(struct tmio_mmc_host *host)