From patchwork Tue Aug 25 06:59:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 11735041 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 05F251731 for ; Tue, 25 Aug 2020 07:00:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE47920639 for ; Tue, 25 Aug 2020 07:00:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vs3QPCx+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="RgjYnOMa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE47920639 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qqXvvZ5qyCRrNdp/x6XEDO+Q8Dj05Vzd1J4jRy+9fM0=; b=vs3QPCx+W3yTpohh3DYOGL4+7 xGLaYvv//BR7+Jacxp77pUiRvoAu1e7Nen8O+x/VsJMZEpMnlPcAq5tYUptTElFjyuRTR50edDkuP BWwgw29y/udjAs+4VESVji/QO+sQvknIX1DL5iuFG9CvKXw7oYaUxONfsYC6sq5jima6qf+lm/4qA F5nSKE01myQbLzXb5mPc4c0Bk7jn8SRFLqhAehrH+xL+xp9x61NWC1yjdmQ0YZJF2ZwJciI0qFpDq QiBoYDMU/IijT3yUGGErCIGNM+XgUUnLwAU209jUwc1zMpvrYKSzJ5/dhaNvJ/Q/YZZc+OZ7MratL uNnD0C5XQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kASvY-00089f-Pt; Tue, 25 Aug 2020 06:59:28 +0000 Received: from esa1.microchip.iphmx.com ([68.232.147.91]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kASvR-00087X-7T for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 06:59:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1598338761; x=1629874761; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=HgjEgkiKGTzhHa9dedX7zLtx+BB912JMHCVfd4RNaDc=; b=RgjYnOMap3S4jPEQqF0U19iWJSjgkhP+0oTHm7N7N+nEfVncwCEgOTst P4Tc70JbloTqPRRZ07vQcFiCCNb3DMqvYGS9yCOUj1wNwRgJR1MI1iatY pIwGkS4bXsxtUeZNtNcC1AjCDj1GkkacCofVEIgOBjRKud/6G1hQ3LRmj vIEMyqeXRTrw0vFCUCs3gc9LMGKYyMmh0814seh2twZpDI+87Q1RsscGa mDAPynUAMBHDipD11d0qGIWTV8CsixJwKxm3k7Q5BpCgg2FVMEO82lqzr kGscFZPlk/Pn9GYhNUXI4RLOLRGcuQRHNT7nvytSIohDMlirr9Qg5WUOL w==; IronPort-SDR: RurX8EOmBuNyZZun6JOWBMi1UJoatI1WaYIR/o8QQiPLgTJ/TdLqoSK14cnfBSgwokGNiuOI/I r5ONgtF+uZN+L/sZY4pv4frutkTOkMwGnZvaTbe++PO17im1i0DJnJtgZncF5cYUazHU777RKb jD0IIKg1lwfSBO0VNpIAoeeRJPZDACHWmOJ35nHy5gkRVKltwZFv80nP3pjcA9ZwYNEypN1g0w ydbqwY3+doLgr6Iwasau+mtioGwuHCcyDbkFNDEWHnI1yeKTw/BvzLE2QPK7w/KNDKWzHKBH5c 8Vg= X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="93013760" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Aug 2020 23:59:19 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 24 Aug 2020 23:59:18 -0700 Received: from m18063-ThinkPad-T460p.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 24 Aug 2020 23:59:16 -0700 From: Claudiu Beznea To: , , , , Subject: [PATCH v2 1/3] clk: at91: remove the checking of parent_name Date: Tue, 25 Aug 2020 09:59:09 +0300 Message-ID: <1598338751-20607-2-git-send-email-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1598338751-20607-1-git-send-email-claudiu.beznea@microchip.com> References: <1598338751-20607-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_025921_483662_1B605E88 X-CRM114-Status: GOOD ( 13.17 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.147.91 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [68.232.147.91 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Claudiu Beznea , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There is no need to check parent_name variable while assigning it to init.parent_names. parent_name variable is already checked at the beginning of at91_clk_register_peripheral() function. Fixes: 6114067e437eb ("clk: at91: add PMC peripheral clocks") Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni --- drivers/clk/at91/clk-peripheral.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91/clk-peripheral.c b/drivers/clk/at91/clk-peripheral.c index 7867eaf0447f..7a27ba8e0577 100644 --- a/drivers/clk/at91/clk-peripheral.c +++ b/drivers/clk/at91/clk-peripheral.c @@ -112,8 +112,8 @@ at91_clk_register_peripheral(struct regmap *regmap, const char *name, init.name = name; init.ops = &peripheral_ops; - init.parent_names = (parent_name ? &parent_name : NULL); - init.num_parents = (parent_name ? 1 : 0); + init.parent_names = &parent_name; + init.num_parents = 1; init.flags = 0; periph->id = id; From patchwork Tue Aug 25 06:59:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 11735033 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7D594722 for ; Tue, 25 Aug 2020 06:59:42 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5436020782 for ; Tue, 25 Aug 2020 06:59:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ibh6QYw8"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="wJAPbYY8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5436020782 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZZ8YETu6ZYFKMYaqtMQGsULTHmT02CYyOrpLPYoZlT0=; b=Ibh6QYw89ug/ilqS0rsqV6Ajy QyNyNrH+XZbZBJJqoUCmOOleqkYiCBhNMr49nMaci3x1CVI7PGTqkq9In9xmKmMzWtJZ0I2zx3ucH 7tvem1PSj2UCRic0h/80Ke7t65xb6pEhNuyCr8dBsffW0TPbASXWo4rnPXzS7TvRsVRzHPkj4CQBo U05eWL+g4rgyRKfmqYvYgrVfQQgyIEXVzIVrQ11hR/g+l8Mu+8wZg9LKKMCWEMcXK3EpN7ontHpLJ 67iO3POVqmvD22Agf+4woGoKPUN3LfiizW+xvSkQb4DkrP294PSqupUQ4Z95g68jx+Gu2+3maDZfx fIb+n/6cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kASva-00089v-Fo; Tue, 25 Aug 2020 06:59:30 +0000 Received: from esa4.microchip.iphmx.com ([68.232.154.123]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kASvV-00088Q-I0 for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 06:59:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1598338765; x=1629874765; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=YLBI2VSPJLXETAxNgEX17p7s44o5bRsrSACE1OZwLZI=; b=wJAPbYY8iHeJlZa3qBdEzg/WbzdlgNokfckf87EfSExYyJL526BGekQk bFUeR+TgGfDBUmwMerB61YXQgMkHI1i3w7PX/GwR/OwrOodl/m4zT1Vto HE+6lovOZP/b2E6kZVoBe1cjkyocLoT3FqOVD9wsN0mVTS8rfcTxupKP8 G1C2Bm+46g2N/UJuk91BZtYmBxJZL8iZz4H0/J7Ug1VooMQGJcJhGIOVM q06pLbjd944I+5iQeKFAR4savLAKawVEpL1IOxruLiTwxPz6PPo9yb7Jr Tg8X+/hRhxzQoXdSxV6D+EAafQllDi28fysCfksm8nF/4ON0h+52czOc8 Q==; IronPort-SDR: sm2A0RzpQIxvooQwr2CT1B5KUIYFkmxp2PHcr0kQ0fRbm573/k/k9MhfpzAiibjqlKUNm6QbtA M6jMOsRm3qpcd+K4XT+w9WttPOW4BBXjVN19w1j9rI9VJJiTFB6jmYWZ1Jn/hnkOSg67PrOvia ry+esOR9m7A5IXU/KqaF3vzH/luqOOhcQI8nJJ9NxyMTHmGnPZ7jQ71mPw+rseQOPT2j5gkmu9 tP9KDsfVVbTnshPuTZjpVY8vvWz1fs4AWIx7oUVMp9GZa0g2hjZMo+m/tFIOIvcsTDc0fJMPJh p4s= X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="84625126" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa4.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Aug 2020 23:59:22 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 24 Aug 2020 23:59:21 -0700 Received: from m18063-ThinkPad-T460p.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 24 Aug 2020 23:59:19 -0700 From: Claudiu Beznea To: , , , , Subject: [PATCH v2 2/3] clk: at91: clk-main: update key before writing AT91_CKGR_MOR Date: Tue, 25 Aug 2020 09:59:10 +0300 Message-ID: <1598338751-20607-3-git-send-email-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1598338751-20607-1-git-send-email-claudiu.beznea@microchip.com> References: <1598338751-20607-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_025925_774990_F7EC8FC8 X-CRM114-Status: GOOD ( 11.96 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.154.123 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [68.232.154.123 listed in wl.mailspike.net] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Claudiu Beznea , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org SAMA5D2 datasheet specifies on chapter 33.22.8 (PMC Clock Generator Main Oscillator Register) that writing any value other than 0x37 on KEY field aborts the write operation. Use the key when selecting main clock parent. Fixes: 27cb1c2083373 ("clk: at91: rework main clk implementation") Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni --- drivers/clk/at91/clk-main.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/clk/at91/clk-main.c b/drivers/clk/at91/clk-main.c index 5c83e899084f..cfae2f59df66 100644 --- a/drivers/clk/at91/clk-main.c +++ b/drivers/clk/at91/clk-main.c @@ -437,12 +437,17 @@ static int clk_sam9x5_main_set_parent(struct clk_hw *hw, u8 index) return -EINVAL; regmap_read(regmap, AT91_CKGR_MOR, &tmp); - tmp &= ~MOR_KEY_MASK; if (index && !(tmp & AT91_PMC_MOSCSEL)) - regmap_write(regmap, AT91_CKGR_MOR, tmp | AT91_PMC_MOSCSEL); + tmp = AT91_PMC_MOSCSEL; else if (!index && (tmp & AT91_PMC_MOSCSEL)) - regmap_write(regmap, AT91_CKGR_MOR, tmp & ~AT91_PMC_MOSCSEL); + tmp = 0; + else + return 0; + + regmap_update_bits(regmap, AT91_CKGR_MOR, + AT91_PMC_MOSCSEL | MOR_KEY_MASK, + tmp | AT91_PMC_KEY); while (!clk_sam9x5_main_ready(regmap)) cpu_relax(); From patchwork Tue Aug 25 06:59:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 11735043 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CE35E1731 for ; Tue, 25 Aug 2020 07:00:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3EE220639 for ; Tue, 25 Aug 2020 07:00:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lHoOYmAr"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="tD2s/s6M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3EE220639 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Jq9P4FpZGADYaITAkX8wOfQz+O9H5S5yd2/KUlBwG+4=; b=lHoOYmArOEhKsmkdsC/51KsN6 fhxMzZkZzU6uvenQL9pdsnV9SNqDyks1cjtoSCn+X32vb3z7l6Hwd29bMjE0VC83dLK4RDoMVITY3 CcGlv/VHhsyYpmH27rVPdODAY47JRJzuZiwP11tWjXyUQ+ebZWu+HC3gAOZZoI37OMQ/MYDjFXltW GNX7WpHbgoEbU4tO7PhA3Jwh4C4EG8kZF2S1wHUFsyEsCDqTYoIa9IkENfNNZI1ylKowvd+5yIlBp hzHCtOd6/ATD2bg5iHSwHK1vMLNQXOsn2EBEiihBJej5EWrjmrI5RcicRcyw76bBe0uBFrVs4Z81E azfm06vPA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kASvg-0008Al-AU; Tue, 25 Aug 2020 06:59:36 +0000 Received: from esa1.microchip.iphmx.com ([68.232.147.91]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kASvW-00088w-P8 for linux-arm-kernel@lists.infradead.org; Tue, 25 Aug 2020 06:59:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1598338766; x=1629874766; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=IQ3W6SU5sxrboBq5t8pIzes6VBRBmqD928/Ulc8ETT0=; b=tD2s/s6Ma65qnmJthiLnoYUhxDTo4jzPkqZUaR4fIHUWwXlZD/MLfWIU 2sjR9DPHzRLUwUfn6D58+JEXaHrS3l3mfjGW/PmBTcBIbtGKoxGI9lv6S FbRd/PAoolNHc/aUrh7VJtgdFSo/cuTyWTSsVkxEbzjnm9DNihCuh5Ex6 ac8D/j/DHb8BUxKEG9MAo4TMyl5FFfbW9oPvo7jP3UVUKn08rTDYkzPeo yeV7h8zl5FDN8LfJiSoJJ/lk9hxGSq6AZfyATOKZj1yfDx0SRXTutFnQU tx10kiY+2HqJL4nYtAFfaAdU4BE9M9ZQxE0YLZf13qkGexPhKCeuiD8oI A==; IronPort-SDR: Dq93KiIJVzmKnFPK59vhOtHy2KkvpPDco0kUNkAaIL/iWvcUUNRl8gsW0w4g/UE3r1dNu7RNdx BC/5NqM5OldhJc5BSlfjIa2PO8gH+bf9ja3O0D/6uou6KPgoroEUCNDMPzHhp+A5hfoYh3QE8W hriWe/ytojaSY7X3vi+AuBxRmvAnIDXPJY2perHORI0BbmNhMkA0DawGuuNnjjIhoreho776iz sDgw2KFO6BNg2qfnA1ozcPfbWNHZQzNcIDgTpORUhQwb40Us0J/NxsZ+UZAP/CETOahUyQthy1 gUk= X-IronPort-AV: E=Sophos;i="5.76,351,1592895600"; d="scan'208";a="93013773" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 24 Aug 2020 23:59:25 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Mon, 24 Aug 2020 23:59:24 -0700 Received: from m18063-ThinkPad-T460p.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.1979.3 via Frontend Transport; Mon, 24 Aug 2020 23:59:22 -0700 From: Claudiu Beznea To: , , , , Subject: [PATCH v2 3/3] clk: at91: clk-sam9x60-pll: remove unused variable Date: Tue, 25 Aug 2020 09:59:11 +0300 Message-ID: <1598338751-20607-4-git-send-email-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1598338751-20607-1-git-send-email-claudiu.beznea@microchip.com> References: <1598338751-20607-1-git-send-email-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200825_025927_002000_B2D400BE X-CRM114-Status: GOOD ( 12.22 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [68.232.147.91 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [68.232.147.91 listed in wl.mailspike.net] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, Claudiu Beznea , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bbrezillon@kernel.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fix variable set but not used compilation warning. Fixes: 43b1bb4a9b3e ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs") Reported-by: kernel test robot Signed-off-by: Claudiu Beznea --- drivers/clk/at91/clk-sam9x60-pll.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c index b473298ef7e6..78f458a7b2ef 100644 --- a/drivers/clk/at91/clk-sam9x60-pll.c +++ b/drivers/clk/at91/clk-sam9x60-pll.c @@ -331,7 +331,7 @@ static long sam9x60_div_pll_compute_div(struct sam9x60_pll_core *core, struct clk_hw *parent = clk_hw_get_parent(&core->hw); unsigned long tmp_rate, tmp_parent_rate, tmp_diff; long best_diff = -1, best_rate = -EINVAL; - u32 divid, best_div; + u32 divid; if (!rate) return 0; @@ -352,7 +352,6 @@ static long sam9x60_div_pll_compute_div(struct sam9x60_pll_core *core, *parent_rate = tmp_parent_rate; best_rate = tmp_rate; best_diff = tmp_diff; - best_div = divid; } if (!best_diff)