From patchwork Wed Aug 26 07:17:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Lee, Shawn C" X-Patchwork-Id: 11737525 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5AD5E913 for ; Wed, 26 Aug 2020 07:18:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 432722071E for ; Wed, 26 Aug 2020 07:18:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 432722071E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F37D26EA29; Wed, 26 Aug 2020 07:18:31 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EE336EA29 for ; Wed, 26 Aug 2020 07:18:31 +0000 (UTC) IronPort-SDR: +0hEzLn0vCyMeuCUz2ElBDg1J0sf4/bJ47kIafKr04ERPdc2UL+KnjtZj0tgufuVsq80l8cmIi 3NnzsXjc3+2g== X-IronPort-AV: E=McAfee;i="6000,8403,9724"; a="153670436" X-IronPort-AV: E=Sophos;i="5.76,354,1592895600"; d="scan'208";a="153670436" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2020 00:18:30 -0700 IronPort-SDR: 2XO8qujj3Z9j3bCsFVBRdhusdlVBz+CuSHpmNzh6SblzeE+HbKH8/kU4KV32Win3bZ2A7EKUjA kDwjojcX9dJw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,354,1592895600"; d="scan'208";a="339068809" Received: from shawnle1-build-machine.itwn.intel.com ([10.5.253.9]) by orsmga007.jf.intel.com with ESMTP; 26 Aug 2020 00:18:29 -0700 From: Lee Shawn C To: intel-gfx@lists.freedesktop.org Date: Wed, 26 Aug 2020 15:17:10 +0800 Message-Id: <20200826071710.31689-1-shawn.c.lee@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200825102600.27779-1-shawn.c.lee@intel.com> References: <20200825102600.27779-1-shawn.c.lee@intel.com> MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v2] drm/i915/fbc: Disable fbc with VT-d also with cometlake X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: William Tseng , Jani Nikula Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Both VT-d and FBC enabled that caused display flicker issue very randomly. According to sighting report, it recommend to disable FBC to workaround this issue. v2: Specific this change for CML U series device. Using IS_CML_ULT() instead of IS_COMETLAKE(). Cc: Ville Syrjälä Cc: Rodrigo Vivi Cc: Mika Kuoppala Cc: Jani Nikula Cc: William Tseng Signed-off-by: Lee Shawn C --- drivers/gpu/drm/i915/display/intel_fbc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_fbc.c b/drivers/gpu/drm/i915/display/intel_fbc.c index 135f5e8a4d70..c99c4c84a0ed 100644 --- a/drivers/gpu/drm/i915/display/intel_fbc.c +++ b/drivers/gpu/drm/i915/display/intel_fbc.c @@ -1443,7 +1443,9 @@ static bool need_fbc_vtd_wa(struct drm_i915_private *dev_priv) { /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt */ if (intel_vtd_active() && - (IS_SKYLAKE(dev_priv) || IS_BROXTON(dev_priv))) { + (IS_SKYLAKE(dev_priv) || + IS_BROXTON(dev_priv) || + IS_CML_ULT(dev_priv))) { drm_info(&dev_priv->drm, "Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n"); return true;