From patchwork Mon Oct 22 20:46:34 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10652537 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1542413A4 for ; Mon, 22 Oct 2018 20:49:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5A9BF28DD8 for ; Mon, 22 Oct 2018 20:49:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4EA2A28DE2; Mon, 22 Oct 2018 20:49:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EE62828DD8 for ; Mon, 22 Oct 2018 20:49:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728956AbeJWFIp (ORCPT ); Tue, 23 Oct 2018 01:08:45 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:38338 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729231AbeJWFIp (ORCPT ); Tue, 23 Oct 2018 01:08:45 -0400 Received: by mail-pl1-f193.google.com with SMTP id p7-v6so673177plk.5 for ; Mon, 22 Oct 2018 13:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9quqmV2lX7vsdq6jXIqD+prLue7GJEdsIfV8n4tr2kY=; b=MFB80zIh70s//Sww6znYj2Gkcnwnh9oj5+gBmfuoHFdXPChng1u6J8DPxn4iSKt1cP 9Pl3/fxJl5n4uAgbJjXUN8LFGvRWcT1LGLO+bJKz/VlsM8HPQ8y+wUz3XEF7g1oDN2WE Y+qZoNrL1VpMbwFa+v60sUjpuu0y1h3DEiH9E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=9quqmV2lX7vsdq6jXIqD+prLue7GJEdsIfV8n4tr2kY=; b=FVruzeFp2Pze8J2szmEe6K6I2+QLt2p35UevAW9mSQWtQ5jKmR7ff/VKxqQ56N++7V d/4Hd9kQFjaMQj+sXigsArNjiQUc1k0PpZh7w9cFFxpFaF+4h33QD9Xjop5Y2h9/CK/t K8xTd3w8BO5HckBRU79bGvECLx1LMBFJEDyPW13dwG+1tjGhp0txgswQSo/OKLaN0M5+ 03wdP7o8nHLxb7PWQOwwVKd6UGuEzothsE5CJt/v+WEclhvYJm9Y9pUknkWOP6VsoQiS uPa296CgH1YqskbmtpTMQE72VoXYf6WO9kfhkeL6oOcVbwG6d6Waat9y7PPigtHPHT/L 8BQA== X-Gm-Message-State: ABuFfojGCs4CvUfF/20IVRO9pij6FqZH0Re87o3k2uJOC//50Ri9RIWt yNZFMI6M3u7NemwaIz2Crpa+yg== X-Google-Smtp-Source: ACcGV62f5GWRKT8OaC7N91FNyB2dMUhTVxo7qO1KXtmQpiW7n1IDqjZbkw22D02ZCJOAF2gOra6+AA== X-Received: by 2002:a17:902:2909:: with SMTP id g9-v6mr40887098plb.223.1540241319754; Mon, 22 Oct 2018 13:48:39 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id y144-v6sm47483001pfb.81.2018.10.22.13.48.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 13:48:38 -0700 (PDT) From: Douglas Anderson To: Sean Paul , Thierry Reding , Sandeep Panda Cc: linux-arm-msm@vger.kernel.org, Laurent Pinchart , jsanka@codeaurora.org, ryandcase@chromium.org, Douglas Anderson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , David Airlie , Mark Rutland Subject: [PATCH 1/6] dt-bindings: drm/panel: simple: Add no-hpd property Date: Mon, 22 Oct 2018 13:46:34 -0700 Message-Id: <20181022204639.8558-1-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some eDP panels that are designed to be always connected to a board use their HPD signal to signal that they've finished powering on and they're ready to be talked to. However, for various reasons it's possible that the HPD signal from the panel isn't actually hooked up. In the case where the HPD isn't hooked up you can look at the timing diagram on the panel datasheet and insert a delay for the maximum amount of time that the HPD might take to come up. Let's add a property in the device tree for this concept. Signed-off-by: Douglas Anderson Reviewed-by: Sean Paul Reviewed-by: Rob Herring --- .../devicetree/bindings/display/panel/simple-panel.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/display/panel/simple-panel.txt b/Documentation/devicetree/bindings/display/panel/simple-panel.txt index 45a457ad38f0..b2b872c710f2 100644 --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt @@ -11,6 +11,9 @@ Optional properties: - ddc-i2c-bus: phandle of an I2C controller used for DDC EDID probing - enable-gpios: GPIO pin to enable or disable the panel - backlight: phandle of the backlight device attached to the panel +- no-hpd: This panel is supposed to communicate that it's ready via HPD + (hot plug detect) signal, but the signal isn't hooked up so we should + hardcode the max delay from the panel spec when powering up the panel. Example: From patchwork Mon Oct 22 20:46:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10652517 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B8C613A4 for ; Mon, 22 Oct 2018 20:48:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 908E528CA4 for ; Mon, 22 Oct 2018 20:48:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 846A228CB4; Mon, 22 Oct 2018 20:48:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2412228CA4 for ; Mon, 22 Oct 2018 20:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729248AbeJWFIr (ORCPT ); Tue, 23 Oct 2018 01:08:47 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:38534 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729232AbeJWFIr (ORCPT ); Tue, 23 Oct 2018 01:08:47 -0400 Received: by mail-pf1-f196.google.com with SMTP id f29-v6so20504781pff.5 for ; Mon, 22 Oct 2018 13:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=f4oR4ZDStg+E8v2cNbJRHjDjC6miXn++j6pN4qN/OJI=; b=nqXfSozcAlJrz1vA+akqt+4QjA8aOz/5RxsauYp28eURs/+12vol0mT8/oWCjXuEKF R5fyotPtUyZgAikNitKS/QGtlX2Ia1PmQF5HQWajN4zcPEekkwJb4N/Ghz2kC7axxTPq H21xkrnPG2bkX0BylaE7Q3h38kpErbrrTGrW0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=f4oR4ZDStg+E8v2cNbJRHjDjC6miXn++j6pN4qN/OJI=; b=Ux7j8Bcw4Na31ZeKa+dB9dTLIeOm9KgBG+uJbWYO8HF+gio7IFq+85wBvftZ28SgCQ quVQ3ef/jPiotox15y6hlIYZ3pmswxLDcE5au1hO380EHcOl/OT8NvX9LwF1RLLPnI9Q n5b2zF7IgVmsHF4p83ID24xKJdlVRDbj10iu5+AwcixQ1EvMwZv7qfsujtnfuzplqP7H 1m7i2upitaj3KJoMnc8G/L8qOIjeVM7XTYRqn2PB/8H6mN5KigpdRslmQptrfwYzO9A2 EgPrWI8BvS0YjH9BR4LDJMUXUdOyFn2SPe/PCKksrRMyjzOtntgFo3Vov5/HFr1As/bP Emdg== X-Gm-Message-State: ABuFfogK0gNKK2SxqLwkvV28OMrGGvXTr88potpAbIFN69FgQWzYQdcI t37jricRPjxVNPH5XpRQw44YA45KJfk= X-Google-Smtp-Source: ACcGV63u11X6gLB9SFur48dm4ZHAR463bY0tjVxvEDCR4idABHAPtyeTVUOGrN34Y4N7CbIYt2JyAA== X-Received: by 2002:a62:8685:: with SMTP id x127-v6mr24358904pfd.252.1540241321478; Mon, 22 Oct 2018 13:48:41 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id y144-v6sm47483001pfb.81.2018.10.22.13.48.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 13:48:40 -0700 (PDT) From: Douglas Anderson To: Sean Paul , Thierry Reding , Sandeep Panda Cc: linux-arm-msm@vger.kernel.org, Laurent Pinchart , jsanka@codeaurora.org, ryandcase@chromium.org, Douglas Anderson , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/6] drm/panel: simple: Support panels with HPD where HPD isn't connected Date: Mon, 22 Oct 2018 13:46:35 -0700 Message-Id: <20181022204639.8558-2-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181022204639.8558-1-dianders@chromium.org> References: <20181022204639.8558-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some eDP panels that are designed to be always connected to a board use their HPD signal to signal that they've finished powering on and they're ready to be talked to. However, for various reasons it's possible that the HPD signal from the panel isn't actually hooked up. In the case where the HPD isn't hooked up you can look at the timing diagram on the panel datasheet and insert a delay for the maximum amount of time that the HPD might take to come up. Let's add support in simple-panel for this concept. At the moment we will co-opt the existing "prepare" delay to keep track of the delay and we'll use a boolean to specify that a given panel should only apply the delay if the "no-hpd" property was specified. Signed-off-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-simple.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 97964f7f2ace..38c646fb55fd 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -63,12 +63,15 @@ struct panel_desc { * turn the display off (no content is visible) * @unprepare: the time (in milliseconds) that it takes for the panel * to power itself down completely + * @prepare_delay_only_if_no_hpd: The prepare delay should only be done + * if we know Hot Plug Detect isn't used. */ struct { unsigned int prepare; unsigned int enable; unsigned int disable; unsigned int unprepare; + bool prepare_delay_only_if_no_hpd; } delay; u32 bus_format; @@ -79,6 +82,7 @@ struct panel_simple { struct drm_panel base; bool prepared; bool enabled; + bool no_hpd; const struct panel_desc *desc; @@ -215,7 +219,8 @@ static int panel_simple_prepare(struct drm_panel *panel) gpiod_set_value_cansleep(p->enable_gpio, 1); - if (p->desc->delay.prepare) + if (p->desc->delay.prepare && + (!p->desc->delay.prepare_delay_only_if_no_hpd || p->no_hpd)) msleep(p->desc->delay.prepare); p->prepared = true; @@ -305,6 +310,8 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) panel->prepared = false; panel->desc = desc; + panel->no_hpd = of_property_read_bool(dev->of_node, "no-hpd"); + panel->supply = devm_regulator_get(dev, "power"); if (IS_ERR(panel->supply)) return PTR_ERR(panel->supply); From patchwork Mon Oct 22 20:46:36 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10652521 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B0B0F13A4 for ; Mon, 22 Oct 2018 20:48:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 013A628CA4 for ; Mon, 22 Oct 2018 20:48:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E972328CAC; Mon, 22 Oct 2018 20:48:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C8F228CA4 for ; Mon, 22 Oct 2018 20:48:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729247AbeJWFIt (ORCPT ); Tue, 23 Oct 2018 01:08:49 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38361 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729250AbeJWFIs (ORCPT ); Tue, 23 Oct 2018 01:08:48 -0400 Received: by mail-pg1-f193.google.com with SMTP id f8-v6so19565692pgq.5 for ; Mon, 22 Oct 2018 13:48:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VBL7kzRm+AuhpncrtwVUlUGI2jFAGP9j8c7KtXaIcaE=; b=WvWxRfdmXjkkJEie+3AqQVb0SqhLpcxb6Gt/u6TEsYEg1K9lb/EICA1Jv09ZoxzYAd k6fCOad9/7zf0AfKZaMgTwmKQRmV5laACtdN7L3GNKUSuZ0uz0+jTgw650O/W6eAp231 POLXtaGYqWcS4wxkhvV3N8WF5AifY71zD+zTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VBL7kzRm+AuhpncrtwVUlUGI2jFAGP9j8c7KtXaIcaE=; b=DUUc6/XIjd13gksD/+vQBR51rLYPoQZQFfwXPzU4vEzqcPTkzVSVaqkBhjLE4zLXTt AF21migPIjLE3NmxgzgURxQDUzOVYDpPEyX1ohUQHF1fEajtS3JPEEkBItp9F3VqFt56 KmRXqEbyloNk5etxU/qIPc0WC4ddrF+LsfpSqTW6/ZTz1zOOMyrY1znM0YvT7A5buDfw UAMC6eFxOTOx6zvtMixMHs+f80itmzItnFsB61jiFsHQpvuxG81mAhR4kH95wJUYhloC xs56ppU6hIwQgubs8yVS+pQ7I1aKz56glM2hpTuPhufjf4IQwF67cI5G+cfychYTCbxm lLiA== X-Gm-Message-State: ABuFfoiOpiHP/6wadJ7JNqeD8BCwzS4OHVuwncyo9BtoNym/p2reCqWP pXjAXiF2IQfFopZslysKLtEQMA== X-Google-Smtp-Source: ACcGV63YMycIoSi70RRH3/rYbV0oT9IDSrQ1DcBsrtc4nxcveSax6GMLdak4HCfvGACQDSF1ADW7GQ== X-Received: by 2002:a62:75c7:: with SMTP id q190-v6mr47491226pfc.137.1540241322852; Mon, 22 Oct 2018 13:48:42 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id y144-v6sm47483001pfb.81.2018.10.22.13.48.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 13:48:42 -0700 (PDT) From: Douglas Anderson To: Sean Paul , Thierry Reding , Sandeep Panda Cc: linux-arm-msm@vger.kernel.org, Laurent Pinchart , jsanka@codeaurora.org, ryandcase@chromium.org, Douglas Anderson , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/6] drm/panel: simple: Add "no-hpd" delay for Innolux TV123WAM Date: Mon, 22 Oct 2018 13:46:36 -0700 Message-Id: <20181022204639.8558-3-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181022204639.8558-1-dianders@chromium.org> References: <20181022204639.8558-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If the HPD signal isn't hooked up to this panel we need a 200 ms delay. In the datasheet this is shown as the maximum time that HPD will take to be asserted after power is given to the panel. Signed-off-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 38c646fb55fd..937e97490c30 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1393,6 +1393,8 @@ static const struct panel_desc innolux_tv123wam = { .height = 173, }, .delay = { + .prepare = 200, + .prepare_delay_only_if_no_hpd = true, .unprepare = 500, }, }; From patchwork Mon Oct 22 20:46:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10652535 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3DC6B14DE for ; Mon, 22 Oct 2018 20:49:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 82AAE28CB5 for ; Mon, 22 Oct 2018 20:49:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 763A928DA9; Mon, 22 Oct 2018 20:49:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E09CF28CB5 for ; Mon, 22 Oct 2018 20:49:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729268AbeJWFIv (ORCPT ); Tue, 23 Oct 2018 01:08:51 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39583 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729250AbeJWFIu (ORCPT ); Tue, 23 Oct 2018 01:08:50 -0400 Received: by mail-pf1-f196.google.com with SMTP id c25-v6so20501121pfe.6 for ; Mon, 22 Oct 2018 13:48:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Quh8Ehy3LAjXO4rhXxhAHCZ0PkZ/kepKtIrAkWUBMF0=; b=QRZOiBzrM7YvGBsgis2lJCR9vBdMpezgSwJLA5pbMeg0e1Pw4X34eXRiBYjPYNvZPA V0PZFBwgnds71G9vFxIWWO622SsHDkuyEe8UfpwTbJPr301MAkgm3akZz7yxKHow0avt 07tuZZ/cRPGCsfAh+y6nEj8ztRr+h+sGZAZ5k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Quh8Ehy3LAjXO4rhXxhAHCZ0PkZ/kepKtIrAkWUBMF0=; b=HafFDBvOYj2Z/BE9ICaAHMZs37j8SIKG5iki7MO77bpPcDHM26Qllg4LCNIwr2zeC5 4EPKTp49l6ink5dMNpqdtJZCQzEYy4Q37IJ54uyK8g6C+QLxKPoJ8voo9Ow7EEY0saqH o4Ho7U6+nT28/2HPoRR8o557+w6oEreCZpU2AJjR4fjZdW8NwFm4GnJlAU3Fl0HxN7O0 PIFoEJN1T4RDSvcch9C3wpjDLO4tJWz8zcDqOOJ70Xr8J73xXMwMjAFoIX22TrjPznen jTF/LBCIYYG1oIxXjg9DYW3+vq51/RzxPAhcTAfwin8NlQ+oN9Diyn0Cllk36bsr9a22 5jDw== X-Gm-Message-State: ABuFfog/3prGO1oIhvHUO9ofHfmi218qH5j7Q2EiozB8YHkzjpqm6j9J qnlE9oAzJ6vg98XxTRC06pp+lg== X-Google-Smtp-Source: ACcGV62V0Lfv2CSDMxSTb9MJl42Yv8g+FnglM4BRrf+D6ymn6AhTYtOByBvx/cQnFathr0gc2NsOuA== X-Received: by 2002:a62:5f05:: with SMTP id t5-v6mr46971100pfb.223.1540241324446; Mon, 22 Oct 2018 13:48:44 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id y144-v6sm47483001pfb.81.2018.10.22.13.48.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 13:48:43 -0700 (PDT) From: Douglas Anderson To: Sean Paul , Thierry Reding , Sandeep Panda Cc: linux-arm-msm@vger.kernel.org, Laurent Pinchart , jsanka@codeaurora.org, ryandcase@chromium.org, Douglas Anderson , Andrzej Hajda , Archit Taneja , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Laurent Pinchart Subject: [PATCH 4/6] drm/bridge: ti-sn65dsi86: Remove the mystery delay Date: Mon, 22 Oct 2018 13:46:37 -0700 Message-Id: <20181022204639.8558-4-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181022204639.8558-1-dianders@chromium.org> References: <20181022204639.8558-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Let's solve the mystery of commit bf1178c98930 ("drm/bridge: ti-sn65dsi86: Add mystery delay to enable()"). Specifically the reason we needed that mystery delay is that we weren't paying attention to HPD. Looking at the datasheet for the same panel that was tested for the original commit, I see there's a timing "t3" that times from power on to the aux channel being operational. This time is specced as 0 - 200 ms. The datasheet says that the aux channel is operational at exactly the same time that HPD is asserted. Scoping the signals on this board showed that HPD was asserted 84 ms after power was asserted. That very closely matches the magic 70 ms delay that we had. ...and actually, in my testing the 70 ms wasn't quite enough of a delay and some percentage of the time the display didn't come up until I bumped it to 100 ms (presumably 84 ms would have worked too). To solve this, we tried to hook up the HPD signal in the bridge. ...but in doing so we found that that the bridge didn't report that HPD was asserted until ~280 ms after we powered it (!). This is explained by looking at the sn65dsi86 datasheet section "8.4.5.1 HPD (Hot Plug/Unplug Detection)". Reading there we see that the bridge isn't even intended to report HPD until 100 ms after it's asserted. ...but that would have left us at 184 ms. The extra 100 ms (presumably) comes from this part in the datasheet: > The HPD state machine operates off an internal ring oscillator. The > ring oscillator frequency will vary [ ... ]. The min/max range in > the HPD State Diagram refers to the possible times based off > variation in the ring oscillator frequency. Given that the 280 ms we'll end up delaying if we hook up HPD is _slower_ than the 200 ms we could just hardcode, for now we'll solve the problem by just hardcoding a 200 ms delay in the panel driver using the patch in this series ("drm/panel: simple: Support panels with HPD where HPD isn't connected"). If we later find a panel that needs to use this bridge where we need HPD then we'll have to come up with some new code to handle it. Given the silly debouncing in the bridge chip, though, it seems unlikely. One last note is that I tried to solve this through another way: In ti_sn_bridge_enable() I tried to use various combinations of dp_dpcd_writeb() and dp_dpcd_readb() to detect when the aux channel was up. In theory that would let me detect _exactly_ when I could continue and do link training. Unfortunately even if I did an aux transfer w/out waiting I couldn't see any errors. Possibly I could keep looping over link training until it came back with success, but that seemed a little overly hacky to me. Signed-off-by: Douglas Anderson Reviewed-by: Sean Paul --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 29 +++++++++++++++------------ 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index f8a931cf3665..680566d97adc 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -458,18 +458,6 @@ static void ti_sn_bridge_enable(struct drm_bridge *bridge) unsigned int val; int ret; - /* - * FIXME: - * This 70ms was found necessary by experimentation. If it's not - * present, link training fails. It seems like it can go anywhere from - * pre_enable() up to semi-auto link training initiation below. - * - * Neither the datasheet for the bridge nor the panel tested mention a - * delay of this magnitude in the timing requirements. So for now, add - * the mystery delay until someone figures out a better fix. - */ - msleep(70); - /* DSI_A lane config */ val = CHA_DSI_LANES(4 - pdata->dsi->lanes); regmap_update_bits(pdata->regmap, SN_DSI_LANES_REG, @@ -536,7 +524,22 @@ static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge) /* configure bridge ref_clk */ ti_sn_bridge_set_refclk_freq(pdata); - /* in case drm_panel is connected then HPD is not supported */ + /* + * HPD on this bridge chip is a bit useless. This is an eDP bridge + * so the HPD is an internal signal that's only there to signal that + * the panel is done powering up. ...but the bridge chip debounces + * this signal by between 100 ms and 400 ms (depending on process, + * voltage, and temperate--I measured it at about 200 ms). One + * particular panel asserted HPD 84 ms after it was powered on meaning + * that we saw HPD 284 ms after power on. ...but the same panel said + * that instead of looking at HPD you could just hardcode a delay of + * 200 ms. We'll assume that the panel driver will have the hardcoded + * delay in its prepare and always disable HPD. + * + * If HPD somehow makes sense on some future panel we'll have to + * change this to be conditional on someone specifying that HPD should + * be used. + */ regmap_update_bits(pdata->regmap, SN_HPD_DISABLE_REG, HPD_DISABLE, HPD_DISABLE); From patchwork Mon Oct 22 20:46:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10652523 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BC88913A4 for ; Mon, 22 Oct 2018 20:48:50 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F138528D22 for ; Mon, 22 Oct 2018 20:48:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E3A8E28CB7; Mon, 22 Oct 2018 20:48:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79E5228CA4 for ; Mon, 22 Oct 2018 20:48:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729264AbeJWFIw (ORCPT ); Tue, 23 Oct 2018 01:08:52 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:40551 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729266AbeJWFIv (ORCPT ); Tue, 23 Oct 2018 01:08:51 -0400 Received: by mail-pf1-f195.google.com with SMTP id g21-v6so13495876pfi.7 for ; Mon, 22 Oct 2018 13:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z9Cvmd97hzPoKYeufhgQkK5oC81R8IRAXT0JDJr89KA=; b=RvH9u8uJARk1S44xEIRKxALSbovNo5XFmOshZSI9Jz2ni7dsraioZ2FNQzBoCJoMq2 6MQCQiPmdRdzzAE3TXUqC9crY0TMaMxn/Sk50s30OYpCsbKc7Acjy41y20E1OGcYch6t 94ub8/cDcN2D5pKDVCOhgdpK0d++dUwQVSvu4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z9Cvmd97hzPoKYeufhgQkK5oC81R8IRAXT0JDJr89KA=; b=Sm6LI6vNcmdD1OG1tQo1BkNBujzaTACFgWq45lpHVyjq+QukSePjNM3m9z6+Tvl7uK T66uojpNB018R5JovZMjLlH0yNpILIaEEALuBx8H2mzewgIJqwmORY7M8Y+0pG1ur/db e/9axQzuITIFvXbvOSu+tOxdNK1eQfZcBrn09pTSMEF/zDuyE9JZe6eidXjRBG3DbGox kgu22VHLvmgu3mp7s1kSe0QciLoxFbjvYrhxpdLvOzIfRH0ZV6w6wASGSOcJSeWNl+K4 +0q3tj8Z3tcx/2BmYDQP/18MogCXpPC+fJ5QroqAI7amXvWaXbVrWfM0I7lMZjkRHJZT d5Jg== X-Gm-Message-State: ABuFfoi83GEVt1P9YQTHsqd9uMAnP2Zdldu4MX5JbCWgsdKZRsoJY0Nu rHUhuOKAJsaIhN0eVDVydYtUwA== X-Google-Smtp-Source: ACcGV63rM84RHpSTX0awUvLQG8+SWYLJHFlF22qPDkaehSFieAHM/Mhx/O39fzpq3a4lNqfU8O6f1A== X-Received: by 2002:a62:120b:: with SMTP id a11-v6mr46934708pfj.165.1540241325796; Mon, 22 Oct 2018 13:48:45 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id y144-v6sm47483001pfb.81.2018.10.22.13.48.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 13:48:45 -0700 (PDT) From: Douglas Anderson To: Sean Paul , Thierry Reding , Sandeep Panda Cc: linux-arm-msm@vger.kernel.org, Laurent Pinchart , jsanka@codeaurora.org, ryandcase@chromium.org, Douglas Anderson , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 5/6] drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1 Date: Mon, 22 Oct 2018 13:46:38 -0700 Message-Id: <20181022204639.8558-5-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181022204639.8558-1-dianders@chromium.org> References: <20181022204639.8558-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As far as I can tell the panel that was added in commit da50bd4258db ("drm/panel: simple: Add Innolux TV123WAM panel driver support") wasn't actually an Innolux TV123WAM but was actually an Innolux P120ZDG-BF1. As far as I can tell the Innolux TV123WAM isn't a real panel and but it's a mosh between the TI TV123WAM and the Innolux P120ZDG-BF1. Let's unmosh. Here's my evidence: * Searching for TV123WAM on the Internet turns up a TI panel. While it's possible that an Innolux panel has the same model number as the TI Panel, it seems a little doubtful. Looking up the datasheet from the TI Panel shows that it's 1920 x 1280 and 259.2 mm x 172.8 mm. * As far as I know, the patch adding the Innolux Panel was supposed to be for the board that's sitting in front of me as I type this (support for that board is not yet upstream). On the back of that panel I see Innolux P120ZDZ-EZ1 rev B1. * Someone pointed me at a datasheet that's supposed to be for the panel in front of me (sorry, I can't share the datasheet). That datasheet has the string "p120zdg-bf1" * If I search for "P120ZDG-BF1" on the Internet I get hits for panels that are 2160x1440. They don't have datasheets, but the fact that the resolution matches is a good sign. In any case, let's update the name and also the physical size to match the correct panel. Fixes: da50bd4258db ("drm/panel: simple: Add Innolux TV123WAM panel driver support") Signed-off-by: Douglas Anderson Cc: Sandeep Panda Reviewed-by: Abhinav Kumar Reviewed-by: Sean Paul --- drivers/gpu/drm/panel/panel-simple.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 937e97490c30..7ee1abc5d81b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1370,7 +1370,7 @@ static const struct panel_desc innolux_n156bge_l21 = { }, }; -static const struct drm_display_mode innolux_tv123wam_mode = { +static const struct drm_display_mode innolux_p120zdg_bf1_mode = { .clock = 206016, .hdisplay = 2160, .hsync_start = 2160 + 48, @@ -1384,13 +1384,13 @@ static const struct drm_display_mode innolux_tv123wam_mode = { .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC, }; -static const struct panel_desc innolux_tv123wam = { - .modes = &innolux_tv123wam_mode, +static const struct panel_desc innolux_p120zdg_bf1 = { + .modes = &innolux_p120zdg_bf1_mode, .num_modes = 1, .bpc = 8, .size = { - .width = 259, - .height = 173, + .width = 254, + .height = 169, }, .delay = { .prepare = 200, @@ -2454,8 +2454,8 @@ static const struct of_device_id platform_of_match[] = { .compatible = "innolux,n156bge-l21", .data = &innolux_n156bge_l21, }, { - .compatible = "innolux,tv123wam", - .data = &innolux_tv123wam, + .compatible = "innolux,p120zdg-bf1", + .data = &innolux_p120zdg_bf1, }, { .compatible = "innolux,zj070na-01p", .data = &innolux_zj070na_01p, From patchwork Mon Oct 22 20:46:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10652525 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1B11E14DE for ; Mon, 22 Oct 2018 20:48:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5DE7528CB5 for ; Mon, 22 Oct 2018 20:48:50 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5207C28DA0; Mon, 22 Oct 2018 20:48:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D2CB628CB5 for ; Mon, 22 Oct 2018 20:48:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729284AbeJWFIy (ORCPT ); Tue, 23 Oct 2018 01:08:54 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:44688 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729282AbeJWFIx (ORCPT ); Tue, 23 Oct 2018 01:08:53 -0400 Received: by mail-pg1-f196.google.com with SMTP id w3-v6so4022162pgs.11 for ; Mon, 22 Oct 2018 13:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4a7sqGi0woSvMngHSP5nAGi8IS8dbPL7pezY6AoAXTg=; b=GDsqbdypuvyVQp6CFQr7rsmI70RmOerzUKasq0mh4Q/KZkcBCezShgB/voc1wward7 zbSxdCwKi+id3XIYxcNe6d9gpcU+Q+DK+fMBkMk8ErJDjMmOXo/f5S+T5YDEJhGv4uNL he58a0yriSm3AG7lRDuyEUSNG76piArj+a6ag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4a7sqGi0woSvMngHSP5nAGi8IS8dbPL7pezY6AoAXTg=; b=dJENlc3mampI5EI0g1Kybo5adyPwOVD84E2WUSVCDHcLGo7fO2M+ffhekUG5aoRN1y bgXyVgG9fTO88pVYfuJoKWtiiuz3xQOGJwVN8WSVsg63wKmXEL8l/9H1vjpIZXhTI/Va Yu0zu0znYCHvzg+GJPHp98590Nq5eur0YNuErPJ+5YGgyfzhvlErpuX8NFM2+yVWvf2c axs/lKfvmLzyZcYBHQs7j/8GLRBi5gCbAkCD4orp1prZo111doWVBbQtx8Nh+zDSbFsF MRiSFbMC2fgjwamILlXNkes/fy2/nYmJ1ll5lRwCWleFzxUPy6ZuTK1PBwMe7MrZpglU OoUw== X-Gm-Message-State: ABuFfogwdtuMh6nx9wBpQs/m4M6n0POmGpbbYrgxMMooEXwVx2mRGEY7 skAcRJeHkblmqXf/kjtRwxVzGw== X-Google-Smtp-Source: ACcGV63MOz9xU64vSNdyCgJbX6qtYuydqvMy5srNCOVlvnR69Hh2QkvlSodWDoIL+fK4TivAbENJAg== X-Received: by 2002:a63:9f0a:: with SMTP id g10-v6mr42240926pge.232.1540241327219; Mon, 22 Oct 2018 13:48:47 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:c8e0:70d7:4be7:a36]) by smtp.gmail.com with ESMTPSA id y144-v6sm47483001pfb.81.2018.10.22.13.48.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 13:48:46 -0700 (PDT) From: Douglas Anderson To: Sean Paul , Thierry Reding , Sandeep Panda Cc: linux-arm-msm@vger.kernel.org, Laurent Pinchart , jsanka@codeaurora.org, ryandcase@chromium.org, Douglas Anderson , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , David Airlie , Mark Rutland Subject: [PATCH 6/6] dt-bindings: drm/panel: simple: Innolux TV123WAM is actually P120ZDG-BF1 Date: Mon, 22 Oct 2018 13:46:39 -0700 Message-Id: <20181022204639.8558-6-dianders@chromium.org> X-Mailer: git-send-email 2.19.1.568.g152ad8e336-goog In-Reply-To: <20181022204639.8558-1-dianders@chromium.org> References: <20181022204639.8558-1-dianders@chromium.org> MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As far as I can tell the bindings that were added in commit 9c04400f7ea6 ("dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings") weren't actually for Innolux TV123WAM but were actually for Innolux P120ZDG-BF1. As far as I can tell the Innolux TV123WAM isn't a real panel and but it's a mosh between the TI TV123WAM and the Innolux P120ZDG-BF1. Let's unmosh. Here's my evidence: * Searching for TV123WAM on the Internet turns up a TI panel. While it's possible that an Innolux panel has the same model number as the TI Panel, it seems a little doubtful. Looking up the datasheet from the TI Panel shows that it's 1920 x 1280 and 259.2 mm x 172.8 mm. * As far as I know, the patch adding the Innolux Panel was supposed to be for the board that's sitting in front of me as I type this (support for that board is not yet upstream). On the back of that panel I see Innolux P120ZDZ-EZ1 rev B1. * Someone pointed me at a datasheet that's supposed to be for the panel in front of me (sorry, I can't share the datasheet). That datasheet has the string "p120zdg-bf1" * If I search for "P120ZDG-BF1" on the Internet I get hits for panels that are 2160x1440. They don't have datasheets, but the fact that the resolution matches is a good sign. While we doing the rename, also mention that no-hpd can be used with this panel. See the previous patch in this series ("drm/panel: simple: Add "no-hpd" delay for Innolux TV123WAM"). Fixes: 9c04400f7ea6 ("dt-bindings: drm/panel: Document Innolux TV123WAM panel bindings") Signed-off-by: Douglas Anderson Cc: Sandeep Panda Reviewed-by: Rob Herring --- .../{innolux,tv123wam.txt => innolux,p120zdg-bf1.txt} | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) rename Documentation/devicetree/bindings/display/panel/{innolux,tv123wam.txt => innolux,p120zdg-bf1.txt} (70%) diff --git a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt b/Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.txt similarity index 70% rename from Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt rename to Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.txt index a9b35265fa13..513f03466aba 100644 --- a/Documentation/devicetree/bindings/display/panel/innolux,tv123wam.txt +++ b/Documentation/devicetree/bindings/display/panel/innolux,p120zdg-bf1.txt @@ -1,20 +1,22 @@ -Innolux TV123WAM 12.3 inch eDP 2K display panel +Innolux P120ZDG-BF1 12.02 inch eDP 2K display panel This binding is compatible with the simple-panel binding, which is specified in simple-panel.txt in this directory. Required properties: -- compatible: should be "innolux,tv123wam" +- compatible: should be "innolux,p120zdg-bf1" - power-supply: regulator to provide the supply voltage Optional properties: - enable-gpios: GPIO pin to enable or disable the panel - backlight: phandle of the backlight device attached to the panel +- no-hpd: If HPD isn't hooked up; add this property. Example: panel_edp: panel-edp { - compatible = "innolux,tv123wam"; + compatible = "innolux,p120zdg-bf1"; enable-gpios = <&msmgpio 31 GPIO_ACTIVE_LOW>; power-supply = <&pm8916_l2>; backlight = <&backlight>; + no-hpd; };