From patchwork Tue Oct 23 09:37:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 10652887 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1195A14BD for ; Tue, 23 Oct 2018 09:37:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E54B429045 for ; Tue, 23 Oct 2018 09:37:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D8D772907C; Tue, 23 Oct 2018 09:37:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 69DA829045 for ; Tue, 23 Oct 2018 09:37:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728584AbeJWSAP (ORCPT ); Tue, 23 Oct 2018 14:00:15 -0400 Received: from mail-he1eur01on0062.outbound.protection.outlook.com ([104.47.0.62]:47104 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728540AbeJWSAP (ORCPT ); Tue, 23 Oct 2018 14:00:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TDVNlXmislBhd/6jjP8bMBd4mTtArfhSUu8tm31dIUM=; b=FaGM/p7Ddi06yo32WIOsxZseROSd67ToX0/1/p7iY9BiMrHv9A4PoocUhfMbLjGtjNVFTjgibQolYEFZ4fX6fH7HCUysDDbUzZi8f4mq4GarsKfQhoThMtjeBUHLZ4ge9HypxBEOXi3wSHN3oheIWwA2W0zzEVTOQFH9nhfUV0g= Received: from VI1PR04MB1038.eurprd04.prod.outlook.com (10.161.109.144) by VI1PR04MB5022.eurprd04.prod.outlook.com (20.177.50.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 09:37:06 +0000 Received: from VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123]) by VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123%3]) with mapi id 15.20.1228.032; Tue, 23 Oct 2018 09:37:06 +0000 From: Yogesh Narayan Gaur To: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "marek.vasut@gmail.com" , "vigneshr@ti.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" CC: "robh@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "computersforpeace@gmail.com" , "frieder.schrempf@exceet.de" , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur Subject: [PATCH v3 1/7] spi: add support for octo mode I/O data transfer Thread-Topic: [PATCH v3 1/7] spi: add support for octo mode I/O data transfer Thread-Index: AQHUarP2kz0cLmXyWk6HoE2nhS/6Jw== Date: Tue, 23 Oct 2018 09:37:06 +0000 Message-ID: <1540287311-1572-2-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> In-Reply-To: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR04CA0141.apcprd04.prod.outlook.com (2603:1096:3:16::25) To VI1PR04MB1038.eurprd04.prod.outlook.com (2a01:111:e400:5092::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5022;6:PzeMXwRjZRN8fCjBsp2aVcn/4+Zb9Az8RN2qIb42IuKvOIgqjcQwcPS8yvGQ70ZUHjteeZGxi/W/ZaFoFxrcNIEfwf6Oivt2aZHQKELzBHa+rqybEIrDiiToaH2TUHyZ5aPW3IKUHjbM8DAIpN0Kx560mSm8/7Rfp9V4o2HmVAkcvH/Ki4BO2HwgUE3K2xhSPAieyekIlNz5rpzQgfO5G6qBip29lt1yOv6WTERfX8vo2AaKZmAOkSU6N6PbWRaa96t97HRAmliPCP0ALXQzr/13vOVl4Bo7xRSyZUjkw6NhQuxIbVylcaHYfpwvNJZ2UAXQ5ATwZC3bAiw+QL6yij4sl6FdJ97WUYMu+1nI0X0c32wnDhy53la71QA5V/teT07TvO/vv62Nq4fVy0FVtWYiAFFBe+zIuIiigJz2rbr0u3PPieIyoifZ086SlHnx9ZynJKgBh6Z8q/MSoRmMOQ==;5:z1QKnF61Wo4lPFL9pwmW9YsiolM1m6EBJs5J/KCJ/RM7cYhEMvPG2WKdwFJRUL2k2hAppU1EwVRuGUS7A5XdIQZPLcQPKzWStLPb69mvvFqnKHivZ4E/ReHZ7qcotDj5ecMWuz+/AVBp4gGlhS/xDBFFoOnyNy9MHXVtL3gzQEw=;7:1LqntoGRsqj09BPsRqjEqLdxKx4lAup8gX0ytrYWK2uz8i4Ci3LVboDZu58b8uCxhpLGBYvljhMhXk+fb/AKTubG8e+6o/mcefKwrVFZGx/CFSjiaheoLTYIhwn4Kw8SwHVvZF1q7/QjzYFIdSlWZHB9tSIF9v6Hj/SrUzjnIOLoFWAytTNN2gIP2gfVVluWIBb+9FOBUNPyTdB5sCkQlxJG/1GxNekh7nwfLHlNiMwN6445KRbPj/EwYT80pHu/ x-ms-office365-filtering-correlation-id: d32094a2-f492-4104-b674-08d638cb1882 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5022; x-ms-traffictypediagnostic: VI1PR04MB5022: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR04MB5022;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB5022; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(8936002)(256004)(6512007)(106356001)(102836004)(446003)(53936002)(71190400001)(575784001)(4326008)(71200400001)(2616005)(54906003)(2906002)(26005)(55236004)(110136005)(476003)(105586002)(99286004)(3846002)(81156014)(7736002)(6436002)(305945005)(81166006)(7416002)(6486002)(2201001)(86362001)(186003)(6506007)(386003)(2900100001)(52116002)(11346002)(478600001)(14454004)(6116002)(8676002)(66066001)(486006)(36756003)(97736004)(5660300001)(39060400002)(316002)(76176011)(2501003)(5250100002)(68736007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5022;H:VI1PR04MB1038.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: VqLkTTcnen6duu2cN3dH785+6nDftu0XeZB0PZH7+juQtt6Z8ERq2MzqvS9Slfv0XdKQ89VdXL8YxqxK8QqwIA8lZDZSKUl/+shpIRLTFhiRHH7H7mgWYLl4uJdgVSu72kVyPN+ccL0dZb/rFthA/ZXvzAkA1uSH5RzEdGpsdv5rzB3td/7T2z8C3p4sZw0UanDIvnjWo5PxWGvfXZ6TNxZMyPYQnkpRa+wbh76dFCtu3SZdFSpvIcHxWHSTBm72OXXXZa4DUv/lmxqv7OuCGsP3CmUyIIuba+g22bVfh9M+bDjBohwrGcHhgFwD9dVhEkQfF6RBGSScOqoWJ1gEebtK8y6cODQSZMufiwx9PvI= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d32094a2-f492-4104-b674-08d638cb1882 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 09:37:06.7205 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5022 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add flags for Octo mode I/O data transfer Required for the SPI controller which can do the data transfer (TX/RX) on 8 data lines e.g. NXP FlexSPI controller. SPI_TX_OCTO: transmit with 8 wires SPI_RX_OCTO: receive with 8 wires Signed-off-by: Yogesh Gaur Reviewed-by: Boris Brezillon --- Changes for v3: - Modified string 'octal' with 'octo'. - Add octo mode support in spi_setup(). Changes for v2: - Incorporated review comments of Boris. drivers/spi/spi.c | 12 ++++++++++-- include/linux/spi/spi.h | 2 ++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index ec395a6..6d57fa7 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1573,6 +1573,9 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi, case 4: spi->mode |= SPI_TX_QUAD; break; + case 8: + spi->mode |= SPI_TX_OCTO; + break; default: dev_warn(&ctlr->dev, "spi-tx-bus-width %d not supported\n", @@ -1591,6 +1594,9 @@ static int of_spi_parse_dt(struct spi_controller *ctlr, struct spi_device *spi, case 4: spi->mode |= SPI_RX_QUAD; break; + case 8: + spi->mode |= SPI_RX_OCTO; + break; default: dev_warn(&ctlr->dev, "spi-rx-bus-width %d not supported\n", @@ -2770,14 +2776,16 @@ int spi_setup(struct spi_device *spi) /* if it is SPI_3WIRE mode, DUAL and QUAD should be forbidden */ if ((spi->mode & SPI_3WIRE) && (spi->mode & - (SPI_TX_DUAL | SPI_TX_QUAD | SPI_RX_DUAL | SPI_RX_QUAD))) + (SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO | + SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO))) return -EINVAL; /* help drivers fail *cleanly* when they need options * that aren't supported with their current controller */ bad_bits = spi->mode & ~spi->controller->mode_bits; ugly_bits = bad_bits & - (SPI_TX_DUAL | SPI_TX_QUAD | SPI_RX_DUAL | SPI_RX_QUAD); + (SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO | + SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO); if (ugly_bits) { dev_warn(&spi->dev, "setup: ignoring unsupported mode bits %x\n", diff --git a/include/linux/spi/spi.h b/include/linux/spi/spi.h index a64235e..cea4e49 100644 --- a/include/linux/spi/spi.h +++ b/include/linux/spi/spi.h @@ -163,6 +163,8 @@ struct spi_device { #define SPI_TX_QUAD 0x200 /* transmit with 4 wires */ #define SPI_RX_DUAL 0x400 /* receive with 2 wires */ #define SPI_RX_QUAD 0x800 /* receive with 4 wires */ +#define SPI_TX_OCTO 0x1000 /* transmit with 8 wires */ +#define SPI_RX_OCTO 0x2000 /* receive with 8 wires */ int irq; void *controller_state; void *controller_data; From patchwork Tue Oct 23 09:37:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 10652907 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 397CF14BD for ; Tue, 23 Oct 2018 09:38:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA68928821 for ; Tue, 23 Oct 2018 09:38:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD71628866; Tue, 23 Oct 2018 09:38:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D88528CF8 for ; Tue, 23 Oct 2018 09:38:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728583AbeJWSAS (ORCPT ); Tue, 23 Oct 2018 14:00:18 -0400 Received: from mail-he1eur01on0062.outbound.protection.outlook.com ([104.47.0.62]:47104 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728646AbeJWSAR (ORCPT ); Tue, 23 Oct 2018 14:00:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NYfNJEqoy0zjNNu1S2MCDXob7rykTjNz2DScZH9CYBA=; b=DRqwWpxcPkOG7OKRcEvEwz93RPO/mehGSOUCgtxccbGKWkwSs+Qt044WgBfPUHnUBcSZOTzyD+EnNtSPPe91siVwTc+jKwN4LFQXPJE3TDQ57hmzrzizUcjiV4f4rIboooN6ArUSMU6p58IF+AwYPpJSzNg4PAqg7pJ4TMfPypw= Received: from VI1PR04MB1038.eurprd04.prod.outlook.com (10.161.109.144) by VI1PR04MB5022.eurprd04.prod.outlook.com (20.177.50.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 09:37:13 +0000 Received: from VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123]) by VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123%3]) with mapi id 15.20.1228.032; Tue, 23 Oct 2018 09:37:13 +0000 From: Yogesh Narayan Gaur To: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "marek.vasut@gmail.com" , "vigneshr@ti.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" CC: "robh@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "computersforpeace@gmail.com" , "frieder.schrempf@exceet.de" , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur Subject: [PATCH v3 2/7] spi: spi-mem: add support for octo mode I/O data transfer Thread-Topic: [PATCH v3 2/7] spi: spi-mem: add support for octo mode I/O data transfer Thread-Index: AQHUarP6iu1ZGhKqmk2kqXdraHyfvA== Date: Tue, 23 Oct 2018 09:37:13 +0000 Message-ID: <1540287311-1572-3-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> In-Reply-To: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR04CA0141.apcprd04.prod.outlook.com (2603:1096:3:16::25) To VI1PR04MB1038.eurprd04.prod.outlook.com (2a01:111:e400:5092::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5022;6:vk1yfHMjECl0GnhHpOaV9D32X0cywSxl5SGQ9jWpnZ4iJvqyYEr4nu3tKI3BhwEkoCq4MfQNuC4wNML/WUfu7qkamJEKkcbP3+h7t/skSME8hYazTVgfM6QqXobF8PTKRRYfcq/+93Q1t5eAK8J2+incwc8pLsnCvLGqsAJ6NcTZTMrdDo7qVZ6/BI2tsHWcaBXjzSmaeU6Ow3aCI93GsW9c2iRKB73YJh1IThqRMo2C1VKqV1nL+cHTSE6fppDqD5LhGucuA1BPBa+eQ8ixzeMsBOubixJ+oFK/URMoMrRZqMJvZDSIVpbt7j+ItAMEk/kKBJnZBVaMeCKYeDkYEFETrXuqOTXbu1t55tsz4TCw6l2ZrnWBfaQX0d6UevNrUbP8p0pRaZpGyVMEbUBu5Wa5YWrVJbrdqLush5gK8A0Ncuzm5NXShDRiKx3oFHl76tpth5DT8JHy1WndbMf0Zw==;5:EYtMGJjUzrkQDuhz3t5HuiioGk6t6vS18h1t5gKHPuPSKUHGk8TXp7TNM7BXjmSrECpLD1yShDN8iMlgigzPeLyY+MZqa4857JSer+ziQuVlOF4zn+XyQeovte7KSJwMY6ttXAgpW5tGpliELTkMlo7NLrLmEJ0FFdGY4X0ONsw=;7:3VuFe8KyNBpXSwBKWfhSzjIGApe2z+nGGT0ESTmP5x9nYtJQ5OQsIY6Zp0C6zYZAFVs1vubDwzWxTFuyRIbQMpFXfx1EZacd2EPYNvX2L1iAf6nsL7IHs/h+nWERnWWGm700LQaU4x+QGS729YVINdDi9va9tn5xiXvkm/IpPupd6ewsDEaY9bL1ZnRg8OVCOhfJQaoq9eXteBt0Xdjh2GgECZebSfLnwP43BYv+CbVbWHcKMTbH9VWhEW9OjjVR x-ms-office365-filtering-correlation-id: fce4ddb0-81f8-4a53-1450-08d638cb1c43 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5022; x-ms-traffictypediagnostic: VI1PR04MB5022: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR04MB5022;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB5022; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(8936002)(256004)(6512007)(106356001)(102836004)(446003)(53936002)(71190400001)(4326008)(71200400001)(2616005)(54906003)(2906002)(26005)(55236004)(110136005)(476003)(105586002)(99286004)(3846002)(81156014)(7736002)(6436002)(305945005)(81166006)(7416002)(6486002)(2201001)(86362001)(186003)(6506007)(386003)(2900100001)(52116002)(11346002)(478600001)(14454004)(6116002)(8676002)(66066001)(486006)(36756003)(97736004)(5660300001)(39060400002)(316002)(76176011)(2501003)(5250100002)(14444005)(5024004)(68736007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5022;H:VI1PR04MB1038.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: PunxgnseFNJX/ivF3Ezrwrjv4db3x+zG+ATHpfxYshVn2I4pF03UVNqEnM8PwK6Ie3EbolzEs62S/96nI4ZLzMq5ltxvKu837IbTphmGDxVdy0g57JvosVvEfoHPknhAv8R6bVjPKl/XdWg9JmWI5Yw8A8FVKmtK2adFdYh8cpLCilpPVex31rA9Zcu9s+EkTnwb+7e/myNc+rgIvZ6U4Trnj8c13C55mx4yfXt60Tp5LH0Q+F3MtP8Yy0PlmZFk9vqwpCuqC+kUlPxbTLaPPhPig1zksru/HX74tHndswh+gP0CLYm/mE8vhKVyNLGgCp5eE3vDah6Ru7X5QIwTR3tl7tu/W+u9n1z5eFfyAd0= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fce4ddb0-81f8-4a53-1450-08d638cb1c43 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 09:37:13.0764 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5022 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add support for octo mode I/O data transfer in spi-mem framework. Signed-off-by: Yogesh Gaur Reviewed-by: Boris Brezillon --- Changes for v3: - Modified string 'octal' with 'octo'. Changes for v2: - Patch added in v2 version. drivers/spi/spi-mem.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c index c6bdea7..2379efc 100644 --- a/drivers/spi/spi-mem.c +++ b/drivers/spi/spi-mem.c @@ -12,7 +12,7 @@ #include "internals.h" -#define SPI_MEM_MAX_BUSWIDTH 4 +#define SPI_MEM_MAX_BUSWIDTH 8 /** * spi_controller_dma_map_mem_op_data() - DMA-map the buffer attached to a @@ -121,6 +121,13 @@ static int spi_check_buswidth_req(struct spi_mem *mem, u8 buswidth, bool tx) break; + case 8: + if ((tx && (mode & SPI_TX_OCTO)) || + (!tx && (mode & SPI_RX_OCTO))) + return 0; + + break; + default: break; } From patchwork Tue Oct 23 09:37:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 10652905 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ACE0D14BB for ; Tue, 23 Oct 2018 09:38:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A94029049 for ; Tue, 23 Oct 2018 09:38:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7A43929097; Tue, 23 Oct 2018 09:38:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF8CF29049 for ; Tue, 23 Oct 2018 09:38:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbeJWSAV (ORCPT ); Tue, 23 Oct 2018 14:00:21 -0400 Received: from mail-he1eur01on0062.outbound.protection.outlook.com ([104.47.0.62]:47104 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728540AbeJWSAV (ORCPT ); Tue, 23 Oct 2018 14:00:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5rzG3WPQ/vWy/Leb+z3Nf/BqWWvlqg4q9mYhu/fDnlQ=; b=EmUD1nLr2hrYkVjU2QWcFtdL1G5AJWMe+9XIb/u4F6vuVuBXCNlHXExh+zOUWW0QXyTHnoOoEMH59W7LQSkW2HWjF1WdhnT8nuZ7ki98UKRDTXRUM/m1rrRhRFfFtErjcx5eIFWzykFYZ+ZxoxOTm37rL9G+syTbntgnvgc2Np0= Received: from VI1PR04MB1038.eurprd04.prod.outlook.com (10.161.109.144) by VI1PR04MB5022.eurprd04.prod.outlook.com (20.177.50.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 09:37:19 +0000 Received: from VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123]) by VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123%3]) with mapi id 15.20.1228.032; Tue, 23 Oct 2018 09:37:19 +0000 From: Yogesh Narayan Gaur To: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "marek.vasut@gmail.com" , "vigneshr@ti.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" CC: "robh@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "computersforpeace@gmail.com" , "frieder.schrempf@exceet.de" , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur Subject: [PATCH v3 3/7] mtd: spi-nor: add opcodes for octo Read/Write commands Thread-Topic: [PATCH v3 3/7] mtd: spi-nor: add opcodes for octo Read/Write commands Thread-Index: AQHUarP935+sB2jvbkig6f9EUeBcCg== Date: Tue, 23 Oct 2018 09:37:19 +0000 Message-ID: <1540287311-1572-4-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> In-Reply-To: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR04CA0141.apcprd04.prod.outlook.com (2603:1096:3:16::25) To VI1PR04MB1038.eurprd04.prod.outlook.com (2a01:111:e400:5092::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5022;6:1PwrmJ7vnS44BQASRiF3MSmpfLaX3p3dczJi7Ls3owPnPJ6AEFnm6az9SxPQjARe/V43MUQTj1FVLmWazZSkj2MdPczwbDzbadXdrewj36GGnw6ZHWiLfPSx8b/CzRoxsSRIMxHokj7dZV+alcvNjuU+63OLLAzQEDX00KcyDFXfWD+gkTYq2iVTgn7UcT43yWZC+Ql3O9M0IMgIMw+oBwW6V4CpFGrRs6hjMwS7/hhM3X4E4N1hw0gFSGkmcwg70wV+HbMJRxuoFUiAkAPqAtIZv8zZcqC8SbCD8CC1RZVNPE9efM+AMaIlxGml8EFMGtnx7qK5Sy1lMx7YkVRKYOOrYpxtYY1kpmrpO+PCbbaCf5XcDaJbv+F+1tjoYZtDRRXNydLaJJ/+d+9h1JmgyN8EzEGJ+DbK2Z6Gy4UgbbDROGx15FMtClRQgQNx+ekBHXhGl+PkRI2FD7Kse8hKZA==;5:gFxfaZZMycoS/D/4OXdHqsrgc53yd99GpU1X4nRc7GPu61IzTZEoSHesYf9hPx0eYSm1MyaVtnPVvc6/7yac1Q86gnMqwzaHDtfK0lqiEJ0K+Q2V5QeSAKHvuL6LMaayBD/ZGgAB/lyFAs6FmR+VuAp9TUOsjl+g9FKPElAbCZM=;7:s15F9+d0ABVyz9d85sXsfSouQRTPYT3J5UPsr+88CX3eXqrLp9XSlCt8zg0ED7cu839WBPJho+Q0hwOc5GnZCVy48VqS6/HSAzuhQ7WLgBx1a1aA8ZlsQDmx9yLOoq4uO1s0dhGRkafwrOXOvCVc5YZX9XNBY2unWaJUGs1cTEpkgtYNMp7qpo6vfLkuwYNmlR7K2gJ7QpNlG956CW5hIZJz4flAAbeqKkZaR99wxEbhoTdD1anQR04eUYgNpUjs x-ms-office365-filtering-correlation-id: a6b1781d-dd2b-45cf-b504-08d638cb2009 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5022; x-ms-traffictypediagnostic: VI1PR04MB5022: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31051911155226)(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR04MB5022;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB5022; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(8936002)(256004)(6512007)(106356001)(102836004)(446003)(53936002)(71190400001)(575784001)(4326008)(71200400001)(2616005)(54906003)(2906002)(26005)(55236004)(110136005)(476003)(105586002)(99286004)(3846002)(81156014)(7736002)(6436002)(305945005)(81166006)(7416002)(6486002)(2201001)(86362001)(186003)(6506007)(386003)(2900100001)(52116002)(11346002)(478600001)(14454004)(6116002)(8676002)(66066001)(486006)(36756003)(97736004)(5660300001)(39060400002)(316002)(76176011)(2501003)(5250100002)(68736007)(25786009)(21314002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5022;H:VI1PR04MB1038.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: BmiM6noa5srAI0VU0govCaTWlJSQne1M8Bvr/NlaR138mbpIP9ZNWBO2hCb5QShqhfAZIMBQWG2qQamOgBvhubsCWXApyxuku29M/YyhkbCzVnVBzsgopj8d+leHxszNn43pD0hrw0I4ThgNzwCLivNeTVXzq9vI6xpiXJRKXQo69wuL/Ba4E+uxkzHaZoRPUJBP2CcUZRFNdmnWVd3X4YlwhRMqeASdjKr+LsX5z2iTa4pYeq0rn6QjwNPJ82FqD2zY4AoZfF6QRW8qwzRBu5rIS2koODxZmSuwrQvgl26gzufSTB73RrF/o0oyBnklYsbS0VRYFLnne6bFDEWH31maTB0AX+yXmstmGHSpAfc= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6b1781d-dd2b-45cf-b504-08d638cb2009 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 09:37:19.4303 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5022 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP - Add opcodes for octo I/O commands * Read : 1-1-8 and 1-8-8 protocol * Write : 1-1-8 and 1-8-8 protocol * opcodes for 4-byte address mode command - Entry of macros in _convert_3to4_xxx function - Add flag specifying flash support octo read commands. Signed-off-by: Vignesh R Signed-off-by: Yogesh Gaur --- Changes for v3: - Modified string 'octal' with 'octo'. Changes for v2: - Incorporated review comments of Boris and Vignesh drivers/mtd/spi-nor/spi-nor.c | 12 ++++++++++++ include/linux/mtd/spi-nor.h | 8 ++++++++ 2 files changed, 20 insertions(+) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 0b8a6e0..120c3bc 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -90,6 +90,7 @@ struct flash_info { #define NO_CHIP_ERASE BIT(12) /* Chip does not support chip erase */ #define SPI_NOR_SKIP_SFDP BIT(13) /* Skip parsing of SFDP tables */ #define USE_CLSR BIT(14) /* use CLSR command */ +#define SPI_NOR_OCTO_READ BIT(15) /* Flash supports Octal Read */ int (*quad_enable)(struct spi_nor *nor); }; @@ -209,6 +210,8 @@ static inline u8 spi_nor_convert_3to4_read(u8 opcode) { SPINOR_OP_READ_1_2_2, SPINOR_OP_READ_1_2_2_4B }, { SPINOR_OP_READ_1_1_4, SPINOR_OP_READ_1_1_4_4B }, { SPINOR_OP_READ_1_4_4, SPINOR_OP_READ_1_4_4_4B }, + { SPINOR_OP_READ_1_1_8, SPINOR_OP_READ_1_1_8_4B }, + { SPINOR_OP_READ_1_8_8, SPINOR_OP_READ_1_8_8_4B }, { SPINOR_OP_READ_1_1_1_DTR, SPINOR_OP_READ_1_1_1_DTR_4B }, { SPINOR_OP_READ_1_2_2_DTR, SPINOR_OP_READ_1_2_2_DTR_4B }, @@ -225,6 +228,8 @@ static inline u8 spi_nor_convert_3to4_program(u8 opcode) { SPINOR_OP_PP, SPINOR_OP_PP_4B }, { SPINOR_OP_PP_1_1_4, SPINOR_OP_PP_1_1_4_4B }, { SPINOR_OP_PP_1_4_4, SPINOR_OP_PP_1_4_4_4B }, + { SPINOR_OP_PP_1_1_8, SPINOR_OP_PP_1_1_8_4B }, + { SPINOR_OP_PP_1_8_8, SPINOR_OP_PP_1_8_8_4B }, }; return spi_nor_convert_opcode(opcode, spi_nor_3to4_program, @@ -3195,6 +3200,13 @@ static int spi_nor_init_params(struct spi_nor *nor, SNOR_PROTO_1_1_4); } + if (info->flags & SPI_NOR_OCTO_READ) { + params->hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8; + spi_nor_set_read_settings(¶ms->reads[SNOR_CMD_READ_1_1_8], + 0, 8, SPINOR_OP_READ_1_1_8, + SNOR_PROTO_1_1_8); + } + /* Page Program settings. */ params->hwcaps.mask |= SNOR_HWCAPS_PP; spi_nor_set_pp_settings(¶ms->page_programs[SNOR_CMD_PP], diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h index 8b1acf6..019f534 100644 --- a/include/linux/mtd/spi-nor.h +++ b/include/linux/mtd/spi-nor.h @@ -50,9 +50,13 @@ #define SPINOR_OP_READ_1_2_2 0xbb /* Read data bytes (Dual I/O SPI) */ #define SPINOR_OP_READ_1_1_4 0x6b /* Read data bytes (Quad Output SPI) */ #define SPINOR_OP_READ_1_4_4 0xeb /* Read data bytes (Quad I/O SPI) */ +#define SPINOR_OP_READ_1_1_8 0x8b /* Read data bytes (Octal Output SPI) */ +#define SPINOR_OP_READ_1_8_8 0xcb /* Read data bytes (Octal I/O SPI) */ #define SPINOR_OP_PP 0x02 /* Page program (up to 256 bytes) */ #define SPINOR_OP_PP_1_1_4 0x32 /* Quad page program */ #define SPINOR_OP_PP_1_4_4 0x38 /* Quad page program */ +#define SPINOR_OP_PP_1_1_8 0x82 /* Octal page program */ +#define SPINOR_OP_PP_1_8_8 0xc2 /* Octal page program */ #define SPINOR_OP_BE_4K 0x20 /* Erase 4KiB block */ #define SPINOR_OP_BE_4K_PMC 0xd7 /* Erase 4KiB block on PMC chips */ #define SPINOR_OP_BE_32K 0x52 /* Erase 32KiB block */ @@ -73,9 +77,13 @@ #define SPINOR_OP_READ_1_2_2_4B 0xbc /* Read data bytes (Dual I/O SPI) */ #define SPINOR_OP_READ_1_1_4_4B 0x6c /* Read data bytes (Quad Output SPI) */ #define SPINOR_OP_READ_1_4_4_4B 0xec /* Read data bytes (Quad I/O SPI) */ +#define SPINOR_OP_READ_1_1_8_4B 0x7c /* Read data bytes (Octal Output SPI) */ +#define SPINOR_OP_READ_1_8_8_4B 0xcc /* Read data bytes (Octal I/O SPI) */ #define SPINOR_OP_PP_4B 0x12 /* Page program (up to 256 bytes) */ #define SPINOR_OP_PP_1_1_4_4B 0x34 /* Quad page program */ #define SPINOR_OP_PP_1_4_4_4B 0x3e /* Quad page program */ +#define SPINOR_OP_PP_1_1_8_4B 0x84 /* Octal page program */ +#define SPINOR_OP_PP_1_8_8_4B 0x8e /* Octal page program */ #define SPINOR_OP_BE_4K_4B 0x21 /* Erase 4KiB block */ #define SPINOR_OP_BE_32K_4B 0x5c /* Erase 32KiB block */ #define SPINOR_OP_SE_4B 0xdc /* Sector erase (usually 64KiB) */ From patchwork Tue Oct 23 09:37:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 10652899 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3714C14BD for ; Tue, 23 Oct 2018 09:38:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 16FC028DA5 for ; Tue, 23 Oct 2018 09:38:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0B4D029049; Tue, 23 Oct 2018 09:38:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D0D0828DA5 for ; Tue, 23 Oct 2018 09:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728731AbeJWSAY (ORCPT ); Tue, 23 Oct 2018 14:00:24 -0400 Received: from mail-he1eur01on0062.outbound.protection.outlook.com ([104.47.0.62]:47104 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728446AbeJWSAX (ORCPT ); Tue, 23 Oct 2018 14:00:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jmdXWgEHp8XRel1doDtaRcO+0D2v6jISOd2eKhNZHpg=; b=Xpl2soHITEW9kwLbbG4XyDbpVHXBtH9LyrTRNaFvKASMS+2xHrXAUss7fjhFh1eu9Ai0QFLg6FmaNWsEuJP92gjKQwc7xUr0FGCvc+vPsW69IVAKgi4hJQhEaPVi4xwxG4monENWLpL1XUGTCTEtGPMZdBFPJ30UsanV9Ax+ric= Received: from VI1PR04MB1038.eurprd04.prod.outlook.com (10.161.109.144) by VI1PR04MB5022.eurprd04.prod.outlook.com (20.177.50.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 09:37:26 +0000 Received: from VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123]) by VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123%3]) with mapi id 15.20.1228.032; Tue, 23 Oct 2018 09:37:26 +0000 From: Yogesh Narayan Gaur To: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "marek.vasut@gmail.com" , "vigneshr@ti.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" CC: "robh@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "computersforpeace@gmail.com" , "frieder.schrempf@exceet.de" , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur Subject: [PATCH v3 4/7] mtd: spi-nor: add octo read flag for flash mt35xu512aba Thread-Topic: [PATCH v3 4/7] mtd: spi-nor: add octo read flag for flash mt35xu512aba Thread-Index: AQHUarQBzGIT8YtCf0iM54fpMwIFSA== Date: Tue, 23 Oct 2018 09:37:26 +0000 Message-ID: <1540287311-1572-5-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> In-Reply-To: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR04CA0141.apcprd04.prod.outlook.com (2603:1096:3:16::25) To VI1PR04MB1038.eurprd04.prod.outlook.com (2a01:111:e400:5092::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5022;6:lwb5Xh99wFymjC89VNThRa0HNih9hc1XU4t8N+alFxT41WlRlVo4Jt2jZkzIGPPX/p2/TDe669qe5YeBwvf8KR7mAYx5ujZqM+a93jAwYAqwOauJXyxah5rum696OV1JgSzcgw04oBSoGiVGFLcUq1itdGDFNSVEg2OXcbfCPoPmrkOD4eBEV1i/STrSW6aTLRsgrCYXNrpykwq1b95op4e7/HlNbKX997NWxc/pCdgWDPIAAKAtFfJ+/Y1VqJBgsDcG5ItmBC1Ev0dPbl8bRWEek4vL7ibr5A/rYjzpUkIuL9M2p7+lQq0HXOC/4wYr1b5OMrJNe0Y6amB03uQGUJ1wHLVHNX1V0YeBW4SKOigtYKZw85UfuNk+1y5R1Ps6lnWs2AxgdIFa/PUIUt08SkJ+f1g8tfZHQO5wXGWIjG2EfADHUI3I/MWx6S6CKo5eyB1871QxCDC/aTNBugr8JQ==;5:oLBj/K/YflCgO8QVsG+nRCdlTxJ0dXPFNsuhudZqFGy0llJPEcUGx9rAAQH+031m9K1WNJqN6W5C4VEA+qFKG/tOScHHERQX8vjosUsMPzi90nwb/G49nB8QI2z3MVYKIo10sS83GN2srRqGmK8lXWeTQDNH4DOfl0zmWi25xUU=;7:cQnlgysAfrlpipy60mm+1c9bP2ZYkeo7B9nq5EN3dn1LegkjwUNlMbynS10KgswT8qp0Mul2oWQ/DdteA7tjlbe+SLW4Mn5hsUZA8SCHx7Dkwg9nLXE+RbeGNVpBzUdtzEtA5cSAQafRwv6KEXKFFPXQWQdpKQ1Bb3P16gzWdM1N14iapNCLHJiZLu2RgLvSmL5hcurbtCTA63PFqjHN/8ZAtSnYY/H3bz2s8LAwSevFQoH+pyrwPcJ8Yxau5P8m x-ms-office365-filtering-correlation-id: 98b57d7a-4a20-4506-d3b5-08d638cb23e0 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5022; x-ms-traffictypediagnostic: VI1PR04MB5022: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(31051911155226)(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR04MB5022;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB5022; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(8936002)(256004)(6512007)(106356001)(102836004)(446003)(53936002)(71190400001)(4326008)(71200400001)(2616005)(54906003)(2906002)(26005)(55236004)(110136005)(476003)(105586002)(99286004)(3846002)(81156014)(7736002)(6436002)(305945005)(81166006)(7416002)(6486002)(2201001)(86362001)(186003)(6506007)(386003)(2900100001)(52116002)(11346002)(478600001)(14454004)(6116002)(8676002)(66066001)(486006)(36756003)(97736004)(5660300001)(39060400002)(316002)(76176011)(2501003)(5250100002)(14444005)(68736007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5022;H:VI1PR04MB1038.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: iISKfIXVfDt9CI6oYOsEf57Bn+a7P+oCzlVbQkmmVYVR7K+rV9X7kkBuK/PX4UiW/Pkz7b3Vg/AoMi5NhHeHMhyHvTv05EFB2mrcfHVj3nJjugPul5CoQLg9O3bsz0m48Iab9UDaETDCdOn/HiEt3RrMVbkTH9kGuiV83yQOXftsBEhIQyMYbtHzf2xng5GjRlr8DBlIWJv3CFqOlLpwq6ZPyIEZvifm5PGODcCoZarPjfFitITDckmuHix1A1Wyy9htdevoTV2HmUwtvvIOk8x5oEqZohS9eP1e2m0L4whQIDRQyN/mtGX2AxfphI6gL9be1e5me48pPPrI9OUtp22VxYAdTorQXoRRhPDaUXk= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98b57d7a-4a20-4506-d3b5-08d638cb23e0 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 09:37:26.1895 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5022 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add octo read flag for flash mt35xu512aba. This flash, mt35xu512aba, is only complaint to SFDP JESD216B and does not seem to support newer JESD216C standard that provides auto detection of Octal mode capabilities and opcodes. Therefore, this capability is manually added using new SPI_NOR_OCTO_READ flag. Signed-off-by: Vignesh R Signed-off-by: Yogesh Gaur --- Changes for v3: - Modified string 'octal' with 'octo'. Changes for v2: - Incorporated review comments of Boris and Vignesh drivers/mtd/spi-nor/spi-nor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 120c3bc..a04f579 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -1413,7 +1413,8 @@ static const struct flash_info spi_nor_ids[] = { /* Micron */ { "mt35xu512aba", INFO(0x2c5b1a, 0, 128 * 1024, 512, - SECT_4K | USE_FSR | SPI_NOR_4B_OPCODES) + SECT_4K | USE_FSR | SPI_NOR_OCTO_READ | + SPI_NOR_4B_OPCODES) }, /* PMC */ From patchwork Tue Oct 23 09:37:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 10652897 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EA64014BB for ; Tue, 23 Oct 2018 09:38:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CA14828DA5 for ; Tue, 23 Oct 2018 09:38:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BE7C729049; Tue, 23 Oct 2018 09:38:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 625A428DA5 for ; Tue, 23 Oct 2018 09:38:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728652AbeJWSAZ (ORCPT ); Tue, 23 Oct 2018 14:00:25 -0400 Received: from mail-he1eur01on0070.outbound.protection.outlook.com ([104.47.0.70]:21493 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728540AbeJWSAY (ORCPT ); Tue, 23 Oct 2018 14:00:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hrUMl5JWNpVfog1oDt0xvjozcc5pGrc5tm3PgwG7bqs=; b=GlLFn/k/yo68QP9pAshny6iUs1LQRQKDoZba1VGF4Ui7NuVHwouD9oHH45Y/yexY1gXxzYlWhoV98nzYYSXtPsJfMc9SF3auQKy5GXKadMwsuh3COW5oPZzDIaPGFsEZ7wi2gC3/3N6hJymsVzttEzG75VA8UmINTzXb57Ghls4= Received: from VI1PR04MB1038.eurprd04.prod.outlook.com (10.161.109.144) by VI1PR04MB5022.eurprd04.prod.outlook.com (20.177.50.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 09:37:32 +0000 Received: from VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123]) by VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123%3]) with mapi id 15.20.1228.032; Tue, 23 Oct 2018 09:37:32 +0000 From: Yogesh Narayan Gaur To: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "marek.vasut@gmail.com" , "vigneshr@ti.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" CC: "robh@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "computersforpeace@gmail.com" , "frieder.schrempf@exceet.de" , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur Subject: [PATCH v3 5/7] mtd: m25p80: add support of octo mode I/O transfer Thread-Topic: [PATCH v3 5/7] mtd: m25p80: add support of octo mode I/O transfer Thread-Index: AQHUarQFKUSi3S8l40SMwx6fJIUHGw== Date: Tue, 23 Oct 2018 09:37:32 +0000 Message-ID: <1540287311-1572-6-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> In-Reply-To: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR04CA0141.apcprd04.prod.outlook.com (2603:1096:3:16::25) To VI1PR04MB1038.eurprd04.prod.outlook.com (2a01:111:e400:5092::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5022;6:zf/FeTiMVin9Qn8wfpcXQS2Gy78FMg4HZqK85qPl+MPE2DvrFBefDtMUXT3eSEsnyXFBHsNXoJy1i58Y0//8brkBTUdoQjwk0ngM8OW5KII8DySrdUWtXexE4XQobvzz2z9X14QU2NSlN+yXdCLc6r+gRN8jmj/PZpFbQo8WgdbCUPU4vKoIQPWgmfrgiF/qiuIzMeLbRj7m2pLHxobVIaovhLzb0SSbdV07Hv2pmcQq5lH42922cmcaEumaktM+7IOgJ/IMx9IR3nkey5fcbRiFo5xrqFhWNmmuUPLa5Doa0Hd3ZF0ES4k9fbS3A35ab2poKXZNDpdKT5NNKqpu+Tv9CzQ3Biz+BHT9WMON1wmUndJn60I7B6mf8oS9AGxZAUY3i0FHpZ3hGdLvtZ8mzipjE6TVHqn3UEyP18sz7W0+hxa1zZ1wbb1ApMNTjJUYhebISEusntbE7d5iRNIL9Q==;5:O9lOHC3XJ+cjcUNXN7EOLcc6RRbXVP3SBLlSr6TZM1kZFP8vzpI2DZ9rLbTBvGcXLYjcFKhH29I0LOUCI3neAVU0tlx9Qir+M1+p5/Yd3w6yjfPMIwp+X+s94dAyZG7325rWpxJnqQSGRZH18IpnTwtQzpIYt+hgo2Dy8D7mGmc=;7:LDSpLw/2iUTYzV8phQyxHg4YB6euLIiuUDNuA/h6oNvSb0tgGTJdD18udBsug5260rcI3lXfXU6ScjMpmeQAkNsUAmk/cq4ZQD9Z4VsSN0gvT6V9Jmr190cQh21Cj4yAftz7AOzupBd90nef65Tn+JrM4ckwq9xF4/6eCfwjURnij4JQRveSC4nJRSsTWKbVBbcVC0TNU1mksEiA+32QVYgB/eS0TJw7hcBpVbzSg+WUOYLCIa6q0QCvXSWiFZag x-ms-office365-filtering-correlation-id: 80993390-66be-4e62-33b5-08d638cb27e8 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5022; x-ms-traffictypediagnostic: VI1PR04MB5022: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR04MB5022;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB5022; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(8936002)(256004)(6512007)(106356001)(102836004)(446003)(53936002)(71190400001)(4326008)(71200400001)(2616005)(54906003)(2906002)(26005)(55236004)(110136005)(476003)(105586002)(99286004)(3846002)(81156014)(7736002)(6436002)(305945005)(81166006)(7416002)(6486002)(2201001)(86362001)(186003)(6506007)(386003)(2900100001)(52116002)(11346002)(478600001)(14454004)(6116002)(8676002)(66066001)(486006)(36756003)(97736004)(5660300001)(39060400002)(316002)(76176011)(2501003)(5250100002)(14444005)(68736007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5022;H:VI1PR04MB1038.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: IGbew9nwttbqZeByoUJC3nMQR8QFg8CndbWI7iie7vQC8mP5Tu1MKodTY/NlQ+Xi+2yh6MM6NaMMkCCU+3BPBiTqB8SWquGfbqtZ1mOlSpir3c+FX9IasNaEogJ35i0x8tnLdOYvw75rB9WWdywBQ3mF6TrF37WIavvncOmX0az7OcCARlhMBaPrEHPIyHnv4lay7yZ5j2N58fVnctusXbO5jb7tZlWj8pcjxfICVqygps03S/q/NWJhWnhjmBrq6GbO9GgeII2KUthE3gldu/WwvSeB/d7zWjgOo+oRsklkQceRDiXceSHpuz/vxhAzBp6BH0FQlmRHxl7R2WghdlO1TZK0n6W0mGrjIsB0acA= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80993390-66be-4e62-33b5-08d638cb27e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 09:37:32.5344 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5022 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add support for octo mode I/O data transfer based on the controller (spi) mode. Assign hw-capability mask bits for octo transfer. Signed-off-by: Yogesh Gaur --- Changes for v3: - Modified string 'octal' with 'octo'. Changes for v2: - Incorporated review comments of Boris. drivers/mtd/devices/m25p80.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index cb14cf9..7d5c3a1 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -175,7 +175,14 @@ static int m25p_probe(struct spi_mem *spimem) spi_mem_set_drvdata(spimem, flash); flash->spimem = spimem; - if (spi->mode & SPI_RX_QUAD) { + if (spi->mode & SPI_RX_OCTO) { + hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8; + + if (spi->mode & SPI_TX_OCTO) + hwcaps.mask |= (SNOR_HWCAPS_READ_1_8_8 | + SNOR_HWCAPS_PP_1_1_8 | + SNOR_HWCAPS_PP_1_8_8); + } else if (spi->mode & SPI_RX_QUAD) { hwcaps.mask |= SNOR_HWCAPS_READ_1_1_4; if (spi->mode & SPI_TX_QUAD) From patchwork Tue Oct 23 09:37:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 10652889 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3768C14BB for ; Tue, 23 Oct 2018 09:37:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 172FF28DA5 for ; Tue, 23 Oct 2018 09:37:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0929129049; Tue, 23 Oct 2018 09:37:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9B67028DA5 for ; Tue, 23 Oct 2018 09:37:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728775AbeJWSA1 (ORCPT ); Tue, 23 Oct 2018 14:00:27 -0400 Received: from mail-he1eur01on0062.outbound.protection.outlook.com ([104.47.0.62]:47104 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728548AbeJWSAZ (ORCPT ); Tue, 23 Oct 2018 14:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PfrTXoZG6eK6bbB5BaJyAY0kDt1bRK34E3DWIq5cXHU=; b=HSHyVx/aQuU+qId+THMVJWKVp9d1dSB9wpZatP8va1FT5MIf/YwpySHogl1Xy5D4LiyFMr2qHmfGPNShdcn4aMfPyLFeQZRU55JZYQDI2J8QPQlbFL3QAHMZHbB9f57KSzhsg1pMSq0WjzNAeiDrDoGjL3FRFs80410SNy9NCAw= Received: from VI1PR04MB1038.eurprd04.prod.outlook.com (10.161.109.144) by VI1PR04MB5022.eurprd04.prod.outlook.com (20.177.50.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 09:37:39 +0000 Received: from VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123]) by VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123%3]) with mapi id 15.20.1228.032; Tue, 23 Oct 2018 09:37:39 +0000 From: Yogesh Narayan Gaur To: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "marek.vasut@gmail.com" , "vigneshr@ti.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" CC: "robh@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "computersforpeace@gmail.com" , "frieder.schrempf@exceet.de" , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur Subject: [PATCH v3 6/7] spi: nxp-fspi: add octo mode flag bit for octal support Thread-Topic: [PATCH v3 6/7] spi: nxp-fspi: add octo mode flag bit for octal support Thread-Index: AQHUarQJFib3X2sTsU+eCnYlpZh0fw== Date: Tue, 23 Oct 2018 09:37:38 +0000 Message-ID: <1540287311-1572-7-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> In-Reply-To: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR04CA0141.apcprd04.prod.outlook.com (2603:1096:3:16::25) To VI1PR04MB1038.eurprd04.prod.outlook.com (2a01:111:e400:5092::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5022;6:Jj++ic93vpRyEMkiN5VVlYzYdYeuK9SHlQXBQhy72e02x4A13xit9+pKCCOnyTCFyRMgme2yAzhLUCLCskeafPBFsD2XcE4/erc4giAk4Rvz5lA4c/TpcLbdizQotN2GDIlPeC8tBjUh2SRBL7UZTqHOesS4aaD0T/l80fv9eVn/gQdiBkoLnxz3+wo10R0fhwP8QqqCXyKfs2LuU+L6qiTGwE6gOf4rX3CrqEDwBFB4kifGRwVGyGfnReJIZThFTXa4IwNgxXcasZ5o0VFGHtsu1/zY6C/yZZMUM4sfhY7pCqBafPVgDeqg5anfWUyK0Ji3sw9cysU7A2L1MbOsRubNnzBpUR63bT185KGKAppJfZQdbEPkZ2X7+FKjWgpYzSJbtRvQU2xWPWly3mkJCI3wVl88Ra+Yr+oOnnGmIyOVDQLA7cJ2rgtIxjJSMCEbr22HKqHKDT7sWftqSgY2wg==;5:OCVLg5rK4QV6jBhyK7LL0JrGjHv1v5o1rvlAtjCSU8JH0pGXlHYTg+m95K8cfrWFQSvOHUkXckQ/KQ3PKTMWg4qYP2mh0/zB3JoVjTSOkOuWrH0mIbwxIGQvtjCmLUoTpCoY97WTYMiQlfWPJUQLbKHXO2XE6/0RerWnGDZLcNA=;7:/39LFSr81zES014OT7FpDdra723EtGp16FHtcM/aoLCNhyeMlBeci3UCI834fxrgsJi3pkO63baoqg9hbYSJScligvkAi1EIfc/rvru391h+ORYWa51H3GMOiAx3xXIwur5Gm22OSXWfsFKCGjGTKFQg65LbFpVxHDRwFUFSe2PdPL3IbAf8Ki6A8O9BFu4HYIgGtcNUSCk6nKMovKEdnRWFuUYRZk4tJSzVsuNoxxdZjbrOeUKIFmPF6OgHraQd x-ms-office365-filtering-correlation-id: 8a79277d-4db5-478d-9928-08d638cb2ba4 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5022; x-ms-traffictypediagnostic: VI1PR04MB5022: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR04MB5022;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB5022; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(8936002)(256004)(6512007)(106356001)(102836004)(446003)(53936002)(71190400001)(4326008)(71200400001)(2616005)(54906003)(2906002)(26005)(55236004)(110136005)(476003)(105586002)(99286004)(3846002)(81156014)(7736002)(6436002)(305945005)(81166006)(7416002)(6486002)(2201001)(86362001)(186003)(6506007)(386003)(2900100001)(52116002)(11346002)(478600001)(14454004)(6116002)(8676002)(66066001)(486006)(36756003)(97736004)(5660300001)(39060400002)(316002)(76176011)(2501003)(5250100002)(68736007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5022;H:VI1PR04MB1038.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: QVz24stktWo2pdTb6B2pnGmGLgd22WwpbAQ95umN1NFr7a4rCU3JUeJbrPAeIZzTC2oY+hd7i+dMl2sxL7z++nhblScHUYpkI/b+3SlNkgQ946ZbP+P1zaZxzWBSSmGX6znaUWkUKZ60AYNRcahGrfzikozryT3/OVus/VXyuXhkFPCi5g95KcLFmujNIX3qeoA4LHX2e36gOGf6+BUARnCxD6iB4JsofO+7Tc99/K9HFQThGFUt0ruo8JadFkENAt5A4km6ZmdEPDYR+urZhFen7AGaStKGsBbGg3RAVkl3irJcIPZXkbJ3Pl9BpJyT6bTotfxEu6kC4E3K4X0D0AjNozxiuSp+ASvzUsGzH3o= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a79277d-4db5-478d-9928-08d638cb2ba4 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 09:37:38.9143 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5022 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add octo mode flags for octal I/O data transfer support. NXP FlexSPI controller supports 8 lines Rx/Tx data transfer. Signed-off-by: Yogesh Gaur --- Changes for v3: - Modified string 'octal' with 'octo'. Changes for v2: - None drivers/spi/spi-nxp-fspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c index 67eea88..332b730 100644 --- a/drivers/spi/spi-nxp-fspi.c +++ b/drivers/spi/spi-nxp-fspi.c @@ -993,8 +993,8 @@ static int nxp_fspi_probe(struct platform_device *pdev) if (!ctlr) return -ENOMEM; - ctlr->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD | - SPI_TX_DUAL | SPI_TX_QUAD; + ctlr->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD | SPI_RX_OCTO | + SPI_TX_DUAL | SPI_TX_QUAD | SPI_TX_OCTO; f = spi_controller_get_devdata(ctlr); f->dev = dev; From patchwork Tue Oct 23 09:37:45 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yogesh Narayan Gaur X-Patchwork-Id: 10652895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6C89614BD for ; Tue, 23 Oct 2018 09:38:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4D79D28DA5 for ; Tue, 23 Oct 2018 09:38:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4177F29049; Tue, 23 Oct 2018 09:38:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D41C328DA5 for ; Tue, 23 Oct 2018 09:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728607AbeJWSAc (ORCPT ); Tue, 23 Oct 2018 14:00:32 -0400 Received: from mail-he1eur01on0070.outbound.protection.outlook.com ([104.47.0.70]:21493 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728446AbeJWSA1 (ORCPT ); Tue, 23 Oct 2018 14:00:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CTAqCCACinXAuZQNte12dKQSA+UtLpD4EpPsu+Yo1dQ=; b=AJax5weT9jIWu8c82TD/BkEhf1BjymCq70E3oNTDVPqi4OYJnIRKaOT1OMKtb/UOZzFdZOFlaSSF4vznzoEhEoJkgjWbJeA85OMSQFxfAhP+Eoi261NJBnuALG4yo5tiOXIOqnS7sxJ9xc2YL9aRDoJPW6faTKzq0lo5U/59w7U= Received: from VI1PR04MB1038.eurprd04.prod.outlook.com (10.161.109.144) by VI1PR04MB5022.eurprd04.prod.outlook.com (20.177.50.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.30; Tue, 23 Oct 2018 09:37:45 +0000 Received: from VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123]) by VI1PR04MB1038.eurprd04.prod.outlook.com ([fe80::d887:3c96:479a:4123%3]) with mapi id 15.20.1228.032; Tue, 23 Oct 2018 09:37:45 +0000 From: Yogesh Narayan Gaur To: "linux-mtd@lists.infradead.org" , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "marek.vasut@gmail.com" , "vigneshr@ti.com" , "linux-spi@vger.kernel.org" , "devicetree@vger.kernel.org" CC: "robh@kernel.org" , "mark.rutland@arm.com" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "computersforpeace@gmail.com" , "frieder.schrempf@exceet.de" , "linux-kernel@vger.kernel.org" , Yogesh Narayan Gaur Subject: [PATCH v3 7/7] arm64: dts: lx2160a: update fspi node Thread-Topic: [PATCH v3 7/7] arm64: dts: lx2160a: update fspi node Thread-Index: AQHUarQNpTOpT9Qzw0WWWurUQJ1BSA== Date: Tue, 23 Oct 2018 09:37:45 +0000 Message-ID: <1540287311-1572-8-git-send-email-yogeshnarayan.gaur@nxp.com> References: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> In-Reply-To: <1540287311-1572-1-git-send-email-yogeshnarayan.gaur@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SG2PR04CA0141.apcprd04.prod.outlook.com (2603:1096:3:16::25) To VI1PR04MB1038.eurprd04.prod.outlook.com (2a01:111:e400:5092::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yogeshnarayan.gaur@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [14.143.30.134] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5022;6:4S2SNm8L8wqiH1RhyrnBCV3sn8jIJDj18vtQcTszVnQZOUiF5jz8zO+L1F4NwPU6MOeZ4aoAWcs/0TIF7bBwGsVQCqJk0TnOVCR95s22qCm0cMHC7pHLtYpGAqbIiOsw+26u0HDlVjIBG9SWEZVx6wGe16DRedUpaytPRPibCJmTj6HkHyz4EWqxkr8JN9gcv2/XFp5DbkdWgyqtc0ebreCwN12Psv7JXPB2EBpjwTEscFogSltKqWNEwZjHvHez4U5s/AguVraH8Y97+merJk9EOyG4BgWORa+xFU2R/4MhKoqH7QA0pIOitLV+C0qpBxWhlgFySNR3VKuTA5ORykTtaYYfPvLjbjBm3zxbPoW5mgXG2KCYJRDNd15qiZovf6mLcWe4W3DEtBhBVZDJJC82TtPTjSdexN3pOVhUsU4d818t2mwYeuonaAG5wtK760fGTP911U1P/sID4pA1VQ==;5:XjmPgOzEgJIoba8eeT1i01/sWW6zdt3IuAD0INxjIZJuhnRowahvuc1wPddI0nEsRWVNT0sNYAgdt0yehhjr5xTaVcqnY2EdgRwOfAOngTEDy7GaDOeobM5EN/nIcwrrHfvapZXOryNoj6UNBcyEtWan2nZdJnyO063Pj7dWvh8=;7:4YnKUuE1MVlio2JPCdffG+RaWbeHUMKbxvdV6WEv67vuVrWcAmRTrQ3MLfQ0h427UjC5/Q5ouzG1Vlg75L3k5w1QcD0+dzbosEbv358uBzbjb7rrIgQAJAenrMmk3kmtHLJBc7pQ6vHRRdRqE7B1giKHdQqsRZiU6ME9SJxJ1esU6/RyKzqhs+MxrdG64ZbTapdTL3fNwrSsyyimGo879jcWTe2k0O/nOZazb3SVWFgWwb73vq5pw8G2pS2NYKmh x-ms-office365-filtering-correlation-id: aeb0008b-4a5c-42f1-cad3-08d638cb2f71 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989299)(5600074)(711020)(4618075)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5022; x-ms-traffictypediagnostic: VI1PR04MB5022: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231355)(944501410)(52105095)(10201501046)(93006095)(93001095)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(20161123564045)(201708071742011)(7699051)(76991095);SRVR:VI1PR04MB5022;BCL:0;PCL:0;RULEID:;SRVR:VI1PR04MB5022; x-forefront-prvs: 0834BAF534 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(396003)(346002)(366004)(136003)(376002)(199004)(189003)(8936002)(256004)(6512007)(106356001)(102836004)(446003)(53936002)(71190400001)(4326008)(71200400001)(2616005)(54906003)(2906002)(26005)(55236004)(110136005)(476003)(105586002)(99286004)(3846002)(81156014)(7736002)(6436002)(305945005)(81166006)(7416002)(6486002)(2201001)(86362001)(186003)(6506007)(386003)(2900100001)(52116002)(11346002)(478600001)(14454004)(6116002)(8676002)(66066001)(486006)(36756003)(97736004)(5660300001)(39060400002)(316002)(76176011)(2501003)(5250100002)(68736007)(25786009);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5022;H:VI1PR04MB1038.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: yKqvWg7ceVIV1fDzIdnW8LAgfPYZzaKJsr2MKQUubZsn9q3qIT10UyMbU7QaEkiVYae/ypO+Ja+wZDprzWKuCsOCrOEEgx3VygNa2ymD/jiMeXYEwUxP0eAQmx8GUdX83G69BsNEldFnBYfPXeO8eWcnf/iFd1C4bLG4ucbZqBVJFmyi25WJugTHupLFs/1IfGhjQ0E8gh1LUmP+tU5Dz5ds6mfPUIjwa5xc1jLNjyY7RZSyuSEVvprhWUxWA6n44FBmUmmYiAe1gRxO0/lmSWdpcqjPp9aUzDTvxRbEK/LDwjzgIrDUDRiZvZFrK1vUsWlvyDX1+9w87OYwdv/c55vSfKbq5teCytlaU27xNpY= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: aeb0008b-4a5c-42f1-cad3-08d638cb2f71 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2018 09:37:45.1251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5022 Sender: linux-spi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-spi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Flash mt35xu512aba connected to FlexSPI controller supports 1-1-8/1-8-8 protocol. Added flag spi-rx-bus-width and spi-tx-bus-width with values as 8 and 8 respectively for both flashes connected at CS0 and CS1. Signed-off-by: Yogesh Gaur --- Changes for v3: - None Changes for v2: - None arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts index 3b20c97..24cc41c 100644 --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-rdb.dts @@ -45,6 +45,8 @@ m25p,fast-read; spi-max-frequency = <20000000>; reg = <0>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <8>; }; mt35xu512aba1: flash@1 { @@ -54,6 +56,8 @@ m25p,fast-read; spi-max-frequency = <20000000>; reg = <1>; + spi-rx-bus-width = <8>; + spi-tx-bus-width = <8>; }; };