From patchwork Wed Sep 2 02:53:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11749653 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 753FC1575 for ; Wed, 2 Sep 2020 02:54:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E40A20707 for ; Wed, 2 Sep 2020 02:54:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uOaTZfu6"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Mmg3k909" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E40A20707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/nUpx2Zs2or78oyu/z+nZEa3UqSN9l6CTgRzgg9vzEw=; b=uOaTZfu6SvIAL0RmPYVloVFkz MhGeY1KFLGzTi4sMfo0zh1mPimYne9KOr55FZfdvUrVg+aC2OD3hazQ4KZjFjpWV8U4tj8siJfONl o7kx+HDdB/lY2RlHbibyzfELeEHmAnYTkqwkJKrpxcpS0sug9DlUCtR4sB6sh9x8a9Po9C1NvLPWr 1R/s6KYNQuIIijqLYZhudCNFO8GVq/A2sa9VcoiKyKtKJcJexO4idWpfi9tSTX65wHA6RbRSUzQJe rNU9fIlnKCzA+AdpQtzbKJYZN1hmM0OUm9F/cvvSImH3KpEJGi4PNDX/n8u53ZqYzydZ4dgsTMqQz YzR/0jFMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuT-0003aL-DX; Wed, 02 Sep 2020 02:54:05 +0000 Received: from mail-pg1-x541.google.com ([2607:f8b0:4864:20::541]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuJ-0003VA-V9 for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:53:57 +0000 Received: by mail-pg1-x541.google.com with SMTP id p37so1791748pgl.3 for ; Tue, 01 Sep 2020 19:53:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=Mmg3k909Im5tPr616qMO7eR07LAJFZClo5qultGvx7lHP5OI+oj6Z0PZ+3rp3MvDA3 EKIdRq33UoHLNu/CJNmyG2b1rFixQhYPrXAA7dqL2iwb7efBZBRwDdWCR5SgWF4hYhHi lpG+N67GmcyXWCsOwQrq7S6QnuK7PbTqvLQO8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HVX5iGApWsA6cOcKpocM02MsLs3Cms0hUFmAcEqMm6M=; b=p8wtTH9g5uwjtT4Avuma1sLWKma8Bx7Dq3u/UaffwH1YTLh1RZvS/Ge7hXzB7b/dX0 /8IKp/UV1OZj3NJ3kyj8ecx4TIIkP82tklum5W9uglGZR+nWFvGqREQ92VqlpnEQ5kEe LtAAzxEiCsHF33MQkQDf6W/o0umiVvOtHHvzqUDa9p1TZg7AOcmXNJ08C5qjTyVGiL1+ CEdMkKQKgsIgXVQ6qKO0D47MshVVB5scDQxqelA0+DkUre7oq1SI11xG5v26Tyvu3f0i GqA8yYWdn/HaQAPO/YzcqWUtgNccFZc0fyaR9g58imXOFF7+YnIbuo9W2vwqCftsjSiB 6EpQ== X-Gm-Message-State: AOAM532tbTx5/4E3+pwDicQKm5oc8UtgWaHXMFID6MfnaGR8WyHIzZD1 ThqEDI4hRAnuogSqZHC0GtMi4Q== X-Google-Smtp-Source: ABdhPJxr15UxFlZO57N08QLgROI0XgkvScTspshNJ0zdFmYYhSNaiyEAMbuocRhYqDliU1QV3ZPnLQ== X-Received: by 2002:a63:6d41:: with SMTP id i62mr199101pgc.279.1599015233901; Tue, 01 Sep 2020 19:53:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id q7sm3438860pgg.10.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 1/5] arm64/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:43 -0700 Message-Id: <20200902025347.2504702-2-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225356_036190_B6C57DC9 X-CRM114-Status: GOOD ( 13.07 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:541 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Peter Collingbourne , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Will Deacon , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. With all sections now handled, enable orphan section warnings. Acked-by: Will Deacon Signed-off-by: Kees Cook --- arch/arm64/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile index 6de7f551b821..081144fcc3da 100644 --- a/arch/arm64/Makefile +++ b/arch/arm64/Makefile @@ -29,6 +29,10 @@ LDFLAGS_vmlinux += --fix-cortex-a53-843419 endif endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + ifeq ($(CONFIG_ARM64_USE_LSE_ATOMICS), y) ifneq ($(CONFIG_ARM64_LSE_ATOMICS), y) $(warning LSE atomics not supported by binutils) From patchwork Wed Sep 2 02:53:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11749657 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 44BB0618 for ; Wed, 2 Sep 2020 02:55:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E131206CD for ; Wed, 2 Sep 2020 02:55:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PVZGbep1"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="etH6NKPq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E131206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cV/ZJgwwYP5xaDZ0GxUjGYE+OHlaAK4CwS4qXQV1q3Y=; b=PVZGbep1Oxvcql6lTvgxdCGVM SLup+i4StT+R4qoqQSjY0IBFn/v1r99dAW0HZdYAFhkmGoW05jPS1y6EoNN3mQVi158x4uFOJbPt6 Bockb3/Um3WYY+z01iDfkVhmItzqswTsmU+Pgs4/vaMCb4GPqJlQpwbscKFrXLundD4CKAVwhCeRQ tR2EIbwWO018t3N2SF2+RJ2E2SmR3V6IDblZ5yOV91/X4oMjWhWekph8bqCxjUey5wVw/iAgOs5v/ gXDUokFEm/P8p88wm8wrHdkhf0lLa9tWD6lGhnHPqQQNuOmiGC4FR7akSgKiqIkbEpmg/1XajJCss wlirdFyNw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuN-0003Xm-6p; Wed, 02 Sep 2020 02:53:59 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuI-0003Uq-Jl for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:53:55 +0000 Received: by mail-pl1-x641.google.com with SMTP id a8so1587143plm.2 for ; Tue, 01 Sep 2020 19:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gClGbep+iV5WfCNFybEdnpd2yOKBqRu+dgKC1E3FLqg=; b=etH6NKPqvQ0E/BEfK1vGJeNK5TqdvKBju+PVw+Mb41Om+kz+V3liIydjrFcRux4SkU v05mxqn5MJF8kH9X94XWKQG2jM7AFeMLaNS02HEIB7YHiurUIEtkT+i/BFHv0qdgbId+ JfK1I292Rf3BQCyWOqL6J7XZBXjo/fSJ76OhM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gClGbep+iV5WfCNFybEdnpd2yOKBqRu+dgKC1E3FLqg=; b=ZtAsnmR5GwJBacIoj4/zFL9S1dzKxynSzvfY8uawGJYHIQynNIvakE0QyyDxrMlUxU /wKErU3VuCwDaighEpm7A3I0+Sn3f+o8i95WPkEGYd28ub6JQtnP3MBBLCNXiFWABXUM iZ9IQChzgC443QdjUEor0oayDGPKLQxNrVpiPWOVaRujTVymXDQBsGe3vEfu3ZbodH4b osxfmv8NYutBnS0WFM4C5dOZHBrHppDuj+0GALrSFGQCrPj6SW+dhhB7Iel7iDcgNoSt 8tmRY6LuYMTHDJniqAYnEbuXDvop87Q1kkkGK6e/Tr5JwCPWCJXBn2XrjmST9mAifCdi PjMA== X-Gm-Message-State: AOAM532aMudFv88HeSUjI51nHI8YYOevhUVSOAyWqBVbEST8sY5yoKDg mthl+o/99tgT+mR6rdmVeNmYgA== X-Google-Smtp-Source: ABdhPJzgc+AwMOXYevHKlYRL3a9Gq1SPcptqwTmA/q6SZkJHgbLxcLNKxPWoUeQVwVN+9q7tAZgD6w== X-Received: by 2002:a17:90b:4d0f:: with SMTP id mw15mr256915pjb.174.1599015231590; Tue, 01 Sep 2020 19:53:51 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id y4sm3597155pfr.46.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 2/5] arm/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:44 -0700 Message-Id: <20200902025347.2504702-3-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225354_691811_42A6CC49 X-CRM114-Status: GOOD ( 12.92 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:641 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. Specifically, this would have made a recently fixed bug very obvious: ld: warning: orphan section `.fixup' from `arch/arm/lib/copy_from_user.o' being placed in section `.fixup' With all sections handled, enable orphan section warning. Reviewed-by: Nick Desaulniers Signed-off-by: Kees Cook --- arch/arm/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm/Makefile b/arch/arm/Makefile index 4e877354515f..e589da3c8949 100644 --- a/arch/arm/Makefile +++ b/arch/arm/Makefile @@ -16,6 +16,10 @@ LDFLAGS_vmlinux += --be8 KBUILD_LDFLAGS_MODULE += --be8 endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + ifeq ($(CONFIG_ARM_MODULE_PLTS),y) KBUILD_LDS_MODULE += $(srctree)/arch/arm/kernel/module.lds endif From patchwork Wed Sep 2 02:53:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11749659 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C61E91575 for ; Wed, 2 Sep 2020 02:55:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9F425206CD for ; Wed, 2 Sep 2020 02:55:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EvBVadsF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="kCu8hyTc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9F425206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H5kpCNvneduROhbNhMWowmLeARFoEbm8ahT5/k/sSe0=; b=EvBVadsFwTyGrZzUqMb1z6q/U JNOc+pXQzugYjitfy6Bbnqf3cBGAfHmt3R+qdCIjsy5oP55KBlyhz+OZSnwhczRR1k8MSNyoeqdJV OK3Ej6Hyd9ciJvtlggvAdh+oiptkdP+nAzThCczEtSH8pOUo0idMc6sX8ggDjI7aRsYPPGMtzze7x y9EKY613LMTEeGHkW6TDgpREaLvAUEuoPsW5wx1Ls6FDU1/lvJcJc+DwAb5/aWtFp/Alyq79UH5oA ER2WE5O6ZT0Y+BnoGRRqLwL512bTU316vwM09lEmr4WZwOWrE/uL9tX6AiW+NfVMEq5m4X73J19CJ GV1P9ICPw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuR-0003Zp-3E; Wed, 02 Sep 2020 02:54:03 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuJ-0003Uv-4Y for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:53:56 +0000 Received: by mail-pj1-x1041.google.com with SMTP id 2so1638841pjx.5 for ; Tue, 01 Sep 2020 19:53:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XPZJbcEtwfQTjOb/c8yhPFEhILSdoB+KS72tNB8EcNI=; b=kCu8hyTcGoY7RYojj6lkArYLYWRPCSJax2BgpnkrA4p6KHwO/KDpfqBFFVqydUb61M KelRtaHdh8yEvhXTfGGBKZyqjY4QUC3HvxL/Mnd4l1/NUfthfp/+uqRjf7TZvXRoaXUv KtH2K7YG+GNs7sb3j+14YNKypSfg/mtqzN72k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XPZJbcEtwfQTjOb/c8yhPFEhILSdoB+KS72tNB8EcNI=; b=MpThHc5MVl7xOvUAf7oRJFUxp2m3rF2FPXKb34ZKFxedUQ3NqmoiCGiZy0t6A0UNW/ Icp0nrdMJPQb4uJBOnTu4fq4Q4yceDqSdSwIysykmZenGcon7ZE6WTaMU+rhKEX3bsCL +d17/KIYYfg1+9Y/4eCpNY0KE8H4lhckJ2JzBm3kccvDh1ElO3IkhxrHx3+PgfUwNGlP 7e2qw74bGaLxE9rwVLN3K5KbquhPVXr59ELO/FlJRu/rV3ImSOqtVNQYzOAqF7/y9tmt Ad1Jij9npILQNKF6ZCRJxvoa1ZD8fgj8UnDGRlYzcXvhyEqjSTbWwAE9FLHhyxEfeJUt HKNw== X-Gm-Message-State: AOAM530ELJ3sqX/Y14mJIp6y/GzAOGVzGm5UU/okpEL+sYas8iAR+kOV 8dTPGPG7ax4CXELcXqpTQam/vA== X-Google-Smtp-Source: ABdhPJxv9F6zTbZLG31keWGzI4N4ccr5wX8ALy3FKGq8wAk/IzXEKUXCP56QRYBrM4KTWBz2JqF6Qg== X-Received: by 2002:a17:902:b20e:: with SMTP id t14mr253940plr.58.1599015232244; Tue, 01 Sep 2020 19:53:52 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id g5sm3575074pfh.168.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 3/5] arm/boot: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:45 -0700 Message-Id: <20200902025347.2504702-4-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225355_203851_C9C60E2D X-CRM114-Status: GOOD ( 13.51 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1041 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. With all sections now handled, enable orphan section warning. Signed-off-by: Kees Cook --- arch/arm/boot/compressed/Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/compressed/Makefile b/arch/arm/boot/compressed/Makefile index b1147b7f2c8d..58028abd05d9 100644 --- a/arch/arm/boot/compressed/Makefile +++ b/arch/arm/boot/compressed/Makefile @@ -123,6 +123,8 @@ endif LDFLAGS_vmlinux += --no-undefined # Delete all temporary local symbols LDFLAGS_vmlinux += -X +# Report orphan sections +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) # Next argument is a linker script LDFLAGS_vmlinux += -T From patchwork Wed Sep 2 02:53:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11749655 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7A069618 for ; Wed, 2 Sep 2020 02:54:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 530FC206CD for ; Wed, 2 Sep 2020 02:54:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bxuqNnkS"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FwZ8Z44S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 530FC206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XWirrUFG3JqJOjJBL5ebHp5rwj5wVqJO1co4gRAaxMQ=; b=bxuqNnkSRC1SpTZBXwhpfXdmu Tlm6rZoy8UEEQqUP7hzK0s7Xa1R/9sErWGh/3a6wEY7DYmn4Mx/d01SvGa8/bsc6N0cjHEuVNL4oF EQQ890SssbbtgxAVOICdy1PX2we2GOFzMBEpzRfPF/FmiKJ/43RUxV1iqxR8okc1N5br7KVHp4Y0v yvwAkIMp4P7JBqupIX9d/lahR6GUQsZQAPrGSZH1/G62JWQ5q2qQpvYT8xB2BQ+ASuXGfNSoPUdyX SSMD/xgikSx9nEem3f90bjKcCO/lEsYu64KA2AIlNOa9nFE4r8wFxutNs/fPBtUEisKqPNiHbLN1K Q2KGKSmfw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuY-0003bi-NK; Wed, 02 Sep 2020 02:54:10 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuK-0003Vr-PG for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:54:00 +0000 Received: by mail-pf1-x441.google.com with SMTP id f18so2014165pfa.10 for ; Tue, 01 Sep 2020 19:53:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bSRmKV4TxKCXU40IBJQsfTYjUw2udm0vFSvEERZRBX0=; b=FwZ8Z44SN7D4KRJA4npu9mvkVI0wXuCLYH1l2mLJj8aelE0Rk0L2zjDZgtqEkgrGP5 Vdlh91A3FK9cW00PtADerkvJE2DbDmOjQwdEO6PDh5uBo9JY+jiyUUcP5hnU8Rb7ZGKm uWPcKxWzPxVjBdhDrkoEXl9Yq9bB3c9PCSDYE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bSRmKV4TxKCXU40IBJQsfTYjUw2udm0vFSvEERZRBX0=; b=RIoUO5R2VC1nWupQck4f5ltOijTq2BLGvY8/4UqxPCIQF3Mkj8osIFhHGJYFLD7Cii Koww6+LdjT/gsj1DNRGuFunhOolMxH59C66KsHG5faJBCuEZu3GGJB3oxSTDnqu0jp32 arE181dsYsK4Gys1MTQik4WxS5DFAm6ZREcF+EZIRgplOEo8xqlRc0AWEAhOvtjzQrot Xba4/78hw4YE57zk2eIFDOeQuArPoWN29c9rzACJXlbc/3QboPo1gUfVjZPeidZJv5OC pJAwR4IY3TOFOUnOW7rJyxlrDrpXHyULk1p9IERsIMv8KBiLcPeKELFgBuz7jrOoXxpD Qaew== X-Gm-Message-State: AOAM533zfZavhx8xzq0ZKttZYN+cIwyxAWrjVIE4FLMGSJ3riKERkDn2 DSD7fpqDs3nBfXUImOYss0rYIQ== X-Google-Smtp-Source: ABdhPJwGPpNyETRl4VuDPYZiIlH2eDa0br1azIegj/wzZtKCn4U41u9SncizzsUSeepmeQxRgh8NDQ== X-Received: by 2002:aa7:824a:: with SMTP id e10mr1243727pfn.62.1599015234783; Tue, 01 Sep 2020 19:53:54 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 31sm2560666pgo.17.2020.09.01.19.53.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:50 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 4/5] x86/build: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:46 -0700 Message-Id: <20200902025347.2504702-5-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225356_859609_0A8AE84C X-CRM114-Status: GOOD ( 12.89 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. Now that all sections are explicitly handled, enable orphan section warnings. Signed-off-by: Kees Cook --- arch/x86/Makefile | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index 4346ffb2e39f..154259f18b8b 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -209,6 +209,10 @@ ifdef CONFIG_X86_64 LDFLAGS_vmlinux += -z max-page-size=0x200000 endif +# We never want expected sections to be placed heuristically by the +# linker. All sections should be explicitly named in the linker script. +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) + archscripts: scripts_basic $(Q)$(MAKE) $(build)=arch/x86/tools relocs From patchwork Wed Sep 2 02:53:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11749661 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BC81D1575 for ; Wed, 2 Sep 2020 02:55:47 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 96544206CD for ; Wed, 2 Sep 2020 02:55:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GlxZuQ+z"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bNeNVIUp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 96544206CD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=RYMNOIJMv+ye/D9c1q1Smt+RWd5DNh0E7q7Hwkim/d0=; b=GlxZuQ+zEpis4Rz9jNhW1V6/O A7TLrAis5Gcjapj6K1L5sLBHckG394n+GOmR4KEAu/XLSfEc9hbKO8eZ2K+WFBJCusHr6A6a3Flkn 43I89V8hwfYrwJUO0vfp22+OSy+EBRvMmzWDwgBjwAPk+H8Q9KzHI9De+5HZNVUyIQypAatdPj+TW /AhG0773cyZK80J5/PkvhsHcMUPIivyUG8zhm1DNdU/D74PREdn4E4WjSk078l8nQyhAFcS/Gf+vA 129zU3VwLborMbqW7Fp7ywrVmOxns5rQAaHwGtZXyGwIbr1Jd5cOkMvxmgViDy6c34WBy2YpvXwJG FdF3Lp+JA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuX-0003bG-54; Wed, 02 Sep 2020 02:54:09 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kDIuM-0003XQ-5A for linux-arm-kernel@lists.infradead.org; Wed, 02 Sep 2020 02:54:00 +0000 Received: by mail-pg1-x544.google.com with SMTP id d19so1781347pgl.10 for ; Tue, 01 Sep 2020 19:53:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=JcvEo160LuHDQD7qfOvAP7KcCyAU7p1FFARh/mGAmoY=; b=bNeNVIUp5wLd20zY7GcMyTGEK+1iPazVe7pNUjLaD0gXYItCy+3Sdv//WvvNwoKDM6 Uv+a9vaUg3+t1WxF84thK1gkM5sHMKI+Rq2tNAhA7rAZnF0RzdZRMP6vmNwRs2hT7jbC A2ZuOezSk/Jtm5d8lXaE6Ct1Du9kbe7yDRf6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=JcvEo160LuHDQD7qfOvAP7KcCyAU7p1FFARh/mGAmoY=; b=UrCH1lwQVl4yLY9dul684d8ZR/P8T9YRRJluvGkxAzRhfIUKe1W9nKw2VAEFTSdhw+ B7dLCd1v/X1mwXBPZF4cENdb2mhmskR9lNkH8B1kQoGphjKVFQ4Vovm84HoVIGGyDRsd 6A5I49aqkaimHQ8pgaHRBMxQMg5tbFIuoib/N0eq1gEEkADdg8+EcCxpNi426DpwNi6z jIlycKoRlzaUamDyqhDoiY6IaL1+JNFZyyInqHbpyRRWRbOdkTedfXmcVBtg6152eHW8 6y2LglIwCdJRmjRe1FNTLAACO38Ur7BhRDX4fkSMSRk9cotjfIl8I2QAcOq2R9wgolDT km0g== X-Gm-Message-State: AOAM532qt4GtTDm7jyQgx3EMeBY8wl9lyVuT6NqFJL1n/uKEKg2Ziucb qWI6u+JPCe5DOTKWD6u36chfUw== X-Google-Smtp-Source: ABdhPJy0HGMfDCWkJW2ahd3RYXmS5RA7xjHg6pHP5/RCgQANMg7x7X7wDQT+vfbBEud/U6454iTChQ== X-Received: by 2002:a63:d34e:: with SMTP id u14mr235066pgi.122.1599015236142; Tue, 01 Sep 2020 19:53:56 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id o192sm3673517pfg.81.2020.09.01.19.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2020 19:53:54 -0700 (PDT) From: Kees Cook To: Ingo Molnar Subject: [PATCH v7 5/5] x86/boot/compressed: Warn on orphan section placement Date: Tue, 1 Sep 2020 19:53:47 -0700 Message-Id: <20200902025347.2504702-6-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200902025347.2504702-1-keescook@chromium.org> References: <20200902025347.2504702-1-keescook@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200901_225358_341318_74F15FFE X-CRM114-Status: GOOD ( 14.86 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:544 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , linux-arch@vger.kernel.org, linux-efi@vger.kernel.org, Kees Cook , Arnd Bergmann , Catalin Marinas , Masahiro Yamada , x86@kernel.org, Nick Desaulniers , Russell King , linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Arvind Sankar , Ingo Molnar , James Morse , Nathan Chancellor , Borislav Petkov , Peter Collingbourne , Ard Biesheuvel , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly handled in the linker script. Now that all sections are explicitly handled, enable orphan section warnings. Signed-off-by: Kees Cook --- arch/x86/boot/compressed/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile index 5b7f6e175b03..871cc071c925 100644 --- a/arch/x86/boot/compressed/Makefile +++ b/arch/x86/boot/compressed/Makefile @@ -54,6 +54,7 @@ KBUILD_LDFLAGS += $(call ld-option,--no-ld-generated-unwind-info) # Compressed kernel should be built as PIE since it may be loaded at any # address by the bootloader. LDFLAGS_vmlinux := -pie $(call ld-option, --no-dynamic-linker) +LDFLAGS_vmlinux += $(call ld-option, --orphan-handling=warn) LDFLAGS_vmlinux += -T hostprogs := mkpiggy