From patchwork Fri Sep 4 14:48:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bean Huo X-Patchwork-Id: 11757601 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 864B2138E for ; Fri, 4 Sep 2020 14:50:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4FD1F2074D for ; Fri, 4 Sep 2020 14:50:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qFs5cdTi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4FD1F2074D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 63D026B005A; Fri, 4 Sep 2020 10:50:06 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5EDF16B005C; Fri, 4 Sep 2020 10:50:06 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48D466B005D; Fri, 4 Sep 2020 10:50:06 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 2FE3A6B005A for ; Fri, 4 Sep 2020 10:50:06 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id E1685181AC9C6 for ; Fri, 4 Sep 2020 14:50:05 +0000 (UTC) X-FDA: 77225663970.05.doll33_3e0399f270b3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id B22E71801585D for ; Fri, 4 Sep 2020 14:50:05 +0000 (UTC) X-Spam-Summary: 1,0,0,e9853799f6489415,d41d8cd98f00b204,huobean@gmail.com,,RULES_HIT:41:355:379:541:800:960:973:988:989:1260:1345:1437:1534:1541:1711:1730:1747:1777:1792:2194:2198:2199:2200:2393:2559:2562:2693:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3870:3871:3872:4250:4321:5007:6261:6653:7576:7875:8603:9413:10004:11026:11658:11914:12043:12296:12297:12438:12517:12519:12555:12679:12895:12986:13069:13255:13311:13357:14096:14181:14384:14394:14687:14721:21080:21324:21444:21627:21666:21796:30036:30054:30070,0,RBL:209.85.218.65:@gmail.com:.lbl8.mailshell.net-62.50.0.100 66.100.201.100;04y8ng4my6jofi4gu6wowuuyuzsx4ypwpymiebjujd8mw43tb9e51ud8nf5zjp5.16nzehwwo76afdmkg5r6zb5xx3jspudga1jir66ei9ztuftwnf131z4tjwqfyfj.s-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:25,LUA_SUMMARY:none X-HE-Tag: doll33_3e0399f270b3 X-Filterd-Recvd-Size: 4182 Received: from mail-ej1-f65.google.com (mail-ej1-f65.google.com [209.85.218.65]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 4 Sep 2020 14:50:04 +0000 (UTC) Received: by mail-ej1-f65.google.com with SMTP id gr14so7864839ejb.1 for ; Fri, 04 Sep 2020 07:50:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=knHcGvrKe47dDgMpklf6EaakjMbICjDQ8kPM7SJOe0g=; b=qFs5cdTin+4XJ14I4314k+lczV2OimLtbY/+jRukUPSyAUxnaIgf3jAMinYQIAPTdc fbW2UfhTnzV3WbKFk++GolYrJIYMt0Zo239oodSDZUE3UbttkPV3lhyX4s9eqQl89CXL yjIt4EJV3QiTBRDE0KyX4NqhwbWFyPaoISFsVSS1o7o3cuw6Jvcqy9uG+tLOTmctJxJv GcBL0y3oFdOtGvt5XVrSRxReSqRptxFI2NipW1G/KlmHn7TlT2hH1adwGUpGtGS4etw6 d+J8zBCamQJhcekfXzbw0mccYToTZeuR/Z9unLyhPd68JHDUs0ihp1wr8P/uLhXRSzoF FVRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=knHcGvrKe47dDgMpklf6EaakjMbICjDQ8kPM7SJOe0g=; b=mOt2vN0WhPpiJ7nbrrbDVg1NLRjpH1/gV71muu68UXUuiut8MMU4kZSJYwc2X37VRl 4mvAPuZURLzXLpey+wi6/S38zs17XbaV1PYnQBIWiwVEE2qPWI3825YgXIaCU8BT4UI2 UMJFPOtiUS3+XOfXagORrEEfXvdeWyxHtfR0AdCaZYuJLUXohnLCrzT8OULttW6xfBux QjnpHb0sPIsKPhOH0ZEoOv4NhY4jcOXszyaNgY9qKBuR9y8+KRqZNVEHt9Xs8Sjn8H4j v/F69hbbcZAUQYKE2LGpOVP/JOlzN5B0WU9LzPHWpYPwnduevgp/e5P4yC5g881vp1BJ 9JGA== X-Gm-Message-State: AOAM532h8E41iaKRigcI02s9QZOnnFmHQgteeGiuUlxNhJ7iqRFfT85V E0DY5difBdLDzsdkPrhGOus= X-Google-Smtp-Source: ABdhPJzXsjAqBhhZESO7864PPMNv5hMGtP7WEfYyrS4EdQC9zKm/W/hF8VLVTc1xTpANhTw0SeKONg== X-Received: by 2002:a17:906:1909:: with SMTP id a9mr7562396eje.127.1599231003271; Fri, 04 Sep 2020 07:50:03 -0700 (PDT) Received: from localhost.localdomain ([2a01:598:b907:ef64:1d41:83f0:a723:a7e3]) by smtp.gmail.com with ESMTPSA id v17sm6281327eju.22.2020.09.04.07.50.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Sep 2020 07:50:02 -0700 (PDT) From: Bean Huo To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: beanhuo@micron.com Subject: [PATCH RFC] mm: Let readahead submit larger batches of pages in case of ra->ra_pages == 0 Date: Fri, 4 Sep 2020 16:48:07 +0200 Message-Id: <20200904144807.31810-1-huobean@gmail.com> X-Mailer: git-send-email 2.17.1 X-Rspamd-Queue-Id: B22E71801585D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000013, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Bean Huo Current generic_file_buffered_read() will break up the larger batches of pages and read data in single page length in case of ra->ra_pages == 0. This patch is to allow it to pass the batches of pages down to the device if the supported maximum IO size >= the requested size. Signed-off-by: Bean Huo --- mm/filemap.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 1aaea26556cc..0deec1897817 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2062,6 +2062,7 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb, struct file *filp = iocb->ki_filp; struct address_space *mapping = filp->f_mapping; struct inode *inode = mapping->host; + struct backing_dev_info *bdi = inode_to_bdi(mapping->host); struct file_ra_state *ra = &filp->f_ra; loff_t *ppos = &iocb->ki_pos; pgoff_t index; @@ -2098,9 +2099,14 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb, if (!page) { if (iocb->ki_flags & IOCB_NOIO) goto would_block; - page_cache_sync_readahead(mapping, - ra, filp, - index, last_index - index); + + if (!ra->ra_pages && bdi->io_pages >= last_index - index) + __do_page_cache_readahead(mapping, filp, index, + last_index - index, 0); + else + page_cache_sync_readahead(mapping, ra, filp, + index, + last_index - index); page = find_get_page(mapping, index); if (unlikely(page == NULL)) goto no_cached_page;