From patchwork Wed Oct 24 04:56:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kimberly Brown X-Patchwork-Id: 10654173 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B901A13A9 for ; Wed, 24 Oct 2018 04:57:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9955A2A1AF for ; Wed, 24 Oct 2018 04:57:43 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8CB572A353; Wed, 24 Oct 2018 04:57:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 307E92A1AF for ; Wed, 24 Oct 2018 04:57:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=++DXA64Oj+uSXHDT6jRRifALSOLosqsmv0/91CW28R0=; b=lnSWjBLnlBO34l 8cdguemPDo8k7wYzJDf8NJFnHs7Uc608cG0TyM0o9ul/5GULUdLP3cqjs8DhJSI4A8c+xgL2wGUCW oxDBjz61mZ1L114AdwCo8yycBrPBJ712C/KntsQ8yp0vTPqu8dn77dSC7TpNC/8jZwqICO7JE8hbj X1ElnV6vUcGEBz8Jwr9DZuY9gkW5q8jqEpboCTs6PltHV91WqkzX7Muoud/TJ3vPtrIEjMKsJPrkn ji4hOwPIl0UtsPoj203puMhbzYXUgWfN0Lay/aeICw2wiOrUwmjYWEej4e4fghubVXMW3MMp/ISk9 k3Px5stP+zw8ixNuGqrw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFBEh-0003Z5-QO; Wed, 24 Oct 2018 04:57:39 +0000 Received: from mail-oi1-x241.google.com ([2607:f8b0:4864:20::241]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gFBED-0003KI-Ur; Wed, 24 Oct 2018 04:57:11 +0000 Received: by mail-oi1-x241.google.com with SMTP id k64-v6so3006662oia.13; Tue, 23 Oct 2018 21:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=NfZouOdn9JYYSOR2kOQNnypLNGNz2ic4JEcKUiU0BgA=; b=NZxkjSgomcm3GvhkNRbD0dxGRt6h5Sf4TE12Np9s8v3DTSdCQHAD09hx/ny5uKr5Wk +orozIG7/0IIIEBIFAouChEVLNXOL58MVPZT7eVPZPNzQUQOwI9G5D2kDRj2HA3Aw5k2 BD4lMhGDhfUQ1esVlRM8OTa7BnTqjYUh8w5uTlcHyHnXVzF3F7Il6W00DQRUORAKtZzd nyPn0e/EVD3y5XEDv4sIyyEeIcOKXl+AXnUGaeo6/pd24NY/DXbj/wmcaIPb45MSbaDW 77buV4m6tWr85PpBUSpRfyBPY5ruY9YiqvshOeywUo0feY+kDmU+Zmb1j9XYTH9DghkH RVgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=NfZouOdn9JYYSOR2kOQNnypLNGNz2ic4JEcKUiU0BgA=; b=TpIyHpBC6o6qHQH2D3fjTxMy1aLJ7KdZxrUYXjj+swTUXy8VKU6mgRmUio8jNGUBoY OJO1Ge08SCOpDunSQ2fUqInRHueWmRHUWMY/9HDt7ARKS+evolF/3Sg4T5MUNRIE9U3n Su4j55pbnH4OKZR9mqbvY6yYWDaJvTF5669ht18JfUlPgbxs1zgKgct7+Ldte8oJbM4p yAEFoqrKDDcNamSiUm2yDa5Sm5ThR6w0aGsGpSkZZzTvSDIm+riI37v8CrACdAFA9rQ9 OvVV6JJoEAs09MJNi/Kq6ushjT8omGVEsQGuzBdTCzfmX7NR58wRU9fRoEbPdNsJpUdF kN6w== X-Gm-Message-State: AGRZ1gIejuJdddsry9ZZ8ZrIQ70ftEoyZMtbp7Z6gxtvVJY3bS8P887U Ggk6ANVSd1VjQz8bd6//h1w= X-Google-Smtp-Source: AJdET5eViUjVlNiNnhQMTMUfNLd8b9e57x7MYQu+InKyn9ITTl+95F4u2SPlriQ4L4wL6PKThhtVeQ== X-Received: by 2002:aca:e64b:: with SMTP id d72-v6mr553063oih.314.1540357017992; Tue, 23 Oct 2018 21:56:57 -0700 (PDT) Received: from v (68-188-226-58.dhcp.bycy.mi.charter.com. [68.188.226.58]) by smtp.gmail.com with ESMTPSA id 43sm1133227otz.75.2018.10.23.21.56.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 23 Oct 2018 21:56:57 -0700 (PDT) Date: Wed, 24 Oct 2018 00:56:53 -0400 From: Kimberly Brown To: outreachy-kernel@googlegroups.com Subject: [PATCH v2] staging: mt7621-dma: Add braces around else branches Message-ID: <20181024045653.GA2864@v> References: <20181023211142.GA2661@v> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20181023211142.GA2661@v> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181023_215709_997486_72696EE5 X-CRM114-Status: GOOD ( 12.10 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , NeilBrown , linux-mediatek@lists.infradead.org, Kimberly Brown , Matthias Brugger , Christian =?iso-8859-1?q?L=FCtke?= =?iso-8859-1?q?-Stetzkamp?= , linux-arm-kernel@lists.infradead.org, John Crispin Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+patchwork-linux-mediatek=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Add braces around else branches in conditional statements that include branches with multiple statements. This style complies with the Linux kernel coding style and improves consistency and readability. Issues found by checkpatch. Signed-off-by: Kimberly Brown Reviewed-by: Matthias Brugger --- Changes in v2: - Added people and mailing lists from get_maintainer.pl to the CC list - Added Reviewed-by line drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c index df6ebf41bdea..35556f024aa1 100644 --- a/drivers/staging/mt7621-dma/mtk-hsdma.c +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c @@ -418,8 +418,9 @@ static void mtk_hsdma_chan_done(struct mtk_hsdam_engine *hsdma, vchan_cookie_complete(&desc->vdesc); chan_issued = gdma_next_desc(chan); } - } else + } else { dev_dbg(hsdma->ddev.dev, "no desc to complete\n"); + } if (chan_issued) set_bit(chan->id, &hsdma->chan_issued); @@ -456,8 +457,9 @@ static void mtk_hsdma_issue_pending(struct dma_chan *c) if (gdma_next_desc(chan)) { set_bit(chan->id, &hsdma->chan_issued); tasklet_schedule(&hsdma->task); - } else + } else { dev_dbg(hsdma->ddev.dev, "no desc to issue\n"); + } } spin_unlock_bh(&chan->vchan.lock); }