From patchwork Mon Sep 7 12:57:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 11761803 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 03458746 for ; Mon, 7 Sep 2020 17:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8BE3208C7 for ; Mon, 7 Sep 2020 17:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729348AbgIGNGC (ORCPT ); Mon, 7 Sep 2020 09:06:02 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33904 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729233AbgIGNFb (ORCPT ); Mon, 7 Sep 2020 09:05:31 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A47082F6D9D99B302CF1; Mon, 7 Sep 2020 21:05:29 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Sep 2020 21:05:06 +0800 From: Hanjun Guo To: "Rafael J. Wysocki" CC: , , Ken Xue , Hanjun Guo Subject: [PATCH v2 1/5] ACPI / APD: Add kernel doc for the properties in struct apd_device_desc Date: Mon, 7 Sep 2020 20:57:29 +0800 Message-ID: <1599483453-26635-2-git-send-email-guohanjun@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> References: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org commit 7ff55d174cbf ("ACPI / APD: Provide build-in properties of the UART") add the 'struct property_entry *properties' in struct apd_device_desc but didn't add the kernel doc, add it now. Signed-off-by: Hanjun Guo --- drivers/acpi/acpi_apd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 4c34837..6f39289 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -34,6 +34,7 @@ * @flags: device flags like %ACPI_APD_SYSFS, %ACPI_APD_PM * @fixed_clk_rate: fixed rate input clock source for acpi device; * 0 means no fixed rate input clock source + * @properties: build-in properties of the device such as UART * @setup: a hook routine to set device resource during create platform device * * Device description defined as acpi_device_id.driver_data From patchwork Mon Sep 7 12:57:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 11761809 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0530415E4 for ; Mon, 7 Sep 2020 17:46:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E9F6721532 for ; Mon, 7 Sep 2020 17:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729369AbgIGRqw (ORCPT ); Mon, 7 Sep 2020 13:46:52 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33906 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729360AbgIGNFb (ORCPT ); Mon, 7 Sep 2020 09:05:31 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id A072C4F64DD3212D677D; Mon, 7 Sep 2020 21:05:29 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Sep 2020 21:05:07 +0800 From: Hanjun Guo To: "Rafael J. Wysocki" CC: , , Ken Xue , Hanjun Guo Subject: [PATCH v2 2/5] ACPI / APD: Remove the flags in struct apd_device_desc Date: Mon, 7 Sep 2020 20:57:30 +0800 Message-ID: <1599483453-26635-3-git-send-email-guohanjun@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> References: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The flags is not used in anywhere, remove it and its related code. Signed-off-by: Hanjun Guo --- drivers/acpi/acpi_apd.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 6f39289..c4bc4ab 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -23,15 +23,7 @@ struct apd_private_data; /** - * ACPI_APD_SYSFS : add device attributes in sysfs - * ACPI_APD_PM : attach power domain to device - */ -#define ACPI_APD_SYSFS BIT(0) -#define ACPI_APD_PM BIT(1) - -/** * struct apd_device_desc - a descriptor for apd device - * @flags: device flags like %ACPI_APD_SYSFS, %ACPI_APD_PM * @fixed_clk_rate: fixed rate input clock source for acpi device; * 0 means no fixed rate input clock source * @properties: build-in properties of the device such as UART @@ -40,7 +32,6 @@ * Device description defined as acpi_device_id.driver_data */ struct apd_device_desc { - unsigned int flags; unsigned int fixed_clk_rate; struct property_entry *properties; int (*setup)(struct apd_private_data *pdata); From patchwork Mon Sep 7 12:57:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 11761005 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 555B41599 for ; Mon, 7 Sep 2020 13:06:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 426ED2166E for ; Mon, 7 Sep 2020 13:06:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729233AbgIGNGJ (ORCPT ); Mon, 7 Sep 2020 09:06:09 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33900 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729322AbgIGNFb (ORCPT ); Mon, 7 Sep 2020 09:05:31 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 91824E8FDE701B7CD569; Mon, 7 Sep 2020 21:05:29 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Sep 2020 21:05:07 +0800 From: Hanjun Guo To: "Rafael J. Wysocki" CC: , , Ken Xue , Hanjun Guo Subject: [PATCH v2 3/5] ACPI / APD: Remove ACPI_MODULE_NAME() Date: Mon, 7 Sep 2020 20:57:31 +0800 Message-ID: <1599483453-26635-4-git-send-email-guohanjun@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> References: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org ACPI_MODULE_NAME() is used for ACPI debug output when using ACPI debug print functions, but ACPI debug print functions are not used in acpi_apd.c, remove the ACPI_MODULE_NAME(). Signed-off-by: Hanjun Guo --- drivers/acpi/acpi_apd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index c4bc4ab..4dbf85b 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -19,7 +19,6 @@ #include "internal.h" -ACPI_MODULE_NAME("acpi_apd"); struct apd_private_data; /** From patchwork Mon Sep 7 12:57:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 11761807 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5ABC7746 for ; Mon, 7 Sep 2020 17:46:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C40921532 for ; Mon, 7 Sep 2020 17:46:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729395AbgIGRqt (ORCPT ); Mon, 7 Sep 2020 13:46:49 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:33898 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729380AbgIGNFb (ORCPT ); Mon, 7 Sep 2020 09:05:31 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 9556C89E6AA31CAB50C0; Mon, 7 Sep 2020 21:05:29 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Sep 2020 21:05:08 +0800 From: Hanjun Guo To: "Rafael J. Wysocki" CC: , , Ken Xue , Hanjun Guo Subject: [PATCH v2 4/5] ACPI / APD: Remove the unneeded APD_ADDR(desc) macro define Date: Mon, 7 Sep 2020 20:57:32 +0800 Message-ID: <1599483453-26635-5-git-send-email-guohanjun@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> References: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Since APD_ADDR(desc) is only used when CONFIG_X86_AMD_PLATFORM_DEVICE or CONFIG_ARM64 is set, no need for the redundant '#define APD_ADDR(desc) (0UL)', remove it. Also update the comments for #endif. Signed-off-by: Hanjun Guo --- drivers/acpi/acpi_apd.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 4dbf85b..561d9ba 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -62,7 +62,6 @@ static int acpi_apd_setup(struct apd_private_data *pdata) } #ifdef CONFIG_X86_AMD_PLATFORM_DEVICE - static int misc_check_res(struct acpi_resource *ares, void *data) { struct resource res; @@ -133,7 +132,7 @@ static int fch_misc_setup(struct apd_private_data *pdata) static const struct apd_device_desc fch_misc_desc = { .setup = fch_misc_setup, }; -#endif +#endif /* CONFIG_X86_AMD_PLATFORM_DEVICE */ #ifdef CONFIG_ARM64 static const struct apd_device_desc xgene_i2c_desc = { @@ -175,13 +174,9 @@ static int fch_misc_setup(struct apd_private_data *pdata) .setup = acpi_apd_setup, .fixed_clk_rate = 250000000, }; -#endif +#endif /* CONFIG_ARM64 */ -#else - -#define APD_ADDR(desc) (0UL) - -#endif /* CONFIG_X86_AMD_PLATFORM_DEVICE */ +#endif /** * Create platform device during acpi scan attach handle. From patchwork Mon Sep 7 12:57:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 11761805 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 72E7B59D for ; Mon, 7 Sep 2020 17:46:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 637DE2080A for ; Mon, 7 Sep 2020 17:46:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729402AbgIGRqp (ORCPT ); Mon, 7 Sep 2020 13:46:45 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:34114 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727032AbgIGNFj (ORCPT ); Mon, 7 Sep 2020 09:05:39 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 99207BD3513C6818865A; Mon, 7 Sep 2020 21:05:29 +0800 (CST) Received: from linux-ibm.site (10.175.102.37) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Mon, 7 Sep 2020 21:05:09 +0800 From: Hanjun Guo To: "Rafael J. Wysocki" CC: , , Ken Xue , Hanjun Guo Subject: [PATCH v2 5/5] ACPI / APD: Head file including cleanups Date: Mon, 7 Sep 2020 20:57:33 +0800 Message-ID: <1599483453-26635-6-git-send-email-guohanjun@huawei.com> X-Mailer: git-send-email 1.7.12.4 In-Reply-To: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> References: <1599483453-26635-1-git-send-email-guohanjun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.102.37] X-CFilter-Loop: Reflected Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Make the including head files to be alphabetical order, and remove the not needed head file inclusion. Signed-off-by: Hanjun Guo --- drivers/acpi/acpi_apd.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpi_apd.c b/drivers/acpi/acpi_apd.c index 561d9ba..05855db 100644 --- a/drivers/acpi/acpi_apd.c +++ b/drivers/acpi/acpi_apd.c @@ -7,15 +7,13 @@ * Wu, Jeff */ -#include -#include -#include -#include -#include #include +#include +#include #include #include -#include +#include +#include #include "internal.h"