From patchwork Fri Sep 11 16:27:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11770927 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 55FA0746 for ; Fri, 11 Sep 2020 16:30:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2FECA22206 for ; Fri, 11 Sep 2020 16:30:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841841; bh=iVrTsu1h/6XlgdpG7zNyUdsnzo/x/58Z/4c9hRJI3iM=; h=From:To:Cc:Subject:Date:List-ID:From; b=zdV2kJ39OEeE0LEgzz2axlH9k3fGo4vpVaRWWCPP0du+fAK4d+p5eg6uH2GhZCUyM ClaAvXDGPn/0CcegKRa78ggLXfWlb4N1hr7ldLLND6prK+O0qtCuYBr/lLNl6oTmm7 IZ84cIKWyz+JYt3lZcaw1bkgEpQdxmI2nKlpptXI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726513AbgIKQai (ORCPT ); Fri, 11 Sep 2020 12:30:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:60662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726613AbgIKQ1m (ORCPT ); Fri, 11 Sep 2020 12:27:42 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 79C56221EB; Fri, 11 Sep 2020 16:27:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841654; bh=iVrTsu1h/6XlgdpG7zNyUdsnzo/x/58Z/4c9hRJI3iM=; h=From:To:Cc:Subject:Date:From; b=p5w4DH3NWmRDXCmqROyjGb503AOrxeMLr3ldg0FtnhVLzvq4sRSHrK83BXXPNaxzZ Pd7c9Hq1BTErlyyx7oIMPEDJ3fCaKoOiOZM2uRdSyo5bEzOPoRcmOcGe/cmCAyBIzY bvQzUzzXqOCedLTOKikBMlt/6Ck/CdlDZDDRJN5g= From: Krzysztof Kozlowski To: Sebastian Reichel , Jonathan Bakker , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/7] power: supply: bq24257: skip 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 11 Sep 2020 18:27:23 +0200 Message-Id: <20200911162729.3022-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, the struct acpi_device_id becomes unused: drivers/power/supply/bq24257_charger.c:1155:36: warning: 'bq24257_acpi_match' defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/bq24257_charger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/bq24257_charger.c b/drivers/power/supply/bq24257_charger.c index 8e60cb0f3c3f..96cb3290bcaa 100644 --- a/drivers/power/supply/bq24257_charger.c +++ b/drivers/power/supply/bq24257_charger.c @@ -1152,6 +1152,7 @@ static const struct of_device_id bq24257_of_match[] = { }; MODULE_DEVICE_TABLE(of, bq24257_of_match); +#ifdef CONFIG_ACPI static const struct acpi_device_id bq24257_acpi_match[] = { { "BQ242500", BQ24250 }, { "BQ242510", BQ24251 }, @@ -1159,6 +1160,7 @@ static const struct acpi_device_id bq24257_acpi_match[] = { {}, }; MODULE_DEVICE_TABLE(acpi, bq24257_acpi_match); +#endif static struct i2c_driver bq24257_driver = { .driver = { From patchwork Fri Sep 11 16:27:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11770929 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91F3913B1 for ; Fri, 11 Sep 2020 16:30:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73833206DB for ; Fri, 11 Sep 2020 16:30:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841845; bh=G1H4KBZK6Z5xZfrreS53bo+fWNiN/FdHp8IsoAi5Cf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jkY/Zyg2KoX43K/aUEF2pUrCyBIb/Q5XqS+jrN1bHP9PHA/5edfxWeeVLo+H5TssF 9U623JTyOYtR6YHbvdgoiMGo8aGw1xZZ/sSCVScpoN0W/i10Iy1qufGpAbTco+38lQ QP9RT2sGu1P8DtSq6d5Wg0CnM9iGiA9isLXCrbY4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725847AbgIKQah (ORCPT ); Fri, 11 Sep 2020 12:30:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:60670 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726629AbgIKQ1m (ORCPT ); Fri, 11 Sep 2020 12:27:42 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5263722204; Fri, 11 Sep 2020 16:27:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841656; bh=G1H4KBZK6Z5xZfrreS53bo+fWNiN/FdHp8IsoAi5Cf8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kqjsMpCrIJCJsqErxjAkkQElm0E6h4bYI0AH7V/EZkEJqHnqyx4u2uAenLC0xQ66L TIg4mYICvefovMXVR2X3iycArkuYbYAewzFaz9vBPUbP+AFixi758c62yvgZ0aWK/n 3XnvHzGX4v9gRA7S2NI8aC22PaTSkXqFVbuMa9I4= From: Krzysztof Kozlowski To: Sebastian Reichel , Jonathan Bakker , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/7] power: supply: bq2515x: fix kerneldoc Date: Fri, 11 Sep 2020 18:27:24 +0200 Message-Id: <20200911162729.3022-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200911162729.3022-1-krzk@kernel.org> References: <20200911162729.3022-1-krzk@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Fix kerneldoc W=1 warning: drivers/power/supply/bq2515x_charger.c:189: warning: Function parameter or member 'init_data' not described in 'bq2515x_device' Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/bq2515x_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/bq2515x_charger.c b/drivers/power/supply/bq2515x_charger.c index 9dcb61ea4cf2..374b112f712a 100644 --- a/drivers/power/supply/bq2515x_charger.c +++ b/drivers/power/supply/bq2515x_charger.c @@ -168,7 +168,7 @@ enum bq2515x_id { * @device_id: value of device_id * @mains_online: boolean value indicating power supply online * - * @bq2515x_init_data init_data: charger initialization data structure + * @init_data: charger initialization data structure */ struct bq2515x_device { struct power_supply *mains; From patchwork Fri Sep 11 16:27:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11770925 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9E9CC746 for ; Fri, 11 Sep 2020 16:30:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 837992087C for ; Fri, 11 Sep 2020 16:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841838; bh=PdARNYmSWwEuVmkx5vGlCCUPcCAIbjbSdbiCxqmb/yg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=e+Qd4NZy2+lZy/m1h5DEzucUTb6cyeyhSDLAXWhw0rB96OhtTwOXouOaUfR9H1dsf Lm05xVRIIsjZzqtM7yUTgbsG2io40vMkK7JlJbvu5GJZfSrTZOfb6nH/VjBfaN3jvD 29oUEnc4+Thzf9N07eoDdU7G4Zx2FdfjSPRzmJ2w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725904AbgIKQad (ORCPT ); Fri, 11 Sep 2020 12:30:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:60690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726633AbgIKQ1m (ORCPT ); Fri, 11 Sep 2020 12:27:42 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 63715221ED; Fri, 11 Sep 2020 16:27:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841658; bh=PdARNYmSWwEuVmkx5vGlCCUPcCAIbjbSdbiCxqmb/yg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IRChD94VHG0MWSmsAO44Iy3TLiflAlrva4/J9DYhz2qGiK1IjJGqt5QDhORnuntRX AaLlPzpmPQkmusDhJfF+gPR6eZsl2M0amJuYeDuwQA4ImpVr9phP3AgaWwzNHHQfcx b1neAFM1fXjQwu43/saHl1KPkuNAAoy01vvMhDww= From: Krzysztof Kozlowski To: Sebastian Reichel , Jonathan Bakker , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/7] power: supply: bq25890: skip 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 11 Sep 2020 18:27:25 +0200 Message-Id: <20200911162729.3022-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200911162729.3022-1-krzk@kernel.org> References: <20200911162729.3022-1-krzk@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, the struct acpi_device_id becomes unused: drivers/power/supply/bq25890_charger.c:1076:36: warning: 'bq25890_acpi_match' defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/bq25890_charger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/bq25890_charger.c b/drivers/power/supply/bq25890_charger.c index 77150667e36b..74b129ddc298 100644 --- a/drivers/power/supply/bq25890_charger.c +++ b/drivers/power/supply/bq25890_charger.c @@ -1073,11 +1073,13 @@ static const struct of_device_id bq25890_of_match[] = { }; MODULE_DEVICE_TABLE(of, bq25890_of_match); +#ifdef CONFIG_ACPI static const struct acpi_device_id bq25890_acpi_match[] = { {"BQ258900", 0}, {}, }; MODULE_DEVICE_TABLE(acpi, bq25890_acpi_match); +#endif static struct i2c_driver bq25890_driver = { .driver = { From patchwork Fri Sep 11 16:27:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11770917 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8E24359D for ; Fri, 11 Sep 2020 16:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6D71422205 for ; Fri, 11 Sep 2020 16:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841711; bh=qu+lbVaMlZCIg+s7vOyGDHOqZHqP4+Sau/I820OhUno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=CCzJOolxZICUnprJQkUAXk6rkX+LrAF6v5hUq2IboZC3wBIrkvuGjkxzodQh7v1lK 5djVZ389yKTl8sK0BLQ2+oW9JFMSCpUI3PNVIA0FxUpgfX2lXNkpBGZOvzKvNbr+KN zyv1Guk352+c+YvgYojNfX4gqYnrLZGl2w2e9Qm0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726421AbgIKQ2a (ORCPT ); Fri, 11 Sep 2020 12:28:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:60714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726481AbgIKQ1m (ORCPT ); Fri, 11 Sep 2020 12:27:42 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B42322206; Fri, 11 Sep 2020 16:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841660; bh=qu+lbVaMlZCIg+s7vOyGDHOqZHqP4+Sau/I820OhUno=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fyC9Um+D3EbXx++28IJIl9VkAIkDYBRn0b1idBw7TJumHowiEvXc5YMUiAlJLffuM gPM5VPUVu/zm2fgJsE5jF+DiXqHrXpCof9EMcWm0LcvecvTDs2IbDZeifFHLgyXvWu AkoR0w8cdrLLr7Hvj9lv7JSxu9vTc6bLlgKW9XpQ= From: Krzysztof Kozlowski To: Sebastian Reichel , Jonathan Bakker , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 4/7] power: supply: goldfish: skip 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 11 Sep 2020 18:27:26 +0200 Message-Id: <20200911162729.3022-4-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200911162729.3022-1-krzk@kernel.org> References: <20200911162729.3022-1-krzk@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, the struct acpi_device_id becomes unused: drivers/power/supply/goldfish_battery.c:269:36: warning: 'goldfish_battery_acpi_match' defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/goldfish_battery.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/goldfish_battery.c b/drivers/power/supply/goldfish_battery.c index c2644a9fe80f..bf1754355c9f 100644 --- a/drivers/power/supply/goldfish_battery.c +++ b/drivers/power/supply/goldfish_battery.c @@ -266,11 +266,13 @@ static const struct of_device_id goldfish_battery_of_match[] = { }; MODULE_DEVICE_TABLE(of, goldfish_battery_of_match); +#ifdef CONFIG_ACPI static const struct acpi_device_id goldfish_battery_acpi_match[] = { { "GFSH0001", 0 }, { }, }; MODULE_DEVICE_TABLE(acpi, goldfish_battery_acpi_match); +#endif static struct platform_driver goldfish_battery_device = { .probe = goldfish_battery_probe, From patchwork Fri Sep 11 16:27:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11770919 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5BE7E59D for ; Fri, 11 Sep 2020 16:28:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3ACCB221EB for ; Fri, 11 Sep 2020 16:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841719; bh=SJd5CI1KP1E/Et9NZrPzsk7fHtv8JHscc1UZms8YxxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yY3iCSaYvovvMcdqaxXgWaGfKRYoghpsyEC2vxQsTThlgpECWK8R5yPd4Do8zDyi5 Ztx5uSdE/jYVDbXqyKghm8IkTncCpEJK4QaA9p42OcP13WWyZqf0Lz2DQp74YJ6kjn iUFo1tZycK2hp7HKjb4XeG7Kv2xDoU7hS1zrt5+k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbgIKQ2a (ORCPT ); Fri, 11 Sep 2020 12:28:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:60726 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726434AbgIKQ1m (ORCPT ); Fri, 11 Sep 2020 12:27:42 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1CA2522205; Fri, 11 Sep 2020 16:27:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841662; bh=SJd5CI1KP1E/Et9NZrPzsk7fHtv8JHscc1UZms8YxxA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nV1L58zRzj1EX6zIljWJ4whhcKA9+RwFeDek2GIZ4ZWCvahgQ6ct6ufy2YwEsi6Ny etsonevEDJ5wwqbJSiMZpwUcqVvq0nBr78j+/GscyY5avDUH1Jc3QnlOocI6A2txYo WPxUY+BJ7NAmori0uuS56zO8GmM+uRf/iBaA26lw= From: Krzysztof Kozlowski To: Sebastian Reichel , Jonathan Bakker , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/7] power: supply: rt9455: skip 'struct acpi_device_id' when !CONFIG_ACPI Date: Fri, 11 Sep 2020 18:27:27 +0200 Message-Id: <20200911162729.3022-5-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200911162729.3022-1-krzk@kernel.org> References: <20200911162729.3022-1-krzk@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, the struct acpi_device_id becomes unused: drivers/power/supply/rt9455_charger.c:1734:36: warning: 'rt9455_i2c_acpi_match' defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/rt9455_charger.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/power/supply/rt9455_charger.c b/drivers/power/supply/rt9455_charger.c index 29161ae90245..594bb3b8a4d1 100644 --- a/drivers/power/supply/rt9455_charger.c +++ b/drivers/power/supply/rt9455_charger.c @@ -1731,11 +1731,13 @@ static const struct of_device_id rt9455_of_match[] = { }; MODULE_DEVICE_TABLE(of, rt9455_of_match); +#ifdef CONFIG_ACPI static const struct acpi_device_id rt9455_i2c_acpi_match[] = { { "RT945500", 0 }, { } }; MODULE_DEVICE_TABLE(acpi, rt9455_i2c_acpi_match); +#endif static struct i2c_driver rt9455_driver = { .probe = rt9455_probe, From patchwork Fri Sep 11 16:27:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11770921 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1825E13B1 for ; Fri, 11 Sep 2020 16:30:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8F1322208 for ; Fri, 11 Sep 2020 16:30:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841802; bh=y1LJBbMFa89dqzjbeHMhQ4rAd65Fc+zMq+ReRBh/ovM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=iYmMFiLpcfV8d5ncfWr4nVJdInwjXHnX7BxE2oPfw5r6tcFWTypkD7I9tlTwiC5/K 7Xea5r5W/c/OVnppnGgpTBItp1H3XpO3pSFJeDhndNVbGHVqOND7+8Bl7nuxh+6q5G zC0y1+q0gpvG4aC38uA6hEb2fbDHYR0yzAoaeKpk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbgIKQ3b (ORCPT ); Fri, 11 Sep 2020 12:29:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:60860 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726587AbgIKQ2E (ORCPT ); Fri, 11 Sep 2020 12:28:04 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D5DFC2220D; Fri, 11 Sep 2020 16:27:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841664; bh=y1LJBbMFa89dqzjbeHMhQ4rAd65Fc+zMq+ReRBh/ovM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TmyVGJIAPADskTsILeikOFLbmcSyzw7En3FjZH2oKTx0CCKg/mM0eAUJjse+7NxoL pAMR08AXz3O9TtOM2/9R8ZjEF2CtxL+wS4DHPoCB5dNZB/NZpuu1TfijL1GWSRk2BV Ebgqmln4MsOo3b5sUFkUAdlso6AnuV9wc+/RVgwo= From: Krzysztof Kozlowski To: Sebastian Reichel , Jonathan Bakker , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 6/7] power: supply: charger-manager: drop unused charger assignment Date: Fri, 11 Sep 2020 18:27:28 +0200 Message-Id: <20200911162729.3022-6-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200911162729.3022-1-krzk@kernel.org> References: <20200911162729.3022-1-krzk@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The 'charger' variable in error path is assigned but never used: drivers/power/supply/charger-manager.c: In function 'charger_manager_probe': drivers/power/supply/charger-manager.c:1626:29: warning: variable 'charger' set but not used [-Wunused-but-set-variable] Fixes: c1f73028f75d ("power: supply: charger-manager: Update extcon functions") Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/charger-manager.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c index 07992821e252..b2ca79173f95 100644 --- a/drivers/power/supply/charger-manager.c +++ b/drivers/power/supply/charger-manager.c @@ -1622,13 +1622,8 @@ static int charger_manager_probe(struct platform_device *pdev) return 0; err_reg_extcon: - for (i = 0; i < desc->num_charger_regulators; i++) { - struct charger_regulator *charger; - - charger = &desc->charger_regulators[i]; - + for (i = 0; i < desc->num_charger_regulators; i++) regulator_put(desc->charger_regulators[i].consumer); - } power_supply_unregister(cm->charger_psy); From patchwork Fri Sep 11 16:27:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11770923 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A3D0E746 for ; Fri, 11 Sep 2020 16:30:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A71F221EB for ; Fri, 11 Sep 2020 16:30:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841817; bh=Sx4EuGaHyHb+oW4aw/xTYThAtAnevqos0vAP/q03wt4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=a9Pvm/iA/3biZOSGL9SoFhhvgL5jSiP8u0d+3XSia7QaiVPtPR6a+G0IH/DHHnm2s yn3hTN0XMzuqlu/pI3AbecjhixjEzqo9oWtzv3EUsdzi8mWIbEk7QdFjK6qnCDEIeR oS+0gDJYGZPNoW4krpnLtJ+Gx8QS+zhkYctODmjU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbgIKQaO (ORCPT ); Fri, 11 Sep 2020 12:30:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:60862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726450AbgIKQ2E (ORCPT ); Fri, 11 Sep 2020 12:28:04 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B19BC22208; Fri, 11 Sep 2020 16:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599841666; bh=Sx4EuGaHyHb+oW4aw/xTYThAtAnevqos0vAP/q03wt4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L1LS9l5vpU3gl6gR7bZMSzrnswJXsY1IESrsIRwWFpsrHiG8Oli9hSUZSGR+mlaRx mZPsdD8ZQc6lZgeNNvnJa1VkdAvVZ4VC4jJEmEzw7PAbqrH/0gdeKthCKTG0iEUElJ r41d5Fj1CLvPAuBx+1pk6WC/AFQkh61Aeb+0G5Jg= From: Krzysztof Kozlowski To: Sebastian Reichel , Jonathan Bakker , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH 7/7] power: supply: pm2301: drop duplicated i2c_device_id Date: Fri, 11 Sep 2020 18:27:29 +0200 Message-Id: <20200911162729.3022-7-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200911162729.3022-1-krzk@kernel.org> References: <20200911162729.3022-1-krzk@kernel.org> Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The driver defines two of 'struct i2c_device_id' but uses only one: drivers/power/supply/pm2301_charger.c:107:35: warning: 'pm2xxx_ident' defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/power/supply/pm2301_charger.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/power/supply/pm2301_charger.c b/drivers/power/supply/pm2301_charger.c index 787867805944..2df6a2459d1f 100644 --- a/drivers/power/supply/pm2301_charger.c +++ b/drivers/power/supply/pm2301_charger.c @@ -104,11 +104,6 @@ static int pm2xxx_charger_current_map[] = { 3000, }; -static const struct i2c_device_id pm2xxx_ident[] = { - { "pm2301", 0 }, - { } -}; - static void set_lpn_pin(struct pm2xxx_charger *pm2) { if (!pm2->ac.charger_connected && gpio_is_valid(pm2->lpn_pin)) {