From patchwork Mon Sep 14 09:11:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haiwei Li X-Patchwork-Id: 11773373 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 77B1E92C for ; Mon, 14 Sep 2020 09:12:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DE7221D24 for ; Mon, 14 Sep 2020 09:12:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Uurm7Jd4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726244AbgINJMG (ORCPT ); Mon, 14 Sep 2020 05:12:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45008 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbgINJMC (ORCPT ); Mon, 14 Sep 2020 05:12:02 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6066CC061788; Mon, 14 Sep 2020 02:12:02 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id t14so11007339pgl.10; Mon, 14 Sep 2020 02:12:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ypxASSpGv9RIPFq+dUkv+nkukyOjiOQi2ZMQ5W1mvNk=; b=Uurm7Jd47CcO0M+kkGP0tmTl8T9VQR/tQQa1rDxBBvHy82vEyY3rqxEpnFLxSMnvQu 7qIlSd/7ctImd9YmtQB6m0XJNOXZLgEwArVoGLDNdExMuF2NEg5FOKL/nTN7KJ2DUNGv 31rcOaRlSzCsJnm+alV9aFYc/AQYkdyMcgXlt3Val9V+3ma/PrdvlWkgjDcTTBALLV13 lj9vFFAQ/vXNu6cbNmHj/KmfzHhm97h0a450AG9A5aZQLNVuWmdSJVbreQtBnpZmbfm8 kCub3VTlDnnnnYewjCJC7bpie/qfBs+OBTXzX8BazvkK+R4DmBlISUS+l4/nFw/khP9R tJ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ypxASSpGv9RIPFq+dUkv+nkukyOjiOQi2ZMQ5W1mvNk=; b=nAuhy+t+1rIRw6qKoKQKdqilYtrpr2S3FQWL7rkIwtdpWGFyrqvGknDWCa0VXABHWx FAs6cJ43aa+SRCm9LwLsIDmpCbaVKz73rwkGFKDtTXhNpa+zn6kVzrYaXATnVuEIOvLE aDV4F3kSswksPm9MaTsGA7ItPJrXpDLtdgioD7RhFeLUDdXgnnAXC6rZwsVHZKgGuukZ 1pFmucepwbjXlat4meOceXyKZZGVnHRhpd3JWiTAxxNGWSNqewmsH7XlB4sIDHL7KgZS qVwiYCoIc5JGvX8tI+kAjp9885OnfiMFsR0jOHch8CRsuuEiJwuO4bu9mzSaMyZwC1SN Ianw== X-Gm-Message-State: AOAM532xADwSizGpNw3AV7VgDTYYZvb4nx/3MajjAHveO2Wxlgs+Z+sO ck7UkP3jfq4l0N1Zb4MVDP2/RQk47rhc X-Google-Smtp-Source: ABdhPJw3LSalbk6bdlfVzuY79OzxpwkR1KzT5aX3N76A2GkC//bQUISzqr0TMsDOQCG67FaFcx8a9w== X-Received: by 2002:a17:902:8c89:: with SMTP id t9mr13290222plo.66.1600074721684; Mon, 14 Sep 2020 02:12:01 -0700 (PDT) Received: from LiHaiwei.tencent.com ([203.205.141.65]) by smtp.gmail.com with ESMTPSA id m13sm8765179pjl.45.2020.09.14.02.11.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2020 02:12:00 -0700 (PDT) From: lihaiwei.kernel@gmail.com To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org Cc: pbonzini@redhat.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, lihaiwei@tencent.com, kernel test robot Subject: [PATCH 1/2] KVM: Fix the build error Date: Mon, 14 Sep 2020 17:11:47 +0800 Message-Id: <20200914091148.95654-2-lihaiwei.kernel@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200914091148.95654-1-lihaiwei.kernel@gmail.com> References: <20200914091148.95654-1-lihaiwei.kernel@gmail.com> MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Haiwei Li When CONFIG_SMP is not set, an build error occurs with message "error: use of undeclared identifier 'kvm_send_ipi_mask_allbutself'" Fixes: 0f990222108d ("KVM: Check the allocation of pv cpu mask", 2020-09-01) Reported-by: kernel test robot Signed-off-by: Haiwei Li --- arch/x86/kernel/kvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 1b51b727b140..7e8be0421720 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -797,7 +797,9 @@ static __init int kvm_alloc_cpumask(void) } } +#if defined(CONFIG_SMP) apic->send_IPI_mask_allbutself = kvm_send_ipi_mask_allbutself; +#endif pv_ops.mmu.flush_tlb_others = kvm_flush_tlb_others; return 0; From patchwork Mon Sep 14 09:11:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Haiwei Li X-Patchwork-Id: 11773375 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C0A396CA for ; Mon, 14 Sep 2020 09:12:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CA5521741 for ; Mon, 14 Sep 2020 09:12:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g15SUR4A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726262AbgINJML (ORCPT ); Mon, 14 Sep 2020 05:12:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726249AbgINJMH (ORCPT ); Mon, 14 Sep 2020 05:12:07 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2952AC06174A; Mon, 14 Sep 2020 02:12:07 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id f2so9007966pgd.3; Mon, 14 Sep 2020 02:12:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cNPaexwdRbC0vdnnc/ZlaorxWPNe3E9MlyDWCDU1qxc=; b=g15SUR4A1W9BYX5FF7LdjklB1QMIvQfgK962p7cJsg6EnMw4sN8VPquCRp2x6eFwM1 chg8YGuNp76jd8NWwlBZh//AU5X8UO4cJTAlFT/NngZVrgQfcHjayRGXcUlM/IMLZO5g hC2yS56YupjW34QAAd8DCZ3lAeElYOCm4VUvcDbTLPJ69aXkaYoewC/PFdGTvlgBl0Bm QtLDUJpMPKn+AyDapstA2yWKNVi+efx5LjPRvIaX21StEz2J96DXAH1lV444DIEaxhz6 koVGBzDXxbpwNSg6Oemv56kiju0RxPw3AXRa4GN4SJqJgEKV6PB+pzpR2T9yzdhQTf1Y VNwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cNPaexwdRbC0vdnnc/ZlaorxWPNe3E9MlyDWCDU1qxc=; b=ZHnTGP2AyzQuZgLpspKNWt7A6A/SwIWanJtA486grebPjbRb32eU9PMCyqzqd9tJd/ KQSW6V2T7bdCS8nNATOPBe7ifgfQbROXnHpeyhi3/ol2zcQodsNSt4lJNDoeq+pPY1AK To2vhZjJOrvYW7IzzD5DoWuI8mjaPjDGAfx4DmmG4lZqt2Mu0LyS0GmdtaWiIqvBxOUE noFRhakPnvlDoBl/4SiNSKNOoSjMFhQIAC62lIzvYeReNlKBVs7NMov3lUClbRtt23O5 C9kvIICNdXwO0SO6boplAFu4Z9qzuu50TBJbxsbFWASt7NMipbfPvzOUVeJazDWmah+5 ESLw== X-Gm-Message-State: AOAM5331MeE1GqP8wkL9lHB6qM9MkAq8xMcHR1QZrAudMBrb0gl+U4GV RSN8YvX2Sce2ouJFnvvkWcAg59MR+cqt X-Google-Smtp-Source: ABdhPJwDswq9ClQszcetLtcvrdOXh5MPugFPoy6/mH75vcuJfuxAQxPW2X2rt3RArOel2TjhEg90Xw== X-Received: by 2002:a63:5f8b:: with SMTP id t133mr10581594pgb.238.1600074726186; Mon, 14 Sep 2020 02:12:06 -0700 (PDT) Received: from LiHaiwei.tencent.com ([203.205.141.65]) by smtp.gmail.com with ESMTPSA id m13sm8765179pjl.45.2020.09.14.02.12.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 14 Sep 2020 02:12:05 -0700 (PDT) From: lihaiwei.kernel@gmail.com To: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, x86@kernel.org Cc: pbonzini@redhat.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, lihaiwei@tencent.com Subject: [PATCH 2/2] KVM: Check if __pv_cpu_mask was allocated instead of assigning ops too late Date: Mon, 14 Sep 2020 17:11:48 +0800 Message-Id: <20200914091148.95654-3-lihaiwei.kernel@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200914091148.95654-1-lihaiwei.kernel@gmail.com> References: <20200914091148.95654-1-lihaiwei.kernel@gmail.com> MIME-Version: 1.0 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Haiwei Li Without this patch, kvm_flush_tlb_others is not called. We can always check if __pv_cpu_mask was allocated and revert back to the architectural path if not. Suggested-by: Vitaly Kuznetsov Signed-off-by: Haiwei Li --- arch/x86/kernel/kvm.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c index 7e8be0421720..3c6c516d9828 100644 --- a/arch/x86/kernel/kvm.c +++ b/arch/x86/kernel/kvm.c @@ -553,7 +553,6 @@ static void kvm_send_ipi_mask_allbutself(const struct cpumask *mask, int vector) static void kvm_setup_pv_ipi(void) { apic->send_IPI_mask = kvm_send_ipi_mask; - apic->send_IPI_mask_allbutself = kvm_send_ipi_mask_allbutself; pr_info("setup PV IPIs\n"); } @@ -619,6 +618,11 @@ static void kvm_flush_tlb_others(const struct cpumask *cpumask, struct kvm_steal_time *src; struct cpumask *flushmask = this_cpu_cpumask_var_ptr(__pv_cpu_mask); + if (unlikely(!flushmask)) { + native_flush_tlb_others(cpumask, info); + return; + } + cpumask_copy(flushmask, cpumask); /* * We have to call flush only on online vCPUs. And @@ -652,6 +656,7 @@ static void __init kvm_guest_init(void) } if (pv_tlb_flush_supported()) { + pv_ops.mmu.flush_tlb_others = kvm_flush_tlb_others; pv_ops.mmu.tlb_remove_table = tlb_remove_table; pr_info("KVM setup pv remote TLB flush\n"); } @@ -800,7 +805,6 @@ static __init int kvm_alloc_cpumask(void) #if defined(CONFIG_SMP) apic->send_IPI_mask_allbutself = kvm_send_ipi_mask_allbutself; #endif - pv_ops.mmu.flush_tlb_others = kvm_flush_tlb_others; return 0; zalloc_cpumask_fail: