From patchwork Wed Sep 16 06:50:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11779139 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5D3CB59D for ; Wed, 16 Sep 2020 06:50:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39D5020771 for ; Wed, 16 Sep 2020 06:50:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="klQl88QN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726128AbgIPGuk (ORCPT ); Wed, 16 Sep 2020 02:50:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45730 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgIPGuh (ORCPT ); Wed, 16 Sep 2020 02:50:37 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7FDFC06174A for ; Tue, 15 Sep 2020 23:50:36 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id w2so1638799wmi.1 for ; Tue, 15 Sep 2020 23:50:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LbhKnr+daA1Lbh8a5+Uxi4Fk14MMdGVCMAhEuc0wWw8=; b=klQl88QNyNoeWcFxpNdTVJTFMt8TrfgfL4w99+Q54TkXs4gHbf+fS6TcGxzSEQpakU tfJHjItMCzf7rDuqdQkAInIZIXa8/xHE/aHoHnyXmdoT3KkgpcWQet/h/3URCHkRrJI5 cyfZTbo1dzp2BJ4FzTYdbtAthPNJWhLnSjpV8rwfEkXo0wQdhlfi6ClHGARTY0ohAZpC JE4YBOfoyNpNlgt1sURpvZ6zOltZHnPJM0IAAW5L9khpDBsj5vhk3VeroclqBSEI7hR7 l9p4erDStcIlW3teiBPo126Ei7ePFa0Ekd2jmgeuWe5NGbJZG2bPNkSXJJBtUVE4ui/x BHtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LbhKnr+daA1Lbh8a5+Uxi4Fk14MMdGVCMAhEuc0wWw8=; b=WrTQ7nfrJR8reKN4UKES7ZJk5OWA3SCZCe3Emx5NdZkyYx1PgrLEPAPKnmuuyv6FJt GS1AbSTKjb1ouFpukTXRl30uBNWf5QXNYryiaviUecxSe6Io3AeYCjFRG2r6jfxOk0H1 M+9fKqPz1fvAfDk0LWzIj/NTN8c69uuU2h9lx2F/gPZR1CzYQcTPZXylKno5ZS1QFM1+ M1poGVtRbnxTsrJcN9z7byG7595i2bDScsGYiNVoMdcRo7pG5fk2Qpj1rEoDoq7OnNES +oJjI0aSGSW/XL3f272h61fpCIDNbNOdnWORKWlcsSrijykVgt1EAcA0y4tApkIvKQ4p 3CMA== X-Gm-Message-State: AOAM531J6WE1sxZAA6ym2XUnXUUgcEa1WVSSjDeulDcvJpiXBSSrybiS ylYm2iqc8m6ixjmZSkydWQ1L0Qeno0A= X-Google-Smtp-Source: ABdhPJyMx5cfrXF/sACeaxvfXmzPqObG7t8KWHt+cBg9CxMhsdsM1h3lGsMAGbxaXEOlSL9b80lsRw== X-Received: by 2002:a1c:b386:: with SMTP id c128mr2965825wmf.82.1600239033258; Tue, 15 Sep 2020 23:50:33 -0700 (PDT) Received: from localhost.localdomain ([84.40.93.108]) by smtp.gmail.com with ESMTPSA id u126sm4229028wmu.9.2020.09.15.23.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 23:50:32 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: linux-trace-devel@vger.kernel.org Cc: rostedt@goodmis.org, "Yordan Karadzhov (VMware)" Subject: [PATCH 1/4] kernel-shark :Fix all build warnings for gcc 10.2.1 Date: Wed, 16 Sep 2020 09:50:04 +0300 Message-Id: <20200916065007.9755-1-y.karadz@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Tested on Fedora 32: gcc (GCC) 10.2.1 20200723 (Red Hat 10.2.1-1) Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsAdvFilteringDialog.cpp | 6 +++--- kernel-shark/src/KsCaptureDialog.cpp | 2 +- kernel-shark/src/KsTraceGraph.cpp | 23 ++++++++--------------- kernel-shark/src/KsTraceGraph.hpp | 4 ++++ kernel-shark/src/KsUtils.cpp | 4 ++-- kernel-shark/src/KsUtils.hpp | 6 +++--- kernel-shark/src/KsWidgetsLib.cpp | 6 +++--- 7 files changed, 24 insertions(+), 27 deletions(-) diff --git a/kernel-shark/src/KsAdvFilteringDialog.cpp b/kernel-shark/src/KsAdvFilteringDialog.cpp index 6af1aea..8dc53bb 100644 --- a/kernel-shark/src/KsAdvFilteringDialog.cpp +++ b/kernel-shark/src/KsAdvFilteringDialog.cpp @@ -170,7 +170,7 @@ void KsAdvFilteringDialog::_setSystemCombo(struct kshark_context *kshark_ctx) } } - qSort(sysList); + std::sort(sysList.begin(), sysList.end()); _systemComboBox.addItems(sysList); i = _systemComboBox.findText("ftrace"); @@ -291,7 +291,7 @@ void KsAdvFilteringDialog::_systemChanged(const QString &sysName) evtsList << events[i]->name; } - qSort(evtsList); + std::sort(evtsList.begin(), evtsList.end()); _eventComboBox.addItems(evtsList); i = _eventComboBox.findText("function"); @@ -310,7 +310,7 @@ KsAdvFilteringDialog::_getEventFormatFields(struct tep_event *event) free(fields); - qSort(fieldList); + std::sort(fieldList.begin(), fieldList.end()); return fieldList; } diff --git a/kernel-shark/src/KsCaptureDialog.cpp b/kernel-shark/src/KsCaptureDialog.cpp index d6f8014..63fd5d6 100644 --- a/kernel-shark/src/KsCaptureDialog.cpp +++ b/kernel-shark/src/KsCaptureDialog.cpp @@ -219,7 +219,7 @@ QStringList KsCaptureControl::_getPlugins() } free (all_plugins); - qSort(pluginList); + std::sort(pluginList.begin(), pluginList.end()); return pluginList; } diff --git a/kernel-shark/src/KsTraceGraph.cpp b/kernel-shark/src/KsTraceGraph.cpp index 90f83f3..f21fcfc 100644 --- a/kernel-shark/src/KsTraceGraph.cpp +++ b/kernel-shark/src/KsTraceGraph.cpp @@ -282,11 +282,9 @@ void KsTraceGraph::_stopUpdating() void KsTraceGraph::_resetPointer(uint64_t ts, int cpu, int pid) { uint64_t sec, usec; - QString pointer; kshark_convert_nano(ts, &sec, &usec); - pointer.sprintf("%" PRIu64 ".%06" PRIu64 "", sec, usec); - _labelP2.setText(pointer); + _labelP2.setText(_t2str(sec, usec)); if (pid > 0 && cpu >= 0) { struct kshark_context *kshark_ctx(NULL); @@ -316,13 +314,12 @@ void KsTraceGraph::_setPointerInfo(size_t i) QString lat(kshark_get_latency_easy(e)); QString info(kshark_get_info_easy(e)); QString comm(kshark_get_task_easy(e)); - QString pointer, elidedText; int labelWidth, width; + QString elidedText; uint64_t sec, usec; kshark_convert_nano(e->ts, &sec, &usec); - pointer.sprintf("%" PRIu64 ".%06" PRIu64 "", sec, usec); - _labelP2.setText(pointer); + _labelP2.setText(_t2str(sec, usec)); comm.append("-"); comm.append(QString("%1").arg(kshark_get_pid_easy(e))); @@ -445,7 +442,7 @@ void KsTraceGraph::addCPUPlot(int cpu) return; _glWindow._cpuList.append(cpu); - qSort(_glWindow._cpuList); + std::sort(_glWindow._cpuList.begin(), _glWindow._cpuList.end()); _selfUpdate(); } @@ -456,7 +453,7 @@ void KsTraceGraph::addTaskPlot(int pid) return; _glWindow._taskList.append(pid); - qSort(_glWindow._taskList); + std::sort(_glWindow._taskList.begin(), _glWindow._taskList.end()); _selfUpdate(); } @@ -606,21 +603,17 @@ void KsTraceGraph::_updateGraphLegends() void KsTraceGraph::_updateTimeLegends() { uint64_t sec, usec, tsMid; - QString tMin, tMid, tMax; kshark_convert_nano(_glWindow.model()->histo()->min, &sec, &usec); - tMin.sprintf("%" PRIu64 ".%06" PRIu64 "", sec, usec); - _labelXMin.setText(tMin); + _labelXMin.setText(_t2str(sec, usec)); tsMid = (_glWindow.model()->histo()->min + _glWindow.model()->histo()->max) / 2; kshark_convert_nano(tsMid, &sec, &usec); - tMid.sprintf("%" PRIu64 ".%06" PRIu64 "", sec, usec); - _labelXMid.setText(tMid); + _labelXMid.setText(_t2str(sec, usec)); kshark_convert_nano(_glWindow.model()->histo()->max, &sec, &usec); - tMax.sprintf("%" PRIu64 ".%06" PRIu64 "", sec, usec); - _labelXMax.setText(tMax); + _labelXMax.setText(_t2str(sec, usec)); } /** diff --git a/kernel-shark/src/KsTraceGraph.hpp b/kernel-shark/src/KsTraceGraph.hpp index c53258c..8abc06b 100644 --- a/kernel-shark/src/KsTraceGraph.hpp +++ b/kernel-shark/src/KsTraceGraph.hpp @@ -108,6 +108,10 @@ private: void _markerReDraw(); + QString _t2str(uint64_t sec, uint64_t usec) { + return QString::number(sec) + "." + QString::number(usec); + }; + enum class GraphActions { ZoomIn, ZoomOut, diff --git a/kernel-shark/src/KsUtils.cpp b/kernel-shark/src/KsUtils.cpp index 8c61b3f..24f7178 100644 --- a/kernel-shark/src/KsUtils.cpp +++ b/kernel-shark/src/KsUtils.cpp @@ -48,7 +48,7 @@ QVector getPidList() free(tempPids); - qSort(pids); + std::sort(pids.begin(), pids.end()); return pids; } @@ -90,7 +90,7 @@ QVector getFilterIds(tracecmd_filter_id *filter) for (int i = 0; i < n; ++i) v.append(cpuFilter[i]); - qSort(v); + std::sort(v.begin(), v.end()); free(cpuFilter); return v; diff --git a/kernel-shark/src/KsUtils.hpp b/kernel-shark/src/KsUtils.hpp index 9adacd8..2772b84 100644 --- a/kernel-shark/src/KsUtils.hpp +++ b/kernel-shark/src/KsUtils.hpp @@ -25,10 +25,10 @@ #include "KsPlotTools.hpp" /** Macro providing the height of the screen in pixels. */ -#define SCREEN_HEIGHT QApplication::desktop()->screenGeometry().height() +#define SCREEN_HEIGHT QGuiApplication::screens()[0]->geometry().height() /** Macro providing the width of the screen in pixels. */ -#define SCREEN_WIDTH QApplication::desktop()->screenGeometry().width() +#define SCREEN_WIDTH QGuiApplication::screens()[0]->geometry().width() //! @cond Doxygen_Suppress @@ -45,7 +45,7 @@ static auto stringWidth = [](QString s) QFont font; QFontMetrics fm(font); - return fm.width(s); + return fm.horizontalAdvance(s); }; //! @endcond diff --git a/kernel-shark/src/KsWidgetsLib.cpp b/kernel-shark/src/KsWidgetsLib.cpp index 330230e..a84aff3 100644 --- a/kernel-shark/src/KsWidgetsLib.cpp +++ b/kernel-shark/src/KsWidgetsLib.cpp @@ -642,7 +642,7 @@ KsCPUCheckBoxWidget::KsCPUCheckBoxWidget(struct tep_handle *tep, cpuItem->setText(0, " "); cpuItem->setText(1, QString("CPU %1").arg(i)); cpuItem->setCheckState(0, Qt::Checked); - cpuItem->setBackgroundColor(0, QColor(colors[i].r(), + cpuItem->setBackground(0, QColor(colors[i].r(), colors[i].g(), colors[i].b())); _tree.addTopLevelItem(cpuItem); @@ -799,12 +799,12 @@ KsTasksCheckBoxWidget::KsTasksCheckBoxWidget(struct tep_handle *pevent, comm = tep_data_comm_from_pid(kshark_ctx->pevent, pid); comItem = new QTableWidgetItem(tr(comm)); - pidItem->setBackgroundColor(QColor(colors[pid].r(), + pidItem->setBackground(QColor(colors[pid].r(), colors[pid].g(), colors[pid].b())); if (_id[i] == 0) - pidItem->setTextColor(Qt::white); + pidItem->setForeground(Qt::white); _table.setItem(i, 2, comItem); } From patchwork Wed Sep 16 06:50:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11779141 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B70F8618 for ; Wed, 16 Sep 2020 06:50:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9893A20771 for ; Wed, 16 Sep 2020 06:50:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XpFfqeV0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726180AbgIPGum (ORCPT ); Wed, 16 Sep 2020 02:50:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgIPGul (ORCPT ); Wed, 16 Sep 2020 02:50:41 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB668C06174A for ; Tue, 15 Sep 2020 23:50:40 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id k18so1708120wmj.5 for ; Tue, 15 Sep 2020 23:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1O4oy929EsjdKBRqEYo9j4n/1OGlYV9VezHHXlxYp4o=; b=XpFfqeV08Xs9JIqL7/toysfDcPKKYUbwG+nvI6XkvrNMjSWi+ZEkAbq5PhtHuc9kAi qN6C/elU1EY5V4ivgL8+KK1KpLAXxrjiLSkiv9j7+gyVmHnprTAJDSA3Yp07DIl9tDlF GxNoP90WNg78urMrfTICNCB11k5p3PAHapFdurTYstCG5rZWJdP2CWQlEXwA8sJMhNbO 32bRplEU6uOnEWqnwbiAKZqjFSf7k6sINJ50BusH/4WnwuYlhiUz0mnCYtZxHf1Cs8he 17yiXfcnBSADZYi4+xknWpFRJxsg/eviYlUhQRXMRfLxOM5Ut5iY4bhvxbmZHXxUO9iH HsDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1O4oy929EsjdKBRqEYo9j4n/1OGlYV9VezHHXlxYp4o=; b=oIh9L4r9gBThqwg8LQElMG2g80LZwdhiOvrLzRhSniMeZ5Nr8oGy/LlQjTNY7v9apW bO9t05QtwzTxLwtPvCtS/FSZma2BDE4xwS2ID6Kc1ravtDe1L7R56jcuwAj+AjMUVKvj RpQL7OBzo/+yaNZHcopxoiBIYrSRX7w4+W8a8x1kUD/jM9a1VXbQqX8Zn3Ih2pM2XVwF cOQbOaN89K0RdvO9Ry5hgd2R9yNik1Ep6+X/C7F5kqPj7mZFCx5abkIn9cDXPuAbcL8n CbvBrsuYG5B2BTX9nEbOKI5IDpK415qGkcW3O3smf2YloE74pjzRC3iOsl5T/U7GecqD qWXw== X-Gm-Message-State: AOAM532jVSoo8zdJmFHYyHa3oPX7itsRZprmiHBlbnXrzMDRnry/TwqO gD6eJ/ny6AnjWhAlmWuvSB9za5w2q30= X-Google-Smtp-Source: ABdhPJwnn/sAQjhdpa4LoyXrgTZNXR/7BtMEBZy8skU3csqr66ys9QqrbmdxP2lCl8cEgLlR7iXhlg== X-Received: by 2002:a1c:9885:: with SMTP id a127mr3012464wme.8.1600239039342; Tue, 15 Sep 2020 23:50:39 -0700 (PDT) Received: from localhost.localdomain ([84.40.93.108]) by smtp.gmail.com with ESMTPSA id u126sm4229028wmu.9.2020.09.15.23.50.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 23:50:38 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: linux-trace-devel@vger.kernel.org Cc: rostedt@goodmis.org, "Yordan Karadzhov (VMware)" Subject: [PATCH 2/4] kernel-shark: Have correct screen geometry on high-resolution screens Date: Wed, 16 Sep 2020 09:50:05 +0300 Message-Id: <20200916065007.9755-2-y.karadz@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200916065007.9755-1-y.karadz@gmail.com> References: <20200916065007.9755-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org A scale factor (also called "Device Pixel Ratio") is often applied in the display settings when running on laptops having high-resolution screens. Take this scale factor into consideration when calculating the screen size. Note that the size of some widget is set to be a fractions of the total size of the screen. Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/KsUtils.hpp | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/kernel-shark/src/KsUtils.hpp b/kernel-shark/src/KsUtils.hpp index 2772b84..a07af1a 100644 --- a/kernel-shark/src/KsUtils.hpp +++ b/kernel-shark/src/KsUtils.hpp @@ -25,10 +25,18 @@ #include "KsPlotTools.hpp" /** Macro providing the height of the screen in pixels. */ -#define SCREEN_HEIGHT QGuiApplication::screens()[0]->geometry().height() +#define SCREEN_HEIGHT \ + ( \ + QGuiApplication::screens()[0]->geometry().height() / \ + QApplication::desktop()->devicePixelRatio() \ + ) /** Macro providing the width of the screen in pixels. */ -#define SCREEN_WIDTH QGuiApplication::screens()[0]->geometry().width() +#define SCREEN_WIDTH \ + ( \ + QGuiApplication::screens()[0]->geometry().width() / \ + QApplication::desktop()->devicePixelRatio() \ + ) //! @cond Doxygen_Suppress From patchwork Wed Sep 16 06:50:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11779143 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C9BE659D for ; Wed, 16 Sep 2020 06:50:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9CAD820771 for ; Wed, 16 Sep 2020 06:50:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nVTflLHx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726189AbgIPGup (ORCPT ); Wed, 16 Sep 2020 02:50:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgIPGun (ORCPT ); Wed, 16 Sep 2020 02:50:43 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 229CAC06174A for ; Tue, 15 Sep 2020 23:50:43 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id a9so1723006wmm.2 for ; Tue, 15 Sep 2020 23:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+KZBIOcQJGO9I4kPWIAQkCtXcR3Btg9aV1WDBLfLbGw=; b=nVTflLHx8AnmBOtxWJiRZN48D/KbDhZq3BU4XBt5n/SUhqmT7QsalIEE2WcqRI9Pe5 F77rIS3LfDTbGNPDdIRUDcZNsj74i3Fgl/7ZSSs4S2xgPjTvbNPQUTj7613vkkZk7tHX GwUzuw+GESCext10mL9PNsnt53+hzetDYvp1lkOSJ8LY1LDWZ5U94hR2ruDd35o8pTOG X/nOxCtnWtcUMjjDjCPS5RT0f1FeNNVtqH8xOqwtQtQbQGuvHlGCjXyBKLO1FQZrKE0I k34wEOasC6ZlFSGxjfPr60W0+P+mIV5rX+26nF0dz6HRE7vL+1Qqm/C5D4r8t/W54Voj 3u3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+KZBIOcQJGO9I4kPWIAQkCtXcR3Btg9aV1WDBLfLbGw=; b=fumzFaQDZkdcK9LVLVFWrE61Bwud5yd1uo782QjONQ5MnIV0kgeJQa4EKR9WGTcZFB xQoJuvgLtYQbYyLtPk8t3DjqHyHGs9XfX9/m1GUv6g7ANiykxILFXCrwg0Sx0HRKri1W A2kgjiHTgMHBVEFSy4Tm7o/wRp6TN4oVB/icUTuKPyUO7JeWOH5ew74hxiiO+GuiRdOV Cpnjnioyxl+E15KNC/B+OUTbGvusAF4RNMpyVHWJmYfU9RlArMJOUCa+/fhheVgx4jBZ HuyxEHoJeoYY6qlUyWp0tOqFqe72+ZyHPJndg288ODsQdvfy6ZKurN6uo40R1MF2kZbP Pxag== X-Gm-Message-State: AOAM530CAixkcpCI8P0y3STur292jbcm2FhkJsjc8wZQYmrGCJDty4nh uWRFcZAUwx9KdYnVTsK99s0ZIjvtjnY= X-Google-Smtp-Source: ABdhPJwVjHW4MBPWzuh+1NZ9lJWhZcc952uqFTx3zJoVwJLG04krntOhR3mGLB0byptCb7B721FRAg== X-Received: by 2002:a7b:c751:: with SMTP id w17mr2917729wmk.97.1600239041689; Tue, 15 Sep 2020 23:50:41 -0700 (PDT) Received: from localhost.localdomain ([84.40.93.108]) by smtp.gmail.com with ESMTPSA id u126sm4229028wmu.9.2020.09.15.23.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 23:50:41 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: linux-trace-devel@vger.kernel.org Cc: rostedt@goodmis.org, "Yordan Karadzhov (VMware)" Subject: [PATCH 3/4] kernel-shark: Check if Qt has been found when building the examples Date: Wed, 16 Sep 2020 09:50:06 +0300 Message-Id: <20200916065007.9755-3-y.karadz@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200916065007.9755-1-y.karadz@gmail.com> References: <20200916065007.9755-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org Some of the examples depend on Qt. Check if Qt exists befor trying to build these examples. Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/examples/CMakeLists.txt | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/kernel-shark/examples/CMakeLists.txt b/kernel-shark/examples/CMakeLists.txt index 35e6b1e..032f305 100644 --- a/kernel-shark/examples/CMakeLists.txt +++ b/kernel-shark/examples/CMakeLists.txt @@ -20,10 +20,14 @@ message(STATUS "dataplot") add_executable(dplot dataplot.cpp) target_link_libraries(dplot kshark-plot) -message(STATUS "widgetdemo") -add_executable(widgetdemo widgetdemo.cpp) -target_link_libraries(widgetdemo kshark-gui) +if (Qt5Widgets_FOUND) -message(STATUS "cmd_split") -add_executable(cmd_split cmd_split.cpp) -target_link_libraries(cmd_split kshark-gui) + message(STATUS "widgetdemo") + add_executable(widgetdemo widgetdemo.cpp) + target_link_libraries(widgetdemo kshark-gui) + + message(STATUS "cmd_split") + add_executable(cmd_split cmd_split.cpp) + target_link_libraries(cmd_split kshark-gui) + +endif (Qt5Widgets_FOUND) From patchwork Wed Sep 16 06:50:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yordan Karadzhov X-Patchwork-Id: 11779145 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1E373139F for ; Wed, 16 Sep 2020 06:50:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0385021655 for ; Wed, 16 Sep 2020 06:50:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UuIizSc3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726205AbgIPGup (ORCPT ); Wed, 16 Sep 2020 02:50:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726100AbgIPGup (ORCPT ); Wed, 16 Sep 2020 02:50:45 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25928C061788 for ; Tue, 15 Sep 2020 23:50:45 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id a17so5653982wrn.6 for ; Tue, 15 Sep 2020 23:50:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xljRxOswziSj96hf/7PT4i2JmxBjSbGMgID4XBhpHfw=; b=UuIizSc3fpnyUevOMpcR7oVHcWASVmpnmlCmxOik6dC3K9+AKiy3ifUuugZebvbwe/ 4lkfwu3cJAYylx/wiYb7jw9qNmLGZjvofFdhS5EUwLS4jPWvE7t6q7cljR8krn6TPhh5 MB0FmhYwKJBYJzom0NlsP+bnswVx43C5QPtA0fs4H2dNsTYtKHC/1A9uHUMDeKgCKBeZ VBDYnqO+1eVl+Pmgy8gB0v1OJNW9x9DidFt5Xcqwr3mqjU2KfkfGddxiE5KIfan4QRFn Md1o2OWBd+jPkNpeHlXG3qdRt6t1xYTGCM5U4N0H1NJC/8X89IYHtwv42FTAo5+hYyRg mJ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xljRxOswziSj96hf/7PT4i2JmxBjSbGMgID4XBhpHfw=; b=b1616lHWxbiH0xPZQ1yT19SGsnIRh6cfGmGHqw41BN+D7seDuQvJD6VPVvS9B3YoJJ 7mgyaDgJesv2qdEiSV83+CEGqQVli4dcickOhyhzP5YbC9aCpG23mxirGHnbWxEcRb3z 4siF0mNaL8IX720MPHVGa2MeLsOdpGuAsB4VV66A2mN2k/fBU038EjcuG4KaWqCyCW3u Y434jjEHnoYRfUcs3YjRhgD/mYGr9zc7pLjIVKnX+E/+6acDG5hqb4ULg46qmxTZRlsa qhJbMyAuP6+/6B/g0ch3Dte5H34ixt1YIG5nrKQhiuDkfzAkMJsNffIjeH+FpMJBxgR7 /dUA== X-Gm-Message-State: AOAM530sCfKF+0ERnh8zJXzfzJDhIv8lEtChEUxPzvZT3E/SFDfIG87I UzIZNJI0JEGP7gqvg1etrGabJ/6eLaw= X-Google-Smtp-Source: ABdhPJxubOFyNCnd+fy9pZn9g5t2Agc+D7Qk+GfrKesLV/eAPGvfZWg2Af1sdp4ymaYwTZfw6hArnQ== X-Received: by 2002:a5d:51c5:: with SMTP id n5mr988868wrv.265.1600239043634; Tue, 15 Sep 2020 23:50:43 -0700 (PDT) Received: from localhost.localdomain ([84.40.93.108]) by smtp.gmail.com with ESMTPSA id u126sm4229028wmu.9.2020.09.15.23.50.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 23:50:43 -0700 (PDT) From: "Yordan Karadzhov (VMware)" To: linux-trace-devel@vger.kernel.org Cc: rostedt@goodmis.org, "Yordan Karadzhov (VMware)" , Ziqian SUN Subject: [PATCH 4/4] kernel-shark: Fix dependency (symbol resolving) issue Date: Wed, 16 Sep 2020 09:50:07 +0300 Message-Id: <20200916065007.9755-4-y.karadz@gmail.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200916065007.9755-1-y.karadz@gmail.com> References: <20200916065007.9755-1-y.karadz@gmail.com> MIME-Version: 1.0 Sender: linux-trace-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org When linking KernelShark libraries we must take into account the intrinsic dependency hierarchy of the trace-cmd libraries. "libtraceevent" is the most basic one. "libtracefs" depends on "libtraceevent" and "libtracecmd" depends on both "libtraceevent" and "libtracefs". In order to guarantee a correct symbol resolution during linking, those libraries must be listed in a reverse order (the most basic comes last). Reported-by: Ziqian SUN (Zamir) Signed-off-by: Yordan Karadzhov (VMware) --- kernel-shark/src/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel-shark/src/CMakeLists.txt b/kernel-shark/src/CMakeLists.txt index 9666b18..0627783 100644 --- a/kernel-shark/src/CMakeLists.txt +++ b/kernel-shark/src/CMakeLists.txt @@ -7,10 +7,10 @@ add_library(kshark SHARED libkshark.c libkshark-configio.c libkshark-collection.c) -target_link_libraries(kshark ${TRACEEVENT_LIBRARY} - ${TRACECMD_LIBRARY} +target_link_libraries(kshark ${TRACECMD_LIBRARY} ${TRACEFS_LIBRARY} - ${JSONC_LIBRARY} + ${TRACEEVENT_LIBRARY} + ${JSONC_LIBRARY} ${CMAKE_DL_LIBS}) set_target_properties(kshark PROPERTIES SUFFIX ".so.${KS_VERSION_STRING}")