From patchwork Wed Sep 16 12:57:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Joel Stanley X-Patchwork-Id: 11779721 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECC40618 for ; Wed, 16 Sep 2020 12:59:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BB63B22272 for ; Wed, 16 Sep 2020 12:59:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IoYw3nwn"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s0ZjKlEW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BB63B22272 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=jms.id.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=GpNQqL+478BDGLTNJtGprm6klkTM1fcDFhiyPK1wySk=; b=IoYw3nwnSxd8q2ZIq2269sRv2q GiEa5MbmoOJI4NkGH/m7q1vWqFVJGOVRy3B9n507oMhlm9aCflSXJAFLiNfkq6S4BlMFHD4pev6Zc Y4ZB1DeoHLeZ2Xda84V4PeoWXOMeNB+XwZimQDFA/GTn5S6qY+S04JQaduWinXl8c5cbXjXLsFCtk xV96qYkZ3I1abbZ3kg/VwzF3TWnVclT2b8gZRKth9/6AAy2iOzpYbU8+lT6OBrHOV2CEUQ0GZIK1e 6qxyDV0Q31/RJtPdN0SPWxOz0BNUqXDKo2rOXTsXcdj6MijaG7BO/r69UNpOrEL9CbssOgH53naUQ rrD48qPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIX0Q-0002LO-L5; Wed, 16 Sep 2020 12:57:50 +0000 Received: from mail-pj1-x1041.google.com ([2607:f8b0:4864:20::1041]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kIX0N-0002Kw-IH for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 12:57:48 +0000 Received: by mail-pj1-x1041.google.com with SMTP id q4so1549795pjh.5 for ; Wed, 16 Sep 2020 05:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+dJA1uVe0UwJ9j+G3rPsxZvQe5x8LCuXQ+8c9AMCh68=; b=s0ZjKlEWPCePHMQjJUeiQuXVLyAZcEpyCJCe3Jy1W+Qhp/VFeqJuHPGEyFp+7puWiy ydJxzkNMJh/iZIRQ4KHRzLnv+v+4Wlyrq4V6ck57gRP/twsEP8zBzEqQtwkhZ1aZyEIp jqL5KiM3ZxZ2AL5np5zdG2G1FfX3xEbrwcGgE3h2xgcEUtNrFmLSYik5CotNp1jf9avw Nn/MDzIK3KR+ECHd7r3PIzLV7KdCknO3I8WpHqgQHky6kaSKcaLBA028OvuwGZx6wp9e +zB3PZT5IqZR8xNZ9/571Npn1NQ6frG2zhQx91FOLOvYXfZPQVexj+a4Uk62oUS2ztgg oY/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=+dJA1uVe0UwJ9j+G3rPsxZvQe5x8LCuXQ+8c9AMCh68=; b=Z86xQW/IDs21adwAcBhBOsEkmVWaykZ2lMxI4iPdcOnlgT4WyAMBWV7xF3+xxMU50Y eSANOWyM4ULhGvTrX7JXnkqJVH84vQIZqdzhPIKxi+GGE7ArrJJxjTbyGiAFXyxATzvS KvWenzrr7dcwVO7PE+ZQl67vNPscsJf31LKipRT1iV++0PkB6EzipmNdPcO0ww3ezwkC EDZwQY8Oxx+VJlbjs1E9uAAEjeB6BWM8aCoG9PL5tXPa6uv0hpEkjArGYdrKJgkcRbzV UFEJSjHxFMlsvFM6DzBnCVke3NF0PYoq4nSPUWtqmcKVYoW+aKNkAob5zIuaXg4kDT56 Gzxg== X-Gm-Message-State: AOAM530qpvkBJDVUQqWwM/kzMukadJf/bEWokSLj1wMqMvMMaDc8n3gV CxtaRL/+lIYCHvCtSqKpTiM= X-Google-Smtp-Source: ABdhPJyNsrtOLXJkKhPYLevPGZikNQW08kONdspYFoTQt2i0v77jpmd8k3EADKmqWWmZ60I1T/kTZQ== X-Received: by 2002:a17:90a:e981:: with SMTP id v1mr3823610pjy.177.1600261065222; Wed, 16 Sep 2020 05:57:45 -0700 (PDT) Received: from localhost.localdomain ([45.124.203.18]) by smtp.gmail.com with ESMTPSA id s24sm2682910pjp.53.2020.09.16.05.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 05:57:44 -0700 (PDT) From: Joel Stanley To: =?utf-8?q?C=C3=A9dric_Le_Goater?= , Arnd Bergmann , Andrew Jeffery Subject: [PATCH] soc: aspeed: Improve kconfig Date: Wed, 16 Sep 2020 22:27:31 +0930 Message-Id: <20200916125731.784527-1-joel@jms.id.au> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_085747_685192_BC9881E4 X-CRM114-Status: GOOD ( 13.98 ) X-Spam-Score: 0.4 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (0.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1041 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [joel.stan[at]gmail.com] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Reword the kconfig text to be consistent and reflect that most drivers are available for all supported ASPEED chips (2400, 2500 and 2600). Rearrange the symbols the SoC drivers depend on so the menu doesn't appear unless you are building for ASPEED for compile testing. The SYSCON_MFD and REGMAP options are usually selected by drivers that need them, so do this. Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Reviewed-by: Andrew Jeffery --- drivers/soc/aspeed/Kconfig | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/soc/aspeed/Kconfig b/drivers/soc/aspeed/Kconfig index c95fa30f1a76..9ce252445605 100644 --- a/drivers/soc/aspeed/Kconfig +++ b/drivers/soc/aspeed/Kconfig @@ -1,32 +1,36 @@ # SPDX-License-Identifier: GPL-2.0-only -menu "Aspeed SoC drivers" -config SOC_ASPEED - def_bool y - depends on ARCH_ASPEED || COMPILE_TEST +if ARCH_ASPEED || COMPILE_TEST + +menu "ASPEED SoC drivers" config ASPEED_LPC_CTRL - depends on SOC_ASPEED && REGMAP && MFD_SYSCON - tristate "Aspeed ast2400/2500 HOST LPC to BMC bridge control" + tristate "ASPEED LPC firmware cycle control" + select REGMAP + select MFD_SYSCON help - Control Aspeed ast2400/2500 HOST LPC to BMC mappings through - ioctl()s, the driver also provides a read/write interface to a BMC ram - region where the host LPC read/write region can be buffered. + Control LPC firmware cycle mappings through ioctl()s. The driver + also provides a read/write interface to a BMC ram region where the + host LPC read/write region can be buffered. config ASPEED_LPC_SNOOP - tristate "Aspeed ast2500 HOST LPC snoop support" - depends on SOC_ASPEED && REGMAP && MFD_SYSCON + tristate "ASPEED LPC snoop support" + select REGMAP + select MFD_SYSCON help Provides a driver to control the LPC snoop interface which allows the BMC to listen on and save the data written by the host to an arbitrary LPC I/O port. config ASPEED_P2A_CTRL - depends on SOC_ASPEED && REGMAP && MFD_SYSCON - tristate "Aspeed ast2400/2500 HOST P2A VGA MMIO to BMC bridge control" + tristate "ASPEED P2A (VGA MMIO to BMC) bridge control" + select REGMAP + select MFD_SYSCON help - Control Aspeed ast2400/2500 HOST P2A VGA MMIO to BMC mappings through - ioctl()s, the driver also provides an interface for userspace mappings to - a pre-defined region. + Control ASPEED P2A VGA MMIO to BMC mappings through ioctl()s. The + driver also provides an interface for userspace mappings to a + pre-defined region. endmenu + +endif