From patchwork Wed Sep 16 16:17:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11780201 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D8910746 for ; Wed, 16 Sep 2020 17:19:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C02082244C for ; Wed, 16 Sep 2020 17:19:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600276780; bh=emKeJfqvDoedmaV7D7ybSVhoskDg33Cwui711fLeBAc=; h=From:To:Cc:Subject:Date:List-ID:From; b=ELb/aZI+bQ4UiLGHJaOhJR+yXtBp6XDmtVdHTYZaFoxJ9MBMUwQRGSqbws4OhfqxF arlULJ23TkyqQ0HbLNT/MzWaoYL8DJor57mMZxkKwZF0tw2aitxRvAbOPIfOVPAiup oW12ICFuuXEtpOmMllOcjhqtcgS+X+9Ti3k0jzSo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726303AbgIPRTh (ORCPT ); Wed, 16 Sep 2020 13:19:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:33728 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbgIPRN6 (ORCPT ); Wed, 16 Sep 2020 13:13:58 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2145722583; Wed, 16 Sep 2020 16:17:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600273068; bh=emKeJfqvDoedmaV7D7ybSVhoskDg33Cwui711fLeBAc=; h=From:To:Cc:Subject:Date:From; b=yMqF+IBxrPF4V/UNukCr3rPJT9I0mnggrGWVW7znhkNMLFXKgAFcU4K3du0FqwdvG 3sDkU4zNmmdOuyEj/s8wNseVmpMuKU8aSj2lJj8f9E2CSMJ+VwBi3ce+d3C77ooOrk OBggc710uJBnD9XqRq252XevLaXDyG3SGB424/Rs= From: Krzysztof Kozlowski To: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , David Lechner , Sekhar Nori , Heiko Stuebner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/6] clk: at91: drop unused at91sam9g45_pcr_layout Date: Wed, 16 Sep 2020 18:17:35 +0200 Message-Id: <20200916161740.14173-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The at91sam9g45_pcr_layout is not used so drop it to fix build warning: drivers/clk/at91/at91sam9g45.c:49:36: warning: 'at91sam9g45_pcr_layout' defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski Acked-by: Alexandre Belloni --- drivers/clk/at91/at91sam9g45.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/clk/at91/at91sam9g45.c b/drivers/clk/at91/at91sam9g45.c index c88ee20bee31..cb4a406ed15d 100644 --- a/drivers/clk/at91/at91sam9g45.c +++ b/drivers/clk/at91/at91sam9g45.c @@ -46,13 +46,6 @@ static const struct { { .n = "pck1", .p = "prog1", .id = 9 }, }; -static const struct clk_pcr_layout at91sam9g45_pcr_layout = { - .offset = 0x10c, - .cmd = BIT(12), - .pid_mask = GENMASK(5, 0), - .div_mask = GENMASK(17, 16), -}; - struct pck { char *n; u8 id; From patchwork Wed Sep 16 16:17:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11780845 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D6E89618 for ; Wed, 16 Sep 2020 20:36:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5D2121D24 for ; Wed, 16 Sep 2020 20:36:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600288576; bh=LN9CdnpYig01xRkC8IS2l0nFAprnIaPmxff2deSsbdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sJz1UyaMaFPhZN74iBNaXZdryOJIU73RhveQGNeVJeaIfLlkxzbC/59wnoLRG2N+9 FhwvRiTg0AdtgkVqx5N2MKzTV5FirLyRs9VTt4jlTFhVdf9ZnX1gtuOyvaZw/WKrRi dcKf23+n/DIqJ+nszh5Pj2ddXzNaQdkqw3UhXOy8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728335AbgIPUgL (ORCPT ); Wed, 16 Sep 2020 16:36:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:60428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726847AbgIPRKa (ORCPT ); Wed, 16 Sep 2020 13:10:30 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9595F227C3; Wed, 16 Sep 2020 16:17:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600273071; bh=LN9CdnpYig01xRkC8IS2l0nFAprnIaPmxff2deSsbdM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=arZO1DSzyRhOIJzlgIdKnCqEdPq/+2oXH63V3zCRjt2uefr7rK8wu2FICE1m/evd4 PlqSMpOP/sMmTTnpdckGd2RTU2CZs6H8hQ2e0xrGUnH+VxSn5fabupSMTnPVjpODK1 n6acg/19rRfvPoRNDQbAwgcoHWP6hRI2xjgG86tg= From: Krzysztof Kozlowski To: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , David Lechner , Sekhar Nori , Heiko Stuebner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/6] clk: fixed: add missing kerneldoc Date: Wed, 16 Sep 2020 18:17:36 +0200 Message-Id: <20200916161740.14173-2-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200916161740.14173-1-krzk@kernel.org> References: <20200916161740.14173-1-krzk@kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Add missing kerneldoc to fix compile warnings like: drivers/clk/clk-fixed-factor.c:211: warning: Function parameter or member 'node' not described in 'of_fixed_factor_clk_setup' Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-fixed-factor.c | 1 + drivers/clk/clk-fixed-rate.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c index 8b343e59dc61..910e6e74ae90 100644 --- a/drivers/clk/clk-fixed-factor.c +++ b/drivers/clk/clk-fixed-factor.c @@ -206,6 +206,7 @@ static struct clk_hw *_of_fixed_factor_clk_setup(struct device_node *node) /** * of_fixed_factor_clk_setup() - Setup function for simple fixed factor clock + * @node: device node for the clock */ void __init of_fixed_factor_clk_setup(struct device_node *node) { diff --git a/drivers/clk/clk-fixed-rate.c b/drivers/clk/clk-fixed-rate.c index 77499a27c8fb..45501637705c 100644 --- a/drivers/clk/clk-fixed-rate.c +++ b/drivers/clk/clk-fixed-rate.c @@ -168,6 +168,7 @@ static struct clk_hw *_of_fixed_clk_setup(struct device_node *node) /** * of_fixed_clk_setup() - Setup function for simple fixed rate clock + * @node: device node for the clock */ void __init of_fixed_clk_setup(struct device_node *node) { From patchwork Wed Sep 16 16:17:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11780169 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D1924746 for ; Wed, 16 Sep 2020 17:16:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B516F22288 for ; Wed, 16 Sep 2020 17:16:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600276560; bh=EHjGZUuZJT8P4Fu0wZHtU4bWPefvl/SobBpWptZnDPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=gw6AneKkPgzXY3SzPOXJS9y9ICeRlFJZF5u+gz9vDB0BYff7DIGlSjMAp32nKUv8Y MlM6bMyumd9cLP3e7e1txs+0Bhsx4aITxJ8eAbG/1Wm08SdrTuGFzC+7AR7Mqg0ruy ScN5BcqbVBwxh5n0mIHKl0V9p9snQnkOKJwQPl34= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbgIPRPD (ORCPT ); Wed, 16 Sep 2020 13:15:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:33712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbgIPRN6 (ORCPT ); Wed, 16 Sep 2020 13:13:58 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2356722838; Wed, 16 Sep 2020 16:17:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600273075; bh=EHjGZUuZJT8P4Fu0wZHtU4bWPefvl/SobBpWptZnDPA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=LD3VU4pDXDvILOHtDKFxURYvXgyTB8ACfXbibwSPYo+xFQOia2LymDneAbApJiQI+ cxMskXpjhQluQQ38YUTirUoMLw+iYwfvr6P2NtTXqT+FcFsXJrGB1IXP4lwyxHTKqy spD0X0DFb9IkH1cUnIo4Nk8zrl19XU+gqpBDxf0A= From: Krzysztof Kozlowski To: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , David Lechner , Sekhar Nori , Heiko Stuebner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 3/6] clk: davinci: add missing kerneldoc Date: Wed, 16 Sep 2020 18:17:37 +0200 Message-Id: <20200916161740.14173-3-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200916161740.14173-1-krzk@kernel.org> References: <20200916161740.14173-1-krzk@kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Add missing kerneldoc to fix compile warning: drivers/clk/davinci/da8xx-cfgchip.c:578: warning: Function parameter or member 'dev' not described in 'da8xx_cfgchip_register_usb1_clk48' Signed-off-by: Krzysztof Kozlowski Reviewed-by: David Lechner --- drivers/clk/davinci/da8xx-cfgchip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/davinci/da8xx-cfgchip.c b/drivers/clk/davinci/da8xx-cfgchip.c index bdc52364b421..77d18276bfe8 100644 --- a/drivers/clk/davinci/da8xx-cfgchip.c +++ b/drivers/clk/davinci/da8xx-cfgchip.c @@ -571,6 +571,7 @@ static const struct clk_ops da8xx_usb1_clk48_ops = { /** * da8xx_cfgchip_register_usb1_clk48 - Register a new USB 1.1 PHY clock + * @dev: The device * @regmap: The CFGCHIP regmap */ static struct da8xx_usb1_clk48 * From patchwork Wed Sep 16 16:17:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11780895 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D000C159A for ; Wed, 16 Sep 2020 20:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF1EE21D7D for ; Wed, 16 Sep 2020 20:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600289325; bh=dSNpGQ0mWKF9wKmXD2Ucm0zykyxGN3p0wNIaxZJV8Io=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=KY3qX3BL4MAtNEtxQGh5urXkOgIBf79EJMgXQ5dtlWFGM8LHMXYHwApQQrB+b+vYV h5zXCjuTd0rKOXW2eKvdSIXTeUwKoBJqBqRvQjGHK6EkZz/ICvF4f8stm35UgdX5I+ d/bJ55RLS4bfdvMsCsUgR5YoRwHdsmVTuYIXTCFU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728462AbgIPUsp (ORCPT ); Wed, 16 Sep 2020 16:48:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:55592 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726691AbgIPRAx (ORCPT ); Wed, 16 Sep 2020 13:00:53 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BAC1F22597; Wed, 16 Sep 2020 16:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600273079; bh=dSNpGQ0mWKF9wKmXD2Ucm0zykyxGN3p0wNIaxZJV8Io=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=viVZyB+wDRwY1ciL2+gA9+KgFhjlpQqg/W9lnYVB4gOk7RbmAAAvaQ27FGmrqlW7/ +I1NXf4LQ0ffvZem9VB5Mv/1cUPkVduhsDrViP689a7qii1kL3VwuxeOOQb1sRqNPp m1gB5VYdy2ohl3tc7TCDiPae8Dxc3vYgU6hDJ19c= From: Krzysztof Kozlowski To: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , David Lechner , Sekhar Nori , Heiko Stuebner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 4/6] clk: mmp: pxa1928: drop unused 'clk' variable Date: Wed, 16 Sep 2020 18:17:38 +0200 Message-Id: <20200916161740.14173-4-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200916161740.14173-1-krzk@kernel.org> References: <20200916161740.14173-1-krzk@kernel.org> MIME-Version: 1.0 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 'clk' is assigned but never read: drivers/clk/mmp/clk-of-pxa1928.c: In function ‘pxa1928_pll_init’: drivers/clk/mmp/clk-of-pxa1928.c:71:14: warning: variable ‘clk’ set but not used [-Wunused-but-set-variable] Signed-off-by: Krzysztof Kozlowski --- drivers/clk/mmp/clk-of-pxa1928.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/clk/mmp/clk-of-pxa1928.c b/drivers/clk/mmp/clk-of-pxa1928.c index cede7b4ca3b9..998fc4207b0e 100644 --- a/drivers/clk/mmp/clk-of-pxa1928.c +++ b/drivers/clk/mmp/clk-of-pxa1928.c @@ -68,7 +68,6 @@ static struct mmp_clk_factor_tbl uart_factor_tbl[] = { static void pxa1928_pll_init(struct pxa1928_clk_unit *pxa_unit) { - struct clk *clk; struct mmp_clk_unit *unit = &pxa_unit->unit; mmp_register_fixed_rate_clks(unit, fixed_rate_clks, @@ -77,7 +76,7 @@ static void pxa1928_pll_init(struct pxa1928_clk_unit *pxa_unit) mmp_register_fixed_factor_clks(unit, fixed_factor_clks, ARRAY_SIZE(fixed_factor_clks)); - clk = mmp_clk_register_factor("uart_pll", "pll1_416", + mmp_clk_register_factor("uart_pll", "pll1_416", CLK_SET_RATE_PARENT, pxa_unit->mpmu_base + MPMU_UART_PLL, &uart_factor_masks, uart_factor_tbl, From patchwork Wed Sep 16 16:17:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11780815 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F41ED618 for ; Wed, 16 Sep 2020 20:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D3D7521D43 for ; Wed, 16 Sep 2020 20:30:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600288224; bh=rDklET3URHRDBZEvF6OLfVutgrEE+P7xngbDw3ovJPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=deq/iTuL8PuB6wJ0gtRd0y8JJu7xw2jly5lnkqfMlvEW/EA4vDybyELCAq0OLuLzE elQacYBnOv6I+CQfIr4rAcGMoOWxdMrBGgwrwgXGklLkyz7igchDdXONlVblDjdwcM UerzW7nQzZwLt/1zOLr1+rE20h8KOScKIGJ1Mqh0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727209AbgIPUaS (ORCPT ); Wed, 16 Sep 2020 16:30:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:33730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726840AbgIPRM6 (ORCPT ); Wed, 16 Sep 2020 13:12:58 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D510222596; Wed, 16 Sep 2020 16:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600273084; bh=rDklET3URHRDBZEvF6OLfVutgrEE+P7xngbDw3ovJPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c2qzRyizp/VEct8ssgms7hbJXVwjVImM85Q7xFsmmmORaJJoUfwUgoBGEFqi0by2T G5IZj2iDxNypoGC+dc+C7hgmzL2KBMi2fi4175i+oyaRfPHYbrPLSGxuuLOR8gaieR ArI/ZIcqrnWAWOtZotaHfvbhZ+dh7bfZdpN9lSwo= From: Krzysztof Kozlowski To: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , David Lechner , Sekhar Nori , Heiko Stuebner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 5/6] clk: si5341: drop unused 'err' variable Date: Wed, 16 Sep 2020 18:17:39 +0200 Message-Id: <20200916161740.14173-5-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200916161740.14173-1-krzk@kernel.org> References: <20200916161740.14173-1-krzk@kernel.org> MIME-Version: 1.0 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org 'err' is assigned but never read: /drivers/clk/clk-si5341.c: In function ‘si5341_output_get_parent’: drivers/clk/clk-si5341.c:886:6: warning: variable ‘err’ set but not used [-Wunused-but-set-variable] Signed-off-by: Krzysztof Kozlowski --- drivers/clk/clk-si5341.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/clk-si5341.c b/drivers/clk/clk-si5341.c index 3d7acab9d280..e0446e66fa64 100644 --- a/drivers/clk/clk-si5341.c +++ b/drivers/clk/clk-si5341.c @@ -883,11 +883,9 @@ static int si5341_output_set_parent(struct clk_hw *hw, u8 index) static u8 si5341_output_get_parent(struct clk_hw *hw) { struct clk_si5341_output *output = to_clk_si5341_output(hw); - int err; u32 val; - err = regmap_read(output->data->regmap, - SI5341_OUT_MUX_SEL(output), &val); + regmap_read(output->data->regmap, SI5341_OUT_MUX_SEL(output), &val); return val & 0x7; } From patchwork Wed Sep 16 16:17:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11780111 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DF06792C for ; Wed, 16 Sep 2020 16:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA77622275 for ; Wed, 16 Sep 2020 16:26:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600273608; bh=d96KYZZMydcJHEl9ntD8CVmSDdqIiH31PsoEq+mfyUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DqFLEXTqXecL26GfTPT2eRN27BsZFA72gjtUEZJOM/Qny/tGmOH8HDWMsI2JU/1rw biWDj91GBQ4GaB4bOMD+rKConjSnSYHMG9UFE8m/PKBxAZ2MMjEjYoY5bROCnjCRvz bqpKO+FC8L4wchP+UP+3nGbvwGgUqVbexAx+N1i8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726260AbgIPQ0U (ORCPT ); Wed, 16 Sep 2020 12:26:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:38640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726566AbgIPQT5 (ORCPT ); Wed, 16 Sep 2020 12:19:57 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.191]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7B30122955; Wed, 16 Sep 2020 16:18:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600273093; bh=d96KYZZMydcJHEl9ntD8CVmSDdqIiH31PsoEq+mfyUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uad7FDK4a+Ne5IYmZfeU+1YD99kDHHrIlZutKKrYvUTLFZmBTRwlLmBx02L+gdKmT MTXHEXjysUHsNp9b6pr/mXmJg4XB4MRZhGPeFw02cwXudkz35qpubMtJJ9zQtzjhi9 45bZmPAi3H4zojr6wkUQO4eJoHTiNA7QT5KWRctY= From: Krzysztof Kozlowski To: Michael Turquette , Stephen Boyd , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , David Lechner , Sekhar Nori , Heiko Stuebner , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 6/6] clk: rockchip: rk3308: drop unused mux_timer_src_p Date: Wed, 16 Sep 2020 18:17:40 +0200 Message-Id: <20200916161740.14173-6-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200916161740.14173-1-krzk@kernel.org> References: <20200916161740.14173-1-krzk@kernel.org> MIME-Version: 1.0 Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org The parent names 'mux_timer_src_p' is not used: In file included from drivers/clk/rockchip/clk-rk3308.c:13:0: drivers/clk/rockchip/clk-rk3308.c:136:7: warning: ‘mux_timer_src_p’ defined but not used [-Wunused-const-variable=] Signed-off-by: Krzysztof Kozlowski --- drivers/clk/rockchip/clk-rk3308.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/clk/rockchip/clk-rk3308.c b/drivers/clk/rockchip/clk-rk3308.c index b0baf87a283e..5bf15f2a44b7 100644 --- a/drivers/clk/rockchip/clk-rk3308.c +++ b/drivers/clk/rockchip/clk-rk3308.c @@ -133,7 +133,6 @@ PNAME(mux_uart1_p) = { "clk_uart1_src", "dummy", "clk_uart1_frac" }; PNAME(mux_uart2_p) = { "clk_uart2_src", "dummy", "clk_uart2_frac" }; PNAME(mux_uart3_p) = { "clk_uart3_src", "dummy", "clk_uart3_frac" }; PNAME(mux_uart4_p) = { "clk_uart4_src", "dummy", "clk_uart4_frac" }; -PNAME(mux_timer_src_p) = { "xin24m", "clk_rtc32k" }; PNAME(mux_dclk_vop_p) = { "dclk_vop_src", "dclk_vop_frac", "xin24m" }; PNAME(mux_nandc_p) = { "clk_nandc_div", "clk_nandc_div50" }; PNAME(mux_sdmmc_p) = { "clk_sdmmc_div", "clk_sdmmc_div50" };