From patchwork Thu Sep 17 04:28:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chandan Babu R X-Patchwork-Id: 11781527 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C0A4C618 for ; Thu, 17 Sep 2020 04:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3E452078D for ; Thu, 17 Sep 2020 04:29:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a+/2XzTs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726055AbgIQE3C (ORCPT ); Thu, 17 Sep 2020 00:29:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgIQE3B (ORCPT ); Thu, 17 Sep 2020 00:29:01 -0400 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1504C06174A; Wed, 16 Sep 2020 21:29:00 -0700 (PDT) Received: by mail-pg1-x542.google.com with SMTP id 7so591119pgm.11; Wed, 16 Sep 2020 21:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u9DWVWkszMPKfRkULRly7P6KDkkzxbhQNqxsXCnDa3Q=; b=a+/2XzTsFii166iqcEbXCmmMLxa+cbpoGYboBGexCY/0RQV0KAcx2j49iesL11YoTf RZJrP86z/CAiKHDjEKynOvh57ECDzDLYwWjgr2QbldtVHEf0VN6MQBvfYZF701IhK76e DqGNSEPM5j+xqT2OMEjw1N7ElG4CFQtABbydugiDNcGKlthrZaBiy9l9n7DSZANO0+/L S6ilWEequg2tQyFu19EBrmwA3mDL42vSSCnDgV3RFOlHuuPASeVLLmNwRFX91bnT9Klj vv5i9YdkQwn8OHuvS1nKln4ze90mVLc9yfU+w8Xo3Tf6G/FAc8VkQhLu+snXiHsZEghW SKWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=u9DWVWkszMPKfRkULRly7P6KDkkzxbhQNqxsXCnDa3Q=; b=jSpT/Nlh947szLWQZ1F2P7e97eX7M3N3nCphWVLTwB7/ItYDSENpPRyAtm70AhaANN CS5WA0abI2r/ZEg5siJakehZ3vxsT7U3mJFvmmn0dr21MsIc2o5jJbh1iZig9HgkqJuy Zm4ZHTS/YEL7Au+ruiND8FYS7TjVA5RdXAwLgI6hCUDbV8oRqq6wtLD5bFW5yT/AKvfy jLg3Fx6humRF28WaebbldqJ1+z9MvL1TRTP/L4WLzV7VMhh0Haj1pMkgBzsC9pwd8fDB 1x4uwnh6YiPcP7CRPNpijFEtHZxqPcxPAlF0aU3fD07uEJKSZkUof+UrpjFuJcdYGqS2 jqeg== X-Gm-Message-State: AOAM532rfxeAj9sthdSgWXH8lRJP/IY14ZCakfsxGYOWqu10cj90CtUF dFxyVTqlX4ol/UVuTVUsnVX3fW3ovtE= X-Google-Smtp-Source: ABdhPJwWVwa8LljcG7yjG3Z59u/+wE/f93Ie+/7cUVLa+7MAGD+pTZJa/tqKe5rn014cK2w6Vts7VA== X-Received: by 2002:aa7:84c5:0:b029:13f:ed60:b20b with SMTP id x5-20020aa784c50000b029013fed60b20bmr15672039pfn.26.1600316940070; Wed, 16 Sep 2020 21:29:00 -0700 (PDT) Received: from localhost.localdomain ([122.179.62.198]) by smtp.gmail.com with ESMTPSA id 31sm15955885pgs.59.2020.09.16.21.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 21:28:59 -0700 (PDT) From: Chandan Babu R To: fstests@vger.kernel.org Cc: Chandan Babu R , linux-xfs@vger.kernel.org, guaneryu@gmail.com, darrick.wong@oracle.com, zlang@redhat.com Subject: [PATCH 1/2] xfs: Add realtime group Date: Thu, 17 Sep 2020 09:58:43 +0530 Message-Id: <20200917042844.6063-1-chandanrlinux@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org This commit adds a new group to classify tests that can work with realtime devices. Signed-off-by: Chandan Babu R --- tests/xfs/group | 50 ++++++++++++++++++++++++------------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/tests/xfs/group b/tests/xfs/group index ed0d389e..b99ca082 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -87,11 +87,11 @@ 087 fuzzers 088 fuzzers 089 fuzzers -090 rw auto +090 rw auto realtime 091 fuzzers 092 other auto quick 093 fuzzers -094 metadata dir ioctl auto +094 metadata dir ioctl auto realtime 095 log v2log auto 096 mkfs v2log auto quick 097 fuzzers @@ -119,7 +119,7 @@ 119 log v2log auto freeze 120 fuzzers 121 shutdown log auto quick -122 other auto quick clone +122 other auto quick clone realtime 123 fuzzers 124 fuzzers 125 fuzzers @@ -128,7 +128,7 @@ 128 auto quick clone fsr 129 auto quick clone 130 fuzzers clone -131 auto quick clone +131 auto quick clone realtime 132 auto quick 133 dangerous_fuzzers 134 dangerous_fuzzers @@ -188,7 +188,7 @@ 188 ci dir auto 189 mount auto quick 190 rw auto quick -191-input-validation auto quick mkfs +191-input-validation auto quick mkfs realtime 192 auto quick clone 193 auto quick clone 194 rw auto @@ -272,7 +272,7 @@ 273 auto rmap fsmap 274 auto quick rmap fsmap 275 auto quick rmap fsmap -276 auto quick rmap fsmap +276 auto quick rmap fsmap realtime 277 auto quick rmap fsmap 278 repair auto 279 auto mkfs @@ -287,7 +287,7 @@ 288 auto quick repair fuzzers 289 growfs auto quick 290 auto rw prealloc quick ioctl zero -291 auto repair +291 auto repair realtime 292 auto mkfs quick 293 auto quick 294 auto dir metadata @@ -329,17 +329,17 @@ 330 auto quick clone fsr quota 331 auto quick rmap clone 332 auto quick rmap clone collapse punch insert zero -333 auto quick rmap -334 auto quick rmap -335 auto rmap -336 auto rmap -337 fuzzers rmap -338 auto quick rmap -339 auto quick rmap -340 auto quick rmap -341 auto quick rmap -342 auto quick rmap -343 auto quick rmap collapse punch insert zero +333 auto quick rmap realtime +334 auto quick rmap realtime +335 auto rmap realtime +336 auto rmap realtime +337 fuzzers rmap realtime +338 auto quick rmap realtime +339 auto quick rmap realtime +340 auto quick rmap realtime +341 auto quick rmap realtime +342 auto quick rmap realtime +343 auto quick rmap collapse punch insert zero realtime 344 auto quick clone 345 auto quick clone 346 auto quick clone @@ -402,10 +402,10 @@ 403 dangerous_fuzzers dangerous_scrub dangerous_online_repair 404 dangerous_fuzzers dangerous_scrub dangerous_repair 405 dangerous_fuzzers dangerous_scrub dangerous_online_repair -406 dangerous_fuzzers dangerous_scrub dangerous_repair -407 dangerous_fuzzers dangerous_scrub dangerous_online_repair -408 dangerous_fuzzers dangerous_scrub dangerous_repair -409 dangerous_fuzzers dangerous_scrub dangerous_online_repair +406 dangerous_fuzzers dangerous_scrub dangerous_repair realtime +407 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime +408 dangerous_fuzzers dangerous_scrub dangerous_repair realtime +409 dangerous_fuzzers dangerous_scrub dangerous_online_repair realtime 410 dangerous_fuzzers dangerous_scrub dangerous_repair 411 dangerous_fuzzers dangerous_scrub dangerous_online_repair 412 dangerous_fuzzers dangerous_scrub dangerous_repair @@ -415,7 +415,7 @@ 416 dangerous_fuzzers dangerous_scrub dangerous_repair 417 dangerous_fuzzers dangerous_scrub dangerous_online_repair 418 dangerous_fuzzers dangerous_scrub dangerous_repair -419 auto quick swap +419 auto quick swap realtime 420 auto quick clone punch seek 421 auto quick clone punch seek 422 dangerous_scrub dangerous_online_repair @@ -477,8 +477,8 @@ 478 dangerous_fuzzers dangerous_norepair 479 dangerous_fuzzers dangerous_norepair 480 dangerous_fuzzers dangerous_norepair -481 dangerous_fuzzers dangerous_norepair -482 dangerous_fuzzers dangerous_norepair +481 dangerous_fuzzers dangerous_norepair realtime +482 dangerous_fuzzers dangerous_norepair realtime 483 dangerous_fuzzers dangerous_norepair 484 dangerous_fuzzers dangerous_norepair 485 dangerous_fuzzers dangerous_norepair From patchwork Thu Sep 17 04:28:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chandan Babu R X-Patchwork-Id: 11781531 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4AA6A618 for ; Thu, 17 Sep 2020 04:29:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E3DD2075E for ; Thu, 17 Sep 2020 04:29:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="iKZWVy8x" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726064AbgIQE3F (ORCPT ); Thu, 17 Sep 2020 00:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgIQE3E (ORCPT ); Thu, 17 Sep 2020 00:29:04 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A92B0C06174A; Wed, 16 Sep 2020 21:29:03 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id k15so394709pfc.12; Wed, 16 Sep 2020 21:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=jD8gSJmistFf9e3EQDv95ZefwiEeTYsknPGCQzRzg6g=; b=iKZWVy8xdp9RuT0SIbbUNgQ/wk6ilZrqRRUhVnNI5QyFBVSBDgqYecUKZjQQUvKUQl 1RBpPF+7oKUWxKjzAbUUnoimA2biKIoz3WfUPO0HDgFyyMcqm2bS4s2z+G92z5GnwGMN SQMih/uEKZD4Fto950O99Wnjgnw48vwbYvthXIMcgvF3XEHqceLWomeTxZ57/rkqwnci +t0KMFcqUv1Ljpgc6v2Uu0/XbfT/wFWFzvkZw01fwJVeU0xbb+dWvzauXyasRlamFiph o6ikb3tytc5IaKC0SrIPAsJfJbCu+v3Ngaq9KJxjluK+5D+jXIqJ87q8rMmaYW7gT5YK MO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=jD8gSJmistFf9e3EQDv95ZefwiEeTYsknPGCQzRzg6g=; b=mv2qzdMx6fVQz7akAnGQfuNu1SIYcbaPwdQ1+ewCuSKy5YSwGvqgC/ODJBGXuBMqhE CKXp8kRVy3kPRIA22U3oG280+G+5MP4ZOqJ+1o7tHCsPZjhiB/6uuv5vLK5zpKvbAQ1C GM2NyRPwEaj/8TKYWMMK91U4leVmdQS+D26jr1AG7M8R8JYcf6jr8403dlckUItzD6YI 4nNvsZOaVdwQ2lmVe0JDy4yFR8NQuisZFWAExWLYW69j2Wj5IMIwEflmix2aLzehUsQB LwFWLYZ3bnekXQWyXmt85RQXdXgFMK4F+Egdo+F82pdBX+r00OJ+iy4GI46AFzVYAKFh DATw== X-Gm-Message-State: AOAM532LSOLTmBPR/AYjZ257fnjJ7/wfCGP02tLphma/3948c+xPc5CT Jgpzvp5Dz4KMiSATQ86WLDhIRfwkVXE= X-Google-Smtp-Source: ABdhPJwFKkMIyR4a7+OpA8i9TmP9CWVUeBQvWId6d3nL7qgH7eTfzL75qTuEMmVtFTFBJ74lu23IjA== X-Received: by 2002:aa7:82ce:0:b029:142:2501:35cb with SMTP id f14-20020aa782ce0000b0290142250135cbmr9505824pfn.43.1600316942913; Wed, 16 Sep 2020 21:29:02 -0700 (PDT) Received: from localhost.localdomain ([122.179.62.198]) by smtp.gmail.com with ESMTPSA id 31sm15955885pgs.59.2020.09.16.21.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 21:29:02 -0700 (PDT) From: Chandan Babu R To: fstests@vger.kernel.org Cc: Chandan Babu R , linux-xfs@vger.kernel.org, guaneryu@gmail.com, darrick.wong@oracle.com, zlang@redhat.com Subject: [PATCH 2/2] xfs: Check if rt summary/bitmap buffers are logged with correct xfs_buf type Date: Thu, 17 Sep 2020 09:58:44 +0530 Message-Id: <20200917042844.6063-2-chandanrlinux@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200917042844.6063-1-chandanrlinux@gmail.com> References: <20200917042844.6063-1-chandanrlinux@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org This commit adds a test to check if growing a real-time device can end up logging an xfs_buf with the "type" subfield of bip->bli_formats->blf_flags set to XFS_BLFT_UNKNOWN_BUF. When this occurs the following call trace is printed on the console, XFS: Assertion failed: (bip->bli_flags & XFS_BLI_STALE) || (xfs_blft_from_flags(&bip->__bli_format) > XFS_BLFT_UNKNOWN_BUF && xfs_blft_from_flags(&bip->__bli_format) < XFS_BLFT_MAX_BUF), file: fs/xfs/xfs_buf_item.c, line: 331 Call Trace: xfs_buf_item_format+0x632/0x680 ? kmem_alloc_large+0x29/0x90 ? kmem_alloc+0x70/0x120 ? xfs_log_commit_cil+0x132/0x940 xfs_log_commit_cil+0x26f/0x940 ? xfs_buf_item_init+0x1ad/0x240 ? xfs_growfs_rt_alloc+0x1fc/0x280 __xfs_trans_commit+0xac/0x370 xfs_growfs_rt_alloc+0x1fc/0x280 xfs_growfs_rt+0x1a0/0x5e0 xfs_file_ioctl+0x3fd/0xc70 ? selinux_file_ioctl+0x174/0x220 ksys_ioctl+0x87/0xc0 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x3e/0x70 entry_SYSCALL_64_after_hwframe+0x44/0xa9 The kernel patch "xfs: Set xfs_buf type flag when growing summary/bitmap files" is required to fix this issue. Reviewed-by: Zorro Lang Signed-off-by: Chandan Babu R Reviewed-by: Darrick J. Wong --- tests/xfs/260 | 51 +++++++++++++++++++++++++++++++++++++++++++++++ tests/xfs/260.out | 2 ++ tests/xfs/group | 1 + 3 files changed, 54 insertions(+) create mode 100755 tests/xfs/260 create mode 100644 tests/xfs/260.out diff --git a/tests/xfs/260 b/tests/xfs/260 new file mode 100755 index 00000000..1cafa368 --- /dev/null +++ b/tests/xfs/260 @@ -0,0 +1,51 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Chandan Babu R. All Rights Reserved. +# +# FS QA Test 260 +# +# Test to check if growing a real-time device can end up logging an xfs_buf with +# the "type" subfield of bip->bli_formats->blf_flags set to +# XFS_BLFT_UNKNOWN_BUF. +# +# This is a regression test for the kernel patch "xfs: Set xfs_buf type flag +# when growing summary/bitmap files". + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs xfs +_supported_os Linux +_require_realtime + +_scratch_mkfs -r size=10M >> $seqres.full + +_scratch_mount >> $seqres.full + +$XFS_GROWFS_PROG $SCRATCH_MNT >> $seqres.full + +echo "Silence is golden" + +# success, all done +status=0 +exit diff --git a/tests/xfs/260.out b/tests/xfs/260.out new file mode 100644 index 00000000..18ca517c --- /dev/null +++ b/tests/xfs/260.out @@ -0,0 +1,2 @@ +QA output created by 260 +Silence is golden diff --git a/tests/xfs/group b/tests/xfs/group index b99ca082..d6d4425d 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -257,6 +257,7 @@ 257 auto quick clone 258 auto quick clone 259 auto quick +260 auto quick growfs realtime 261 auto quick quota 262 dangerous_fuzzers dangerous_scrub dangerous_online_repair 263 auto quick quota