From patchwork Thu Sep 17 09:48:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Christian_K=C3=B6nig?= X-Patchwork-Id: 11782077 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D65AA618 for ; Thu, 17 Sep 2020 09:48:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABEF220838 for ; Thu, 17 Sep 2020 09:48:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JCXzCne2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABEF220838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 960496E118; Thu, 17 Sep 2020 09:48:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C5256E118 for ; Thu, 17 Sep 2020 09:48:40 +0000 (UTC) Received: by mail-ej1-x630.google.com with SMTP id r7so2329938ejs.11 for ; Thu, 17 Sep 2020 02:48:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=CHA5WFKJcj6oIvoLyKMYsWjBZKrS/Y/yi68IlTiVbDo=; b=JCXzCne2bESiTr1BzjhsG4MKSjk+kkTjdzaCRMBx6eZttwa4JHYCrvkHxEx3BzTbjV YDuwXhKyeP8tys44H3/YGkBO469ygNMhLPpagBp3xP5Jyqn/evRX/elbmE+enPBap3ki EuulmqH56PsJe1apK682zadGH6O0TkdwuU0C5/Ru4YnK1S5EwXtoMEslLu5PWhE8eeXy h5T7vWEphTfrcWGtddmTv0qZvOrs0COIp/ecVV5HVeWlIio+9w5y25POrR7P1kSYewWz WqyZ26UzOrPjseq7mBcp8beK9F6ZamBYgnw6kEgL0b3rkPSvtzAu3ekrg09ZRUwsw1Xn fgkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=CHA5WFKJcj6oIvoLyKMYsWjBZKrS/Y/yi68IlTiVbDo=; b=em4VTd8wG8bVzdjt5VE5/CWgkVeAnztv0lci3tOlG429r5I1yAojx4gcT2aGcEAK3q aIx0b3ilUglQbmJeqXt+Mfop7/FuOaoJT7wrCh//jG64lL/Jdw8QhJjfWHItq5Zy64yd XC9y08F95+XXC8eUhbmqQtJbvzu/Ps2A05GgMnPPsq4nUz9YLef751kNOCFlX6qpqTZw ocKG4/rO1Aud8pLOrHOXgLU8tRKcfWeyYxv9OExE4ezNfL3keNTAbKYOyEodWVG+MN3c VnXEqVPLdslEySeiTMO75DtrzHlamQPSPv22fd6oQDSDEyNxHl8DWwb4LwB8BA7USQnz B+xQ== X-Gm-Message-State: AOAM531mYg381b08XrUdCX+QHd9eoXdbJk9iC2ZKBk5mON6q39a19sE+ a39LD7+1C1ZDVPLkF8yWWh25Qwds5Bg= X-Google-Smtp-Source: ABdhPJx0QaYniBs3q5BHiJsEr+/7QMU3cOVXngf/qSVUUaF4w1i9y3LKdvIUhHmxhyIXAbnTJjTPbg== X-Received: by 2002:a17:906:4cc7:: with SMTP id q7mr30286471ejt.437.1600336118592; Thu, 17 Sep 2020 02:48:38 -0700 (PDT) Received: from abel.fritz.box ([2a02:908:1252:fb60:2734:61f1:4615:35cf]) by smtp.gmail.com with ESMTPSA id d13sm16033447edu.54.2020.09.17.02.48.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Sep 2020 02:48:37 -0700 (PDT) From: " =?utf-8?q?Christian_K=C3=B6nig?= " X-Google-Original-From: =?utf-8?q?Christian_K=C3=B6nig?= To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm/ttm: remove superflous extern attribute from funcs Date: Thu, 17 Sep 2020 11:48:37 +0200 Message-Id: <20200917094837.2787-1-christian.koenig@amd.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Extern is the default attribute for functions anyway. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- include/drm/ttm/ttm_execbuf_util.h | 19 ++++++++----------- include/drm/ttm/ttm_memory.h | 25 ++++++++++++------------- 2 files changed, 20 insertions(+), 24 deletions(-) diff --git a/include/drm/ttm/ttm_execbuf_util.h b/include/drm/ttm/ttm_execbuf_util.h index 5a19843bb80d..a99d7fdf2964 100644 --- a/include/drm/ttm/ttm_execbuf_util.h +++ b/include/drm/ttm/ttm_execbuf_util.h @@ -58,9 +58,8 @@ struct ttm_validate_buffer { * Undoes all buffer validation reservations for bos pointed to by * the list entries. */ - -extern void ttm_eu_backoff_reservation(struct ww_acquire_ctx *ticket, - struct list_head *list); +void ttm_eu_backoff_reservation(struct ww_acquire_ctx *ticket, + struct list_head *list); /** * function ttm_eu_reserve_buffers @@ -96,10 +95,9 @@ extern void ttm_eu_backoff_reservation(struct ww_acquire_ctx *ticket, * ttm_eu_fence_buffer_objects() when command submission is complete or * has failed. */ - -extern int ttm_eu_reserve_buffers(struct ww_acquire_ctx *ticket, - struct list_head *list, bool intr, - struct list_head *dups); +int ttm_eu_reserve_buffers(struct ww_acquire_ctx *ticket, + struct list_head *list, bool intr, + struct list_head *dups); /** * function ttm_eu_fence_buffer_objects. @@ -113,9 +111,8 @@ extern int ttm_eu_reserve_buffers(struct ww_acquire_ctx *ticket, * It also unreserves all buffers, putting them on lru lists. * */ - -extern void ttm_eu_fence_buffer_objects(struct ww_acquire_ctx *ticket, - struct list_head *list, - struct dma_fence *fence); +void ttm_eu_fence_buffer_objects(struct ww_acquire_ctx *ticket, + struct list_head *list, + struct dma_fence *fence); #endif diff --git a/include/drm/ttm/ttm_memory.h b/include/drm/ttm/ttm_memory.h index 2d468d7c94e6..c1f167881e33 100644 --- a/include/drm/ttm/ttm_memory.h +++ b/include/drm/ttm/ttm_memory.h @@ -79,18 +79,17 @@ extern struct ttm_mem_global { #endif } ttm_mem_glob; -extern int ttm_mem_global_init(struct ttm_mem_global *glob); -extern void ttm_mem_global_release(struct ttm_mem_global *glob); -extern int ttm_mem_global_alloc(struct ttm_mem_global *glob, uint64_t memory, +int ttm_mem_global_init(struct ttm_mem_global *glob); +void ttm_mem_global_release(struct ttm_mem_global *glob); +int ttm_mem_global_alloc(struct ttm_mem_global *glob, uint64_t memory, + struct ttm_operation_ctx *ctx); +void ttm_mem_global_free(struct ttm_mem_global *glob, uint64_t amount); +int ttm_mem_global_alloc_page(struct ttm_mem_global *glob, + struct page *page, uint64_t size, + struct ttm_operation_ctx *ctx); +void ttm_mem_global_free_page(struct ttm_mem_global *glob, + struct page *page, uint64_t size); +size_t ttm_round_pot(size_t size); +bool ttm_check_under_lowerlimit(struct ttm_mem_global *glob, uint64_t num_pages, struct ttm_operation_ctx *ctx); -extern void ttm_mem_global_free(struct ttm_mem_global *glob, - uint64_t amount); -extern int ttm_mem_global_alloc_page(struct ttm_mem_global *glob, - struct page *page, uint64_t size, - struct ttm_operation_ctx *ctx); -extern void ttm_mem_global_free_page(struct ttm_mem_global *glob, - struct page *page, uint64_t size); -extern size_t ttm_round_pot(size_t size); -extern bool ttm_check_under_lowerlimit(struct ttm_mem_global *glob, - uint64_t num_pages, struct ttm_operation_ctx *ctx); #endif