From patchwork Fri Oct 26 16:19:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 10657675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88AA45A4 for ; Fri, 26 Oct 2018 16:32:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7E6E12CB2E for ; Fri, 26 Oct 2018 16:32:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7C1312CB52; Fri, 26 Oct 2018 16:32:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BF8082CB2E for ; Fri, 26 Oct 2018 16:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2guy5em0Z3pxYS2i+FzR8lrWONLvI9rbhyK2Bfwq1UQ=; b=RNcNASLc/kSmT0 LE66zRM54586GZ8ykrX2tmClZgmFfC+nNi2xDa1tAvZ0X8uD5jQWeTsPelYB/g5MpgP8I4OtdWQvs jklPWur4jiYT+WzN5VLWskE2HIxcdsCT5w8serJ7TTg630bzEqBhnumVIL4Z5151ofBwTpycMmAfE DR4IZhk0JGen4Fjo8AuRJGxjpKUAz6VLCbfbhJ9HYkwkNXw6peAXeTNboL4BKCmCQYPGCHeDGhRP9 Rm2dlx5vXXNCLWgSjRQL33WwgJnw8EnjNAJ3WDs2wtPz8G9sU2ESzW1VQNzKPrICdEUPrE4Q36im6 xvPMktygCvO0gQSCh9CQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG51m-0004HG-7o; Fri, 26 Oct 2018 16:32:02 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG4qB-0006uI-Tk for linux-arm-kernel@lists.infradead.org; Fri, 26 Oct 2018 16:20:13 +0000 X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="20187339" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 26 Oct 2018 09:19:52 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.38) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 26 Oct 2018 09:19:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tvqjjW+uLz5CMP2p/3h+xplp/7O3+Qo56tXuAOxdoCQ=; b=bC5sA6qFByNU4jpuRSbDsmT2YOS2IE3AyHdFGjr0+JRGRI0yHmnF/mlRHCa/tensbRTvA5GJPuhSuv3UQxRW4GOc1RiHymCiN1cEiwmRsAGO4edKxo9lk3nR5JRu1/ep7H8J76E0/6pSAXW+BClpqDsVGeOk7W4bDjtR9w0B+/g= Received: from BY2PR11MB0744.namprd11.prod.outlook.com (10.163.112.142) by BY2PR11MB0792.namprd11.prod.outlook.com (10.163.112.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.18; Fri, 26 Oct 2018 16:19:48 +0000 Received: from BY2PR11MB0744.namprd11.prod.outlook.com ([fe80::d0a5:29e0:506a:76a8]) by BY2PR11MB0744.namprd11.prod.outlook.com ([fe80::d0a5:29e0:506a:76a8%7]) with mapi id 15.20.1273.021; Fri, 26 Oct 2018 16:19:48 +0000 From: To: , , , , , Subject: [PATCH 1/2] regulator: act8945: Implement PM functionalities Thread-Topic: [PATCH 1/2] regulator: act8945: Implement PM functionalities Thread-Index: AQHUbUe3aB7PxIHxB0GWg8NpuJvvnA== Date: Fri, 26 Oct 2018 16:19:48 +0000 Message-ID: <1540570753-16370-2-git-send-email-claudiu.beznea@microchip.com> References: <1540570753-16370-1-git-send-email-claudiu.beznea@microchip.com> In-Reply-To: <1540570753-16370-1-git-send-email-claudiu.beznea@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1P195CA0095.EURP195.PROD.OUTLOOK.COM (2603:10a6:802:59::48) To BY2PR11MB0744.namprd11.prod.outlook.com (2a01:111:e400:52de::14) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Claudiu.Beznea@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BY2PR11MB0792; 6:EUlFOEiDfZzwgg8koXmzBqs7eDJVYTit9zcPCwXHIhbw55WSboyN4+ZnAeCvUevpnjSnoGA9SS05MtSdVdiLoF/N208oJx8LIOSN7fJJSvI5n1pBx6oZvtLTzVYhas/9qcBFBG88Ugt2w7D6vN0cWNSB88auc17+8OFTN5XuEveMLAAovc5hpDXl/qIgBSII+Re/EAxtymswnPzwPy+wljmiHmxyW8l2TdiA+ECPf6Cjt+xnT9kwQGiyYr+mIuNTP4aqxYBsfyQbT1kDoEHNFR7n2LE3VAKkJFP/zB3djAOYSnDIPujs8M285cU6zH9uh8d7SeHcoJZk75MXsWMa+EcWI3Yp/CYaZvSTTfij90ODv/MlTYgLO/LFObnKUy7lo2uH8u3xX8HXtkpHc8ullZjXxaOvk3egn+EeMFAY7MRu3VIPPYNq1vxRZxaJn3Ydqkj6OFs8AjS2ylw237paRg==; 5:A4sHFviSxG9AdG0OV2WHFxQgzdQIyguZ3N3vQTho7giYbapa1SEusBugppitY4czqX2c4BddiQ1boC6jDkb7JSOTcIgCsJzt2Xngw3tm9pPs9sr7iaIs87ZPeSRNw3PomvFvKtVo5RHKeX9QAwYnlE1/4QyYkKma5iHwpD6R8xE=; 7:K04bBvyW9vCZheGodOxm1mrmSnq7DfeJi5pLZVs8hxHLSuHy8S9jNLbtevLOK9G5xLpzbdq0YtXr2QL/4qZRO4TGMdQxldGSrJtJMLdmF8CF20qSmxqThvJ3h9kdaYcxLLt71UBhnJU6beYG6ro/ag== x-ms-office365-filtering-correlation-id: 201a4e47-c29a-48a1-5db8-08d63b5ed98a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BY2PR11MB0792; x-ms-traffictypediagnostic: BY2PR11MB0792: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231355)(944501410)(52105095)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:BY2PR11MB0792; BCL:0; PCL:0; RULEID:; SRVR:BY2PR11MB0792; x-forefront-prvs: 083751FCA6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(136003)(39840400004)(199004)(189003)(52116002)(256004)(2501003)(11346002)(76176011)(6486002)(99286004)(66066001)(3846002)(105586002)(81156014)(6116002)(71190400001)(25786009)(107886003)(8676002)(39060400002)(7736002)(305945005)(2616005)(476003)(446003)(68736007)(4326008)(5660300001)(36756003)(478600001)(2906002)(5250100002)(110136005)(54906003)(2900100001)(53936002)(14454004)(575784001)(72206003)(316002)(26005)(81166006)(6512007)(386003)(6506007)(86362001)(106356001)(186003)(71200400001)(14444005)(486006)(8936002)(6436002)(102836004)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR11MB0792; H:BY2PR11MB0744.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: sMYxXWTmwhRpHE5G/YwpdopmN1vrYk7pISa/npuN1Awf9MfbAu6JBqeFimw/zWAVB1pPGsEk14mUMcA4Z2QyCOibGohQDvzvKAMTrmcK0LgbXyzJyns0Msh7avyfL5Kg6/Ph8gylVZbwZIYW2BN9U3OpbxTW9YmlwaE5hhGxc3IlISBB/+K6wzx3O0neEzj6lKfC2MkQgAdKRRohutZfWAUzCYuyWQRF+dnTuhlIuXOVycoOqyHaDCHPDtMCRb0XrW5huIKgjjgGrUe/jJAix1P+yPRVg5GQpkYvpinPDb4ziqYrcO4r3RAyqBSwToNonJaQkaU9dkgoW+HiKvdYzp4n12LskADdD5xFiW4qyUQ= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 201a4e47-c29a-48a1-5db8-08d63b5ed98a X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2018 16:19:48.6025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0792 X-OriginatorOrg: microchip.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181026_092004_156633_27FD5552 X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Claudiu.Beznea@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, boris.brezillon@bootlin.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Boris Brezillon The regulator supports a dedicated suspend mode. Implement the appropriate ->set_suspend_xx() hooks, add support for ->set_mode(), and provide basic PM ops functionalities to setup the regulator in a suspend state when the system is entering suspend. We also implement the ->shutdown() method to make sure the PMIC will not enter the suspend state when the system is shutdown. Signed-off-by: Boris Brezillon [claudiu.beznea@microchip.com: remove dev_pm_ops, fix checkpatch warking, adapt commit message] Signed-off-by: Claudiu Beznea --- drivers/regulator/act8945a-regulator.c | 195 ++++++++++++++++++++++++++++++++- 1 file changed, 193 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/act8945a-regulator.c b/drivers/regulator/act8945a-regulator.c index 43fda8b4455a..41bf7d224abb 100644 --- a/drivers/regulator/act8945a-regulator.c +++ b/drivers/regulator/act8945a-regulator.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -23,23 +24,36 @@ */ #define ACT8945A_SYS_MODE 0x00 #define ACT8945A_SYS_CTRL 0x01 +#define ACT8945A_SYS_UNLK_REGS 0x0b #define ACT8945A_DCDC1_VSET1 0x20 #define ACT8945A_DCDC1_VSET2 0x21 #define ACT8945A_DCDC1_CTRL 0x22 +#define ACT8945A_DCDC1_SUS 0x24 #define ACT8945A_DCDC2_VSET1 0x30 #define ACT8945A_DCDC2_VSET2 0x31 #define ACT8945A_DCDC2_CTRL 0x32 +#define ACT8945A_DCDC2_SUS 0x34 #define ACT8945A_DCDC3_VSET1 0x40 #define ACT8945A_DCDC3_VSET2 0x41 #define ACT8945A_DCDC3_CTRL 0x42 +#define ACT8945A_DCDC3_SUS 0x44 + +#define ACT8945A_DCDC_MODE_MSK BIT(5) +#define ACT8945A_DCDC_MODE_FIXED BIT(5) +#define ACT8945A_DCDC_MODE_POWER_SAVING (0) + #define ACT8945A_LDO1_VSET 0x50 #define ACT8945A_LDO1_CTRL 0x51 +#define ACT8945A_LDO1_SUS 0x52 #define ACT8945A_LDO2_VSET 0x54 #define ACT8945A_LDO2_CTRL 0x55 +#define ACT8945A_LDO2_SUS 0x56 #define ACT8945A_LDO3_VSET 0x60 #define ACT8945A_LDO3_CTRL 0x61 +#define ACT8945A_LDO3_SUS 0x62 #define ACT8945A_LDO4_VSET 0x64 #define ACT8945A_LDO4_CTRL 0x65 +#define ACT8945A_LDO4_SUS 0x66 /** * Field Definitions. @@ -63,12 +77,154 @@ enum { ACT8945A_REG_NUM, }; +struct act8945a_pmic { + struct regulator_dev *rdevs[ACT8945A_REG_NUM]; + struct regmap *regmap; +}; + static const struct regulator_linear_range act8945a_voltage_ranges[] = { REGULATOR_LINEAR_RANGE(600000, 0, 23, 25000), REGULATOR_LINEAR_RANGE(1200000, 24, 47, 50000), REGULATOR_LINEAR_RANGE(2400000, 48, 63, 100000), }; +static int act8945a_set_suspend_state(struct regulator_dev *rdev, bool enable) +{ + struct regmap *regmap = rdev->regmap; + int id = rdev->desc->id, ret, reg, val; + + switch (id) { + case ACT8945A_ID_DCDC1: + reg = ACT8945A_DCDC1_SUS; + val = 0xa8; + break; + case ACT8945A_ID_DCDC2: + reg = ACT8945A_DCDC2_SUS; + val = 0xa8; + break; + case ACT8945A_ID_DCDC3: + reg = ACT8945A_DCDC3_SUS; + val = 0xa8; + break; + case ACT8945A_ID_LDO1: + reg = ACT8945A_LDO1_SUS; + val = 0xe8; + break; + case ACT8945A_ID_LDO2: + reg = ACT8945A_LDO2_SUS; + val = 0xe8; + break; + case ACT8945A_ID_LDO3: + reg = ACT8945A_LDO3_SUS; + val = 0xe8; + break; + case ACT8945A_ID_LDO4: + reg = ACT8945A_LDO4_SUS; + val = 0xe8; + break; + default: + return -EINVAL; + } + + if (enable) + val |= BIT(4); + + /* + * Ask the PMIC to enable/disable this output when entering hibernate + * mode. + */ + ret = regmap_write(regmap, reg, val); + if (ret < 0) + return ret; + + /* + * Ask the PMIC to enter the suspend mode on the next PWRHLD + * transition. + */ + return regmap_write(regmap, ACT8945A_SYS_CTRL, 0x42); +} + +static int act8945a_set_suspend_enable(struct regulator_dev *rdev) +{ + return act8945a_set_suspend_state(rdev, true); +} + +static int act8945a_set_suspend_disable(struct regulator_dev *rdev) +{ + return act8945a_set_suspend_state(rdev, false); +} + +static unsigned int act8945a_of_map_mode(unsigned int mode) +{ + if (mode == ACT8945A_DCDC_MODE_POWER_SAVING) + return REGULATOR_MODE_STANDBY; + + return REGULATOR_MODE_NORMAL; +} + +static int act8945a_set_mode(struct regulator_dev *rdev, unsigned int mode) +{ + struct regmap *regmap = rdev->regmap; + int id = rdev->desc->id; + int reg, val; + + switch (mode) { + case REGULATOR_MODE_STANDBY: + val = ACT8945A_DCDC_MODE_POWER_SAVING; + break; + case REGULATOR_MODE_NORMAL: + val = ACT8945A_DCDC_MODE_FIXED; + break; + default: + return -EINVAL; + } + + switch (id) { + case ACT8945A_ID_DCDC1: + reg = ACT8945A_DCDC1_CTRL; + break; + case ACT8945A_ID_DCDC2: + reg = ACT8945A_DCDC2_CTRL; + break; + case ACT8945A_ID_DCDC3: + reg = ACT8945A_DCDC3_CTRL; + break; + default: + return -EINVAL; + } + + return regmap_update_bits(regmap, reg, ACT8945A_DCDC_MODE_MSK, val); +} + +static unsigned int act8945a_get_mode(struct regulator_dev *rdev) +{ + struct regmap *regmap = rdev->regmap; + int id = rdev->desc->id; + unsigned int val; + int reg; + + switch (id) { + case ACT8945A_ID_DCDC1: + reg = ACT8945A_DCDC1_CTRL; + break; + case ACT8945A_ID_DCDC2: + reg = ACT8945A_DCDC2_CTRL; + break; + case ACT8945A_ID_DCDC3: + reg = ACT8945A_DCDC3_CTRL; + break; + default: + return -EINVAL; + } + + regmap_read(regmap, reg, &val); + + if ((val & ACT8945A_DCDC_MODE_MSK) == ACT8945A_DCDC_MODE_POWER_SAVING) + return REGULATOR_MODE_STANDBY; + + return REGULATOR_MODE_NORMAL; +} + static const struct regulator_ops act8945a_ops = { .list_voltage = regulator_list_voltage_linear_range, .map_voltage = regulator_map_voltage_linear_range, @@ -76,7 +232,11 @@ static const struct regulator_ops act8945a_ops = { .set_voltage_sel = regulator_set_voltage_sel_regmap, .enable = regulator_enable_regmap, .disable = regulator_disable_regmap, + .set_mode = act8945a_set_mode, + .get_mode = act8945a_get_mode, .is_enabled = regulator_is_enabled_regmap, + .set_suspend_enable = act8945a_set_suspend_enable, + .set_suspend_disable = act8945a_set_suspend_disable, }; #define ACT89xx_REG(_name, _family, _id, _vsel_reg, _supply) \ @@ -84,6 +244,7 @@ static const struct regulator_ops act8945a_ops = { .name = _name, \ .supply_name = _supply, \ .of_match = of_match_ptr("REG_"#_id), \ + .of_map_mode = act8945a_of_map_mode, \ .regulators_node = of_match_ptr("regulators"), \ .id = _family##_ID_##_id, \ .type = REGULATOR_VOLTAGE, \ @@ -122,10 +283,22 @@ static int act8945a_pmic_probe(struct platform_device *pdev) { struct regulator_config config = { }; const struct regulator_desc *regulators; + struct act8945a_pmic *act8945a; struct regulator_dev *rdev; int i, num_regulators; bool voltage_select; + act8945a = devm_kzalloc(&pdev->dev, sizeof(*act8945a), GFP_KERNEL); + if (!act8945a) + return -ENOMEM; + + act8945a->regmap = dev_get_regmap(pdev->dev.parent, NULL); + if (!act8945a->regmap) { + dev_err(&pdev->dev, + "could not retrieve regmap from parent device\n"); + return -EINVAL; + } + voltage_select = of_property_read_bool(pdev->dev.parent->of_node, "active-semi,vsel-high"); @@ -140,16 +313,33 @@ static int act8945a_pmic_probe(struct platform_device *pdev) config.dev = &pdev->dev; config.dev->of_node = pdev->dev.parent->of_node; for (i = 0; i < num_regulators; i++) { - rdev = devm_regulator_register(&pdev->dev, ®ulators[i], &config); + rdev = devm_regulator_register(&pdev->dev, ®ulators[i], + &config); if (IS_ERR(rdev)) { dev_err(&pdev->dev, "failed to register %s regulator\n", regulators[i].name); return PTR_ERR(rdev); } + + act8945a->rdevs[i] = rdev; } - return 0; + platform_set_drvdata(pdev, act8945a); + + /* Unlock expert registers. */ + return regmap_write(act8945a->regmap, ACT8945A_SYS_UNLK_REGS, 0xef); +} + +static void act8945a_pmic_shutdown(struct platform_device *pdev) +{ + struct act8945a_pmic *act8945a = platform_get_drvdata(pdev); + struct regmap *regmap = act8945a->regmap; + + /* + * Ask the PMIC to shutdown everything on the next PWRHLD transition. + */ + regmap_write(regmap, ACT8945A_SYS_CTRL, 0x0); } static struct platform_driver act8945a_pmic_driver = { @@ -157,6 +347,7 @@ static struct platform_driver act8945a_pmic_driver = { .name = "act8945a-regulator", }, .probe = act8945a_pmic_probe, + .shutdown = act8945a_pmic_shutdown, }; module_platform_driver(act8945a_pmic_driver); From patchwork Fri Oct 26 16:19:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 10657673 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7736A14BD for ; Fri, 26 Oct 2018 16:20:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 641BD2CAFC for ; Fri, 26 Oct 2018 16:20:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 57E9C2CB00; Fri, 26 Oct 2018 16:20:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9833C2CAFC for ; Fri, 26 Oct 2018 16:20:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zn4EksfSDY/L7nZ7uzjOMWgC2Q9MKjl/59UZzD5OePg=; b=ibl0Kq6vBghJE2 bXN3TLHvC5s7dZMWMm3/Q391nh/qVCAg43+/HAwT/3eHTRULStFlsgITm1JMIBsNq9UJi63Ljd2Sy PMHtxKE0etnbV5ZlHK1+gMSlG8Zbjv5ROdKQkd9LL2+ZXoVRVlP+BvTWaF6EYm5bS6JH5XoZ8B44m hfFvZrFxMoqwuJVSP3LZlPx2jC9HQEUGNHS6p9PPl8ddcuCFrp7438OoMbnjj1ZsDOa8Lql4mnOd7 ExaMC3erICtypmLb2z49AFHst0WHZCEUqJrPQTEBYZYNNQt39e4CYVZsyTBvrKb1nBeFwoRyevmot XUdS2xtFJMhUVDRV7MLg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG4qw-0008Ur-BD; Fri, 26 Oct 2018 16:20:50 +0000 Received: from esa5.microchip.iphmx.com ([216.71.150.166]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gG4qB-0006ue-TB for linux-arm-kernel@lists.infradead.org; Fri, 26 Oct 2018 16:20:08 +0000 X-IronPort-AV: E=Sophos;i="5.54,428,1534834800"; d="scan'208";a="20187342" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa5.microchip.iphmx.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 26 Oct 2018 09:19:55 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (10.10.215.89) by email.microchip.com (10.10.76.38) with Microsoft SMTP Server (TLS) id 14.3.352.0; Fri, 26 Oct 2018 09:19:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microchiptechnology.onmicrosoft.com; s=selector1-microchiptechnology-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WFpec7d+H8qSbC6xHNglY4ZwbeCcEKuwdvW9jn83O2g=; b=N3znAKR56Zdjr3Hu6myX5LfWILMe1556ShgmLvrvsDRx+HOObx11hQZfXZmYJ1bnGkgp2c79T8r+Cs5chUfFuod4f288O0dw02ztZj9LYRaOkEVKh9tkG/NXo81G++Ygi0Gfo6CdTUkHbDCfKTjoRPcIWcYYkA/pDOmwG9jPb6I= Received: from BY2PR11MB0744.namprd11.prod.outlook.com (10.163.112.142) by BY2PR11MB0792.namprd11.prod.outlook.com (10.163.112.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1273.18; Fri, 26 Oct 2018 16:19:52 +0000 Received: from BY2PR11MB0744.namprd11.prod.outlook.com ([fe80::d0a5:29e0:506a:76a8]) by BY2PR11MB0744.namprd11.prod.outlook.com ([fe80::d0a5:29e0:506a:76a8%7]) with mapi id 15.20.1273.021; Fri, 26 Oct 2018 16:19:51 +0000 From: To: , , , , , Subject: [PATCH 2/2] ARM: dts: at91: sama5d2_xplained: Add proper regulator states for suspend-to-mem Thread-Topic: [PATCH 2/2] ARM: dts: at91: sama5d2_xplained: Add proper regulator states for suspend-to-mem Thread-Index: AQHUbUe5yUP2uUy8PEKK5rCQy8syxQ== Date: Fri, 26 Oct 2018 16:19:51 +0000 Message-ID: <1540570753-16370-3-git-send-email-claudiu.beznea@microchip.com> References: <1540570753-16370-1-git-send-email-claudiu.beznea@microchip.com> In-Reply-To: <1540570753-16370-1-git-send-email-claudiu.beznea@microchip.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: VI1P195CA0095.EURP195.PROD.OUTLOOK.COM (2603:10a6:802:59::48) To BY2PR11MB0744.namprd11.prod.outlook.com (2a01:111:e400:52de::14) authentication-results: spf=none (sender IP is ) smtp.mailfrom=Claudiu.Beznea@microchip.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [94.177.32.154] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; BY2PR11MB0792; 6:YEmziRQ9BWjIz0RIwMY1dY3cD2gx9YDDjbveGEN9D3G5k4kYVPlOesoHpVMrRq6XytodQNvB4tRNXPShUXc0rHSkVVj8dsqoQmSzGiVENs2G/e9yIKbC3FicrrNzGaMv4eczk55iZFDkwojadTUprGtKsu5pNX1YYGylNe1O06N4v1ve+/VVK3NdlJZmo9iAJtPHLOgrGVsj9QXfEwEUgbWTJI+SxXmBuExYpgO9SJz1bDXYptN2gMHoZ82Ro1CNyIkTakylZ1vn4zCL5AQAM8w6aiwS0Di3jEoa6y91Mm3Pm44Tumafh3cQwpcLdHvqhLmuvqoYsFVKlTE7Hw/g60/V1UE0JHSTfW3kulrOTycrkLTFc16DmWuo/xpbAC7f5cEt+nf8ZY3BG6wII4j12M8IK4xMoN5I9QWXOl2oUpU85C+F4CKCm1WG88LBOExd3hvxo0LE/vkuM3Wq8ZaAKg==; 5:5FtD9KA+UTGJBznBJeb9hNXnvj2j8lbQy1Ps665iJ8UarFTKtflExyO1wFsaCefbOHh66jbTnQZxavKBMJncX2Fqb/9aEww2SFJGfJidGxrhq/o5egnm4u96PiLEHREblcuvVM04GSW0JCrTsxxun0nPQ7ZhtIK31zXaY57k3FY=; 7:oWwyKMhBobO0QPfbCmDvhK4du8BEkT6CvpwTMHJD2cryxnXVcSAkewK47xU7qQlERZFX2RyjRolEE7UYT97IkF7Ql2AzXA10w8hXpyb1+cOA6kSQhgcdPqYyyHfPEzP3ucRRU4y7zA51NXGRmch1qA== x-ms-office365-filtering-correlation-id: e9f17f42-c787-4cc1-0619-08d63b5edb7d x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(2017052603328)(7153060)(7193020); SRVR:BY2PR11MB0792; x-ms-traffictypediagnostic: BY2PR11MB0792: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231355)(944501410)(52105095)(10201501046)(3002001)(148016)(149066)(150057)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(201708071742011)(7699051)(76991095); SRVR:BY2PR11MB0792; BCL:0; PCL:0; RULEID:; SRVR:BY2PR11MB0792; x-forefront-prvs: 083751FCA6 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(376002)(346002)(396003)(136003)(39840400004)(199004)(189003)(52116002)(256004)(2501003)(11346002)(76176011)(6486002)(99286004)(66066001)(3846002)(105586002)(81156014)(6116002)(71190400001)(25786009)(107886003)(8676002)(39060400002)(7736002)(15650500001)(305945005)(2616005)(476003)(446003)(68736007)(4326008)(5660300001)(36756003)(478600001)(2906002)(5250100002)(110136005)(54906003)(2900100001)(53936002)(14454004)(72206003)(316002)(26005)(81166006)(15760500003)(6512007)(386003)(6506007)(86362001)(106356001)(186003)(71200400001)(14444005)(486006)(8936002)(6436002)(102836004)(97736004); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR11MB0792; H:BY2PR11MB0744.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: microchip.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Tc8jH7LtaF2RLOg2kJEPeBPhwPn7GFR4NfuIVJ61Fn2jGQdutz2E1TQAg1oPN2TpdHB4MifDgWtT6o/TMqr0NiDYRJlHjZg6Qp12tI29Ag2z0vVCvXe3WREe75uvRR5F8N6h9fz9X8JRwa6VMwU5wa+JXyx1AYdyVW8uRGfcUP9Oxzo48PgYmS0nYgJpP/u8w0KPF/3cJwU6EiHh78mKNoQ/9wgNjHqGllhR7lospp1jXvtqXnQsYDL5H61Cv1zKtVi5xRQWSCZtrJgPRwIrbFVAozRHPU1vcX1pdN4UD9zvwU0x53FtSfozy8jFg+QkUKD0fahCwfmGi64urO+iGQBKhxMqNPEiyhp0s+u3d/g= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e9f17f42-c787-4cc1-0619-08d63b5edb7d X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Oct 2018 16:19:51.8295 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3f4057f3-b418-4d4e-ba84-d55b4e897d88 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR11MB0792 X-OriginatorOrg: microchip.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181026_092004_084214_34B50843 X-CRM114-Status: GOOD ( 10.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Claudiu.Beznea@microchip.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, boris.brezillon@bootlin.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Boris Brezillon When entering suspend-to-mem, all PMIC outputs are disabled except VDDIODDR which is put in power saving mode, and whose voltage is increased (probably to counter the poor accuracy of power saving mode). Signed-off-by: Boris Brezillon [claudiu.beznea@microchip.com: use regulator-changeable-in-suspend, regulator-suspend-max-microvolt, regulator-suspend-max-microvolt] Signed-off-by: Claudiu Beznea --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 33 +++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts index fcc85d70f36e..0137d7432834 100644 --- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts +++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts @@ -182,6 +182,15 @@ regulator-min-microvolt = <1350000>; regulator-max-microvolt = <1350000>; regulator-always-on; + + regulator-state-mem { + regulator-on-in-suspend; + regulator-suspend-min-microvolt=<1400000>; + regulator-suspend-max-microvolt=<1400000>; + regulator-changeable-in-suspend; + /* Power saving mode. */ + regulator-mode=<0>; + }; }; vdd_1v2_reg: REG_DCDC2 { @@ -189,6 +198,10 @@ regulator-min-microvolt = <1100000>; regulator-max-microvolt = <1300000>; regulator-always-on; + + regulator-state-mem { + regulator-off-in-suspend; + }; }; vdd_3v3_reg: REG_DCDC3 { @@ -196,6 +209,10 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + + regulator-state-mem { + regulator-off-in-suspend; + }; }; vdd_fuse_reg: REG_LDO1 { @@ -203,6 +220,10 @@ regulator-min-microvolt = <2500000>; regulator-max-microvolt = <2500000>; regulator-always-on; + + regulator-state-mem { + regulator-off-in-suspend; + }; }; vdd_3v3_lp_reg: REG_LDO2 { @@ -210,6 +231,10 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + + regulator-state-mem { + regulator-off-in-suspend; + }; }; vdd_led_reg: REG_LDO3 { @@ -217,6 +242,10 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-always-on; + + regulator-state-mem { + regulator-off-in-suspend; + }; }; vdd_sdhc_1v8_reg: REG_LDO4 { @@ -224,6 +253,10 @@ regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; + + regulator-state-mem { + regulator-off-in-suspend; + }; }; };