From patchwork Fri Sep 25 16:06:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Su X-Patchwork-Id: 11800213 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5419A112C for ; Fri, 25 Sep 2020 16:07:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 035B323718 for ; Fri, 25 Sep 2020 16:07:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="PVQYhqPD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 035B323718 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F0EAF900004; Fri, 25 Sep 2020 12:07:15 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id EBEDA6B007B; Fri, 25 Sep 2020 12:07:15 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD589900004; Fri, 25 Sep 2020 12:07:15 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id C84C06B0078 for ; Fri, 25 Sep 2020 12:07:15 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 8CDB1180AD801 for ; Fri, 25 Sep 2020 16:07:15 +0000 (UTC) X-FDA: 77302063230.29.comb91_4a012f627169 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 700FA180868DC for ; Fri, 25 Sep 2020 16:07:15 +0000 (UTC) X-Spam-Summary: 1,0,0,58894b47237aa162,d41d8cd98f00b204,sh_def@163.com,,RULES_HIT:41:355:379:582:800:960:966:973:988:989:1152:1260:1277:1312:1313:1314:1345:1381:1437:1516:1518:1519:1534:1542:1593:1594:1595:1596:1711:1730:1747:1777:1792:2196:2198:2199:2200:2393:2553:2559:2562:2731:2895:3138:3139:3140:3141:3142:3353:3865:3866:3867:3868:3870:3871:3872:3874:4321:4385:4605:5007:6261:6653:7903:10004:10400:11026:11334:11657:11658:11914:12048:12296:12297:12438:12555:12895:13215:13229:13439:13895:14096:14097:14181:14394:14721:21080:21324:21627:21740:30054:30070:30090,0,RBL:220.181.12.15:@163.com:.lbl8.mailshell.net-62.50.2.100 66.100.201.100;04ygxyk4xwsh6qn1ao783dnczqqryyp6inrk5oncugwhzjjifkao4g3afwetdp6.5rutnc4dm7b4jkfxks56k3xc6ehcugex316p61sz5wmrmjn831d39ipphdm9yqi.4-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: comb91_4a012f627169 X-Filterd-Recvd-Size: 3842 Received: from m12-15.163.com (m12-15.163.com [220.181.12.15]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Fri, 25 Sep 2020 16:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=TPYFb PSp4V8vYQ4z0mS+XWUEYAjUGpB+g/xY+pc+6GE=; b=PVQYhqPDCUwiAEdCTv3nZ UM+WBwcstQfT/KMzCBTVXr5/Obw6/vTsN3e/TxWPG8kZ6Rs2ZRplwls5wzjfy5Lw +668EgpaU6EqLwJvcPjwdcOjjC5Cy1YB7H7L4iPdmgcPN7OO3OLqteOKxjsZ9xbN 6FwYolGypdX4NBacz+rx58= Received: from localhost (unknown [101.86.214.224]) by smtp11 (Coremail) with SMTP id D8CowAAH3peaFW5fMOwfDw--.9007S2; Sat, 26 Sep 2020 00:06:51 +0800 (CST) Date: Sat, 26 Sep 2020 00:06:50 +0800 From: Hui Su To: lizefan@huawei.com, tj@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH] mm: fix some comments in page_alloc.c and mempolicy.c Message-ID: <20200925160650.GA42847@rlk> MIME-Version: 1.0 Content-Disposition: inline X-CM-TRANSID: D8CowAAH3peaFW5fMOwfDw--.9007S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7ZFWUurWrtF4fCw1rAF45GFg_yoW8tFWkpF WkGa45A3WFvF1jk392ka1Dury0gw48Ja17KFn5Gwn5Z3W3tF4qkF9rWwnxZryYyF1Y9a4U trZIvr4Yg3WDJ3DanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jSnmiUUUUU= X-Originating-IP: [101.86.214.224] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbitwSqX1aEFvbE+wABsK X-Bogosity: Ham, tests=bogofilter, spamicity=0.010948, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 1. the cpuset.c has been moved from kernel/cpuset.c to kernel/cgroup/cpuset.c long time ago, but the comment is stale, so we update it. 2. get_page_from_freelist() may alloc many pages according to order, we may use pages for better. Signed-off-by: Hui Su --- kernel/cgroup/cpuset.c | 2 +- mm/mempolicy.c | 2 +- mm/page_alloc.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index 642415b8c3c9..1d3011c1aab6 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -1,5 +1,5 @@ /* - * kernel/cpuset.c + * kernel/cgroup/cpuset.c * * Processor and Memory placement constraints for sets of tasks. * diff --git a/mm/mempolicy.c b/mm/mempolicy.c index eddbe4e56c73..ac59b049b16c 100644 --- a/mm/mempolicy.c +++ b/mm/mempolicy.c @@ -2295,7 +2295,7 @@ int vma_dup_policy(struct vm_area_struct *src, struct vm_area_struct *dst) * rebinds the mempolicy its copying by calling mpol_rebind_policy() * with the mems_allowed returned by cpuset_mems_allowed(). This * keeps mempolicies cpuset relative after its cpuset moves. See - * further kernel/cpuset.c update_nodemask(). + * further kernel/cgroup/cpuset.c update_nodemask(). * * current's mempolicy may be rebinded by the other task(the task that changes * cpuset's mems), so we needn't do rebind work for current task. diff --git a/mm/page_alloc.c b/mm/page_alloc.c index fab5e97dc9ca..1e3c7493e1cb 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3709,7 +3709,7 @@ static inline unsigned int current_alloc_flags(gfp_t gfp_mask, /* * get_page_from_freelist goes through the zonelist trying to allocate - * a page. + * pages. */ static struct page * get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, @@ -3723,7 +3723,7 @@ get_page_from_freelist(gfp_t gfp_mask, unsigned int order, int alloc_flags, retry: /* * Scan zonelist, looking for a zone with enough free. - * See also __cpuset_node_allowed() comment in kernel/cpuset.c. + * See also __cpuset_node_allowed() comment in kernel/cgroup/cpuset.c. */ no_fallback = alloc_flags & ALLOC_NOFRAGMENT; z = ac->preferred_zoneref;