From patchwork Sat Oct 27 02:00:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10658035 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80EE015A7 for ; Sat, 27 Oct 2018 02:01:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 71A6C2C7A1 for ; Sat, 27 Oct 2018 02:01:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6471F2C7F9; Sat, 27 Oct 2018 02:01:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 088CC2C7A1 for ; Sat, 27 Oct 2018 02:01:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727398AbeJ0Kj7 (ORCPT ); Sat, 27 Oct 2018 06:39:59 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:39920 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726048AbeJ0Kj6 (ORCPT ); Sat, 27 Oct 2018 06:39:58 -0400 Received: by mail-qk1-f194.google.com with SMTP id e4so1844392qkh.6 for ; Fri, 26 Oct 2018 19:00:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=k98qfZFTnS8YJsoHEehtGRqClwouswNGYRpoM+jy0g0=; b=0mvHuAu73tBFg2S2xrmm13wOe/2ZPE0w3h1ybC4dfMYqIkCJajhFGuOcRZ457PFVVq qIoc9L6ErihoxUKmAwQBcw2HBkOH02vz1dDMnSyleijBuYHm3/xNNcLEM60zSoH3ekKR /gLgC6Ec/vsMOuYYWmN+8g9TUZYp/+gkkCtVyVXtUWT3tWFfliczUUQ4fEwxt9M/a7wV 93gHnTH3KJpK6y2q3SasjrkL6ESkvPgA3hLemUZF4ZKXQsX1OEVX+MfM9OgTDPrJKMq+ D8uFFN4sjoZK1gYb/nP66iSuktTXlopIh+Nq5JOfpayoTjBCyqP3UV9VLEu9UR7SBS0/ 6tIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=k98qfZFTnS8YJsoHEehtGRqClwouswNGYRpoM+jy0g0=; b=YJwmw6sVQEvJComgMHVQMHwp3gnUCi4C6dIGTXFWV8ra+km5iH3whvYMeuza7QzP46 D0en5DMIfCTDIJc8EdQepB7hpsirr95UI4dXFy7maowE+BV/2o1cxto0mBa9Rr8jcv6a 80AH16pMTTXBfaKj4vFGlSPoZI/kvRtHnWHMQ2l3jgCL8lDWQGlVN5MwYNw+wobXylnb Qv2aGrdVd5EZURorDrdsD+KLdc+4bzL/vggkcY96p6HGE3kpeppEz17B6IP5LjObJqiT C/kFppgfeU/8F+jEKSJCA0CnoUmhfy63baLivEWaH6634XRa2Sv+sq4vRfSShFnKf+ZS AdIQ== X-Gm-Message-State: AGRZ1gKkhj4QS/clcH1YA5XOjsoBqSzWjI57mrg55rZSHHyPhp6JEiWs bcboeDMqJUmuIy7Ib5jOSniNMw== X-Google-Smtp-Source: AJdET5cdYWQCzzz2kZGr6+Kw9s3+0znmG3RnArlGWcHf3C5FviHbNCXNukzyEjI0z3oc5dD/pkn3Bw== X-Received: by 2002:a37:aa91:: with SMTP id t139mr5101949qke.139.1540605638037; Fri, 26 Oct 2018 19:00:38 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id h67-v6sm8499777qkf.32.2018.10.26.19.00.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:00:37 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code Date: Fri, 26 Oct 2018 23:00:00 -0300 Message-Id: <20181027020005.3140-2-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 59586947a936..11fac9f90148 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -35,12 +35,15 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, struct ad2s90_state *st = iio_priv(indio_dev); mutex_lock(&st->lock); + ret = spi_read(st->sdev, st->rx, 2); - if (ret) - goto error_ret; + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } + *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); -error_ret: mutex_unlock(&st->lock); return IIO_VAL_INT; From patchwork Sat Oct 27 02:00:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10658025 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42B1E14DE for ; Sat, 27 Oct 2018 02:00:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 353A62C79A for ; Sat, 27 Oct 2018 02:00:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 29A202C7A1; Sat, 27 Oct 2018 02:00:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9C5BA2C79A for ; Sat, 27 Oct 2018 02:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727698AbeJ0KkC (ORCPT ); Sat, 27 Oct 2018 06:40:02 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:47011 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725892AbeJ0KkB (ORCPT ); Sat, 27 Oct 2018 06:40:01 -0400 Received: by mail-qk1-f196.google.com with SMTP id q1so129053qkf.13 for ; Fri, 26 Oct 2018 19:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=WjbK4B6Pz9n82ZrdDfd6PM5GbCp+QQyg3yNP3mE7mKzlOXjeN844EOEYIK2yahjQ0o mVp8ZHWSiKqLhFU9dnqEusVrxdF5+JSSC859jT7UY984FUY0tflownWmlZ2cmc8CGs+S t5xXcLBtcYq4EXaVJKSzsERb14VLzX0FNpZm06WX2ReOxgJAS8HI744ZwIUCV4hU3YMZ Kn6aBih4w7SM2pRK7K3QsFWq5UKIh+IaTLkDvcXJ6o/iYJlFE2B0bogytJBkp9fhmehr NX5h0px7aJS0V+aFJ7EZpleD7VB0oBRmUpu2ebvwHrP4hrlF8Z2W8ht/UmcwhwFYFgH5 nsCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NGr8UhZ9CwRomF1EVbg7fLmktxQjU3RFkveOlg5US54=; b=t20Fp8haw6RF8/2UgKXWCCI/cdJnmVIpFLg2VuTKn91eDv5V5Dh/n0FSC5fWouufmt RD5QktcrZKpDTQUazcNr9h/mzMfn63tvG/8mx7anqovkj/x+AR4uf6cgvUw+dQ7n7vRu 8OdZ9sQt2Bw9D7QXofm42IXDZDt2CYTQy6mg7sZUK0F95GYM5yXMqGREPHojBfs5t3oa ixOI3C2hSHqccW7/MyPmQIEqHSlPTcHswyCckOFsUqexrLn2JFLic3+b2OnKtiO0oPLu jygFMkcIWmmhAvHoXTmhZrhqKkJhCmCO/xbSMBg6Y+Z91t8TIK6DvHrgixhLtU1A9If9 WJ2w== X-Gm-Message-State: AGRZ1gLXEwJKpKQFnVlFd5kBMxXP4OzwNjcSkn5O+gbLbxOleAMF4+8s lh5QQvaBkxH/nq0HucuXRuX1sQ== X-Google-Smtp-Source: AJdET5fQuEouxoTq1ebTp9DugDk3pG9h6vIhcvOj+9AFlURyWW6ARC4U0cY76QYXWd4bS/Cds7iOMA== X-Received: by 2002:a37:fa8:: with SMTP id 40mr5265581qkp.48.1540605641110; Fri, 26 Oct 2018 19:00:41 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id h67-v6sm8499777qkf.32.2018.10.26.19.00.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:00:40 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure Date: Fri, 26 Oct 2018 23:00:01 -0300 Message-Id: <20181027020005.3140-3-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, ad2s90_probe ignored the return code from spi_setup, not handling its possible failure. This patch makes ad2s90_probe check if the code is an error code and, if so, do the following: - Call dev_err with an appropriate error message. - Return the spi_setup's error code, aborting the execution of the rest of the function. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 11fac9f90148..d6a42e3f1bd8 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -88,7 +88,12 @@ static int ad2s90_probe(struct spi_device *spi) /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; - spi_setup(spi); + ret = spi_setup(spi); + + if (ret < 0) { + dev_err(&spi->dev, "spi_setup failed!\n"); + return ret; + } return 0; } From patchwork Sat Oct 27 02:00:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10658033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 65DFF15A7 for ; Sat, 27 Oct 2018 02:01:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 586E82C19F for ; Sat, 27 Oct 2018 02:01:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 480972C7CE; Sat, 27 Oct 2018 02:01:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E85D22C19F for ; Sat, 27 Oct 2018 02:01:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727743AbeJ0KkF (ORCPT ); Sat, 27 Oct 2018 06:40:05 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:33369 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727741AbeJ0KkE (ORCPT ); Sat, 27 Oct 2018 06:40:04 -0400 Received: by mail-qt1-f194.google.com with SMTP id i15-v6so3439690qtr.0 for ; Fri, 26 Oct 2018 19:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=J5RxTErJXoIN4DFbUXbMSG5XxKyOAlaWHaLsxy5wXNA=; b=i+xRmGszyHXsGOlwYvMiG4mFJva9OV47BWT/Z+nYhns536kXMs/XgGdbGBHG/S4BxN 8mN8DYXRMSdt18k9VZKU2X66CnIzj4g1QLZKanEEZQQ8K4l+xr95iE2uOn/CcoUsELtp f7SazgtC7jPXVEzlAIbPL9p53IrzqLQ6R065RxSGCEPKqBOBm9z4mTNgaXwPvgDEFD+u 7iB+MJwboM7159+DtOh9T47fyyDeGW2P+PWrQgHm6DnzBTGp22LkCH+wm9T4vbsshU2l MLaTLK40A//QLvOB2e3p95hgTbSePyVBvvc9ChiL3aX79AxY+fPHWi4/MYHky1Bd0jgg kduw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=J5RxTErJXoIN4DFbUXbMSG5XxKyOAlaWHaLsxy5wXNA=; b=q1ocomqwzO+//mJOuI6IT+8mF5FUmH1kugTjBpqORX2EBGT++038ypoA/b/h3rtCd+ TbFLZ4Xh3pscn2Ziq2JmhgIoWjGFKiWS6tAuy+N/yDp1wHRUHm0DTc4Q7FIFcaJqR4Zx +RQ++EAKqsOBy2y50WmcAARZQ2AbUoQbec6qTUFB3xSN2wkDQxsxHnI+MWEdQmvtYvy1 MXFCCukLBqtuQlOZ4RxWmjokelFFkt4cGdlkY8oeiRnwmyRZ/OReZO22//G5AjYaMgzo 27Or9QDz1EUssP/DdDrY0dtWEfmR5B32qAHJvKim2L3PtpT+MqvLJhXFJT30XcI7X2MJ 3JIQ== X-Gm-Message-State: AGRZ1gK6GYMYASr9TTJkU8YqRrUaNXfaETHZ6tafAB/lJE8JwcvnivvP 6PTaLwnwb9gSy6ENtZosq60L6Q== X-Google-Smtp-Source: AJdET5fwcBZGWVm1ZBdNb85/o3FMVCpcze2t9NbIlq4FYOEOZPIPT/rN+rFMPUNvkgVz3WJk0P4U2Q== X-Received: by 2002:ac8:5414:: with SMTP id b20-v6mr5489234qtq.144.1540605644110; Fri, 26 Oct 2018 19:00:44 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id h67-v6sm8499777qkf.32.2018.10.26.19.00.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:00:43 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v2 3/6] staging:iio:ad2s90: Remove always overwritten assignment Date: Fri, 26 Oct 2018 23:00:02 -0300 Message-Id: <20181027020005.3140-4-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch removes an initial assignment to the variable ret at probe, that was always overwritten. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index d6a42e3f1bd8..c20d37dc065a 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -64,7 +64,7 @@ static int ad2s90_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct ad2s90_state *st; - int ret = 0; + int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); if (!indio_dev) From patchwork Sat Oct 27 02:00:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10658031 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EC26414DE for ; Sat, 27 Oct 2018 02:01:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE9FB2C19F for ; Sat, 27 Oct 2018 02:01:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CFAAF2C7CE; Sat, 27 Oct 2018 02:01:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 766682C19F for ; Sat, 27 Oct 2018 02:01:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727793AbeJ0KkI (ORCPT ); Sat, 27 Oct 2018 06:40:08 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:38099 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727792AbeJ0KkI (ORCPT ); Sat, 27 Oct 2018 06:40:08 -0400 Received: by mail-qt1-f193.google.com with SMTP id r22-v6so3417727qtm.5 for ; Fri, 26 Oct 2018 19:00:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z2LHH9F5OJ0rvYdq5SDRuLDudXHduK0q/J3//KKhqZw=; b=ruL+ahgQTt8IWvavSx0G9329AhPM1OKdSqIdK5LK4YJrghthI+Mxz8SKeL1a2HmvwE e+H8ERDXOenJ0kDdhwWl5ZzlyxcyE8fq7yPMzC+2CaOQ5ThT1l07yxH5xV8CocAG5Dd4 EcxXmBJtqpMEoeGHZ+Ep5upwQZIVMbtf50EV4WOHWVb9yJwm7RSDkJF9SWwCSFtjMtLt 89zeRKq2r/0N94tkWj5W1U1lj/jdW0jTasEg/z+gfUHkXKiPdIpVa+/QPgM2Y1SNYg/A elSCW4CxeYOYH80QZLawAO8LUgKhcH4EdK8mzCy3fZNYK5+QIOxyznh821RxaXKX/CM+ lIqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z2LHH9F5OJ0rvYdq5SDRuLDudXHduK0q/J3//KKhqZw=; b=RtDL9MizBlFv05P/5IoQ4DnLDMtFaCR0GirQROa5QGzmqeUCiO+1/tN6RBo0RmhSra 3p4nUJL0f6WHon58zvcRAQ9ZR46HMqmDeNmiwjYAx3zdGlvlrS8BJsSx197HBXInUb0E fKYQKXX/Nmseg2t/Yl9hAGc4G0TxAztkjJ+zG5VPOSkWX3W7OuBEt8nPKIgQ4qlUb1yu qcqko/G5rGb3RFM7SFvaFP2o0msG7eajOb0rYkLKa7itrxycKFyiPS6t4I1HhqWoec24 PG+i+IKWafkRv6mtCDNHTTeLjYmspClmclYC0yHikhV4zf0/lMc2FmhlIEn1JI16k/+J 51jA== X-Gm-Message-State: AGRZ1gKPQPXeYqZduX6HjgJWnaa5rF1+ea1Kg47LYgEJUw40/HMjEEnx kKUQpq/3ey8vdd0/BpV14aIw9w== X-Google-Smtp-Source: AJdET5cu1/HMNJwpQhcKHquey8ibfvg93sjyy2N490xuju8SYMqryd7dFoZAwVoD34W9ac9yYlF6hg== X-Received: by 2002:ac8:701d:: with SMTP id x29-v6mr5458721qtm.161.1540605647110; Fri, 26 Oct 2018 19:00:47 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id h67-v6sm8499777qkf.32.2018.10.26.19.00.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:00:46 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v2 4/6] staging:iio:ad2s90: Move device registration to the end of probe Date: Fri, 26 Oct 2018 23:00:03 -0300 Message-Id: <20181027020005.3140-5-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, devm_iio_device_register was being called before the spi_setup call and the spi_device's max_speed_hz and mode assignments. This could lead to a race condition since the driver was still being set up after it was already made ready to use. To fix it, this patch moves the device registration to the end of ad2s90_probe. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index c20d37dc065a..b4a6a89c11b0 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -81,10 +81,6 @@ static int ad2s90_probe(struct spi_device *spi) indio_dev->num_channels = 1; indio_dev->name = spi_get_device_id(spi)->name; - ret = devm_iio_device_register(indio_dev->dev.parent, indio_dev); - if (ret) - return ret; - /* need 600ns between CS and the first falling edge of SCLK */ spi->max_speed_hz = 830000; spi->mode = SPI_MODE_3; @@ -95,7 +91,7 @@ static int ad2s90_probe(struct spi_device *spi) return ret; } - return 0; + return devm_iio_device_register(indio_dev->dev.parent, indio_dev); } static const struct spi_device_id ad2s90_id[] = { From patchwork Sat Oct 27 02:00:04 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10658029 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 337C814DE for ; Sat, 27 Oct 2018 02:01:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 271482C19F for ; Sat, 27 Oct 2018 02:01:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 18F042C7F9; Sat, 27 Oct 2018 02:01:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id ACBAE2C19F for ; Sat, 27 Oct 2018 02:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727844AbeJ0KkM (ORCPT ); Sat, 27 Oct 2018 06:40:12 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:36126 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727659AbeJ0KkL (ORCPT ); Sat, 27 Oct 2018 06:40:11 -0400 Received: by mail-qt1-f193.google.com with SMTP id u34-v6so3425585qth.3 for ; Fri, 26 Oct 2018 19:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=q2vdmtUPmzwFZSI00GQes0NB6ZitLyrsTfc3LNt6rZ8=; b=SzL4ZeniqHfcy081DHrPNC+V2oGbX5i773yZH+MmCKUiVrOPTXl+wcXMl1ye6RyWhU +O+yAMQUlp+6mK1sp6OVmT9Ef8b/yAnjWmBDbKRLbIeuIfGE/Xd3DoVUttxfSbQWOaRA q50xaSGVCz0m2uAOOOpTuDRXVenyktYgSjgEBzCWwsqr1uw0Zu7TqVaSwuKVBWmVYjAi q5lcywwbf94NGO6aQeuHLsHkU0FBj+E0Yl90xI1bQ+AJfczUXcxbSh9UUqXmA3M0yF9k tTWz1U4+AFWMox2C4qKtruqkU9goxYWrvNDJsyNrDXfQjFmP6PzOofIXNXPS6CjxFEZm 2h3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=q2vdmtUPmzwFZSI00GQes0NB6ZitLyrsTfc3LNt6rZ8=; b=fVMjbWJ1ILKoqiSisyW3zFsS96OqrAdqMqjWk0P7ZTG0CaXumDCKMpgvH1fpRpAaPz l9DTCnF6N8bqbJ976FgIiFHYEn/OOKQvFMgn5+0ES35hp992DxQ3PonxOMbyk/jXjSY9 rV5e+aMxs4T4ggmaXb7DuHgdnraUwZKU2azqikKx/vsR89QYvXruo7l/wRGn4EugooJ9 aQR7Tfb304YbMmXHVZfH4ANWd1aub0QTJFqKB4g9XNyoOPhdAUtWBR6MnZSDaUoBsQHM l06DdA/i5/e0eOCmvz3wta+bBx2DWkDkRILIQ+3lf06+n3266p/79+JhlCHAeLuLZmu3 ZTyg== X-Gm-Message-State: AGRZ1gJuNqYpvA8dBitaG2d00cFFoiOYJ+RnqbzP3s2ldHDT1DjTdoeS RKARGJjvxap2WMaNJ0tLeGilVA== X-Google-Smtp-Source: AJdET5d/djts5UApLE+6dQVmk45w7/rXb4FHqLDrVbp69bflikCGdDgMAxOfQMUC7z60YCiisfRtbg== X-Received: by 2002:a0c:ad8f:: with SMTP id w15mr5372488qvc.146.1540605650310; Fri, 26 Oct 2018 19:00:50 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id h67-v6sm8499777qkf.32.2018.10.26.19.00.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:00:49 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com, Victor Colombo Subject: [PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw Date: Fri, 26 Oct 2018 23:00:04 -0300 Message-Id: <20181027020005.3140-6-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and implements the relative read behavior at ad2s90_read_raw. Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 32 ++++++++++++++++++--------- 1 file changed, 22 insertions(+), 10 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index b4a6a89c11b0..52b656875ed1 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -34,19 +34,31 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, int ret; struct ad2s90_state *st = iio_priv(indio_dev); - mutex_lock(&st->lock); + switch (m) { + case IIO_CHAN_INFO_SCALE: + /* 2 * Pi / (2^12 - 1) ~= 0.001534355 */ + *val = 0; + *val2 = 1534355; + return IIO_VAL_INT_PLUS_NANO; + case IIO_CHAN_INFO_RAW: + mutex_lock(&st->lock); + + ret = spi_read(st->sdev, st->rx, 2); + if (ret < 0) { + mutex_unlock(&st->lock); + return ret; + } + + *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); - ret = spi_read(st->sdev, st->rx, 2); - if (ret < 0) { mutex_unlock(&st->lock); - return ret; - } - *val = (((u16)(st->rx[0])) << 4) | ((st->rx[1] & 0xF0) >> 4); - - mutex_unlock(&st->lock); + return IIO_VAL_INT; + default: + break; + } - return IIO_VAL_INT; + return -EINVAL; } static const struct iio_info ad2s90_info = { @@ -57,7 +69,7 @@ static const struct iio_chan_spec ad2s90_chan = { .type = IIO_ANGL, .indexed = 1, .channel = 0, - .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE), }; static int ad2s90_probe(struct spi_device *spi) From patchwork Sat Oct 27 02:00:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matheus Tavares X-Patchwork-Id: 10658027 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3FE9614DE for ; Sat, 27 Oct 2018 02:01:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 313642C7A1 for ; Sat, 27 Oct 2018 02:01:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 227B52C821; Sat, 27 Oct 2018 02:01:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2EA62C7A1 for ; Sat, 27 Oct 2018 02:01:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727941AbeJ0KkO (ORCPT ); Sat, 27 Oct 2018 06:40:14 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:36156 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727878AbeJ0KkO (ORCPT ); Sat, 27 Oct 2018 06:40:14 -0400 Received: by mail-qk1-f196.google.com with SMTP id q184-v6so1847607qkd.3 for ; Fri, 26 Oct 2018 19:00:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=usp-br.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=NU6uEhiDTDfMKDT6vIKylD1JcOmwJKYVJFXwnpeU4xs=; b=sOjLj73hbkjSNHCbjYdY/10ua9GvS5qgofryFwX7Al2Wq0Ah/5T0+uLHRFthjyBSJR fTxs1EBvwwPAxu2/CpX6Rp9IcNWvQ4Dczucmuj7hIBEjAjTCvnvcuzwYtr7a7BmczEqD EC9Hw3/QdPVRZ54nCM9GZYJzFYhzuMSUc9tSmxuHNoTrd9bXikADe/Jk/AAIe2pLYDxP CtEwaCma9AcArR9h9GULLKwSFz0RjwZ0m1s6diAdZp2M1n9k5D3V/8AAAZBJL2Jc4L4R +rRwBd4hm+ldGz7/+5i9pky/AHbNqQMzDVnqoYm/juj42YnPhnKwVJn6rjc8PQwroUSd GRvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NU6uEhiDTDfMKDT6vIKylD1JcOmwJKYVJFXwnpeU4xs=; b=KlmAfLnYVe7B8BlLyagTGLQO5/CU7QezsT5wjoJgogR9TZQEhHkpRwkXYpyTtKhNjH 3dvtVx26i9kljc5fptYxDe0DDMGBNz+Nlmbz4mw0heHGed5q+KIExkS4wzgHKa8Gk5d1 gbtZ7nWORsP1ApfcyJiiglD0LT83IGcgdN0FtdhmOYFjW4H/1QN3C0Omd4NOgcZCoHwN 1l2p2WCgcgX0gRT+YCvuMRB1ioKYDjWJDAh9mKQlmy3/1htuVMII6JYrGXQtMQPajREj 0skER/ZS/qieX5FsRq4lulG4bCFIybBkZKqzEJb5czkt7OPzn9Vob5dRVXf1Q1yZAS9i QJng== X-Gm-Message-State: AGRZ1gJEpFpUF+nWMNZ2ELmSbOBBCORd3DUzfE5anJOJjz0Cw4aqZxn3 0twyDK63qWSUIiQ1x+eVz/3W9A== X-Google-Smtp-Source: AJdET5cpuLESHD23vMBbkSd1mZMwXcwmH5QzRTLkRUJMo3g/oXciZKeWaC6sNGnbDMdF/eH7p6RlAA== X-Received: by 2002:a37:1ad9:: with SMTP id l86mr5001061qkh.54.1540605653316; Fri, 26 Oct 2018 19:00:53 -0700 (PDT) Received: from mango.spo.virtua.com.br ([2804:14c:81:942d::1]) by smtp.gmail.com with ESMTPSA id h67-v6sm8499777qkf.32.2018.10.26.19.00.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Oct 2018 19:00:52 -0700 (PDT) From: Matheus Tavares To: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Hartmut Knaack , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com Subject: [PATCH v2 6/6] staging:iio:ad2s90: Check channel type at read_raw Date: Fri, 26 Oct 2018 23:00:05 -0300 Message-Id: <20181027020005.3140-7-matheus.bernardino@usp.br> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181027020005.3140-1-matheus.bernardino@usp.br> References: <20181027020005.3140-1-matheus.bernardino@usp.br> Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch adds a channel type check at the beginning of the ad2s90_read_raw function. Since ad2s90 has only one channel, it just checks if the given channel is the expected one and if not, return -EINVAL. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c index 52b656875ed1..24002042a5c5 100644 --- a/drivers/staging/iio/resolver/ad2s90.c +++ b/drivers/staging/iio/resolver/ad2s90.c @@ -34,6 +34,9 @@ static int ad2s90_read_raw(struct iio_dev *indio_dev, int ret; struct ad2s90_state *st = iio_priv(indio_dev); + if (chan->type != IIO_ANGL) + return -EINVAL; + switch (m) { case IIO_CHAN_INFO_SCALE: /* 2 * Pi / (2^12 - 1) ~= 0.001534355 */