From patchwork Thu Oct 1 11:03:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 11811301 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 23467139F for ; Thu, 1 Oct 2020 11:03:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E70FD20B1F for ; Thu, 1 Oct 2020 11:03:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gH4j3mK4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="LsGUqUvX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E70FD20B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=aVAbhZ3A8R/bkICnQ4PJFkEYpU7fx5xRG3bvUC/reUs=; b=gH4j3mK4TTs7TYEu3ms4odlvn2 tiV2bpAjf9g3bhi1SC5s9ZbtGd5kObfkFqQvn2/nOUFlB3SfZFIOdp/YUUNL/F4SouBj7ImSHm+4C +X5uq+F480lCmfXGFtMyzsoIyf/1jqGs+lRSMVvBxmxOChyl9W4TFnxUp0C+7aHqkCydxb9Inv7QG 41zxhAhKHKiSwP7b9Mf9+2QYpxCIgi3ONh/JuAJR+Mt1bPkGuGn8qrbuZjgXVNvMR5XWCTifU78fp qXvd13jKqiVEfK9HtaROuXT7ZtAz0vpSTHprq2h3N3CBLv2bw2nLoTGPaJ7VM12TYnFsURMoA5Mrq ix56aZdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNwMt-00019t-4U; Thu, 01 Oct 2020 11:03:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNwMq-00018w-Dq for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 11:03:21 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BE34B2137B; Thu, 1 Oct 2020 11:03:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601550199; bh=QqBWYFceAV9eRz9MdwHloz53O7ACwbM/lAUyFD2oOtc=; h=From:To:Cc:Subject:Date:From; b=LsGUqUvXnH7LSKlqpbSkJh0mC1PQ2mBPu4sXspLjA0eD2lAlnhia1RD9wEhfa/utj lQS8MeaG7p06+SRVjB0R/tJDhN8fo/TCxdcDIi5ErX86FH52OyE1iMqa+OaDv4p3WH jafPZyrfuuvJyEmMqNXMdGDJTgoZD7IqfmD+CrUY= From: Will Deacon To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] perf: arm-cmn: Fix unsigned comparison to less than zero Date: Thu, 1 Oct 2020 12:03:14 +0100 Message-Id: <20201001110315.18505-1-will@kernel.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_070320_763314_7D2B0867 X-CRM114-Status: GOOD ( 13.83 ) X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , robin.murphy@arm.com, "Gustavo A . R . Silva" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Ensure that the 'irq' field of 'struct arm_cmn_dtc' is a signed int so that it can be compared '< 0'. Link: https://lore.kernel.org/r/20200929170835.GA15956@embeddedor Addresses-Coverity-ID: 1497488 ("Unsigned compared against 0") Fixes: 0ba64770a2f2 ("perf: Add Arm CMN-600 PMU driver") Reported-by: Gustavo A. R. Silva Signed-off-by: Will Deacon Reviewed-by: Gustavo A. R. Silva --- drivers/perf/arm-cmn.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index e824b5b83ea2..cd4da4c5dac0 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -217,7 +217,7 @@ struct arm_cmn_node { struct arm_cmn_dtc { void __iomem *base; - unsigned int irq; + int irq; int irq_friend; bool cc_active; From patchwork Thu Oct 1 11:03:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Will Deacon X-Patchwork-Id: 11811303 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 82FE86CA for ; Thu, 1 Oct 2020 11:03:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E9B12087D for ; Thu, 1 Oct 2020 11:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ffYIdKIy"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oJmwdZ2g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E9B12087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nu8d2ThIMOrLcrAlfdSgOzVqBgK7uCBj00MeFFSZbyQ=; b=ffYIdKIynsT+dv5BTfQuE5aXq gajfoapLR15wtbxGCcMdoejRfW1NUT5QLSm1Kl12o/Plizto9rd9sB+iRkLLe1xVKgCxWd8bj/UH9 /ZvG98PaEFae2pamZ5c4n+AK+2kdyebjo9Opj09lkVT8jeA4OS3YsPIq1x5BZaUOoVSEAMb2m/1jl IohIjD04VtP5+qu8m2RsltIKroqnvxkrwhsBBHzd/M9ToDLc+TkZofjzrbSwacEi6XJcI4Huu1FN+ fUv3w+S+MJ4CkaQbMtWoVYoXFBlQ5wgY23ZFKL1zjChL2GkSNSS4HoS6NzGYbMAHo3+7kcKmxgkH4 Hf1C2VooA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNwMv-0001Al-3z; Thu, 01 Oct 2020 11:03:25 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kNwMr-00019M-Gu for linux-arm-kernel@lists.infradead.org; Thu, 01 Oct 2020 11:03:22 +0000 Received: from localhost.localdomain (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A3362176B; Thu, 1 Oct 2020 11:03:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1601550201; bh=KzXxDLJKIgILnbP1LlnMsq4XY7Ti3d38pVq1F3EzNjs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oJmwdZ2gMGh994+gNJ73G5ny5JeOmohdjsQ8CJGpM+Owp1hn8eFanf8RnosYXjmbD gin7I0DiSaDrONYcz2kiYS2nJylIVakTdNtDIOIXoeEJLN9m6nIqSP+3q31O/wtJO1 GY2emUI2ceQgO0yThMb8i6muoRwjw8w9UNBi56Ug= From: Will Deacon To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] perf: arm-cmn: Fix conversion specifiers for node type Date: Thu, 1 Oct 2020 12:03:15 +0100 Message-Id: <20201001110315.18505-2-will@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201001110315.18505-1-will@kernel.org> References: <20201001110315.18505-1-will@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201001_070321_655263_870EB590 X-CRM114-Status: GOOD ( 14.59 ) X-Spam-Score: -5.2 (-----) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-5.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -5.0 RCVD_IN_DNSWL_HI RBL: Sender listed at https://www.dnswl.org/, high trust [198.145.29.99 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Will Deacon , robin.murphy@arm.com, kernel test robot Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The node type field is an enum type, so print it as a 32-bit quantity rather than as an unsigned short. Link: https://lore.kernel.org/r/202009302350.QIzfkx62-lkp@intel.com Reported-by: kernel test robot Signed-off-by: Will Deacon --- drivers/perf/arm-cmn.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/perf/arm-cmn.c b/drivers/perf/arm-cmn.c index cd4da4c5dac0..a76ff594f3ca 100644 --- a/drivers/perf/arm-cmn.c +++ b/drivers/perf/arm-cmn.c @@ -1324,7 +1324,7 @@ static void arm_cmn_init_node_info(struct arm_cmn *cmn, u32 offset, struct arm_c else level = 2; - dev_dbg(cmn->dev, "node%*c%#06hx%*ctype:%-#6hx id:%-4hd off:%#x\n", + dev_dbg(cmn->dev, "node%*c%#06hx%*ctype:%-#6x id:%-4hd off:%#x\n", (level * 2) + 1, ' ', node->id, 5 - (level * 2), ' ', node->type, node->logid, offset); } @@ -1430,7 +1430,7 @@ static int arm_cmn_discover(struct arm_cmn *cmn, unsigned int rgn_offset) break; /* Something has gone horribly wrong */ default: - dev_err(cmn->dev, "invalid device node type: 0x%hx\n", dn->type); + dev_err(cmn->dev, "invalid device node type: 0x%x\n", dn->type); return -ENODEV; } }