From patchwork Mon Oct 29 14:20:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wiebe, Wladislav (Nokia - DE/Ulm)" X-Patchwork-Id: 10659361 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 51E1B14DE for ; Mon, 29 Oct 2018 14:21:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 494C229A33 for ; Mon, 29 Oct 2018 14:21:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3D92B29A50; Mon, 29 Oct 2018 14:21:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BDE1629A4B for ; Mon, 29 Oct 2018 14:21:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=XEWHN+7EzC5Nw83XsxVEkEHenvuBiGvJqR3c7Qt7byk=; b=Z64rx6on6QuNZD tTFA00GtDn6P1NaBZFho8FFkWLsNUErs2uywJ+L/loCCK1dArKnnMTwRKxETqzoX/zUIZk+jd33sn vwU6MwgIVNNwSDgNh4ffSe1+gDKKswtnE8T9ySJiJ00FmlOOfbBwwSvxsoLDgg3XwCG7xtS/MsKyU /f7BTQSGZWDFsiK0y0Ps3H8Mco+WGvjcPNpLsdQFs80e64JX/h8sfHEzh5D+2e8lvGA8UBgr2nPM+ 6h1hn2zlfeklJJiwKCsjVxGkWT8qwuAloaoun6glPIOBwPuaE7DgQqFrmm357vg9oTELqTj29vOde Z0ijoCE/E5qGevOPHunQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH8Pn-00046v-Sh; Mon, 29 Oct 2018 14:21:11 +0000 Received: from mail-eopbgr10097.outbound.protection.outlook.com ([40.107.1.97] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH8Pk-00045O-37 for linux-arm-kernel@lists.infradead.org; Mon, 29 Oct 2018 14:21:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nokia.onmicrosoft.com; s=selector1-nokia-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=y1wqUoitqe5H3yCfLsg8y06j4SAqd1sA8i/NDyfAzPw=; b=FTSOrMy+4QDe/KaHHA6KjLJEsi96nRO87G1dAT4JaE+v/pdaBAI7CksoF7hgsUejO6GUuyi7HAsfZuq9fr4nsVga1BmurPvTzMxgLxItbCtieNYYTnHq0EtT2+gOs8+hyv3/iLTSw9+/s0RpL9+ejqJw9SJyg+CIOZZGxPspiOY= Received: from HE1PR0702MB3756.eurprd07.prod.outlook.com (52.133.7.10) by HE1PR0702MB3579.eurprd07.prod.outlook.com (52.133.6.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1294.17; Mon, 29 Oct 2018 14:20:52 +0000 Received: from HE1PR0702MB3756.eurprd07.prod.outlook.com ([fe80::4c9:7fe3:973e:77ed]) by HE1PR0702MB3756.eurprd07.prod.outlook.com ([fe80::4c9:7fe3:973e:77ed%4]) with mapi id 15.20.1294.018; Mon, 29 Oct 2018 14:20:52 +0000 From: "Wiebe, Wladislav (Nokia - DE/Ulm)" To: "linux@armlinux.org.uk" , "tony@atomide.com" , "akpm@linux-foundation.org" , "ebiederm@xmission.com" , "jrdr.linux@gmail.com" , "linux-arm-kernel@lists.infradead.org" Subject: [PATCH] arm: mm: fault: check ADFSR in case of abort Thread-Topic: [PATCH] arm: mm: fault: check ADFSR in case of abort Thread-Index: AdRvkeVP3Te0gsIRSvm4gC5lSIqMig== Date: Mon, 29 Oct 2018 14:20:51 +0000 Message-ID: Accept-Language: de-DE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=wladislav.wiebe@nokia.com; x-originating-ip: [131.228.32.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; HE1PR0702MB3579; 6:aEaTnpx5RXQOumdaWJWgcywbX6G+rpRUeYwzHz42OFpfA69PiQaxpKdqEGO2y/JdghV+rkKl4Q1ccHFZlkZ+ajQ+V5MiYRcWkVwPvDHPMZ6wOsklUZy1Ht6H3ytmzRv8ABTX2ZAwK2i6M1MEFMWGYkNnj9PVaB1acs0uFhbW0+4StSePaNIo5dZRdxWq8DQLIYXMytNUdLN025C9muW+4LVrRt8nbnlDY8FsxZgSfpTRropGC8+usbkrYTU7S3XRvDG6v5x5Fz7mFxWsi45BryE0fAvfu6Jre2OvZmPUilk9G5BuK0Asdis/kksncs53SB3/VjsFRBzbQ4MwB3N0hdFOE0XLYKEmi5r/9E1xxiFyvrjv7gRgHbvhdPafmxOrhuvYhaomRXvv5yI5NvUIQQSFiLtmN7ZP+7E5S5hHy8OXD73OsJ5BrVIvoX6yTo+5XOmoiFvphiu7VT3CPJqDkQ==; 5:aZYkaeQ8I56i/123veiUY45r7JVRrES3Nv4+Tuflx+50lksLBb6Ew4/4oe7pZqCdggOpgywSl2zHAZ8w9aQyvR69B9hnm7CVCxqRh3r6lUEbVNZ0dvfl0V22wWAaaCJ9O2o5UHDIic85SPQQL9TVxWnXyy9r7Al9fzXiC5uBtOI=; 7:pS9PcwUtm7UUsFGfdR7fgtnW91K21JwGkh0jKu0b1lHdvZN2ZKpiLN2rIR/qsUFrTezMkJHopoWv5JxkH/gvvxSUOZpfbyuETxOqUDAK+X1u4uB8uj9OLBM2+n5uInmUAngHiA/qsjFSOPWHRaJUBA== x-ms-exchange-antispam-srfa-diagnostics: SOS; x-ms-office365-filtering-correlation-id: 02957ae0-2b32-4079-9ef4-08d63da9bb4f x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7193020); SRVR:HE1PR0702MB3579; x-ms-traffictypediagnostic: HE1PR0702MB3579: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(82608151540597)(109105607167333)(195916259791689); x-ms-exchange-senderadcheck: 1 x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(11241501184)(806099)(944501410)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:HE1PR0702MB3579; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0702MB3579; x-forefront-prvs: 084080FC15 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(346002)(376002)(136003)(366004)(39860400002)(189003)(199004)(110136005)(55016002)(6436002)(6506007)(9686003)(316002)(105586002)(14454004)(2900100001)(2201001)(102836004)(68736007)(86362001)(53936002)(106356001)(478600001)(3846002)(6116002)(26005)(256004)(186003)(39060400002)(5250100002)(7736002)(305945005)(74316002)(2501003)(66066001)(7696005)(25786009)(4326008)(1857600001)(71200400001)(71190400001)(99286004)(97736004)(8936002)(5660300001)(2906002)(486006)(81166006)(81156014)(33656002)(476003)(8676002); DIR:OUT; SFP:1102; SCL:1; SRVR:HE1PR0702MB3579; H:HE1PR0702MB3756.eurprd07.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nokia.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: B8craZCEp6XmBHyvAm7VouiA5NBIrffT3EsffLW4cwydOiq0gtKKFqzjO0yxOtb/pY9QN5FRusJMZdJ7bJvsOwvjF7pUnu4PPXKPj0rAbI8qdKYeRpaMokWVWsJxBhnl/IdSlabome6ABuVPSzblHdB8EmGCUpNhPG8ihvuEbcak9u1T0O1t0Jhq6WYI07SHyvJ5+KHX18cWl7X1DPvRu9gyq7vEgh/U9adf/bUl7fsvHpgll5CI70S03/WHuQnc2F1Dqk81VTVeKaevtoLG7gI6AbgnmrpvIQ9xXS5M7vhxntV5jj2ZYdXoFnPPe74m6MIhBZ/xxdQNJJs7E353MzU6Ixk1K4e3Ea9wFsJUYKN/0nADK2Cz+0xRmze8tbF0ZJQv3TeIwqum2rTC6YA7Og== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nokia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02957ae0-2b32-4079-9ef4-08d63da9bb4f X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2018 14:20:51.9891 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5d471751-9675-428d-917b-70f44f9630b0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0702MB3579 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181029_072108_136700_29C0FD6F X-CRM114-Status: GOOD ( 11.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-kernel@vger.kernel.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP When running into situations like: "Unhandled fault: synchronous external abort (0x210) at 0xXXX" or "Unhandled prefetch abort: synchronous external abort (0x210) at 0xXXX" it is useful to know the content of ADFSR (Auxiliary Data Fault Status Register) to indicate an ECC double-bit error in L1 or L2 cache. Refer to: Cortex-A15 Technical Reference Manual, Revision: r2p1 [6.4.8. Error Correction Code] Signed-off-by: Wladislav Wiebe --- arch/arm/mm/fault.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/mm/fault.c b/arch/arm/mm/fault.c index 3232afb6fdc0..5e240deb6ed6 100644 --- a/arch/arm/mm/fault.c +++ b/arch/arm/mm/fault.c @@ -547,6 +547,22 @@ hook_fault_code(int nr, int (*fn)(unsigned long, unsigned int, struct pt_regs *) fsr_info[nr].name = name; } +/* + * Check for ECC double-bit errors in Auxiliary Data Fault Status Register + */ +static void check_adfsr_for_ecc(void) +{ + u32 adfsr = 0; + + asm("mrc p15, 0, %0, c5, c1, 0" : "=r" (adfsr)); + + if (adfsr & (BIT(31) | BIT(23))) { + pr_alert("ADFSR status 0x%x indicates that an L1 or L2 cache\n" + "ECC double-bit error occurred at some time.\n", + adfsr); + } +} + /* * Dispatch a data abort to the relevant handler. */ @@ -559,6 +575,7 @@ do_DataAbort(unsigned long addr, unsigned int fsr, struct pt_regs *regs) if (!inf->fn(addr, fsr & ~FSR_LNX_PF, regs)) return; + check_adfsr_for_ecc(); pr_alert("Unhandled fault: %s (0x%03x) at 0x%08lx\n", inf->name, fsr, addr); show_pte(current->mm, addr); @@ -593,6 +610,7 @@ do_PrefetchAbort(unsigned long addr, unsigned int ifsr, struct pt_regs *regs) if (!inf->fn(addr, ifsr | FSR_LNX_PF, regs)) return; + check_adfsr_for_ecc(); pr_alert("Unhandled prefetch abort: %s (0x%03x) at 0x%08lx\n", inf->name, ifsr, addr);