From patchwork Mon Oct 29 15:13:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10659383 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4155413B5 for ; Mon, 29 Oct 2018 15:14:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 531981FFB7 for ; Mon, 29 Oct 2018 15:14:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4768428FAF; Mon, 29 Oct 2018 15:14:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B0EF11FFB7 for ; Mon, 29 Oct 2018 15:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=xEuc3LBWUzOuw/nsi/Wj6l9Tf/snvaL4Utp0WdHn5lI=; b=GeBddsg6CFT4Z5QFF95CbjgNNf eO1SPLPblIpJ+MM1AgRCnVn59GJ8yEuZQu66A2Sj95uM5o/S5/2N2xCDV5aUSU9FVVYptl/bijOrM IiZpJNqLtGjclMJT+P/yd1IXVtBwCUaahfALz1WoudQT84oFuR4DeIbpwGP33RMtR26ROKWWzUvhg VHhM0eQlCvaKB0axRTBccGNrv13qlyO7APN/9Kkw0ViHvQbtb53gDb1DxRvNLsn9WF1VBuWBFfmz9 nU4ogDOwQUYNu6pkmE/iff4801WSsHMgFr8KcIBNj4mKDq2ZyhTz6PDvPyzahHHS43bYjZuQt/m4r 31wAJU3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9FC-000358-AT; Mon, 29 Oct 2018 15:14:18 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9Ev-0002tn-B3 for linux-amlogic@lists.infradead.org; Mon, 29 Oct 2018 15:14:13 +0000 Received: by mail-wm1-x343.google.com with SMTP id y144-v6so8304155wmd.4 for ; Mon, 29 Oct 2018 08:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=0VhoeL3UY49i/r3Uv5WwXcxN1BcTVCznhsZ8wfU4g58=; b=NeyZUXmZYPFiamyJy6Mextlt3eCUJIYenp2CHMQKIgEXft/niJoHz9VXJJdo45FonJ aQriVAdzwbwyq9mC017f8lD1+7DB3rjeiqvzefsxWjhGXz2sMde4SjxciB5S0vOwdA7l Oq90rjuVlHSWrkxOC7sXyRJMZvsBBGMxxuVrvn2/S/QLPlu0Ud89PeBQy6oex4pYLbwI P9IqSsZw2Wd1CZUnPj4HRwoh9ZJiWpED39k/PnTbH/a90NsMovjtFm0xmE7LoPiM1+Al W4jDyOrVlQhyM2rTx3PHV9CaukjE7pTlqBdnAwPwIH5rt96T+1c/39cOKODfQyIxUZ+b cVDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=0VhoeL3UY49i/r3Uv5WwXcxN1BcTVCznhsZ8wfU4g58=; b=ejZMus4ZZegMLk6AiOlALchZpkq721mH93GIywALLGiw5BARefKSgvL/Fnfx46pr6g wDoxiuqkGmjTYTNM9OnhRANVI4meJNEMR7V3ZW27KOAEDPdyt9PYYMEX/roQltRjnV6H 5TSTBJhCMiBw6mpBJVPUI6JIWkAH1UE18oTC1xtbPJaqF2+VPh2tmrCny0qfUy9NSsAq x70uFWi2Thv9fLxW9XpaHZKiGKDvTbXR44uXmuKhgOpuPLGanVu0n/Nyk9P3da7T4wt0 0BYEKXFS3pMPYe66rEJMrjam8o+5dwneO4x1mhk1wbHotXuRJT92PkPR0qm7DsI93H7A g5ew== X-Gm-Message-State: AGRZ1gLUw/a/a6eX4CJeXv4tTK3WppZOiyfsIJoKM6eHz7jdGSlg+0+l TzaOQME0/a6wm1J9zX1ZEWY62A== X-Google-Smtp-Source: AJdET5cwELqT9reYQwEgf0ThUPiFZrEp5casMhPyLDohV6RBhutmn5tcLMdUSQ4+jU8EZRKvJl2KZw== X-Received: by 2002:a1c:f514:: with SMTP id t20-v6mr14245688wmh.129.1540826029381; Mon, 29 Oct 2018 08:13:49 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i7-v6sm23045236wmd.41.2018.10.29.08.13.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 08:13:48 -0700 (PDT) From: Jerome Brunet To: Linus Walleij , Kevin Hilman , Carlo Caione , Martin Blumenstingl Subject: [PATCH 1/4] pinctrl: meson: fix gxbb ao pull register bits Date: Mon, 29 Oct 2018 16:13:37 +0100 Message-Id: <20181029151340.9087-2-jbrunet@baylibre.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181029151340.9087-1-jbrunet@baylibre.com> References: <20181029151340.9087-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181029_081401_431997_32459D59 X-CRM114-Status: GOOD ( 12.45 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP AO pull register definition is inverted between pull (up/down) and pull enable. Fixing this allows to properly apply bias setting through pinconf Fixes: 468c234f9ed7 ("pinctrl: amlogic: Add support for Amlogic Meson GXBB SoC") Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson-gxbb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c index 4ceb06f8a33c..4edeb4cae72a 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxbb.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxbb.c @@ -830,7 +830,7 @@ static struct meson_bank meson_gxbb_periphs_banks[] = { static struct meson_bank meson_gxbb_aobus_banks[] = { /* name first last irq pullen pull dir out in */ - BANK("AO", GPIOAO_0, GPIOAO_13, 0, 13, 0, 0, 0, 16, 0, 0, 0, 16, 1, 0), + BANK("AO", GPIOAO_0, GPIOAO_13, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), }; static struct meson_pinctrl_data meson_gxbb_periphs_pinctrl_data = { From patchwork Mon Oct 29 15:13:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10659385 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CB3A213BF for ; Mon, 29 Oct 2018 15:14:29 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DB4B81FFB7 for ; Mon, 29 Oct 2018 15:14:29 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CEF2329657; Mon, 29 Oct 2018 15:14:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 84F261FFB7 for ; Mon, 29 Oct 2018 15:14:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=OvxfQlRe2/iTs0vMGNvnoDYjrwENmGp8P0IAgAsoLlo=; b=K3RBOHicV4Pk68RCmp6ySDQ48Z kgsrqsNTrnuXBRy9XFFHF0QiwDUDgB/be68dMklifozJVwLBPQ/f/IaCI0ZPwQQiBdquGkL9wn/pQ G4rm/nn91qXr+7xNl2oOPL2lpja1Z8hNDbivNSBUBEFBbmvUCTdrcw7h3NzOig/DV00lRHRPkkjZf F6UXrBFpneCT+JmpVT/Xmdk46d+RraV/Rq2at7Ozo7loltQ6KzB9bTrva0c6G8KNvlas92E6KeUnh Ys8Ai1WLzW8iB1qOfk/CaDMskFPx9ytHMs+4aQR6AUQ0lSkc4u206CHtyVwj/TCDqW6WiE7UdQkBT MHz8nV5g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9FK-00038L-Bh; Mon, 29 Oct 2018 15:14:26 +0000 Received: from mail-wr1-x443.google.com ([2a00:1450:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9Ew-0002uT-5B for linux-amlogic@lists.infradead.org; Mon, 29 Oct 2018 15:14:19 +0000 Received: by mail-wr1-x443.google.com with SMTP id y15-v6so9103830wru.9 for ; Mon, 29 Oct 2018 08:13:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HfflCg4Qw2FH+NwxmZyMZZXnm57vofYP5WlUFbknjj8=; b=2Kl2Bn9NujwQpKNbw7DfIxMlvbMG9fBRtqSZnbdrT7BoE5yn7yTzJeUZKQsuTJ4/2s QUPluiVND7IxBWEw4NP7PGTvzx+WoKjSJg44tN4sKuXi92v/5H/89j1S3I+vbyF/EGwO LwGVXpbij2HCrkuxJNviNjJdWRaBLDAzwfV28XHyh35qDXErbR14NQmGBcZEqLYT0/BH cVmidWDQScn6wKoIGqWJ+LEoOHF8Ir/AsTXld8H+EHOIKbsd7mAQnDxAJCWN81roTKCT PegaAvfPceoTQuRrEUAB7s0Si/koM4igUln6zx9XdLtJ1UuFpBUdOsu82rTscGnyJHGe x0nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HfflCg4Qw2FH+NwxmZyMZZXnm57vofYP5WlUFbknjj8=; b=X9JaZ+wQcO2phYwJgAgxooSU3wP8TT8iHAerQzWs+hG/uT1zj0gQEyPiqZn3Mp5z42 V5a1CwaL2TGPIJsuAT2ahAS38OtknBq9tCrQnlEB5cQ5GLJ9N80MymQf4ATFPPZuJn79 rVRHFk9p+pQZEkDLDsfgBQ/e36eWd0sUwHXI+/G0QCvY+XnL6UH/CNjT48B5EkskEC7X IWivKuUZXSbwXsa4HRAjNDtfNpRVor6tyqzw+9Qt8wUWFn23438nECyxaIEz1MV2aJCl pkHNS9HfhaEayHtNe5CZuZAqwZRTQVO1/s8BTh8EwkBUDcWLcr1m1HGVNNXqK6u5ry3r t5fQ== X-Gm-Message-State: AGRZ1gKkgc74xW6j9R4HcrnvZibVf9PG0xzlz3B9hzauT3rDMfTQ4yQr D0XTKHbh2C8FtGXFRJ+qyPXNHg== X-Google-Smtp-Source: AJdET5dRVW71Oicyk68QJm76/Y+3LIrPu5i2N5R6LgMN/PsGcUMPWi0ZP0hhQsMKHPu/rqboItgEGg== X-Received: by 2002:adf:92e6:: with SMTP id 93-v6mr15731892wrn.124.1540826030373; Mon, 29 Oct 2018 08:13:50 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i7-v6sm23045236wmd.41.2018.10.29.08.13.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 08:13:49 -0700 (PDT) From: Jerome Brunet To: Linus Walleij , Kevin Hilman , Carlo Caione , Martin Blumenstingl Subject: [PATCH 2/4] pinctrl: meson: fix gxl ao pull register bits Date: Mon, 29 Oct 2018 16:13:38 +0100 Message-Id: <20181029151340.9087-3-jbrunet@baylibre.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181029151340.9087-1-jbrunet@baylibre.com> References: <20181029151340.9087-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181029_081402_231122_AD61473A X-CRM114-Status: GOOD ( 12.02 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP AO pull register definition is inverted between pull (up/down) and pull enable. Fixing this allows to properly apply bias setting through pinconf Fixes: 0f15f500ff2c ("pinctrl: meson: Add GXL pinctrl definitions") Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson-gxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson-gxl.c b/drivers/pinctrl/meson/pinctrl-meson-gxl.c index 7dae1d7bf6b0..158f618f1695 100644 --- a/drivers/pinctrl/meson/pinctrl-meson-gxl.c +++ b/drivers/pinctrl/meson/pinctrl-meson-gxl.c @@ -807,7 +807,7 @@ static struct meson_bank meson_gxl_periphs_banks[] = { static struct meson_bank meson_gxl_aobus_banks[] = { /* name first last irq pullen pull dir out in */ - BANK("AO", GPIOAO_0, GPIOAO_9, 0, 9, 0, 0, 0, 16, 0, 0, 0, 16, 1, 0), + BANK("AO", GPIOAO_0, GPIOAO_9, 0, 9, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), }; static struct meson_pinctrl_data meson_gxl_periphs_pinctrl_data = { From patchwork Mon Oct 29 15:13:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10659387 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2600213B5 for ; Mon, 29 Oct 2018 15:14:37 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 373551FFB7 for ; Mon, 29 Oct 2018 15:14:37 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B86828FAF; Mon, 29 Oct 2018 15:14:37 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D6ECF1FFB7 for ; Mon, 29 Oct 2018 15:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=eZHWkIz117ybVggKQrKlWZcINcepha7iFh39T2rJvKM=; b=XcVEhoGXGpcVmycs3LMyNFpREB aJZ0WmeTZmN8MODl4I5T7CS/UYnwuxzcvWWPoRRxJ1H4cgFJJ1JNA+Psz+vuypeN77LgweRaiumX0 VQofXFj3rAjx6IaFVO9jEPvnbAQULXBkvkQsQWW+lDDiiFrGaenc0nVw582NYkbO5GSkLNgKfR27t 6bpS5+JGvQxcQBQ+AX4kOlwAl/Jxi4ODhIM/HG0fqfp16ZWZIT7YOHSusdupNZxcM/dGpSGITo+um FPSurk32u+m0+53CgOzKnP6hhIvBU1vb/e+aJWRK58VhwlOpv9mnRFN5VYh5LaRrjSjmQJcjHHCUl fVzE9dAg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9FQ-0003AG-E3; Mon, 29 Oct 2018 15:14:32 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9Ex-0002v9-7b for linux-amlogic@lists.infradead.org; Mon, 29 Oct 2018 15:14:26 +0000 Received: by mail-wr1-x444.google.com with SMTP id x12-v6so9095290wrw.8 for ; Mon, 29 Oct 2018 08:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IVKNCElcTw4O7+BsXJj7w6a+UoV8WRTsqsukzgsta1A=; b=Mg+p9GQ5lAvK9A4y6No9a/ymvvVUBXtA3cpfZVbKj82N5hzU0OQcTMeSs0GhMm3xeE mWOHClwKFhq8wNox68iXnxAEJYsJxMFoIfWLY4uwOEnOCejNILnD7gWYxN3kgW5htqCA MrOtMDLiO7CJgvgQyOSHSfCbSirCWTbB7N4FVlNS7f8QX05aBunaHsd1efMB8uMkCpyh DmmHRaixUP/Dxm4feejY8Amte7gMaO1d6CBZDkb3D5ysQxcfR0zw95cW3ASX4vr3B+2U acT099QeBUY+XSF2tQlu6wpz1twyP30XhW+GtcB9xgGJa6MEBHWH/WAjqIFCbmezawJ9 4NCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IVKNCElcTw4O7+BsXJj7w6a+UoV8WRTsqsukzgsta1A=; b=Xmi8LA5Pf2619LSxFuhP9wdckmqR2a66TFXBbjlkDwZpmsF2Jti5PD2JhygTc2ct8S gDk6wTs9uFowsQEDxUNur85QnPAqh/5QRJT0PtlaN+PI8OVsYN7m3gHAEQExBbcthsdc AX7RwhVS8lRrrZO7jGHeG4vvVaa+cAVMdWSJVDzX4fcKYMh84pqWvnX4zS9Soih6VB0o ChEJCvNueHY5AODPrrEbOZRUm39ZOG+ZlEi+R81hhrCS0o1sE/3avN/PIgHGkK1QiVF6 tmCYsza+LL4m/+ISGkjI3N1ekS1TWiPwc8vuug8DOdpWVjUWYnZ2/ZHnPWlbLDOi5Hk7 t8gw== X-Gm-Message-State: AGRZ1gLHfs0bRGb6tZwlVVIJAEZwSua5eKKzTmQIrhimf9rjOM8oFu/r tMxLZAHdCDbUdGz41QIW3LXDxzD8CYQ= X-Google-Smtp-Source: AJdET5fLzHpcK+2A+4mFLgf+Wm+tfRHGE/RLD6/RtL2yhacmXoHF5pt+cAnexoLfunULXtTSpGKRCA== X-Received: by 2002:a5d:51cb:: with SMTP id n11-v6mr3931700wrv.121.1540826031334; Mon, 29 Oct 2018 08:13:51 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i7-v6sm23045236wmd.41.2018.10.29.08.13.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 08:13:50 -0700 (PDT) From: Jerome Brunet To: Linus Walleij , Kevin Hilman , Carlo Caione , Martin Blumenstingl Subject: [PATCH 3/4] pinctrl: meson: fix meson8 ao pull register bits Date: Mon, 29 Oct 2018 16:13:39 +0100 Message-Id: <20181029151340.9087-4-jbrunet@baylibre.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181029151340.9087-1-jbrunet@baylibre.com> References: <20181029151340.9087-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181029_081403_322742_8E3A5AAC X-CRM114-Status: GOOD ( 12.43 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP AO pull register definition is inverted between pull (up/down) and pull enable. Fixing this allows to properly apply bias setting through pinconf Fixes: 6ac730951104 ("pinctrl: add driver for Amlogic Meson SoCs") Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson8.c b/drivers/pinctrl/meson/pinctrl-meson8.c index c6d79315218f..86466173114d 100644 --- a/drivers/pinctrl/meson/pinctrl-meson8.c +++ b/drivers/pinctrl/meson/pinctrl-meson8.c @@ -1053,7 +1053,7 @@ static struct meson_bank meson8_cbus_banks[] = { static struct meson_bank meson8_aobus_banks[] = { /* name first last irq pullen pull dir out in */ - BANK("AO", GPIOAO_0, GPIO_TEST_N, 0, 13, 0, 0, 0, 16, 0, 0, 0, 16, 1, 0), + BANK("AO", GPIOAO_0, GPIO_TEST_N, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), }; static struct meson_pinctrl_data meson8_cbus_pinctrl_data = { From patchwork Mon Oct 29 15:13:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jerome Brunet X-Patchwork-Id: 10659389 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 58D3013B5 for ; Mon, 29 Oct 2018 15:14:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 69BFE1FFB7 for ; Mon, 29 Oct 2018 15:14:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5E4D228FAF; Mon, 29 Oct 2018 15:14:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1AE371FFB7 for ; Mon, 29 Oct 2018 15:14:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=sD8PpjUiESoVrwdk3evLfPttv53nsZkKQc0rkUXG15w=; b=Q6Yff2cT+EYyOkGay5mmhmswJZ y3xr1ziurky8oNvwxOusvlD6a/JeQJz9m8SoqrG0PcgvRY/dGB33Rb5lI2GbZnacLp1uvgkurqpaZ uJzoTvfxQlZgsVM8yzsOLhPcbM4J8fDhJd8JcvxA4QIbPyhT5ArKQHpeDTRNkIFSBmywJ7N5GIjSv dHfxZg9FfzHZyhjePrOjzg5SkseNthdCPJj2/op1oUNtLdn48ZmE2Vk/AN6WRtQSCuQ39xuNRKezh DWyF1gme/Qed8oPFeBC+OrJURUl6j13gX1PCE92EXdluG3Rgdm/g4b9FNMjbOdF+q208aWCWC8riI B2n7ah0Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9Fc-0003ET-S8; Mon, 29 Oct 2018 15:14:44 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gH9Ey-0002vs-Ir for linux-amlogic@lists.infradead.org; Mon, 29 Oct 2018 15:14:41 +0000 Received: by mail-wr1-x442.google.com with SMTP id l6-v6so9122567wrt.1 for ; Mon, 29 Oct 2018 08:13:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4iCWujpwciyPGn/eyek7MRdxupz7S9P7JrT19wMcw9Y=; b=pgBFw7/KkVdREpcWrMHeYc6+YXXzwN+8mYGhNqfkbpPU9ZakIjpVeBcIvbedCtD4M0 Lzg1jukcW81QbLb47RHp6xA/ItvcPKyDkpl45nswuqru3348F4GWvQkhiafHESKBLoUJ f5s47y3/VnQl9RCf+Vb+55i70SESdP/fZqwM7u9ylm1tiGN0b+1QKsElH01VpVogVnHO zEB5b1QTzDWrPdK6zcCrR6C3IFobqAfV35bdt7rmuqorIDwQ88QuZTdoCC0rxLCPeYBj QSULIyNbUQ7rFq4malSZ78I2M3RXE3esrF0M1XMelcwht4XXDT8iZfthf8prXQ57QNv7 RJSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4iCWujpwciyPGn/eyek7MRdxupz7S9P7JrT19wMcw9Y=; b=DyJ3Vm5Fm3C3WIXy1k3vmUyDZasXm53AbwmxCsik4uyW6zZZVEU/fnKbWxN9g5tpZR xWhYZI+Wo5+sTs4+TPdjS6tmFS3qfLJpIqbEOlfnSrjnoFMK/yrYusmcwMjyJGxie18R VsLVYtMcuUshOtuvGJJhuRj2q7IeQfoSGzP/N8PiAlnKGySArl14x+/XAg4NWSVFTqpg UyYNmRIKf0LtgYP0Kq29qxODi/JiCrLsah/35UvFx34ASKKxMLtR4dTqzpobtPLPrnmp e4+44Egutx/yeqhbRxfgE1t9X8f/ZZvZoL03000ZBWPP4p/5p671jTW7X7JUUoVhBSLo vgOw== X-Gm-Message-State: AGRZ1gJR+68KYzGyU2j4vvId3VwVPxhQivtUQXx71BFsGViDioPn/jtp kUA/ZoNpOznwSP/EVVZpKKjFwoN2oGI= X-Google-Smtp-Source: AJdET5cMDfspKkgE/rZOcyFre3G2rKV3Z5u93C5yA/yPl6i0LE0/2ebLygB6T4AZ/5//DoI35CjuVg== X-Received: by 2002:adf:b211:: with SMTP id u17-v6mr14063772wra.52.1540826032557; Mon, 29 Oct 2018 08:13:52 -0700 (PDT) Received: from boomer.baylibre.local ([90.63.244.31]) by smtp.googlemail.com with ESMTPSA id i7-v6sm23045236wmd.41.2018.10.29.08.13.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 08:13:51 -0700 (PDT) From: Jerome Brunet To: Linus Walleij , Kevin Hilman , Carlo Caione , Martin Blumenstingl Subject: [PATCH 4/4] pinctrl: meson: fix meson8b ao pull register bits Date: Mon, 29 Oct 2018 16:13:40 +0100 Message-Id: <20181029151340.9087-5-jbrunet@baylibre.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20181029151340.9087-1-jbrunet@baylibre.com> References: <20181029151340.9087-1-jbrunet@baylibre.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181029_081404_669536_03D8D57D X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-gpio@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Jerome Brunet MIME-Version: 1.0 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP AO pull register definition is inverted between pull (up/down) and pull enable. Fixing this allows to properly apply bias setting through pinconf Fixes: 0fefcb6876d0 ("pinctrl: Add support for Meson8b") Signed-off-by: Jerome Brunet --- drivers/pinctrl/meson/pinctrl-meson8b.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c index bb2a30964fc6..647ad15d5c3c 100644 --- a/drivers/pinctrl/meson/pinctrl-meson8b.c +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c @@ -906,7 +906,7 @@ static struct meson_bank meson8b_cbus_banks[] = { static struct meson_bank meson8b_aobus_banks[] = { /* name first lastc irq pullen pull dir out in */ - BANK("AO", GPIOAO_0, GPIO_TEST_N, 0, 13, 0, 0, 0, 16, 0, 0, 0, 16, 1, 0), + BANK("AO", GPIOAO_0, GPIO_TEST_N, 0, 13, 0, 16, 0, 0, 0, 0, 0, 16, 1, 0), }; static struct meson_pinctrl_data meson8b_cbus_pinctrl_data = {