From patchwork Thu Oct 8 14:37:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 11823117 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2F91D14D5 for ; Thu, 8 Oct 2020 14:40:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E01BC21789 for ; Thu, 8 Oct 2020 14:40:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RPfD6aui"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GidDfEuG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E01BC21789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=8tc3a9jgIIgnW4InVqpIOtV2WHWNVXvSdqkZuz2Muew=; b=RPfD6auivV3hBhJsG4t1jbqVt9 bUXqK9IL5ycHm1Rp/l+eys4TyWezNJuScqUiPQ3EqBGaDANCqb1ofQ3DAVro/nOiZN/cdebocmJP6 LB+GV+OFzVuQR9PrhzgFWpMHQWOpphgeCsdP3YYgtIL+/nzX3vk/vMQmmE5n81HW3YFo8nabux4Rq wuECtMHze+BEcLvv4DfF9279cOMDAEglwHzwA5MKpLZxWjQhuxduTiu4EMbIVz/i6xbSkWLf28BIb JDyvlLgYZCsNHK3iwLgclm13pdTIGD+nryRYG93Dk/1jOpcgj8xNCnJCoKbB58ZdSzeUO3IAnVSYT fJ5kJLuQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX49-00006u-3F; Thu, 08 Oct 2020 14:38:45 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX46-00005n-97 for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 14:38:43 +0000 Received: by mail-wr1-x441.google.com with SMTP id e18so6873668wrw.9 for ; Thu, 08 Oct 2020 07:38:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=FB6oiqekxD6KQBOtL25AGTNlxj+owP0Z0d2XXT3CycU=; b=GidDfEuGMf0x3IVybYbsOdgEd2GBGFjOPiSoKOkDqPEEEswCD/uG4ZSPvdKOpsSRxh /I1cdDuDGudQhCVcqZO0KsXYDy4XELuJFg0702rdLRY+dtloRfVM0bZ9LikTfx4F7Eg0 KAM+7KANP9Jp19igWILZAuLdvMQiyPAjpuXuJeODcCBHhjn3oC88bHPdMTrOq6uALtCE 6EK0NyJedgiLZqVodlpMMb4h3ha+lncFJK0hav9SsYlBeD0QDW+w4+EIwHvZeH+digG+ I3NuWcd9hCf3doEjXkMLCHNiD9AUixRIfPum2DvtH2dnCOqUVwN4j0dSTK+hEStqPCm2 KuIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FB6oiqekxD6KQBOtL25AGTNlxj+owP0Z0d2XXT3CycU=; b=gCF0HqJM8j9sO+/lgEaIke+5dFu20uMXZ/GJQjin0KMCJF4o/oVAVMRs4Vid/VVnmi 2ApXVU6PGlEJJE2Jr2cg7ioRcnST8M1D9hVqU5X1hQlAkBqQpN/IwqYoqYP09j5B2b/I U44amodJ/jmeg2Br7KPZFy20Uc7rANcjV9IMVNP4+5XxPxQf7qFjaVj+1oL/8Z20nDPx /js331FWok15sPbbwMSbgpibgz6uXqx/7sqBJNHAQwmob9OkUjM+TtkWtAJBn6wm8ilF hQVM81qG9HYrEdogQdvdL+LxogfN3YvZSocG41k/+be9uOpqse5Ihvg9Al06zdQTledj XNSQ== X-Gm-Message-State: AOAM533QTaVs92sauQ9kJd12waeJzFX6a/lvbl+HEEoMU0BooD6zET3z w/ar/WnMd3G7lYmdQtUya4o8ng== X-Google-Smtp-Source: ABdhPJwirUND1gx/xJWlOO2u3TXTwZvVIJX+XwyFjfELnyCZmUPsWbjhW2AU97TzEb6o9wp12Uv10A== X-Received: by 2002:a5d:424e:: with SMTP id s14mr10597990wrr.149.1602167920912; Thu, 08 Oct 2020 07:38:40 -0700 (PDT) Received: from lmecxl0524.lme.st.com ([2a04:cec0:11c8:908d:6533:9100:d943:8b22]) by smtp.gmail.com with ESMTPSA id y14sm6926942wma.48.2020.10.08.07.38.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 07:38:40 -0700 (PDT) From: Etienne Carriere To: linux-kernel@vger.kernel.org Subject: [PATCH 1/5] firmware: arm_scmi: always initialize protocols Date: Thu, 8 Oct 2020 16:37:18 +0200 Message-Id: <20201008143722.21888-1-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_103842_360378_253B5EF2 X-CRM114-Status: GOOD ( 12.66 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Souvik Chakravarty , linux-arm-kernel@lists.infradead.org, Sudeep Holla , Vincent Guittot , Etienne Carriere , Cristian Marussi MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Remove the IDR replacement that prevent initializing an SCMI protocol when it has already been initialized. This is needed when there are several SCMI agents that do implement a given SCMI protocol unless what only the related SCMI protocol communication is initialized only for first probed agent. Signed-off-by: Etienne Carriere --- drivers/firmware/arm_scmi/bus.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/firmware/arm_scmi/bus.c b/drivers/firmware/arm_scmi/bus.c index 1377ec76a45d..8ea04b069129 100644 --- a/drivers/firmware/arm_scmi/bus.c +++ b/drivers/firmware/arm_scmi/bus.c @@ -60,11 +60,6 @@ static int scmi_protocol_init(int protocol_id, struct scmi_handle *handle) return fn(handle); } -static int scmi_protocol_dummy_init(struct scmi_handle *handle) -{ - return 0; -} - static int scmi_dev_probe(struct device *dev) { struct scmi_driver *scmi_drv = to_scmi_driver(dev->driver); @@ -83,10 +78,6 @@ static int scmi_dev_probe(struct device *dev) if (ret) return ret; - /* Skip protocol initialisation for additional devices */ - idr_replace(&scmi_protocols, &scmi_protocol_dummy_init, - scmi_dev->protocol_id); - return scmi_drv->probe(scmi_dev); } From patchwork Thu Oct 8 14:37:19 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 11823111 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 855FC14D5 for ; Thu, 8 Oct 2020 14:39:05 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B29421974 for ; Thu, 8 Oct 2020 14:39:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0BiDpTUR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UMIv7thr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B29421974 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tshuXngTAUmNl3HYktS4O9pmrzQaN1rqU7EEEOoVqgU=; b=0BiDpTURI0B4nrMOTPk84/5NAH CV4Jgb54W8cGO0KyKxIxmNJnXv9pSuNYru76e52IE4AXoJ1+Vz00ZD7MuWn1zMKM94fZuqcFVLxzO l3It4iACq0yQVtqp9x3iIGa4/mXQu8JXHn8p5DVZUd7v/pZBCH/HoOuRZ2gOI0TwDaZRlcNwg3GGh 9FPMkdC8WNOfQD6djWTNGgFph9y6VFuTZdQZbaP+tSHYkHKFoXIpZKO9/svSXN14bit2zCYOIwqBf bzXuak0de05YHKKFT9cWarHrnQNfGnjSRVDjO2kyNCVkOVutfOw7HqMlrmRz0VtViBDYz4IlEdtqY xthh4F+Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX4B-000088-Sp; Thu, 08 Oct 2020 14:38:47 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX46-00005t-Sc for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 14:38:43 +0000 Received: by mail-wm1-x341.google.com with SMTP id q5so6771290wmq.0 for ; Thu, 08 Oct 2020 07:38:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=D+9J/HNIjhjYiMOlJN5FLKO8xUVilMJPpBLCBZbGWLw=; b=UMIv7thr4BJdqGPaaDxbj0L5JfqV94gw26TUdeeoEdsuDXaBmIO255ZX0YboaE+xHJ FvokadyGOOTDiVLwu78QN++GEmauP0HHBRN9x2hP3k0PWX4p8XklfbICE4jWIMvhpOKU /KSZAaWlMfz3y3Pcf0Qs451JurQqIFbds4etRxXChNl1oL4WuIu/I0UTciUZ8temcOA/ Sn02bcEnkqBjV9MRvpUS23OgjbkDq0y+dIpRYR50X77jNk25NNXhyAaejXu8bVMaJFQv obUQr47YMd+zKjHLcnd+fnR/ifsxymAHbeOy74d6PTLQK38nLR4//al4qtN3QOphZNKO lYQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=D+9J/HNIjhjYiMOlJN5FLKO8xUVilMJPpBLCBZbGWLw=; b=RTjGs/IpiLHw7lzXA5ljFUBlVc7H8gamxBosNJi428QRyWLG9e7B9FfAPWgFxXQ6Bo Adh11VhHn9WvMcci4CQYVoDKCXXzKYpxSZTerJzCd+N0PsBavJaHL6ezEC90z6TlR7Y1 4HJoaWG12Ex/vj3ExauTAkkjDR6YnlNXh47b+Kb3e6n0sLeHspfOJcWDYJW1+siUTdWL XZN+QFcIf5FpIPrTNcZCRVlgj3V9Qh0LtI4kGa3ZMdG/9xnu1Ua7+q1SRAfgYC2aWML1 Cct/8zwKBhBa+MA/e1TdzlI0VA8los48xKczoBAkRJi12R3sWrDaIr2SjNCy8/Fdy8HZ Fxaw== X-Gm-Message-State: AOAM532JWhDQiiQZ+qPwdtfa/CQcFegYLbRlac+uBf4o/1eH++eoqyQQ ab23K1fQ4Q169XXHw8KSX3H7YA== X-Google-Smtp-Source: ABdhPJzKkZD13r1AHLAaKgwoB0i221mwt28cGazWbJRZz/jY0hD+8bq6hEB2H4HDDpiro84/lG9EFA== X-Received: by 2002:a7b:c0d8:: with SMTP id s24mr8985143wmh.156.1602167921940; Thu, 08 Oct 2020 07:38:41 -0700 (PDT) Received: from lmecxl0524.lme.st.com ([2a04:cec0:11c8:908d:6533:9100:d943:8b22]) by smtp.gmail.com with ESMTPSA id y14sm6926942wma.48.2020.10.08.07.38.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 07:38:41 -0700 (PDT) From: Etienne Carriere To: linux-kernel@vger.kernel.org Subject: [PATCH 2/5] firmware: arm_scmi: fix transfer missing re-initialization Date: Thu, 8 Oct 2020 16:37:19 +0200 Message-Id: <20201008143722.21888-2-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org> References: <20201008143722.21888-1-etienne.carriere@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_103842_933985_0EF2A7F1 X-CRM114-Status: GOOD ( 15.56 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Souvik Chakravarty , linux-arm-kernel@lists.infradead.org, Sudeep Holla , Vincent Guittot , Etienne Carriere , Cristian Marussi MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Implement helper function scmi_do_xfer_again() to process consecutive transfers that are initialized only once with scmi_xfer_get_init() and hence get the pool completion and responses message length not reloaded regarding last completed transfer. Signed-off-by: Etienne Carriere --- drivers/firmware/arm_scmi/base.c | 2 +- drivers/firmware/arm_scmi/clock.c | 2 +- drivers/firmware/arm_scmi/common.h | 2 ++ drivers/firmware/arm_scmi/driver.c | 10 ++++++++++ drivers/firmware/arm_scmi/perf.c | 2 +- drivers/firmware/arm_scmi/sensors.c | 2 +- 6 files changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/firmware/arm_scmi/base.c b/drivers/firmware/arm_scmi/base.c index 9853bd3c4d45..508f214baa1b 100644 --- a/drivers/firmware/arm_scmi/base.c +++ b/drivers/firmware/arm_scmi/base.c @@ -183,7 +183,7 @@ static int scmi_base_implementation_list_get(const struct scmi_handle *handle, /* Set the number of protocols to be skipped/already read */ *num_skip = cpu_to_le32(tot_num_ret); - ret = scmi_do_xfer(handle, t); + ret = scmi_do_xfer_again(handle, t); if (ret) break; diff --git a/drivers/firmware/arm_scmi/clock.c b/drivers/firmware/arm_scmi/clock.c index c1cfe3ee3d55..9bb54c1a8d55 100644 --- a/drivers/firmware/arm_scmi/clock.c +++ b/drivers/firmware/arm_scmi/clock.c @@ -161,7 +161,7 @@ scmi_clock_describe_rates_get(const struct scmi_handle *handle, u32 clk_id, /* Set the number of rates to be skipped/already read */ clk_desc->rate_index = cpu_to_le32(tot_rate_cnt); - ret = scmi_do_xfer(handle, t); + ret = scmi_do_xfer_again(handle, t); if (ret) goto err; diff --git a/drivers/firmware/arm_scmi/common.h b/drivers/firmware/arm_scmi/common.h index 37fb583f1bf5..6d4eea7b0f3e 100644 --- a/drivers/firmware/arm_scmi/common.h +++ b/drivers/firmware/arm_scmi/common.h @@ -143,6 +143,8 @@ struct scmi_xfer { void scmi_xfer_put(const struct scmi_handle *h, struct scmi_xfer *xfer); int scmi_do_xfer(const struct scmi_handle *h, struct scmi_xfer *xfer); +int scmi_do_xfer_again(const struct scmi_handle *handle, + struct scmi_xfer *xfer); int scmi_do_xfer_with_response(const struct scmi_handle *h, struct scmi_xfer *xfer); int scmi_xfer_get_init(const struct scmi_handle *h, u8 msg_id, u8 prot_id, diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index c5dea87edf8f..887cb8249db0 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -402,6 +402,16 @@ int scmi_do_xfer(const struct scmi_handle *handle, struct scmi_xfer *xfer) return ret; } +int scmi_do_xfer_again(const struct scmi_handle *handle, struct scmi_xfer *xfer) +{ + struct scmi_info *info = handle_to_scmi_info(handle); + + xfer->rx.len = info->desc->max_msg_size; + xfer->hdr.poll_completion = false; + + return scmi_do_xfer(handle, xfer); +} + #define SCMI_MAX_RESPONSE_TIMEOUT (2 * MSEC_PER_SEC) /** diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c index ed475b40bd08..66d3d8459936 100644 --- a/drivers/firmware/arm_scmi/perf.c +++ b/drivers/firmware/arm_scmi/perf.c @@ -281,7 +281,7 @@ scmi_perf_describe_levels_get(const struct scmi_handle *handle, u32 domain, /* Set the number of OPPs to be skipped/already read */ dom_info->level_index = cpu_to_le32(tot_opp_cnt); - ret = scmi_do_xfer(handle, t); + ret = scmi_do_xfer_again(handle, t); if (ret) break; diff --git a/drivers/firmware/arm_scmi/sensors.c b/drivers/firmware/arm_scmi/sensors.c index 9703cf6356a0..97addcf828a3 100644 --- a/drivers/firmware/arm_scmi/sensors.c +++ b/drivers/firmware/arm_scmi/sensors.c @@ -134,7 +134,7 @@ static int scmi_sensor_description_get(const struct scmi_handle *handle, /* Set the number of sensors to be skipped/already read */ put_unaligned_le32(desc_index, t->tx.buf); - ret = scmi_do_xfer(handle, t); + ret = scmi_do_xfer_again(handle, t); if (ret) break; From patchwork Thu Oct 8 14:37:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 11823121 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B86517D1 for ; Thu, 8 Oct 2020 14:40:23 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA7BC21789 for ; Thu, 8 Oct 2020 14:40:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="lmaigTEF"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zSN5/dFY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA7BC21789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zU3u2W64OAbLivyMXFOSybaMk7x00ZyUneVSODvnVmo=; b=lmaigTEFgnbYHXNqVhg74C2/m3 i5h9dhlZtkNF/fU7H/H3gC7Vygl08m1RXPfALeDFaMeS+F9a4ik4+pWgiQIyhJzV9ViGPeKBWS7HO c7h4b1miLo5lZjOm62nGIw9ACKRoTy2Ft1qJT5mShIHpsqJHXecqvKTbvY5CAM1g8Awy9ujNrbgSk linhi0cPfhAm7MQLlFkN4T8axMGNYiiZ0vPtFHehrwyMOGiXnjucO8DY3A9T84Tvn5TRnvJD5XHM5 gRNrLp4vshuPqmd84e0P5nDDl68yT+3EvLPRPCR7hHuyMTe+YVhfSKi1zPSX+YmNJqnoMKqmpoOeG xA+/bRLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX4E-00008s-KW; Thu, 08 Oct 2020 14:38:50 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX47-00006R-PK for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 14:38:44 +0000 Received: by mail-wr1-x441.google.com with SMTP id e17so6866261wru.12 for ; Thu, 08 Oct 2020 07:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CnaYY18o2fUBSxrKOxr4IUz/CoikwNfBXHHG6rEGY+E=; b=zSN5/dFY3Pss71qJeL0BUGIjbsSNjXfA8EnhZObgHsbIGYe9uEqAG0D8Mt85u+JeUa rof4fEdSwxU3KGnZ4kZVhZMdNVxrtiwIsmUle4hHkpj9A/+YVT7QXj6jHfxIg8HTG79C 4kTsbHGPNg4BK2LZ6hTPFGpDVXwkyAyFjMpradHBYcKhBFcteoJyR/OwFgEFGoF20Zw3 mFVzbOKe3VxZ6370CKOoQwPHGz7/l7nzR4YauObVVhr578Em3+AY/R3McLx4xOlvDwAg Cj0/TVHN3rWPyIP1w2WX52S/rrsrcH/D3tB/mcPWFGMYgKRX9KH91damRNvQN83hM4mm IrVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CnaYY18o2fUBSxrKOxr4IUz/CoikwNfBXHHG6rEGY+E=; b=b48p/Rr5ChVunkjbrKFE2k//4A3FO+NsS0TnS8zA7msIDnk5xbDVuSCY8EWobFB53f B2CI1U4cRAiZt51c5L6qhS1veOMpGgkbfEnGr7uO0XCBoBbeiAi2OKqZ3XRNzMWcctek tt8SwueyKLK9WtLVhZV9SsR2UhgrH+sk5hka5fx1MTW9bf0AHSvrZM7h1j+J2U7Kb7p/ mnQ5dklFSJG/e1Qx23XGGmX+qOSiOIWfAggjMfCooWn5UI9eEUcOobOrgN1b8ggfz8Yw hep99zFEChvBf9j5szSI586wMB11nzoiDjpcoMF6oqXbZ+yV7zqc8ksEvKB0yiyAkAG6 TX6w== X-Gm-Message-State: AOAM5310Xc2rZrtBoULZxTDeTMouDDYtVAVNDQt1vFPNEkx3KvOgcjrd GKUrPq0dQCWGfaSQb6YnzJ7z0g== X-Google-Smtp-Source: ABdhPJyx7CZ7tbTU69BULIH+0qH16YJhWmb6egZ/ijGM04WH4OKQaFlQj4KlXU5EMlA1w3n2NUX0nw== X-Received: by 2002:adf:e38f:: with SMTP id e15mr9723978wrm.294.1602167923002; Thu, 08 Oct 2020 07:38:43 -0700 (PDT) Received: from lmecxl0524.lme.st.com ([2a04:cec0:11c8:908d:6533:9100:d943:8b22]) by smtp.gmail.com with ESMTPSA id y14sm6926942wma.48.2020.10.08.07.38.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 07:38:42 -0700 (PDT) From: Etienne Carriere To: linux-kernel@vger.kernel.org Subject: [PATCH 3/5] firmware: arm_scmi: add config dependency for smc transport Date: Thu, 8 Oct 2020 16:37:20 +0200 Message-Id: <20201008143722.21888-3-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org> References: <20201008143722.21888-1-etienne.carriere@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_103843_856152_C50B2248 X-CRM114-Status: GOOD ( 14.89 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Souvik Chakravarty , linux-arm-kernel@lists.infradead.org, Sudeep Holla , Vincent Guittot , Etienne Carriere , Cristian Marussi MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fix dependencies for configuration switch ARM_SCMI_PROTOCOL that is not exclusively dependent on MAILBOX since the alternate smc transport that is depends on HAVE_ARM_SMCCC_DISCOVERY since [1]. Link: [1] d76428237784 ("firmware: arm_scmi: Use HAVE_ARM_SMCCC_DISCOVERY instead of ARM_PSCI_FW") Signed-off-by: Etienne Carriere --- drivers/firmware/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig index 3315e3c21586..5bdd411206ff 100644 --- a/drivers/firmware/Kconfig +++ b/drivers/firmware/Kconfig @@ -9,7 +9,7 @@ menu "Firmware Drivers" config ARM_SCMI_PROTOCOL tristate "ARM System Control and Management Interface (SCMI) Message Protocol" depends on ARM || ARM64 || COMPILE_TEST - depends on MAILBOX + depends on MAILBOX || HAVE_ARM_SMCCC_DISCOVERY help ARM System Control and Management Interface (SCMI) protocol is a set of operating system-independent software interfaces that are From patchwork Thu Oct 8 14:37:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 11823113 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 41A911580 for ; Thu, 8 Oct 2020 14:39:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0AF8E21789 for ; Thu, 8 Oct 2020 14:39:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JUiXeOFq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Y1bCIMyF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0AF8E21789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=unc+wGVCcMLPPsh0iDt978QoNnFUNb6C6bl5vHMx5BE=; b=JUiXeOFqbHnsOPne6i+RzqdNrG KHXUUF0aMbqgfaa3DG7Ls9bzC6TsswDQWLNk1LjrRnH/da2Y5ZOqD6bMOPOOSPbQLmwLhKurebrqw 8aY8dk1E6CZnvFQO0S0vd5wRSpNiDrKpm/8IPhbE5QRgUEP0qnySuO+iP2ezLc9oVrh/LhHrVgTzU guYRWNG4Bl5aJ1lHUjfM9k7nSGxeMs3Q0R24I27RLNrbDME7GjRqlYic/9dWmk9DhcaUuLMsJxHtx +P7vOjYvL8ip3o7Q5gX5juoribqqFyj9W5T0AHz2l61xLtz90C7AIS7SNGxJxfJTuM0P+CQPK4Qmg V670P4wA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX4H-00009a-Vk; Thu, 08 Oct 2020 14:38:54 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX49-00006v-At for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 14:38:46 +0000 Received: by mail-wr1-x442.google.com with SMTP id e17so6866335wru.12 for ; Thu, 08 Oct 2020 07:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fGkjTPMi2V3zZZF0+OMF37VrvjDLPDRxTs3MRGoDMBg=; b=Y1bCIMyFDS1UY7hqJ2e5vxCxhQRE6HviXtylOjCWXSrwnTG8W5kyBwnaPSgogGxsyB TiGiZsz6UmJNxxqX9M5oQ0eoMd9fu1xxqezD/D8ckX3m/X8RUgatbmsUIUro+ahODEAu 3ItyuwY/9hLyulO704XHVVFjBz9X2tj6GMqjAPP0nhEiuU0tDGxD3JolzMesOAK1LXR3 tTSU17Om/DdKiWthuVmfuzjMuGraUTYCnSWQ3TFjX4lTgLUX8U1p21FOA2Avw7KvLM4O sI7hhYyuQyFu9SWgTytdbZ8gtyxW5NUwrEo3eUOnVhzQqRDm7cRqq6aOFUk04NI05gfY m1zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fGkjTPMi2V3zZZF0+OMF37VrvjDLPDRxTs3MRGoDMBg=; b=mzQ4/Y8rmnqMUAO+Iam9kmUJIeYFIzvw58FfC1Rt6y/JN64+k0hIOb3NQGc49JwU6S UW/gxUPSzqHAFm800gHwpl/AqhXMz6qxHqRdsA873NWfSLA8GkpkQB+HsZ+LrmIX1nxI bPypXveOXcJOm9yCurkwULGmKijTMOPY4EmdlYQJ2JsMxvkoicbHiSKdzncD21XABJaE qQhRyjT/dn4nRxR+KfRla6ndpoCihBc2hIkZ4Ke8TXmzyhuPizwOQw5eJMyYwqJE1+Dc NQ/OphxN9HDynF5sIh98TrrRq6+fb+GwUuh/CoVmbnxxcUD1lyHJ5cvnkOej1fvvRGZ+ /GCQ== X-Gm-Message-State: AOAM531jomc1WTWWd19qjwrD9hIjn/dk7nUncWDvvv3DDwX8lnFJQ7bX TaQ5wdQF2QIPJnxKgFiExqyOJg== X-Google-Smtp-Source: ABdhPJyL6s+5OY5gglmH/jnSTgDyh+Lz5CLiCPryYXQ8CPd+l4JpwYWOmvdg592zQOtlwmycxHiX0g== X-Received: by 2002:a05:6000:1284:: with SMTP id f4mr9686712wrx.210.1602167924118; Thu, 08 Oct 2020 07:38:44 -0700 (PDT) Received: from lmecxl0524.lme.st.com ([2a04:cec0:11c8:908d:6533:9100:d943:8b22]) by smtp.gmail.com with ESMTPSA id y14sm6926942wma.48.2020.10.08.07.38.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 07:38:43 -0700 (PDT) From: Etienne Carriere To: linux-kernel@vger.kernel.org Subject: [PATCH 4/5] firmware: arm_scmi: smc transport supports multi-message pool Date: Thu, 8 Oct 2020 16:37:21 +0200 Message-Id: <20201008143722.21888-4-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org> References: <20201008143722.21888-1-etienne.carriere@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_103845_456195_E62F2253 X-CRM114-Status: GOOD ( 15.02 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peng Fan , Souvik Chakravarty , linux-arm-kernel@lists.infradead.org, Sudeep Holla , Vincent Guittot , Etienne Carriere , Cristian Marussi MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org There is no reason for the smc transport to restrict itself to a 1 message pool. More can be allocated, messages are copied from/to the shared memory only on SMC exit/entry hence SCMI driver can play with several messages. Use value of 20 to mimic mailbox transport implementation. Any high value could fit. This should be something configurable. Signed-off-by: Etienne Carriere Cc: Peng Fan --- drivers/firmware/arm_scmi/smc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c index 1a03c3ec0230..82a82a5dc86a 100644 --- a/drivers/firmware/arm_scmi/smc.c +++ b/drivers/firmware/arm_scmi/smc.c @@ -149,6 +149,6 @@ static const struct scmi_transport_ops scmi_smc_ops = { const struct scmi_desc scmi_smc_desc = { .ops = &scmi_smc_ops, .max_rx_timeout_ms = 30, - .max_msg = 1, + .max_msg = 20, .max_msg_size = 128, }; From patchwork Thu Oct 8 14:37:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Etienne Carriere X-Patchwork-Id: 11823119 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80EE014D5 for ; Thu, 8 Oct 2020 14:40:22 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4135221789 for ; Thu, 8 Oct 2020 14:40:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LmF1Wxm7"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VBCYDrWw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4135221789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:References:In-Reply-To:Message-Id:Date:Subject:To: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UV/LwSZgUOGIrGdN3Bmg8DfQzw2OsU0LDqd5RHkQL2o=; b=LmF1Wxm7lEJvPY9rXE0JL+3HrQ 4+Nu8t8IVCCyGINlMl/ichCWBmvub7aYI+iBUU4772h1RRJclhIORKcLDJLeDcm667v/Hcn21UBh2 RIt5+08m3+5LQBFFO7I05q5irnuxmlVBjMFCG1Rh2HWlGQVXM5RwbJQC7H3WIr7FQEI0L9UWU4H55 4oajBBOkhqp7+g0zl7RFiBOyQ5TIftxH4YZMbdkBDYyy0DxPFpm5GhkpqMG2Of+jA0D+GlmpULHAf qK5uy5R3kj7IIuxlUG9vVSEWMT6jotICtU1oZiHI+AaEvVpttpQmIP8f3NKtVoRGJzUQP6hSHWISZ 7bxlAZ9A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX4P-0000C3-7t; Thu, 08 Oct 2020 14:39:01 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kQX49-000079-SP for linux-arm-kernel@lists.infradead.org; Thu, 08 Oct 2020 14:38:46 +0000 Received: by mail-wr1-x441.google.com with SMTP id i1so770806wro.1 for ; Thu, 08 Oct 2020 07:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WgNDcH66XgUR5xvlin4vgOc3vaLahNaQFK4he5fif9k=; b=VBCYDrWwfKpjCC9cjowky2P9uUdpZLV3HYyKQwXB4FUs2ZGzR30L3E84ciUkr8vZxI iCURge4wpInCm+QH7mEvl8g4Ob5YmewXbBYqfOT6te+pO/gQkRzs0ek0U0ETdf6bxjqx SppH/aQ8oKZRQtaCSg/OGoav0prhqqoeSMDBs/wU1nvDjWWrqS3NZYsOHKuXFInLdQ6/ FpTq6fSWZ94QjZXirNCmccnp+i7eLR9WX5V2CmJ4xvZYss4rBlCb9T9mYB6jDM1S5KZW NG7iWSdr7VRpgSPC+2e3l1wMXBKPnRcm5f21b0LGLKRTkwxJmNtFfMAnvBWuOvtELFcY 0z5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=WgNDcH66XgUR5xvlin4vgOc3vaLahNaQFK4he5fif9k=; b=cwVFFQfJg0QyE9mcqAJ0bjAOYrseKbPyO6ehMUSyRxBIfPCNLFB0nNQfLu0k/1a83S JJ9UJf1y42X0sMDub10nflAFPdye+iJ0Aj+FBrMdz9D7bJzNceYc6tEnJDZSL573Ivey 8IPyPm1QbC6GCC7DNhJC4+HkwnJAQ45bjjFEIZBk4/FZITF/zaS5KX2e/2XlDGyd8ceq IWZWq6vp+/rbHmm4gyy5oONOAlnuCh8gw3juR7CI7lqhpwCzjQw2B6qhxz+E5hRBNrfM UU8Twk5sfgGP3zTnFVS+Gcx+MK0GCDvP537r1IIz3k51xTP9ySD8ws+h3cFtfZ4K9Amr tfZA== X-Gm-Message-State: AOAM530fw8JoDP7uGaqd9SPoCIfmcevAKrQhS3B+SPip9vKLb9Vg0pNK uwUJH998+VfFLSuGA9qS7eyuhw== X-Google-Smtp-Source: ABdhPJxEGhaFlmgD1zG31MpnbwTI/UoqOHHNEJ4n2LgcKuln/yIhIQHMUndaHQL2u6qpfD9P/cmTQg== X-Received: by 2002:a5d:480b:: with SMTP id l11mr9783275wrq.225.1602167925062; Thu, 08 Oct 2020 07:38:45 -0700 (PDT) Received: from lmecxl0524.lme.st.com ([2a04:cec0:11c8:908d:6533:9100:d943:8b22]) by smtp.gmail.com with ESMTPSA id y14sm6926942wma.48.2020.10.08.07.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2020 07:38:44 -0700 (PDT) From: Etienne Carriere To: linux-kernel@vger.kernel.org Subject: [PATCH 5/5] firmware: arm_scmi: fix ARCH_COLD_RESET Date: Thu, 8 Oct 2020 16:37:22 +0200 Message-Id: <20201008143722.21888-5-etienne.carriere@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201008143722.21888-1-etienne.carriere@linaro.org> References: <20201008143722.21888-1-etienne.carriere@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201008_103846_009817_C2B02C93 X-CRM114-Status: GOOD ( 12.34 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:441 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Souvik Chakravarty , linux-arm-kernel@lists.infradead.org, Sudeep Holla , Vincent Guittot , Etienne Carriere , Cristian Marussi MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Fix ARCH_COLD_RESET according to SCMI specification. Signed-off-by: Etienne Carriere --- drivers/firmware/arm_scmi/reset.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/arm_scmi/reset.c b/drivers/firmware/arm_scmi/reset.c index f063cfe17e02..a981a22cfe89 100644 --- a/drivers/firmware/arm_scmi/reset.c +++ b/drivers/firmware/arm_scmi/reset.c @@ -36,9 +36,7 @@ struct scmi_msg_reset_domain_reset { #define EXPLICIT_RESET_ASSERT BIT(1) #define ASYNCHRONOUS_RESET BIT(2) __le32 reset_state; -#define ARCH_RESET_TYPE BIT(31) -#define COLD_RESET_STATE BIT(0) -#define ARCH_COLD_RESET (ARCH_RESET_TYPE | COLD_RESET_STATE) +#define ARCH_COLD_RESET 0 }; struct scmi_msg_reset_notify {