From patchwork Tue Oct 30 07:31:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 10660511 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6767315E9 for ; Tue, 30 Oct 2018 07:31:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3D5A129750 for ; Tue, 30 Oct 2018 07:31:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 317412975E; Tue, 30 Oct 2018 07:31:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6DD5229750 for ; Tue, 30 Oct 2018 07:31:55 +0000 (UTC) Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 3D55E267692; Tue, 30 Oct 2018 08:31:53 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id D90D926770D; Tue, 30 Oct 2018 08:31:50 +0100 (CET) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (mail-os2jpn01on0090.outbound.protection.outlook.com [104.47.92.90]) by alsa0.perex.cz (Postfix) with ESMTP id 3B59B2675B8 for ; Tue, 30 Oct 2018 08:31:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesasgroup.onmicrosoft.com; s=selector1-renesas-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2emzMWz+1naCz0gPGyneO+BmR7/FJW7rn3W/9QBsdEw=; b=dtrTz4GMZpf1VcpAtoy69xCiJpPWQj9V2/xAJq7nR1K/7LfN7heE8q7gsLmDbwiEBnKlksw1EELuWV5bFsqpYqOTm9TWrervYAoHDyxGW80buDrzpPgaoJozMReCN+4Rv2x5yIBi+NHc7g+45ep0MAuywLCoUk9vK9mhKVNCD8U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Received: from morimoto-PC.renesas.com (211.11.155.130) by OSAPR01MB3313.jpnprd01.prod.outlook.com (2603:1096:604:52::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1250.20; Tue, 30 Oct 2018 07:31:40 +0000 Message-ID: <87h8h3sxt4.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto User-Agent: Wanderlust/2.15.9 Emacs/24.5 Mule/6.0 To: Mark Brown MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Date: Tue, 30 Oct 2018 07:31:40 +0000 X-Originating-IP: [211.11.155.130] X-ClientProxiedBy: TY2PR06CA0011.apcprd06.prod.outlook.com (2603:1096:404:42::23) To OSAPR01MB3313.jpnprd01.prod.outlook.com (2603:1096:604:52::18) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4c47335-97ea-4666-d766-08d63e39bbb4 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:OSAPR01MB3313; X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB3313; 3:tbZJpoAmF6SG6XSKNktbx52qDjGFbZbLw9dQ4YG1jRmLhwFKaRuXVKNc5Qa0vdvnz+IwxOpntu1Z09D9QJd+xxmXaPLg7INEIM+SgzQsavapH0PCG7/g0SyUujKY4NfFfDzataCPr26/m8+W9AEPUNkHWQ9Ymn6/f8ljhpblwAUGDXlTVYpo6ht0nfTOWC2WZwJ9XCYNNMkbJ0rJjLjUFB1YsiCBDqQB+tzdAlLTnmyhme0tQ+RQoM2xEW4Mo26l; 25:YrhxGQwGcIqIJ4WQbR1TcBEbN8BB37KlMaVuNRSzNSA9NQ/vsX3EO0q7syFshS2bbU6dcmx8HjsenEl9BdvqFyTEGedgZwSQ6RLxLe/7vMU/hi37kB+J7xGm0VwDboT9F1Scxf8M3pU/Ax1NMZarxp0avCoY5sOAuw8NWBw/X/rtnk31KdyOS3ueRcyLbvtWwjrK2+qW3lxLlqMO2a1qTtZ6p7TaOaXAM6oY/1qHavsE+GR8nwZpD7oWbu4n9tSLaxBBQS63qeBoP0mh4+nlRN4GqJXm3H1HafiAsNyAMp+NWuqqid8pka9SY7JWUDKxZMDRgWajxgAFeyvnes3t4w==; 31:EM+OAawdLuV+yRam04c7BLg5Knc5rLUN2/jQHg+ICnDEwe0Qrh+Fge9ds7DO0J7WSb77Oc7yfW1AvauZ2nDgsVIKq7aBh7wiIusfg/1LZ72EDdYfPA5MKFTQRSMSX3e/S4Rh0yDarl8a41whXk0YP4skgMxAOqjEbKzr8Cg5j/cq4Bk92CE0abgD0+CRjrEVh7NnTeDUZcCrlRPgsBCxEaQI51HA1xr83JFFGdQ+wAk= X-MS-TrafficTypeDiagnostic: OSAPR01MB3313: X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB3313; 20:LwpJC6KsK7oMgyqUsPsGg3RfYbyZXychHBeGZI3WNZVlBqtRD6QmVezNzKWyYdpxT8WbzzeKzscSXVpvg6INK1+/LW+m8Gmyc1WYro2w6a2FvdGy5BQi43gMFPwWBNR6n5zuU7Hw2wVqoVWj4MvSE9ZZ+GIOq+H0w+0f/sXYbIIB2EWcuau3HEqkcPkpIz9zDlqYD07e5K9z9W3of4mjx+0sGBZTs4Vrhw9MKb0fl+vMJ/IXksETsNVYIKqMtKB7ReO4okMurd2pj1VHryHjvJg5z059SwkBawOAQbNCqr1ekvADrF35mhFJIQxaZ83uXoS1NuytpHmf0Tkm63YsDS09wxnf31sXEIqbdWQc7edtjHIIMIZHqMRF8MlBsJ4MVuPvbEzwLvsKozIO7VUgSE2y0sUqOpZRWSNL5YV2rybqxdYTp6rFVCnWcOhtyM948A6CXETaOwoi6G5PoBtSqCYTgBr3RRIAgRDdCssH3hoUwWx93dIMY7OGzPp/ArdH; 4:hPKVTICnVssTEZGZ/1BwmYdnHP8cSjtwpzCuLOkahsldZ87U6dtgNzyZ/H2YtGBrgKmADH0f9XdcLYQFthWKs6k/e/n4Fm09680MtDlyWsj/eTg543sYyQ9DWxB2lvHoxJUBn8JRqdPHemotLQoW231RxFiQ8DlaFpBVkEtNwVa47FkGu5n4IeJp4jK2sz4PHwUtE+17Zr0bQZ8Mo4bAi66e6WXt0CR5oeVmSyiN3o9VNqo4nLszgT1CvNTVvnTBkFHvySH9c/n8A6hAq8d0Cg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231382)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(148016)(149066)(150057)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201708071742011)(7699051)(76991095); SRVR:OSAPR01MB3313; BCL:0; PCL:0; RULEID:; SRVR:OSAPR01MB3313; X-Forefront-PRVS: 08417837C5 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(136003)(366004)(39860400002)(376002)(346002)(396003)(199004)(189003)(66066001)(68736007)(386003)(97736004)(105586002)(52116002)(7696005)(106356001)(4326008)(16526019)(186003)(53416004)(86362001)(50466002)(26005)(6486002)(81166006)(81156014)(8676002)(8936002)(5660300001)(2906002)(305945005)(53936002)(486006)(6916009)(69596002)(7736002)(3846002)(6116002)(316002)(23726003)(58126008)(16586007)(25786009)(956004)(2616005)(476003)(1857600001)(478600001)(47776003)(36756003)(16060500001); DIR:OUT; SFP:1102; SCL:1; SRVR:OSAPR01MB3313; H:morimoto-PC.renesas.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: renesas.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; OSAPR01MB3313; 23:VV2rd+wutd1lLVvGLITlzUkbbDJd28VXgD1hxjCCc?= FlY6rjzjlTu33jhS69rc526Ml6wknGbwJCDy2KOGBun2/RAU4KlaE3nB2kMp68HnYfJ7UuibKLkuq0cF58BN0vkQcaaINaEhyb2jqmlxUj84rmewTMGmS+FHGgQTOkkCHIT7j9E+REtR4nkMEOX/LLZtERoF/ozMvdVGhsHWLZPiXuN9itICog0RW6liYH/b1p3zkzRit/x9oZezxYo0SVISSe5invjjg6fGGp/zM7n44mDlwqBF7CCXLBlmYVCv6WBtzKwAHbF9FknIZzDR6ZEx/O7aBSNy1SttaUIyPz2CyZULlG4r26NYSniw4MMPuA52qzRuVmQdVtNKm2oqoI1ttm+Jne9+EewucEWqaDwJDnYhoX4Xv4G/cFDszq4XF3VDTEyelGW+62h4iU+rgskDOsq7aWgYifAcVa06sus8jfMuF7lSRzb+iYM0LDeSd8QW9BOBPyesW0DFvgzygFxVrS2O4nvnMXo2371PxP80tZTz+xjHU71x4npXZMluq6+UIQMf4VL1piUocYWTZs/cq/W6ZqlW9lAvGhQwpstOAdnRGYZuGVW27cdacsqa3bIwD7m/G61ZieMNo9Mke+y6ZXF8Mx8QvyDjKv0tp26kEI4MG8YTvjMgPTk/khqixl+jfbAosOfsVqdoGfzclncY0dpyA+nEnZtD1JAgh19ELmAkIkn7yVs609zB93mH7VDvB4LcILaXI+AmfH1vuTA7KcTqxLEUBAgrP+EDHhUBd6TZmoL51WACHFs4Y48uOqBC5pPnd1HIzwUdcU/FwpHYfG6qphrWXVH6qbq6UfGUycrF6Tu0rP87rv3wFZTP17yYr+uQQKHwEGGA8yVliO7XObbzkQUhjYI+Wn3cC40WaSyXBTfKBGY4YF0dbZCJvk0PWnAB9593R+COd6V5yaA9jQMjZcH26dogotqJxiwzchxY6pyNMnRooekfD8pRlI2p/iXzAWF5MUJx+JWDtItdL5PkqTriUvHsP8AX5NSeYHN06Wh8QRgsM+hwUWLDLZE8lEUfm74nTKj/OUv5j1tNvpvO+WU57fTl9D8JwrkbZdlb03JqHRV36tVg25a6nZKgXS8SUJ1tqrUQIzbfBi0 X-Microsoft-Antispam-Message-Info: AwhDlCqVas1ktgg8YZ5jitJSxTHDtxgsrbFGyXa58tDDZEju/baNBDVWQ/+DBiGa44Jwf8s6V7amHC2qTXP/nTvGvRbyy/1D5Aa4EX9coOfGlzg9DmOxoQOJYasgHzT/BjJbdo2KAU7vION5Xub0c7xAPXHgGweQHyWSq7RdqGPcnnU5/GN0Y63hSsMoKgp6DlzKnRA1BGgOFrFtbncT3X7C/rYP7Nuhv68vbbTA1kWnx5xfnEiuFimdOUfR2SS+ewUbVbMoOAa0eFPV40mfbuVLwgR2iMI0cBgj9GioGi1cjBqMDd1zTatysWsDqTOokKF72HYRpTk29ljk4sY2aNFILCmVC9OscnrGQ9KcXRs= X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB3313; 6:nmC9yOK7RYZkQAvR91HpqPFmCRZS1c0WyEsdpkJcbr/bKUs3Ksy05dAd73rnfGNjYgG1NVxfJZPVcD8UlyNC4h4AvV41h/zL0UCeR+9QJYHXDhCqZSOUYfZLZRWBLBtXEctnBdunre5LiIuiv4peBEMOK7DR8NQIgEnQMSoV0uXA1AY872wUoQwS/ZcxBf8erGgqJC78fo+1UWzY0DAl1ouVS+tc6wcemZqBNNuFIY7QztYnCNQkCElCNZdL8rGGO8CtKAF7PIumo2gEumMsPZuAXncT0ElF6iTCHi1jH5Fa76F7scEqrpSMnqfZA4SkmQLJ7RkZen3POp+6npQmBELvgVaDoCPEqFbfeyE5w2pyKGsMgU4zmPjf0SL2KCi5gXMrMB3oih5KVsD4QbTA1LQBwWG+mZPA3ImR8H6Ewe5gEZ8G/2R1VSaQZsQ7auTnVBcw+ej0tLwjEWZl3BpVtg==; 5:qSUaJ0YYMBVz3vgSZSM+0pqYe28J1GrVOkfErIYXiO19BN3nC4JUmdpxGXasR3cdRhUSqha2B3kz4XKeYHWW2LZhn0cg0OioRBCkr5/tqy03uW6PNy51hMA8E6kuEMHKOTvOv4bFFtJyEF6YGAN8rXqv9RpTfRbjATk/b4gsoYI=; 7:hNTD9F21mmF98V7/fp3cQHOL5JoByrhwCNoJw46XHcX81ZKffp1QuV3evw17VIrf9t6Z9VW/+mpj8efcFvtrh5rJWl6YwqCaWp8+O00O+GrXu6Pl8rkfDRnU7CMSgBJbrL7ewqW5xHLcRGPHwvB9dUSFjGjjh7xRfk+M2sv/Uusq3c21iQ4OjPvyo7cr6SpppW0WIP/ImZPuJ+x83E0CHpB0ep0nHTPZ5XC5uXTlXpWbRev7x2HfrpLbAAsY2SBm SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; OSAPR01MB3313; 20:r0zRl841Okh/wIIgkrFsH+M1ohpvI5X0Btzyr2ZYIZA/Ri+13+++iK5xb08AOEWvDYJGVXcJDUOH0xibZ8tdqI9zfQFi5CRYWifHrZUFqAH4fllE7Kf0PLdwPT/vXheXr+fxgdrIcEItW48ET9GQRDYoHfLnzM7qZqPeidO25dY= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Oct 2018 07:31:40.2102 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4c47335-97ea-4666-d766-08d63e39bbb4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSAPR01MB3313 Cc: Linux-ALSA Subject: [alsa-devel] [PATCH] ASoC: pcm3168a: cleanup hw_constraint for LEFT_J/I2S X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org X-Virus-Scanned: ClamAV using ClamSMTP From: Kuninori Morimoto hw constraint for LEFT_J/I2S are same, but had duplicated code. This code cleanup these. Signed-off-by: Kuninori Morimoto --- sound/soc/codecs/pcm3168a.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index e1c3a18..115f2165 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -497,6 +497,10 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream, unsigned int fmt; unsigned int sample_min; unsigned int channel_max; + unsigned int channel_maxs[] = { + 6, /* rx */ + 8 /* tx */ + }; if (tx) fmt = pcm3168a->dac_fmt; @@ -521,18 +525,9 @@ static int pcm3168a_startup(struct snd_pcm_substream *substream, channel_max = 2; break; case PCM3168A_FMT_LEFT_J: - sample_min = 24; - if (tx) - channel_max = 8; - else - channel_max = 6; - break; case PCM3168A_FMT_I2S: sample_min = 24; - if (tx) - channel_max = 8; - else - channel_max = 6; + channel_max = channel_maxs[tx]; break; default: sample_min = 24;