From patchwork Tue Oct 13 08:01:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru M Stan X-Patchwork-Id: 11835157 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 54C5215E6 for ; Tue, 13 Oct 2020 08:03:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E7DD2074A for ; Tue, 13 Oct 2020 08:03:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hq+FNAQW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Yq/nvpaQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E7DD2074A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/0HFjLjooytGWHE3FSdtsJoJBXrIsN54ZYNQYdA59c8=; b=Hq+FNAQWRZMmaSobHaibnFBF0 FS5LCGmgN2GNrtAxWqbjV/M7pk+TMIByDras8EEKd6I8bxxXmprQjTHZLLdkEZl0Csq/sT9QADKwf tkwC61MEeWWPBsFY+8twe9l382NyIC15HxXv7cRDTamSX9DVdVkDIYO+kTmPkoc1JIW/HRP9d/sJU WD/uFrpcNc9AZKGVlyp0QE1PGvzLPoV84vYa/7dUejfhOdPP/m53z1JbnboXSG6HETZB859TmKOit 77UAo0/MHhI8S5t+Qkr5KkhWo+zufwtLmm/a9qEg+n46E+6lohLK/PUjMBc+tXBlY4Vqgyq8frCdb 9P9fP68nQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSFFb-0004wX-MJ; Tue, 13 Oct 2020 08:01:39 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kSFFX-0004un-VC for linux-arm-kernel@lists.infradead.org; Tue, 13 Oct 2020 08:01:36 +0000 Received: by mail-pl1-x629.google.com with SMTP id w21so7480000plq.3 for ; Tue, 13 Oct 2020 01:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PX6utEv95nZrK8Cio4KcHOFe3eh1+n1xQTOKgWru7Q8=; b=Yq/nvpaQ5Hpx/VK+3t8sVeKV8lzlwCiDy9N4+pw8gUCZpI3XS9cL9KwWtSFkhWhisR LGmwRdWOc8I/GXFP/OoRfZ5q2niv7Jht6WP1s7Niv6VRkxKqD+4GSHYXr/EGk+DgX4ts Psnki/01Xl8AnE4gxxe2SnN1XiYtoSXrDxcqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PX6utEv95nZrK8Cio4KcHOFe3eh1+n1xQTOKgWru7Q8=; b=Nx0hjyCnJug8wacGv4opF7BUzFE83t12zfMTRz4KJSRFmS7Cvd/oXED2sWVTkka3RE +u9BLLhTAOErsX7Owm7SXVIVPo++RN90WJBAUdD13DGvjSiusCZ5bPRfeKjvjvH/uN4Q RmkfFF2yjverI8pvio/HO+iyYnPFlhc7OGr1M8Kqpyir2ixGGFoe9s+5Nl47IvikY+Uz GHzskKWnhgGEYCLg+LGSkVe2sP8qADyIwejVyzDDxTyvg/S4XG17GbCcSax+jabmQXM1 mAVVrssBZtImSdeXkJ503hJRmAZbjqG+ZVIVeqh6KfRp0jY+TN18Qdeoc+oV1hqxE6Al UrOw== X-Gm-Message-State: AOAM532yFzkl0/bEbfVansH/NkGP+K72E/jdY7fF3OSv3x6GcYJJlruD tD4W0iR51XEhVVS6HEDwWnA5eg== X-Google-Smtp-Source: ABdhPJwy8G+WoGa8xfqN7S2NUeVNZqaFQcnZEV3UAVpca7MBw+WNfz5pRUiBOuT/fqofn7wEFblptA== X-Received: by 2002:a17:90a:160f:: with SMTP id n15mr24051942pja.75.1602576092037; Tue, 13 Oct 2020 01:01:32 -0700 (PDT) Received: from alex-desktop.lan (c-73-63-253-164.hsd1.ca.comcast.net. [73.63.253.164]) by smtp.gmail.com with ESMTPSA id y124sm14956924pfy.28.2020.10.13.01.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Oct 2020 01:01:31 -0700 (PDT) From: Alexandru Stan To: Thierry Reding , =?utf-8?q?Uwe_Kleine-K=C3=B6n?= =?utf-8?q?ig?= , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Heiko Stuebner , Rob Herring , Andy Gross , Bjorn Andersson Subject: [PATCH v2 2/3] ARM: dts: rockchip: veyron: Remove 0 point from brightness-levels Date: Tue, 13 Oct 2020 01:01:02 -0700 Message-Id: <20201013010056.v2.2.I96b8d872ec51171f19274e43e96cadc092881271@changeid> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201013080103.410133-1-amstan@chromium.org> References: <20201013080103.410133-1-amstan@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201013_040136_023208_5EAB3C12 X-CRM114-Status: GOOD ( 15.98 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:629 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - High trust sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandru Stan , Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Matthias Kaehlcke , Enric Balletbo i Serra , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org After the "PWM backlight interpolation adjustments" patches, the backlight interpolation works a little differently. The way these dts files were working before was relying on a bug (IMHO). Remove the 0-3 range since otherwise we would have a 252 long interpolation that would slowly go between 0 and 3, looking really bad in userspace. We don't need the 0% point, userspace seems to handle this just fine because it uses the bl_power property to turn off the display. Signed-off-by: Alexandru Stan Acked-by: Daniel Thompson --- arch/arm/boot/dts/rk3288-veyron-jaq.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-minnie.dts | 2 +- arch/arm/boot/dts/rk3288-veyron-tiger.dts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron-jaq.dts b/arch/arm/boot/dts/rk3288-veyron-jaq.dts index af77ab20586d..4a148cf1defc 100644 --- a/arch/arm/boot/dts/rk3288-veyron-jaq.dts +++ b/arch/arm/boot/dts/rk3288-veyron-jaq.dts @@ -20,7 +20,7 @@ / { &backlight { /* Jaq panel PWM must be >= 3%, so start non-zero brightness at 8 */ - brightness-levels = <0 8 255>; + brightness-levels = <8 255>; num-interpolated-steps = <247>; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index f8b69e0a16a0..82fc6fba9999 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -39,7 +39,7 @@ volum_up { &backlight { /* Minnie panel PWM must be >= 1%, so start non-zero brightness at 3 */ - brightness-levels = <0 3 255>; + brightness-levels = <3 255>; num-interpolated-steps = <252>; }; diff --git a/arch/arm/boot/dts/rk3288-veyron-tiger.dts b/arch/arm/boot/dts/rk3288-veyron-tiger.dts index 069f0c2c1fdf..52a84cbe7a90 100644 --- a/arch/arm/boot/dts/rk3288-veyron-tiger.dts +++ b/arch/arm/boot/dts/rk3288-veyron-tiger.dts @@ -23,7 +23,7 @@ / { &backlight { /* Tiger panel PWM must be >= 1%, so start non-zero brightness at 3 */ - brightness-levels = <0 3 255>; + brightness-levels = <3 255>; num-interpolated-steps = <252>; };