From patchwork Fri Oct 16 03:39:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tianxianting X-Patchwork-Id: 11840839 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A397A14B4 for ; Fri, 16 Oct 2020 03:50:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 14528207F7 for ; Fri, 16 Oct 2020 03:49:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 14528207F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=h3c.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E569B900002; Thu, 15 Oct 2020 23:49:56 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id DDEA9940007; Thu, 15 Oct 2020 23:49:56 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C8082900003; Thu, 15 Oct 2020 23:49:56 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id 9C4DA900002 for ; Thu, 15 Oct 2020 23:49:56 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3BEF0362C for ; Fri, 16 Oct 2020 03:49:56 +0000 (UTC) X-FDA: 77376409992.16.guide99_1e13b2c2721a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 1C8F61024CAA9 for ; Fri, 16 Oct 2020 03:49:56 +0000 (UTC) X-Spam-Summary: 1,0,0,0b798832c904a7d0,d41d8cd98f00b204,tian.xianting@h3c.com,,RULES_HIT:41:355:379:541:582:800:960:966:973:988:989:1152:1260:1261:1277:1313:1314:1345:1437:1516:1518:1534:1539:1711:1714:1730:1747:1777:1792:2196:2199:2393:2559:2562:3138:3139:3140:3141:3142:3350:3865:3866:3867:3870:3872:4321:4385:5007:6261:7903:10004:10400:11658:11914:12296:12297:12517:12519:12555:12895:13069:13311:13357:14181:14394:14721:21080:21451:21627:21740:21990:30054,0,RBL:60.191.123.56:@h3c.com:.lbl8.mailshell.net-62.14.2.100 64.201.201.201;04ygczqnf6fkzq99zg9y5inky6918ypxufio49r33bxya38kfnncf6mzpzddmsd.dcdgxrwqommfu6hkxcyancgbzdoiixzb79tu5tjfihng7u9ofe4359ncirw8x8i.y-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:24,LUA_SUMMARY:none X-HE-Tag: guide99_1e13b2c2721a X-Filterd-Recvd-Size: 2010 Received: from h3cspam01-ex.h3c.com (smtp.h3c.com [60.191.123.56]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Fri, 16 Oct 2020 03:49:54 +0000 (UTC) Received: from DAG2EX03-BASE.srv.huawei-3com.com ([10.8.0.66]) by h3cspam01-ex.h3c.com with ESMTPS id 09G3nW3G052206 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 16 Oct 2020 11:49:32 +0800 (GMT-8) (envelope-from tian.xianting@h3c.com) Received: from localhost.localdomain (10.99.212.201) by DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 16 Oct 2020 11:49:34 +0800 From: Xianting Tian To: CC: , , Xianting Tian Subject: [PATCH] mm: vmscan: avoid a unnecessary reschedule in shrink_slab() Date: Fri, 16 Oct 2020 11:39:52 +0800 Message-ID: <20201016033952.1924-1-tian.xianting@h3c.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.99.212.201] X-ClientProxiedBy: BJSMTP01-EX.srv.huawei-3com.com (10.63.20.132) To DAG2EX03-BASE.srv.huawei-3com.com (10.8.0.66) X-DNSRBL: X-MAIL: h3cspam01-ex.h3c.com 09G3nW3G052206 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In shrink_slab(), it directly goes to 'out' label only when it can't get the lock of shrinker_rwsew. In this case, it doesn't do the real work of shrinking slab, so we don't need trigger a reschedule by cond_resched(). Signed-off-by: Xianting Tian --- mm/vmscan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index 466fc3144..676e97b28 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -687,8 +687,9 @@ static unsigned long shrink_slab(gfp_t gfp_mask, int nid, } up_read(&shrinker_rwsem); -out: + cond_resched(); +out: return freed; }