From patchwork Mon Oct 19 17:52:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 11844887 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B2C9314B4 for ; Mon, 19 Oct 2020 17:52:56 +0000 (UTC) Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 677F02224D for ; Mon, 19 Oct 2020 17:52:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 677F02224D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=ocfs2-devel-bounces@oss.oracle.com Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09JHo5HF133779; Mon, 19 Oct 2020 17:52:45 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 347s8mptv9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 19 Oct 2020 17:52:45 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09JHnq67084232; Mon, 19 Oct 2020 17:52:45 GMT Received: from oss.oracle.com (oss-old-reserved.oracle.com [137.254.22.2]) by userp3020.oracle.com with ESMTP id 348acprhc3-1 (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO); Mon, 19 Oct 2020 17:52:45 +0000 Received: from localhost ([127.0.0.1] helo=lb-oss.oracle.com) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1kUZKu-0003ld-8G; Mon, 19 Oct 2020 10:52:44 -0700 Received: from userp3030.oracle.com ([156.151.31.80]) by oss.oracle.com with esmtp (Exim 4.63) (envelope-from ) id 1kUZKe-0003f9-Fg for ocfs2-devel@oss.oracle.com; Mon, 19 Oct 2020 10:52:28 -0700 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09JHoraS095408 for ; Mon, 19 Oct 2020 17:52:28 GMT Received: from userp2030.oracle.com (userp2030.oracle.com [156.151.31.89]) by userp3030.oracle.com with ESMTP id 348ahv83f7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 19 Oct 2020 17:52:28 +0000 Received: from pps.filterd (userp2030.oracle.com [127.0.0.1]) by userp2030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09JHhBLt028512 for ; Mon, 19 Oct 2020 17:52:27 GMT Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by userp2030.oracle.com with ESMTP id 3480e9xyju-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=OK) for ; Mon, 19 Oct 2020 17:52:26 +0000 Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-134-BOHmGsUJOKSjxDkCg6by4Q-1; Mon, 19 Oct 2020 13:52:21 -0400 X-MC-Unique: BOHmGsUJOKSjxDkCg6by4Q-1 Received: by mail-qt1-f198.google.com with SMTP id z22so448872qtn.15 for ; Mon, 19 Oct 2020 10:52:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=1rEftUQf/7Jy+J88LXeoBCQ82ZWczV2fVgKUL/vZ8vg=; b=PuFvdmctqdROp7nqCmxFMOB5CjxVUoCgLRzKYFtt1vG7HCXvS8ITAEFIL/zy5WvM14 Hj9/eJjVDqxDslZzMJxOHowNKm9QJhgs+oAeMwkmWv6x52Q1+0+/hL4e5/TH1ENHH3G4 skMo8PyhcnLwP941bfTTzNDkgb41qX/VIqtFe3EDJp/Bfv1z2DX9KDxfzyfP4v2fSOWz mTeiX3Oa0rTjYXOW6T6n6nZ1n428RwBx+7EjwTqjVjEPgaK4IpyFGMx8U7hK8b8GJsy7 yKWgR8hYWqpgYKoJ1+aWPO/QFOvTqduEtpQ+Idyyg83GQTI0e8IIPWtUUQHY6W+gjEdI 4i5A== X-Gm-Message-State: AOAM533PfTbA/SnK7C4Eo2A04LTQ6FCw+dp5EnoVnguSNFdBSS0TAz5h p4srKwz4rkAVyvXguDnx7HsqQX1nITJRogcR/JojbpuP9fInyr4flPiPlia5W+uyQd7vCMg8/z0 Os+9bKhqw0Axgaxi6KXr91g== X-Received: by 2002:a37:7185:: with SMTP id m127mr793762qkc.246.1603129941369; Mon, 19 Oct 2020 10:52:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhsAue4y6qUuYrwWoQG00RGuFBLPHfhcyHNIxwMVlpoPdRfJ2W7ZKYrVEdVKFRc7dB1NLf3Q== X-Received: by 2002:a37:7185:: with SMTP id m127mr793741qkc.246.1603129941165; Mon, 19 Oct 2020 10:52:21 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id 79sm316123qkl.42.2020.10.19.10.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Oct 2020 10:52:20 -0700 (PDT) From: trix@redhat.com To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com, davem@davemloft.net, akpm@linux-foundation.org, willy@infradead.org, alex.shi@linux.alibaba.com Date: Mon, 19 Oct 2020 10:52:16 -0700 Message-Id: <20201019175216.2329-1-trix@redhat.com> X-Mailer: git-send-email 2.18.1 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:103.23.64.2 ip4:103.23.65.2 ip4:103.23.66.26 ip4:103.23.67.26 ip4:107.21.15.141 ip4:108.177.8.0/21 ip4:13.111.0.0/16 ip4:136.147.128.0/20 ip4:136.147.176.0/20 ip4:148.105.8.0/21 ip4:148.139.0.2 ip4:148.139.1.2 ip4:148.139.2.2 ip4:148.139.28.2 ip4:148.139.29.2 ip4:148.139.3.2 ip4:149.72.0.0/16 ip4:149.96.1.26 ip4:149.96.13.2 include:spf1.redhat.com -all X-Proofpoint-SPF-VenPass: Allowed X-PDR: PASS X-Source-IP: 63.128.21.124 X-ServerName: us-smtp-delivery-124.mimecast.com X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 ip4:103.23.64.2 ip4:103.23.65.2 ip4:103.23.66.26 ip4:103.23.67.26 ip4:107.21.15.141 ip4:108.177.8.0/21 ip4:13.111.0.0/16 ip4:136.147.128.0/20 ip4:136.147.176.0/20 ip4:148.105.8.0/21 ip4:148.139.0.2 ip4:148.139.1.2 ip4:148.139.2.2 ip4:148.139.28.2 ip4:148.139.29.2 ip4:148.139.3.2 ip4:149.72.0.0/16 ip4:149.96.1.26 ip4:149.96.13.2 include:spf1.redhat.com -all X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9779 signatures=668682 X-Proofpoint-Spam-Details: rule=tap_safe policy=tap score=0 classifier= adjust=0 reason=safe scancount=1 engine=8.12.0-2009150000 definitions=main-2010190121 X-Spam: OrgSafeList X-SpamRule: orgsafelist Cc: Tom Rix , linux-kernel@vger.kernel.org, ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [PATCH] fs: ocfs2 remove unneeded break X-BeenThere: ocfs2-devel@oss.oracle.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9779 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 malwarescore=0 suspectscore=0 spamscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010190122 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9779 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 priorityscore=1501 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 impostorscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010190122 From: Tom Rix A break is not needed if it is preceded by a goto Signed-off-by: Tom Rix Acked-by: Joseph Qi --- fs/ocfs2/cluster/tcp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/ocfs2/cluster/tcp.c b/fs/ocfs2/cluster/tcp.c index 79a231719460..3bd8119bed5e 100644 --- a/fs/ocfs2/cluster/tcp.c +++ b/fs/ocfs2/cluster/tcp.c @@ -1198,7 +1198,6 @@ static int o2net_process_message(struct o2net_sock_container *sc, msglog(hdr, "bad magic\n"); ret = -EINVAL; goto out; - break; } /* find a handler for it */