From patchwork Wed Oct 31 21:35:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Max Filippov X-Patchwork-Id: 10663261 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3574914E2 for ; Wed, 31 Oct 2018 21:37:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 268652AC1C for ; Wed, 31 Oct 2018 21:37:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 19FBE2BABE; Wed, 31 Oct 2018 21:37:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FROM,FROM_LOCAL_NOVOWEL,HK_RANDOM_FROM, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from lists.gnu.org (lists.gnu.org [208.118.235.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A78802AC1C for ; Wed, 31 Oct 2018 21:37:09 +0000 (UTC) Received: from localhost ([::1]:33603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHyAm-0003no-4H for patchwork-qemu-devel@patchwork.kernel.org; Wed, 31 Oct 2018 17:37:08 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gHy9n-0003JM-KP for qemu-devel@nongnu.org; Wed, 31 Oct 2018 17:36:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gHy9m-0006eY-TW for qemu-devel@nongnu.org; Wed, 31 Oct 2018 17:36:07 -0400 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:40656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gHy9m-0006ck-Ki; Wed, 31 Oct 2018 17:36:06 -0400 Received: by mail-lf1-x142.google.com with SMTP id n3-v6so12798478lfe.7; Wed, 31 Oct 2018 14:36:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=WCNxAxoqdsxmQ426AnUQrNlcJe/0uebVMyXeJ+ezS28=; b=Y8/+pS/b99HjfVqt5vAbeNEaDb3Ik0dfzy5BstvokcK6emc6t7A+woeKsatDEIMEpI m1rt3caKE653e8HnfQn2Qwr0vOImG75YjtmgzSFQvlcqPtVgfKaFXXcNlEpgieAGjhnj QLpWfFI9LlDp0t16hshocOp9MLdLYCCqy9iWVwkAmQ7Nhh9t/c2fVGCIhzvejsKXv2TY MBBHMKm6WHNbM1qLoNCUT6h4KNsJebqve0Je1ki0nhChkxV24uawEKy2Nqjsnt6l9nag 4HpxQRjRt/HPcqq9eUkR5NMWZQiO6euDUmLRr6a+Ix+jnF67OeBb9yfgs+tbx4Bdhxze 8zww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=WCNxAxoqdsxmQ426AnUQrNlcJe/0uebVMyXeJ+ezS28=; b=dSzNifD2AT08+w2D9yf/DM+qeq8+skegW0Nmu1goYNCAR4Wym7MtNWQZ7hrI5g2v5E /gXK8986mElhyvb4pCYoxSi2AwNSRrd0mGjSjDNh8/Yd8PhrdSF5PiozV6CTSCnaZzEL H8Rndme9lpHySGGYRkemw9k5eQfNtDaVektfnitIY+oeBUtIgH6x7WaDH4ph+5bkmQS1 cW3BtLUEFR5/EQ3kD2sy/7HM08sK8w6pAo65zDfcfoHzv/70jsOJvdub7J5C5INqZqrR vl3qGUcN1wZr5FTq7rQQKMCF87aDmw65nqL93K1KIyjU+wmNCqomNYMc4eHI24iSZ1VE Zanw== X-Gm-Message-State: AGRZ1gIR1cL/23GvbqJAUlU/f1UNC0cTl2C82A3T5awjFMEtM5j0DlqQ VHeiJg0ybSYsGjhbVz4yBHkMg9sR X-Google-Smtp-Source: AJdET5eApHkSFm/bOVJRwU3EYdGY+l0eB30arf16+QA1GDYXxXQEi+n08DS6wlkCl31hsu6wCa1JpQ== X-Received: by 2002:a19:cc46:: with SMTP id c67mr2826587lfg.145.1541021764190; Wed, 31 Oct 2018 14:36:04 -0700 (PDT) Received: from octofox.cadence.com (jcmvbkbc-1-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:1fa::2]) by smtp.gmail.com with ESMTPSA id g73-v6sm156604lje.24.2018.10.31.14.36.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 14:36:03 -0700 (PDT) From: Max Filippov To: qemu-devel@nongnu.org Date: Wed, 31 Oct 2018 14:35:50 -0700 Message-Id: <20181031213550.4544-1-jcmvbkbc@gmail.com> X-Mailer: git-send-email 2.11.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::142 Subject: [Qemu-devel] [PATCH] target/xtensa: drop num_[core_]regs from dc232b/dc233c configs X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Max Filippov , qemu-stable@nongnu.org Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" X-Virus-Scanned: ClamAV using ClamSMTP gdb_regmap::num_core_regs field is initialized incorrectly in the dc232b and dc233c configurations. As a result the following message is displayed when attaching to an xtensa linux-user process: "Register 105 is not available", and gdb is unable to control the inferior. Now that xtensa_count_regs does the right thing, remove manual initialization of these fields from the affected configurations and let xtensa_finalize_config initialize them. Cc: qemu-stable@nongnu.org Signed-off-by: Max Filippov Reviewed-by: Richard Henderson --- target/xtensa/core-dc232b.c | 2 -- target/xtensa/core-dc233c.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/target/xtensa/core-dc232b.c b/target/xtensa/core-dc232b.c index 71313378409e..7851bcb63687 100644 --- a/target/xtensa/core-dc232b.c +++ b/target/xtensa/core-dc232b.c @@ -40,8 +40,6 @@ static XtensaConfig dc232b __attribute__((unused)) = { .name = "dc232b", .gdb_regmap = { - .num_regs = 120, - .num_core_regs = 52, .reg = { #include "core-dc232b/gdb-config.inc.c" } diff --git a/target/xtensa/core-dc233c.c b/target/xtensa/core-dc233c.c index d701e3f5de07..8853bfd4d08f 100644 --- a/target/xtensa/core-dc233c.c +++ b/target/xtensa/core-dc233c.c @@ -40,8 +40,6 @@ static XtensaConfig dc233c __attribute__((unused)) = { .name = "dc233c", .gdb_regmap = { - .num_regs = 121, - .num_core_regs = 52, .reg = { #include "core-dc233c/gdb-config.inc.c" }