From patchwork Mon Oct 26 15:38:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11857619 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C40AE6A2 for ; Mon, 26 Oct 2020 15:40:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A05B522450 for ; Mon, 26 Oct 2020 15:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603726830; bh=pOt9wtKPKqangfuHUH6+tRCLKSUEff4N/khEnNsCMzg=; h=From:To:Cc:Subject:Date:List-ID:From; b=aQEcqIwM0rVORiIhBKFWJmoENgIh6pAURcXWjHiBwW2kx4OqjeZzAcD8Bhmd9zEkB UiBD0Aa9Jbbuikhr7zf8obkYQsPq14lfbkrgtTb41rVShu2alH2SHWDKUXVW+pSCl3 KBb/qx5OjVCteiD+kPHH9Z2PNOjxJ7kp2SHq7Zwo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1773323AbgJZPka (ORCPT ); Mon, 26 Oct 2020 11:40:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:34780 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1773322AbgJZPka (ORCPT ); Mon, 26 Oct 2020 11:40:30 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A457822404; Mon, 26 Oct 2020 15:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603726829; bh=pOt9wtKPKqangfuHUH6+tRCLKSUEff4N/khEnNsCMzg=; h=From:To:Cc:Subject:Date:From; b=uuV65gouyxRylexjetz28pKjdEX6gLb73pkSDShdZ4fFDhmZj0zIXbqxYJZf1cNeo U0Q/l1+LWFMjri44+WegQlxHWep/ZnodLKegr0SDiOv0e0Gsrlt4B/M8i4cWL/r/wD 0bPMP4UJsWujRLFYkc23FZdR1LAvozZ4ZiRjIKO0= From: Krzysztof Kozlowski To: Ulf Hansson , Ben Dooks , Maxime Ripard , Chen-Yu Tsai , Adrian Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 1/3] mmc: s3cmci: include GPIO descriptor consumer header Date: Mon, 26 Oct 2020 16:38:08 +0100 Message-Id: <20201026153810.89512-1-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The driver uses GPIO Descriptor Consumer Interface so include proper header to fix compile test errors like: drivers/mmc/host/s3cmci.c: In function ‘s3cmci_check_sdio_irq’: drivers/mmc/host/s3cmci.c:304:7: error: implicit declaration of function ‘gpiod_get_value’; did you mean ‘gpio_get_value’? [-Werror=implicit-function-declaration] drivers/mmc/host/s3cmci.c: In function ‘s3cmci_probe_pdata’: drivers/mmc/host/s3cmci.c:1451:19: error: implicit declaration of function ‘devm_gpiod_get_index’ [-Werror=implicit-function-declaration] Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/s3cmci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/s3cmci.c b/drivers/mmc/host/s3cmci.c index 643d54eceef6..a33a7823c265 100644 --- a/drivers/mmc/host/s3cmci.c +++ b/drivers/mmc/host/s3cmci.c @@ -17,7 +17,7 @@ #include #include #include -#include +#include #include #include #include From patchwork Mon Oct 26 15:38:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11857621 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E743514C0 for ; Mon, 26 Oct 2020 15:40:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D0174239D2 for ; Mon, 26 Oct 2020 15:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603726833; bh=KAl+a17RKAP8KypIuISMNDf6rpG0mE1AHoSQdwN/75Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GT5ZDtnPuo3nhxE/SsDWGOPIFVKdFcdHZ6QacJ0ARhFSoURuT3nZ436MbQkIMFKUn cCpr+EsxxVLO8Oe5yQrf7swOLErkBcXk8CyHbLmkc1R54/3xycadPHq0jfWXbap7qY VklC7GtjRU1xXPCs63dN7ka0cx2w9iiFuVSULLk4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1784252AbgJZPkd (ORCPT ); Mon, 26 Oct 2020 11:40:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:34876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1773322AbgJZPkc (ORCPT ); Mon, 26 Oct 2020 11:40:32 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0391D2242A; Mon, 26 Oct 2020 15:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603726832; bh=KAl+a17RKAP8KypIuISMNDf6rpG0mE1AHoSQdwN/75Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I5Dou+5oBBQu9B6fpTptjbMUWmxlwzDlG9DHDH4lwDGqyPW5GbO+WLe62AnoSr6cW fgBgANAJa1WwsZRr3EJTSYsgp4sDA2XbV5nRHA/n789N0HjdBUQCXq80as8CSF+xAg /ePe9Z3S3ZwFBJFGrBt1UqibfZMSNiWWJn6T8rWc= From: Krzysztof Kozlowski To: Ulf Hansson , Ben Dooks , Maxime Ripard , Chen-Yu Tsai , Adrian Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH 2/3] mmc: s3cmci: enable compile testing Date: Mon, 26 Oct 2020 16:38:09 +0100 Message-Id: <20201026153810.89512-2-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201026153810.89512-1-krzk@kernel.org> References: <20201026153810.89512-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The driver can be compile tested to increase build coverage. Signed-off-by: Krzysztof Kozlowski --- drivers/mmc/host/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index 31481c9fcc2e..310e546e5898 100644 --- a/drivers/mmc/host/Kconfig +++ b/drivers/mmc/host/Kconfig @@ -631,8 +631,8 @@ config MMC_SPI config MMC_S3C tristate "Samsung S3C SD/MMC Card Interface support" - depends on ARCH_S3C24XX - depends on S3C24XX_DMAC + depends on ARCH_S3C24XX || COMPILE_TEST + depends on S3C24XX_DMAC || COMPILE_TEST help This selects a driver for the MCI interface found in Samsung's S3C2410, S3C2412, S3C2440, S3C2442 CPUs. From patchwork Mon Oct 26 15:38:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 11857623 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BB3F614C0 for ; Mon, 26 Oct 2020 15:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A226B22460 for ; Mon, 26 Oct 2020 15:40:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603726837; bh=9ZA2eUlao+W2wjkHccyiO9YyGNF586SIGj+ZQg6YKD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OZQ8/rf8kRo7e+/6gYZ6WFYaSSl9VhmuE/JJl7YeUbeU3tXezr8Mq6WIBVIklNSx/ 1xUfYPy3hYC3USSXtJ8uuLAUztqLn/bhD7FDDVAiEoIGwDgdiRaLe+8GwMtrfz2qZT Ir2U1tz1NFMUHmLxB2ke0I7wUOWmr5wd6BUf0fp0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1784262AbgJZPkg (ORCPT ); Mon, 26 Oct 2020 11:40:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:34946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1784261AbgJZPkf (ORCPT ); Mon, 26 Oct 2020 11:40:35 -0400 Received: from kozik-lap.mshome.net (unknown [194.230.155.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4099E22400; Mon, 26 Oct 2020 15:40:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603726835; bh=9ZA2eUlao+W2wjkHccyiO9YyGNF586SIGj+ZQg6YKD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GjXnh3M0/liuMV7QyGMmlKiUKrc4da3ovQD6nsgOscWexQ1B3/1ZaXpLMAEH/Nupb ZH+QHvTCcSUdS0J0xrRICdPfwI+gNeiIC9u5NQqb1ZUJmpQL6yGI3oyK4CovvTnX9I fUEABGcBlM83g6o3JVrWVUybcjau9hiUfVcKf3GI= From: Krzysztof Kozlowski To: Ulf Hansson , Ben Dooks , Maxime Ripard , Chen-Yu Tsai , Adrian Hunter , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski , kernel test robot Subject: [PATCH 3/3] mmc: sunxi: drop of_match_ptr from of_device_id table Date: Mon, 26 Oct 2020 16:38:10 +0100 Message-Id: <20201026153810.89512-3-krzk@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201026153810.89512-1-krzk@kernel.org> References: <20201026153810.89512-1-krzk@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org The driver can match only via DT table so it should be always used and the of_match_ptr does not have any sense (this also allows ACPI matching via PRP0001, even though it is not relevant for sunxi). This fixes compile warning: drivers/mmc/host/sunxi-mmc.c:1181:34: warning: ‘sunxi_mmc_of_match’ defined but not used [-Wunused-const-variable=] Reported-by: kernel test robot Signed-off-by: Krzysztof Kozlowski Acked-by: Maxime Ripard --- drivers/mmc/host/sunxi-mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c index fc62773602ec..6310693f2ac0 100644 --- a/drivers/mmc/host/sunxi-mmc.c +++ b/drivers/mmc/host/sunxi-mmc.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -1515,7 +1516,7 @@ static struct platform_driver sunxi_mmc_driver = { .driver = { .name = "sunxi-mmc", .probe_type = PROBE_PREFER_ASYNCHRONOUS, - .of_match_table = of_match_ptr(sunxi_mmc_of_match), + .of_match_table = sunxi_mmc_of_match, .pm = &sunxi_mmc_pm_ops, }, .probe = sunxi_mmc_probe,