From patchwork Mon Oct 26 20:57:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 11858773 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A33AC4363A for ; Mon, 26 Oct 2020 20:57:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 499CD2076A for ; Mon, 26 Oct 2020 20:57:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="E2t87IDf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728539AbgJZU5f (ORCPT ); Mon, 26 Oct 2020 16:57:35 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:35969 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728524AbgJZU5d (ORCPT ); Mon, 26 Oct 2020 16:57:33 -0400 Received: by mail-qk1-f194.google.com with SMTP id r7so9782796qkf.3 for ; Mon, 26 Oct 2020 13:57:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=Y9JdjpM4anMcNe9Rm4u/VZMVCiw0d5EcNQIWvf6Jupw=; b=E2t87IDfDQiaUBZ3/yUmZnhUDu3M6kL4kkABbk1IYE7tiNnMrUvwOkb8refhBVWHSj +OV0bEGjF64oSHdswpqN8NNVb0uwxiz6QaqjCYvGk0OwfBYXlLA3xdnx9HvnFqCW9gzb Kg8HF8sLHGXXI8eV2+58XJ1TG2AxuuG0QDfJHL8SjcX9webkcNMWi5vDdp96Zs/Q8EUS O0QR+kF/CC+g11KMQVTojeXRD2+UMP9cBBLK+pZ605f5C+A/HA8P8bCjuylYFwh+rmU3 jxuW/zWFZlYokXbRijyg8c8i7tw5X0XZdU3tiEW+jL2MOuGAQrMvqJSI69E2cTgZ4GY6 qmQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y9JdjpM4anMcNe9Rm4u/VZMVCiw0d5EcNQIWvf6Jupw=; b=RTenGlcGKDdLlQoT1BPgN5ydKsX3px4ueRPaqsdbnmsrZzAIQtWXMggjuAopQlSIBW zgdweDVA2PVXd8/k51r6tTX+HA9PjK0wuiakXY9QF21f/KvPPQ2MFWSK6SwPWA3Xf6J/ GWp199yUVDuXUQQvuNG+jZNOIw25wbEtUs3thfNN2YD5gu8mExKIcqkliGn2HPnuye5K e7UwrUaTQz/7mG0bXf7/7BYmhclE99jkfb3s0XqGvh+oVI2jgT3fiFx/LssdlIfL9j2j n33XKGVWG5BA0V+t2bEFSfqKipAt3QYMAi+goTjM2HJHtHu4QVicdisqvrpKsFAsrKw9 X6iw== X-Gm-Message-State: AOAM531mzCbwTMmvqsDh9XCmndgnjUVwXJG82JZRBM68fJxUnM7kubl2 pYa4rqRJzcGg8XfXGaO6r3x2TU4l9QVyAhl9 X-Google-Smtp-Source: ABdhPJw3+jImnilyXgwQoLx/007zAiY/i+Va2dcyWcqiOTP0h7zBmCUkZvszZIxHeNDOMPVGL7Jmog== X-Received: by 2002:a37:a38b:: with SMTP id m133mr20533259qke.45.1603745851634; Mon, 26 Oct 2020 13:57:31 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id s14sm3052671qtb.25.2020.10.26.13.57.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 13:57:31 -0700 (PDT) From: Josef Bacik To: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: [PATCH v2 1/2] btrfs: print the block rsv type when we fail our reservation Date: Mon, 26 Oct 2020 16:57:26 -0400 Message-Id: X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org To help with debugging, print the type of the block rsv when we fail to use our target block rsv in btrfs_use_block_rsv. Signed-off-by: Josef Bacik Reviewed-by: Nikolay Borisov --- fs/btrfs/block-rsv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/block-rsv.c b/fs/btrfs/block-rsv.c index 4651f8bf890b..04a6226e0388 100644 --- a/fs/btrfs/block-rsv.c +++ b/fs/btrfs/block-rsv.c @@ -519,7 +519,8 @@ struct btrfs_block_rsv *btrfs_use_block_rsv(struct btrfs_trans_handle *trans, /*DEFAULT_RATELIMIT_BURST*/ 1); if (__ratelimit(&_rs)) WARN(1, KERN_DEBUG - "BTRFS: block rsv returned %d\n", ret); + "BTRFS: block rsv %d returned %d\n", + block_rsv->type, ret); } try_reserve: ret = btrfs_reserve_metadata_bytes(root, block_rsv, blocksize, From patchwork Mon Oct 26 20:57:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 11858769 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACC9BC5517A for ; Mon, 26 Oct 2020 20:57:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5DAF62076A for ; Mon, 26 Oct 2020 20:57:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="oo6Cc5LM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728551AbgJZU5g (ORCPT ); Mon, 26 Oct 2020 16:57:36 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:40288 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728525AbgJZU5e (ORCPT ); Mon, 26 Oct 2020 16:57:34 -0400 Received: by mail-qt1-f195.google.com with SMTP id m9so7805689qth.7 for ; Mon, 26 Oct 2020 13:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=M84GAXEwUxWaRrqs+QZ2oVxAW6ZNZ9Sx6nHQ3GDL8GE=; b=oo6Cc5LMGZHG7LALrZpoEGKC4UXN952AKNTgyJCa10S7BHfDHczeDz8RhNcdQEneGY anER7yT8RDC38NjFkZfueUpAv9WKtfGNvtTp1deYt/Aez5WdlBXkvZ2HUbi3DjEnZ+d+ fPMjuWInqEfWrjGbZvVC7RKekTO6R236dshhOYNnip/f9IlM3yD7I1lGDAFlAHAJgMoU Zm5auveUokKCv6e6jNEXiFjKIbMTAI29xNALxi2i9TuSH/4hKVfnxDxF9jrzAOuLykWg VUCunDRic8UTg4odUTSCjO18dOEtpGBqql38HcYu7jhczd4G11j1K9QaCrhmy8eBEtqz 0SBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M84GAXEwUxWaRrqs+QZ2oVxAW6ZNZ9Sx6nHQ3GDL8GE=; b=YUMAOH3P/raHlqGOMJFD55VTcgpjYbvz6gSHZApvjB8WszRQKwZ0Ovd52UgQFCECMf zDyzqWC2ITlN0EJmoYUn4mvfAkmzs4Qqt70oqfWxBYvEWU0f27OI9+ubmobhlQYKyQAR L0Igz87YN7gNe7ucbxXSS0wpv6EQnzaYFjOGWnGNCcbtT/oGAGmNqP86L+pbiKuXMwoj SfPxyiTB8VLo1QNmQ6e5eWT7uL8EGyAO/D+zOTTA50j7cG40Mg/YUGWOj0lZMcj8omFA nvYahUmZLLPgixZkFVMYLvhChetdXh9Lxhi78USfYapqlFFRjXAnJkZNgGmHb1tuVy2y AfpQ== X-Gm-Message-State: AOAM531wWHF4qbDNJ4v0IigPyEjlLO5grOaNJAe/9s9q7B+gZe4jywok d5XMx5wL9ufac+6/ieEYKdPNx/Rjvobj62wn X-Google-Smtp-Source: ABdhPJz8EKnCJP3YOGl8hqYn4un403dmvpkfNshZeIvByEzkD39rXOMdat0UOQgGxahuDejw+JzhLg== X-Received: by 2002:ac8:4e01:: with SMTP id c1mr19279551qtw.343.1603745853399; Mon, 26 Oct 2020 13:57:33 -0700 (PDT) Received: from localhost (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id d129sm7225239qkg.127.2020.10.26.13.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Oct 2020 13:57:32 -0700 (PDT) From: Josef Bacik To: linux-btrfs@vger.kernel.org, kernel-team@fb.com Subject: [PATCH v2 2/2] btrfs: fix min reserved size calculation in merge_reloc_root Date: Mon, 26 Oct 2020 16:57:27 -0400 Message-Id: <617eb7b3560d2319b8362209331fa4bc3ec03cc5.1603745723.git.josef@toxicpanda.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The minimum reserve size was adjusted to take into account the height of the tree we are merging, however we can have a root with a level == 0. What we want is root_level + 1 to get the number of nodes we may have to cow. This fixes the enospc_debug warning pops with btrfs/101. 44d354abf33e ("btrfs: relocation: review the call sites which can be interrupted by signal") Signed-off-by: Josef Bacik Reviewed-by: Nikolay Borisov Tested-by: Nikolay Borisov --- fs/btrfs/relocation.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index 3602806d71bd..9ba92d86da0b 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -1648,6 +1648,7 @@ static noinline_for_stack int merge_reloc_root(struct reloc_control *rc, struct btrfs_root_item *root_item; struct btrfs_path *path; struct extent_buffer *leaf; + int reserve_level; int level; int max_level; int replaced = 0; @@ -1696,7 +1697,8 @@ static noinline_for_stack int merge_reloc_root(struct reloc_control *rc, * Thus the needed metadata size is at most root_level * nodesize, * and * 2 since we have two trees to COW. */ - min_reserved = fs_info->nodesize * btrfs_root_level(root_item) * 2; + reserve_level = max_t(int, 1, btrfs_root_level(root_item)); + min_reserved = fs_info->nodesize * reserve_level * 2; memset(&next_key, 0, sizeof(next_key)); while (1) {