From patchwork Tue Oct 27 02:52:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xiao Yang X-Patchwork-Id: 11859295 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D53DA1130 for ; Tue, 27 Oct 2020 03:11:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF806206C1 for ; Tue, 27 Oct 2020 03:11:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2443699AbgJ0DL4 (ORCPT ); Mon, 26 Oct 2020 23:11:56 -0400 Received: from mail.cn.fujitsu.com ([183.91.158.132]:62427 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2440576AbgJ0DLz (ORCPT ); Mon, 26 Oct 2020 23:11:55 -0400 X-IronPort-AV: E=Sophos;i="5.77,422,1596470400"; d="scan'208";a="100536952" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 27 Oct 2020 11:11:52 +0800 Received: from G08CNEXMBPEKD05.g08.fujitsu.local (unknown [10.167.33.204]) by cn.fujitsu.com (Postfix) with ESMTP id 303C14CE34D6 for ; Tue, 27 Oct 2020 11:11:48 +0800 (CST) Received: from G08CNEXCHPEKD06.g08.fujitsu.local (10.167.33.205) by G08CNEXMBPEKD05.g08.fujitsu.local (10.167.33.204) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 27 Oct 2020 11:11:47 +0800 Received: from Fedora-31.g08.fujitsu.local (10.167.220.31) by G08CNEXCHPEKD06.g08.fujitsu.local (10.167.33.205) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 27 Oct 2020 11:11:45 +0800 From: Xiao Yang To: CC: Xiao Yang Subject: [RESEND PATCH v2] ext4/047: Add a test for inline_data vs. DAX inode flag Date: Tue, 27 Oct 2020 10:52:11 +0800 Message-ID: <20201027025211.575303-1-yangx.jy@cn.fujitsu.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-yoursite-MailScanner-ID: 303C14CE34D6.A9694 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: yangx.jy@cn.fujitsu.com X-Spam-Status: No Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org Inline_data is mutually exclusive to DAX inode flag so enabling both of them is not expected and triggers some errors. It's a regression test for kernel patch: commit aa2f77920b74 ("ext4: disallow modifying DAX inode flag if inline_data has been set") Signed-off-by: Xiao Yang Reviewed-by: Ritesh Harjani --- V1->V2: 1) Add commit id for kernel patch. 2) Rebase on the lastest xfstests-dev. tests/ext4/047 | 56 ++++++++++++++++++++++++++++++++++++++++++++++ tests/ext4/047.out | 2 ++ tests/ext4/group | 1 + 3 files changed, 59 insertions(+) create mode 100755 tests/ext4/047 create mode 100644 tests/ext4/047.out diff --git a/tests/ext4/047 b/tests/ext4/047 new file mode 100755 index 00000000..116158f5 --- /dev/null +++ b/tests/ext4/047 @@ -0,0 +1,56 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2020 Fujitsu. All Rights Reserved. +# +# FS QA Test 047 +# +# This is a regression test for kernel patch: +# commit aa2f77920b74 ("ext4: disallow modifying DAX inode flag if inline_data has been set") + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here +_supported_fs ext4 +_require_scratch_dax_mountopt "dax=always" +_require_dax_iflag +_require_scratch_ext4_feature "inline_data" + +TESTFILE=$SCRATCH_MNT/testfile + +_scratch_mkfs_ext4 -O inline_data > $seqres.full 2>&1 + +_scratch_mount "-o dax=inode" >> $seqres.full 2>&1 + +echo "Need to make some inline data..." > $TESTFILE + +# It's fine to disallow modifying DAX inode flag on the file which +# has inline_data flag. +if $XFS_IO_PROG -c "chattr +x" $TESTFILE >> $seqres.full 2>&1; then + _scratch_cycle_mount "dax=inode" + echo 'Append data' >> $TESTFILE +fi + +# success, all done +echo "Silence is golden" +status=0 +exit diff --git a/tests/ext4/047.out b/tests/ext4/047.out new file mode 100644 index 00000000..48db9bfe --- /dev/null +++ b/tests/ext4/047.out @@ -0,0 +1,2 @@ +QA output created by 047 +Silence is golden diff --git a/tests/ext4/group b/tests/ext4/group index 70c0bca6..ceda2ba6 100644 --- a/tests/ext4/group +++ b/tests/ext4/group @@ -49,6 +49,7 @@ 044 auto quick 045 auto dir 046 auto prealloc quick +047 auto quick dax 271 auto rw quick 301 aio auto ioctl rw stress defrag 302 aio auto ioctl rw stress defrag