From patchwork Thu Oct 29 17:09:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 11866911 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4AE14157C for ; Thu, 29 Oct 2020 17:10:26 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0254D20790 for ; Thu, 29 Oct 2020 17:10:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="LHHiOfgH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0254D20790 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.14392.35546 (Exim 4.92) (envelope-from ) id 1kYBR3-0001MU-7b; Thu, 29 Oct 2020 17:10:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 14392.35546; Thu, 29 Oct 2020 17:10:01 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYBR3-0001MN-4W; Thu, 29 Oct 2020 17:10:01 +0000 Received: by outflank-mailman (input) for mailman id 14392; Thu, 29 Oct 2020 17:10:00 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYBR2-0001MI-8x for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 17:10:00 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0639829f-d219-4018-aa96-5a8fc86ef1cb; Thu, 29 Oct 2020 17:09:59 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A5290ACDF; Thu, 29 Oct 2020 17:09:58 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYBR2-0001MI-8x for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 17:10:00 +0000 X-Inumbo-ID: 0639829f-d219-4018-aa96-5a8fc86ef1cb Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 0639829f-d219-4018-aa96-5a8fc86ef1cb; Thu, 29 Oct 2020 17:09:59 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603991398; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3hE4uVxT8Nrw6+ayb6BmQUqV+JrKDRf67hQnoXyI4UA=; b=LHHiOfgHMsbd7/1FTq8fAj9nbwJ6GsYestzVeJhFsijS3lO3BeHJLSa6nHFb+GZrDnM4vd VggUzE65cPeRqv1gDP2+gW3r2iYtHnuGIKPUiGLdDwWTAJBg9POIngPVnvCBHp7MP7wXoL R/Zohxa80zTnAnVHeg3MKuGGMWd1gJ0= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A5290ACDF; Thu, 29 Oct 2020 17:09:58 +0000 (UTC) Subject: [PATCH 1/2] x86: fix build of PV shim when !GRANT_TABLE From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= References: <94c18ebf-632d-8a2c-220c-c31d6e37eb55@suse.com> Message-ID: <333de96e-5f60-dc87-7668-e8027dcfbcdd@suse.com> Date: Thu, 29 Oct 2020 18:09:59 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <94c18ebf-632d-8a2c-220c-c31d6e37eb55@suse.com> Content-Language: en-US To do its compat translation, shim code needs to include the compat header. For this to work, this header first of all needs to be generated. Reported-by: Andrew Cooper Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/include/Makefile +++ b/xen/include/Makefile @@ -24,6 +24,7 @@ headers-$(CONFIG_X86) += compat/arch headers-$(CONFIG_ARGO) += compat/argo.h headers-$(CONFIG_PV) += compat/callback.h headers-$(CONFIG_GRANT_TABLE) += compat/grant_table.h +headers-$(CONFIG_PV_SHIM) += compat/grant_table.h headers-$(CONFIG_HVM) += compat/hvm/dm_op.h headers-$(CONFIG_HVM) += compat/hvm/hvm_op.h headers-$(CONFIG_HVM) += compat/hvm/hvm_vcpu.h From patchwork Thu Oct 29 17:10:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 11866913 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0317461C for ; Thu, 29 Oct 2020 17:10:56 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B7E2620759 for ; Thu, 29 Oct 2020 17:10:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="MQJ29yPq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B7E2620759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.14395.35559 (Exim 4.92) (envelope-from ) id 1kYBRR-00026o-Gu; Thu, 29 Oct 2020 17:10:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 14395.35559; Thu, 29 Oct 2020 17:10:25 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYBRR-00026h-Cs; Thu, 29 Oct 2020 17:10:25 +0000 Received: by outflank-mailman (input) for mailman id 14395; Thu, 29 Oct 2020 17:10:24 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYBRP-00026X-VF for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 17:10:23 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 847c457d-17cf-4b40-bc43-e1ed0460cb81; Thu, 29 Oct 2020 17:10:23 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7A389ACF6; Thu, 29 Oct 2020 17:10:22 +0000 (UTC) Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kYBRP-00026X-VF for xen-devel@lists.xenproject.org; Thu, 29 Oct 2020 17:10:23 +0000 X-Inumbo-ID: 847c457d-17cf-4b40-bc43-e1ed0460cb81 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 847c457d-17cf-4b40-bc43-e1ed0460cb81; Thu, 29 Oct 2020 17:10:23 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1603991422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+ezQCTGakbRm0syNT/lctbw8ycn2F425iJ8DjN9kNw=; b=MQJ29yPq1EqSqtt+PS4dtHxn0Lg2YBlLrBvwllE1Rk3+X7ucOObj2y+G07fZhWB5281NTE BOd+b7THGBPjq7uGOmjTExQOhLKzS8JHWqY7p95y54kGlh1o9BpkEC6T5McTH3JLKn+yQz f7K7ZMZrqp7nh5Erf8jdvbJr5CYAL+0= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7A389ACF6; Thu, 29 Oct 2020 17:10:22 +0000 (UTC) Subject: [PATCH 2/2] x86: PV shim doesn't need GRANT_TABLE From: Jan Beulich To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= References: <94c18ebf-632d-8a2c-220c-c31d6e37eb55@suse.com> Message-ID: <17fb04fb-99b6-7e20-0583-421ebb666ddc@suse.com> Date: Thu, 29 Oct 2020 18:10:23 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <94c18ebf-632d-8a2c-220c-c31d6e37eb55@suse.com> Content-Language: en-US The only reference into the code controlled by this option is from the hypercall table, and that hypercall table entry gets overwritten. Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- a/xen/arch/x86/configs/pvshim_defconfig +++ b/xen/arch/x86/configs/pvshim_defconfig @@ -9,6 +9,7 @@ CONFIG_EXPERT=y CONFIG_SCHED_NULL=y # Disable features not used by the PV shim # CONFIG_XEN_SHSTK is not set +# CONFIG_GRANT_TABLE is not set # CONFIG_HYPFS is not set # CONFIG_BIGMEM is not set # CONFIG_KEXEC is not set