From patchwork Fri Nov 2 02:19:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liu Bo X-Patchwork-Id: 10664887 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9B45713A4 for ; Fri, 2 Nov 2018 02:19:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7EACB2B862 for ; Fri, 2 Nov 2018 02:19:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6F2B32C519; Fri, 2 Nov 2018 02:19:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5CEE2B862 for ; Fri, 2 Nov 2018 02:19:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726125AbeKBLZT (ORCPT ); Fri, 2 Nov 2018 07:25:19 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:42289 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726119AbeKBLZT (ORCPT ); Fri, 2 Nov 2018 07:25:19 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R911e4;CH=green;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07417;MF=bo.liu@linux.alibaba.com;NM=1;PH=DS;RN=2;SR=0;TI=SMTPD_---0TC6oWzf_1541125170; Received: from localhost(mailfrom:bo.liu@linux.alibaba.com fp:SMTPD_---0TC6oWzf_1541125170) by smtp.aliyun-inc.com(127.0.0.1); Fri, 02 Nov 2018 10:19:30 +0800 From: Liu Bo To: Cc: Subject: [PATCH] Fstest: ext4: regression test for a ENOSPC warning Date: Fri, 2 Nov 2018 10:19:25 +0800 Message-Id: <1541125165-122108-1-git-send-email-bo.liu@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Sender: fstests-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: fstests@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This adds a regression test for a ENOSPC warning which can be triggered if '-odioread_nolock,nodelalloc' and quota are used. The bug was fixed by patch "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled". Signed-off-by: Liu Bo --- tests/ext4/034 | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ tests/ext4/034.out | 17 +++++++++++++ tests/ext4/group | 1 + 3 files changed, 93 insertions(+) create mode 100755 tests/ext4/034 create mode 100644 tests/ext4/034.out diff --git a/tests/ext4/034 b/tests/ext4/034 new file mode 100755 index 00000000..2449c3b7 --- /dev/null +++ b/tests/ext4/034 @@ -0,0 +1,75 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2018 Liu Bo, Alibaba. All Rights Reserved. +# +# FS QA Test 034 +# +# Regression test for a ENOSPC warning when both quota and +# "-o dioread_nolock,nodelalloc" is used. +# +# The bug was fixed by commit +# "Ext4: fix ENOSPC when both quota and dioread_nolock are enabled" +# +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter +. ./common/quota + +# remove previous $seqres.full before test +rm -f $seqres.full + +# real QA test starts here + +# Modify as appropriate. +_supported_fs generic +_supported_os Linux +_require_scratch +_require_quota +_require_nobody + +echo "Format and mount" +_scratch_mkfs "-O quota" > $seqres.full 2>&1 +_scratch_mount "-o dioread_nolock,nodelalloc" > $seqres.full 2>&1 +quotaon $SCRATCH_MNT 2>/dev/null + +echo "Create the original file" +touch $SCRATCH_MNT/foobar >> $seqres.full +chown nobody $SCRATCH_MNT/foobar >> $seqres.full + +quotaon $SCRATCH_MNT 2>/dev/null +echo "Set hard quota" +setquota -u nobody 0 10M 0 0 $SCRATCH_MNT +_report_quota_blocks $SCRATCH_MNT + +echo "Create 2 level extent tree (btree) for foobar with a unwritten extent" +$XFS_IO_PROG -f -c "pwrite 0 4k" -c "falloc 4k 4k" -c "pwrite 8k 4k" -c "pwrite 20k 4k" -c "pwrite 28k 4k" -c "pwrite 36k 4k" -c "fsync" $SCRATCH_MNT/foobar >> $seqres.full + +xfs_io -c "fiemap -v" $SCRATCH_MNT/foobar >> $seqres.full + +echo "Convert unwritten extent to written and collapse extent tree to inode" +$XFS_IO_PROG -c "pwrite 4k 4k" $SCRATCH_MNT/foobar >> $seqres.full + +echo "Create a new file and do fsync to force a jbd2 commit" +$XFS_IO_PROG -f -c "pwrite 0 4k" -c "fsync" $SCRATCH_MNT/dummy >> $seqres.full + +echo "sync $SCRATCH_MNT to writeback" +$XFS_IO_PROG -c "syncfs" $SCRATCH_MNT >> $seqres.full + +# success, all done +status=0 +exit diff --git a/tests/ext4/034.out b/tests/ext4/034.out new file mode 100644 index 00000000..dd0c8a7c --- /dev/null +++ b/tests/ext4/034.out @@ -0,0 +1,17 @@ +QA output created by 034 +Format and mount +Create the original file +Set hard quota +root 20 0 0 +nobody 0 0 10240 +User soft hard grace +Block time: 7days; Inode +Block File limits +---------------------------------------------------------------------- +*** for user quotas + + +Create 2 level extent tree (btree) for foobar with a unwritten extent +Convert unwritten extent to written and collapse extent tree to inode +Create a new file and do fsync to force a jbd2 commit +sync /mnt/scratch to writeback diff --git a/tests/ext4/group b/tests/ext4/group index b850f568..eb744a12 100644 --- a/tests/ext4/group +++ b/tests/ext4/group @@ -36,6 +36,7 @@ 031 auto quick dax 032 auto quick ioctl resize 033 auto ioctl resize +034 auto quick quota 271 auto rw quick 301 aio auto ioctl rw stress defrag 302 aio auto ioctl rw stress defrag