From patchwork Mon Nov 2 11:44:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873667 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64563C00A89 for ; Mon, 2 Nov 2020 11:45:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10DFF222B9 for ; Mon, 2 Nov 2020 11:45:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qfj7amzD" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728612AbgKBLpa (ORCPT ); Mon, 2 Nov 2020 06:45:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbgKBLpY (ORCPT ); Mon, 2 Nov 2020 06:45:24 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AB603C0617A6 for ; Mon, 2 Nov 2020 03:45:23 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id s9so14197891wro.8 for ; Mon, 02 Nov 2020 03:45:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L/1dSfgUmYvSGxjXScyhjjkeJuw81QdOwZR7q6CVPfI=; b=Qfj7amzDD6qRJfpPj7Kfaq0RN6Zfebg5cL2Y5QirGcThPfy/GdFzJEUlIhkxCxX2ej 8pN7J4WvJOwj2EX1YIXsel0XOyS7xvbsXCqRUU8ayU75Tezo1KQrxJOTXpJy/hQO79E1 oqSrIE3cAwDY1I1OIP13gFP8y6Uj8eXiTOATnEPNU3NGd2BPhxv4lSaZ0jNaFYRWR7ay 8PWlbSnokPxIRKb65tQC6IilvYeK8TDXUsNyKweT3tHgHpR+av+NhFWPQ39ThGcxTOmT aTCWSVNnZjc+4XSbqT/GXi7K2XrQ2Mmg/Jlur8r52OQojB1NMrzx1Oab4Lvt92n9ri+a FjmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L/1dSfgUmYvSGxjXScyhjjkeJuw81QdOwZR7q6CVPfI=; b=a1CWD/r2js4Zikg8xLnDddTNdBj0gSeMYIhIPfW8gQdF87nL4Nxg6xPNSVrUAy3BoF 0IE0CdzYOu3hnqxneawGUJb906rOB8uEEZAzUjjL0Ekz2FYJP3K8W8jWNbdXRrqX4RMW 2JHQOvhlMgU1Va8u5xaoVjzmvxb8nE2R1ZaXSbkrQTlxzB0efA1fNwSn8j+DMX7vGVeC PsENtrXjSLFhqT/r3EDGxggNyo5vp1QlYpCoRnuTcsx2dfCScbQC9DEHCKMSQWDuGVur Qe/TujCW2PqA9i7AIcM5SABafe+QTZ5RE7qXX6FgJZiVdc7nOF82jFMMUC4HtN/uGEx8 hgcw== X-Gm-Message-State: AOAM5332u7nz7ebBtA2cLQCDCRuuALc2qvjAKTo3rzLI1caCqLNLK617 WrgcQFWVho4LCt4xZSbnX3Cz0Q== X-Google-Smtp-Source: ABdhPJymAryJsxD86HRxteYOWKeQkGtIsslWIMb5neTnqMW+04ZCVn6ueDBGgX/iA9uK4VJVtgok4g== X-Received: by 2002:adf:f74e:: with SMTP id z14mr19575382wrp.312.1604317522365; Mon, 02 Nov 2020 03:45:22 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:21 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 01/30] net: fddi: skfp: ecm: Protect 'if' when AIX_EVENT is not defined Date: Mon, 2 Nov 2020 11:44:43 +0000 Message-Id: <20201102114512.1062724-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org When AIX_EVENT is not defined, the 'if' body will be empty, which makes GCC complain. Place bracketing around the invocation to protect it. Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’: drivers/net/fddi/skfp/ecm.c:153:29: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/ecm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/fddi/skfp/ecm.c b/drivers/net/fddi/skfp/ecm.c index 15c503f43727b..97f3efd5eb13c 100644 --- a/drivers/net/fddi/skfp/ecm.c +++ b/drivers/net/fddi/skfp/ecm.c @@ -147,10 +147,11 @@ static void ecm_fsm(struct s_smc *smc, int cmd) /* For AIX event notification: */ /* Is a disconnect command remotely issued ? */ if (cmd == EC_DISCONNECT && - smc->mib.fddiSMTRemoteDisconnectFlag == TRUE) + smc->mib.fddiSMTRemoteDisconnectFlag == TRUE) { AIX_EVENT (smc, (u_long) CIO_HARD_FAIL, (u_long) FDDI_REMOTE_DISCONNECT, smt_get_event_word(smc), smt_get_error_word(smc) ); + } /*jd 05-Aug-1999 Bug #10419 "Port Disconnect fails at Dup MAc Cond."*/ if (cmd == EC_CONNECT) { From patchwork Mon Nov 2 11:44:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873671 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7BF6C00A89 for ; Mon, 2 Nov 2020 11:45:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 54CF4222B9 for ; Mon, 2 Nov 2020 11:45:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U5nOshcF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728622AbgKBLpb (ORCPT ); Mon, 2 Nov 2020 06:45:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728587AbgKBLp0 (ORCPT ); Mon, 2 Nov 2020 06:45:26 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E61D6C061A04 for ; Mon, 2 Nov 2020 03:45:24 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id k18so9186543wmj.5 for ; Mon, 02 Nov 2020 03:45:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qTLTOT3UiP7umQhbUytVP5DdKiqnXHZ+scIPpasRwX8=; b=U5nOshcFMkIRwnZ7WqYwgy6vgOAvLlNMafEdOqovcaGuQwSbUQWG303JSKW26Wb/v2 Wm7N3kcb57OsFvdqqctn29+vCJkLykuCstn7Kf+KTjXLTeVzOB6B9zWVJ97mTkkG904P jES3hBetpsvS+hZxnmz0VRDE3tcSS+cNQi67hYIJ/eHe01+gAmL82vcxCxq8tovNtMdM pjD7qVkTLueYl+u1DBXXpXhf/Bhifzq3YVn9x8UBUKK23Qpn0Ndf7/A/fiCX36JR1fGl A4pKRVkQWYegPLIExk7PXwb0R1yZUwiQ5G3dwUZE1Db/DjSCjPd9ZFaYyhpzGAj1yKg9 hSAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qTLTOT3UiP7umQhbUytVP5DdKiqnXHZ+scIPpasRwX8=; b=fB2tyMhqjhyseXdDIGi2mtsQP/QysZUTMCco0CZ+3UVO/DivLNjNSCGq0VmVfn+0Rm 2RNoq2BmvPwwtFMQxtV8VhIj31O4HNr6Y+Gy9kcbf9+sFY4ZMwsk2SQfN+2Xxwxs1xTv WMdTGd7TSPBeZL2302qCyqh8TIAuzeFYNqZ+KpEf+AG6501uIlmsDFpyKkkXPjJEZjlv eyYeVxAq4P8Hpss6xij7b3T7WZTp7nXEcLAQl5Ib48owkGJFv9ZGi4+39+YgDBmajqgz 324kscIqX9U5fpLjtq6/MF87EPkwA6lY188Lg5kUNNNIQGTLRBdh2jNzmV4XSAwHk+cH hpUQ== X-Gm-Message-State: AOAM532sDYtZWheCSkUSLuT46gBIveIgFVs6YcH1w3e4yXGfrFYoCfs1 rf9HwZojH0CC6RkMg6E6rtMR2w== X-Google-Smtp-Source: ABdhPJxWBIDDJ9Hbor8TSdj63tk0OaicVZFIzsP+XZstpxjIm4DgBlg8Z2N9iqjfTPYvgVIY+d3b2A== X-Received: by 2002:a1c:c286:: with SMTP id s128mr17255914wmf.88.1604317523577; Mon, 02 Nov 2020 03:45:23 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:22 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 02/30] net: fddi: skfp: ecm: Remove seemingly unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:44 +0000 Message-Id: <20201102114512.1062724-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org This variable is present in many source files and has not been used anywhere (at least internally) since it was introduced. Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/ecm.c: In function ‘ecm_fsm’: drivers/net/fddi/skfp/ecm.c:44:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Lee Jones Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/ecm.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/ecm.c b/drivers/net/fddi/skfp/ecm.c index 97f3efd5eb13c..2f5f5f26bb434 100644 --- a/drivers/net/fddi/skfp/ecm.c +++ b/drivers/net/fddi/skfp/ecm.c @@ -40,10 +40,6 @@ #define KERNEL #include "h/smtstate.h" -#ifndef lint -static const char ID_sccs[] = "@(#)ecm.c 2.7 99/08/05 (C) SK " ; -#endif - /* * FSM Macros */ From patchwork Mon Nov 2 11:44:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873669 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 427CCC2D0A3 for ; Mon, 2 Nov 2020 11:45:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE3C3222B9 for ; Mon, 2 Nov 2020 11:45:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VJ7OQqxC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728670AbgKBLps (ORCPT ); Mon, 2 Nov 2020 06:45:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728602AbgKBLp1 (ORCPT ); Mon, 2 Nov 2020 06:45:27 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DE06C0617A6 for ; Mon, 2 Nov 2020 03:45:26 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id a9so14187060wrg.12 for ; Mon, 02 Nov 2020 03:45:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=yNA/lsoUC0LQBBnCzXfTlR1/o1qLqZQkYjPe/aZZUWk=; b=VJ7OQqxCtsMIFKYTVkbAQsy4Gl9fa43vLa9eRWIIWy83//s/L6RVTdlWoNurw28qak RLF6Z7wCmTpYP4Ezmq/ji3TCV0jSs345gzdEvm2bDiZW+/rx/UMs47jwhZ+F4mRHfY4L VdDLv8oXbAQS/zpMKs3v836D25W7uolqLtcj2c5ZNC0VqZCN+t2t9LU6vwumhKv0ew48 UPhgAIszuq7G0Lcbux7lR8Sjl6Ff6zfqvnHW3FxurZUIjieAyiKIZaPCha57yAYnSHSW fgFrWHiIRBG1v25ceQ5XPV/55I5AvrsSfEkSJNq7ALMJoIggQVDQizmNXEmDbblKe0Jv gsew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=yNA/lsoUC0LQBBnCzXfTlR1/o1qLqZQkYjPe/aZZUWk=; b=L5B5zi6g19nVTBgFYAnnl/a0Mc7dDhRSZElIkudqzAteepcU4dMie8fDCU+9iUXHDI W7O1PN2gL5CJH+AsoFPDiP4NHnhn+0jWvKSRNrYjoXTpGc2/aGhF8WHbTm1YGF0WyE+2 1rHuFISOcK8+mvMr+6Jc5NN6vb+4EcX0+MaT1C2Yy7V08K4pOpp6P4cnJDjMk3vN0A3F qvUCaFtJxr6IYR+tscyhLVrBWVLHVqsJDcdf0vBcG8sZek7GPDCWeINSGqNh9LglXL6H igIMetnFFzMF3ea0JXVR7BXVLJ2obvrmbQi+GUwcbqaj3+00KPoAYChdvLioyDj0xa9D wnmw== X-Gm-Message-State: AOAM530ItaNvSDkUD6It3vmsHfsq8vxw2udfqv0MoXHQBJJLAoCak1gJ zqFwXD6wz/kGCOaMMVqYvAgOIg== X-Google-Smtp-Source: ABdhPJyMDwWSXDu4EYwBHjPgqYG7q1YuMC8d2HWbou7grThryxqWTPwEwgzghHp+jOXfgaBsD8F5FQ== X-Received: by 2002:adf:cf10:: with SMTP id o16mr19694571wrj.264.1604317524782; Mon, 02 Nov 2020 03:45:24 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:24 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , "Gustavo A. R. Silva" , netdev@vger.kernel.org Subject: [PATCH 03/30] net: fddi: skfp: pcmplc: Remove defined but not used variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:45 +0000 Message-Id: <20201102114512.1062724-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/pcmplc.c:49:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: "Gustavo A. R. Silva" Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/pcmplc.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/pcmplc.c b/drivers/net/fddi/skfp/pcmplc.c index 554cde8d6073e..90e8df6d9a88a 100644 --- a/drivers/net/fddi/skfp/pcmplc.c +++ b/drivers/net/fddi/skfp/pcmplc.c @@ -45,10 +45,6 @@ #define KERNEL #include "h/smtstate.h" -#ifndef lint -static const char ID_sccs[] = "@(#)pcmplc.c 2.55 99/08/05 (C) SK " ; -#endif - #ifdef FDDI_MIB extern int snmp_fddi_trap( #ifdef ANSIC From patchwork Mon Nov 2 11:44:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873673 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D14D6C2D0A3 for ; Mon, 2 Nov 2020 11:45:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CFF4223BE for ; Mon, 2 Nov 2020 11:45:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mEp+m8Xh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728657AbgKBLpx (ORCPT ); Mon, 2 Nov 2020 06:45:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728607AbgKBLp1 (ORCPT ); Mon, 2 Nov 2020 06:45:27 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32465C061A47 for ; Mon, 2 Nov 2020 03:45:27 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id n15so14255786wrq.2 for ; Mon, 02 Nov 2020 03:45:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UI9R8pRGKqPSITi9y8opWbYC7XAAhjSoyXUvokLORX4=; b=mEp+m8Xhrz9N/YGJLRO6c2twOaJT24f6qd/l+oej5MSobh+oZAOjuxMu4Zzij0Nqil HOrcMHfUNHdNECZzN0b7YtsAoBeyyfzGO07oOZTKWy/Io0RWtagh+VLSh9bie5qgQTx+ 6jsT+jCNOnLVWXz/Kc2BxjCtrh2Qo8pE2S2sQd2VVqewC7fD2HYroG/27m/nQ4TYImgX sNLGwV4ObpMpmu+mbVhZI1x+z20A3G/mJosGd51gxmJwavGSfArCGiR6Gwwvy6NXUaAL Y6bQNfXLujT/YtCoVVcKP56AnwUTpQXy1h45KQ22HtqNfXSvzIs6Pie9t09yVi8aBxwK kneA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UI9R8pRGKqPSITi9y8opWbYC7XAAhjSoyXUvokLORX4=; b=QbUxWeE+/1EvmP7xzomqJCiKZBqk33MctXQJI5OHfxOdcR0FN1qesfFvNxQDUX7FgH ip0T3nWI5orHVf1pTq+tjwK5xHcBiL5QUQktJpEzJ8qBVNdaKQB0wqcOU+aSYXSudD8u SFgQYHbtkO3kqMj8f6ZNUtRIWnFmplZ7qV0letbhCh6VQvuK1qCtXsmx59SizOLhS5R3 eNRrhhz7EvGYa9OV4e6tpVWw8qcNEY3+6J27WgGdSOyWs9GdKSNAihpHD36oZMEjRFUh 9N+zRtohAhud0Df2rtDvVI9TZnQYHCYEPZqvbRbm6bMwPxird2uUV5uw2KDQiOSLdKBf TYJw== X-Gm-Message-State: AOAM530rAvx6bu+/bmbUzhjrUdbwQnO3Rn0unn/1Vrc7hbjCEzbPXjIe gtwSbWfm4A4Q8ktezb5Dku8b9w== X-Google-Smtp-Source: ABdhPJzLCe0UVqCjxOxtF46/ekMeCDXDavB+LsuZEq0PQMFxWtAJOdlBewan7+tdB3iwhNknzTT8WQ== X-Received: by 2002:a5d:4001:: with SMTP id n1mr20203003wrp.426.1604317525943; Mon, 02 Nov 2020 03:45:25 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:25 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Inaky Perez-Gonzalez , linux-wimax@intel.com, Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 04/30] net: wimax: i2400m: control: Fix some misspellings in i2400m_set_init_config()'s docs Date: Mon, 2 Nov 2020 11:44:46 +0000 Message-Id: <20201102114512.1062724-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/control.c:1195: warning: Function parameter or member 'arg' not described in 'i2400m_set_init_config' drivers/net/wimax/i2400m/control.c:1195: warning: Excess function parameter 'arg_size' description in 'i2400m_set_init_config' Cc: Inaky Perez-Gonzalez Cc: linux-wimax@intel.com Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/staging/wimax/i2400m/control.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wimax/i2400m/control.c b/drivers/staging/wimax/i2400m/control.c index fe885aa56cf37..1e270b2101e86 100644 --- a/drivers/staging/wimax/i2400m/control.c +++ b/drivers/staging/wimax/i2400m/control.c @@ -1183,11 +1183,11 @@ static int i2400m_cmd_get_state(struct i2400m *i2400m) * Set basic configuration settings * * @i2400m: device descriptor - * @args: array of pointers to the TLV headers to send for + * @arg: array of pointers to the TLV headers to send for * configuration (each followed by its payload). * TLV headers and payloads must be properly initialized, with the * right endianess (LE). - * @arg_size: number of pointers in the @args array + * @args: number of pointers in the @arg array */ static int i2400m_set_init_config(struct i2400m *i2400m, const struct i2400m_tlv_hdr **arg, From patchwork Mon Nov 2 11:44:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873751 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D931C2D0A3 for ; Mon, 2 Nov 2020 11:48:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD1E4222B9 for ; Mon, 2 Nov 2020 11:48:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Isl9bk4B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728864AbgKBLsy (ORCPT ); Mon, 2 Nov 2020 06:48:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728610AbgKBLpa (ORCPT ); Mon, 2 Nov 2020 06:45:30 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48BC8C061A48 for ; Mon, 2 Nov 2020 03:45:28 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id g12so14188530wrp.10 for ; Mon, 02 Nov 2020 03:45:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S8vpnZmXz9iLnkLUB3C6XR52IXLaRp3UFxZH+gyvs48=; b=Isl9bk4BepGjbjN2Gsn8Amc0qbhI3yVqYtwyU13dln8QhJx46A+HtaRtz8cef2AqIg jqwcA06LcgAd03VDbCjuWcosIbL27KVy6ElOVejAn4DIHU5NDfuV0u7J/u5oDjpD+5fI apB69q5qusne9jhbuWe/6KItNRgQ6eXMj4VZJ+kEoS7u0OIflKpeZGXfSyc04ZrUYnUB 7BDrLFUjOMMgiIXjpLQhXHhSTVfd19q9TzBehpXveYyoxhQbmsiixu29i+yBekWABtst 7Ic8apkazKDrGzryyoeqJ+Snh2XfzBoEFtiLxishAjYdyFE+WuBTI101PcsPH5GcX/gL Gj1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S8vpnZmXz9iLnkLUB3C6XR52IXLaRp3UFxZH+gyvs48=; b=ZyAlx5SVz7bgGhMNeE3trv/bs7DNtF97wyP4kW5Cc8u3+60ZDDOaoT51MCqqxGEMex kl/Sy17S+34XOOiKoaEhRD9P5Ll9ChX8zFLGDfC824Pto5vZY+QEpI0xrJzWHvI4qOMU FbSv0M8JG2HsA2zBNqTq4/k7Zzh942X54UV/QGlXl74SF+i/TAcC/zrAN4eqw1j7UuqF cM0RJkPkGA1yXa3FvFZdgh5a3tKuTwn27xAB69vbraUTOTI/6oWUSmfqcOZEUMgh7V0E 9iwNJZsZW2AnKYjL6iWzXUil/md+L0YoyM3nn0TUpP4a9eVtSF5308+IVkNG5TYRf0b1 CCeQ== X-Gm-Message-State: AOAM532N1OaIfr/3pBtQ2h9gX3EYFTRLYPOxa3ISHR50ul/cQQFwBYlH WCcgH6EKNMmwMcwwwIdAJeCPEZu/2FHi0Q== X-Google-Smtp-Source: ABdhPJwRTx0erMAvX+JBVQyr1LqvyNTp2cMUC+akvqWOQ0BhhuBie6CoqGiBGKIMRKrWphWdaTiWOA== X-Received: by 2002:adf:fe48:: with SMTP id m8mr19495866wrs.127.1604317527059; Mon, 02 Nov 2020 03:45:27 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:26 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Inaky Perez-Gonzalez , linux-wimax@intel.com, Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 05/30] net: wimax: i2400m: driver: Demote some non-conformant kernel-docs, fix others Date: Mon, 2 Nov 2020 11:44:47 +0000 Message-Id: <20201102114512.1062724-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/driver.c:681: warning: Function parameter or member 'i2400m' not described in 'i2400m_dev_reset_handle' drivers/net/wimax/i2400m/driver.c:681: warning: Function parameter or member 'reason' not described in 'i2400m_dev_reset_handle' drivers/net/wimax/i2400m/driver.c:775: warning: Function parameter or member 'i2400m' not described in 'i2400m_init' drivers/net/wimax/i2400m/driver.c:842: warning: Function parameter or member 'bm_flags' not described in 'i2400m_setup' drivers/net/wimax/i2400m/driver.c:942: warning: Function parameter or member 'i2400m' not described in 'i2400m_release' Cc: Inaky Perez-Gonzalez Cc: linux-wimax@intel.com Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/staging/wimax/i2400m/driver.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/wimax/i2400m/driver.c b/drivers/staging/wimax/i2400m/driver.c index dc8939ff78c0e..f5186458bb3d4 100644 --- a/drivers/staging/wimax/i2400m/driver.c +++ b/drivers/staging/wimax/i2400m/driver.c @@ -665,7 +665,7 @@ void __i2400m_dev_reset_handle(struct work_struct *ws) } -/** +/* * i2400m_dev_reset_handle - Handle a device's reset in a thread context * * Schedule a device reset handling out on a thread context, so it @@ -685,7 +685,7 @@ int i2400m_dev_reset_handle(struct i2400m *i2400m, const char *reason) EXPORT_SYMBOL_GPL(i2400m_dev_reset_handle); - /* +/* * The actual work of error recovery. * * The current implementation of error recovery is to trigger a bus reset. @@ -766,7 +766,7 @@ void i2400m_bm_buf_free(struct i2400m *i2400m) } -/** +/* * i2400m_init - Initialize a 'struct i2400m' from all zeroes * * This is a bus-generic API call. @@ -831,6 +831,7 @@ EXPORT_SYMBOL_GPL(i2400m_reset); * i2400m_setup - bus-generic setup function for the i2400m device * * @i2400m: device descriptor (bus-specific parts have been initialized) + * @bm_flags: boot mode flags * * Returns: 0 if ok, < 0 errno code on error. * @@ -933,7 +934,7 @@ int i2400m_setup(struct i2400m *i2400m, enum i2400m_bri bm_flags) EXPORT_SYMBOL_GPL(i2400m_setup); -/** +/* * i2400m_release - release the bus-generic driver resources * * Sends a disconnect message and undoes any setup done by i2400m_setup() From patchwork Mon Nov 2 11:44:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873749 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFA61C2D0A3 for ; Mon, 2 Nov 2020 11:48:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CF35222B9 for ; Mon, 2 Nov 2020 11:48:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bKwIQdAn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728860AbgKBLst (ORCPT ); Mon, 2 Nov 2020 06:48:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728616AbgKBLpb (ORCPT ); Mon, 2 Nov 2020 06:45:31 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77B2EC061A49 for ; Mon, 2 Nov 2020 03:45:29 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id y12so14217308wrp.6 for ; Mon, 02 Nov 2020 03:45:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ovie+dxspvrU5u8+4wDypRlKJmG6Xumo/oagtBBwY2g=; b=bKwIQdAnp/kv2/fCVRgBZpe17vYm8/pAkopdSiLaVAAEeqtSNnYKfQojLimBEUYe6F TnwQ0/R0n3TuTnVFSZD2O+pnB3SzYIhkJUjB+HnKrT7+4aHfZKwQj+Quc6WhHFSHI0Oe t2ah0F5oBlLM3HHGdA0fiH0FELST3HRKp7wKkeFVgJNm227dSWcSFiKzKQqeX+6zO7R/ SxxhjOsHT2PFKxWNst0iONDkLkkVfR7SMGzSQRbU9VMbSNdXl9SBRsxDEMXMGy/QAixH +qsZ1wB7hICLkWTkKCzun+BLDx20BTZ3oJ8hBz2nFRRFOGuFQHJ8OVQ/vpH4SWEUL+fg dQCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ovie+dxspvrU5u8+4wDypRlKJmG6Xumo/oagtBBwY2g=; b=XzKMhUH8lH4yC8lgLtSQ2YqtXyaK1sXQxNOd2tx0MQSYWKVRUR8w8t5GdytG1i5X0w 9vRaqNwmvlbr6OcOrpq7b7dSQs1K77ysHvIkOP5G/sztIdi4HXJFOKjlGuT3P/tNKxS5 qUgKwh5tNDI1mYNnafEW9LEk6kPj7/mrrt1PfymYqOvKtfBEhyCkcRUvgNjTFyYwtSPR 88ZxIgmyv3srmbDd84Jmth79G4qEWhWl8HBJcJJ6i8eEqFwlxfzVBzucMSGrQvgMxZ0Y 8DEx98y2mzWadJOZPoVqPL21BZNXdSuqCSDLbv+tQNN3SUXR25X5XpSDs/c+1eZOIgmO hrYQ== X-Gm-Message-State: AOAM530tWEvzSfrx4DGn6t6i6St9vF+c8TNv9wdAGdOxdajKvHT4v0WO nSwN6r1AoxySe4tzIcIbXQsNPA== X-Google-Smtp-Source: ABdhPJz77Ti9iG1aZnh7BZeK40/QFiM41qDrrepDbBJsPnTPjLG6Kl4EnPZomOQL1Gxcl1oTyav9Aw== X-Received: by 2002:adf:f20f:: with SMTP id p15mr20042117wro.339.1604317528202; Mon, 02 Nov 2020 03:45:28 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:27 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Inaky Perez-Gonzalez , linux-wimax@intel.com, Jakub Kicinski , Yanir Lubetkin , netdev@vger.kernel.org Subject: [PATCH 06/30] net: wimax: i2400m: fw: Fix some function header misdemeanours Date: Mon, 2 Nov 2020 11:44:48 +0000 Message-Id: <20201102114512.1062724-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/fw.c:584: warning: Function parameter or member 'i2400m' not described in 'i2400m_bm_cmd' drivers/net/wimax/i2400m/fw.c:584: warning: Excess function parameter 'returns' description in 'i2400m_bm_cmd' drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member 'chunk' not described in 'i2400m_download_chunk' drivers/net/wimax/i2400m/fw.c:646: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk' drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf' description in 'i2400m_download_chunk' drivers/net/wimax/i2400m/fw.c:646: warning: Excess function parameter 'buf_len' description in 'i2400m_download_chunk' drivers/net/wimax/i2400m/fw.c:1548: warning: Function parameter or member 'flags' not described in 'i2400m_dev_bootstrap' Cc: Inaky Perez-Gonzalez Cc: linux-wimax@intel.com Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Yanir Lubetkin Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/staging/wimax/i2400m/fw.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c index 6c9a41bff2e0a..9970857063374 100644 --- a/drivers/staging/wimax/i2400m/fw.c +++ b/drivers/staging/wimax/i2400m/fw.c @@ -534,6 +534,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode, /** * i2400m_bm_cmd - Execute a boot mode command * + * @i2400m: device descriptor * @cmd: buffer containing the command data (pointing at the header). * This data can be ANYWHERE (for USB, we will copy it to an * specific buffer). Make sure everything is in proper little @@ -566,7 +567,7 @@ ssize_t __i2400m_bm_ack_verify(struct i2400m *i2400m, int opcode, * * @flags: see I2400M_BM_CMD_* above. * - * @returns: bytes received by the notification; if < 0, an errno code + * Returns: bytes received by the notification; if < 0, an errno code * denoting an error or: * * -ERESTARTSYS The device has rebooted @@ -634,8 +635,8 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m, * i2400m_download_chunk - write a single chunk of data to the device's memory * * @i2400m: device descriptor - * @buf: the buffer to write - * @buf_len: length of the buffer to write + * @chunk: the buffer to write + * @chunk_len: length of the buffer to write * @addr: address in the device memory space * @direct: bootrom write mode * @do_csum: should a checksum validation be performed @@ -1533,6 +1534,13 @@ void i2400m_fw_put(struct i2400m_fw *i2400m_fw) * i2400m_dev_bootstrap - Bring the device to a known state and upload firmware * * @i2400m: device descriptor + * @flags: + * I2400M_BRI_SOFT: a reboot barker has been seen + * already, so don't wait for it. + * + * I2400M_BRI_NO_REBOOT: Don't send a reboot command, but wait + * for a reboot barker notification. This is a one shot; if + * the state machine needs to send a reboot command it will. * * Returns: >= 0 if ok, < 0 errno code on error. * From patchwork Mon Nov 2 11:44:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873675 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C77BCC00A89 for ; Mon, 2 Nov 2020 11:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6BAA121556 for ; Mon, 2 Nov 2020 11:46:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IxN7oIBL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728387AbgKBLqF (ORCPT ); Mon, 2 Nov 2020 06:46:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728614AbgKBLpa (ORCPT ); Mon, 2 Nov 2020 06:45:30 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 917F6C0617A6 for ; Mon, 2 Nov 2020 03:45:30 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id n15so14255987wrq.2 for ; Mon, 02 Nov 2020 03:45:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t4Kp5LGeouttAwFs/VHXrMGULx219tqmwLf1j6gGnyc=; b=IxN7oIBLixmziOnZEDfpg27SlZeeQzLHDly3rD5PBvgtwybxQOTRJ0dk4s4ZO7bXHR aug3rJXvjD9RzjNxoViF2PSD/LHbzVCwu71S9r0EZP4kJcPL1zJGVG1ZF4+/rD1dp6v2 N5gD2xyA21UGdYU4i1FF+XcjbCXYAteV2AU8rMQ9/3suud0r9Cb/ZFhzorcdE+1PK5As EX/rxZ1q2fqjl5clMvK9xKmWbNFYPcKxU3P0OYhbXgKjqz8W6tXAtKwqEtXbM4ZIVMHG 2viNNszSJcVPikgKJzE1C5gJ/5HrNnyqsFZATzGEaWH0Ucxi1Y3j9HQB7v12b3hmn05w FVhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t4Kp5LGeouttAwFs/VHXrMGULx219tqmwLf1j6gGnyc=; b=c1c7MjdmcqD+PWbpnyFkKNjZIAMsJNVjcjxXsWi7VpkMze9Pf4TdD5/b/bxva56E8L +YxqolqeldqEn9Hs/RlWcBhYmwe130cbf7ZA2jNSR0J/xafwVxD+goU6OQDcxrZHrfkt wlslWquq/uHNHIHMEERa8HAIHfjT8yfAOT12cXrHmSRXwk8zyLug7Jn8AWDJNMGa4+sW 6BlcvAqHab6whpFUasZahmEicMyR8wLY8SWlpjsVShCER0pcJW7XX2aybguMRXyzrZMX ORX1DC5vO28cU4IlSubDC5NOnRctyvzY/3//Iw0wYDaebAd8U59S67iw4l8gyD67sSGQ sfJw== X-Gm-Message-State: AOAM533U5O14kAlR+YpZE1AaZSTK3ubM+i/z9W6A2JwBYqxVRMEQp8EM L9Tr8+fSjJ84iD1iptFDh3FmPtWreMbMrA== X-Google-Smtp-Source: ABdhPJwgk09rZHq7NiCiX4EOKV9gPkTQ+xO+kvkTLALfOhOJmvVxUvUQo47QQ3HEgLidB7rTqRzZYg== X-Received: by 2002:a5d:5449:: with SMTP id w9mr20774903wrv.182.1604317529366; Mon, 02 Nov 2020 03:45:29 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:28 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 07/30] net: fddi: skfp: pmf: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:49 +0000 Message-Id: <20201102114512.1062724-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/pmf.c:28:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/pmf.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/pmf.c b/drivers/net/fddi/skfp/pmf.c index 14f10b4cab0fc..563fb7f0b327e 100644 --- a/drivers/net/fddi/skfp/pmf.c +++ b/drivers/net/fddi/skfp/pmf.c @@ -24,10 +24,6 @@ #ifndef SLIM_SMT -#ifndef lint -static const char ID_sccs[] = "@(#)pmf.c 1.37 97/08/04 (C) SK " ; -#endif - static int smt_authorize(struct s_smc *smc, struct smt_header *sm); static int smt_check_set_count(struct s_smc *smc, struct smt_header *sm); static const struct s_p_tab* smt_get_ptab(u_short para); From patchwork Mon Nov 2 11:44:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873747 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E22BC00A89 for ; Mon, 2 Nov 2020 11:48:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 128CB21D91 for ; Mon, 2 Nov 2020 11:48:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vAXWx6/5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728850AbgKBLss (ORCPT ); Mon, 2 Nov 2020 06:48:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728555AbgKBLpb (ORCPT ); Mon, 2 Nov 2020 06:45:31 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B48EC061A04 for ; Mon, 2 Nov 2020 03:45:31 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id c18so9078815wme.2 for ; Mon, 02 Nov 2020 03:45:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=s8uoq2NTqcU9/GZu8TClmlUCrHQkyQ7sDiNoJZkjYgE=; b=vAXWx6/5P9RNoz41owRIxlCUNS6pTDSvi8iEDC7bc5eVIy7dWDEvqkBnb/+B8VCC5h vKRv6FncC403gCgly1EBy0D7G9ACjQ90tp8PyGSGqB0FcdFe84IX39qxwEqGhapq7KCl u/MhPY/y+80sir4OZZZagrF3oy+KaFEmzpBUIx02yWavPSIRG4uquJCPkbLwFiOLYavD Fp8421yZq/GmvkVTeq6SqVN7JD+XEKNlcvHVcTFi2gAe0rrKU+9BR2N0ERsVAxGiRDX/ e7QQ3qMS3J7dQXGwPJ9WhWnBIkQp6sVD62vFqicb3ArDnXemliqwIRugY8w8VcYvwdd1 4zsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=s8uoq2NTqcU9/GZu8TClmlUCrHQkyQ7sDiNoJZkjYgE=; b=iCihWRNlxQj8RVLhcR0VOcPnVYh9i6+rsgGoK4GWMlxrAnvddxf+yqA9ZrsL8AEEuG kSB6HtXW8eiB+hyXkK9szf9C+qDyZoFzQci2X0TdMJowQp/uq4bIPTUop36EAho+9PZ8 vINc8p27F7a6fyD+DfAk1dX2rrJG+M0C3Gy5v3/LGmCIwVAS19O+6lLXgrtskN/zU2/7 sZIr4rmY/cj+H/nzK8R4eGfvQVKgdIm8NQHW8IgLOK0Db9+TSw4UjJsQSahXn0RbZuK3 1SVlOKYbVbVwf41UyenL3BINdGoiCgoy3A0rVVZYYXeWOLEn9zXVaICq2d8Mp9QaHWSX zvPw== X-Gm-Message-State: AOAM531DgVNDfqI93gxzimvu5gOasEzUfU7LXCNNU3TMTsj48wRGHI+j Ss1OwxrrEZxpw6OaHhb4v5MtXA== X-Google-Smtp-Source: ABdhPJyXzWkITGxxQ9FjUyHajtWPlgfvwJItE4etXIVGEyPXrEJUxHMPKUaCkrkgeWhPJUdZDuBypA== X-Received: by 2002:a1c:1f51:: with SMTP id f78mr17511311wmf.162.1604317530266; Mon, 02 Nov 2020 03:45:30 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:29 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 08/30] net: fddi: skfp: queue: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:50 +0000 Message-Id: <20201102114512.1062724-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/queue.c:22:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/queue.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/queue.c b/drivers/net/fddi/skfp/queue.c index ba022f723bd77..abe155ad777fa 100644 --- a/drivers/net/fddi/skfp/queue.c +++ b/drivers/net/fddi/skfp/queue.c @@ -18,10 +18,6 @@ #include "h/fddi.h" #include "h/smc.h" -#ifndef lint -static const char ID_sccs[] = "@(#)queue.c 2.9 97/08/04 (C) SK " ; -#endif - #define PRINTF(a,b,c) /* From patchwork Mon Nov 2 11:44:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873737 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38022C00A89 for ; Mon, 2 Nov 2020 11:48:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4E69222B9 for ; Mon, 2 Nov 2020 11:48:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bUWQy+kC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728849AbgKBLsn (ORCPT ); Mon, 2 Nov 2020 06:48:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728623AbgKBLpd (ORCPT ); Mon, 2 Nov 2020 06:45:33 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6B12C061A47 for ; Mon, 2 Nov 2020 03:45:32 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id b3so8305828wrx.11 for ; Mon, 02 Nov 2020 03:45:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+2KZ3fjSfA5rxM50Oa10TVdHu/XQWkPodLQYHhtQcE0=; b=bUWQy+kCDkS/NX4JSWWFlkB2qfE5HPUBe+REeZUWKsu/r8ZQBAJZBkMvpvYuQ5kwpr q6fP8WNfRHW7dKZDf1G5OCRzTOQZJqtky6GDsfmiX0Oh/cXv6jmWI8Wc8RUnKxXHipIY TTeWNg8I8GhuiBcMojie8Z9SrcB+2kgJZg7nJa+3xG/v9zz6t/P2ySJ6/RD449Lc526N W6hFcr4N/rdH+GNT1WTtCx0M1pNZDleJfMTCiP+Fw9JoSIUHvz3ISg5kZEoPxaf67u+9 b7bjBot3HFWvcF74XXvJOZdCLMLD90MLKgIlTNVbALIAju/+SMZrtNmD4GKMKJDVIoSW BdcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+2KZ3fjSfA5rxM50Oa10TVdHu/XQWkPodLQYHhtQcE0=; b=tcdCJjznvAplHnuHkxvGLTrV5tHHKRQOdHpy0D8QUPNbe+gMGpFFkXz1MJ137l2omi pjYkmUoLibXnaMs+2zSfzREUr7S53XYsLLaMA/6mk64vkbvodLHgJqibXgtwtbW4m3oi SebNK7jndD/IHGPteNJkFe0ObKmlhWaBQvF3qS+iL5HGgp9ckyFvOJPOjphAUxy304wN eTlWiVTxEOqfehbct5i2wEs3Ji6Y1LoTv0xUGo39ZFnhLcdRt94cWaXZbIn/0vUK5WE5 JpX1Xdzwlt+2zi80QFxAYy24rqJwnyDAWRjuOGCkfYh6Ty/cOGay2mN2igyNVvMm62EZ PzqQ== X-Gm-Message-State: AOAM533XCdcYHn7dndcEHKsxcI6iywxkbd9rJpkCq9ZJw06efwt7MJzS sOA99lDM4t1U2ObTGXRnTMXlZg== X-Google-Smtp-Source: ABdhPJxnYbxqwLRNHyRJSGfG7OmLrUKnO0ZLPWJGqwZCxUdzeRjJDy57NtJo9lLeu1yt+VB4xlT/hQ== X-Received: by 2002:adf:8bce:: with SMTP id w14mr19173150wra.242.1604317531478; Mon, 02 Nov 2020 03:45:31 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:30 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 09/30] net: fddi: skfp: rmt: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:51 +0000 Message-Id: <20201102114512.1062724-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/rmt.c:49:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/rmt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/rmt.c b/drivers/net/fddi/skfp/rmt.c index c0e62c25332cd..37a89675dbeb3 100644 --- a/drivers/net/fddi/skfp/rmt.c +++ b/drivers/net/fddi/skfp/rmt.c @@ -45,10 +45,6 @@ #define KERNEL #include "h/smtstate.h" -#ifndef lint -static const char ID_sccs[] = "@(#)rmt.c 2.13 99/07/02 (C) SK " ; -#endif - /* * FSM Macros */ From patchwork Mon Nov 2 11:44:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873735 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D87C00A89 for ; Mon, 2 Nov 2020 11:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88BEC21D91 for ; Mon, 2 Nov 2020 11:48:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eGhBIevm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728488AbgKBLsl (ORCPT ); Mon, 2 Nov 2020 06:48:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728624AbgKBLpe (ORCPT ); Mon, 2 Nov 2020 06:45:34 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C62CCC0617A6 for ; Mon, 2 Nov 2020 03:45:33 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id c9so7536729wml.5 for ; Mon, 02 Nov 2020 03:45:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VNb8tUXKXaGPMudLrBc3JPhFZfoOGbf5hBAlPTwGRzw=; b=eGhBIevmjNMHiNEGCAcW9TKr7444xX6cMHtFbNgUtVJonOfdYHrUovSmSFG1OEgAVa DwSZ+s994nqhFWZDd/NY6vpfOvIYEKPU4jDfh0ai65XIkbJOzPiksZGwt0zvm2HghjfT rF7/XWxXygS5/ntS/iGGK9tNS3VKo3XkwuH0JvNBDlU7hCchd5vFUauYE2xgLjSX6sE9 bJzat6Dk31BjZj6yJUZmqv1eym6NzeAjxWtHY9dLCAdujrwiBQIxn1YJRPO1lgMqRSgV kUFefB7DDqj8rDLNCz9qF2eSFKktdYRg49rc+faNAs8gYMJltDeKXtQD4OtckSpML4G/ qxLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VNb8tUXKXaGPMudLrBc3JPhFZfoOGbf5hBAlPTwGRzw=; b=s9swCkTGINsnbbDGLM+Mkrb6E/7K9dqAn52VKWlid745PObU5Osk+HyuZl0YT2J174 ddwr74MO7bTdPXMIx0HnweOmiiS9ymM9m3oLvBC2O1HDCAU3NOYAqpxsx+1Kbsg+U0NK sz7bSwcUN1WNuI6JudOupIPSDBfTls05wFAaeu4A9xXlqfdtCWiVDtvw/LUZrdR5BkmC /gql4P+S/fjG+kss5Y8yTOkZLynqz/NnNdtcz1cH6o53ykiruDK2CRNyZ9haDgoJTRcB dQund+yQXQx/HlAtLN6T5PpTy2XvGryp74RQJg39Unb659L7WDT5Qmyh0nq9vzTEA7I3 WMQA== X-Gm-Message-State: AOAM533cmDv7eLhHyPwJPDWO4c4tkt5nFGarw4/ekGxlzcU8VMW5UwM8 KBcT+feu0NrcNLhO5Xi2F8kwkgR62KTf9w== X-Google-Smtp-Source: ABdhPJxg7UXmajOaGgu37gUYzDyNFKznZa8dzo2gwZyLGxCJ/DCj9KsQNdbHQK0/87ixIv7G2zhv/w== X-Received: by 2002:a1c:1d92:: with SMTP id d140mr17296806wmd.48.1604317532592; Mon, 02 Nov 2020 03:45:32 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:32 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 10/30] net: fddi: skfp: smtdef: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:52 +0000 Message-Id: <20201102114512.1062724-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/smtdef.c:26:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/smtdef.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/smtdef.c b/drivers/net/fddi/skfp/smtdef.c index 0bebde3c6cb9a..99cc9a549bd7e 100644 --- a/drivers/net/fddi/skfp/smtdef.c +++ b/drivers/net/fddi/skfp/smtdef.c @@ -22,10 +22,6 @@ #define OEM_USER_DATA "SK-NET FDDI V2.0 Userdata" #endif -#ifndef lint -static const char ID_sccs[] = "@(#)smtdef.c 2.53 99/08/11 (C) SK " ; -#endif - /* * defaults */ From patchwork Mon Nov 2 11:44:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873691 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DF29C388F2 for ; Mon, 2 Nov 2020 11:46:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15D6C223BD for ; Mon, 2 Nov 2020 11:46:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SufM/3lm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728715AbgKBLqW (ORCPT ); Mon, 2 Nov 2020 06:46:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728626AbgKBLpf (ORCPT ); Mon, 2 Nov 2020 06:45:35 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB791C061A48 for ; Mon, 2 Nov 2020 03:45:34 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id k18so9187024wmj.5 for ; Mon, 02 Nov 2020 03:45:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Bo49ib5VL9yqey9VyX7XP5zl1YXqZIOtWGudOLG0P1Q=; b=SufM/3lmzUDYSfCpW5FTrP8RpUmf0MYSFD4/squLedHDglTvM71nyDDnTfTPMTlY6j hvLMCOU+6AUYf9I7/ierRm3DXRgWN9UWRUm160CfQVax37Oowe9aXm9cote2n4gWSEwF VPcKX+LN2BR622D2ge4vsb1b6Np/XbFIYOtQ6ICNbyF+ui/k3qHfiyyszNPSUTneVKcw D/WrKcp3xHGUwZ9Ixwlosb1js1mN2n5y2I6AFSsw/DHonoxKLSHPnDKsBgtWJPWOXKNZ XMVCHODv1+M3Bj5F0X4YAGwPnXKufAsNE8iTQ6znQV5dBio2AT/vciqptNhPTIGRVnhp YcPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Bo49ib5VL9yqey9VyX7XP5zl1YXqZIOtWGudOLG0P1Q=; b=eMxNW/8xbxEC6xX4yUkAjsbXeE9rkBAoQGowT/c/v3K8fWHr/tRhryLixQcAg1FqZo QLKvTG5uylHVFmjTGeBmpTaGwVCEqOsbHyDc5vm5DlCb2dcvGRkGup10caY4jOBCbf3C 4JDotD/n6v1HaNWpsdGi2Z2OXexwf+7lzFilo8qiQYj2U7Fn+y/EryaVAg0/d425p1i5 PmgK44+ITryoUhfPxSNkOMR7xBxEqdRxGFQ8lIBcow1eSJAO3/7BeB0HGFqxV4OZUAv/ QN6Ds7tX4uTQr9mgsITyUH8XhL7v8m2/ZrzDA/Cx8ZsIMbRjDNhnKPbcjMK2YTORzoo0 ZTlQ== X-Gm-Message-State: AOAM530f79Ps6lD7xfXe/j5gOorUq57T69okVKM7gdEptkglfhq4hPMi 6XFmhX/A7lmAwTyCk1hg7GW/Qg== X-Google-Smtp-Source: ABdhPJywSUw4EDLs7UyrJZTutBD0+aK2zdCl2aJlw1IHHat9blk/wCzMnrVg+t7hnA1FwxxU+C+OBA== X-Received: by 2002:a1c:f002:: with SMTP id a2mr18345798wmb.129.1604317533627; Mon, 02 Nov 2020 03:45:33 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:33 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 11/30] net: fddi: skfp: smtinit: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:53 +0000 Message-Id: <20201102114512.1062724-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/smtinit.c:23:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/smtinit.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/smtinit.c b/drivers/net/fddi/skfp/smtinit.c index 01f6c75cbea81..c9898c83fe304 100644 --- a/drivers/net/fddi/skfp/smtinit.c +++ b/drivers/net/fddi/skfp/smtinit.c @@ -19,10 +19,6 @@ #include "h/fddi.h" #include "h/smc.h" -#ifndef lint -static const char ID_sccs[] = "@(#)smtinit.c 1.15 97/05/06 (C) SK " ; -#endif - void init_fddi_driver(struct s_smc *smc, u_char *mac_addr); /* define global debug variable */ From patchwork Mon Nov 2 11:44:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873677 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AF37C388F2 for ; Mon, 2 Nov 2020 11:46:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A0C8222B9 for ; Mon, 2 Nov 2020 11:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OCtG+NyP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728628AbgKBLqN (ORCPT ); Mon, 2 Nov 2020 06:46:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728631AbgKBLpg (ORCPT ); Mon, 2 Nov 2020 06:45:36 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01038C061A4A for ; Mon, 2 Nov 2020 03:45:36 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id 205so1440572wma.4 for ; Mon, 02 Nov 2020 03:45:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+JGIBxh2OHPmWqNoTk3kNcBe2Yw+4aH4Fb8WFyGD6FA=; b=OCtG+NyPy6NjpA+yP+kc9t/GBUTE59Cg+6TxVnmIATtEFXWWp2Nc/mXIpaPUs518bE LzRXpR2IQ3vTBC3S+GvvjpGDLYuOiB84WQAs9VDT8cM3yeRazr8y85b3mOO6Qt44nu9T /6sG6GsQX67gl8/yjcxM9s4jGOULebIapztfjkVLkXsNT5bBqvwk9bsSZtyQchi+roAT BAS4R+zGWInHafeNmA5aDZVehQcG6QCrYpM2nM+wknh6RocDgrmk6jQdOi1MnXgUsDJq CeQRwGzOM4bYkXo6C+xYGj4M5PJ4ei9bphFA8fN6BcI2XEMcS2bBdlFXRBVqllLodbq8 J/pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+JGIBxh2OHPmWqNoTk3kNcBe2Yw+4aH4Fb8WFyGD6FA=; b=sLa4P1+qn1cfIntTFP5satLr1vpbL/vqbqyR/XlkJg1MnIE56JqkSTw6cwZFwijINI 2VH9F/6/89gqUo0xlkIzJ24h/Sl7k63wxiU6JI6TEKbL8sJxh0wO+Er2VbD77AW63+PY UPK/Ab0njiSczgfUiYkbaMk1txzc8k+4gpWC41D1PJCTEIEF2lxgK/ab+BYZtw42Z0XI 32zBSpcjIzcX6fa8gX4lvJRIMkzDJ+4QMt7uYwnynKMBhw1x5w0RFVF9jITni618dnJ9 4UlIEkP7CHqFGMQqQu/oEIHQkQQdgNbCS/Xia5I13TA1sr4Pqi/zMGrMurKCvWHviin9 xiyw== X-Gm-Message-State: AOAM533eYmXvntygZZ6spwfBvpBTsekR9QzMeAKWVJlAGiKKZyWGPRGK jdUV6Dt911BOReX1TaX7d1TZpnj6eCoIqw== X-Google-Smtp-Source: ABdhPJyidhSU9lS2I1HP9YG0E5I3cIiLsvT8CzglNpdpSJYt4uYgKZj2+aP38vkCL1094Axals7m2w== X-Received: by 2002:a7b:c00a:: with SMTP id c10mr17198561wmb.119.1604317534760; Mon, 02 Nov 2020 03:45:34 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:34 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Inaky Perez-Gonzalez , linux-wimax@intel.com, Jakub Kicinski , Yanir Lubetkin , netdev@vger.kernel.org Subject: [PATCH 12/30] net: wimax: i2400m: netdev: Demote non-conformant function header Date: Mon, 2 Nov 2020 11:44:54 +0000 Message-Id: <20201102114512.1062724-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/netdev.c:583: warning: Function parameter or member 'net_dev' not described in 'i2400m_netdev_setup' Cc: Inaky Perez-Gonzalez Cc: linux-wimax@intel.com Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Yanir Lubetkin Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/staging/wimax/i2400m/netdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/netdev.c b/drivers/staging/wimax/i2400m/netdev.c index a7fcbceb6e6be..8339d600e77b5 100644 --- a/drivers/staging/wimax/i2400m/netdev.c +++ b/drivers/staging/wimax/i2400m/netdev.c @@ -574,7 +574,7 @@ static const struct ethtool_ops i2400m_ethtool_ops = { .get_link = ethtool_op_get_link, }; -/** +/* * i2400m_netdev_setup - Setup setup @net_dev's i2400m private data * * Called by alloc_netdev() From patchwork Mon Nov 2 11:44:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873731 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 798F0C388F2 for ; Mon, 2 Nov 2020 11:48:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2A727222B9 for ; Mon, 2 Nov 2020 11:48:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vliAKTVb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728656AbgKBLsj (ORCPT ); Mon, 2 Nov 2020 06:48:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728634AbgKBLpo (ORCPT ); Mon, 2 Nov 2020 06:45:44 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14DA4C061A4B for ; Mon, 2 Nov 2020 03:45:37 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id g12so14189105wrp.10 for ; Mon, 02 Nov 2020 03:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gvA8KxiiKQ/tWQ/ICepUyhKkRYtDSjo2P0kRgFq5FUE=; b=vliAKTVbQ+Yf7ljmfVfFDUTf2D3nyRlD0+GaBiWtYqpRwBwHvXFfqzq6ULSuP/x4kn RX/T16O7dd7RdiQhuCD9Is+VC57VLWEYXZtl7o86BvaY8QXpyBgFiYK4IKpQLTP4TY2s nakR3rV1TTp8ENtK2aAgc5QTgbY69T1lXMU9W9YkS0j5EhqV8gdPOVhEPFOHtUaGEsnI VpLwuA4wkZj3byCL4rx2FYT8d0M+0kjnV6bllUdYqSfqX5NKUwyPRJOfnaNBjNWoJxkU 6K+eL3WHx6fb1cMTxdvR3OlfDO8MSjP7EXZxxpk+mqwX15VLpwVvD0pM7M5Xlpk2di5b MrTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gvA8KxiiKQ/tWQ/ICepUyhKkRYtDSjo2P0kRgFq5FUE=; b=BM8wYPum6JfwvFK0FOcj4t+zWEaLU6SUGo+//PHS1eaiixDL7gcsmosjDioBgCzlJo +WLgyEYyuGBMtapiIJJuxXHY8Xa05p8980B4T3RLgHc6+n3jgROhtKKumLtCJ3Gb8Zv+ D7G0dw8eQalcYyjE9u8XFN5z6GvDQfsivh3i/eDvoHifgAZTseEFnezWEO4UlWGY7jXo PEirH5vZVgt+MaRhl4FIxc6o5yPuvSeYxoap2Z14DLN0SNpPWeiax1Lv1NKBgsb37Fpw cfGvXi0vhG4Y7WwqN9LU7sbLw3nAqk7vhUHpkNsFTRJpwLtjGLsoVf3w+Bl7Zjpc34qL 1fww== X-Gm-Message-State: AOAM530ndlGZYHpmiESmNwQPUw5POtzTrRpYfB/RbX+MCRT+kYx0uh+P V+FkmzQQ7fvoWdl3dgNXvw64ZQ== X-Google-Smtp-Source: ABdhPJwn2PIL/TRI53AK0L1yjYtUy6cS/IEs7jLyBnq5Cwz6OUogP+XNLa9v1e3/lZpck3SuAgQXzA== X-Received: by 2002:a5d:4b92:: with SMTP id b18mr17505695wrt.281.1604317535871; Mon, 02 Nov 2020 03:45:35 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:35 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Inaky Perez-Gonzalez , linux-wimax@intel.com, Jakub Kicinski , Yanir Lubetkin , netdev@vger.kernel.org Subject: [PATCH 13/30] net: wimax: i2400m: tx: Fix a few kernel-doc misdemeanours Date: Mon, 2 Nov 2020 11:44:55 +0000 Message-Id: <20201102114512.1062724-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/tx.c:715: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx' drivers/net/wimax/i2400m/tx.c:964: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx_setup' drivers/net/wimax/i2400m/tx.c:1005: warning: Function parameter or member 'i2400m' not described in 'i2400m_tx_release' Cc: Inaky Perez-Gonzalez Cc: linux-wimax@intel.com Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Yanir Lubetkin Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/staging/wimax/i2400m/tx.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/tx.c b/drivers/staging/wimax/i2400m/tx.c index 1255302e251e4..e9436212fe54d 100644 --- a/drivers/staging/wimax/i2400m/tx.c +++ b/drivers/staging/wimax/i2400m/tx.c @@ -681,6 +681,8 @@ void i2400m_tx_close(struct i2400m *i2400m) /** * i2400m_tx - send the data in a buffer to the device * + * @i2400m: device descriptor + * * @buf: pointer to the buffer to transmit * * @buf_len: buffer size @@ -955,6 +957,8 @@ EXPORT_SYMBOL_GPL(i2400m_tx_msg_sent); /** * i2400m_tx_setup - Initialize the TX queue and infrastructure * + * @i2400m: device descriptor + * * Make sure we reset the TX sequence to zero, as when this function * is called, the firmware has been just restarted. Same rational * for tx_in, tx_out, tx_msg_size and tx_msg. We reset them since @@ -998,7 +1002,7 @@ int i2400m_tx_setup(struct i2400m *i2400m) } -/** +/* * i2400m_tx_release - Tear down the TX queue and infrastructure */ void i2400m_tx_release(struct i2400m *i2400m) From patchwork Mon Nov 2 11:44:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873733 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 804B3C2D0A3 for ; Mon, 2 Nov 2020 11:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 276C1223EA for ; Mon, 2 Nov 2020 11:48:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Gx0cov5n" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728683AbgKBLsd (ORCPT ); Mon, 2 Nov 2020 06:48:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728639AbgKBLpt (ORCPT ); Mon, 2 Nov 2020 06:45:49 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0B12DC061A4D for ; Mon, 2 Nov 2020 03:45:38 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id g12so14189162wrp.10 for ; Mon, 02 Nov 2020 03:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Mjt3Wocbtw9EZVTr/SD4kz4Q1tcHUi3KMIhfsvCbBvE=; b=Gx0cov5nIz2x7yaN5HH8UOy8R2Ox8QzRdi3nQVVFyw4TSg/bSQd1WY//0r8FzVEH0M P0MkxGLBBqichSDYoAqV31dRFjy4zL/hS6XbsbS6tSmsPXxbY/n7E6bXpMGkD79pvQFA EgVZmzxbyLAO2ALuz5uVrdp2alHt69bdyKM2nxsCnyKz078+0DxQqAxbWyv3/R7OZWZc D0IKLZwblFzcG0iaekr3eTb2YL1crfZfG3l0eTGTMCBHwbC4SHEYDwgdzgqfepFlgEBE 53l80cLjF/LR+karg/7Izz9Wbs8ocQN285JKixJtpdHE/QyXe4O/hzN/w01uP5FB4Sdg PbXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Mjt3Wocbtw9EZVTr/SD4kz4Q1tcHUi3KMIhfsvCbBvE=; b=tfyjuc/F67xu5hAtrhSGqtcklQM+hTwKS0o8OptwcGMda38/qcNQmXNswUYvdZDtSL dqSUHZl6QILDxzpXlbTWrKHTltKJB0ihfP67cqzJi0XfxKMiL4b8tjUTNmEOYpXoEWNF BtrDbMHPOmSge6D7v5MtIbbNUbB256o7a42wiXOHgMioxlo+gZxiZMlJVlcw+zTRsaqc duXGyduCndas2StjPRBjl1Ic2Po4SiLVjO5ksZzdERgdQFS4xgr2IifWamITxhi12Xcl VSimP+dauTC7gm2bne70nHTT9exgfXrADTmG4HIbfKzO2hypYaH6d/TCG+w4O+dbfb9J ssxw== X-Gm-Message-State: AOAM532A+/8QrG2Nn+NInpob5sJtV8HVkdRfWKB6eLm/FEmahJTBA51U 7iwOik1HVQkOnGIoSKC1fOHqMQ== X-Google-Smtp-Source: ABdhPJzBTR2wxUkuzaQjDGPa5BFIgtswvxD1hxzpDSiggdg4iUOY1fnjalxAifHd9sWNrM8ylXaaEQ== X-Received: by 2002:adf:e849:: with SMTP id d9mr21044794wrn.25.1604317536772; Mon, 02 Nov 2020 03:45:36 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:36 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 14/30] net: fddi: skfp: smttimer: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:56 +0000 Message-Id: <20201102114512.1062724-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/smttimer.c:22:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/smttimer.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/smttimer.c b/drivers/net/fddi/skfp/smttimer.c index 9d549bb14f07f..5f3e5d7bf415b 100644 --- a/drivers/net/fddi/skfp/smttimer.c +++ b/drivers/net/fddi/skfp/smttimer.c @@ -18,10 +18,6 @@ #include "h/fddi.h" #include "h/smc.h" -#ifndef lint -static const char ID_sccs[] = "@(#)smttimer.c 2.4 97/08/04 (C) SK " ; -#endif - static void timer_done(struct s_smc *smc, int restart); void smt_timer_init(struct s_smc *smc) From patchwork Mon Nov 2 11:44:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873743 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F34BC00A89 for ; Mon, 2 Nov 2020 11:48:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE27D223BD for ; Mon, 2 Nov 2020 11:48:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AB2ZomZb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728833AbgKBLsg (ORCPT ); Mon, 2 Nov 2020 06:48:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728649AbgKBLpt (ORCPT ); Mon, 2 Nov 2020 06:45:49 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FEB3C061A4F for ; Mon, 2 Nov 2020 03:45:39 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id c9so7536992wml.5 for ; Mon, 02 Nov 2020 03:45:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=36SrPi/Z2LVhG8V20mNI11V0afy1ameNG58Hej6I4Oo=; b=AB2ZomZbif0Q6E/h+qi/uD+jIDq9XFrk8/x/i2O0bgc0EsIuTeU0R222cQVKaR/yFu qZ+BomF0Ybbpq/xNxAzGhgLtK/wzWcklZ8UVjxMISTA2AqMuAGXFq0yqYil6P2cWUu2R jl5KqOF5pdEjiYzeTKWML4c0yuC1cO27E82Z9t/xXJrZxh/njlIjEeRrnrjyPCPP5wYA cGMWu9K7dGNuCOy0k/2hwTeUh+V/oeJ4IPhF7jT/PRWVhFhLkHhDUerdVZ04Eja7IYT4 etZN4Y4TZBYtIEN05X5PZ6DrmjWNTuu4UxL8vOiMSF3exx18bw/y31aOxrSjX7jYDUre ymEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=36SrPi/Z2LVhG8V20mNI11V0afy1ameNG58Hej6I4Oo=; b=JNxHRcpV6REJFkRVwtXSp22jrXyFrTgh7HKnEtUiFRVcbH/+FXE46kSi8rWGN3L251 eLk+zLqXP4l6Q3fwrk2r6bkGa/HOjpFZH7pZZRcv+Wip+6gctruoHmaem6O0RsBKKdS5 wX/TKDo5ReZYnh9RrFuadjUC4bP3eKoDW3liGvQx0yV/zHZPv4xJpAUNhTbo2rhgMoag TV5ax96U0hU49M8QSNC35TNCFIaSuyGMWr26iqjzeHAuzAVk6PTXz34RKPd/UrlfcuvG tdH5y4Klqke2nseWaGno8M/mQcSSyYHGxE1AZWfNSpyegAWUA0o1RXLeZgbeUETA5lkR mNJQ== X-Gm-Message-State: AOAM530M4DjeAHYzJkZfpJZsElqCR6FYwYWTwvooI2ehqD9twxTzq2tO cIRT6eZI0p1iEJ7d9ONu58AcXg== X-Google-Smtp-Source: ABdhPJwm8ITipl9QL4iWbgcu9PJNZKX9oUy+oy/ZSMx70JgSyeS21Ego42oSY50uPy8ab0M3rtaQ2g== X-Received: by 2002:a1c:2ece:: with SMTP id u197mr17571890wmu.58.1604317537981; Mon, 02 Nov 2020 03:45:37 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:37 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 15/30] net: fddi: skfp: hwt: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:57 +0000 Message-Id: <20201102114512.1062724-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/hwt.c:31:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/hwt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/hwt.c b/drivers/net/fddi/skfp/hwt.c index 32804ed049cdd..5577b8e14b736 100644 --- a/drivers/net/fddi/skfp/hwt.c +++ b/drivers/net/fddi/skfp/hwt.c @@ -27,10 +27,6 @@ #include "h/fddi.h" #include "h/smc.h" -#ifndef lint -static const char ID_sccs[] = "@(#)hwt.c 1.13 97/04/23 (C) SK " ; -#endif - /* * Prototypes of local functions. */ From patchwork Mon Nov 2 11:44:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873741 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B78B4C00A89 for ; Mon, 2 Nov 2020 11:48:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6423A21D91 for ; Mon, 2 Nov 2020 11:48:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rTxAago5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728827AbgKBLsf (ORCPT ); Mon, 2 Nov 2020 06:48:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728652AbgKBLpt (ORCPT ); Mon, 2 Nov 2020 06:45:49 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67D2DC061A51 for ; Mon, 2 Nov 2020 03:45:40 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id 205so1440779wma.4 for ; Mon, 02 Nov 2020 03:45:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=poH1VG0a9WGSQs1vAX3xhce1fVh51gqxCxVcQG61Ecg=; b=rTxAago5FX6VjdmUc/zhr+24URMWUlo1ORk7irP6IzLpkmczDExlwfsMw7YfgbfQn4 Go+oARU+Vuxf2Bv2pJskXIRQda6jc8ngIq86PIUr2jG9c1E7JcPQit5nLomgsttqllRC JwIojjwtb9ygLNESd0kMJp/hgOojWCGQ/iN+sTh1+5ybHK0l2/DM2hguAeeVOGwgdwwb SQuBdAMxQ7ypgYpxW24F+/ObobpIYFu41sKTn/huR1X4kjkhvEJw6TFMr6X05LGSc7oX Dbh1sTMWSwvHB+UVLY2Fci+mJr69YZW4PGJBzHl5aMI+/MeRBhcq/feYMw69pbai374t nw4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=poH1VG0a9WGSQs1vAX3xhce1fVh51gqxCxVcQG61Ecg=; b=HyT34tvJhfXZkbRC58JTFmqmmwWNLrmnBoV/LdZxz+eA2bVfq3ooQRfVofnA394aoC T4hT6++Hw6/KM9jirryRrXuBxXRNFF1tl/zyv/lj/nIZHVTjA9QXgPXE74u6b5Nxf3sB YgkjuwP92Z6a4ybBFWMMRlOD9stwY60tPEi1D1WQYNdPEn+suBokvbfbeQER+j9repDW /qSIj1Qp+UQ89uiuXPBdMUWiWIsSb8P9Yx3HjPkgZVItXui0JHQKoLuVG8g+vcQj9uBG 2/voSZhnE5JifI9dFFOymAHbVKg7/TF3JGkw4S/J3x1aADLsJtaOPGbpWfz76C/PRNpK YHXw== X-Gm-Message-State: AOAM530PUvVEn4Us1ihSCtNY5ARToIvB45YRay4uhDXECMxAoaIK+lDq ocFSt3N+FYfo7VSp1mj9xQbfjg== X-Google-Smtp-Source: ABdhPJx7Hvq6uXTssI+CthCz6qQMWvOnUVh/2Uidh61gl4Ho2zsNP6B1NEIhfgxn4zHP12hqVJZ1fQ== X-Received: by 2002:a1c:96ca:: with SMTP id y193mr17097349wmd.22.1604317539185; Mon, 02 Nov 2020 03:45:39 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:38 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 16/30] net: fddi: skfp: srf: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:44:58 +0000 Message-Id: <20201102114512.1062724-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/srf.c:30:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/srf.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/fddi/skfp/srf.c b/drivers/net/fddi/skfp/srf.c index f98d060b0f5b0..4cad68c3f49b3 100644 --- a/drivers/net/fddi/skfp/srf.c +++ b/drivers/net/fddi/skfp/srf.c @@ -26,11 +26,6 @@ #ifndef SLIM_SMT #ifndef BOOT -#ifndef lint -static const char ID_sccs[] = "@(#)srf.c 1.18 97/08/04 (C) SK " ; -#endif - - /* * function declarations */ From patchwork Mon Nov 2 11:44:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873745 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34F34C00A89 for ; Mon, 2 Nov 2020 11:48:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9D5E21D91 for ; Mon, 2 Nov 2020 11:48:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fkDL7hui" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728646AbgKBLsb (ORCPT ); Mon, 2 Nov 2020 06:48:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728653AbgKBLpt (ORCPT ); Mon, 2 Nov 2020 06:45:49 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE46C061A52 for ; Mon, 2 Nov 2020 03:45:41 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id p22so9078835wmg.3 for ; Mon, 02 Nov 2020 03:45:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=COHpN89YHkMBJqrtEu0XBsht05sYavnazN1Mt7fpBKk=; b=fkDL7huiZ/Lbz3WJpe3FUz+EUaM+KbGaFk1iFyWlFeSd2bcqw8hm37MhO3MJ6htLqy JLDY661w2YNbPsqhqbCosb25NmD/K/mrMbFZH/ZXja3tWnN9fQrrkLcTyJED65PPcQ26 ReiWgVysf1NZNd6zzVjWGnh2IgWRGBCvjN3wshlM0HsgxFB2lh26QUwffnT1d39OIgxG p0pK9jHUemZJgMl4Qfl9555XLWzVezGBLWPfDfofPNecptc9TXw+6ENmJw3KvXfuAoLV cJ4Ueiwm49pLjS8qjXSS6uRqiTriGJR9mgwmWInTrUHYuXkjGvP+3/jjI9tBzUzAl57d xWKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=COHpN89YHkMBJqrtEu0XBsht05sYavnazN1Mt7fpBKk=; b=lfw4onLkVvh6UGHeyxtb4J8fOoq6x8zP8NovfLAOjMQD6nIHidqN7xU9p0YjvGMGos gijfnJzAY9LFRKV2gHsLp2mLTFdBnVtjdlC2dZNxSrkN2pwxAVYIJhDwhn9xqWS/B6HY TJgTtB3iTm5qIC1SHanwFQOcVMaqExC0ulpQsMsBm0k/u2J0uO9YXlLbyJ77Mi37ShzM RupxJ95lqzP5x8iRqK7atCOEoDWc0Ltf6AzSGe6gBC/K48TLBueqdF7rzd6oswaw18Xh iqjYwcrB+zIeCubHG5N5fk8K1HnTZpyQfyVb0b3NwOflXHsKzd2noPIHEeJ8o/4VzWRR m4bQ== X-Gm-Message-State: AOAM532LSJz3pr41q6kNh3d54LqjlWY3zVHifSaeoxC1pDi+bGTrWi+x Scu36NvxwYPyLvw+zpbhk16jW7v4Xv6pPA== X-Google-Smtp-Source: ABdhPJzxz1vv9WcVwfS8dl/02ZYd2VO65DE4GLXc2nxAtRpw8HSplQsQxz3SLsx+QCLxAfbog8H8+g== X-Received: by 2002:a7b:c932:: with SMTP id h18mr18143994wml.82.1604317540218; Mon, 02 Nov 2020 03:45:40 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:39 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Inaky Perez-Gonzalez , linux-wimax@intel.com, Jakub Kicinski , Yanir Lubetkin , netdev@vger.kernel.org Subject: [PATCH 17/30] net: wimax: i2400m: fw: Fix incorrectly spelt function parameter in documentation Date: Mon, 2 Nov 2020 11:44:59 +0000 Message-Id: <20201102114512.1062724-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wimax/i2400m/fw.c:647: warning: Function parameter or member '__chunk_len' not described in 'i2400m_download_chunk' drivers/net/wimax/i2400m/fw.c:647: warning: Excess function parameter 'chunk_len' description in 'i2400m_download_chunk' Cc: Inaky Perez-Gonzalez Cc: linux-wimax@intel.com Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Yanir Lubetkin Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/staging/wimax/i2400m/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wimax/i2400m/fw.c b/drivers/staging/wimax/i2400m/fw.c index 9970857063374..edb5eba0898b0 100644 --- a/drivers/staging/wimax/i2400m/fw.c +++ b/drivers/staging/wimax/i2400m/fw.c @@ -636,7 +636,7 @@ ssize_t i2400m_bm_cmd(struct i2400m *i2400m, * * @i2400m: device descriptor * @chunk: the buffer to write - * @chunk_len: length of the buffer to write + * @__chunk_len: length of the buffer to write * @addr: address in the device memory space * @direct: bootrom write mode * @do_csum: should a checksum validation be performed From patchwork Mon Nov 2 11:45:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873719 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8FC6C4742C for ; Mon, 2 Nov 2020 11:48:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F2BB22404 for ; Mon, 2 Nov 2020 11:48:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TENsMfs6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728658AbgKBLsO (ORCPT ); Mon, 2 Nov 2020 06:48:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728484AbgKBLpw (ORCPT ); Mon, 2 Nov 2020 06:45:52 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A42B3C061A47 for ; Mon, 2 Nov 2020 03:45:42 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id k10so12873477wrw.13 for ; Mon, 02 Nov 2020 03:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HI+eieWXuwyz8PcdZT+p31GivdwC/vuYT4tAZQpGNKs=; b=TENsMfs6lnqr8/OGtVcbodT5BW0/AHHyX8VH8Wr26SQTsxCLQFxX7ReD0GAMYBBl5I 1LiZcLx1tnEbNtBftzZoPGO3e86/6jRCj2j30ITfpd29Fa42nYoofjxOerqk003UW4ok IL7YTl3N/WzH3XJHN/O7kVWu1yPX5kVW/m2ssFKO6KFxZZySwXj3ehbQCAVpAIH7mm8b 7ULswcoGba7CGhFOiKZHWsjYPPbBoukqKkg2ATGUpTgwVuyTDeCjMwG6WMQuqIMy/MxM P6AChpG1bKuLRv3l7y2x88yOBg/DfAGyeQGDTxwcV5A4tBiKqF4S0f4+9WfGlJC2+Axn kF7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HI+eieWXuwyz8PcdZT+p31GivdwC/vuYT4tAZQpGNKs=; b=MrfIj90nNS8G0ANM+jXqvYcmGif0pV38ZqFEZqtBdb28+5jr5FC8Y2QCLmld9rmAaJ c6QzP+yGvDj4ITUC11jEyyEsEQeYYw95uwXSSC/6zbYp2Hib6RjMtu5f4CLqad0h9nDd QLxdBZi8vqGQPA3cO87Aq5Q5+UEl4MlTt/B0CnZyhfykiI8pcMflfEjGal445CtKqPV7 lymUoVu8JwUHL9BwH3YF7RzL48Py8GTocBJ6nra7CF1TkKCD00uZwOL/AGxnKGg2gzL5 xidOdu9W7SAqO1St83akEzxvlEdi3y6bS24/4dInYegqMUpM9lhsV/ynJ1rsPIhMX8fJ KzJQ== X-Gm-Message-State: AOAM533rxvYKWC1wAiD8SSqOT0ct15B2DkHnOj2acqXfj1vXP1rALAhW OzqycMYml4IFKJ7Nuh/7v5frFQ== X-Google-Smtp-Source: ABdhPJyEcjdGLfyFckCwi2FifsndwmgroBJiGMYfufwGXa+ttr437NvQYTVTAcsF7RvxNZ5ZgzbK+A== X-Received: by 2002:adf:f381:: with SMTP id m1mr21735375wro.347.1604317541432; Mon, 02 Nov 2020 03:45:41 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:40 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , Heiner Kallweit , netdev@vger.kernel.org Subject: [PATCH 18/30] net: fddi: skfp: drvfbi: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:45:00 +0000 Message-Id: <20201102114512.1062724-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/drvfbi.c:26:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Heiner Kallweit Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/drvfbi.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/fddi/skfp/drvfbi.c b/drivers/net/fddi/skfp/drvfbi.c index cc9ac572423e9..e9b9614639cdd 100644 --- a/drivers/net/fddi/skfp/drvfbi.c +++ b/drivers/net/fddi/skfp/drvfbi.c @@ -22,10 +22,6 @@ #include #include -#ifndef lint -static const char ID_sccs[] = "@(#)drvfbi.c 1.63 99/02/11 (C) SK " ; -#endif - /* * PCM active state */ From patchwork Mon Nov 2 11:45:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873693 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D74F0C2D0A3 for ; Mon, 2 Nov 2020 11:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B1B1222B9 for ; Mon, 2 Nov 2020 11:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AJX5cVYb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728523AbgKBLqk (ORCPT ); Mon, 2 Nov 2020 06:46:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728339AbgKBLpw (ORCPT ); Mon, 2 Nov 2020 06:45:52 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D01DDC061A49 for ; Mon, 2 Nov 2020 03:45:43 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id y12so14218222wrp.6 for ; Mon, 02 Nov 2020 03:45:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KYODUgFzLZpQRtZvtEYb1GiOIVfxB6JPRgWqq+iAt+c=; b=AJX5cVYbYfywEDxmxD3pZjiVRslIcybEJZ8g2dbXdeUJiSS0Ky0LFXCUV0CYcXYHsb dCNANCtu/DivMaX/I6jArtkFyH9j+m54tuCqgcyCwmupDoxAxIPzjB8XDdFizzc9/fAT 55jJvjAPyVpvsJpvWPMYuEUOP7ktgv4AtUKUI9w35CVqp0zumnqtQzEZ62n/bR+dBH+K W7W+fleGsND2HzYP/6g7Ba/xIHWAN1/mwtTkEQO4TY+V9hDs6RLgjDEBHsDGBDmLOw2v 9l4if4pfCZ8hH1xao+IPz+C4z6Wk+XX7ktqR4nD73+J7ehbZr0YBi+8z4eFLvvOrqjGH A6cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KYODUgFzLZpQRtZvtEYb1GiOIVfxB6JPRgWqq+iAt+c=; b=BmUWEaBpKg1DECcJTqtfTqf0XZcCGanwp64qzizctIzs0FD+rZq88WuW2Iyl4fRZ56 +E2YAqu9FByF5u25DrX7r/CVBxXaK9Q0aSLSAG598xv4MGljL7tHUhddSjUMjxek+MdV nWIsalo5x7J73trBVv4L3bjN81iOUsz3cY+GtC/uLuXAsxMRRYOzcLpIQIFnX43Ks2dN E7b9KBnYo73Dyu9Q2xnEWnMij8Wf47m0bxuWkwS16KCls3fRDyxAczqvrPj+3huNb3wa OCYrh8KzYFZkp5uOizNL/d3JVC8bFk6KHdxqqdokygQgOyj0ic7SGJEoHJ8b+s1F98jT RAKw== X-Gm-Message-State: AOAM533HEo9GBc3VEMRAwB7c5FHDGcYXhNT/DAO5i2UwSRd3gfTbk2cm 80HJDEd7iGA/bEeHavTk6qk6gw== X-Google-Smtp-Source: ABdhPJxwVVKc7cWervgf1tBjuBEil9YpITINaEFrabEoaKUHr5C+ef2qo5WF6jlrUYpN00LtTFFauA== X-Received: by 2002:adf:9069:: with SMTP id h96mr20674315wrh.358.1604317542636; Mon, 02 Nov 2020 03:45:42 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:42 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , Tetsuo Handa , netdev@vger.kernel.org Subject: [PATCH 19/30] net: fddi: skfp: ess: Remove defined but unused variable 'ID_sccs' Date: Mon, 2 Nov 2020 11:45:01 +0000 Message-Id: <20201102114512.1062724-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/fddi/skfp/ess.c:43:19: warning: ‘ID_sccs’ defined but not used [-Wunused-const-variable=] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Tetsuo Handa Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/fddi/skfp/ess.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/fddi/skfp/ess.c b/drivers/net/fddi/skfp/ess.c index afd5ca39f43b6..35110c0c00a04 100644 --- a/drivers/net/fddi/skfp/ess.c +++ b/drivers/net/fddi/skfp/ess.c @@ -40,7 +40,6 @@ #ifdef ESS #ifndef lint -static const char ID_sccs[] = "@(#)ess.c 1.10 96/02/23 (C) SK" ; #define LINT_USE(x) #else #define LINT_USE(x) (x)=(x) From patchwork Mon Nov 2 11:45:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873725 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3C1AC2D0A3 for ; Mon, 2 Nov 2020 11:48:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 929FC223AC for ; Mon, 2 Nov 2020 11:48:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="E6Fp50ul" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728826AbgKBLsR (ORCPT ); Mon, 2 Nov 2020 06:48:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728660AbgKBLpw (ORCPT ); Mon, 2 Nov 2020 06:45:52 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 321D1C061A48 for ; Mon, 2 Nov 2020 03:45:45 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id n18so14211282wrs.5 for ; Mon, 02 Nov 2020 03:45:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IWgM+9wLuX8CxFAK18XYYejQxSRrdtsxUWktHkjPbDM=; b=E6Fp50ulPAfuAJ6P5gCUm0zVao8mKSzXvbeCmHfykPE1YvpvDyXsSz+Q2Gl3X25pgS cIphkuRccC94rwEIfwRbgic+6QEQysrjw+3g6OV95uygyBShSSXVKixSsgLvIK+dD+RY JpQCTEjNt49VEK43k+g+1S+knd0zPP5GfGt82z1CG8WsIzEaMYIiL5ioSD2LOajWViEA QUIe3imS+ofT2HZKN+TvNazJt1XTQZBYh7Zrgmf6m5+vj73MVctzPfGK49IfyZOy5SDk bBkpri/Ulz7dh5vV0yRW7MFPkfmZk3X9tcAB5IoRFUUwoI1hLXZa55J72xKZxxy4Xso/ di0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IWgM+9wLuX8CxFAK18XYYejQxSRrdtsxUWktHkjPbDM=; b=LDW8LMWTM/t49Fmqr8WL7oqhj28a6kaGvd/8VxVaFyMKlv+cHQHnfm8uDMLxuyOE/7 Q2wlb5R3l/bTBirw6FPLxF+JFZHLT4Q8Md8Ld1ppRwR5a6Sg+8NEB5NmpHMtLNxexFe2 zDugO2fMBcSps0Eie52lmvjCCPPw8XTCTb2fILJ7perXj+Bq06aURFdcibRxlXIYvncT Vfuo0yBkIQYtdi+eNubjDh3yvpXuzneVA/CcXZ6yhGce3+0H7yF/8OXQDEsCinN5PRXi JxAh0BLgPn7KDjaF1+NxL6yptjwcm8vfnUzTlemCvx6NY/SAA2hDkWksUZuHuNNTvL2H gxJw== X-Gm-Message-State: AOAM5332pBLRZGb1z2C3r9fbAAEaQWWCnipnTNsJA2P+lw06NSDInGmC GGdPU4KTFJnc7ztZnL0PKQDy3A== X-Google-Smtp-Source: ABdhPJyqxRoQANg1UUIJRw+oLBLo0MjxqNAIVuiK5NQIfLgVEVOm2KJ+pjSQEIrBSK1gdgEudWq9WQ== X-Received: by 2002:adf:e849:: with SMTP id d9mr21045411wrn.25.1604317543902; Mon, 02 Nov 2020 03:45:43 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:43 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Harry Morris , Alexander Aring , Stefan Schmidt , Jakub Kicinski , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 20/30] net: ieee802154: ca8210: Fix a bunch of kernel-doc issues Date: Mon, 2 Nov 2020 11:45:02 +0000 Message-Id: <20201102114512.1062724-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ieee802154/ca8210.c:326: warning: Function parameter or member 'readq' not described in 'ca8210_test' drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'spi_transfer_complete' not described in 'ca8210_priv' drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'sync_exchange_complete' not described in 'ca8210_priv' drivers/net/ieee802154/ca8210.c:375: warning: Function parameter or member 'promiscuous' not described in 'ca8210_priv' drivers/net/ieee802154/ca8210.c:430: warning: Function parameter or member 'short_address' not described in 'macaddr' drivers/net/ieee802154/ca8210.c:723: warning: Function parameter or member 'cas_ctl' not described in 'ca8210_rx_done' drivers/net/ieee802154/ca8210.c:723: warning: Excess function parameter 'arg' description in 'ca8210_rx_done' drivers/net/ieee802154/ca8210.c:1289: warning: Excess function parameter 'device_ref' description in 'tdme_checkpibattribute' drivers/net/ieee802154/ca8210.c:3054: warning: Function parameter or member 'spi_device' not described in 'ca8210_remove' drivers/net/ieee802154/ca8210.c:3054: warning: Excess function parameter 'priv' description in 'ca8210_remove' drivers/net/ieee802154/ca8210.c:3104: warning: Function parameter or member 'spi_device' not described in 'ca8210_probe' drivers/net/ieee802154/ca8210.c:3104: warning: Excess function parameter 'priv' description in 'ca8210_probe' Cc: Harry Morris Cc: Alexander Aring Cc: Stefan Schmidt Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wpan@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Stefan Schmidt --- drivers/net/ieee802154/ca8210.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 4eb64709d44cb..9b3ab7acad37e 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -316,6 +316,7 @@ struct cas_control { * struct ca8210_test - ca8210 test interface structure * @ca8210_dfs_spi_int: pointer to the entry in the debug fs for this device * @up_fifo: fifo for upstream messages + * @readq: read wait queue * * This structure stores all the data pertaining to the debug interface */ @@ -346,12 +347,12 @@ struct ca8210_test { * @ca8210_is_awake: nonzero if ca8210 is initialised, ready for comms * @sync_down: counts number of downstream synchronous commands * @sync_up: counts number of upstream synchronous commands - * @spi_transfer_complete completion object for a single spi_transfer - * @sync_exchange_complete completion object for a complete synchronous API - * exchange - * @promiscuous whether the ca8210 is in promiscuous mode or not + * @spi_transfer_complete: completion object for a single spi_transfer + * @sync_exchange_complete: completion object for a complete synchronous API + * exchange + * @promiscuous: whether the ca8210 is in promiscuous mode or not * @retries: records how many times the current pending spi - * transfer has been retried + * transfer has been retried */ struct ca8210_priv { struct spi_device *spi; @@ -420,8 +421,8 @@ struct fulladdr { /** * union macaddr: generic MAC address container - * @short_addr: 16-bit short address - * @ieee_address: 64-bit extended address as LE byte array + * @short_address: 16-bit short address + * @ieee_address: 64-bit extended address as LE byte array * */ union macaddr { @@ -714,7 +715,7 @@ static void ca8210_mlme_reset_worker(struct work_struct *work) /** * ca8210_rx_done() - Calls various message dispatches responding to a received * command - * @arg: Pointer to the cas_control object for the relevant spi transfer + * @cas_ctrl: Pointer to the cas_control object for the relevant spi transfer * * Presents a received SAP command from the ca8210 to the Cascoda EVBME, test * interface and network driver. @@ -1277,7 +1278,6 @@ static u8 tdme_channelinit(u8 channel, void *device_ref) * @pib_attribute: Attribute Number * @pib_attribute_length: Attribute length * @pib_attribute_value: Pointer to Attribute Value - * @device_ref: Nondescript pointer to target device * * Return: 802.15.4 status code of checks */ @@ -3046,7 +3046,7 @@ static void ca8210_test_interface_clear(struct ca8210_priv *priv) /** * ca8210_remove() - Shut down a ca8210 upon being disconnected - * @priv: Pointer to private data structure + * @spi_device: Pointer to spi device data structure * * Return: 0 or linux error code */ @@ -3096,7 +3096,7 @@ static int ca8210_remove(struct spi_device *spi_device) /** * ca8210_probe() - Set up a connected ca8210 upon being detected by the system - * @priv: Pointer to private data structure + * @spi_device: Pointer to spi device data structure * * Return: 0 or linux error code */ From patchwork Mon Nov 2 11:45:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873739 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67AE0C388F2 for ; Mon, 2 Nov 2020 11:48:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BCE0223AC for ; Mon, 2 Nov 2020 11:48:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IjD0gMxm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728807AbgKBLsM (ORCPT ); Mon, 2 Nov 2020 06:48:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728520AbgKBLpw (ORCPT ); Mon, 2 Nov 2020 06:45:52 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 673ACC061A4A for ; Mon, 2 Nov 2020 03:45:46 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id k10so12873683wrw.13 for ; Mon, 02 Nov 2020 03:45:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=t4/hDwsvOptYgItp/Hg6I8g87o5PfiaXnk0Gr30j7xY=; b=IjD0gMxmeBMbl5Fxzs/adRvcFXbegxhnhe+EHvQBBVselVbzpYWyxza1xqm+HgVhMz Res+pm/vli1k3kxnF1AwcnrKx7OT+cI9CfKhWsxTUI8PKndeBGAr8JL9xUquPHF8b2/A ihGFlslj18W1noJW0ZGPuS0R+AvcIu2eTRYrnS4GN304H691qpO+Occf4Bvpv+hZ6nvv OI6K46SbUH3b2krhX6/UArGwBHsDmduwsZNMEbOCF+5iMLqtBbO7zeqXVjsXwH9Fyrvk SNAjxKcUsOfFcrUvl4x3jw52blAukAR4dRzDaD7swrOge33TIfD8pra6vrCxWayILnMm aXAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=t4/hDwsvOptYgItp/Hg6I8g87o5PfiaXnk0Gr30j7xY=; b=dHA+KAJWekCpRK7S2mWrLc1eH/PKVTCHrf2afBntFHg49s/l46IUaEaR2Qs73TYyfF NI7JQWUsHD4aBcu0VfS2eNUrO1rf0if1ow3V7WrtXi9lJu9P763eLwMc9qXCEnviUYY2 P0jdXGwqCu6bbqpwCpTbhJV4H36q/fZdiuqfmhZSncetwS0GBwH7xPLUpAVMhP8UGcTR yeU7xm2H4eVrLXoYxXe6nhwq6jw/ynhAb07AHuaBVjg7fd0xMgFDXk342EfZt7k9TuQ/ 4w9gfbx4Y7esXf1HYfMfsGaVLI2ncrQ2+0R7PcckNP++NuxdZvx9hqvTtLrlPFcJBU6e 6P0w== X-Gm-Message-State: AOAM533PkDReYeZeSYARl7Zb5WYOU6OfvX3P5pA3UqcV5wN8FxqzPzj9 deZOyW0He91aYRASK07WbYwudg== X-Google-Smtp-Source: ABdhPJyCgVL1JXYgDh/fD+3/EbFSvF9TbeAHn7Rmj+Ae+8dMfP4pXIDM8+T2FvgZ7NsyMssDD/cTGQ== X-Received: by 2002:adf:e40e:: with SMTP id g14mr18352866wrm.285.1604317545189; Mon, 02 Nov 2020 03:45:45 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:44 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , netdev@vger.kernel.org, linux-parisc@vger.kernel.org Subject: [PATCH 21/30] net: ethernet: dec: tulip: tulip_core: 'last_irq' is only used when i386 or x86 Date: Mon, 2 Nov 2020 11:45:03 +0000 Message-Id: <20201102114512.1062724-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/dec/tulip/tulip_core.c: In function ‘tulip_init_one’: drivers/net/ethernet/dec/tulip/tulip_core.c:1296:13: warning: variable ‘last_irq’ set but not used [-Wunused-but-set-variable] Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Cc: linux-parisc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/dec/tulip/tulip_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/dec/tulip/tulip_core.c b/drivers/net/ethernet/dec/tulip/tulip_core.c index e7b0d7de40fd6..94f615869827c 100644 --- a/drivers/net/ethernet/dec/tulip/tulip_core.c +++ b/drivers/net/ethernet/dec/tulip/tulip_core.c @@ -1293,7 +1293,7 @@ static int tulip_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) static unsigned char last_phys_addr[ETH_ALEN] = { 0x00, 'L', 'i', 'n', 'u', 'x' }; - static int last_irq; + static int __maybe_unused last_irq; int i, irq; unsigned short sum; unsigned char *ee_data; From patchwork Mon Nov 2 11:45:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873727 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38CE8C00A89 for ; Mon, 2 Nov 2020 11:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE14E223AC for ; Mon, 2 Nov 2020 11:48:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e43KOouB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728823AbgKBLsP (ORCPT ); Mon, 2 Nov 2020 06:48:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51462 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728667AbgKBLpw (ORCPT ); Mon, 2 Nov 2020 06:45:52 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9554FC061A54 for ; Mon, 2 Nov 2020 03:45:47 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id 13so9092461wmf.0 for ; Mon, 02 Nov 2020 03:45:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AWriSgrmFQKcR5kCIros4j6sVpvbfTSpmeIF4cEJj4k=; b=e43KOouByYFhUgBvOtp5cHfzHpKIf//0u16XInSVXKFhV9EnQYDi42dCz6s/RqbLj3 niOVuSqxo7GznFN6nbDppNfg2jqsPC6wvGwXAzXoK//Srq5UoLk2IJuX7iojxWjdaz50 ppYk6FnxxLZ2WkKLPu1Ne5k4O31koZZjogktp2TIXDVErjj4bSzgWvHRhXLpWqeWyRf6 kMmphybgCaihly4pWLj9uKlLUfUspi1hN8TRZbpypQHP/S6lk5cAP07UhqQvJbrgOLt5 sBDSF7FxSviEqC4ftQq5cv43HasZDmMuaL8isZHUWhL3NDk3iY+duN19/0iDexB/SXhK OhCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AWriSgrmFQKcR5kCIros4j6sVpvbfTSpmeIF4cEJj4k=; b=WIzC9YVGqkhvXWn/3q6wNnXBeHtW2TJ+o12sfXRq8/xyUodKguiu/HFsSzOXyGUQmI osfyhGGihr9NWz13fWPfkl3PtV7MRrTuWQO8/qrErH+zPQUaWb8SlX2UiD6gy8YquVFE eEo/rzsJ7J5m9anw3U44ZJ+cTS//dey4jxL910ZNNjqmJ1t1XiMAqtnmWcsvEw4ZLHYR ugsxXNJqDh+YnyBuQw2SDjivOAhma8SeNFyAmPQkIbe2Cr5/KxrvUeQ/VmF7O01ZNxM5 yrCDTBNZkfoetXNk7rblUrcvuaWCzq3i6ZdrhaSuN9zOD5fvPafuP8+vZMgtF2UNYOqD JkWw== X-Gm-Message-State: AOAM532+LxCWsd35fnkxindOmxEgMft0F6HSKSnQNhFXSyxUZMC/yvnC 9ewRljqJSh/iYVzMEJavWjDAVQ== X-Google-Smtp-Source: ABdhPJxF3BjV7c1IDu+m/wMMnZ1lMe4fIwNGQw+eqC+8fbuigkZVpETyEuu75ijq4q6zvJzwxqixrA== X-Received: by 2002:a1c:c286:: with SMTP id s128mr17257532wmf.88.1604317546360; Mon, 02 Nov 2020 03:45:46 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:45 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , Hayes Wang , nic maintainers , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 22/30] net: usb: r8152: Provide missing documentation for some struct members Date: Mon, 2 Nov 2020 11:45:04 +0000 Message-Id: <20201102114512.1062724-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/usb/r8152.c:934: warning: Function parameter or member 'blk_hdr' not described in 'fw_mac' drivers/net/usb/r8152.c:934: warning: Function parameter or member 'reserved' not described in 'fw_mac' drivers/net/usb/r8152.c:947: warning: Function parameter or member 'blk_hdr' not described in 'fw_phy_patch_key' drivers/net/usb/r8152.c:947: warning: Function parameter or member 'reserved' not described in 'fw_phy_patch_key' drivers/net/usb/r8152.c:986: warning: Function parameter or member 'blk_hdr' not described in 'fw_phy_nc' drivers/net/usb/r8152.c:986: warning: Function parameter or member 'mode_pre' not described in 'fw_phy_nc' drivers/net/usb/r8152.c:986: warning: Function parameter or member 'mode_post' not described in 'fw_phy_nc' drivers/net/usb/r8152.c:986: warning: Function parameter or member 'reserved' not described in 'fw_phy_nc' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Hayes Wang Cc: nic maintainers Cc: linux-usb@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Hayes Wang --- drivers/net/usb/r8152.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index b1770489aca51..cebe2dc15c3f0 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -898,6 +898,7 @@ struct fw_header { * struct fw_mac - a firmware block used by RTL_FW_PLA and RTL_FW_USB. * The layout of the firmware block is: * + + . + * @blk_hdr: firmware descriptor (type, length) * @fw_offset: offset of the firmware binary data. The start address of * the data would be the address of struct fw_mac + @fw_offset. * @fw_reg: the register to load the firmware. Depends on chip. @@ -911,6 +912,7 @@ struct fw_header { * @bp_num: the break point number which needs to be set for this firmware. * Depends on the firmware. * @bp: break points. Depends on firmware. + * @reserved: reserved space (unused) * @fw_ver_reg: the register to store the fw version. * @fw_ver_data: the firmware version of the current type. * @info: additional information for debugging, and is followed by the @@ -936,8 +938,10 @@ struct fw_mac { /** * struct fw_phy_patch_key - a firmware block used by RTL_FW_PHY_START. * This is used to set patch key when loading the firmware of PHY. + * @blk_hdr: firmware descriptor (type, length) * @key_reg: the register to write the patch key. * @key_data: patch key. + * @reserved: reserved space (unused) */ struct fw_phy_patch_key { struct fw_block blk_hdr; @@ -950,6 +954,7 @@ struct fw_phy_patch_key { * struct fw_phy_nc - a firmware block used by RTL_FW_PHY_NC. * The layout of the firmware block is: * + + . + * @blk_hdr: firmware descriptor (type, length) * @fw_offset: offset of the firmware binary data. The start address of * the data would be the address of struct fw_phy_nc + @fw_offset. * @fw_reg: the register to load the firmware. Depends on chip. @@ -960,6 +965,7 @@ struct fw_phy_patch_key { * @mode_reg: the regitster of switching the mode. * @mod_pre: the mode needing to be set before loading the firmware. * @mod_post: the mode to be set when finishing to load the firmware. + * @reserved: reserved space (unused) * @bp_start: the start register of break points. Depends on chip. * @bp_num: the break point number which needs to be set for this firmware. * Depends on the firmware. From patchwork Mon Nov 2 11:45:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873723 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95952C00A89 for ; Mon, 2 Nov 2020 11:48:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2923F222B9 for ; Mon, 2 Nov 2020 11:48:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mxwSTCHJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728805AbgKBLsD (ORCPT ); Mon, 2 Nov 2020 06:48:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728671AbgKBLpy (ORCPT ); Mon, 2 Nov 2020 06:45:54 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2CAFC061A56 for ; Mon, 2 Nov 2020 03:45:48 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id x7so14237713wrl.3 for ; Mon, 02 Nov 2020 03:45:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wO3DZUe4v/2VFg7iK8pRPHz2KfePFYcH1bmhyPk8rVQ=; b=mxwSTCHJXfkm9QxIRzdWvvf6dxhtPXbmtDgBcU+bx+1CFUbQ75z70+OO18gi9tXNG5 eaJtTaZq5qTYfhtyuJc0RLNtgtupNknmAfdDjt+atyOBtvn59pEWTsFT6vubLHaj1dYh C+ASzGBSNwAvk0fh0SSB6/okY7o5tWIPnfh9dVWJv3Q5zNJFenOFsn/orWIZ9O7veTd6 KQ4B8mDGYo4F4bLl16h6/rU0s8oMYRhN8sBGmE7LQzrEoSEUCp/24h+nPu1Y47uBvLq8 puQWJR0uoMjhogCNgA14CKVYiQONorlvpTu5VneJM1R1oLDnwtGbmNIDt1Xi33+vMsdR r8jQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wO3DZUe4v/2VFg7iK8pRPHz2KfePFYcH1bmhyPk8rVQ=; b=OBVeV1MEH/h83L3qiBP+rWbPYDfVT6rtk+sAmv0Dsy+FvShDvIOVlLTJBK8gYvq8V5 yPTy3hR+T5UPM8TKaTLBt7qIkeHCpEIidK9WKTfAxBjRnJpC7B1B3cixQmUHtSvDarGx 9wJmQs0I66BrEhFqAHRLBN+Ji6mvCAGkyF0z/Ih5mE5AtrswMJPymYA4itjm5AsCMtQc YaSjCjikTQa1Hfd4ImGaGDRRI6RuxOnpRrmvQ8KDEzjr3ly8qvjYHqmFo0xo0m7mLutr oRPgtpCOsqpCBya83WCvtoiXoanL3X3zhTFZ5KJHSFwP3lrPddTXQG2dHAwKzZkuPhTo KqPg== X-Gm-Message-State: AOAM531W0jcr3C9sq457ZTbY89bWo+2Cr9mLvdoIawkZt3Y4pA/SxuJx Qm3+lxMOFURYo44oHdnXHWYuxQ== X-Google-Smtp-Source: ABdhPJzkteUP54xGsBZR9fcdINOLUtFH7SmKsmGUmAokF70EMPtdeIkFyyWIkzCECam1TRe43qUO3A== X-Received: by 2002:adf:fe48:: with SMTP id m8mr19497585wrs.127.1604317547698; Mon, 02 Nov 2020 03:45:47 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:47 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Harry Morris , Alexander Aring , Stefan Schmidt , Jakub Kicinski , linux-wpan@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 23/30] net: ieee802154: ca8210: Fix incorrectly named function param doc Date: Mon, 2 Nov 2020 11:45:05 +0000 Message-Id: <20201102114512.1062724-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/ieee802154/ca8210.c:724: warning: Function parameter or member 'cas_ctl' not described in 'ca8210_rx_done' drivers/net/ieee802154/ca8210.c:724: warning: Excess function parameter 'cas_ctrl' description in 'ca8210_rx_done' Cc: Harry Morris Cc: Alexander Aring Cc: Stefan Schmidt Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wpan@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Stefan Schmidt --- drivers/net/ieee802154/ca8210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 9b3ab7acad37e..3a2824f24caa8 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -715,7 +715,7 @@ static void ca8210_mlme_reset_worker(struct work_struct *work) /** * ca8210_rx_done() - Calls various message dispatches responding to a received * command - * @cas_ctrl: Pointer to the cas_control object for the relevant spi transfer + * @cas_ctl: Pointer to the cas_control object for the relevant spi transfer * * Presents a received SAP command from the ca8210 to the Cascoda EVBME, test * interface and network driver. From patchwork Mon Nov 2 11:45:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873713 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF8AC2D0A3 for ; Mon, 2 Nov 2020 11:48:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B6A6222B9 for ; Mon, 2 Nov 2020 11:48:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bner9DWV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728795AbgKBLr7 (ORCPT ); Mon, 2 Nov 2020 06:47:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728674AbgKBLp5 (ORCPT ); Mon, 2 Nov 2020 06:45:57 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 614F2C040202 for ; Mon, 2 Nov 2020 03:45:50 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id 13so9092625wmf.0 for ; Mon, 02 Nov 2020 03:45:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+emfuZozboE6VPCpjSxgZ17ErxNdr0CQU6HuFjGGj9c=; b=bner9DWV6sMjrx+uGqRHOdxA/sobQFM1QppI4RtglurUSLvLxe3FbY0/BZBoYDdPw/ 5V4KwZkgcD/1mhlO6dcq3fryWaLIklQuinl7+SwGC8fRKGnpHXSkRyFBcj3WHlgGPXJG GuZ1UrrReOAYQFiy085OGnYYGdjhR0/wqqNfbA+5QBNpRfd1pG+L0SMR5J0vfAT81F4l JGoIdiJWuliHUwDX6YC2R/kGrCdB57a+1e/HwvUSYez/ql44qKq1J3RWkOtxwlxrfk+X 4kidDNt2ZFPh2ZiTpr8oh/qG1hQKsoIPpeQOA0i/RTTJnoCi9/+Lm1PjVeRPDjBX/+2M Ybzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+emfuZozboE6VPCpjSxgZ17ErxNdr0CQU6HuFjGGj9c=; b=h3nhaymcrnyAwSiFooD3rgPDSh2M48VS2uiFRXFQPsxriBAps4EKZ2Ih+q2Civ+YIq 4rJNToCWM6H3qBNVEZuJMPrNs4lk1XOZC4JJK86uLMs9pZ4cWh/4JzJv4/ShZUmzWoyz 3ejkLQos9+pNf7tek2C3yrkW3SsYFjeE+gVGe/qVE2JEmBd8F2okBuUefsSaStFMIL1Z 7x/eSbU2AwCUQFx7yknc7uj9q1LmdKc7mylLwlPbWvPBrqHE5zjKdrpNsyGOOArYFKBQ Ny4x9vkVCs6R7mWvwEmMFdXKvjW2akjPwCY2vJFzTC1Fm+yhougc1lZby++oUSrCoRtu TdNQ== X-Gm-Message-State: AOAM533pq43hcEFtUpCA7wcjRbOa2dTX66UYdsB5JNzElXdB3HER41ao twhGKJVEh6hNa0/JtmOVaLBhug== X-Google-Smtp-Source: ABdhPJwvlsl0mXhcHm3c34kRSfmM2+iQtsKvySuSGmvAnpkjnB+NRBUEhRWmYKqPzfReW5kLol3dTg== X-Received: by 2002:a1c:9950:: with SMTP id b77mr10940001wme.123.1604317548963; Mon, 02 Nov 2020 03:45:48 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:48 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Woojung Huh , Microchip Linux Driver Support , Jakub Kicinski , netdev@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 24/30] net: usb: lan78xx: Remove lots of set but unused 'ret' variables Date: Mon, 2 Nov 2020 11:45:06 +0000 Message-Id: <20201102114512.1062724-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/usb/lan78xx.c: In function ‘lan78xx_read_raw_otp’: drivers/net/usb/lan78xx.c:825:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_write_raw_otp’: drivers/net/usb/lan78xx.c:879:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_deferred_multicast_write’: drivers/net/usb/lan78xx.c:1041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_update_flowcontrol’: drivers/net/usb/lan78xx.c:1127:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_init_mac_address’: drivers/net/usb/lan78xx.c:1666:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_link_status_change’: drivers/net/usb/lan78xx.c:1841:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_irq_bus_sync_unlock’: drivers/net/usb/lan78xx.c:1920:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan8835_fixup’: drivers/net/usb/lan78xx.c:1994:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_rx_max_frame_length’: drivers/net/usb/lan78xx.c:2192:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_change_mtu’: drivers/net/usb/lan78xx.c:2270:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_mac_addr’: drivers/net/usb/lan78xx.c:2299:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_features’: drivers/net/usb/lan78xx.c:2333:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] drivers/net/usb/lan78xx.c: In function ‘lan78xx_set_suspend’: drivers/net/usb/lan78xx.c:3807:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Woojung Huh Cc: Microchip Linux Driver Support Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Cc: linux-usb@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/usb/lan78xx.c | 168 ++++++++++++++++++-------------------- 1 file changed, 78 insertions(+), 90 deletions(-) diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 65b315bc60abd..bf243edeb0641 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -822,20 +822,19 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset, u32 length, u8 *data) { int i; - int ret; u32 buf; unsigned long timeout; - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (buf & OTP_PWR_DN_PWRDN_N_) { /* clear it and wait to be cleared */ - ret = lan78xx_write_reg(dev, OTP_PWR_DN, 0); + lan78xx_write_reg(dev, OTP_PWR_DN, 0); timeout = jiffies + HZ; do { usleep_range(1, 10); - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "timeout on OTP_PWR_DN"); @@ -845,18 +844,18 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset, } for (i = 0; i < length; i++) { - ret = lan78xx_write_reg(dev, OTP_ADDR1, + lan78xx_write_reg(dev, OTP_ADDR1, ((offset + i) >> 8) & OTP_ADDR1_15_11); - ret = lan78xx_write_reg(dev, OTP_ADDR2, + lan78xx_write_reg(dev, OTP_ADDR2, ((offset + i) & OTP_ADDR2_10_3)); - ret = lan78xx_write_reg(dev, OTP_FUNC_CMD, OTP_FUNC_CMD_READ_); - ret = lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); + lan78xx_write_reg(dev, OTP_FUNC_CMD, OTP_FUNC_CMD_READ_); + lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); timeout = jiffies + HZ; do { udelay(1); - ret = lan78xx_read_reg(dev, OTP_STATUS, &buf); + lan78xx_read_reg(dev, OTP_STATUS, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "timeout on OTP_STATUS"); @@ -864,7 +863,7 @@ static int lan78xx_read_raw_otp(struct lan78xx_net *dev, u32 offset, } } while (buf & OTP_STATUS_BUSY_); - ret = lan78xx_read_reg(dev, OTP_RD_DATA, &buf); + lan78xx_read_reg(dev, OTP_RD_DATA, &buf); data[i] = (u8)(buf & 0xFF); } @@ -876,20 +875,19 @@ static int lan78xx_write_raw_otp(struct lan78xx_net *dev, u32 offset, u32 length, u8 *data) { int i; - int ret; u32 buf; unsigned long timeout; - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (buf & OTP_PWR_DN_PWRDN_N_) { /* clear it and wait to be cleared */ - ret = lan78xx_write_reg(dev, OTP_PWR_DN, 0); + lan78xx_write_reg(dev, OTP_PWR_DN, 0); timeout = jiffies + HZ; do { udelay(1); - ret = lan78xx_read_reg(dev, OTP_PWR_DN, &buf); + lan78xx_read_reg(dev, OTP_PWR_DN, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "timeout on OTP_PWR_DN completion"); @@ -899,21 +897,21 @@ static int lan78xx_write_raw_otp(struct lan78xx_net *dev, u32 offset, } /* set to BYTE program mode */ - ret = lan78xx_write_reg(dev, OTP_PRGM_MODE, OTP_PRGM_MODE_BYTE_); + lan78xx_write_reg(dev, OTP_PRGM_MODE, OTP_PRGM_MODE_BYTE_); for (i = 0; i < length; i++) { - ret = lan78xx_write_reg(dev, OTP_ADDR1, + lan78xx_write_reg(dev, OTP_ADDR1, ((offset + i) >> 8) & OTP_ADDR1_15_11); - ret = lan78xx_write_reg(dev, OTP_ADDR2, + lan78xx_write_reg(dev, OTP_ADDR2, ((offset + i) & OTP_ADDR2_10_3)); - ret = lan78xx_write_reg(dev, OTP_PRGM_DATA, data[i]); - ret = lan78xx_write_reg(dev, OTP_TST_CMD, OTP_TST_CMD_PRGVRFY_); - ret = lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); + lan78xx_write_reg(dev, OTP_PRGM_DATA, data[i]); + lan78xx_write_reg(dev, OTP_TST_CMD, OTP_TST_CMD_PRGVRFY_); + lan78xx_write_reg(dev, OTP_CMD_GO, OTP_CMD_GO_GO_); timeout = jiffies + HZ; do { udelay(1); - ret = lan78xx_read_reg(dev, OTP_STATUS, &buf); + lan78xx_read_reg(dev, OTP_STATUS, &buf); if (time_after(jiffies, timeout)) { netdev_warn(dev->net, "Timeout on OTP_STATUS completion"); @@ -1038,7 +1036,6 @@ static void lan78xx_deferred_multicast_write(struct work_struct *param) container_of(param, struct lan78xx_priv, set_multicast); struct lan78xx_net *dev = pdata->dev; int i; - int ret; netif_dbg(dev, drv, dev->net, "deferred multicast write 0x%08x\n", pdata->rfe_ctl); @@ -1047,14 +1044,14 @@ static void lan78xx_deferred_multicast_write(struct work_struct *param) DP_SEL_VHF_HASH_LEN, pdata->mchash_table); for (i = 1; i < NUM_OF_MAF; i++) { - ret = lan78xx_write_reg(dev, MAF_HI(i), 0); - ret = lan78xx_write_reg(dev, MAF_LO(i), + lan78xx_write_reg(dev, MAF_HI(i), 0); + lan78xx_write_reg(dev, MAF_LO(i), pdata->pfilter_table[i][1]); - ret = lan78xx_write_reg(dev, MAF_HI(i), + lan78xx_write_reg(dev, MAF_HI(i), pdata->pfilter_table[i][0]); } - ret = lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); + lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); } static void lan78xx_set_multicast(struct net_device *netdev) @@ -1124,7 +1121,6 @@ static int lan78xx_update_flowcontrol(struct lan78xx_net *dev, u8 duplex, u16 lcladv, u16 rmtadv) { u32 flow = 0, fct_flow = 0; - int ret; u8 cap; if (dev->fc_autoneg) @@ -1147,10 +1143,10 @@ static int lan78xx_update_flowcontrol(struct lan78xx_net *dev, u8 duplex, (cap & FLOW_CTRL_RX ? "enabled" : "disabled"), (cap & FLOW_CTRL_TX ? "enabled" : "disabled")); - ret = lan78xx_write_reg(dev, FCT_FLOW, fct_flow); + lan78xx_write_reg(dev, FCT_FLOW, fct_flow); /* threshold value should be set before enabling flow */ - ret = lan78xx_write_reg(dev, FLOW, flow); + lan78xx_write_reg(dev, FLOW, flow); return 0; } @@ -1663,11 +1659,10 @@ static const struct ethtool_ops lan78xx_ethtool_ops = { static void lan78xx_init_mac_address(struct lan78xx_net *dev) { u32 addr_lo, addr_hi; - int ret; u8 addr[6]; - ret = lan78xx_read_reg(dev, RX_ADDRL, &addr_lo); - ret = lan78xx_read_reg(dev, RX_ADDRH, &addr_hi); + lan78xx_read_reg(dev, RX_ADDRL, &addr_lo); + lan78xx_read_reg(dev, RX_ADDRH, &addr_hi); addr[0] = addr_lo & 0xFF; addr[1] = (addr_lo >> 8) & 0xFF; @@ -1700,12 +1695,12 @@ static void lan78xx_init_mac_address(struct lan78xx_net *dev) (addr[2] << 16) | (addr[3] << 24); addr_hi = addr[4] | (addr[5] << 8); - ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo); - ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi); + lan78xx_write_reg(dev, RX_ADDRL, addr_lo); + lan78xx_write_reg(dev, RX_ADDRH, addr_hi); } - ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo); - ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); + lan78xx_write_reg(dev, MAF_LO(0), addr_lo); + lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); ether_addr_copy(dev->net->dev_addr, addr); } @@ -1838,7 +1833,7 @@ static void lan78xx_remove_mdio(struct lan78xx_net *dev) static void lan78xx_link_status_change(struct net_device *net) { struct phy_device *phydev = net->phydev; - int ret, temp; + int temp; /* At forced 100 F/H mode, chip may fail to set mode correctly * when cable is switched between long(~50+m) and short one. @@ -1849,7 +1844,7 @@ static void lan78xx_link_status_change(struct net_device *net) /* disable phy interrupt */ temp = phy_read(phydev, LAN88XX_INT_MASK); temp &= ~LAN88XX_INT_MASK_MDINTPIN_EN_; - ret = phy_write(phydev, LAN88XX_INT_MASK, temp); + phy_write(phydev, LAN88XX_INT_MASK, temp); temp = phy_read(phydev, MII_BMCR); temp &= ~(BMCR_SPEED100 | BMCR_SPEED1000); @@ -1863,7 +1858,7 @@ static void lan78xx_link_status_change(struct net_device *net) /* enable phy interrupt back */ temp = phy_read(phydev, LAN88XX_INT_MASK); temp |= LAN88XX_INT_MASK_MDINTPIN_EN_; - ret = phy_write(phydev, LAN88XX_INT_MASK, temp); + phy_write(phydev, LAN88XX_INT_MASK, temp); } } @@ -1917,14 +1912,13 @@ static void lan78xx_irq_bus_sync_unlock(struct irq_data *irqd) struct lan78xx_net *dev = container_of(data, struct lan78xx_net, domain_data); u32 buf; - int ret; /* call register access here because irq_bus_lock & irq_bus_sync_unlock * are only two callbacks executed in non-atomic contex. */ - ret = lan78xx_read_reg(dev, INT_EP_CTL, &buf); + lan78xx_read_reg(dev, INT_EP_CTL, &buf); if (buf != data->irqenable) - ret = lan78xx_write_reg(dev, INT_EP_CTL, data->irqenable); + lan78xx_write_reg(dev, INT_EP_CTL, data->irqenable); mutex_unlock(&data->irq_lock); } @@ -1991,7 +1985,6 @@ static void lan78xx_remove_irq_domain(struct lan78xx_net *dev) static int lan8835_fixup(struct phy_device *phydev) { int buf; - int ret; struct lan78xx_net *dev = netdev_priv(phydev->attached_dev); /* LED2/PME_N/IRQ_N/RGMII_ID pin to IRQ_N mode */ @@ -2001,11 +1994,11 @@ static int lan8835_fixup(struct phy_device *phydev) phy_write_mmd(phydev, MDIO_MMD_PCS, 0x8010, buf); /* RGMII MAC TXC Delay Enable */ - ret = lan78xx_write_reg(dev, MAC_RGMII_ID, + lan78xx_write_reg(dev, MAC_RGMII_ID, MAC_RGMII_ID_TXC_DELAY_EN_); /* RGMII TX DLL Tune Adjust */ - ret = lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00); + lan78xx_write_reg(dev, RGMII_TX_BYP_DLL, 0x3D00); dev->interface = PHY_INTERFACE_MODE_RGMII_TXID; @@ -2189,28 +2182,27 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) static int lan78xx_set_rx_max_frame_length(struct lan78xx_net *dev, int size) { - int ret = 0; u32 buf; bool rxenabled; - ret = lan78xx_read_reg(dev, MAC_RX, &buf); + lan78xx_read_reg(dev, MAC_RX, &buf); rxenabled = ((buf & MAC_RX_RXEN_) != 0); if (rxenabled) { buf &= ~MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); } /* add 4 to size for FCS */ buf &= ~MAC_RX_MAX_SIZE_MASK_; buf |= (((size + 4) << MAC_RX_MAX_SIZE_SHIFT_) & MAC_RX_MAX_SIZE_MASK_); - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); if (rxenabled) { buf |= MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); } return 0; @@ -2267,13 +2259,12 @@ static int lan78xx_change_mtu(struct net_device *netdev, int new_mtu) int ll_mtu = new_mtu + netdev->hard_header_len; int old_hard_mtu = dev->hard_mtu; int old_rx_urb_size = dev->rx_urb_size; - int ret; /* no second zero-length packet read wanted after mtu-sized packets */ if ((ll_mtu % dev->maxpacket) == 0) return -EDOM; - ret = lan78xx_set_rx_max_frame_length(dev, new_mtu + VLAN_ETH_HLEN); + lan78xx_set_rx_max_frame_length(dev, new_mtu + VLAN_ETH_HLEN); netdev->mtu = new_mtu; @@ -2296,7 +2287,6 @@ static int lan78xx_set_mac_addr(struct net_device *netdev, void *p) struct lan78xx_net *dev = netdev_priv(netdev); struct sockaddr *addr = p; u32 addr_lo, addr_hi; - int ret; if (netif_running(netdev)) return -EBUSY; @@ -2313,12 +2303,12 @@ static int lan78xx_set_mac_addr(struct net_device *netdev, void *p) addr_hi = netdev->dev_addr[4] | netdev->dev_addr[5] << 8; - ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo); - ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi); + lan78xx_write_reg(dev, RX_ADDRL, addr_lo); + lan78xx_write_reg(dev, RX_ADDRH, addr_hi); /* Added to support MAC address changes */ - ret = lan78xx_write_reg(dev, MAF_LO(0), addr_lo); - ret = lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); + lan78xx_write_reg(dev, MAF_LO(0), addr_lo); + lan78xx_write_reg(dev, MAF_HI(0), addr_hi | MAF_HI_VALID_); return 0; } @@ -2330,7 +2320,6 @@ static int lan78xx_set_features(struct net_device *netdev, struct lan78xx_net *dev = netdev_priv(netdev); struct lan78xx_priv *pdata = (struct lan78xx_priv *)(dev->data[0]); unsigned long flags; - int ret; spin_lock_irqsave(&pdata->rfe_ctl_lock, flags); @@ -2354,7 +2343,7 @@ static int lan78xx_set_features(struct net_device *netdev, spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags); - ret = lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); + lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); return 0; } @@ -3804,7 +3793,6 @@ static u16 lan78xx_wakeframe_crc16(const u8 *buf, int len) static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) { u32 buf; - int ret; int mask_index; u16 crc; u32 temp_wucsr; @@ -3813,26 +3801,26 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) const u8 ipv6_multicast[3] = { 0x33, 0x33 }; const u8 arp_type[2] = { 0x08, 0x06 }; - ret = lan78xx_read_reg(dev, MAC_TX, &buf); + lan78xx_read_reg(dev, MAC_TX, &buf); buf &= ~MAC_TX_TXEN_; - ret = lan78xx_write_reg(dev, MAC_TX, buf); - ret = lan78xx_read_reg(dev, MAC_RX, &buf); + lan78xx_write_reg(dev, MAC_TX, buf); + lan78xx_read_reg(dev, MAC_RX, &buf); buf &= ~MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); - ret = lan78xx_write_reg(dev, WUCSR, 0); - ret = lan78xx_write_reg(dev, WUCSR2, 0); - ret = lan78xx_write_reg(dev, WK_SRC, 0xFFF1FF1FUL); + lan78xx_write_reg(dev, WUCSR, 0); + lan78xx_write_reg(dev, WUCSR2, 0); + lan78xx_write_reg(dev, WK_SRC, 0xFFF1FF1FUL); temp_wucsr = 0; temp_pmt_ctl = 0; - ret = lan78xx_read_reg(dev, PMT_CTL, &temp_pmt_ctl); + lan78xx_read_reg(dev, PMT_CTL, &temp_pmt_ctl); temp_pmt_ctl &= ~PMT_CTL_RES_CLR_WKP_EN_; temp_pmt_ctl |= PMT_CTL_RES_CLR_WKP_STS_; for (mask_index = 0; mask_index < NUM_OF_WUF_CFG; mask_index++) - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), 0); + lan78xx_write_reg(dev, WUF_CFG(mask_index), 0); mask_index = 0; if (wol & WAKE_PHY) { @@ -3861,30 +3849,30 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) /* set WUF_CFG & WUF_MASK for IPv4 Multicast */ crc = lan78xx_wakeframe_crc16(ipv4_multicast, 3); - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), + lan78xx_write_reg(dev, WUF_CFG(mask_index), WUF_CFGX_EN_ | WUF_CFGX_TYPE_MCAST_ | (0 << WUF_CFGX_OFFSET_SHIFT_) | (crc & WUF_CFGX_CRC16_MASK_)); - ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 7); - ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK0(mask_index), 7); + lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); mask_index++; /* for IPv6 Multicast */ crc = lan78xx_wakeframe_crc16(ipv6_multicast, 2); - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), + lan78xx_write_reg(dev, WUF_CFG(mask_index), WUF_CFGX_EN_ | WUF_CFGX_TYPE_MCAST_ | (0 << WUF_CFGX_OFFSET_SHIFT_) | (crc & WUF_CFGX_CRC16_MASK_)); - ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 3); - ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK0(mask_index), 3); + lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); mask_index++; temp_pmt_ctl |= PMT_CTL_WOL_EN_; @@ -3905,16 +3893,16 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) * for packettype (offset 12,13) = ARP (0x0806) */ crc = lan78xx_wakeframe_crc16(arp_type, 2); - ret = lan78xx_write_reg(dev, WUF_CFG(mask_index), + lan78xx_write_reg(dev, WUF_CFG(mask_index), WUF_CFGX_EN_ | WUF_CFGX_TYPE_ALL_ | (0 << WUF_CFGX_OFFSET_SHIFT_) | (crc & WUF_CFGX_CRC16_MASK_)); - ret = lan78xx_write_reg(dev, WUF_MASK0(mask_index), 0x3000); - ret = lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); - ret = lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK0(mask_index), 0x3000); + lan78xx_write_reg(dev, WUF_MASK1(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK2(mask_index), 0); + lan78xx_write_reg(dev, WUF_MASK3(mask_index), 0); mask_index++; temp_pmt_ctl |= PMT_CTL_WOL_EN_; @@ -3922,7 +3910,7 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) temp_pmt_ctl |= PMT_CTL_SUS_MODE_0_; } - ret = lan78xx_write_reg(dev, WUCSR, temp_wucsr); + lan78xx_write_reg(dev, WUCSR, temp_wucsr); /* when multiple WOL bits are set */ if (hweight_long((unsigned long)wol) > 1) { @@ -3930,16 +3918,16 @@ static int lan78xx_set_suspend(struct lan78xx_net *dev, u32 wol) temp_pmt_ctl &= ~PMT_CTL_SUS_MODE_MASK_; temp_pmt_ctl |= PMT_CTL_SUS_MODE_0_; } - ret = lan78xx_write_reg(dev, PMT_CTL, temp_pmt_ctl); + lan78xx_write_reg(dev, PMT_CTL, temp_pmt_ctl); /* clear WUPS */ - ret = lan78xx_read_reg(dev, PMT_CTL, &buf); + lan78xx_read_reg(dev, PMT_CTL, &buf); buf |= PMT_CTL_WUPS_MASK_; - ret = lan78xx_write_reg(dev, PMT_CTL, buf); + lan78xx_write_reg(dev, PMT_CTL, buf); - ret = lan78xx_read_reg(dev, MAC_RX, &buf); + lan78xx_read_reg(dev, MAC_RX, &buf); buf |= MAC_RX_RXEN_; - ret = lan78xx_write_reg(dev, MAC_RX, buf); + lan78xx_write_reg(dev, MAC_RX, buf); return 0; } From patchwork Mon Nov 2 11:45:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873711 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D612C388F2 for ; Mon, 2 Nov 2020 11:47:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13251223BD for ; Mon, 2 Nov 2020 11:47:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iQF/a9Co" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728784AbgKBLrm (ORCPT ); Mon, 2 Nov 2020 06:47:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728668AbgKBLp7 (ORCPT ); Mon, 2 Nov 2020 06:45:59 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8047C040208 for ; Mon, 2 Nov 2020 03:45:51 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id h22so9215626wmb.0 for ; Mon, 02 Nov 2020 03:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5oUC6Va014UtrlRcCbDs4GNP4CgSuaSNLLRcp4b0LvM=; b=iQF/a9CoUruapBJrFnUqxVwaWOKGPXgbLBMakAGZC8BLtPxjKyqanbtEfHKkO5YIGZ 16Q0NhUYBg8tiGlNHEHHTD85UpWtPH5RsswHkfSI9DT0c22fd/epWbrqkkWrxEHmMtdE NS6ZKm4kqh72EPuoeO4BTGqXzFde8oFuOz8bYviEl7GinDDUkHlaGreje9hjQOLxq/td NCbIi6D8CwZzsCOpTZdl4ySvmr5jvBDlqsMf5o3xyfjRj1AjKixP0d8pRarRDZo5sl6Z lUl7uLCw8utg6bBrDZ+oHf5VxvVxP8o2/hFOjw+iVhwI8IU4wgJq5fYty+3iRb409uUP vqGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5oUC6Va014UtrlRcCbDs4GNP4CgSuaSNLLRcp4b0LvM=; b=sxx8Vkl94i+Rj4QjayBzA9bz85DlpyJz9dh7vX34bwFUfKvv56Dv6L+AxW4l4CX9Dm ow5UAQs2/ChrB68c8knZ8J1JkMAwOOSrezXb2Qfmb/mad1xfwfDFHgd0+Ly6OPXa52rd UcRHsqpNV93b0Bkl8/RTMOPq8gTIKGzbFfSZt1nlaBPar9uUPqhshLe94rwxN4Mddpxl kx6vaAs6HJlLecZh5hIqpG00z3zVcqJJIurbh1eUOPewonDxmMboszxmNnB+YYcRNVx5 peJDvmq0Q8J8S0JtPVFVnst/nAL5wsKl7xaqm+jZrxOMCmqAkzNfpxxLoJbH2NAKj2ul Bu7Q== X-Gm-Message-State: AOAM531sKJnp1jjrVOtu0hJRXpoGzxlIsjia0yBtnO7rUiywFwtqmhyo bkF6MQnvMZweIOsZHPyOEA/0DA== X-Google-Smtp-Source: ABdhPJz0YApYIF0oABznSZuXC8NHJa5ODWlpRrd9yMx7G/7RbC0uBlfVBHVg3Uo3fJHnxsi+eXwYNQ== X-Received: by 2002:a1c:f417:: with SMTP id z23mr16497597wma.57.1604317550516; Mon, 02 Nov 2020 03:45:50 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:49 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , Sabrina Dubroca , netdev@vger.kernel.org Subject: [PATCH 25/30] net: macsec: Add missing documentation for 'gro_cells' Date: Mon, 2 Nov 2020 11:45:07 +0000 Message-Id: <20201102114512.1062724-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/macsec.c:113: warning: Function parameter or member 'gro_cells' not described in 'macsec_dev' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Sabrina Dubroca Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/macsec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index 11ca5fa902a16..92425e1fd70c0 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -101,6 +101,7 @@ struct pcpu_secy_stats { * @real_dev: pointer to underlying netdevice * @stats: MACsec device stats * @secys: linked list of SecY's on the underlying device + * @gro_cells: pointer to the Generic Receive Offload cell * @offload: status of offloading on the MACsec device */ struct macsec_dev { From patchwork Mon Nov 2 11:45:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873695 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B511C00A89 for ; Mon, 2 Nov 2020 11:46:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9514222B9 for ; Mon, 2 Nov 2020 11:46:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wKZjryqR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728735AbgKBLqq (ORCPT ); Mon, 2 Nov 2020 06:46:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728680AbgKBLqA (ORCPT ); Mon, 2 Nov 2020 06:46:00 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04F9CC0401C0 for ; Mon, 2 Nov 2020 03:45:53 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id a9so14188694wrg.12 for ; Mon, 02 Nov 2020 03:45:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xGhEowgdcWKuLXb9Pj9j/sbipGm9ceEZBmZdHTodzCE=; b=wKZjryqR/URTMssBcGm64w4KUfxhYG2WPxJQBrHlyVdGxCRdYxQammgX7+ShmZDJD+ 8LSA9+0F7ttyH3y1W3oMGPC7kLAaOCYlHQp9mUCIL6eYT04luKhFq5MlRBVa99tZeQPd u2mSCMIp4bxIq5WJOPtVbG3KSmCFXcmc4kRRpvLas+fOVCemv8qyx51AZXjpSpzrczUN zgN4y8kiq6c7lR8ix1Wfajl6SmiYrP8IffCOkZq/FSI20aGy4jw85PMlBBWE+zAH/T44 BCESXXTqATDNCae+PemlLwGo5ZJcV+yYlfCJ/G4LWAafmpTvF3F8/kdFSzbNfA32+TPI Ue4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xGhEowgdcWKuLXb9Pj9j/sbipGm9ceEZBmZdHTodzCE=; b=CRJDXrXGIcfHgPyN9wHgLyAe8hI3iBxlfWRlEtSvudRvm0eDTY0LWfHZvG0xwajRnx rAHK//RNFg78KPjTpgehi8TK6YUzQdoqcCvi5hd0qCSn1FlXRrIBZijnMLdiKwD7T9Ad foZVvLwMH0PXBxwtQdsqj6403Qke4xYmszdh+U3hELL2V/UdLahyzPzj1JQ6IF5Tj17G EWr/RZ87DoOcOZav0knE91D1glSvq25ufkPZrxOnaeBQg+8UzvGub9SKuKeVT6qFBLGM 13ZJBv5xe3kvDiSszDj2NIE2LdnyAo/1+beXnttGkyfz310JyG2G7x/BBhPtKbIF5uzl Si4A== X-Gm-Message-State: AOAM531+JrSOQ5KzxkPqAl93vV/XPgyfVmPfKk9QzVAB8SJAuiFAjgLV fty3XcqwRPjONZWjrk1Y1oMYDw== X-Google-Smtp-Source: ABdhPJyJAJryg0Y2/RgjMFbI+6TE1BgLepiCm1HDAowKJ0KbRJV00hGw+Q/Puf3A+TfrCF8Gv4wqOg== X-Received: by 2002:adf:f90f:: with SMTP id b15mr19883731wrr.343.1604317551745; Mon, 02 Nov 2020 03:45:51 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:51 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , Patrick McHardy , Broadband Ltd , Ben Greear , netdev@vger.kernel.org Subject: [PATCH 26/30] net: macvlan: Demote nonconformant function header Date: Mon, 2 Nov 2020 11:45:08 +0000 Message-Id: <20201102114512.1062724-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/macvlan.c:1350: warning: Function parameter or member 'vlan' not described in 'macvlan_changelink_sources' drivers/net/macvlan.c:1350: warning: Function parameter or member 'mode' not described in 'macvlan_changelink_sources' drivers/net/macvlan.c:1350: warning: Function parameter or member 'data' not described in 'macvlan_changelink_sources' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Patrick McHardy Cc: Broadband Ltd Cc: Ben Greear Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/macvlan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index c8d803d3616c9..dd960209da943 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1339,7 +1339,7 @@ static int macvlan_validate(struct nlattr *tb[], struct nlattr *data[], return 0; } -/** +/* * reconfigure list of remote source mac address * (only for macvlan devices in source mode) * Note regarding alignment: all netlink data is aligned to 4 Byte, which From patchwork Mon Nov 2 11:45:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873721 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72EA5C388F2 for ; Mon, 2 Nov 2020 11:47:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23BA0222B9 for ; Mon, 2 Nov 2020 11:47:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="w3v/425t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728592AbgKBLri (ORCPT ); Mon, 2 Nov 2020 06:47:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728679AbgKBLqA (ORCPT ); Mon, 2 Nov 2020 06:46:00 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34B25C061A4B for ; Mon, 2 Nov 2020 03:45:54 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id h62so4366925wme.3 for ; Mon, 02 Nov 2020 03:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=d6wOWByAs5f7rPxO4TjrPC/r2b2juD5yTl6dq0Ru2bA=; b=w3v/425to/PN6qqmfV7Xffc9tidXa3aIqhEw/99cZfikh0L1vYo6bZkLAbNLAM4WV/ 6X3p5qEEAidUSJaQq09QNspMewmEXCBK6jydtHzEdJaSBrXiuxA8yLFclLzO7mAYbMLi PIpFohCM/NaOn6gAOE0RzCn8V4qifhiHeKubhlDq/IZ4K3IIK6qZ1eWh9DdZor5riHqF Jm9vxBUrSISCugSkpBuwXkanE2HaMBQYjTLZMyzQt3F+3RIZLPQeGAwbGGavDUt9RPDr crBJDbEeOoPjTrk9FqN0pwve6L+6l3Eg3mjlNy46gwluXGWJ8x59UfpjkYTdCJo3D1QJ Ub5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=d6wOWByAs5f7rPxO4TjrPC/r2b2juD5yTl6dq0Ru2bA=; b=JEn6CvRSfiAuWmpHdt4NeNY6Vvp5SFvlpyf4oZCufs+oaomGhR3X0g/SoPE+ZixCHE /Gk2iHSdNn5A5PVuc3KFL47cvq+msYHZ09bh41cXdDIP+PCVaoOGTUrjxPVXUS0D16M9 QxgOq88pRTxv7qursV2EmOVpxn7f2layLHw1nwxfNnOi0uv2hA8MgjRaAcrwzELVGxVg EjQ1tE+/qZ9K3fWPfxWbhrLbkIHaeS9cbH9+1VnGA2Pl9erGk69UDQMIhF3PLr9tBTUN Z0Jpu4GxCQXqWLt5T7djX6Xqalc/lw+wMDdUM3zB1IYcvhZOJuVeGfrAC4+WfFAxcMQw HiaQ== X-Gm-Message-State: AOAM532WZ88gwN8ImSYqLOM0ZAGMlv4wr5KiSawVBbz2YkAlUtv/12M0 d4u/6X6fCDICCeggsAsm/cl6IQ== X-Google-Smtp-Source: ABdhPJyuV8hFjrgOthwkEdNUG99Fk5kK5NnRsdCIbtsCSyJsAfexvpjRgdIY4aDBFj1B9Ahew0rJiw== X-Received: by 2002:a1c:4e0e:: with SMTP id g14mr8861120wmh.9.1604317552974; Mon, 02 Nov 2020 03:45:52 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:52 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , Hayes Wang , nic maintainers , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 27/30] net: usb: r8152: Fix a couple of spelling errors in fw_phy_nc's docs Date: Mon, 2 Nov 2020 11:45:09 +0000 Message-Id: <20201102114512.1062724-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/usb/r8152.c:992: warning: Function parameter or member 'mode_pre' not described in 'fw_phy_nc' drivers/net/usb/r8152.c:992: warning: Function parameter or member 'mode_post' not described in 'fw_phy_nc' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Hayes Wang Cc: nic maintainers Cc: linux-usb@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Hayes Wang --- drivers/net/usb/r8152.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index cebe2dc15c3f0..b9b3d19a2e988 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -963,8 +963,8 @@ struct fw_phy_patch_key { * @patch_en_addr: the register of enabling patch mode. Depends on chip. * @patch_en_value: patch mode enabled mask. Depends on the firmware. * @mode_reg: the regitster of switching the mode. - * @mod_pre: the mode needing to be set before loading the firmware. - * @mod_post: the mode to be set when finishing to load the firmware. + * @mode_pre: the mode needing to be set before loading the firmware. + * @mode_post: the mode to be set when finishing to load the firmware. * @reserved: reserved space (unused) * @bp_start: the start register of break points. Depends on chip. * @bp_num: the break point number which needs to be set for this firmware. From patchwork Mon Nov 2 11:45:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873715 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C57C388F2 for ; Mon, 2 Nov 2020 11:47:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BF49207BB for ; Mon, 2 Nov 2020 11:47:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yby+34tg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728708AbgKBLrf (ORCPT ); Mon, 2 Nov 2020 06:47:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51436 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbgKBLqA (ORCPT ); Mon, 2 Nov 2020 06:46:00 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37248C0401C2 for ; Mon, 2 Nov 2020 03:45:55 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id a9so14188830wrg.12 for ; Mon, 02 Nov 2020 03:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qRyyhT2AWsAOiMgoL3f0fJFF+pEVB6J7sHbwygfJRQ4=; b=yby+34tgJw4ulZID9MO+AkwPdoB+lgG/KF699C6ysVMZmY5ZMs/K8eK2UdR7TmvODj 2LCdDXqy1BkH5rIqnQsyf7N2ABBGx59blLnBn23X+JGtDd0ho4v0S1Rd9P5nYlTQz1rP imeHg28VCHg5O9Wee87TWnjZMAVjXh2auTZO+NTQxexs7ljsTQSfpiFz+LSDgUp9W7GY WeEJuSm6W551rPQ689dmWWUw/8lt6KDJUK+FQMdr5gFjFstMp8jJjE70ZjOL9Kaa0vFt QKEx6Etp9Ub0zGvuxJh1Gpx9ytWMn/V5uW73qeENSK6KFASRXGHb0GmO88N0LagO00jE Rgww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qRyyhT2AWsAOiMgoL3f0fJFF+pEVB6J7sHbwygfJRQ4=; b=m6ByTcQh6srkLccx6HZ0KNnpukhGxXkVs+eztss35tJkWil2XliknfGCm2gVQSHgxD xso3Fs8MuKJo4pRWSKxCYJggE7ism2k5XRUBm4gKxWClrRVBSLv/04ANgrGcRF1fxUEk h60V//rM4yFpeOMhzPckVW8fmLfg6b8lED8GwP+4fn2g0OPm6wJQNQDsuj5AUchJFaAm xv6RJmXDNF8WfpOwbZEtYUGSRO5FID6Bvn6DOXj3kJECXSKeTwsEWT5AbRYeLtWn5Hks 9wwZTCnzuM8z44T7Ok5EqimOnuzrC17HgbSr6UGjSjja91SzSnOVTE7t6Pl1EGYX/M5F yULA== X-Gm-Message-State: AOAM530WTXmO6xsnWK6NoNH4ztDb3C8NUb0aRu/7/4cVzSjIEPX/+7L2 wT3gbm9b8OWqnpDC9RLjOCMwvFF63oHOgA== X-Google-Smtp-Source: ABdhPJyAos5nl+3PwujH9XAhxApX2rSFmyk/MyXjAFeSwdTg9e4wkEmYoPTeUCplhSzBTAURRcOhYg== X-Received: by 2002:adf:cf10:: with SMTP id o16mr19697049wrj.264.1604317554017; Mon, 02 Nov 2020 03:45:54 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:53 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Jakub Kicinski , Ingo Molnar , Matt Mackall , netdev@vger.kernel.org Subject: [PATCH 28/30] net: netconsole: Add description for 'netconsole_target's extended attribute Date: Mon, 2 Nov 2020 11:45:10 +0000 Message-Id: <20201102114512.1062724-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/netconsole.c:104: warning: Function parameter or member 'extended' not described in 'netconsole_target' Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Ingo Molnar Cc: Matt Mackall Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/netconsole.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c index 92001f7af380c..ccecba908ded6 100644 --- a/drivers/net/netconsole.c +++ b/drivers/net/netconsole.c @@ -83,6 +83,7 @@ static struct console netconsole_ext; * whether the corresponding netpoll is active or inactive. * Also, other parameters of a target may be modified at * runtime only when it is disabled (enabled == 0). + * @extended: Denotes whether console is extended or not. * @np: The netpoll structure for this target. * Contains the other userspace visible parameters: * dev_name (read-write) From patchwork Mon Nov 2 11:45:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873709 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 783BBC00A89 for ; Mon, 2 Nov 2020 11:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1A126206A4 for ; Mon, 2 Nov 2020 11:47:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QsVFsIkm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728460AbgKBLra (ORCPT ); Mon, 2 Nov 2020 06:47:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728693AbgKBLqC (ORCPT ); Mon, 2 Nov 2020 06:46:02 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59CA6C0401C4 for ; Mon, 2 Nov 2020 03:45:56 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id s9so14199918wro.8 for ; Mon, 02 Nov 2020 03:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QwG68V9MoarwqZHiGt0L1iQ02kmf6AVMeQn4KDmuzCk=; b=QsVFsIkmbkm8kUDo4iMhPtRk0lqsVk/OO+HtLIKaS/d/HE3DjqR0ZMAG3Pa/3oBJB6 4kZ2OYOrhDtBapWw/onwlsgS5vDEdirqO0uO053mbPSOkKaZtgHIzme5+KLlIjpzvX8p LrlYKdFqub0FqXYShTqL1wUhJ3pMfZyMmF5Y5ULT1vwc0tfZQAKP6X1iOPpFrwAQMtBc UGAtxqwR9lw7lqxoeA2QS16bhpjSlGFcPCSeJOCBTEKJTZe2Fov/5uxB7LvjpldTNwiA x60ehNrybDS3SbjLeQqsk6OdaozmELdwQCUA/CQP94A71eA+XFL8A0OSBHwxV3Eo4pmj tj+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QwG68V9MoarwqZHiGt0L1iQ02kmf6AVMeQn4KDmuzCk=; b=oxWZ00ESchPCHWm4x3hWC5JVAsvipXYzsQjWT5lBQnIZm+4XrLHpJvR2Uz/k7NDu1v VkAmIdeGyG1tG12I3cgmfTay+pNLPKrtCZeqVT0lWujTXYJi7qd7FZBDxOCHM69E/95f tCwTSpGL15TOcA/0xx+GEm3PBbfghyXRUxkPGMZRTe0sPv7RiCxGazzYemtOFjqG0ZNe x++yQGuLchURntxmaE0exsQtKKJHi5ZkVwgiwYpoOlSOMqccVUs05YsS4tkrlGKo9jaq BhlyIk7OfU+3AqXV16qM+6+EbWYzPDtZYVm3VQljVswxgSnHUfJF2mnhn0vZTleflo0J y82Q== X-Gm-Message-State: AOAM530quQN7SKBxTFFDxTJeZMXJ/x58XzU2FsByRk8B2pe84JgrvZd6 zs322C3ZWFSp2pI879BLhyel/A== X-Google-Smtp-Source: ABdhPJy2EACqzIzHB9Q+zHtwKZLr8whwEeebgXGyZL/f0jkbsJlckM9ox4cmxubumfYqpabDdHTcBg== X-Received: by 2002:a5d:4001:: with SMTP id n1mr20205511wrp.426.1604317555130; Mon, 02 Nov 2020 03:45:55 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:54 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Sridhar Samudrala , Jakub Kicinski , netdev@vger.kernel.org Subject: [PATCH 29/30] net: net_failover: Correct parameter name 'standby_dev' Date: Mon, 2 Nov 2020 11:45:11 +0000 Message-Id: <20201102114512.1062724-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/net_failover.c:711: warning: Function parameter or member 'standby_dev' not described in 'net_failover_create' drivers/net/net_failover.c:711: warning: Excess function parameter 'dev' description in 'net_failover_create' Cc: Sridhar Samudrala Cc: "David S. Miller" Cc: Jakub Kicinski Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/net_failover.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/net_failover.c b/drivers/net/net_failover.c index fb182bec8f062..2a4892402ed8c 100644 --- a/drivers/net/net_failover.c +++ b/drivers/net/net_failover.c @@ -697,7 +697,7 @@ static struct failover_ops net_failover_ops = { /** * net_failover_create - Create and register a failover instance * - * @dev: standby netdev + * @standby_dev: standby netdev * * Creates a failover netdev and registers a failover instance for a standby * netdev. Used by paravirtual drivers that use 3-netdev model. From patchwork Mon Nov 2 11:45:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11873717 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5D59C388F2 for ; Mon, 2 Nov 2020 11:47:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7C92021D91 for ; Mon, 2 Nov 2020 11:47:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jzCNUlgP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728693AbgKBLrc (ORCPT ); Mon, 2 Nov 2020 06:47:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728689AbgKBLqB (ORCPT ); Mon, 2 Nov 2020 06:46:01 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98C70C0401C6 for ; Mon, 2 Nov 2020 03:45:57 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id 33so3428599wrl.7 for ; Mon, 02 Nov 2020 03:45:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PCJb8WRZZMprUiDuUrCCgk0qpYM+re9rQeuSrQaWY/Y=; b=jzCNUlgPqonybZGC9xi6yfUkXjrLgYS6Y7E0FluwJYKBuaSC55hE9+6HTGWXXasTVQ 6PYP//yPFBxL+EPmhuVDOP/fLknimjudGTxtWw+b30dXehEq8woplqI6gSJBOyxyCg9w nZkMigvlHJkx8zzxPyBRu8YrhRil58NV14HYbifDU+aFIx8P9SG48UcsG7L7CaK4mIK1 qZ5ABtHzZmBr472oSWyGjL+MVsIVdDaov0mo2ZT6f9ray7ul2k4VUddmDEsYG0rxtcZl iRA6D0XmWzuJypSBT28JJKhiVOYKuEzv3oxiBVmOOVL91fipPjncZr8WhC6ShVllZMgq fmsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PCJb8WRZZMprUiDuUrCCgk0qpYM+re9rQeuSrQaWY/Y=; b=E9JDBbhI70ySmrtqwxfZWLE11nxdz94R5g5JWj/kNgVukZHUk9TMz3HQKhCB+MaATO UGXDjtZ1wzK0EHuHuXdLiYTfaRgbbOvgaemDi4RJJ51EU4vnBfHSBESPpCp8QlQE/uOJ SHSHrazKggVSlB67Cz7TZk0VlvpGwRGghfcoKyzMMMH3djv+LxBT/xDIWMKXCZomap+v ZWo0hKHWn7kQDeoC+ljwLtTYkrS00kZ7soSVX8QLemEnDLW/M9ReBRlVXc05E2dta1Mx /3SK4ytHAqHWtSj0ti2ODmCRHEORxYIeQng7FD09wCj7jw6sjZqkO8jGEYxalgZx6lef xh/A== X-Gm-Message-State: AOAM533zl9A44g9XfMhPxeBjorSJ/VRKUWnxu9YFvcWJB/14aB75i+D8 /4o4rqfEqRwlMz5d0aZDTQNwtg== X-Google-Smtp-Source: ABdhPJxcxe2k7Y3U2mdQ5lLdFpWzE9sCSbTrnu9RLba5DQPaSQe+9Mm8Lnvu+2wktpZcupxuZRPutw== X-Received: by 2002:adf:eb4d:: with SMTP id u13mr18862571wrn.146.1604317556383; Mon, 02 Nov 2020 03:45:56 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id g66sm15545352wmg.37.2020.11.02.03.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:45:55 -0800 (PST) From: Lee Jones To: davem@davemloft.net Cc: Lee Jones , Nicolas Pitre , Jakub Kicinski , Erik Stahlman , Peter Cammaert , Daris A Nevil , Russell King , netdev@vger.kernel.org Subject: [PATCH 30/30] net: ethernet: smsc: smc91x: Mark 'pkt_len' as __maybe_unused Date: Mon, 2 Nov 2020 11:45:12 +0000 Message-Id: <20201102114512.1062724-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102114512.1062724-1-lee.jones@linaro.org> References: <20201102114512.1062724-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org 'pkt_len' is used to interact with a hardware register. It might not be safe to remove it entirely. Mark it as __maybe_unused instead. Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/smsc/smc91x.c: In function ‘smc_tx’: drivers/net/ethernet/smsc/smc91x.c:706:51: warning: variable ‘pkt_len’ set but not used [-Wunused-but-set-variable] Cc: Nicolas Pitre Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Erik Stahlman Cc: Peter Cammaert Cc: Daris A Nevil Cc: Russell King Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/ethernet/smsc/smc91x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index b5d053292e717..a3f37b1f86491 100644 --- a/drivers/net/ethernet/smsc/smc91x.c +++ b/drivers/net/ethernet/smsc/smc91x.c @@ -703,7 +703,7 @@ static void smc_tx(struct net_device *dev) { struct smc_local *lp = netdev_priv(dev); void __iomem *ioaddr = lp->base; - unsigned int saved_packet, packet_no, tx_status, pkt_len; + unsigned int saved_packet, packet_no, tx_status, __maybe_unused pkt_len; DBG(3, dev, "%s\n", __func__);