From patchwork Wed Nov 4 10:53:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernard Zhao X-Patchwork-Id: 11880405 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 144ECC2D0A3 for ; Wed, 4 Nov 2020 10:55:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 921E320867 for ; Wed, 4 Nov 2020 10:55:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="vcwQ6zdp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 921E320867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZtXmQbRam7bN31S4ahegncGFn9D6CmElZDUtrC2cCR8=; b=vcwQ6zdpXGvOZFTPnnD3OZgbZ jHlzvwWrHszGbgWz79hWTkMTYukLmjS0LU9tsc6bAk2Fs6ZlvYj2x8NxTZnzXObPi/p0MB4yzgHsr gQRXiaxE9X8f2KsX4OmZD57jjro7+T/qK1xJnynqTizhXlmDjiG7f/GqRadPZ+352eQdB9c68gLfx NRL4eQWi23cceZrMcMbmWM2x5mwVhCi+wGVyFjRBXRW27+tj/0TWNZMrPMcJBYJi0EbVy7GRnZFIG 23tsc/dztVpThHFUcIhZXEvLffygWKsxWTvZxwxBOtkziIw/06XIbnRufIzRcrk5Its1tBde/MeEQ sLCkA3TkA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaGQb-00019V-Tz; Wed, 04 Nov 2020 10:54:10 +0000 Received: from mail-m17613.qiye.163.com ([59.111.176.13]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaGQJ-00011w-3g for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 10:53:54 +0000 Received: from ubuntu.localdomain (unknown [58.213.83.156]) by mail-m17613.qiye.163.com (Hmail) with ESMTPA id 73C70482CF2; Wed, 4 Nov 2020 18:53:48 +0800 (CST) From: Bernard Zhao To: Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] drivers/tty: delete break after goto Date: Wed, 4 Nov 2020 02:53:30 -0800 Message-Id: <20201104105331.16654-2-bernard@vivo.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20201104105331.16654-1-bernard@vivo.com> References: <20201104105331.16654-1-bernard@vivo.com> MIME-Version: 1.0 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZGh4eTEtPHUxIGUxLVkpNS09PQ0xJSUNMSU9VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS09ISFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6OTo6Qjo5Dj8fNx8QA0MYCAwU SDYKCU1VSlVKTUtPT0NMSUlCSk5OVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlOQ1VJ SkhVQ0hVSk5NWVdZCAFZQUlNQ0g3Bg++ X-HM-Tid: 0a7592e42cfa93bakuws73c70482cf2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_055351_705968_39A37977 X-CRM114-Status: UNSURE ( 8.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com, Bernard Zhao Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Delete break after goto, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/nozomi.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..946cc16827aa 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c @@ -414,11 +414,9 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start, buf16 = (u16 *) buf; *buf16 = __le16_to_cpu(readw(ptr)); goto out; - break; case 4: /* 4 bytes */ *(buf) = __le32_to_cpu(readl(ptr)); goto out; - break; } while (i < size_bytes) { @@ -460,7 +458,6 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf, buf16 = (const u16 *)buf; writew(__cpu_to_le16(*buf16), ptr); return 2; - break; case 1: /* * also needs to write 4 bytes in this case * so falling through.. @@ -468,7 +465,6 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf, case 4: /* 4 bytes */ writel(__cpu_to_le32(*buf), ptr); return 4; - break; } while (i < size_bytes) { From patchwork Wed Nov 4 10:53:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernard Zhao X-Patchwork-Id: 11880401 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E341C2D0A3 for ; Wed, 4 Nov 2020 10:54:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8451320867 for ; Wed, 4 Nov 2020 10:54:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gs8iYD31" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8451320867 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WQgQyYYA/Dq/Oik/gNDRPCC6BngekDKVoK3mhwUI4AY=; b=gs8iYD31S716ZQByjLJ3y++vj 0//huzBMSnCOFSzo969DM6RMeWYsz/bpfqCXTHcB/6K/ZFX8+hnMtIkiC28az94IJr5pEjphGCLVd lVgQbMdcqqWSDi2rgoBQJeOn5bXTkm2qO1l0w3nU9Rdua5TGdvFAyVnU0g9ZxG/j05PIMdfP1sQo1 JNnd2dE5XE0oER+nA0JdliHoXbO8oInoCwuCXijO5SCaGZZOciuYBCKOuh7Hm9FgZeT/3vkCsqB0V aNiIbxEc3aYUiFbX2im7ydPyr36Uw2DTG+FjG431n37Dgi0UKMBaG+2BQdWxKBhOqUk7XnPR4iFv0 1VhgG1Rxw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaGQo-0001Eq-6P; Wed, 04 Nov 2020 10:54:22 +0000 Received: from mail-m17613.qiye.163.com ([59.111.176.13]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kaGQM-00013E-47 for linux-arm-kernel@lists.infradead.org; Wed, 04 Nov 2020 10:53:56 +0000 Received: from ubuntu.localdomain (unknown [58.213.83.156]) by mail-m17613.qiye.163.com (Hmail) with ESMTPA id 3E749482D14; Wed, 4 Nov 2020 18:53:51 +0800 (CST) From: Bernard Zhao To: Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] drivers/tty: delete break after return Date: Wed, 4 Nov 2020 02:53:31 -0800 Message-Id: <20201104105331.16654-3-bernard@vivo.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20201104105331.16654-1-bernard@vivo.com> References: <20201104105331.16654-1-bernard@vivo.com> MIME-Version: 1.0 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZS0MdGUsfGUIdSB4aVkpNS09PQ0xJSEpOSENVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS09ISFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PCI6PSo6Mz8oNx8qA00ICE9I HjoaCTBVSlVKTUtPT0NMSUhKQkxJVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlOQ1VJ SkhVQ0hVSk5NWVdZCAFZQUlOQ0s3Bg++ X-HM-Tid: 0a7592e437fa93bakuws3e749482d14 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201104_055354_439021_75C8DDB6 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com, Bernard Zhao Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) switch (offset) { case UCR1: return sport->ucr1; - break; case UCR2: /* * UCR2_SRST is the only bit in the cached registers that might @@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) if (!(sport->ucr2 & UCR2_SRST)) sport->ucr2 = readl(sport->port.membase + offset); return sport->ucr2; - break; case UCR3: return sport->ucr3; - break; case UCR4: return sport->ucr4; - break; case UFCR: return sport->ufcr; - break; default: return readl(sport->port.membase + offset); }