From patchwork Thu Nov 5 14:44:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884575 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C696C4741F for ; Thu, 5 Nov 2020 14:52:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7142E21D81 for ; Thu, 5 Nov 2020 14:52:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DvX+YFq0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7142E21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FA436ED84; Thu, 5 Nov 2020 14:52:17 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29B0D6ED84 for ; Thu, 5 Nov 2020 14:52:17 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id h2so1874450wmm.0 for ; Thu, 05 Nov 2020 06:52:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7qK4vXzf9k749HbSw+NxCxzFALmYv20LEPAyeYzlRJg=; b=DvX+YFq0boewLykq+SRnhh+o0RblVNOCxqwRFP2HW2CfK8Pmx+3clePTBNvWOqiAlo 6iifsKbFhESVU9JX1Qr5PP3j4dk/WVzjt2wT3rOzCJxtGSfqG4Eydl0yANYEeFhEgO6X h8na7H0n4q2V40frBQtsO3lUoXDLl2yfMTqiTyiX7pzXyTwkHKZkku74oLaqgrThJGFI ledlIjIxUT9uBm0nugUaAnD4Lpvzr7y5LnZsQUsg+h/5H3vPdpeq59M69qrP+c8tT58U 62w8Eo6U3pbROKNyR3Mk6PqEF6d3dXVYNVkzALqqNEz84J82wk3bz83cXzHDm8kHLD1f qtoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7qK4vXzf9k749HbSw+NxCxzFALmYv20LEPAyeYzlRJg=; b=UTqU1p18UoiRNcmAfqjgGcJnIsEkscIkBw4IyGF4Y/pY1/cB8Xu0IswtBtMolN2vlg 2SH8vbV4b4DWX8bwfVLtsTSlrl8rIe8laJgb/miO/PZh4gZmuIAHYBw4zZoh85vsgLEm 0D6oTKgNwgnJobOBYc+Ga8Oj+9pR/0Dzq2FJ7rfUZ6KENNLhwS7VJghvEa9uLSOhkxy1 Igmpl1K+S8mE9ZrbBjnlefxbP8mCx8StjRqVpIPmYkGI8g71eNVxKQWz5qjoCXt/XDwC Qg51P57zAkg6wQvqq6VqnIVj52b2VyAXGaX7v33Omx6VQmZBbLNO46ZbuT5iz94gkGSd Oy6A== X-Gm-Message-State: AOAM5303kaxIASBQ42vhTv+c4eehvaMw1wPDqa6Otnu3Rccz/XqydG2Q vqegqvSSJSG/+SAbKkQTBpq8bg== X-Google-Smtp-Source: ABdhPJxI3Hz+xthd1AooFfZRJiYYpYQ7WvLLajU3VZosa9/ukoyhZuoZL8CZ36qLvtZ38khO9VAoCA== X-Received: by 2002:a1c:4c05:: with SMTP id z5mr3136449wmf.122.1604587935853; Thu, 05 Nov 2020 06:52:15 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/19] gpu: host1x: bus: Add missing description for 'driver' Date: Thu, 5 Nov 2020 14:44:59 +0000 Message-Id: <20201105144517.1826692-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-tegra@vger.kernel.org, Thierry Reding , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/host1x/bus.c:40: warning: Function parameter or member 'driver' not described in 'host1x_subdev_add' Cc: Thierry Reding Cc: dri-devel@lists.freedesktop.org Cc: linux-tegra@vger.kernel.org Signed-off-by: Lee Jones Acked-by: Thierry Reding --- drivers/gpu/host1x/bus.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/host1x/bus.c b/drivers/gpu/host1x/bus.c index e201f62d62c0c..347fb962b6c93 100644 --- a/drivers/gpu/host1x/bus.c +++ b/drivers/gpu/host1x/bus.c @@ -32,6 +32,7 @@ struct host1x_subdev { /** * host1x_subdev_add() - add a new subdevice with an associated device node * @device: host1x device to add the subdevice to + * @driver: host1x driver containing the subdevices * @np: device node */ static int host1x_subdev_add(struct host1x_device *device, From patchwork Thu Nov 5 14:45:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884579 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8010C4741F for ; Thu, 5 Nov 2020 14:52:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3355E20719 for ; Thu, 5 Nov 2020 14:52:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="P5kJIDqA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3355E20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 23D276ED90; Thu, 5 Nov 2020 14:52:21 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6267C6ED90 for ; Thu, 5 Nov 2020 14:52:18 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id h2so1874513wmm.0 for ; Thu, 05 Nov 2020 06:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ni2p/a1qgnbLwmmB/hD7NYV4hNmI7rYb9FSLzDt4vrQ=; b=P5kJIDqACB9jb6uMDWpBlxNm+8vQEgqLkWzRYli9z9drKI0ges+7m1XSxTElgGB3AT E0oeyDVSkgcv4ri+lAhxW9W1Rjd8mQSlGYbxwL6AFS5FAuMyfuFtdGv5mt4QXrMh4xfT zYHCgi3xcD3xAO69tRlyoU+DebIeOUPOcXIMIoBVt0wxrx5LPjYM2Zz8nk+c9XlApErS 4mcJX7FEKH6tTZ+yIbjj7wxpsVd96+HHXxotJ+je7auaSELL8vfBLiBi5PoFeqpLcEsP Isi9cCHdhXswdhNbCfZm4nRVZ/OrcvswD2J1qP0rf3tRDIkmsGHB2ajoqWYR1HwYfYYd ZR+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ni2p/a1qgnbLwmmB/hD7NYV4hNmI7rYb9FSLzDt4vrQ=; b=LUKAw2O19CWADAnx57VAF8ayZn6fKGl839/iiD3Ot2R30Ay9o/93VdueVCcpEqUjBo IlqK+CTIUIp6jAcO7S+l8RjRv2EZa5eEv2hig7rXSzl+q+X2IGLxrg92s+PpjLB9OIRi 4kVCksKDMQCWTsviq0GIcMDCFK4wt7FKI9HoxELLbd5fEGZmdHWUX5FnEBEV5RtETrzH /ZP7Tewpy+HbPIyKTBe91L5REnvT+a/9snqNay2elRbUtVy3QzqOjta0hgzRWQxpJe9Q ylRQY1jwTZXZfzbX2QElOgU9sKZ8hhlAK/X3prdZgazlKk+PhH2QQkdbIUThiofwArcL TRug== X-Gm-Message-State: AOAM530AbhZzCuUoUE9w22zpIyxHBnrZ49bQ3cXmfJ5qjyJahulRERfi ispB/OJtEXhjpwBd9t2m+QiAOg== X-Google-Smtp-Source: ABdhPJwGZM99j8rfQFi86ZhM62w2thIu1iqbxZXuL7hmcT0j5pcCOVuEnqqDxPlt4cOh8LO2oNVTyA== X-Received: by 2002:a1c:81c9:: with SMTP id c192mr3079205wmd.1.1604587937121; Thu, 05 Nov 2020 06:52:17 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/19] gpu: ipu-v3: ipu-di: Strip out 2 unused 'di_sync_config' entries Date: Thu, 5 Nov 2020 14:45:00 +0000 Message-Id: <20201105144517.1826692-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Sascha Hauer , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" They're taking up too much space on the stack. Fixes the following W=1 kernel build warning(s): drivers/gpu/ipu-v3/ipu-di.c: In function ‘ipu_di_sync_config_noninterlaced’: drivers/gpu/ipu-v3/ipu-di.c:391:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Philipp Zabel Cc: Sascha Hauer Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/ipu-v3/ipu-di.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c index b4a31d506fccf..e617f60afeea3 100644 --- a/drivers/gpu/ipu-v3/ipu-di.c +++ b/drivers/gpu/ipu-v3/ipu-di.c @@ -310,10 +310,6 @@ static void ipu_di_sync_config_noninterlaced(struct ipu_di *di, /* unused */ } , { /* unused */ - } , { - /* unused */ - } , { - /* unused */ }, }; /* can't use #7 and #8 for line active and pixel active counters */ From patchwork Thu Nov 5 14:45:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884567 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C988C56201 for ; Thu, 5 Nov 2020 14:52:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C917A20719 for ; Thu, 5 Nov 2020 14:52:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TPoS4HuP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C917A20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 88ACF6ED8D; Thu, 5 Nov 2020 14:52:20 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9FAA36ED90 for ; Thu, 5 Nov 2020 14:52:19 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id p19so1283141wmg.0 for ; Thu, 05 Nov 2020 06:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PcLLONpboZvUTN2aQG6zfp2ux20ADiydIBkQhnQ1U2o=; b=TPoS4HuPdYH3c9MkIFPPhTWS3RWJ96JxCEE54GBANaYyXJMNJ57387nPrvwHRDaSNm nHeUY9/F6E6+1ajLkqOBdOwSz5wlN0DSW7bnb1kM0wXtle/sPy0+QyzhHL2HmYDskP0v 5a4eQrJJ0W/tyvnCITfTXUTSFkYNhAXh+AqVcy9u1VbHeLO0Fq9Bzo0EvGqSkLe1zH+B Hsy14wy/MXLN+cEeGwCc0fsMQzhwOZlaUnyojp+zFzAx1gfvzRv+/sU1YkCrjUbRFHGj nqjP0GLiBveDIZrB3bqZAv6TFLiFeKVtaym1w8d+0ijahi4yfUnW+DsvZlU60sUcORea pq9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PcLLONpboZvUTN2aQG6zfp2ux20ADiydIBkQhnQ1U2o=; b=RSaSsrKMIhMvcNywbP/ebhI0P2GUIaG5drYFZcd/xif6U6rgpOP8e9Vn83If3RxQS3 xdaManTIiyneRJS0WmUMQe6PzrpjXI7ETrVY64J3E993PKbNNTlFLZHA6FcqxFz+FjfG iFIPF7wzI/CPmCV7vGW+U3oi82OAxasVcfdR/fmigeFveAA5m5YhFNe1fK3Hn9irTRoU PuqIQxpBR4JChsxzVxIzZhiUVqE700b9Ah0Mcb1p4JpFY6PMxJ6ir85XCS1EcixbXYZD BUyDs/9LJ7FRr7B0dUjFtiZsSEBviJ/gmmWq2UZKEbdmncNd+MWAyUN6GOukhI7lh1i5 WBDA== X-Gm-Message-State: AOAM53063x8E+hlGbg4a27R1sP8hkX391S8oNQuS4pN8fOBoOyRH7yJI kytuI6cQYfC1o01GCJT7YxjQ1w== X-Google-Smtp-Source: ABdhPJx1nScLQJ8+/5pp9aKW+CIR313HsjM2GzYFhafeQ2i1VZRBFeJhdHevY5Gcwa6RoHinYaOFfg== X-Received: by 2002:a1c:a7ce:: with SMTP id q197mr3190860wme.138.1604587938324; Thu, 05 Nov 2020 06:52:18 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/19] gpu: drm: imx: ipuv3-plane: Mark 'crtc_state' as __always_unused Date: Thu, 5 Nov 2020 14:45:01 +0000 Message-Id: <20201105144517.1826692-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, NXP Linux Team , Shawn Guo , Pengutronix Kernel Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided as a container for state->crtcs[i].new_state, but is not utilised in this use-case. We cannot simply delete the variable, so here we tell the compiler that we're intentionally discarding the read value. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/imx/ipuv3-plane.c: In function ‘ipu_planes_assign_pre’: drivers/gpu/drm/imx/ipuv3-plane.c:746:42: warning: variable ‘crtc_state’ set but not used [-Wunused-but-set-variable] Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/imx/ipuv3-plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 8a4235d9d9f1e..acc0a3ce4992f 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -743,7 +743,7 @@ bool ipu_plane_atomic_update_pending(struct drm_plane *plane) int ipu_planes_assign_pre(struct drm_device *dev, struct drm_atomic_state *state) { - struct drm_crtc_state *old_crtc_state, *crtc_state; + struct drm_crtc_state *old_crtc_state, __always_unused *crtc_state; struct drm_plane_state *plane_state; struct ipu_plane_state *ipu_state; struct ipu_plane *ipu_plane; From patchwork Thu Nov 5 14:45:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884569 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5076EC4742C for ; Thu, 5 Nov 2020 14:52:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D230221D81 for ; Thu, 5 Nov 2020 14:52:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nFSE2PNc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D230221D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D63AF6ED91; Thu, 5 Nov 2020 14:52:21 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id BF0D46ED90 for ; Thu, 5 Nov 2020 14:52:20 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id g12so2080781wrp.10 for ; Thu, 05 Nov 2020 06:52:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zoR5nL3y6WX07329sSplpqvqBToYY/Osic4mjE5dOiE=; b=nFSE2PNcG7cmh0Bdu/Jxv3NzVCljiKeBffdfQAlnWgNNsWEHnr9anRWAJ8RDFLEViF m0Mn8kaHFPW1Qvm0KNQ1w6nKcEMhPhShH8efGb75qFdRJSFfl9QnQFD5zfrdTSPWKw/f AaeRuVcKXygPYcs5XA+BR0qs5zM/t4+cXOozmhE0apmnKGGo8ZcGuiZkTxxrh1o4m47f 2pqNYTJzN6ECwOElr1+JqwmVCMp4ulUNam8H23EbT0bqtmmkz7thIKHWJu2eKGy8swdT E0GAEjE/m6rQwpYiiQr5igWxz5V24Oc3ZNM+cNMx4F3a26x/Q0dW1dAy45FVKb/idBCD iXtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zoR5nL3y6WX07329sSplpqvqBToYY/Osic4mjE5dOiE=; b=jcMYh1xQZuN2dCZLZmPefc0C+Dy2Uo9aDfref9VsmHbVXKgtE/RKnDUTTo23bTNCtI EhUMAHgdord0cbApWjw+DMCHdR7UrWdeEY6H7PxcflCbd00mBQe7of4ir46oosmWtlzu +h5YPNpuJaEG+Tqn/x6uBN3uy8qkNA+meWlks+YbFCa2SvCEALOig1yB/Fg0LZAlmtrM 5r66xeLse+5GMUqF57aWuG3ZgHtNuZfHVDwR22TA6j3QVo8BgqRKY2vrcC3aC4Fh9Dpk hEY/4Z6r1n9WuDQICnWFFny4Yr+ykjEYzpoKEpwkN4G1u657eFQ83V1XlUcZokC+0UOC JA9A== X-Gm-Message-State: AOAM533kqvi0z6IyjYafc4/glAUYCxBUNEi+Slhoax6HJoOVRWtcN+Z6 X2JfU/W3iJk77B8OEs6oHfFpkA== X-Google-Smtp-Source: ABdhPJxsDscnN+g4maf2B8aLyv9Aq1bsygHLBACSxivG8ps1ZUJyW6RrJt3fnaohkUk8LbB3V5sZMQ== X-Received: by 2002:adf:ef83:: with SMTP id d3mr3414398wro.393.1604587939487; Thu, 05 Nov 2020 06:52:19 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/19] gpu: drm: omapdrm: omap_irq: Fix a couple of doc-rot issues Date: Thu, 5 Nov 2020 14:45:02 +0000 Message-Id: <20201105144517.1826692-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Clark , Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The API has been updated, but the header was not. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Function parameter or member 'crtc' not described in 'omap_irq_enable_vblank' drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Excess function parameter 'dev' description in 'omap_irq_enable_vblank' drivers/gpu/drm/omapdrm/omap_irq.c:115: warning: Excess function parameter 'pipe' description in 'omap_irq_enable_vblank' drivers/gpu/drm/omapdrm/omap_irq.c:142: warning: Function parameter or member 'crtc' not described in 'omap_irq_disable_vblank' drivers/gpu/drm/omapdrm/omap_irq.c:142: warning: Excess function parameter 'dev' description in 'omap_irq_disable_vblank' drivers/gpu/drm/omapdrm/omap_irq.c:142: warning: Excess function parameter 'pipe' description in 'omap_irq_disable_vblank' Cc: Tomi Valkeinen Cc: David Airlie Cc: Daniel Vetter Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/omap_irq.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/omap_irq.c b/drivers/gpu/drm/omapdrm/omap_irq.c index 382bcdc72ac06..8643871e23a83 100644 --- a/drivers/gpu/drm/omapdrm/omap_irq.c +++ b/drivers/gpu/drm/omapdrm/omap_irq.c @@ -100,8 +100,7 @@ int omap_irq_enable_framedone(struct drm_crtc *crtc, bool enable) /** * enable_vblank - enable vblank interrupt events - * @dev: DRM device - * @pipe: which irq to enable + * @crtc: DRM CRTC * * Enable vblank interrupts for @crtc. If the device doesn't have * a hardware vblank counter, this routine should be a no-op, since @@ -131,8 +130,7 @@ int omap_irq_enable_vblank(struct drm_crtc *crtc) /** * disable_vblank - disable vblank interrupt events - * @dev: DRM device - * @pipe: which irq to enable + * @crtc: DRM CRTC * * Disable vblank interrupts for @crtc. If the device doesn't have * a hardware vblank counter, this routine should be a no-op, since From patchwork Thu Nov 5 14:45:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884581 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66513C55ABD for ; Thu, 5 Nov 2020 14:52:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F2E2222203 for ; Thu, 5 Nov 2020 14:52:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Fam3S7jh" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F2E2222203 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7F1806ED9A; Thu, 5 Nov 2020 14:52:27 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0B6306ED94 for ; Thu, 5 Nov 2020 14:52:22 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id x12so2084333wrm.8 for ; Thu, 05 Nov 2020 06:52:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wbt6Bt9xb+nEOL+sC88FIyMMDCRwxeU6Sb1wX9bISpg=; b=Fam3S7jhyYU7Z3NVpeOT6nsSRFnhdHgQmCdaWhPs/Yr784DIvf4lSZhyZHm2kJR56B xFeYjjLXHYSZXkqWhyT2ShuGYnKzxLHPnefwdaOp8hMNZV2apCFXYCYmtM2cgs1iwSfU /9VZfe69vuzcpbQb11b7TYnFXBRK9Ha/1DN1lG5nS5Tg/bckPfi2G8c4ImLNv6WThk4y kiAwvcINQwP5e8wsl/NVsQ1wfRvGCXS77nJZpnFrQuQvrJvGByjSikVklVVtzAl/Pa0a jXTSoylLp28E6q1VPfcZ60zbGwaQ4FEK5FQQu2wjmDXStRYgwELevsk7O/w7zazaDndl GIHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wbt6Bt9xb+nEOL+sC88FIyMMDCRwxeU6Sb1wX9bISpg=; b=VHFustvNLt75K1kiHn9eApytCTREUrLcL3WKz/nrag2zQei3Sl6K64Gf1rSJabaGKS cu74dQbhjLLMW92cSYxliP6BVjjS8sWKX5Yvv3/cTppcgu+fInfxJhEaUnihHVPWZcOd gUZtzoyxH7P+Wlqje4BA3P0HewWLCvarv8hKUwwGqLUAMGZY7x27z5GBNg+pxBnqrZbG MLwfsLJIb7CCNZNeAXnpROjFbwTD6USIpDS0Dc2OiM6km0C4xhcn/HR9rjLd0tTsWfJf Y+ztEa/ga9adenanedxcXdCW3R93bE1weeElkxbsZEEMY41IpAyo1L8k0VXIHQf589UP 8iew== X-Gm-Message-State: AOAM531w84x+VutuN4NCE6xEpO89B2LOKhisXwbNtGYq2XFOak7Tfk/R bm4SilLcdt7h2oYObjMZlebkhw== X-Google-Smtp-Source: ABdhPJyUVy8zvMojF9OfX8R20eVTkRIbuvjv/KNiuhzS4OiNxtWZb4zKr0KnzrRzULj0tbNM0uBdEA== X-Received: by 2002:a05:6000:8d:: with SMTP id m13mr3373575wrx.216.1604587940699; Thu, 05 Nov 2020 06:52:20 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:20 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/19] gpu: drm: selftests: test-drm_mm: Mark 'hole_end' as always_unused Date: Thu, 5 Nov 2020 14:45:03 +0000 Message-Id: <20201105144517.1826692-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , Nirmoy Das Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In the macro drm_mm_for_each_hole() 'hole_end' is provided as a container for 'hole_start + pos->hole_size', but is not utilised in this use-case. We cannot simply delete the variable, so here we tell the compiler that we're intentionally discarding the read value. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_mm.c: In function ‘assert_no_holes’: drivers/gpu/drm/selftests/test-drm_mm.c:57:18: warning: variable ‘hole_end’ set but not used [-Wunused-but-set-variable] Cc: David Airlie Cc: Daniel Vetter Cc: "Christian König" Cc: Nirmoy Das Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/selftests/test-drm_mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c b/drivers/gpu/drm/selftests/test-drm_mm.c index 95e212a9a74d2..b768b53c4aee3 100644 --- a/drivers/gpu/drm/selftests/test-drm_mm.c +++ b/drivers/gpu/drm/selftests/test-drm_mm.c @@ -54,7 +54,7 @@ static int igt_sanitycheck(void *ignored) static bool assert_no_holes(const struct drm_mm *mm) { struct drm_mm_node *hole; - u64 hole_start, hole_end; + u64 hole_start, __always_unused hole_end; unsigned long count; count = 0; From patchwork Thu Nov 5 14:45:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884571 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86158C4741F for ; Thu, 5 Nov 2020 14:52:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B2BF221FA for ; Thu, 5 Nov 2020 14:52:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y5NLIQDV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B2BF221FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F52A6ED92; Thu, 5 Nov 2020 14:52:25 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id A134D6ED92 for ; Thu, 5 Nov 2020 14:52:23 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id b8so2103716wrn.0 for ; Thu, 05 Nov 2020 06:52:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B68ULhNIafZ1wW7c1l8pnyj5WZlq4OYRmPHr+DhWUhE=; b=y5NLIQDVRqbJUttUWB4r8/ibcZ5Qata4Q2mrbDJBmadOo2DotGPs54R38SqQQOJtK0 APDTcNF2QLkfRliuF57BWAQCdehDYlb8lsZFwORe8I/gL2fKDdjWxTNYlEnicdU+Tepk 5OAcbqoeisbVAWkR8/09ao1c1KKTBgYRHdOoAZ2QAAqvarPS1tsfilMWK2a+AlJNuzz0 +kUncIw/eC9DDBQ60wMblUKDiSVe6X7R5lWE83cQIIuQuIZRnQdyUh3vH+ugoQ+RH7Yn MLAgK7S/UR++VibC4t2AYpomfaTwMl4ffyF3maXz3zJHEmlNVS5ukN+72YKOTLdKnzri Do6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B68ULhNIafZ1wW7c1l8pnyj5WZlq4OYRmPHr+DhWUhE=; b=QtYc5E7iRSOuJ61kcvRMNbp3M1o6AaLs/XpBvPGJ+js51u/PBrHUAjetC0hf+/nz6y KwndxoaFPNEH5ahyybIaREGtDVbZ4nUQpk8uEv1u6lCKeLhrZFVGUF1MRO1DHqGE1ztZ yLvkbDjrs5SEVb1u+mVLGjN9cBJ0TPxs8fUgihZ5Ng36ma15yzw+bIZV0TZE5sqe8o9N 7s4jKdXvrqgGZ0BmqNFbAGsvWHlGUEqF27aeTNEEKF/3e8xJUNxEQnfIo6IYo5E3Dfa8 bqKLoubh/HL5qEZhBUkJ8SeK2hDXG6bB5t8hGvSiWTZNuAe9v+ta2CLrbpZNm1TIkJoC DxOg== X-Gm-Message-State: AOAM531USMyB/CADuhh4np7D1c9HMXymBnDdnxDSl4rv1IqIVG5O91+G yOQlJxKsl+jojpta6W35kF349w== X-Google-Smtp-Source: ABdhPJygN4kha10hMe+UVXlVwhFEkYq3Wn91ptnkwyJh9gk4hgBLYUpGHf+fN868Iaa7qiNaQGBSZQ== X-Received: by 2002:a5d:43c6:: with SMTP id v6mr3435853wrr.20.1604587942346; Thu, 05 Nov 2020 06:52:22 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/19] gpu: drm: scheduler: sched_main: Provide missing description for 'sched' paramter Date: Thu, 5 Nov 2020 14:45:04 +0000 Message-Id: <20201105144517.1826692-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, =?utf-8?q?Christian_K=C3=B6nig?= , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/scheduler/sched_main.c:74: warning: Function parameter or member 'sched' not described in 'drm_sched_rq_init' Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/scheduler/sched_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index 9a0d77a680180..da24c4e8b9fb3 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -65,6 +65,7 @@ static void drm_sched_process_job(struct dma_fence *f, struct dma_fence_cb *cb); /** * drm_sched_rq_init - initialize a given run queue struct * + * @sched: scheduler instance to associate with this run queue * @rq: scheduler run queue * * Initializes a scheduler runqueue. From patchwork Thu Nov 5 14:45:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884577 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36AF9C55179 for ; Thu, 5 Nov 2020 14:52:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4F18221FA for ; Thu, 5 Nov 2020 14:52:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tS6RccjZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C4F18221FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 72C056ED94; Thu, 5 Nov 2020 14:52:27 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id D20476ED92 for ; Thu, 5 Nov 2020 14:52:24 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id 33so2089546wrl.7 for ; Thu, 05 Nov 2020 06:52:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AjBPdz+8mpzbEfzyqGKPlE/9r69QMe/kgLbI+X7lVik=; b=tS6RccjZm9XFR5PPPsKzjHr+15rT9c+pyaaKa3oTIxSSg9rigM8R5GtZ2ZewHuhAV7 AT0G632//S8OZXZ+wVHiTMC/QIX2O1WgL4uDqgp/PSws2NlL1q3zu7SXfBypJKiLlZeK txrVBNiBYyQqWcP2pUTDkip2KylIpRWprckhw71bLvqYqT0EOAC+LlAM6+2r4g7mSi1u YuaXoVDSY4HdHu+GwAbkn7hGmf6z8pWvKGsXczqFA5afKn9UlCZkPuUqQIdSTycoQbur +xgLPhv63tlBwL2YnXN9XED9/yi4orIo/qxH9gHJrKbkjb++yFurjXlMY6/z4VKiglFQ 1enQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AjBPdz+8mpzbEfzyqGKPlE/9r69QMe/kgLbI+X7lVik=; b=nru3I2SgfzOXj74r9/CNc9ULOnLxfomkX4kiMcfcU/a81O8Lxmyc3jZgsiuhGzGA/f /j/B0F1CJzkhvcwx5rf787Y8N1dV7SSNIg930aZ0Cvip2Es4OtmYsiWlcW15TxXDKR5L 33Uzj+Wu59D86HuOAUTi1I9iY4oz3FPwJ1iB/rtRtfAWnl6QOvPYds9ZBDJMD5pdkHFW CxZobEpESfcBBTNTOm35O2vvSQuz35i9Lj2g0Q/NHnhnSyGoP/l6ecwn6Z8QDx7SOME5 lVkRwbwmPoV1wQ89av8pHqBUIiNqXvmqKCzqhbPPqBtY6MKcg9zDKaUnLXeGjOxIxbQ7 F11w== X-Gm-Message-State: AOAM530tRl6SW0hun+1Z/M7SZzjAdWwsDFQpwTxcwRnpWuEs7yserNmL SO0F0Wazr0bW6kMDbIgii0zqhQ== X-Google-Smtp-Source: ABdhPJyRWm95rr/rrX+vwzMrA+OAGQ0bPe8HoSoQw05klN+IufG2gMUpauu6wrD4P4hiQLXPg7q2Xg== X-Received: by 2002:adf:9150:: with SMTP id j74mr3666874wrj.57.1604587943605; Thu, 05 Nov 2020 06:52:23 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/19] gpu: drm: scheduler: sched_entity: Demote non-conformant kernel-doc headers Date: Thu, 5 Nov 2020 14:45:05 +0000 Message-Id: <20201105144517.1826692-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, Alex Deucher , linux-media@vger.kernel.org, =?utf-8?q?Christian_K=C3=B6nig?= , Nirmoy Das Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/scheduler/sched_entity.c:316: warning: Function parameter or member 'f' not described in 'drm_sched_entity_clear_dep' drivers/gpu/drm/scheduler/sched_entity.c:316: warning: Function parameter or member 'cb' not described in 'drm_sched_entity_clear_dep' drivers/gpu/drm/scheduler/sched_entity.c:330: warning: Function parameter or member 'f' not described in 'drm_sched_entity_wakeup' drivers/gpu/drm/scheduler/sched_entity.c:330: warning: Function parameter or member 'cb' not described in 'drm_sched_entity_wakeup' Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: Alex Deucher Cc: Nirmoy Das Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/scheduler/sched_entity.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_entity.c b/drivers/gpu/drm/scheduler/sched_entity.c index f8ec277a6aa85..c1ac3e4003c6f 100644 --- a/drivers/gpu/drm/scheduler/sched_entity.c +++ b/drivers/gpu/drm/scheduler/sched_entity.c @@ -308,7 +308,7 @@ void drm_sched_entity_destroy(struct drm_sched_entity *entity) } EXPORT_SYMBOL(drm_sched_entity_destroy); -/** +/* * drm_sched_entity_clear_dep - callback to clear the entities dependency */ static void drm_sched_entity_clear_dep(struct dma_fence *f, @@ -321,7 +321,7 @@ static void drm_sched_entity_clear_dep(struct dma_fence *f, dma_fence_put(f); } -/** +/* * drm_sched_entity_clear_dep - callback to clear the entities dependency and * wake up scheduler */ From patchwork Thu Nov 5 14:45:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884573 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12391C4742C for ; Thu, 5 Nov 2020 14:52:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A16B622227 for ; Thu, 5 Nov 2020 14:52:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CUpGQdFe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A16B622227 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2DD756ED99; Thu, 5 Nov 2020 14:52:27 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E4EF6ED99 for ; Thu, 5 Nov 2020 14:52:26 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id d142so1867693wmd.4 for ; Thu, 05 Nov 2020 06:52:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5Xt9NPmWITpKLKGlbBp65KNc5QWwZDBhANixt0RAfzs=; b=CUpGQdFe0Fpy8mF0smnsFvAhA8XeNwRgzON8Ouemw6fHxmx52YrEcZAMwdSABsRq/7 Lxy+ostf7rA/tdZRM7TSq0bo2YvzW5haVIiyQUoFDcaYBJtIcuzThdWaW98Rt/uf8hvR Yessl9lyLwVOyxg+4AEZljm+9pyh+9RuR49gHLGu4bQ+JI1lJesriHB1MV4d2kRG1j3P TIlRa/EgbhDezoFvNOXhtPQsF5zeJmrssB5jRQCoZyr63oGYwhQMu6w5h3uRW6a3fAba HW1hSPLM89nmRzJCEJlwbC+/dBHrd4TqiaEeCIChBj7BD98hF67RBzDmT4LCIdbTjJ7e r4Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5Xt9NPmWITpKLKGlbBp65KNc5QWwZDBhANixt0RAfzs=; b=tFAmx0ls9zvjaijm5f2kvmsmOg0/ynT57uVnc9ayg5yrzy16+2P9LUlqNIfyoyEVXG 8vR5CHA7hWyTiYx8ZUvPlZ2lD8tG7UCrix5qj1nrWr+O2zDLzVPh2ePgUvMzex1OdzVW z2D1cecHCAsOhl8dfL2pTY0ZGkhki0omjRABratb86qgfHqsVIUbVqkVo4I5gfkLAUtR KRoXOxquxCONi5SjdyJFZoR0M3VZqqwZpWkEQ7ycRSYvGDfs4mKhCd+ymNJOfw9ayFJe tPDDGMpRkszFO31GmEUmSa7sn6vBDgfkUUMkCj0N5p1YFNM+fdS6EaW7Ic/RAEDsjefJ J0Wg== X-Gm-Message-State: AOAM532SpsPuZyzkRZVTk5X10dteIRyquIQjCI9t4Wk/xkpuNTDZ3l9y zJKOI5C6OqbxTuw/KYpoeL+/xA== X-Google-Smtp-Source: ABdhPJx4o/ngA4xvA0+rv6p3i9fdDVG+or+aahOHyJb8+xTTqmrY/O+FOfhIhBwkLVbCJU8toTdOCQ== X-Received: by 2002:a1c:2803:: with SMTP id o3mr3018917wmo.97.1604587944829; Thu, 05 Nov 2020 06:52:24 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:24 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/19] gpu: drm: omapdrm: dss: dsi: Rework and remove a few unused variables Date: Thu, 5 Nov 2020 14:45:06 +0000 Message-Id: <20201105144517.1826692-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tomi Valkeinen , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘_dsi_print_reset_status’: drivers/gpu/drm/omapdrm/dss/dsi.c:1131:6: warning: variable ‘l’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/omapdrm/dss/dsi.c: In function ‘dsi_update’: drivers/gpu/drm/omapdrm/dss/dsi.c:3943:10: warning: variable ‘dh’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/omapdrm/dss/dsi.c:3943:6: warning: variable ‘dw’ set but not used [-Wunused-but-set-variable] Cc: Tomi Valkeinen Cc: David Airlie Cc: Daniel Vetter Cc: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Tomi Valkeinen Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/omapdrm/dss/dsi.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c index eeccf40bae416..5929b320b3cfa 100644 --- a/drivers/gpu/drm/omapdrm/dss/dsi.c +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c @@ -1128,13 +1128,12 @@ static void dsi_runtime_put(struct dsi_data *dsi) static void _dsi_print_reset_status(struct dsi_data *dsi) { - u32 l; int b0, b1, b2; /* A dummy read using the SCP interface to any DSIPHY register is * required after DSIPHY reset to complete the reset of the DSI complex * I/O. */ - l = dsi_read_reg(dsi, DSI_DSIPHY_CFG5); + dsi_read_reg(dsi, DSI_DSIPHY_CFG5); if (dsi->data->quirks & DSI_QUIRK_REVERSE_TXCLKESC) { b0 = 28; @@ -3940,7 +3939,6 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel, void (*callback)(int, void *), void *data) { struct dsi_data *dsi = to_dsi_data(dssdev); - u16 dw, dh; dsi_perf_mark_setup(dsi); @@ -3949,11 +3947,8 @@ static int dsi_update(struct omap_dss_device *dssdev, int channel, dsi->framedone_callback = callback; dsi->framedone_data = data; - dw = dsi->vm.hactive; - dh = dsi->vm.vactive; - #ifdef DSI_PERF_MEASURE - dsi->update_bytes = dw * dh * + dsi->update_bytes = dsi->vm.hactive * dsi->vm.vactive * dsi_get_pixel_size(dsi->pix_fmt) / 8; #endif dsi_update_screen_dispc(dsi); From patchwork Thu Nov 5 14:45:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884593 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F8CBC55ABD for ; Thu, 5 Nov 2020 14:52:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC68E21D81 for ; Thu, 5 Nov 2020 14:52:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QpushnzW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BC68E21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C03C6ED9D; Thu, 5 Nov 2020 14:52:31 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26C0C6ED94 for ; Thu, 5 Nov 2020 14:52:27 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id d142so1867761wmd.4 for ; Thu, 05 Nov 2020 06:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CpDMS+RHHV1rRQnMHYAjcZzCg3wY/F0STHOFtNum/rU=; b=QpushnzWopYXqm5YWwBvN6+FQaZHUZjNp1tHAUM5Ag2u5db4kXa+UJ3Z4yl/TOmdD1 7T39shHAWcJiQRYKkCkciEbSRLy+kOmviXG4DtQVSWEgKSXKv6NFk9JKADhbaGGEZJAA gOR7hTYFkaC0n1XYj/O1NWU4cb3MOSx4JPotMGNGBBBgUy9K2NK2k9ZFVySebV+iywE1 ekymQgI26V3+xOhGpSd0IXPly/an+QOpGzOAbVFqI8PeMMkoBWPrSIQ4gtFJRQR3c7NR DL62I58XDWWnnY0xsrxuDBjVmUGHkMYUoJYEyhvi3yBjSU1fQmaNCGo139n4SjKDzreO iqyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CpDMS+RHHV1rRQnMHYAjcZzCg3wY/F0STHOFtNum/rU=; b=dHvcm0iuGBGUEWrA1zmVlXQfJoM9PVoZdewbijQCmet3i2qGmR8q2NRF5w/uAa1Jdz ny0jy1mfgMvcDlJoj1i5o3eSswgO36FtnewszAvEaDITBpujRCxtmDnwQQxY6eUTzBpb UdMqNMarGlF8QOBitryydicn7J8gCo77qr6BjQm5Vg/NVsc6wCDV+dRynLcyoLmKgqo/ QYRL/Db+Re6OdJTcZeAabykn3Pz6Sgop/yKuaBRtrZJsCjqMolaTKWWdNv0WPMDzXgId ZzKtBu12cjlm10gP+Hi+pB7zZXNllNsV0rhecRN97sRRJzBGfojAkvi5LQDFP1KdDk9X NyGg== X-Gm-Message-State: AOAM5318wpfzTe8Y50eCwYPonbttSjuwfpqyj4WtJgsMQsFGXKbj60BJ N1t+FKFEaKDr06yoyGw3oiiUHQ== X-Google-Smtp-Source: ABdhPJyvqYkwE2uGejo6SM8lDSIcZCLWdzpd2TkAJxJyZGijBu5DUEM0XrGnnJJ+a8vBsZQGeJGfjw== X-Received: by 2002:a05:600c:22d3:: with SMTP id 19mr3311106wmg.161.1604587945893; Thu, 05 Nov 2020 06:52:25 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/19] gpu: drm: selftests: test-drm_framebuffer: Remove set but unused variable 'fb' Date: Thu, 5 Nov 2020 14:45:07 +0000 Message-Id: <20201105144517.1826692-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_framebuffer.c: In function ‘execute_drm_mode_fb_cmd2’: drivers/gpu/drm/selftests/test-drm_framebuffer.c:333:26: warning: variable ‘fb’ set but not used [-Wunused-but-set-variable] Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/selftests/test-drm_framebuffer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/selftests/test-drm_framebuffer.c b/drivers/gpu/drm/selftests/test-drm_framebuffer.c index 2d29ea6f92e2a..789f22773dbc9 100644 --- a/drivers/gpu/drm/selftests/test-drm_framebuffer.c +++ b/drivers/gpu/drm/selftests/test-drm_framebuffer.c @@ -330,10 +330,9 @@ static struct drm_device mock_drm_device = { static int execute_drm_mode_fb_cmd2(struct drm_mode_fb_cmd2 *r) { int buffer_created = 0; - struct drm_framebuffer *fb; mock_drm_device.dev_private = &buffer_created; - fb = drm_internal_framebuffer_create(&mock_drm_device, r, NULL); + drm_internal_framebuffer_create(&mock_drm_device, r, NULL); return buffer_created; } From patchwork Thu Nov 5 14:45:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0155C4742C for ; Thu, 5 Nov 2020 14:52:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 582E12224B for ; Thu, 5 Nov 2020 14:52:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dduQNHED" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 582E12224B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C794B6ED9B; Thu, 5 Nov 2020 14:52:30 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB2536ED9B for ; Thu, 5 Nov 2020 14:52:28 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id w1so2104980wrm.4 for ; Thu, 05 Nov 2020 06:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CiwuaHU0ZHFg8OQhxx1cJ0dSvWM+0RzNg9gjhgk/WPA=; b=dduQNHED/EB0aCtpEb6ZPI3Ygd/DXzxcM6AtONVZiYH8oOWysFV+SV32BXj7CRawn8 3qPDx42rbOXx3GO70oulyAVbyR2HuKGl8RXT08Cum9UEJAzaBP1FnUZSSWqRwEliQcMG 7APPDUIFphi1rufMhTfciYQOCmVo//x1tN69RM3fTfdGHw4xQf2o4ZoDpYJ8Ac+9oO7M f4JjmzCn5PLS9anQBkW3NK6Qa5ihhhyARqji7LRN742P39PzfEyRybjH33AIuve1EPSz 12K4QAR9lXYH+qh9QIDJR7F58wDmqFRQ4cfd2yM2AWfB/b2zvVkHWRmiqt3imMKyOaNg USoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CiwuaHU0ZHFg8OQhxx1cJ0dSvWM+0RzNg9gjhgk/WPA=; b=p3WhAtUWVYtwPZUCfxGI0oxMhQHBsluvDw1CYuIMUvldgUIamCNC3cSC6ZO3vLicsT WbnUq1rPxk9nh+0brYFkn7pYlgy3NPduEMeUHLvv0kgSEEWOFF6ZwX1OW/xEQDv+8zq/ 9ybDkersn2ydJu8AHqklZ3CmSXr0qP5DFLtBvE5D8kkTUm8bVWPjHp1BRcaha2gvauQH nPjT3XA32smmgK9C5c7n4n2F76UyRA67qaQba85Hgihg6AwoSxzGtVRhvVk7roxpVsLS 4tLFWJThuZc7L3Ytz5P230cnNMZUn7a0AA5DDRqwaucdxxFEBQje/g61MJTj9Kkt+Lr+ BUhw== X-Gm-Message-State: AOAM530a9JHwrHICHKVzF9Lw5emkEgHFkzPKde9646XAzwkzDRB8xSkm uqLTlDzpnzjsLcDNIDiKPQ7IVg== X-Google-Smtp-Source: ABdhPJx8+Xyxk3R3buvDFYahFOdmnHso41DjA+AdBII2gmx00vBAFsKsMfNfZ8R2RRVHTR/ZSpXreA== X-Received: by 2002:adf:e386:: with SMTP id e6mr3301874wrm.330.1604587947150; Thu, 05 Nov 2020 06:52:27 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/19] gpu: drm: ttm: ttm_bo: Fix one function header - demote lots of kernel-doc abuses Date: Thu, 5 Nov 2020 14:45:08 +0000 Message-Id: <20201105144517.1826692-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian Koenig , linaro-mm-sig@lists.linaro.org, Huang Rui , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_bo.c:51: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' drivers/gpu/drm/ttm/ttm_bo.c:286: warning: Function parameter or member 'bo' not described in 'ttm_bo_cleanup_memtype_use' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'bo' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'interruptible' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'no_wait_gpu' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'unlock_resv' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:424: warning: Function parameter or member 'bdev' not described in 'ttm_bo_delayed_delete' drivers/gpu/drm/ttm/ttm_bo.c:424: warning: Function parameter or member 'remove_all' not described in 'ttm_bo_delayed_delete' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'bo' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'ctx' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'locked' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'busy' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'bo' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'man' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'mem' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'no_wait_gpu' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'bo' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'place' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'mem' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'ctx' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'bo' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'placement' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'mem' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'ctx' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:1387: warning: Function parameter or member 'ctx' not described in 'ttm_bo_swapout' Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/ttm/ttm_bo.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index c63b7ea1cd5d0..2b69c959d7f4d 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -45,7 +45,7 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj); -/** +/* * ttm_global_mutex - protecting the global BO state */ DEFINE_MUTEX(ttm_global_mutex); @@ -274,7 +274,7 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, return ret; } -/** +/* * Call bo::reserved. * Will release GPU memory type usage on destruction. * This is the place to put in driver specific hooks to release @@ -348,9 +348,10 @@ static void ttm_bo_flush_all_fences(struct ttm_buffer_object *bo) * Must be called with lru_lock and reservation held, this function * will drop the lru lock and optionally the reservation lock before returning. * - * @interruptible Any sleeps should occur interruptibly. - * @no_wait_gpu Never wait for gpu. Return -EBUSY instead. - * @unlock_resv Unlock the reservation lock as well. + * @bo: The buffer object to clean-up + * @interruptible: Any sleeps should occur interruptibly. + * @no_wait_gpu: Never wait for gpu. Return -EBUSY instead. + * @unlock_resv: Unlock the reservation lock as well. */ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, @@ -416,7 +417,7 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, return 0; } -/** +/* * Traverse the delayed list, and call ttm_bo_cleanup_refs on all * encountered buffers. */ @@ -620,7 +621,7 @@ bool ttm_bo_eviction_valuable(struct ttm_buffer_object *bo, } EXPORT_SYMBOL(ttm_bo_eviction_valuable); -/** +/* * Check the target bo is allowable to be evicted or swapout, including cases: * * a. if share same reservation object with ctx->resv, have assumption @@ -759,7 +760,7 @@ int ttm_mem_evict_first(struct ttm_bo_device *bdev, return ret; } -/** +/* * Add the last move fence to the BO and reserve a new shared slot. */ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, @@ -795,7 +796,7 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, return 0; } -/** +/* * Repeatedly evict memory from the LRU for @mem_type until we create enough * space, or we've evicted everything and there isn't enough space. */ @@ -857,7 +858,7 @@ static int ttm_bo_mem_placement(struct ttm_buffer_object *bo, return 0; } -/** +/* * Creates space for memory region @mem according to its type. * * This function first searches for free space in compatible memory types in @@ -1379,7 +1380,7 @@ int ttm_bo_wait(struct ttm_buffer_object *bo, } EXPORT_SYMBOL(ttm_bo_wait); -/** +/* * A buffer object shrink method that tries to swap out the first * buffer object on the bo_global::swap_lru list. */ From patchwork Thu Nov 5 14:45:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D80CC55179 for ; Thu, 5 Nov 2020 14:52:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 24C2F20719 for ; Thu, 5 Nov 2020 14:52:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="r7IG/ZJu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 24C2F20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 591D66ED9C; Thu, 5 Nov 2020 14:52:31 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D2186ED9D for ; Thu, 5 Nov 2020 14:52:29 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id 33so2089834wrl.7 for ; Thu, 05 Nov 2020 06:52:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=msUJv3g77jRfXUZFInWbo08oOqamqaMF7n9SOzCcjkY=; b=r7IG/ZJuEPCMH4rRLkfuGlHBB4SlDlKJBOj/G97StXC4XJk2dMx6attzaVaNp5vWCQ LlVdWwEyqS22BVqDUXVugsP5iYpT/Lm/IvVDSZ2s/WC+RtTgnoEgW7RJE5Sw38gcm7b1 B/B8xAIuwPcq6sm8QPMvbH1l5jBPls4ndV/ntH7W1GVpUxzoEkl3JS9gbUSEWuVbRAia Ai6PwdULfSyuWv5lcXDpVwRbj7Y8MJwknqHx0g29KlYuZ80PFKciu3XjdnWh2TIG7ght w0H8Hz3ptmwLg95uJLIp9jEDf7/+ciI3fBsYFv2WHqn+5UiNFGfBSCFr9PowwJshpQhl 79ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=msUJv3g77jRfXUZFInWbo08oOqamqaMF7n9SOzCcjkY=; b=cA+qdo5kUT8lYkku0NK6/CjX99HHb3LKH2tjz24gyQsapbpg1gIuf5R1ePhhs0aKjA y0WzrU2TjuCAivDKNhUhQpuE2dti5lFCqO88aJeIBk37S5uEyYPVRYmpkHJLWAYPdC4l VzP1pCfdQ6Y612B4glvlplKxfQMpTDpL1KlGlbQRMSON37I6WmM35I1/QMGHkMMQbCFM RbEqHtWQ9i/N8G5L942BWoHWeQw1k6XjSPGP+IPKoc8BoSxyhZAkGcnwPBm4ztkwPPsa lQ4r2rkgGGPxqDe1uWahAqd4N7zATQ0xCqR8vmxJ0W+RVPxILA5W4wO48iFFqLKIXKW1 kraA== X-Gm-Message-State: AOAM531qvS2qo9khcqCfonw1ceb8/s/Fn04R0sANtrgHFL3P+M3N3Lwp K+2CT3gtpDjsYMcHa8WnwIhexA== X-Google-Smtp-Source: ABdhPJwOCFph5hs/qG6yS2bZ9ZwIw/eSKDawsUf80Zrt7pTiS+RF1hawBHfFt7P9n2O5VPET+RJlAw== X-Received: by 2002:adf:e682:: with SMTP id r2mr3425322wrm.184.1604587948243; Thu, 05 Nov 2020 06:52:28 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/19] gpu: drm: panel: panel-simple: Fix 'struct panel_desc's header Date: Thu, 5 Nov 2020 14:45:09 +0000 Message-Id: <20201105144517.1826692-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Struct headers should start with 'struct ' Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/panel/panel-simple.c:42: warning: Cannot understand * @modes: Pointer to array of fixed modes appropriate for this panel. If Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Acked-by: Thierry Reding --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 8b82ec33f08ae..1327df0bddbd6 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -39,6 +39,7 @@ #include /** + * struct panel_desc * @modes: Pointer to array of fixed modes appropriate for this panel. If * only one mode then this can just be the address of this the mode. * NOTE: cannot be used with "timings" and also if this is specified @@ -53,6 +54,7 @@ * @delay: Structure containing various delay values for this panel. * @bus_format: See MEDIA_BUS_FMT_... defines. * @bus_flags: See DRM_BUS_FLAG_... defines. + * @connector_type: LVDS, eDP, DSI, DPI, etc. */ struct panel_desc { const struct drm_display_mode *modes; From patchwork Thu Nov 5 14:45:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF60AC4741F for ; Thu, 5 Nov 2020 14:52:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6BFFB2224B for ; Thu, 5 Nov 2020 14:52:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GMWyFQ8D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6BFFB2224B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F126B6ED9E; Thu, 5 Nov 2020 14:52:34 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id F05476ED9C for ; Thu, 5 Nov 2020 14:52:30 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id w1so2105157wrm.4 for ; Thu, 05 Nov 2020 06:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rDbLk2JBRogslz/zoVgvVt10s2+/czAleqnbZF2PqCo=; b=GMWyFQ8DSD9byB9lddD/NyUUDqnEAbCbwAp0QAL61+0zBB45uUHwL8q4EDB8BuAAPn LQ577k4iflbvlAV0dzpguwoJ66yfIQ/YL0JdHZsm228lZVGpFv9vCCtjKk0Uu4QgBGIY n31UkVlb0RTvBCsfV1BL3t72WjAUYYUAasCYzceDyKYsl51RKexB49kUHCpteFFyKmnx /1z7S6EQgCudi7WRWd8ZXIl7NCwoqHJ1LbAT/tABZGCvU2bOmnckTynv0+WMyKHoFMph 4fgVEyqsunNnBgJnRD9zNsJTwPCyrbL614n1ajhMjj52Q4uu5i6z3pq1NWixK4gt9xet KzUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rDbLk2JBRogslz/zoVgvVt10s2+/czAleqnbZF2PqCo=; b=qUeQIXRTswOzs5u+7fSruBsVimy+i1sPmAPwswTXals+DqTHwBGp+tABg6dsn+Un/t Ht5xJRQKqjnd9JWCSdbJHTQ8UivQ+gI7w4UhYMWLQ0idz06U0qryEX+NgCBudutoO/8D wLuOcKNTBevLE/b/EujOVlKgMbTTzS8lWK6BL9PGAqWXp3ileDnwvXpxBOvK6CbrxRzt 0TM/3W4N7BjYDEAZ1181hMG7wDOZ/q8/ff+dj/5EhHROEuRCNCtMiENCj8gSSnJ03dJl j4i6nYIxbc/MQxB6onoc8lNG8m70o1uahB3XvkF2OZ1GJxGlu5K4/GWfkf8/gFuCR4sV IeDg== X-Gm-Message-State: AOAM5310Xlr/GXkZ2Uo/BFyBJhs1h4VuzpDWMmHWNsjUJEduhUA8VwUa JOthMZpAjoS03+CUfITlZKhReQ== X-Google-Smtp-Source: ABdhPJyGT71xib6DJdiI22PqqtneEPs2v/oITwMrzyxOxfCyY+tQfjZPt0a48UrqUZedobkzXWBqrA== X-Received: by 2002:adf:e94b:: with SMTP id m11mr3380925wrn.35.1604587949674; Thu, 05 Nov 2020 06:52:29 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:28 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 12/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_write_byte_to_dpcd' Date: Thu, 5 Nov 2020 14:45:10 +0000 Message-Id: <20201105144517.1826692-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jingoo Han , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Jason Yan , Laurent Pinchart , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:571:5: warning: no previous prototype for ‘analogix_dp_write_byte_to_dpcd’ [-Wmissing-prototypes] Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Jason Yan Cc: Sam Ravnborg Cc: Jingoo Han Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 44 ------------------- 1 file changed, 44 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c index fafb4b492ea04..9ce45c757f8c8 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -568,50 +568,6 @@ static int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) return retval; } -int analogix_dp_write_byte_to_dpcd(struct analogix_dp_device *dp, - unsigned int reg_addr, - unsigned char data) -{ - u32 reg; - int i; - int retval; - - for (i = 0; i < 3; i++) { - /* Clear AUX CH data buffer */ - reg = BUF_CLR; - writel(reg, dp->reg_base + ANALOGIX_DP_BUFFER_DATA_CTL); - - /* Select DPCD device address */ - reg = AUX_ADDR_7_0(reg_addr); - writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_7_0); - reg = AUX_ADDR_15_8(reg_addr); - writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_15_8); - reg = AUX_ADDR_19_16(reg_addr); - writel(reg, dp->reg_base + ANALOGIX_DP_AUX_ADDR_19_16); - - /* Write data buffer */ - reg = (unsigned int)data; - writel(reg, dp->reg_base + ANALOGIX_DP_BUF_DATA_0); - - /* - * Set DisplayPort transaction and write 1 byte - * If bit 3 is 1, DisplayPort transaction. - * If Bit 3 is 0, I2C transaction. - */ - reg = AUX_TX_COMM_DP_TRANSACTION | AUX_TX_COMM_WRITE; - writel(reg, dp->reg_base + ANALOGIX_DP_AUX_CH_CTL_1); - - /* Start AUX transaction */ - retval = analogix_dp_start_aux_transaction(dp); - if (retval == 0) - break; - - dev_dbg(dp->dev, "%s: Aux Transaction fail!\n", __func__); - } - - return retval; -} - void analogix_dp_set_link_bandwidth(struct analogix_dp_device *dp, u32 bwtype) { u32 reg; From patchwork Thu Nov 5 14:45:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3ED20C4742C for ; Thu, 5 Nov 2020 14:52:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C400321D81 for ; Thu, 5 Nov 2020 14:52:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N+9AOKvo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C400321D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3CF886EDA2; Thu, 5 Nov 2020 14:52:40 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 267C76EDA0 for ; Thu, 5 Nov 2020 14:52:32 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id n15so2107892wrq.2 for ; Thu, 05 Nov 2020 06:52:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=F0IbdwxDH4j9csyHE4k5O0hxf8H6de2hTqN1yOLzedY=; b=N+9AOKvoS24VvDcMunCNgXiSgEzn4l1Am+g6ZNVSMuDooX+deYX5oJWAtDt2A/EY7P yu7qk3VrkH4ysHxosDjcQ3bnH0IqqYgA8oDzrmdEZ+6XvcGJB0/FuPE6rBVbsp5AUXgZ EWV+I+CJ+vGh87wbE4wS80cTatwtn1fWimWEj0k0qZoc6SlqOr2p4cw4V2A38vfgdee8 DMLYwv/qszAuBohW0aF12ct7lTy5aVTld1e93cPR1FDuoGp59nKpIasJVfXe21/I/v8D cw8wTIwy9TvvdDfQNJP9ewj/6V3gn3mlSaVcOVW5mkKS2NkaVcjq8IDhIDnGR2klyvRJ hjRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=F0IbdwxDH4j9csyHE4k5O0hxf8H6de2hTqN1yOLzedY=; b=iTROYDyXMCgdOo43pgswb5ir/+oSVmq2kVTVbkBZ7y3TxzEBdW+TGFWe9o6+hUykLP uzR8tJcRcmW72chFRKb2MkAe0vaogmcqYT6VC6caH8QcHQUQ1IyZEdKejOF3gbkCu//4 EQ1einsSUiz771Hd0eTf32K1YQTWK9X3bqr94F3wdM+f+tER8CNRjzTfHtkuiXgxhuVL uhcGZjRmRHVgPXZrKg1x/mHuIQN1eEELcQsJ9qJNk9SrImdexoCrvfXcq29Vkxq/65W+ jqvo5w5PwPlhLuDR3RBXDle23snV3SPctrF9CidgtkcGDehmjtmC3tnpvHVODC5AOxo0 1gQA== X-Gm-Message-State: AOAM5331mFbt9rvGSJ/s1R6eJRLlQLyEEiMGmjFFZaqEcWjlKd1F//vJ yRdEh2llYIFr+qqQAIsGGi5WZw== X-Google-Smtp-Source: ABdhPJwAkqDrGU58mpfo9/oDp9kDfWjs3etPOM56QRr6g6b6lprxLixxEpoU8gNb6/mzmV66ghlueA== X-Received: by 2002:adf:c14c:: with SMTP id w12mr3641178wre.40.1604587950781; Thu, 05 Nov 2020 06:52:30 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 13/19] gpu: drm: ttm: ttm_tt: Demote kernel-doc header format abuses Date: Thu, 5 Nov 2020 14:45:11 +0000 Message-Id: <20201105144517.1826692-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Huang Rui , Christian Koenig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'bo' not described in 'ttm_tt_create' drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'zero_alloc' not described in 'ttm_tt_create' drivers/gpu/drm/ttm/ttm_tt.c:83: warning: Function parameter or member 'ttm' not described in 'ttm_tt_alloc_page_directory' Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/ttm/ttm_tt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index 8861a74ac3351..3190bafd8b783 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm/ttm_tt.c @@ -38,7 +38,7 @@ #include #include -/** +/* * Allocates a ttm structure for the given BO. */ int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc) @@ -76,7 +76,7 @@ int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc) return 0; } -/** +/* * Allocates storage for pointers to the pages that back the ttm. */ static int ttm_tt_alloc_page_directory(struct ttm_tt *ttm) From patchwork Thu Nov 5 14:45:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884595 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6C77C5517A for ; Thu, 5 Nov 2020 14:52:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CBF521D81 for ; Thu, 5 Nov 2020 14:52:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VlPjzCJT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CBF521D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 707736EDA0; Thu, 5 Nov 2020 14:52:37 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5188C6EDA0 for ; Thu, 5 Nov 2020 14:52:33 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id x7so2105568wrl.3 for ; Thu, 05 Nov 2020 06:52:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DSkh58f2krzhp2hE3KFf5ZyOONS9hWGvZQYe4kveepQ=; b=VlPjzCJT3y6e/FnCd2xLEPBd0z7vGt4Qg/m+b0RlACokUoWDnR7rwn/cE/eawSN26W Wz2Vmh8dmVk3cTlLPul5wt3AlHqwThJYpazo4c8CHYlLlbi+um3zq0XC/BntQDQDlSug qP9xHZoWAqIhvGMCzQyBkgpS2fxEnGPkSCmwP4o0tV70AV7CwMxNJ4dHIVzUHDawwKnM N5OzXuMeIbtujOq7o6yjhUQubbYvD45CJls1gsJCnHgAiyv1oWrRGm42I+1RxN6LOq70 jYUJep8G9BsTpyns4E0uVhkbNw80eZTOMgIaaedtq1GBcTjO4/U4C4y6dYJ9oZ70BJk7 ocIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DSkh58f2krzhp2hE3KFf5ZyOONS9hWGvZQYe4kveepQ=; b=Bq5CTVT9tS1WoGLwAe6z81Tg425CWKhGbj4dMsKRUWndEoUFZCPgCdCsNFT9clz7QO w7AWHnen7H2QPijbLnfXzZAorYmQUt0PA9Jif37oKvFSRM82XLCLKzwLa6upyoGH6KDn LsPSauS85WFof9zoNiMVw0Wnl5QOXG5xg5aVIY0JeJ7L5WgEbXRQJTNOpmmnIJJiBG2D MWxOYL/TcMfQPYK8kK53qP0JjTAE+FisupstMvKIepiN964zAdkvqWj9OEX2IOJcJZUj tYvIA2X0tv/p4K/8yWWYS5jdpnHuZ0l1EG+52mQ/U35plrb8agJsRn0ayTtvRaHQEA7O IasA== X-Gm-Message-State: AOAM532LQsks9iHFgP/9QRYWM26csvy58zihsSJezVDKJOBzNjUK8SGL oMxRaqfpBaAwtl7cXm69eaCYxg== X-Google-Smtp-Source: ABdhPJyLybY/q1JINhhp6tsqqnQa/WrE4fpJ0FtSt5uywWd1JtbavxdvLo7R9GEFsr/3kV4i58KbAw== X-Received: by 2002:adf:a2c2:: with SMTP id t2mr3530595wra.54.1604587951999; Thu, 05 Nov 2020 06:52:31 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:31 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/19] gpu: drm: selftests: test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Date: Thu, 5 Nov 2020 14:45:12 +0000 Message-Id: <20201105144517.1826692-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , David Francis , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The stack is too full. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: David Airlie Cc: Daniel Vetter Cc: Lyude Paul Cc: David Francis Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../drm/selftests/test-drm_dp_mst_helper.c | 29 ++++++++++++------- 1 file changed, 18 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c index 1d696ec001cff..0a539456f6864 100644 --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c @@ -120,44 +120,51 @@ sideband_msg_req_equal(const struct drm_dp_sideband_msg_req_body *in, static bool sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) { - struct drm_dp_sideband_msg_req_body out = {0}; + struct drm_dp_sideband_msg_req_body *out; struct drm_printer p = drm_err_printer(PREFIX_STR); struct drm_dp_sideband_msg_tx txmsg; int i, ret; + bool result = true; + + out = kzalloc(sizeof(*out), GFP_KERNEL); drm_dp_encode_sideband_req(in, &txmsg); - ret = drm_dp_decode_sideband_req(&txmsg, &out); + ret = drm_dp_decode_sideband_req(&txmsg, out); if (ret < 0) { drm_printf(&p, "Failed to decode sideband request: %d\n", ret); - return false; + result = false; + goto out; } - if (!sideband_msg_req_equal(in, &out)) { + if (!sideband_msg_req_equal(in, out)) { drm_printf(&p, "Encode/decode failed, expected:\n"); drm_dp_dump_sideband_msg_req_body(in, 1, &p); drm_printf(&p, "Got:\n"); - drm_dp_dump_sideband_msg_req_body(&out, 1, &p); - return false; + drm_dp_dump_sideband_msg_req_body(out, 1, &p); + result = false; + goto out; } switch (in->req_type) { case DP_REMOTE_DPCD_WRITE: - kfree(out.u.dpcd_write.bytes); + kfree(out->u.dpcd_write.bytes); break; case DP_REMOTE_I2C_READ: - for (i = 0; i < out.u.i2c_read.num_transactions; i++) - kfree(out.u.i2c_read.transactions[i].bytes); + for (i = 0; i < out->u.i2c_read.num_transactions; i++) + kfree(out->u.i2c_read.transactions[i].bytes); break; case DP_REMOTE_I2C_WRITE: - kfree(out.u.i2c_write.bytes); + kfree(out->u.i2c_write.bytes); break; } /* Clear everything but the req_type for the input */ memset(&in->u, 0, sizeof(in->u)); - return true; +out: + kfree(out); + return result; } int igt_dp_mst_sideband_msg_req_decode(void *unused) From patchwork Thu Nov 5 14:45:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD03EC5517A for ; Thu, 5 Nov 2020 14:52:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 448442222B for ; Thu, 5 Nov 2020 14:52:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XSREkBYK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 448442222B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E11C76EDA3; Thu, 5 Nov 2020 14:52:39 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BE276ED9E for ; Thu, 5 Nov 2020 14:52:34 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id a3so1936492wrx.13 for ; Thu, 05 Nov 2020 06:52:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rv3e4lR5n3wbFt5a45993iZf/YGmwbWZWnMbXebEIvs=; b=XSREkBYK380J4CWNoXmcHRvUSexcxURarBudmCsFRVoIQ5vYDbDJky11tMykMICSa5 4t9WSt6mx44I9x9YihMhfrnjm70iija84cbYr3L4NqZKBysrWKTcAV2f60BmrUPyFPBc uy2UBtjWg1mmBR2rV9UNTmvSNlis678WRkrwrShYsej7hOIa9wV1hL4KdbtQJtzxDpWt pdjB5XWNlS0fZTNFXn5zMylPY7TooJTMlFDSFAhcBEEuM3+ByEeXJGnioaHz511LVgxV vP5bJbK0TsnoToAaMHJdezPZ7VCMgyK37zQ060GU0rjX/IC+TOsbCJNFnwcMXfS16kho 26yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rv3e4lR5n3wbFt5a45993iZf/YGmwbWZWnMbXebEIvs=; b=ZBGscWX7u3zYfIpgVIVeV+FuVknCRtxLFVRxoA6lg4fx0r/3SdPZKoQbU8pCLUX+Tl Z04c2a53pBmPWq0NgpEdkRnuG4HHtepDK1R4DiHfn59KSRCfqiHjhCYgz7Bpn1oVH7QR kJDl0zjVFV6Idwowksq08aqGdvDq7KVkPZH3RojbmwnbNkJC1b1MM1gqFJV9Yx+hYkWY uLjGzTNwkmwD9oYtj1nugH45AhwDn4qjYBW85sRRw/pxwIG3AvwymVIEcfULB9+W3fTr Y1mORpBAoGNFT0nZRDkdMxQG15vjwDjg5h4GDYQuaOoAr3iVL400yDr32pIliuvrKcPP y0BA== X-Gm-Message-State: AOAM531L5xOmhuGvrMRYKGVI6U/Ty8OzQ22UDmNwWx6yN+GdjdFErYZQ mv1SmGrDmwZ7A/dYdorLr1nBLQ== X-Google-Smtp-Source: ABdhPJyRZrB38ZvyOkJUZt6MoLWccltE1b+bbQaqzlHiYSRu4qcXO2ij1vEYl45QgtpeTpFIvxmy+Q== X-Received: by 2002:adf:fac6:: with SMTP id a6mr3321445wrs.373.1604587953215; Thu, 05 Nov 2020 06:52:33 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 15/19] gpu: drm: radeon: radeon_drv: Remove unused variable 'ret' Date: Thu, 5 Nov 2020 14:45:13 +0000 Message-Id: <20201105144517.1826692-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Gareth Hughes , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_drv.c: In function ‘radeon_pmops_runtime_suspend’: drivers/gpu/drm/radeon/radeon_drv.c:455:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Gareth Hughes Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm/radeon/radeon_drv.c index 65061c949aeea..f5f1cb700d873 100644 --- a/drivers/gpu/drm/radeon/radeon_drv.c +++ b/drivers/gpu/drm/radeon/radeon_drv.c @@ -452,7 +452,6 @@ static int radeon_pmops_runtime_suspend(struct device *dev) { struct pci_dev *pdev = to_pci_dev(dev); struct drm_device *drm_dev = pci_get_drvdata(pdev); - int ret; if (!radeon_is_px(drm_dev)) { pm_runtime_forbid(dev); @@ -462,7 +461,7 @@ static int radeon_pmops_runtime_suspend(struct device *dev) drm_dev->switch_power_state = DRM_SWITCH_POWER_CHANGING; drm_kms_helper_poll_disable(drm_dev); - ret = radeon_suspend_kms(drm_dev, false, false, false); + radeon_suspend_kms(drm_dev, false, false, false); pci_save_state(pdev); pci_disable_device(pdev); pci_ignore_hotplug(pdev); From patchwork Thu Nov 5 14:45:14 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7823C4742C for ; Thu, 5 Nov 2020 14:52:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5345B21D81 for ; Thu, 5 Nov 2020 14:52:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="swOlcuLU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5345B21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9475C6EDA1; Thu, 5 Nov 2020 14:52:37 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D01F6EDA0 for ; Thu, 5 Nov 2020 14:52:35 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id h2so1875429wmm.0 for ; Thu, 05 Nov 2020 06:52:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Lzr2LZKkjeyh+0gXSjtszqjFcxymZo2/y4TJCmeBIoM=; b=swOlcuLUwLVsy5H0kZyJDIny5wOGPi4N36T5qjg/xyiN0ZRy/TR+lqUsJM/dksU6HV LRpj6JmHpaFZLKcgMPDDw95n0IWR1MQOO2UN4udOERsKfNg+qKMRbef8h/Pk7Rynqb7V ldZWi/RBJgzaXFam5OkPaWd/9Pwh0fjVkAQUZXoJcfL+6QR7ox+/FUSwFYJFBdzfrkjj d/tw9iWv6GAE0cL9vwkWbzs2WnsflB5dzqlm0JCj4kUOPF2Fww1gU8Deb9SxCMD/EAuZ n92AkxxE100PUWDbNbdgYLDNmHqxg7zOBJoYqfDD+QWhk5y+EVgYOUJorOQBpC2tRFUz sRaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Lzr2LZKkjeyh+0gXSjtszqjFcxymZo2/y4TJCmeBIoM=; b=AMIB+lg/EDRrpbh0eeacu+m8KxaUhls+jNWx1la7uwKQWEQa+mHsRiGGun+uh1brMX oGS5fCaXhhx5Fh4U1+M3v1ViUsSC8663PlPklQS+uePTEMe02HtSRinorsRHqKkmi5nD MmHNv3y2e9zwKSi7vzPi46phvbJL1Rd7rdTLZw5BqIPtiXI1qO5cxOY9T8JSeaZxgDrh qP5isBx+0AWWSLpGedjZy+il2+SvosvWHDjkj5X28ISGKR80d0PHK0M9xre0Y82eLmm2 eKkeab4Br7Ia/FNlmW4th81t1xNSzgeQlpu4R1e5YLL8CmCwX0wrstjOR8Gil6J+qv3Z W5Lg== X-Gm-Message-State: AOAM5336PIHMVZIDsNVgjA6vjezTcZ6A8E4uIjGd7F6g8WT0x+s2w0CB XwHsqTWuWQsSlYr6Lhlppuye8w== X-Google-Smtp-Source: ABdhPJwEQdQy1KXngQ0iziaR9HkA2R0NAcKEAYFhCBRARBNNh5ssNJoyNlHhkkm7K6yluAbMvU79zQ== X-Received: by 2002:a1c:5f45:: with SMTP id t66mr3197691wmb.20.1604587954367; Thu, 05 Nov 2020 06:52:34 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:33 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 16/19] gpu: drm: panel: panel-ilitek-ili9322: Demote non-conformant kernel-doc header Date: Thu, 5 Nov 2020 14:45:14 +0000 Message-Id: <20201105144517.1826692-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding , Sam Ravnborg Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_SRGB_THROUGH' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_SRGB_ALIGNED' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_SRGB_DUMMY_320X240' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_SRGB_DUMMY_360X240' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_DISABLED_1' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_PRGB_THROUGH' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_PRGB_ALIGNED' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_YUV_640X320_YCBCR' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_YUV_720X360_YCBCR' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_DISABLED_2' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_ITU_R_BT656_720X360_YCBCR' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_ITU_R_BT656_640X320_YCBCR' not described in enum 'ili9322_input' drivers/gpu/drm/panel/panel-ilitek-ili9322.c:177: warning: Enum value 'ILI9322_INPUT_UNKNOWN' not described in enum 'ili9322_input' Cc: Thierry Reding Cc: Sam Ravnborg Cc: David Airlie Cc: Daniel Vetter Cc: Linus Walleij Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Acked-by: Thierry Reding --- drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c index 074e18559b9f6..8e84df9a0033d 100644 --- a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c @@ -152,7 +152,7 @@ #define ILI9322_GAMMA_7 0x16 #define ILI9322_GAMMA_8 0x17 -/** +/* * enum ili9322_input - the format of the incoming signal to the panel * * The panel can be connected to various input streams and four of them can From patchwork Thu Nov 5 14:45:15 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884603 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC857C56201 for ; Thu, 5 Nov 2020 14:52:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7138922228 for ; Thu, 5 Nov 2020 14:52:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KBwJ7sSz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7138922228 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DCE716EDA9; Thu, 5 Nov 2020 14:52:41 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id E667E6EDA0 for ; Thu, 5 Nov 2020 14:52:36 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id g12so2081728wrp.10 for ; Thu, 05 Nov 2020 06:52:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IlbFjA1pCKxkPmsP5EtFe6iKvE9D/xy8RlK3r75nIgE=; b=KBwJ7sSzoNNlJeM2LSJvEoNx0u2IjzwVfbxJtvfnkAyQneAXifgDuipGbxyIPmXaZc IUQ0H64STjSyAboATFDUOeOxFj6TCu5DASRAQ4SdaGzYak9HoVRmtzxjvDqzj+MZH0Bk t8RKh93xOdbfXIhI1vpPW60dy5WYFwmtX4VTRqj6MCUtk3A+65lrPPRg+8i/bwjhotQM nyn5BKBKMuXnrL0WNM5fhvAEsRhXCL0GyeTriYJFQgcUcmscWLQAavQIIUOUwxk06tp1 hZw6MU7gG88Rf8Zm3+TWjMjYr42iNeNjeSJxmD0ZHV+jNEaG4k4r5e1Qt6BZEe+fmsHz 0r7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IlbFjA1pCKxkPmsP5EtFe6iKvE9D/xy8RlK3r75nIgE=; b=NwSW03QnAPhG0UQ/upc7iIMeOcpsJCSVPhvphSUh53PDwjSGzttLMdkbDZ2jqpiYI9 t7QZyBFwRWRrRJAG0VtgNw0q/y01XNMh5vDdj3Noebb0nKGnbZBGgbohutOX8Vfv8VGh FrmZd9GX7BLoDuE50dmsqQcj5Jc/4AoHHvOZ5V3tVMrJyyHNkpCl11rPn5Km1hcKXZp0 SVm/UIv+OV3IZKRTj2OwmWICn9aUjS1F9l0pXlcQrJwTYavI721TbLLBFFwNapr+ospz Uh+eReccaRPjpDyHSYyYvU9z7qd2R32WF0Puf0hPIVahNItjddTINZdQQtujIadGUDeU pL+Q== X-Gm-Message-State: AOAM533/hKC1EzNA2mm45jRz9huPBlceS7/9vsqbqhIcbcrDQYXWCmmI lou+MlpA1LvFNJWtLCuPon97xP0WiKgPKcLC X-Google-Smtp-Source: ABdhPJzG5CGbpR/TwJSrNO2WIuVUgfK/JaOAwXwNTRUH+y0L82UrvdrxUj9hc+98hlc1aSXdNIfIyg== X-Received: by 2002:adf:e443:: with SMTP id t3mr3470794wrm.14.1604587955662; Thu, 05 Nov 2020 06:52:35 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:34 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/19] gpu: drm: radeon: radeon_device: Fix a bunch of kernel-doc misdemeanours Date: Thu, 5 Nov 2020 14:45:15 +0000 Message-Id: <20201105144517.1826692-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" - Demote non-conformant headers - Fix misnaming issues - Rename labels with identical names - Remove incorrect descriptions Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no previous prototype for ‘radeon_device_is_virtual’ [-Wmissing-prototypes] drivers/gpu/drm/radeon/radeon_device.c:552: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:556: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:561: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:564: warning: duplicate section name 'Note' drivers/gpu/drm/radeon/radeon_device.c:1106: warning: Function parameter or member 'family' not described in 'radeon_gart_size_auto' drivers/gpu/drm/radeon/radeon_device.c:1291: warning: Function parameter or member 'ddev' not described in 'radeon_device_init' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'dev' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'suspend' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'fbcon' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Function parameter or member 'freeze' not described in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Excess function parameter 'pdev' description in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1565: warning: Excess function parameter 'state' description in 'radeon_suspend_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or member 'dev' not described in 'radeon_resume_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or member 'resume' not described in 'radeon_resume_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Function parameter or member 'fbcon' not described in 'radeon_resume_kms' drivers/gpu/drm/radeon/radeon_device.c:1669: warning: Excess function parameter 'pdev' description in 'radeon_resume_kms' Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_device.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c index 266e3cbbd09bd..7f384ffe848a7 100644 --- a/drivers/gpu/drm/radeon/radeon_device.c +++ b/drivers/gpu/drm/radeon/radeon_device.c @@ -544,21 +544,21 @@ int radeon_wb_init(struct radeon_device *rdev) * Note: GTT start, end, size should be initialized before calling this * function on AGP platform. * - * Note: We don't explicitly enforce VRAM start to be aligned on VRAM size, + * Note 1: We don't explicitly enforce VRAM start to be aligned on VRAM size, * this shouldn't be a problem as we are using the PCI aperture as a reference. * Otherwise this would be needed for rv280, all r3xx, and all r4xx, but * not IGP. * - * Note: we use mc_vram_size as on some board we need to program the mc to + * Note 2: we use mc_vram_size as on some board we need to program the mc to * cover the whole aperture even if VRAM size is inferior to aperture size * Novell bug 204882 + along with lots of ubuntu ones * - * Note: when limiting vram it's safe to overwritte real_vram_size because + * Note 3: when limiting vram it's safe to overwritte real_vram_size because * we are not in case where real_vram_size is inferior to mc_vram_size (ie * note afected by bogus hw of Novell bug 204882 + along with lots of ubuntu * ones) * - * Note: IGP TOM addr should be the same as the aperture addr, we don't + * Note 4: IGP TOM addr should be the same as the aperture addr, we don't * explicitly check for that thought. * * FIXME: when reducing VRAM size align new size on power of 2. @@ -627,7 +627,7 @@ void radeon_gtt_location(struct radeon_device *rdev, struct radeon_mc *mc) * GPU helpers function. */ -/** +/* * radeon_device_is_virtual - check if we are running is a virtual environment * * Check if the asic has been passed through to a VM (all asics). @@ -1100,7 +1100,7 @@ static bool radeon_check_pot_argument(int arg) /** * Determine a sensible default GART size according to ASIC family. * - * @family ASIC family name + * @family: ASIC family name */ static int radeon_gart_size_auto(enum radeon_family family) { @@ -1276,7 +1276,7 @@ static const struct vga_switcheroo_client_ops radeon_switcheroo_ops = { * radeon_device_init - initialize the driver * * @rdev: radeon_device pointer - * @pdev: drm dev pointer + * @ddev: drm dev pointer * @pdev: pci dev pointer * @flags: driver flags * @@ -1550,12 +1550,9 @@ void radeon_device_fini(struct radeon_device *rdev) /* * Suspend & resume. */ -/** +/* * radeon_suspend_kms - initiate device suspend * - * @pdev: drm dev pointer - * @state: suspend state - * * Puts the hw in the suspend state (all asics). * Returns 0 for success or an error on failure. * Called at driver suspend. @@ -1656,11 +1653,9 @@ int radeon_suspend_kms(struct drm_device *dev, bool suspend, return 0; } -/** +/* * radeon_resume_kms - initiate device resume * - * @pdev: drm dev pointer - * * Bring the hw back to operating state (all asics). * Returns 0 for success or an error on failure. * Called at driver resume. From patchwork Thu Nov 5 14:45:16 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E766C56202 for ; Thu, 5 Nov 2020 14:52:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 080DF2222B for ; Thu, 5 Nov 2020 14:52:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wfiAsdlt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 080DF2222B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 978726EDA4; Thu, 5 Nov 2020 14:52:42 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A5DD6EDA6 for ; Thu, 5 Nov 2020 14:52:38 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id n15so2108273wrq.2 for ; Thu, 05 Nov 2020 06:52:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=aFGC0ytSE2C9dt0H5Lm6tpZnXpH56uqHjPZdDctt26w=; b=wfiAsdlt6epXo2Z0lyQ2vFG5VIANzrYi7k+Kj7DSPrq0Wlu7lE/C7PyBaDtKnFt5W3 ss6q9w+fsheDQAj9Qg22QH+HM8yU1kpflALNQwljtfRtDwIlCCGravQG8EHFfj/kpG1Y FEzypD0aYD9XfDVxFcUTqvOQu5NR5igeobiejNnTe3Idb/HE8ochjkpI+47Yygo0GaRN 7aeAWTVLBX8UdQbRzfNLEcs84NSw+tI8FIqPamYKU2xJ2J2QG9/PsJHOthgrZI8DXhnq eYE1IUn/Dky5zKBZjcjsHDXk7MpSiXTc/WeaJzAxEQ2MrL3ItGYCnlcRVglXawLV2AxM 0ibw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=aFGC0ytSE2C9dt0H5Lm6tpZnXpH56uqHjPZdDctt26w=; b=GigR/JaxBHBon24QF8DrhjL/Vd2wJG79YnTEm0USw4+g7Nkr9z89sID0adva1DZEVy z0+lS6B19jUKslROI2MMgZZlcZjcUtpRMeW+GCrwmsZuhaNpvL9HHmo2MO95ee9M8flv t9LY6wjYMZ49zocIWOp3oz+xgBfowz/ULsnHHJjPHh9AttG1INQuyZdqGOaHjpoejNOa yUod2/NHLFBCDURzxf4RGrkArrVXnWV74qONW4gU772HCVikyzFhfi0WjpRwY+x11n+D tF8YTtg3MTJnbhigPYZB7Ew14b7F0LAKluVmL4sYrm/sJ0et2Tco4fukRGXeii1aEDr1 Weag== X-Gm-Message-State: AOAM531m2yNF0veWKp9ZFYHcFH2dueYWb/7ZgmHyHh4mwHS2G6PWVva2 7OFqEeB2BjbUQtcSLLDXhrOwmQ== X-Google-Smtp-Source: ABdhPJzXmfpypPEGh1sjthrWtYAHtbC+T4FEWZkqUKOyrF6tmldqGj0XtFoQ6I7iSmVwj8o3PG+jxg== X-Received: by 2002:adf:9150:: with SMTP id j74mr3668000wrj.57.1604587956920; Thu, 05 Nov 2020 06:52:36 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 18/19] gpu: drm: amd: amdgpu: amdgpu: Mark global variables as __maybe_unused Date: Thu, 5 Nov 2020 14:45:16 +0000 Message-Id: <20201105144517.1826692-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, dri-devel@lists.freedesktop.org, Alex Deucher , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" These 3 variables are used in *some* sourcefiles which include amdgpu.h, but not *all*. This leads to a flurry of build warnings. Fixes the following W=1 kernel build warning(s): from drivers/gpu/drm/amd/amdgpu/amdgpu.h:67, drivers/gpu/drm/amd/amdgpu/amdgpu.h:198:19: warning: ‘no_system_mem_limit’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/amdgpu.h:197:19: warning: ‘debug_evictions’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/amd/amdgpu/amdgpu.h:196:18: warning: ‘sched_policy’ defined but not used [-Wunused-const-variable=] NB: Repeats ~650 times - snipped for brevity. Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h index 183b09d71b64a..5939753080056 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h @@ -193,9 +193,9 @@ extern int sched_policy; extern bool debug_evictions; extern bool no_system_mem_limit; #else -static const int sched_policy = KFD_SCHED_POLICY_HWS; -static const bool debug_evictions; /* = false */ -static const bool no_system_mem_limit; +static const int __maybe_unused sched_policy = KFD_SCHED_POLICY_HWS; +static const bool __maybe_unused debug_evictions; /* = false */ +static const bool __maybe_unused no_system_mem_limit; #endif extern int amdgpu_tmz; From patchwork Thu Nov 5 14:45:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11884601 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 521A5C55ABD for ; Thu, 5 Nov 2020 14:52:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBA5F21D81 for ; Thu, 5 Nov 2020 14:52:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XBW8xFz2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBA5F21D81 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EE0656EDA7; Thu, 5 Nov 2020 14:52:40 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 98E9B6EDA2 for ; Thu, 5 Nov 2020 14:52:39 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id g12so2081865wrp.10 for ; Thu, 05 Nov 2020 06:52:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/ohyBbiMl4QAk0hhVQhX7OOzIoCPrYd9chXW0LdTWwg=; b=XBW8xFz25wrZDDaO9F9vfOL8x0OhOhpJq3zGD2BEffVr94ia5p8vCiGc1dDvydPk8G NDrGwM8qHJIWF+YyN3+pqM04QpTovwtHRwYaY+CB0lm71Gm7e96ItZi/WAkO9B1ijRbJ D3zSToxMNbprGNAI1QfIFaElECUMP9+zGdyTDLypSReTAwazDqv05F15HG1XUa+Dn15J cMuSKGY3lupgIXoi2hTrHUZpaqPt6dZAhP+Pq/Rx2olZZEtgk11RkFZCZLK2f05T1Vk0 8wHSBFUOFm63LhPsJnl9L2OhDl4kuTp5kTmGF7uaGIC/XEBoHlD+C41OVq0tg4j7E+K+ CcbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/ohyBbiMl4QAk0hhVQhX7OOzIoCPrYd9chXW0LdTWwg=; b=IIMribwV51xFXpnCXv5aBFqIFS1AIGj6x0oScNwQm3DoXqsmgoARLsxxmW22y+1PM+ 24LrmYFN27d66eXdMiryolnRLkZj3Xzlxcl1DdN7ZxjJXIpLzxG+Ks0DwzAFLIdigiLi O14CseKfoTIUxFlZ9Yxl88fN3adb2B8Bbs19z2/hqikwrc3Mgfj+LQuLDGKpPjJ2mz2T q1xbfNMXvwIIb91vCYpdGnygXVjX5XN2sOoHYmCXHNRSeFYLKFINBmaYzZcyOrRn8Mcs HQ0LfjxhknIxkbuBVzbfzDC4yQevOl2mC2a4yWzhlO2Nlhk2DUzT+ADjPRBIul8BoW1Q auUg== X-Gm-Message-State: AOAM531Cm046PQi/NvQ0lmLGLh6BKOXSrg1/fMzvPbsRFj/WMeFjTQVP NYB17olCY+UXHWwOLJYkyfP0rQ== X-Google-Smtp-Source: ABdhPJy1zJUpgVBLvXfGwyfP/DxiTdsE/xHFzIPHRB2Y83e58sQ2ACFhophmTpm4Om/fUXHn2r43dQ== X-Received: by 2002:adf:fe46:: with SMTP id m6mr3113804wrs.254.1604587958250; Thu, 05 Nov 2020 06:52:38 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id f5sm2631243wmh.16.2020.11.05.06.52.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Nov 2020 06:52:37 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 19/19] gpu: drm: bridge: analogix: analogix_dp_reg: Remove unused function 'analogix_dp_start_aux_transaction' Date: Thu, 5 Nov 2020 14:45:17 +0000 Message-Id: <20201105144517.1826692-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201105144517.1826692-1-lee.jones@linaro.org> References: <20201105144517.1826692-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jernej Skrabec , Jingoo Han , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrzej Hajda , Jason Yan , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c:527:12: warning: ‘analogix_dp_start_aux_transaction’ defined but not used [-Wunused-function] Cc: Andrzej Hajda Cc: Neil Armstrong Cc: Laurent Pinchart Cc: Jonas Karlman Cc: Jernej Skrabec Cc: David Airlie Cc: Daniel Vetter Cc: Jason Yan Cc: Lee Jones Cc: Jingoo Han Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- .../gpu/drm/bridge/analogix/analogix_dp_reg.c | 44 ------------------- 1 file changed, 44 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c index 9ce45c757f8c8..cab6c8b92efd4 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -524,50 +524,6 @@ void analogix_dp_enable_sw_function(struct analogix_dp_device *dp) writel(reg, dp->reg_base + ANALOGIX_DP_FUNC_EN_1); } -static int analogix_dp_start_aux_transaction(struct analogix_dp_device *dp) -{ - int reg; - int retval = 0; - int timeout_loop = 0; - - /* Enable AUX CH operation */ - reg = readl(dp->reg_base + ANALOGIX_DP_AUX_CH_CTL_2); - reg |= AUX_EN; - writel(reg, dp->reg_base + ANALOGIX_DP_AUX_CH_CTL_2); - - /* Is AUX CH command reply received? */ - reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); - while (!(reg & RPLY_RECEIV)) { - timeout_loop++; - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) { - dev_err(dp->dev, "AUX CH command reply failed!\n"); - return -ETIMEDOUT; - } - reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); - usleep_range(10, 11); - } - - /* Clear interrupt source for AUX CH command reply */ - writel(RPLY_RECEIV, dp->reg_base + ANALOGIX_DP_INT_STA); - - /* Clear interrupt source for AUX CH access error */ - reg = readl(dp->reg_base + ANALOGIX_DP_INT_STA); - if (reg & AUX_ERR) { - writel(AUX_ERR, dp->reg_base + ANALOGIX_DP_INT_STA); - return -EREMOTEIO; - } - - /* Check AUX CH error access status */ - reg = readl(dp->reg_base + ANALOGIX_DP_AUX_CH_STA); - if ((reg & AUX_STATUS_MASK) != 0) { - dev_err(dp->dev, "AUX CH error happens: %d\n\n", - reg & AUX_STATUS_MASK); - return -EREMOTEIO; - } - - return retval; -} - void analogix_dp_set_link_bandwidth(struct analogix_dp_device *dp, u32 bwtype) { u32 reg;