From patchwork Sat Nov 7 03:29:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernard Zhao X-Patchwork-Id: 11888507 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D9AEC388F7 for ; Sat, 7 Nov 2020 03:30:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4358206F4 for ; Sat, 7 Nov 2020 03:30:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FZpHvVO/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A4358206F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WQgQyYYA/Dq/Oik/gNDRPCC6BngekDKVoK3mhwUI4AY=; b=FZpHvVO/qs5swy2UVHG8/TEfo 8aulJzYXA1/RKiLnFGeaLOVIAtZO/XVZxOpaiFPasz3ossfWbriasUkILlNEU9zygKCzH9p9ZkvZ6 HJZ+oLqjyyg41cTfTEbRY8Hz0AqqG9x4vMyvq6gk0end9ArQ51DwXnCy1PFkD6bQT06U07b2i3g/o Xmx/WN+NBw/VivTGFnwQuRXocmYKtEQPK9hS9H/frfzvB6Gme0OYRZLMGnsIgHnkMa7W9xogvg0ou VUQizLt5UAq1UJ3CTUTFleAKdoPK7QHCoQRvcysazu0ZwVyeWTEGq0KNwqYE7NBXfeafzbnOfQktv LJvltk44A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbEvM-0005zO-H9; Sat, 07 Nov 2020 03:29:56 +0000 Received: from mail-m1271.qiye.163.com ([115.236.127.1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbEvF-0005xq-Cr for linux-arm-kernel@lists.infradead.org; Sat, 07 Nov 2020 03:29:52 +0000 Received: from ubuntu.localdomain (unknown [58.213.83.157]) by mail-m1271.qiye.163.com (Hmail) with ESMTPA id 2D476581FA9; Sat, 7 Nov 2020 11:29:41 +0800 (CST) From: Bernard Zhao To: Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] tty/serial: delete break after return Date: Fri, 6 Nov 2020 19:29:23 -0800 Message-Id: <20201107032924.25044-2-bernard@vivo.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20201107032924.25044-1-bernard@vivo.com> References: <20201107032924.25044-1-bernard@vivo.com> MIME-Version: 1.0 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZHxgYGhofSE1KHktDVkpNS09MSkJMQ0pPQ0hVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS09ISFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PCI6GQw6KD8YMxwoT0oaTTQw OR4KCVFVSlVKTUtPTEpCTENKQ09JVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlOQ1VJ SkhVQ0hVSk5MWVdZCAFZQUlOTEM3Bg++ X-HM-Tid: 0a75a0c0a60798b6kuuu2d476581fa9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_222949_699343_C34F98ED X-CRM114-Status: UNSURE ( 7.78 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com, Bernard Zhao Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Delete break after return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/serial/imx.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 1731d9728865..09703079db7b 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -320,7 +320,6 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) switch (offset) { case UCR1: return sport->ucr1; - break; case UCR2: /* * UCR2_SRST is the only bit in the cached registers that might @@ -331,16 +330,12 @@ static u32 imx_uart_readl(struct imx_port *sport, u32 offset) if (!(sport->ucr2 & UCR2_SRST)) sport->ucr2 = readl(sport->port.membase + offset); return sport->ucr2; - break; case UCR3: return sport->ucr3; - break; case UCR4: return sport->ucr4; - break; case UFCR: return sport->ufcr; - break; default: return readl(sport->port.membase + offset); } From patchwork Sat Nov 7 03:29:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bernard Zhao X-Patchwork-Id: 11888505 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F00C4742C for ; Sat, 7 Nov 2020 03:31:29 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EED5420658 for ; Sat, 7 Nov 2020 03:31:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="h7rZsBPz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EED5420658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=vivo.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8BSMAar6m7dsncwXsyudErHF1nXTlOo06vRKAbW/krQ=; b=h7rZsBPzU+1f2SAPcw+iMyLsE qS8yz9DwMiqVP2ss1tQ5+yhaMk6Lq11Hxq1llkosurZzf4qZvvuXPKKllDEprubUdvAmKGuO1fpJ+ zv26gWhF4bjVqSGsASWxMAkne5JTpAYWJ5KPZ7MohsYsPCw0CA4vGqvV4ImQuDl5Y/LBlAS20gPhl mAe9mQ4BEXX1SYBTNHROdzuRP/6s0RQuOkcbEJ2HDJ0iW1r1lVmNtwQafl0DPMoTXY96k4M1I62Vq qIYXP/pWrCPcVrpJlBYRbn9CV/wu3/JG/atcXuJycxA+NAR9bWmsBDhzFgW7+sjcG+bjE2fqnh5hd UHlRH/45Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbEvO-0005zi-EQ; Sat, 07 Nov 2020 03:29:58 +0000 Received: from mail-m1271.qiye.163.com ([115.236.127.1]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kbEvF-0005xu-CS for linux-arm-kernel@lists.infradead.org; Sat, 07 Nov 2020 03:29:52 +0000 Received: from ubuntu.localdomain (unknown [58.213.83.157]) by mail-m1271.qiye.163.com (Hmail) with ESMTPA id 1DB295820CE; Sat, 7 Nov 2020 11:29:43 +0800 (CST) From: Bernard Zhao To: Greg Kroah-Hartman , Jiri Slaby , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] drivers/tty: delete break after goto/return Date: Fri, 6 Nov 2020 19:29:24 -0800 Message-Id: <20201107032924.25044-3-bernard@vivo.com> X-Mailer: git-send-email 2.29.0 In-Reply-To: <20201107032924.25044-1-bernard@vivo.com> References: <20201107032924.25044-1-bernard@vivo.com> MIME-Version: 1.0 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZGEhMGEhIGRlLQ0IaVkpNS09MSkJMQ0hPSUtVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS09ISFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NRw6Qxw4Dj8tIxwvCktLTTkW Kk4KCglVSlVKTUtPTEpCTENPSk5OVTMWGhIXVRkeCRUaCR87DRINFFUYFBZFWVdZEgtZQVlOQ1VJ SkhVQ0hVSk5MWVdZCAFZQUlMS083Bg++ X-HM-Tid: 0a75a0c0ad9798b6kuuu1db295820ce X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201106_222949_716006_33460308 X-CRM114-Status: UNSURE ( 8.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: opensource.kernel@vivo.com, Bernard Zhao Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Delete break after goto/return, which will never run. Signed-off-by: Bernard Zhao --- drivers/tty/nozomi.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/tty/nozomi.c b/drivers/tty/nozomi.c index d42b854cb7df..946cc16827aa 100644 --- a/drivers/tty/nozomi.c +++ b/drivers/tty/nozomi.c @@ -414,11 +414,9 @@ static void read_mem32(u32 *buf, const void __iomem *mem_addr_start, buf16 = (u16 *) buf; *buf16 = __le16_to_cpu(readw(ptr)); goto out; - break; case 4: /* 4 bytes */ *(buf) = __le32_to_cpu(readl(ptr)); goto out; - break; } while (i < size_bytes) { @@ -460,7 +458,6 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf, buf16 = (const u16 *)buf; writew(__cpu_to_le16(*buf16), ptr); return 2; - break; case 1: /* * also needs to write 4 bytes in this case * so falling through.. @@ -468,7 +465,6 @@ static u32 write_mem32(void __iomem *mem_addr_start, const u32 *buf, case 4: /* 4 bytes */ writel(__cpu_to_le32(*buf), ptr); return 4; - break; } while (i < size_bytes) {