From patchwork Sat Nov 7 13:39:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 11888953 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E8A7C174A for ; Sat, 7 Nov 2020 13:39:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBAAA20719 for ; Sat, 7 Nov 2020 13:39:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pp3Nijb3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728063AbgKGNjl (ORCPT ); Sat, 7 Nov 2020 08:39:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbgKGNjl (ORCPT ); Sat, 7 Nov 2020 08:39:41 -0500 Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5AE0C0613CF; Sat, 7 Nov 2020 05:39:40 -0800 (PST) Received: by mail-lj1-x231.google.com with SMTP id y16so4609144ljk.1; Sat, 07 Nov 2020 05:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c5vk1HU4LMO05/HvLhuFLID0YfaxsQiSjHZGb3JZL+k=; b=pp3Nijb3qelAlJYoXTJYgO4SDTsvHQB1JVzF89P6cF7PNLT/RAQs2CvY4zJ2L+s657 Rncm1TbS0AhZp5RWhK17AA9nfGkJuPjqOuiTzG5SUXR0X/CBwILioM5AcJwIQfNT3oNi 6l3Iz82nm4lT7T+93ohGSnSSQK2e0WzReQZ6oDBR1YsM0b2OGWCkPUBtqGJXh4R/zsbe KIFr52Gn7obgs+qgg1HXxFe3Q+6Ig0nlw89gQ2rUe1ccXEJ9GVn4GcREF7Z1huS2l5MB wGPvhOufbRsForGk7jLelkIHSAe/hKG7VFQ3BOthkkFnmdb6qq1eWE5eUd9JYdKtVV+w mESg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=c5vk1HU4LMO05/HvLhuFLID0YfaxsQiSjHZGb3JZL+k=; b=aT+9E0ex+1rgp4p+UufwbYMQ5EHxD0GLtqyhf2/eooOm5yECywHKRf4NUCBZj/4DQO INwxfEmvivFDx9uFOLy6EPpJ0XA7fPyuaT+x0Uqeahy9co7Mkx0Lc9SB9sIyok6c1iCN ll9HW47ZxQrSqJVj5j+DKXebntosDVHpM4OMqnCmYmqxpF90q4l+rZ6aJj4CwgXTASNo VOjh3fBZ70EmdAhpcOn3x+tRGW4EGptbyxn8bqxbjQXmBbwmKALrX03I2oSAfvWngIz7 TeIdPMqDT52U/WZXyl02o0a5RST48dm1YpAFyRhZXT3rswbf0mooYVZXS8aeOzvrtbCa 7SUQ== X-Gm-Message-State: AOAM531RI9Ki1QqIEE9mQYuRanFJkgGo1VuHcuMUv8ryN9ND++kYeI+F mYzLh8Do5aLFSUvgGN/No1c= X-Google-Smtp-Source: ABdhPJykwd8X4etetyGtEH9KC2jai7rgshQmz5xZq3TNNHZcMixp/o1ZAsTHgBT0IRpaPnjMLSR6FQ== X-Received: by 2002:a2e:9ac4:: with SMTP id p4mr2412087ljj.247.1604756379480; Sat, 07 Nov 2020 05:39:39 -0800 (PST) Received: from localhost.localdomain ([2a02:a315:5445:5300:d646:fcbb:9c5e:1da1]) by smtp.googlemail.com with ESMTPSA id y27sm524189ljm.74.2020.11.07.05.39.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 05:39:38 -0800 (PST) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: kgene@kernel.org, krzk@kernel.org, alim.akhtar@samsung.com Cc: robh+dt@kernel.org, a.kesavan@samsung.com, naveenkrishna.ch@gmail.com, thomas.ab@samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Subject: [PATCH v2 1/2] arm64: dts: exynos: Include common syscon restart/poweroff for Exynos7 Date: Sat, 7 Nov 2020 14:39:25 +0100 Message-Id: <20201107133926.37187-1-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org Exynos7 uses the same syscon reboot and poweroff nodes as other Exynos SoCs, so instead of duplicating code we can just include common dtsi file, which already contains definitions of them. After this change, poweroff node will be also available, previously this dts file did contain only reboot node. Fixes: fb026cb65247 ("arm64: dts: Add reboot node for exynos7") Fixes: b9024cbc937d ("arm64: dts: Add initial device tree support for exynos7") Signed-off-by: Paweł Chmiel --- Changes from v1: - Split into two separate patches. - Include existing exynos-syscon-restart.dtsi to avoid code duplication. --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index 7a2cba4220d9..723f5d5fcf00 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -624,13 +624,6 @@ hsi2c_11: hsi2c@136a0000 { pmu_system_controller: system-controller@105c0000 { compatible = "samsung,exynos7-pmu", "syscon"; reg = <0x105c0000 0x5000>; - - reboot: syscon-reboot { - compatible = "syscon-reboot"; - regmap = <&pmu_system_controller>; - offset = <0x0400>; - mask = <0x1>; - }; }; rtc: rtc@10590000 { @@ -818,3 +811,5 @@ atlas_thermal: cluster0-thermal { }; #include "exynos7-pinctrl.dtsi" +#include "arm/exynos-syscon-restart.dtsi" + From patchwork Sat Nov 7 13:39:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Pawe=C5=82_Chmiel?= X-Patchwork-Id: 11888955 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9110117D4 for ; Sat, 7 Nov 2020 13:39:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7220420719 for ; Sat, 7 Nov 2020 13:39:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AhDiTzaq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728130AbgKGNjo (ORCPT ); Sat, 7 Nov 2020 08:39:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727084AbgKGNjn (ORCPT ); Sat, 7 Nov 2020 08:39:43 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 940E2C0613CF; Sat, 7 Nov 2020 05:39:42 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id 126so5846293lfi.8; Sat, 07 Nov 2020 05:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lAR/h1wV/mVrmRlM3JEvsi3/vv0tMjOOYCctIjXs1fA=; b=AhDiTzaqcIBZB/kD/hlamzvzQ/LFTFLzK2Ti4G+IBZg9/+yDi5Mw2INNbxyzhei+lu G0EvTSygiRODFHWPQJW70UBEGeCEGtL7TOXZR85U6Sl65Pc/wZmfY2Gs/iOsbyZ9toOg 26gI68BDpXhyRpQMGhGLDbOmvAJgFk76xSeRhYTq4zn2FPR1lH8lGm4tbIjNoBrDmGZN nBdkXRqVyK9qa73nHLG8TPyaoeT4isYOR1iT6cQnJXzUPGpz8EytJH+zgtgH6E6vlXCR UjXKSLU/vFpGAmi46NVNjgH2Sn5kyi0do8wkLWim659Op9OS3hIJYOXUdQaU/TY3lSH5 1DrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lAR/h1wV/mVrmRlM3JEvsi3/vv0tMjOOYCctIjXs1fA=; b=fOn8M6iIvLFKLGVGYn660Kdr+GsrQnp0iZLA7XEpOpMxFI0FXxA+bwNKYDlCyBKZ9T 0MEsOTmW7Pt8WPXBiJNKvVGGsJa3awK4JNyoeKuWx7Bs0nhD6hJDKDbfY/dmn3YBpxJl 0M9a7krsnIdjySElzOfsHamqLoOmoHHXreAN8EnpdeJ9RYuzg4WaaY8qcR8GpFXAUXwi ezXrxlRjYq+yuLw/yEVstzLSwuK6sKjrNUUdPIhTFuVDYDPLwpIR+TDoRnPZBTPCVeqB aZJ79XAHbBYK5of/jEuSVujEtu8fY7CZJ6+mGJGTACMXPgJ7rR+VrLVMtASMkovKXXsm nUyg== X-Gm-Message-State: AOAM5304d96C0Vy3j699ArS1QAsd3rtYAvjH06zPR61wTRP+YLB6Iksc 3pmGn7VE4WlELJkciQSDD/E= X-Google-Smtp-Source: ABdhPJxGEb/igDJY7FFYn1Atx88+hv86yhzhEjECh4F4QIcwxm/ZUYV/HiIyeNiwwYfb9+TtVWFh0w== X-Received: by 2002:ac2:533b:: with SMTP id f27mr2495942lfh.57.1604756381108; Sat, 07 Nov 2020 05:39:41 -0800 (PST) Received: from localhost.localdomain ([2a02:a315:5445:5300:d646:fcbb:9c5e:1da1]) by smtp.googlemail.com with ESMTPSA id y27sm524189ljm.74.2020.11.07.05.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 05:39:40 -0800 (PST) From: =?utf-8?q?Pawe=C5=82_Chmiel?= To: kgene@kernel.org, krzk@kernel.org, alim.akhtar@samsung.com Cc: robh+dt@kernel.org, a.kesavan@samsung.com, naveenkrishna.ch@gmail.com, thomas.ab@samsung.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?Pawe=C5=82_Chmiel?= Subject: [PATCH v2 2/2] arm64: dts: exynos: Correct psci compatible used on Exynos7 Date: Sat, 7 Nov 2020 14:39:26 +0100 Message-Id: <20201107133926.37187-2-pawel.mikolaj.chmiel@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201107133926.37187-1-pawel.mikolaj.chmiel@gmail.com> References: <20201107133926.37187-1-pawel.mikolaj.chmiel@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org It's not possible to reboot or poweroff Exynos7420 using PSCI. Instead we need to use syscon reboot/poweroff drivers, like it's done for other Exynos SoCs. This was confirmed by checking vendor source and testing it on Samsung Galaxy S6 device based on this SoC. To be able to use custom restart/poweroff handlers instead of PSCI functions, we need to correct psci compatible. This also requires us to provide function ids for CPU_ON and CPU_OFF. Fixes: fb026cb65247 ("arm64: dts: Add reboot node for exynos7") Fixes: b9024cbc937d ("arm64: dts: Add initial device tree support for exynos7") Signed-off-by: Paweł Chmiel --- Changes from v1: - Split into two separate patches. --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index 723f5d5fcf00..fff383206545 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -117,8 +117,10 @@ cpu_atlas3: cpu@3 { }; psci { - compatible = "arm,psci-0.2"; + compatible = "arm,psci"; method = "smc"; + cpu_off = <0x84000002>; + cpu_on = <0xC4000003>; }; soc: soc@0 {