From patchwork Sat Nov 7 17:21:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889089 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C8D1714B4 for ; Sat, 7 Nov 2020 17:22:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB8D7208FE for ; Sat, 7 Nov 2020 17:22:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="tCgApyOq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728437AbgKGRWy (ORCPT ); Sat, 7 Nov 2020 12:22:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRWx (ORCPT ); Sat, 7 Nov 2020 12:22:53 -0500 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CA6CC0613CF; Sat, 7 Nov 2020 09:22:52 -0800 (PST) Received: by mail-pj1-x1042.google.com with SMTP id r9so1004865pjl.5; Sat, 07 Nov 2020 09:22:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=CiDS6Teu78wmWygf2J2zdXtriik6tBTmq5dTYnwE40o=; b=tCgApyOqPT+RZAX5zLv9TE7h+GzvOLEXvLP8T1DpB2w+OaCLTTk5xtxuDwixegEQkW MaheBhqBA5iiP6GvAKyxHdD5e8ubUr2YEBqD2BiiSczsFQUVYMDLSmppUaOyR2zccweL dukM+4mWPc7gDMT/oPFU3v9J63IZY9qxpqJzUD7CB+UQWCrJMT5vHFvZ4DM3wrWd99kP JgIOoLiNk+2xhNBGWH+fO8R1lZipfpO2+MEMrdedtudBGpRbGA5zea1A9/aW6UKYbbnV WBS2l56e+LtqS9NU9CtYPU03HRViedTLeoWvgl0JXmcdvemq0aVsylLk36kbuWmuraEy W91A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CiDS6Teu78wmWygf2J2zdXtriik6tBTmq5dTYnwE40o=; b=rQldtJeFVRyQbo7tMzEd7g9oswGTDm8uXt5ov3s+L6gQUiFiRKLt0Zuaq2yQyRW/wf mzj4F7fdV/IxhpAynfEd2c9ELpi8asMNHQXi8AzBM6VE0tkRGBcmM7yHWcstR5A6BUsr Fm8CpXIA47hGP2HzPR9LTO7D3RwC1sagePQk13B2C6NrDrKa6q41nL75fHXxT50KSUmI a7EKdalAj6yDLM8QNW37tMwQax/Dm7Pmvpjq8dAtnvxVs9otFH9e3TAW/xaQjoBrUKN5 R+YfaF+SbUzajru7l+vrMDQrFqTjrkGgi8k75E1BTReTMunlL2Vy6mBj6H57HENZsHC1 IXPg== X-Gm-Message-State: AOAM531Nn9n9mmUkcYqPxYr4MQLvvpAvGqcV4B/kvAd7k+vr9A3s7K2/ xJVLWpfZHU5ljFBAd6Bh+Xs= X-Google-Smtp-Source: ABdhPJyKBW8P+7OQmuvTY1J/Yv9saMA6cBcGLM77v9zrCJXHc1wUWn9jrHDjVOPNdNz1Nyt5SRLR/Q== X-Received: by 2002:a17:902:b711:b029:d3:f1e5:c9c1 with SMTP id d17-20020a170902b711b02900d3f1e5c9c1mr3207871pls.3.1604769771923; Sat, 07 Nov 2020 09:22:51 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:22:51 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 01/21] net: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:32 +0000 Message-Id: <20201107172152.828-2-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 9e466250ede3 ("batman-adv: Prefix bat_debugfs local static functions with batadv_") Fixes: 5609c185f24d ("6lowpan: iphc: add support for stateful compression") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem net/6lowpan/debugfs.c | 1 + net/batman-adv/log.c | 1 + 2 files changed, 2 insertions(+) diff --git a/net/6lowpan/debugfs.c b/net/6lowpan/debugfs.c index 1c140af06d52..2f791ccc783b 100644 --- a/net/6lowpan/debugfs.c +++ b/net/6lowpan/debugfs.c @@ -161,6 +161,7 @@ static const struct file_operations lowpan_ctx_pfx_fops = { .write = lowpan_ctx_pfx_write, .llseek = seq_lseek, .release = single_release, + .owner = THIS_MODULE, }; static void lowpan_dev_debugfs_ctx_init(struct net_device *dev, diff --git a/net/batman-adv/log.c b/net/batman-adv/log.c index a67b2b091447..c0ca5fbe5b08 100644 --- a/net/batman-adv/log.c +++ b/net/batman-adv/log.c @@ -180,6 +180,7 @@ static const struct file_operations batadv_log_fops = { .read = batadv_log_read, .poll = batadv_log_poll, .llseek = no_llseek, + .owner = THIS_MODULE, }; /** From patchwork Sat Nov 7 17:21:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889093 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C37D9139F for ; Sat, 7 Nov 2020 17:23:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A1E23221FE for ; Sat, 7 Nov 2020 17:23:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MYWbjFmL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728488AbgKGRXD (ORCPT ); Sat, 7 Nov 2020 12:23:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRXC (ORCPT ); Sat, 7 Nov 2020 12:23:02 -0500 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43116C0613D2; Sat, 7 Nov 2020 09:23:01 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id y7so4411843pfq.11; Sat, 07 Nov 2020 09:23:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Svu+8zZ1HFkOwV4kgZcEyG8KAuhCUkKQSH8fdpqwQuc=; b=MYWbjFmLYT8cO4Ib43c8sfdsiUN/EiEtHmO+Kv8gwdsD5UCpKjO04gnM/+3bCBE6L1 2u+vs4qcvHaGs5aj2asgVXjv2mbLYJHBje+G2+phfNoX98BbuVnINSE11UYhiUZHbAqi rChP/QnrSPrkkQBuvU+RXPRm3v+qAPF4uZMhA6ARlx1uXEROI8wNpS/m/nXN8D2Sj6VR EsqOp4Zw/zgFDRvLOesHFq+klW0Dc5Eu/ZG68mbq1Rzo9eTHg17H+ljnH7Hc1r4WvZoI Hk8aCKvI8gsUHOcsDvwI/QEFfNODq2pxRUROTwRq9pEyRdYHleFQWDuBDcTeBmmBdti5 cGQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Svu+8zZ1HFkOwV4kgZcEyG8KAuhCUkKQSH8fdpqwQuc=; b=B9AxAlo4UKEztgFo9HtNwzwpN1ySAnNGLMLkzv/zohTOK5Y+3X7Cu4imLdO03qdTIx nEC9F5d73CVcw8uvHgTBWT31dG0CrZJcLXp9QIqSFPLAktket9+lP/Gc2D4oGncgE4aK xG0aXAe5TMzQfG4vK1At8zN4O8W7xaYaPw51QqXjCdvqW68rmxgAsGS6dmtVjYNpHoMs apTeoveHIoNrWv2HQczpKGHeGm37sGBztjytS6igMXOpYIOOzbHRek/7VopB06E0LyeI GpaDTU+dDxUwjiZ5kU5wNlJRkfzVj6OKezHxSC2Mk9m/8kDwWgMXq0dMRJPMMcOfdKzM IGKg== X-Gm-Message-State: AOAM531/gCQhcv1ZZ/vjh0pUOwlCR+sungBPiKtzlw5kFWgYcXrmyBl9 zT+xJ/Y72payhgRDlJPB+XU= X-Google-Smtp-Source: ABdhPJw45yizT66uymYl4g7/Fn719gVJCC+oaYIYG2LBWngS+BnKhNNmh1jzXexx3iYEjaR18BXdhA== X-Received: by 2002:a63:4f5f:: with SMTP id p31mr6232629pgl.158.1604769780833; Sat, 07 Nov 2020 09:23:00 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:22:59 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 02/21] mac80211: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:33 +0000 Message-Id: <20201107172152.828-3-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: e9f207f0ff90 ("[MAC80211]: Add debugfs attributes.") Fixes: 4b7679a561e5 ("mac80211: clean up rate control API") Fixes: ec8aa669b839 ("mac80211: add the minstrel_ht rate control algorithm") Fixes: 2cae0b6a70d6 ("mac80211: add new Minstrel-HT statistic output via csv") Fixes: d0a77c6569ab ("mac80211: allow writing TX PN in debugfs") Fixes: 8f20fc24986a ("[MAC80211]: embed key conf in key, fix driver interface") Fixes: a75b4363eaaf ("mac80211: allow controlling aggregation manually") Fixes: 9399b86c0e9a ("mac80211: add debug knobs for fair queuing") Fixes: e322c07f8371 ("mac80211: debugfs: improve airtime_flags handler readability") Fixes: 3ace10f5b5ad ("mac80211: Implement Airtime-based Queue Limit (AQL)") Fixes: 276d9e82e06c ("mac80211: debugfs option to force TX status frames") Fixes: 827b1fb44b7e ("mac80211: resume properly, add suspend/resume test") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem net/mac80211/debugfs.c | 7 +++++++ net/mac80211/debugfs_key.c | 3 +++ net/mac80211/debugfs_netdev.c | 1 + net/mac80211/debugfs_sta.c | 2 ++ net/mac80211/rate.c | 1 + net/mac80211/rc80211_minstrel_ht_debugfs.c | 2 ++ 6 files changed, 16 insertions(+) diff --git a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c index 90470392fdaa..abbfc1bbdb8b 100644 --- a/net/mac80211/debugfs.c +++ b/net/mac80211/debugfs.c @@ -46,6 +46,7 @@ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_READONLY_FILE(name, fmt, value...) \ @@ -148,6 +149,7 @@ static const struct file_operations aqm_ops = { .read = aqm_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t airtime_flags_read(struct file *file, @@ -201,6 +203,7 @@ static const struct file_operations airtime_flags_ops = { .read = airtime_flags_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t aql_txq_limit_read(struct file *file, @@ -282,6 +285,7 @@ static const struct file_operations aql_txq_limit_ops = { .read = aql_txq_limit_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t force_tx_status_read(struct file *file, @@ -334,6 +338,7 @@ static const struct file_operations force_tx_status_ops = { .read = force_tx_status_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; #ifdef CONFIG_PM @@ -354,6 +359,7 @@ static const struct file_operations reset_ops = { .write = reset_write, .open = simple_open, .llseek = noop_llseek, + .owner = THIS_MODULE, }; #endif @@ -537,6 +543,7 @@ static const struct file_operations stats_ ##name## _ops = { \ .read = stats_ ##name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_STATS_ADD(name) \ diff --git a/net/mac80211/debugfs_key.c b/net/mac80211/debugfs_key.c index 98a713475e0f..d7c0c28045ef 100644 --- a/net/mac80211/debugfs_key.c +++ b/net/mac80211/debugfs_key.c @@ -30,6 +30,7 @@ static const struct file_operations key_ ##name## _ops = { \ .read = key_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } #define KEY_OPS_W(name) \ @@ -38,6 +39,7 @@ static const struct file_operations key_ ##name## _ops = { \ .write = key_##name##_write, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } #define KEY_FILE(name, format) \ @@ -53,6 +55,7 @@ static const struct file_operations key_ ##name## _ops = { \ .read = key_conf_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } #define KEY_CONF_FILE(name, format) \ diff --git a/net/mac80211/debugfs_netdev.c b/net/mac80211/debugfs_netdev.c index fe8a7a87e513..8efa31ae7334 100644 --- a/net/mac80211/debugfs_netdev.c +++ b/net/mac80211/debugfs_netdev.c @@ -127,6 +127,7 @@ static const struct file_operations name##_ops = { \ .write = (_write), \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } #define _IEEE80211_IF_FILE_R_FN(name) \ diff --git a/net/mac80211/debugfs_sta.c b/net/mac80211/debugfs_sta.c index 829dcad69c2c..9ce49346c32a 100644 --- a/net/mac80211/debugfs_sta.c +++ b/net/mac80211/debugfs_sta.c @@ -34,6 +34,7 @@ static const struct file_operations sta_ ##name## _ops = { \ .read = sta_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } #define STA_OPS_RW(name) \ @@ -42,6 +43,7 @@ static const struct file_operations sta_ ##name## _ops = { \ .write = sta_##name##_write, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } #define STA_FILE(name, field, format) \ diff --git a/net/mac80211/rate.c b/net/mac80211/rate.c index 45927202c71c..bbb691119a44 100644 --- a/net/mac80211/rate.c +++ b/net/mac80211/rate.c @@ -225,6 +225,7 @@ const struct file_operations rcname_ops = { .read = rcname_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; #endif diff --git a/net/mac80211/rc80211_minstrel_ht_debugfs.c b/net/mac80211/rc80211_minstrel_ht_debugfs.c index bebb71917742..cdb51aa460a3 100644 --- a/net/mac80211/rc80211_minstrel_ht_debugfs.c +++ b/net/mac80211/rc80211_minstrel_ht_debugfs.c @@ -173,6 +173,7 @@ static const struct file_operations minstrel_ht_stat_fops = { .read = minstrel_stats_read, .release = minstrel_stats_release, .llseek = no_llseek, + .owner = THIS_MODULE, }; static char * @@ -311,6 +312,7 @@ static const struct file_operations minstrel_ht_stat_csv_fops = { .read = minstrel_stats_read, .release = minstrel_stats_release, .llseek = no_llseek, + .owner = THIS_MODULE, }; void From patchwork Sat Nov 7 17:21:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889095 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 90987139F for ; Sat, 7 Nov 2020 17:23:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 706DC20878 for ; Sat, 7 Nov 2020 17:23:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mewAzy8f" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbgKGRXL (ORCPT ); Sat, 7 Nov 2020 12:23:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRXL (ORCPT ); Sat, 7 Nov 2020 12:23:11 -0500 Received: from mail-pg1-x542.google.com (mail-pg1-x542.google.com [IPv6:2607:f8b0:4864:20::542]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51067C0613CF; Sat, 7 Nov 2020 09:23:10 -0800 (PST) Received: by mail-pg1-x542.google.com with SMTP id m26so62072pgd.9; Sat, 07 Nov 2020 09:23:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Wj+0VqG+5SB5oZKbW/GaSo/+ki/3S6i7Eqaup4c2W/g=; b=mewAzy8fCkvVFDTWKRKNDtl/H54rTocRCmAp5/HuryIKGEUBVZt5s2zyjFkpa7B8cI 8wv9K03NY/aMJ03JxRsdC3VUxo+huCY4/0mhGDrVs8tFShv1Wwm61xBd2blSRhlrWAYd HKXY3xW1SNwGYfhAx/xzR8xZGkyj7unEHIT1Is8Qm5PBCPsTXwUHsFmmuhZfeFN6e02M Q73IQhY9nGP2NZtUzLxcxLSUMn3rcLKLKCJfnj56r++t0OsaMFp8ZVehRXquB2gSz1Vq vuVuFBR1Np1J1nNDZYl7sUryIXDIN7dVNN5NTjBASuPkjzf5u7Q4+RsJx6g/vG9DSVE0 rLBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Wj+0VqG+5SB5oZKbW/GaSo/+ki/3S6i7Eqaup4c2W/g=; b=emJx5Ik/XnvafVZbLjln15MrUbX3jRGgWAuK7WAY1DkZiUpJf8cSskVphx4tLAB9lZ yJPodWK5xo73owlbzJnbr+0PNN/u5lgCb9wgSPd6ubUCTp5vAllqrAFSqhvkE63c+7c4 Q28ANhKZudJ6mXF1gKq7eJsEOQ+iOqygnmTooqYLaw49RqCP9CSJA/Ri8U+Sx2krZeow njIRA14XJ4Ksf7ztgWJTQ1CzgnKySFgZJVXsy96Ne3YsnfdScBEKiUaymHvxuX7z89eF NpiDVCy/ZEE8TXG76x0+LKN/fljs4otP3H+P92HnwfZy1HZsE2RqpemXe5HnpD0M6vXE 2RYQ== X-Gm-Message-State: AOAM532OVOmCA1XTuTwXblnh4HgBdGiRIEmzGzUdD+qTRNOM+mmuJqK8 pY8l4U+l9AskTqRSYEUHbvQ= X-Google-Smtp-Source: ABdhPJyIYLL/8VP94KriZUTOq5Oac2fHtME+PAWpk8Y8ZE/Dd5g84O2dFhwevg0M2Q6uz0DWqMD/5w== X-Received: by 2002:aa7:9f0c:0:b029:18a:e524:3b90 with SMTP id g12-20020aa79f0c0000b029018ae5243b90mr6887178pfr.77.1604769789902; Sat, 07 Nov 2020 09:23:09 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.23.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:23:08 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 03/21] cfg80211: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:34 +0000 Message-Id: <20201107172152.828-4-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 1ac61302dcd1 ("mac80211/cfg80211: move wiphy specific debugfs entries to cfg80211") Fixes: 80a3511d70e8 ("cfg80211: add debugfs HT40 allow map") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem net/wireless/debugfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/wireless/debugfs.c b/net/wireless/debugfs.c index 76b845f68ac8..eb54c0ac4728 100644 --- a/net/wireless/debugfs.c +++ b/net/wireless/debugfs.c @@ -26,6 +26,7 @@ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d", @@ -97,6 +98,7 @@ static const struct file_operations ht40allow_map_ops = { .read = ht40allow_map_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; #define DEBUGFS_ADD(name) \ From patchwork Sat Nov 7 17:21:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889099 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AE63014B4 for ; Sat, 7 Nov 2020 17:23:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9111520878 for ; Sat, 7 Nov 2020 17:23:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gDp8axuf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728543AbgKGRXT (ORCPT ); Sat, 7 Nov 2020 12:23:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRXT (ORCPT ); Sat, 7 Nov 2020 12:23:19 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D0B8C0613CF; Sat, 7 Nov 2020 09:23:19 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id g12so3515326pgm.8; Sat, 07 Nov 2020 09:23:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tI2A7wrVYPdXVz/TzeQi+IfDXKzGJ3NnGoB/TzjX3uU=; b=gDp8axufFz7PoT/7cEm5Ct8IfswZtCeOYN+FspIWjMhIfQyTfl8lKLEhWT8OZ6gsq+ KjEYIX3W+vYc2q71A/WeiKbOOv/JmxkeB/IVNpJhEiA7mR+rMj5umtx99qtizuuQjre+ rtKtYFQTsA3ECjQLiKuJG5W5cJWpF6WaeQxU1bbWLe2O5Q8tx/lgsKXDYF3xtQ0l7h7j sTzuPyZJWPdnxCNmQtmd0Etrme/KKn7g6o2V8/kOmam1gWU41po7RYQAyN03vMxrNYTx tWm/lhMT19tgHxuvt+PWjFOgoiQmQQEr+N/35/o8KujOJ/Extf2a6qQNIFEUgcm2hva0 qkQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tI2A7wrVYPdXVz/TzeQi+IfDXKzGJ3NnGoB/TzjX3uU=; b=nWabVov/4lfEJu3hgdgaxDVQhu1j1gAmnySFRsPAg0g9nmNtOdqCmUxe1xjEF2St7i R0/x5IuTgnf5CYnFc9OQ0Bo9oFnoTWuaw43aPtRkq4ysUEITiJ3eW5YmNNtkONAAgyjm DKstO9/kPl9lPY92XROOBKxBWoqzyMxoxy0qSDb/RDqqGPhlCulfEmYBJ+JSYQFP8shE S+dh/WIrKO6SqKtsuDLK4gD8xf/Xz97DzsdKvju5eJqyeIQqMnW0EQ16uiebIiLtq80X +2RMywHIYauE4ECODtAYcDPycYX+OYqSrAPAnHrDim5iNO3dOzoUjVWJuxmgOj5kBQ/s o8jQ== X-Gm-Message-State: AOAM533DaWVkr0ojzLbHyremuJ5vIzLXyY3GNrLRidX99687BHrXzPto 0Q8cSCD3rJTZt51hSeF91K0= X-Google-Smtp-Source: ABdhPJyJ5X3qCOo2hy4oJjtEYNBB8jnpwIJ9Ropkke72jm52m3EG2XdEIpAm47tjZJpJHlAe9JBUvA== X-Received: by 2002:a62:8043:0:b029:160:b840:b44 with SMTP id j64-20020a6280430000b0290160b8400b44mr6607219pfd.50.1604769798921; Sat, 07 Nov 2020 09:23:18 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.23.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:23:18 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 04/21] netdevsim: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:35 +0000 Message-Id: <20201107172152.828-5-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 82c93a87bf8b ("netdevsim: implement couple of testing devlink health reporters") Fixes: 424be63ad831 ("netdevsim: add UDP tunnel port offload support") Fixes: 4418f862d675 ("netdevsim: implement support for devlink region and snapshots") Fixes: d3cbb907ae57 ("netdevsim: add ACL trap reporting cookie as a metadata") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/netdevsim/dev.c | 2 ++ drivers/net/netdevsim/health.c | 1 + drivers/net/netdevsim/udp_tunnels.c | 1 + 3 files changed, 4 insertions(+) diff --git a/drivers/net/netdevsim/dev.c b/drivers/net/netdevsim/dev.c index d07061417675..e7972e88ffe0 100644 --- a/drivers/net/netdevsim/dev.c +++ b/drivers/net/netdevsim/dev.c @@ -96,6 +96,7 @@ static const struct file_operations nsim_dev_take_snapshot_fops = { .open = simple_open, .write = nsim_dev_take_snapshot_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, }; static ssize_t nsim_dev_trap_fa_cookie_read(struct file *file, @@ -188,6 +189,7 @@ static const struct file_operations nsim_dev_trap_fa_cookie_fops = { .read = nsim_dev_trap_fa_cookie_read, .write = nsim_dev_trap_fa_cookie_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, }; static int nsim_dev_debugfs_init(struct nsim_dev *nsim_dev) diff --git a/drivers/net/netdevsim/health.c b/drivers/net/netdevsim/health.c index 62958b238d50..21e2974660e7 100644 --- a/drivers/net/netdevsim/health.c +++ b/drivers/net/netdevsim/health.c @@ -261,6 +261,7 @@ static const struct file_operations nsim_dev_health_break_fops = { .open = simple_open, .write = nsim_dev_health_break_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, }; int nsim_dev_health_init(struct nsim_dev *nsim_dev, struct devlink *devlink) diff --git a/drivers/net/netdevsim/udp_tunnels.c b/drivers/net/netdevsim/udp_tunnels.c index 6ab023acefd6..02dc3123eb6c 100644 --- a/drivers/net/netdevsim/udp_tunnels.c +++ b/drivers/net/netdevsim/udp_tunnels.c @@ -124,6 +124,7 @@ static const struct file_operations nsim_udp_tunnels_info_reset_fops = { .open = simple_open, .write = nsim_udp_tunnels_info_reset_write, .llseek = generic_file_llseek, + .owner = THIS_MODULE, }; int nsim_udp_tunnels_info_create(struct nsim_dev *nsim_dev, From patchwork Sat Nov 7 17:21:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889105 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 442E5139F for ; Sat, 7 Nov 2020 17:23:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27C5C21D81 for ; Sat, 7 Nov 2020 17:23:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q2tdwVQV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728564AbgKGRX3 (ORCPT ); Sat, 7 Nov 2020 12:23:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRX2 (ORCPT ); Sat, 7 Nov 2020 12:23:28 -0500 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C224C0613CF; Sat, 7 Nov 2020 09:23:28 -0800 (PST) Received: by mail-pf1-x444.google.com with SMTP id z3so4413206pfb.10; Sat, 07 Nov 2020 09:23:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3hUaI9Zj73c0ME20iVIA+LX+pfMlZzzwZ/KWweKdyWk=; b=Q2tdwVQV1YrQYMK5hlyISpnZQS/QG4SfGs1O3nnAXm614yCmiZFuKMxwNXK2rk2mU4 4IMFs1SMrkTIWfdOUr8uz7rt3clKOh9et0v00dQ8qTWqTlND6cVr+bfLpJ7CloBbdNQk 9R/oHCp0MVe64gDkPOdswlQWBkx1P1ksaDeEdDe6Sd1WACRUieI4qPI+rEyCYGP6XcAe I75gldvgyAacayMppMtbW6n9D04FI51dxHl5agDxzoCjwFgRTmJsfX7aRKrnONuDItY4 QE40CwkwnswAeB9GcVMa8Ww1lle1CRfRnCEBZruUux8h0mAIv7yal/Rzp2WGKVrJqFRW vLlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3hUaI9Zj73c0ME20iVIA+LX+pfMlZzzwZ/KWweKdyWk=; b=HXaKCOlJS/PzT8YeONxeENCgYQBZAHFvnmn/IXT675FURRUn5YnBzm5exUQ/HMUlwb /NnmUBWTRv1AWv0wWQaaQw3SXmFHqX0JbQ5i+xoBpJOzN8aMuAqOoEZq60TDWiYUVtqv zSMOaiyy+CFHAKNB5cXUzQy4QzSurA4ZG7LWzLkXnSBGMybFDgO/QZj8KgatrIsZMji/ 4ip8JL0wSLLEPgumnu2qD8BN6CHbaQwClJWoWMHafb143Dz+wInssNWDF1XeBWD/poRD t43gXoNC8Zjfiq2zEAjI8gfZNhf1NRP26mgL8ARAqobZXjFkuYYeaVXltIwXTXKiVOP4 SruQ== X-Gm-Message-State: AOAM5325CxiHlNxAAa9+bgOCK5duu0pJ2LLCmWfeRtxjbmq7JYRVstU+ 3JPx5rRv8tFORB5qTwpnGjI= X-Google-Smtp-Source: ABdhPJx8EAj5YwxrZKT0XE5bVYHHzJBx6wBfZgKrXC7CjyPZPy0fpWZjLfPo8bO0VKLDKE63JU/JNQ== X-Received: by 2002:a63:2021:: with SMTP id g33mr6456482pgg.5.1604769807757; Sat, 07 Nov 2020 09:23:27 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.23.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:23:26 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 05/21] ieee802154: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:36 +0000 Message-Id: <20201107172152.828-6-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/ieee802154/ca8210.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 4eb64709d44c..d7b68c1279e6 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -2672,7 +2672,8 @@ static const struct file_operations test_int_fops = { .open = ca8210_test_int_open, .release = NULL, .unlocked_ioctl = ca8210_test_int_ioctl, - .poll = ca8210_test_int_poll + .poll = ca8210_test_int_poll, + .owner = THIS_MODULE, }; /* Init/Deinit */ From patchwork Sat Nov 7 17:21:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889107 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EBD68139F for ; Sat, 7 Nov 2020 17:23:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D14F8208FE for ; Sat, 7 Nov 2020 17:23:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lQGPCEMh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728586AbgKGRXh (ORCPT ); Sat, 7 Nov 2020 12:23:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRXh (ORCPT ); Sat, 7 Nov 2020 12:23:37 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 426FCC0613CF; Sat, 7 Nov 2020 09:23:37 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id h6so3529950pgk.4; Sat, 07 Nov 2020 09:23:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DVH7MPV7h31siOUxNvTJ1dlLI6x1csCPhYzRcZFZBc8=; b=lQGPCEMhSdpn9VyK57Qw0PuNHqO5mTKkBF13mjBaMDjgydI/B88u9y0jwohiOGe+7i uTlQYJA/f+bMSqVF2/4MLS+y8upPAoWH0e/KBnSUDcLsfABxErM82t5vLLRbq8uYrZ9D GaA3RNOT/uG9nbHJNqY2dylvfA2n/caSba+ScL1f2A47SNrIQKHq6BHO5qCphQaOwf0l HCedVCA+UoGARrA4O0Uiclo1aJg71ViYTu9kh90umNYDBhBVsKqQV2er9sJZlQAmzvmr 2XIgrf4bv/6QDi/I1DMnS6FuN/dMmZisZY9L1UGDhlOfgSuAoIAuy6k6L9sEyOTZOaXL SdsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DVH7MPV7h31siOUxNvTJ1dlLI6x1csCPhYzRcZFZBc8=; b=EQjsv4vl66UYaGI82D8gUI0j1bFpQqvpcMloL6Yu9kLdHPzRpVeCiOg9cfx91xYAaE ZJ9DN0m3x1xJsV23N4hovWkyWLQuz/GOrMSeVGjMnN+WjrR+dP2RTiKEBBINnpHRwhJ7 PUVAJrzEvQFLKjmqA9VVZ8LdORYgoU3D1OOiu/1AMoSsPEAKELNbmbZcF78DvqbLRvT3 L7icj9ITlauZ060f6G/9zDflkTOpDerp+Q4RZ3n3bk7Te0AgfOKbGq1p5RPItHRJPseh OGXOxwNtC5UJl7vdC/TEdTd1nGSFNrlJhmxzzUVoq7DSrsMUlFaigqhkskaKlgTTRJM+ N/hQ== X-Gm-Message-State: AOAM532uMiLMRJCUIPK0sJG586HDKfYoq5jDaVF9pIAj0/aAXENXBXKH d2RgqxTZxZHKehCIb+Jo1c8= X-Google-Smtp-Source: ABdhPJyzINbYWbM94zeW9+eAABlqFkL79L0aI0G7kehb6+rW5jRBR/fBzO8v6T539a9r3q3vD8EkIg== X-Received: by 2002:a63:1062:: with SMTP id 34mr6224131pgq.78.1604769816862; Sat, 07 Nov 2020 09:23:36 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.23.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:23:36 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 06/21] i2400m: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:37 +0000 Message-Id: <20201107172152.828-7-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: c71228caf91e ("i2400m: debugfs controls") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wimax/i2400m/debugfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wimax/i2400m/debugfs.c b/drivers/net/wimax/i2400m/debugfs.c index 1c640b41ea4c..144f8a7e98af 100644 --- a/drivers/net/wimax/i2400m/debugfs.c +++ b/drivers/net/wimax/i2400m/debugfs.c @@ -87,6 +87,7 @@ const struct file_operations i2400m_rx_stats_fops = { .read = i2400m_rx_stats_read, .write = i2400m_rx_stats_write, .llseek = default_llseek, + .owner = THIS_MODULE, }; @@ -140,6 +141,7 @@ const struct file_operations i2400m_tx_stats_fops = { .read = i2400m_tx_stats_read, .write = i2400m_tx_stats_write, .llseek = default_llseek, + .owner = THIS_MODULE, }; From patchwork Sat Nov 7 17:21:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889113 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D51B414B4 for ; Sat, 7 Nov 2020 17:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8FB2208FE for ; Sat, 7 Nov 2020 17:23:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B4/wE20o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728602AbgKGRXq (ORCPT ); Sat, 7 Nov 2020 12:23:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40260 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRXq (ORCPT ); Sat, 7 Nov 2020 12:23:46 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57564C0613CF; Sat, 7 Nov 2020 09:23:46 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id x15so1643017pll.2; Sat, 07 Nov 2020 09:23:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=eAp0pK4KzjRqqD/baLCKjCsG8PKBRZRcMg8qB8SJ2ys=; b=B4/wE20oItQPSjrj4O0gFoVU1fo1CMtVWbl2Bqs2uJSCLFV63cIsziKsEXwF1grEO3 RcVmlswSSM5YUGdzxT4t975xfFv9ucdpNQ3hrC3kW7V2yImt1w4WphzZDVCpzPmGMTBo fUjD6iZi2M0XkyQqB7JH6CF+k37uKSVR6DN4GOro+ZoaXc3ySmlfw1Ii7hZ1sccXp22a +PHT2OVxI4uAmVPyxguP5tXzxJLLdsyEKqxjK0P8i2n6W1GMm+pkBn6mSIJBt0AsERVI qPzntnyXKdmyf7ZbX9EcD+ZO/sJNsdVCd2N85EREwdxasx/VG8VSJa1gBwhSRTXHs4/t 6ixg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=eAp0pK4KzjRqqD/baLCKjCsG8PKBRZRcMg8qB8SJ2ys=; b=UYTL2AoYg5jAi84yOkVekjBQ2Nj62uO8H0RbwvSu6vw9TX3jQnh8+FhPadgGSlVHdE crSxtl7eASvZc940M/N82j5xNQprUOUnZX1BHfm1Q2Qb63U+kzNGIBctlQCOTtxFJ3Rn yRmoZQ1AKfN80yhBpDGQvYho+ePvrF+bSuseVhxVBGXqwCIQakNf1KkiK5ny3VKXx6kv Y9a/V0LX/0+6HWxIMD6Ex07Da23JNg/rno7NfQSBpNWTV3Vr7eQ2BTQD3bkeN3TI7nDX nLDsNr29IhPoEZd8DgoWOKQFkeAgz8VAJPLYOXaZOwTDobTzBdKRF3sEFBpriLZSrgNQ 012w== X-Gm-Message-State: AOAM530P8GxtrFO/OPUCdCTxciYUW3fYwlCFK7QZxchv3vpID5OJhODa 2ERwWXQABaM3a0m8RXSbmek= X-Google-Smtp-Source: ABdhPJyTpVlXUKFNyQbZ6ITAzYdrTBi92c5vkmRIDCWCay2TvL4Fzbc6jDw0XzuPSo5db5Ef9NA/GA== X-Received: by 2002:a17:902:c242:b029:d6:c58c:7fe7 with SMTP id 2-20020a170902c242b02900d6c58c7fe7mr6147931plg.51.1604769825909; Sat, 07 Nov 2020 09:23:45 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:23:45 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 07/21] wlcore: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:38 +0000 Message-Id: <20201107172152.828-8-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: f5fc0f86b02a ("wl1271: add wl1271 driver files") Fixes: bcca1bbdd412 ("wlcore: add debugfs macro to help print fw statistics arrays") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/ti/wlcore/debugfs.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ti/wlcore/debugfs.h b/drivers/net/wireless/ti/wlcore/debugfs.h index b143293e694f..559c93543247 100644 --- a/drivers/net/wireless/ti/wlcore/debugfs.h +++ b/drivers/net/wireless/ti/wlcore/debugfs.h @@ -35,6 +35,7 @@ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_ADD(name, parent) \ @@ -68,6 +69,7 @@ static const struct file_operations sub## _ ##name## _ops = { \ .read = sub## _ ##name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_FWSTATS_FILE_ARRAY(sub, name, len, struct_type) \ @@ -93,6 +95,7 @@ static const struct file_operations sub## _ ##name## _ops = { \ .read = sub## _ ##name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_FWSTATS_ADD(sub, name) \ From patchwork Sat Nov 7 17:21:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889147 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C03A214B4 for ; Sat, 7 Nov 2020 17:23:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DEB0208FE for ; Sat, 7 Nov 2020 17:23:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="vTujXt8B" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728612AbgKGRX4 (ORCPT ); Sat, 7 Nov 2020 12:23:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRXz (ORCPT ); Sat, 7 Nov 2020 12:23:55 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B062C0613CF; Sat, 7 Nov 2020 09:23:55 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id m17so1005798pjz.3; Sat, 07 Nov 2020 09:23:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gtnojxwNPLzdgmwWawXjklMOz8pCiClwWa86xyzRf48=; b=vTujXt8BiFcOi9EOhMUnqzdTeJasNXAqMzPqgawUzcNMmO7fCN8kXxYdwYhB2bebWL sip6xshqalxvWP5KIH0zyZapRxmq31FYgXr4rH4wnWrSKVTb5LtltDt+nn3wgGOvpFv1 xTf7WpRnSDDsVL+HjF+5GZ0qDBdIPngGzlvt56bI9qZgKj/9Dpx8TEnoNhhNA8WeT7C5 k0onseQ/iRFUDRdEJ5P7ZCsuntgv/lEqPYhgn7PZ39I5sXEJ9UhR3XyWIzJdM2mcU7qD DwTbx4xjba4ShoeOglg7C5TJyJuDAmpVCoNtYjHOfOSmd+3xSIOyP3GemlMwVAqWYZME Eghg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gtnojxwNPLzdgmwWawXjklMOz8pCiClwWa86xyzRf48=; b=MaNn8Er1M7+R2LoyYvv4dbZ1qhH/zMHfGYmJPkQAF1lhKR/iVM2D6FSH/TiAXbvEoE iB4xrT8/Av/2AtkJzHpJtXcwjv9/vghwgBvPq/eCGVPZ8RO/iP74dt/C5b0e0itDMUbW Or30yaLplTTPRu6ILA6yeOgds4HAfhrvKLOPbg0StAhAZFef2sTDoUqSbUa/FBBOoeXg SwVySSNOINaHGI8sZC6+XHGrNkpYiJWc5pm40ZTe61P50IXgTJxwpsDFA780X6rj+zyk SGdbLrB8/3AqmnicnZxRQWelmCr+gQYEucRldF5uwBWEsnY6Jw7zHUeri6+baVSgJFBx QpkQ== X-Gm-Message-State: AOAM531w5bYojP4BndO034re16t1M2irAd2RzB1Ndi+gQLaRQ0fYtF6K rZuAFCqlXQ4r6deJrq6HRq8= X-Google-Smtp-Source: ABdhPJwadgvZD+i+qLkY/p678kGK4NBR5zn8hdySWkJjzcB7ZlbwLPtrTPEcTBFf+kmWHek9QhxhQw== X-Received: by 2002:a17:90a:c686:: with SMTP id n6mr1318397pjt.21.1604769834982; Sat, 07 Nov 2020 09:23:54 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.23.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:23:54 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 08/21] wl1251: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:39 +0000 Message-Id: <20201107172152.828-9-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2f01a1f58889 ("wl12xx: add driver") Fixes: b7339b1de0f7 ("wl1251: add tx queue status to debugfs") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/ti/wl1251/debugfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ti/wl1251/debugfs.c b/drivers/net/wireless/ti/wl1251/debugfs.c index d48746e640cc..0a26cee0f287 100644 --- a/drivers/net/wireless/ti/wl1251/debugfs.c +++ b/drivers/net/wireless/ti/wl1251/debugfs.c @@ -35,6 +35,7 @@ static const struct file_operations name## _ops = { \ .read = name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_ADD(name, parent) \ @@ -67,6 +68,7 @@ static const struct file_operations sub## _ ##name## _ops = { \ .read = sub## _ ##name## _read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_FWSTATS_ADD(sub, name) \ @@ -212,6 +214,7 @@ static const struct file_operations tx_queue_len_ops = { .read = tx_queue_len_read, .open = simple_open, .llseek = generic_file_llseek, + .owner = THIS_MODULE, }; static ssize_t tx_queue_status_read(struct file *file, char __user *userbuf, @@ -234,6 +237,7 @@ static const struct file_operations tx_queue_status_ops = { .read = tx_queue_status_read, .open = simple_open, .llseek = generic_file_llseek, + .owner = THIS_MODULE, }; static void wl1251_debugfs_delete_files(struct wl1251 *wl) From patchwork Sat Nov 7 17:21:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889153 X-Patchwork-Delegate: luca@coelho.fi Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9E752139F for ; Sat, 7 Nov 2020 17:24:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 704C0208FE for ; Sat, 7 Nov 2020 17:24:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IHs5FQ8Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728634AbgKGRYE (ORCPT ); Sat, 7 Nov 2020 12:24:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRYE (ORCPT ); Sat, 7 Nov 2020 12:24:04 -0500 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B1CCC0613CF; Sat, 7 Nov 2020 09:24:04 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id t18so2473313plo.0; Sat, 07 Nov 2020 09:24:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=odlLroNxxuLIC09tR+IlvfwqpoNgpJyrXnvF3o9ig+c=; b=IHs5FQ8Qw9UcNwUF6BUwERkP9ilP01zbci1uGo3vKlEbwejMPeVZx+dpZ31WBpZ71u rZBmYO6YAgGikZGN4m5kTel8PjchamivCCqPIvssRLgzriudPgQ899QTwSdSOww3OrsE pBh09V6DpG5xYi322wUDwg0os0kB7Rnxd28ZE35qNLgmTMdSD+psy2r69aFg0hfvkUZB a8LyUbF4onW5UlwLN/0rndDLa5YnVbFKcmvKNOHzIi9GHrVjWqE2X9y6MhJ8oGHp6umH 9s7XHQqZHX18ZQci5Rbz3o0Auu9yadzuLsHre7VHIQw5wIJDR+SS23KQx11jxJXFtI3m KjJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=odlLroNxxuLIC09tR+IlvfwqpoNgpJyrXnvF3o9ig+c=; b=tOJ7Kzzl3CYSOGgfpXNPP7ElAKKYfjDwlyOKvKRNopKLKe/Lg/tcFlZUURNkJmBRVq lmN6c10VXSvbau5LEPJk/DHWsXbk6RvwooEQbroYp7ut39YegBCMu95I7fu6KuXkzNE0 trWm6P52BkJg+mvZ3616RKivUKEjlPJduw4FuXjUlfWBVcONsMU4kIDoi8bOlnHSNPCu wFi05LMF0nG2Sh61D+5M8imnZVq4es0a59NuyFjSUwaobW1PjAXKM3+Zo0IaN61Ikgj2 pM+IUDGCmVemJimo3uxqkTvszpleF5eMvKK3Mcm9kZt9vUd7eFJpva9Ez+yWdsE9J8cO pFng== X-Gm-Message-State: AOAM532JwkozRElZuRCRz4eKRvqcRptOFPCKACqza8VpUaoe23757bIX nNF9imxmqOK0f9k7BVdcnlM= X-Google-Smtp-Source: ABdhPJxBr/485iFpiaVQrXjQEXm46jBqhyO6DKnSZrGQ0rW8ljq9LmeLoncg9NAI/EeCEgxrYORc2g== X-Received: by 2002:a17:90b:46d7:: with SMTP id jx23mr5094196pjb.86.1604769843792; Sat, 07 Nov 2020 09:24:03 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.23.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:24:03 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 09/21] iwlwifi: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:40 +0000 Message-Id: <20201107172152.828-10-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 5ae212c9273d ("[PATCH] iwlwifi: add read rate scale table debugfs function") Fixes: 0209dc11c769 ("[PATCH] iwlwifi: add debugfs rate scale stats") Fixes: 712b6cf57a53 ("iwlwifi: Add debugfs to iwl core") Fixes: 189a2b5942d6 ("iwlwifi: trigger event log from debugfs") Fixes: 8ca151b568b6 ("iwlwifi: add the MVM driver") Fixes: 757cf23b4b4b ("iwlwifi: mvm: add per rate tx stats") Fixes: 2b55f43f8e47 ("iwlwifi: mvm: Add mem debugfs entry") Fixes: 93b167c13a3a ("iwlwifi: runtime: sync FW and host clocks for logs") Fixes: 38167459da50 ("iwlagn: show current rate scale data in debugfs") Fixes: 87e5666c0722 ("iwlagn: transport handler can register debugfs entries") Fixes: 16db88ba51d6 ("iwlagn: move dump_csr and dump_fh to transport layer") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/intel/iwlwifi/dvm/debugfs.c | 3 +++ drivers/net/wireless/intel/iwlwifi/dvm/rs.c | 3 +++ drivers/net/wireless/intel/iwlwifi/fw/debugfs.c | 3 +++ drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c | 1 + drivers/net/wireless/intel/iwlwifi/mvm/debugfs.h | 3 +++ drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 3 +++ drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 3 +++ 7 files changed, 19 insertions(+) diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/dvm/debugfs.c index 911049201838..a1022987eccf 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/debugfs.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/debugfs.c @@ -34,6 +34,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .read = iwl_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_WRITE_FILE_OPS(name) \ @@ -41,6 +42,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .write = iwl_dbgfs_##name##_write, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; @@ -50,6 +52,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .read = iwl_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; static ssize_t iwl_dbgfs_sram_read(struct file *file, diff --git a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c index 548540dd0c0f..1518dead1e47 100644 --- a/drivers/net/wireless/intel/iwlwifi/dvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/dvm/rs.c @@ -3172,6 +3172,7 @@ static const struct file_operations rs_sta_dbgfs_scale_table_ops = { .read = rs_sta_dbgfs_scale_table_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t rs_sta_dbgfs_stats_table_read(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) @@ -3215,6 +3216,7 @@ static const struct file_operations rs_sta_dbgfs_stats_table_ops = { .read = rs_sta_dbgfs_stats_table_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t rs_sta_dbgfs_rate_scale_data_read(struct file *file, @@ -3241,6 +3243,7 @@ static const struct file_operations rs_sta_dbgfs_rate_scale_data_ops = { .read = rs_sta_dbgfs_rate_scale_data_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static void rs_add_debugfs(void *priv, void *priv_sta, diff --git a/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c b/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c index 267ad4eddb5c..5f41c8587ac6 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/debugfs.c @@ -122,6 +122,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .open = _iwl_dbgfs_##name##_open, \ .llseek = generic_file_llseek, \ .release = _iwl_dbgfs_release, \ + .owner = THIS_MODULE, \ } #define FWRT_DEBUGFS_WRITE_WRAPPER(name, buflen, argtype) \ @@ -150,6 +151,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .open = _iwl_dbgfs_##name##_open, \ .llseek = generic_file_llseek, \ .release = _iwl_dbgfs_release, \ + .owner = THIS_MODULE, \ } #define _FWRT_DEBUGFS_WRITE_FILE_OPS(name, buflen, argtype) \ @@ -160,6 +162,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .open = _iwl_dbgfs_##name##_open, \ .llseek = generic_file_llseek, \ .release = _iwl_dbgfs_release, \ + .owner = THIS_MODULE, \ } #define FWRT_DEBUGFS_READ_FILE_OPS(name, bufsz) \ diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c index 3395c4675988..d4b9ef8b25ee 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.c @@ -1981,6 +1981,7 @@ static const struct file_operations iwl_dbgfs_mem_ops = { .write = iwl_dbgfs_mem_write, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; void iwl_mvm_sta_add_debugfs(struct ieee80211_hw *hw, diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.h b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.h index a83d252c0602..5bf4f7801b83 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.h +++ b/drivers/net/wireless/intel/iwlwifi/mvm/debugfs.h @@ -63,6 +63,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .read = iwl_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ } #define MVM_DEBUGFS_WRITE_WRAPPER(name, buflen, argtype) \ @@ -87,6 +88,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .read = iwl_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define _MVM_DEBUGFS_WRITE_FILE_OPS(name, buflen, argtype) \ @@ -95,4 +97,5 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .write = _iwl_dbgfs_##name##_write, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index ed7382e7ea17..853c3969c956 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c @@ -3909,6 +3909,7 @@ static const struct file_operations rs_sta_dbgfs_scale_table_ops = { .read = rs_sta_dbgfs_scale_table_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t rs_sta_dbgfs_stats_table_read(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) @@ -3956,6 +3957,7 @@ static const struct file_operations rs_sta_dbgfs_stats_table_ops = { .read = rs_sta_dbgfs_stats_table_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t rs_sta_dbgfs_drv_tx_stats_read(struct file *file, @@ -4046,6 +4048,7 @@ static const struct file_operations rs_sta_dbgfs_drv_tx_stats_ops = { .write = rs_sta_dbgfs_drv_tx_stats_write, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t iwl_dbgfs_ss_force_read(struct file *file, diff --git a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c index d2e69ad53b27..250b7883703c 100644 --- a/drivers/net/wireless/intel/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/intel/iwlwifi/pcie/trans.c @@ -2476,6 +2476,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .read = iwl_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_WRITE_FILE_OPS(name) \ @@ -2483,6 +2484,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .write = iwl_dbgfs_##name##_write, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_READ_WRITE_FILE_OPS(name) \ @@ -2491,6 +2493,7 @@ static const struct file_operations iwl_dbgfs_##name##_ops = { \ .read = iwl_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; struct iwl_dbgfs_tx_queue_priv { From patchwork Sat Nov 7 17:21:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889157 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 349CA139F for ; Sat, 7 Nov 2020 17:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14B26208FE for ; Sat, 7 Nov 2020 17:24:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p/Wt5kBe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728648AbgKGRYN (ORCPT ); Sat, 7 Nov 2020 12:24:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40340 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRYN (ORCPT ); Sat, 7 Nov 2020 12:24:13 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24736C0613CF; Sat, 7 Nov 2020 09:24:13 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id u2so2452661pls.10; Sat, 07 Nov 2020 09:24:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=s1LNEKUScgxop0eLZewEZfCrayhJikCFppuZBt54gvA=; b=p/Wt5kBeDfH3ajleUhl3tkKcpb3mI5osB6IOB3ny6/tUOl9K2gYz9jo3xduJtNpzxA CjuPrXjJPXJsfnUWDAHmtPChTNANUZp2ag9m3y8PX6qTKPIGuhlKZ8NznODaJ1GayAlg pxr0+XvpEoBBs22sSRLHi2SzTiSbk+uhTMNfPq1nxGnBy3iw00e7nIx4KOHFCBFH2JVZ ykgSUJ105T0DiI3Upg78QBT4WNNZ+lQWWe3bpa6kCC3dnMItOfyty80xUpC+fSkut1vU TuTeC2PBosHW7f0zDScBFmS3wX6knlTlF78CIzjQ4ItcjslBw7N0j3TuXwTrk4QsDBaU HiWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=s1LNEKUScgxop0eLZewEZfCrayhJikCFppuZBt54gvA=; b=UdPR7uYErxOifnnQBgNcCxCHCe+UhlIvmdtl7clhNxEBqlqYIfXNZkqxF13HTi/E7Q VP2Bfj4+aFLwOh2XkrSCGqIbSA9+lI5In0VWAzGrLLAW3B75a2znUOEgXgRtWNY2rJv1 kOHdekA8tEO6Mb12g/VvBnIZXaHSKLd8Dxo210A5uJITsmX3uux73NRNHlG30Vf4Glrx ztJTh/KkZzchwoNghJynRKuStjNp8j+ii2NidKhDT5VBoH/gTCMaEDRGA6WOALN38ZNl OmofTCztdbYflG7oDJ7yDFoK125ApO1ruKjV/AB9RNVwX24YmCsOVN8EXCN3P0oElS5e qtXg== X-Gm-Message-State: AOAM531j1Px8dUejXqj/GXXSch6pbxXQKsx1ZKpVP3cwx3ZU2DufQDXn HzW3nI/g8KzrmsbERFuHL4w= X-Google-Smtp-Source: ABdhPJxqw+ukXLR9L1J0ECgPqV3whGl+KagDxNK7Wrnq1QhY+2NRbUAnVfriBcV53gFDFQ8jk5Sx3Q== X-Received: by 2002:a17:90a:d70d:: with SMTP id y13mr5197661pju.138.1604769852694; Sat, 07 Nov 2020 09:24:12 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:24:11 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 10/21] iwlegacy: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:41 +0000 Message-Id: <20201107172152.828-11-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: be663ab67077 ("iwlwifi: split the drivers for agn and legacy devices 3945/4965") Fixes: 4bc85c1324aa ("Revert "iwlwifi: split the drivers for agn and legacy devices 3945/4965"") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/intel/iwlegacy/3945-rs.c | 1 + drivers/net/wireless/intel/iwlegacy/4965-rs.c | 3 +++ drivers/net/wireless/intel/iwlegacy/debug.c | 3 +++ 3 files changed, 7 insertions(+) diff --git a/drivers/net/wireless/intel/iwlegacy/3945-rs.c b/drivers/net/wireless/intel/iwlegacy/3945-rs.c index b2478cbe558e..b86e8ddc6f76 100644 --- a/drivers/net/wireless/intel/iwlegacy/3945-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/3945-rs.c @@ -836,6 +836,7 @@ static const struct file_operations rs_sta_dbgfs_stats_table_ops = { .read = il3945_sta_dbgfs_stats_table_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static void diff --git a/drivers/net/wireless/intel/iwlegacy/4965-rs.c b/drivers/net/wireless/intel/iwlegacy/4965-rs.c index 9a491e5db75b..afe0b2121fc9 100644 --- a/drivers/net/wireless/intel/iwlegacy/4965-rs.c +++ b/drivers/net/wireless/intel/iwlegacy/4965-rs.c @@ -2669,6 +2669,7 @@ static const struct file_operations rs_sta_dbgfs_scale_table_ops = { .read = il4965_rs_sta_dbgfs_scale_table_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t @@ -2714,6 +2715,7 @@ static const struct file_operations rs_sta_dbgfs_stats_table_ops = { .read = il4965_rs_sta_dbgfs_stats_table_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t @@ -2742,6 +2744,7 @@ static const struct file_operations rs_sta_dbgfs_rate_scale_data_ops = { .read = il4965_rs_sta_dbgfs_rate_scale_data_read, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static void diff --git a/drivers/net/wireless/intel/iwlegacy/debug.c b/drivers/net/wireless/intel/iwlegacy/debug.c index d998a3f1b056..67fae353038c 100644 --- a/drivers/net/wireless/intel/iwlegacy/debug.c +++ b/drivers/net/wireless/intel/iwlegacy/debug.c @@ -136,6 +136,7 @@ static const struct file_operations il_dbgfs_##name##_ops = { \ .read = il_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_WRITE_FILE_OPS(name) \ @@ -144,6 +145,7 @@ static const struct file_operations il_dbgfs_##name##_ops = { \ .write = il_dbgfs_##name##_write, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; #define DEBUGFS_READ_WRITE_FILE_OPS(name) \ @@ -154,6 +156,7 @@ static const struct file_operations il_dbgfs_##name##_ops = { \ .read = il_dbgfs_##name##_read, \ .open = simple_open, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }; static const char * From patchwork Sat Nov 7 17:21:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889161 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F029139F for ; Sat, 7 Nov 2020 17:24:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5162D208FE for ; Sat, 7 Nov 2020 17:24:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="t3WXp1HV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728660AbgKGRYW (ORCPT ); Sat, 7 Nov 2020 12:24:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRYW (ORCPT ); Sat, 7 Nov 2020 12:24:22 -0500 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E5A0C0613CF; Sat, 7 Nov 2020 09:24:22 -0800 (PST) Received: by mail-pj1-x1043.google.com with SMTP id ie6so1005932pjb.0; Sat, 07 Nov 2020 09:24:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=LTccE1+gUeumxbUvALN/1mz2k95a4c5mP+1xBzNvmSA=; b=t3WXp1HVaKnHEqw8q4P9s4M90USGPzdfKvxRFHNYV50aBa+Kbi3I81koFX7YXlZFLX XWLg/Hn2PYNC/W9Xl0lmXe4tAuNqEpKlvzUcmEMMvrtsynsKg3vaOOJZs0W+kLvz21UD 3bXVhTMUgWzAJCiJLEmWxxYSG0M/w4xP2WTdUWZKnH9/8/W/7drgRZk/yI1EpHSgE6NT +TtlvV4uDEI3MttYGN9Apuz9/CZvuF/W6lKEEV/m5GYlmkgb1PLLVrrI+YXkw/LTkFYJ IjfbkSb1c2ueJoI5fvlMwUySjYMv8Pu9QJfaVb0XQsJ1BwDt0pH7/fqeCw3eCJYcQKUc RAeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=LTccE1+gUeumxbUvALN/1mz2k95a4c5mP+1xBzNvmSA=; b=IXhGQZAUIIZoMFhpEVm7VDDv25QmF2NNNdA8IK/8uxRVfqOSsSgVW7maN9++5e1axi dhZChIBMCtyLzs1pmtU8AFr8u+VXXhewC6+mUhj+WiBb8iu4ShbDz9y6V1XZuN/1frgH rlHBMEoBZkYgNW3OsnOLzdWMrFFhLIYvX6FZOzVYAmF7uh+rDj/iLsNW/xjjcVGrFyWT wn47PzhL4iYGU1UKSFg2f6jx27c9IBDPVZeMCULHKkhQOTVH8uCAC7hmx2F0BUmF4Zka qMpJGCX4N/c2znqZNIKkBaJgfMSLhEjFtk2uWlhKbmqnMxLd0m2nV7W+jpK2KqMQo61/ mPDg== X-Gm-Message-State: AOAM531+1evWxDXASpZhN3dzuhsuoIgo3nr/YMfXOYVXYtALn6ez8eO8 ClLoFcEnU2lEWsBqG9wRdYw= X-Google-Smtp-Source: ABdhPJypssb+RhiIwdqmIq77IQAElHx5NidaTxAEf0XWbEdXpAjQsixVWCJL75CcDoiB41K8dajdsA== X-Received: by 2002:a17:902:ec03:b029:d7:c7c2:145a with SMTP id l3-20020a170902ec03b02900d7c7c2145amr4521075pld.33.1604769861649; Sat, 07 Nov 2020 09:24:21 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.24.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:24:20 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 11/21] rtlwifi: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:42 +0000 Message-Id: <20201107172152.828-12-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wireless/realtek/rtlwifi/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c b/drivers/net/wireless/realtek/rtlwifi/debug.c index 901cdfe3723c..c8ffd4ca9c09 100644 --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -69,6 +69,7 @@ static const struct file_operations file_ops_common = { .read = seq_read, .llseek = seq_lseek, .release = single_release, + .owner = THIS_MODULE, }; static int rtl_debug_get_mac_page(struct seq_file *m, void *v) From patchwork Sat Nov 7 17:21:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889165 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A56B714B4 for ; Sat, 7 Nov 2020 17:24:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8AF08208FE for ; Sat, 7 Nov 2020 17:24:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JX3RDgq4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728691AbgKGRYb (ORCPT ); Sat, 7 Nov 2020 12:24:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRYb (ORCPT ); Sat, 7 Nov 2020 12:24:31 -0500 Received: from mail-pj1-x1041.google.com (mail-pj1-x1041.google.com [IPv6:2607:f8b0:4864:20::1041]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF647C0613CF; Sat, 7 Nov 2020 09:24:30 -0800 (PST) Received: by mail-pj1-x1041.google.com with SMTP id gi3so1013101pjb.3; Sat, 07 Nov 2020 09:24:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VRJReBusLJDdL7VrPK2tUmMmHMsSMNbu46+dvffJ4Ng=; b=JX3RDgq4wVWW6aZoTEcAdTgVaXjdLHYVWICv2dc7uEKWFBPxZ0vITqHuB++9M2NMIZ UTv0nLdFmvCVg+UQNTJ8Vp0tHSR7XhkAXqDi66jFnX1+xN8sabT+kEtshoMB0BS9xshn Kedr/a4Uijjfh/dbSlRtNOoiGKGwaJ58jbxT37hoI5my3VKiHOeiF6XMXD6lfE2oo1Tw iO9mEA4hTKvqD9yWME4qJRAlL81L0110C90QTz+ghmMyXSdVh/xDiwzSm65q7ydAcq4g 6yRDneyw5UCmVlvbhm9GJLgO0+4u6bLgT1iAmROYGBmZqku6H37fj4WH86qK41Mw3EO8 KjGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VRJReBusLJDdL7VrPK2tUmMmHMsSMNbu46+dvffJ4Ng=; b=GQn0arZMD9nmAfXQHD+lssvvkl/PIe+Vofp4oqVkoLCivy3NIi4f7lPU0qR1qP2PZT K/C0NeNoLesAc4qY5lHCgubSpS4xzJL3z3P385ddwvlO5v24CFVXQY+0yD91mwojy97L dz78C+L9bNF6+bjp8Z6VFTH6yROeud2C2HvHyUIPSg7oSajNsGqz73WiY/w1O/hE9u2y VsctWrlxSkzbtJI/JvOchTSq/bt/ZFoLxK8t73ffTRim8ybcPSB6vJ4yrlo5Rx51Kapz KW7DovUIwJNRV8QWF7VP7r9W7T3UUxf0iDty05GKyTeVEr8kNyGTOMxsCFhQ0vSk+YiN gn+g== X-Gm-Message-State: AOAM530a+nT5Zk0m+UeQEMJ7noQolrL1Rd9bkOLhRF1EBTVF65tAJhsY ofBT28JpOaXrYOxr3x6Cego= X-Google-Smtp-Source: ABdhPJxqit/zAbNV9BUSu85bevXj9bYGcoVd7LeOdaB86aHpNM7QsRGbVKGp6HnpZUgxugHd6l6zCw== X-Received: by 2002:a17:90a:b393:: with SMTP id e19mr4974472pjr.40.1604769870452; Sat, 07 Nov 2020 09:24:30 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:24:29 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 12/21] ath11k: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:43 +0000 Message-Id: <20201107172152.828-13-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/ath/ath11k/debugfs.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/debugfs.c b/drivers/net/wireless/ath/ath11k/debugfs.c index 1b914e67d314..bce9f9512833 100644 --- a/drivers/net/wireless/ath/ath11k/debugfs.c +++ b/drivers/net/wireless/ath/ath11k/debugfs.c @@ -593,7 +593,8 @@ static ssize_t ath11k_read_enable_extd_tx_stats(struct file *file, static const struct file_operations fops_extd_tx_stats = { .read = ath11k_read_enable_extd_tx_stats, .write = ath11k_write_enable_extd_tx_stats, - .open = simple_open + .open = simple_open, + .owner = THIS_MODULE, }; static ssize_t ath11k_write_extd_rx_stats(struct file *file, @@ -686,6 +687,7 @@ static const struct file_operations fops_extd_rx_stats = { .read = ath11k_read_extd_rx_stats, .write = ath11k_write_extd_rx_stats, .open = simple_open, + .owner = THIS_MODULE, }; static int ath11k_fill_bp_stats(struct ath11k_base *ab, @@ -1047,7 +1049,8 @@ static ssize_t ath11k_write_simulate_radar(struct file *file, static const struct file_operations fops_simulate_radar = { .write = ath11k_write_simulate_radar, - .open = simple_open + .open = simple_open, + .owner = THIS_MODULE, }; int ath11k_debugfs_register(struct ath11k *ar) From patchwork Sat Nov 7 17:21:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889169 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 52C0A139F for ; Sat, 7 Nov 2020 17:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 32D9621D81 for ; Sat, 7 Nov 2020 17:24:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Q7hLYJCP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728697AbgKGRYk (ORCPT ); Sat, 7 Nov 2020 12:24:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726364AbgKGRYj (ORCPT ); Sat, 7 Nov 2020 12:24:39 -0500 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2BAFC0613CF; Sat, 7 Nov 2020 09:24:39 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id b12so2466414plr.4; Sat, 07 Nov 2020 09:24:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4+aAtgXDYqySZiqkd4LH9+itS3gTV5MK5an12cOAgbw=; b=Q7hLYJCPIgsT59lxTt9zeO6RYC2+dwg7ulaDUytCRoqpD0R+OmQxzzdPGZXdKDH70t ZL7Fh1+wL7kcQOnLqVaTEx1jVp6AdZswPySyMpuWgupV2ALz49JvcXuz+cJXSEnoCfXz r6FnDpvmq4vSsgURIUtJPnqT0+vDa0fzN0D3HqtxDoPsTt/XvJnNz5Tu5yuLyOztZfkU SKomJDDOCxeLHJA43dBhgNs66xzmq9Pf8Hbc1ipb9df6iz/bDuqdxqjOts/+5cs7gwdu Ohzv5shxfgWOCE5wAbCVXP4gM/Fmplmi4I6ej3saMlvonM2OkAWNTXocb8g3809PYY6N MpSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4+aAtgXDYqySZiqkd4LH9+itS3gTV5MK5an12cOAgbw=; b=lKE64/Rct6DZA0u7gg/MvZ8WvlFQWYTbjSo6/vIuMUfTRKdufUrzAtmEPsbPLqPBQy RpeE69uFys69yU9M0x9LretY4AW4X7J/VXoYtnl3Ln7zhKGS6tPrBKfpZySEi4nX4GBn JOBxZIlwH1yuzSqjaxCo5VhsvIcRx7wsyrAcVO8IyFIVtiVk/axRgv3uZSguR81X5RFI aRzVg2d27L9fmEfAYkV6L3xMB+ZHjmICE2MdJm1H++z5EU1UQ/ACj82rcnKlHIi0wpeJ 0ASYL0MYXXY1rkXGiVSxZS2S0gzw4omzoSBRn8e0D2a2ItCij2vIiYeJ9954cnI6FqaH aMIw== X-Gm-Message-State: AOAM531N/OrV2XbaABakT20y20l+RAt1W8QtrnAs8tmklQYRzx9hSo+J JPC6yI3b9sOJdvMB3qdz84U= X-Google-Smtp-Source: ABdhPJyHgpbU5ya1bMlCna6kWX13dnAwHbmM9yXtj4YB8SiJpxFmsgoAV0DwmDwRUxkOH802YCLe6Q== X-Received: by 2002:a17:902:9347:b029:d3:7c08:86c6 with SMTP id g7-20020a1709029347b02900d37c0886c6mr6028323plp.84.1604769879429; Sat, 07 Nov 2020 09:24:39 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:24:38 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 13/21] ath10k: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:44 +0000 Message-Id: <20201107172152.828-14-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 90174455ae05 ("ath10k: add support to configure pktlog filter") Fixes: 63fb32df9786 ("ath10k: add debugfs entry to configure quiet period") Fixes: 844fa5722712 ("ath10k: debugfs file to enable Bluetooth coexistence feature") Fixes: 348cd95c8196 ("ath10k: add debugfs entry to enable extended tx stats") Fixes: cc61a1bbbc0e ("ath10k: enable debugfs provision to enable Peer Stats feature") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/ath/ath10k/debug.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index e8250a665433..afde3d8048e8 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -1911,7 +1911,8 @@ static ssize_t ath10k_read_pktlog_filter(struct file *file, char __user *ubuf, static const struct file_operations fops_pktlog_filter = { .read = ath10k_read_pktlog_filter, .write = ath10k_write_pktlog_filter, - .open = simple_open + .open = simple_open, + .owner = THIS_MODULE, }; static ssize_t ath10k_write_quiet_period(struct file *file, @@ -1955,7 +1956,8 @@ static ssize_t ath10k_read_quiet_period(struct file *file, char __user *ubuf, static const struct file_operations fops_quiet_period = { .read = ath10k_read_quiet_period, .write = ath10k_write_quiet_period, - .open = simple_open + .open = simple_open, + .owner = THIS_MODULE, }; static ssize_t ath10k_write_btcoex(struct file *file, @@ -2039,7 +2041,8 @@ static ssize_t ath10k_read_btcoex(struct file *file, char __user *ubuf, static const struct file_operations fops_btcoex = { .read = ath10k_read_btcoex, .write = ath10k_write_btcoex, - .open = simple_open + .open = simple_open, + .owner = THIS_MODULE, }; static ssize_t ath10k_write_enable_extd_tx_stats(struct file *file, @@ -2094,7 +2097,8 @@ static ssize_t ath10k_read_enable_extd_tx_stats(struct file *file, static const struct file_operations fops_enable_extd_tx_stats = { .read = ath10k_read_enable_extd_tx_stats, .write = ath10k_write_enable_extd_tx_stats, - .open = simple_open + .open = simple_open, + .owner = THIS_MODULE, }; static ssize_t ath10k_write_peer_stats(struct file *file, @@ -2163,7 +2167,8 @@ static ssize_t ath10k_read_peer_stats(struct file *file, char __user *ubuf, static const struct file_operations fops_peer_stats = { .read = ath10k_read_peer_stats, .write = ath10k_write_peer_stats, - .open = simple_open + .open = simple_open, + .owner = THIS_MODULE, }; static ssize_t ath10k_debug_fw_checksums_read(struct file *file, From patchwork Sat Nov 7 17:21:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889171 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A3E58139F for ; Sat, 7 Nov 2020 17:24:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 88F8D21D81 for ; Sat, 7 Nov 2020 17:24:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XxLft7tJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728719AbgKGRYt (ORCPT ); Sat, 7 Nov 2020 12:24:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40446 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728437AbgKGRYs (ORCPT ); Sat, 7 Nov 2020 12:24:48 -0500 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB6AFC0613CF; Sat, 7 Nov 2020 09:24:48 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id u2so2453086pls.10; Sat, 07 Nov 2020 09:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=j3U/F8uus8D2VmGNE2iflYbt9gsiy2OiJvdrE0/Jxbw=; b=XxLft7tJJHuO3S5/3wyY3iyfuIcjJUSdfbNTN9swZLFRNhAwK2l4perpw9C99pFH2w KVeC0ozurFEkrDVf7uX+li+t8S2XCPx6pe+xqyGkITyztLMHxjZu4I153FHlsv9UDag4 b8AYHQvtg2zfSyfWm4vVSfluQbYv/qIpVeDADaRK98y2d1JZ0JUomZ0T9ir4Ts4bi/Ny P/6dsm7Jf9HQV6qYl1rWBdZwl7QLv86/BoCJD0QBhBMrW1+qxtc/AyIM0bGM7kXJ9w72 nQ7fVuIomnf1XL1jRu6QIJlJ9KFS1DxXga0SvjGIbTeI1sXjZfByW8hA33OQE5TlWIfH McvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=j3U/F8uus8D2VmGNE2iflYbt9gsiy2OiJvdrE0/Jxbw=; b=g+4LIAEzOx3jY0oAA0zkmmNF9YMe//y/CN5lSYSt6f4trqyO8h9YWRNYAoSAVtqleK pZP6B+VkQb6rvFieuW8gzt+AvxPgojsok7ozKnA2DV4BZY3gvhY8bhvpyhTVOSOqcp7v jBLBtzpUvM2gnnmTFDmEqUtkEDupSBpBfystIRWJqle69eEdw5zABWvpwkHHdejb2c04 Is8pcEzQzZ4lua6GuRP0qj/onpVBsGN1Dds+XNKfdnbDTD7HZd/ScOVufF5+RjDncVCD VR2xYds87FOo5VVGlVeWcT2e9XsoqYJyLbx/60VFqyNgKif++AXPvCiu+C68cfBfSGlF yWGA== X-Gm-Message-State: AOAM5335NMhU1x/znaWoIu3M2S4HK+UD6Z+NccwGThZv7l/3W3QFAdrT pRCtTUt/k7HVn/9Wuc3sRjg= X-Google-Smtp-Source: ABdhPJzOfbtwy6lEwUmmYTWQU/LyE+zhYE8cw9yQdTt/PqZ5TcHQfIUME/P9AKa4Ma9Q/rGLBPq4RQ== X-Received: by 2002:a17:90a:8906:: with SMTP id u6mr5116979pjn.35.1604769888278; Sat, 07 Nov 2020 09:24:48 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.24.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:24:47 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 14/21] wcn36xx: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:45 +0000 Message-Id: <20201107172152.828-15-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/ath/wcn36xx/debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/wireless/ath/wcn36xx/debug.c b/drivers/net/wireless/ath/wcn36xx/debug.c index 389b5e7129a6..4b78be5c67e8 100644 --- a/drivers/net/wireless/ath/wcn36xx/debug.c +++ b/drivers/net/wireless/ath/wcn36xx/debug.c @@ -93,6 +93,7 @@ static const struct file_operations fops_wcn36xx_bmps = { .open = simple_open, .read = read_file_bool_bmps, .write = write_file_bool_bmps, + .owner = THIS_MODULE, }; static ssize_t write_file_dump(struct file *file, @@ -134,6 +135,7 @@ static ssize_t write_file_dump(struct file *file, static const struct file_operations fops_wcn36xx_dump = { .open = simple_open, .write = write_file_dump, + .owner = THIS_MODULE, }; #define ADD_FILE(name, mode, fop, priv_data) \ From patchwork Sat Nov 7 17:21:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889205 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 364A7139F for ; Sat, 7 Nov 2020 17:25:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1440B208FE for ; Sat, 7 Nov 2020 17:25:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pUNoC673" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728730AbgKGRY6 (ORCPT ); Sat, 7 Nov 2020 12:24:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728437AbgKGRY6 (ORCPT ); Sat, 7 Nov 2020 12:24:58 -0500 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2498C0613CF; Sat, 7 Nov 2020 09:24:57 -0800 (PST) Received: by mail-pf1-x442.google.com with SMTP id z3so4414813pfb.10; Sat, 07 Nov 2020 09:24:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=R8MHn27XTX9uCiH/plMskXmmEPSmK7f2PWuf8/OR+AU=; b=pUNoC673i2WYSbCl0jbt9pCvBg26oiu+f0tyKdcFmV6zq/aN99b+xI+aaNhT1CXQIl qXc/7OlhFBeMVo/yqdz9o6G0xJBqIB4kkxmid/9QP9amDKRpZ1My4jFUUHBbUbXI3SXw JJAcjXn4u7UcHyXvKKLPjlqWqDdjWQ2iTTwhC2hjP20nnqhMwwgKw/O/RBuofvxrYd4/ zCFJ1tb7WgOV0M5GcTFX4EcooXtEk2ELFdlgAUFUSCM7P1LEEBrRdGZTwNy8rwtmF1t9 FGgoeJfh1SgmLhOvhX31q/Hyq6YNewUYNrFZyibVcnMcxBOyxOEu+3suF8qNmf+tJ3kx LZ4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=R8MHn27XTX9uCiH/plMskXmmEPSmK7f2PWuf8/OR+AU=; b=d8mxEN8yyTmuBhPSQhsgzQZfsUUguiRvjm2LoES+rgCewxVbsIDw8JYOHtHf3dAjrw J5zJtOxzCPwBcQ3PJxJTs9Lr0EjCfLA4ixrtqrl66XixE/kh1NCRW9HTmXX4Yg5Z6u6I YIsriCFGtl+sBLsT60nS3Wi4k+07pwdfQYKd7nTEcAbXQRdw5h2xbm/nMD9Jsah5/kmZ EC1DBaHZ8Qm3imB+UQWjHJ2duKQe9FM8SXyTHMGI/mvfVXr8YOZzpvRcE2edxkzea0Jp d9KoPB3m+BjfoWlEn5Aa1PeyRAKdQT+5gXVzKrB94BeBEKC1kwWA/k8V+WK8o4GkvmvH R74g== X-Gm-Message-State: AOAM530zqw5QER62zLPv5U2RMlI1nFI5SFCJ9ATeD4Q0erASrOYevaH9 1wlp2nfcL9ceDLvOPZC24/k= X-Google-Smtp-Source: ABdhPJy92yRleIaEQ5hiH+RyR1slGmITH9Z4dpShgnssfYQTYJ49kuylD+nc3doX3ybGbLPNcJDl5Q== X-Received: by 2002:a63:1103:: with SMTP id g3mr6488347pgl.48.1604769897225; Sat, 07 Nov 2020 09:24:57 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.24.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:24:56 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 15/21] wil6210: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:46 +0000 Message-Id: <20201107172152.828-16-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2be7d22f0625 ("wireless: add new wil6210 802.11ad 60GHz driver") Fixes: 0b39aaf2f203 ("wil6210: Tx mgmt frame from debugfs") Fixes: c5b3a6582b1e ("wil6210: Add support for setting RBUFCAP configuration") Fixes: 3277213feb1b ("wil6210: ADDBA/DELBA flows") Fixes: dc16427bbe65 ("wil6210: Add pmc debug mechanism memory management") Fixes: 977c45ab5f41 ("wil6210: add debugfs to show PMC ring content") Fixes: ff974e408334 ("wil6210: debugfs interface to send raw WMI command") Fixes: c33407a8c504 ("wil6210: manual FW error recovery mode") Fixes: a24a3d6abb97 ("wil6210: add TX latency statistics") Fixes: 0c936b3c9633 ("wil6210: add support for link statistics") Fixes: 10d599ad84a1 ("wil6210: add support for device led configuration") Fixes: 12bace75704e ("wil6210: extract firmware capabilities from FW file") Fixes: 13cd9f758a55 ("wil6210: extract firmware version from file header") Fixes: fe9ee51e6a43 ("wil6210: add support for PCIe D3hot in system suspend") Fixes: 96c93589e2df ("wil6210: initialize TX and RX enhanced DMA rings") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/ath/wil6210/debugfs.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/net/wireless/ath/wil6210/debugfs.c b/drivers/net/wireless/ath/wil6210/debugfs.c index 2d618f90afa7..799493739771 100644 --- a/drivers/net/wireless/ath/wil6210/debugfs.c +++ b/drivers/net/wireless/ath/wil6210/debugfs.c @@ -678,6 +678,7 @@ static const struct file_operations fops_ioblob = { .read = wil_read_file_ioblob, .open = simple_open, .llseek = default_llseek, + .owner = THIS_MODULE, }; static @@ -729,6 +730,7 @@ static ssize_t wil_write_file_rxon(struct file *file, const char __user *buf, static const struct file_operations fops_rxon = { .write = wil_write_file_rxon, .open = simple_open, + .owner = THIS_MODULE, }; static ssize_t wil_write_file_rbufcap(struct file *file, @@ -767,6 +769,7 @@ static ssize_t wil_write_file_rbufcap(struct file *file, static const struct file_operations fops_rbufcap = { .write = wil_write_file_rbufcap, .open = simple_open, + .owner = THIS_MODULE, }; /* block ack control, write: @@ -865,6 +868,7 @@ static const struct file_operations fops_back = { .read = wil_read_back, .write = wil_write_back, .open = simple_open, + .owner = THIS_MODULE, }; /* pmc control, write: @@ -941,12 +945,14 @@ static const struct file_operations fops_pmccfg = { .read = wil_read_pmccfg, .write = wil_write_pmccfg, .open = simple_open, + .owner = THIS_MODULE, }; static const struct file_operations fops_pmcdata = { .open = simple_open, .read = wil_pmc_read, .llseek = wil_pmc_llseek, + .owner = THIS_MODULE, }; static int wil_pmcring_seq_open(struct inode *inode, struct file *file) @@ -959,6 +965,7 @@ static const struct file_operations fops_pmcring = { .release = single_release, .read = seq_read, .llseek = seq_lseek, + .owner = THIS_MODULE, }; /*---tx_mgmt---*/ @@ -996,6 +1003,7 @@ static ssize_t wil_write_file_txmgmt(struct file *file, const char __user *buf, static const struct file_operations fops_txmgmt = { .write = wil_write_file_txmgmt, .open = simple_open, + .owner = THIS_MODULE, }; /* Write WMI command (w/o mbox header) to this file to send it @@ -1039,6 +1047,7 @@ static ssize_t wil_write_file_wmi(struct file *file, const char __user *buf, static const struct file_operations fops_wmi = { .write = wil_write_file_wmi, .open = simple_open, + .owner = THIS_MODULE, }; static void wil_seq_print_skb(struct seq_file *s, struct sk_buff *skb) @@ -1558,6 +1567,7 @@ static const struct file_operations fops_recovery = { .read = wil_read_file_recovery, .write = wil_write_file_recovery, .open = simple_open, + .owner = THIS_MODULE, }; /*---------Station matrix------------*/ @@ -1836,6 +1846,7 @@ static const struct file_operations fops_tx_latency = { .read = seq_read, .write = wil_tx_latency_write, .llseek = seq_lseek, + .owner = THIS_MODULE, }; static void wil_link_stats_print_basic(struct wil6210_vif *vif, @@ -1999,6 +2010,7 @@ static const struct file_operations fops_link_stats = { .read = seq_read, .write = wil_link_stats_write, .llseek = seq_lseek, + .owner = THIS_MODULE, }; static int @@ -2053,6 +2065,7 @@ static const struct file_operations fops_link_stats_global = { .read = seq_read, .write = wil_link_stats_global_write, .llseek = seq_lseek, + .owner = THIS_MODULE, }; static ssize_t wil_read_file_led_cfg(struct file *file, char __user *user_buf, @@ -2100,6 +2113,7 @@ static const struct file_operations fops_led_cfg = { .read = wil_read_file_led_cfg, .write = wil_write_file_led_cfg, .open = simple_open, + .owner = THIS_MODULE, }; /* led_blink_time, write: @@ -2165,6 +2179,7 @@ static const struct file_operations fops_led_blink_time = { .read = wil_read_led_blink_time, .write = wil_write_led_blink_time, .open = simple_open, + .owner = THIS_MODULE, }; /*---------FW capabilities------------*/ @@ -2189,6 +2204,7 @@ static const struct file_operations fops_fw_capabilities = { .release = single_release, .read = seq_read, .llseek = seq_lseek, + .owner = THIS_MODULE, }; /*---------FW version------------*/ @@ -2215,6 +2231,7 @@ static const struct file_operations fops_fw_version = { .release = single_release, .read = seq_read, .llseek = seq_lseek, + .owner = THIS_MODULE, }; /*---------suspend_stats---------*/ @@ -2275,6 +2292,7 @@ static const struct file_operations fops_suspend_stats = { .read = wil_read_suspend_stats, .write = wil_write_suspend_stats, .open = simple_open, + .owner = THIS_MODULE, }; /*---------compressed_rx_status---------*/ @@ -2329,6 +2347,7 @@ static const struct file_operations fops_compressed_rx_status = { .read = seq_read, .write = wil_compressed_rx_status_write, .llseek = seq_lseek, + .owner = THIS_MODULE, }; /*----------------*/ From patchwork Sat Nov 7 17:21:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889209 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 31540139F for ; Sat, 7 Nov 2020 17:25:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15154208FE for ; Sat, 7 Nov 2020 17:25:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gcXi/Nxl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728752AbgKGRZH (ORCPT ); Sat, 7 Nov 2020 12:25:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728437AbgKGRZG (ORCPT ); Sat, 7 Nov 2020 12:25:06 -0500 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BC3BC0613CF; Sat, 7 Nov 2020 09:25:06 -0800 (PST) Received: by mail-pj1-x1042.google.com with SMTP id w7so1007936pjy.1; Sat, 07 Nov 2020 09:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6NEkJsCiyEXeyvYU2Km3eijMSDhBwKPdqNY1wwXuuTc=; b=gcXi/Nxl6mkjZ5c+J0NgVW8x5zzRctDLMZdPNpEVCH0QBXXOy0JOes0z1ZXgQ5kY/K BWzjhxu+rriFvMIuZoS+XO7zvPY4Yh8cZjrRrkUbRvI3DdGodmSHZHMkoaVKvn+Pz9oO esm36yqExYQfy3LOScKMrwD9Cy4hCzXUELRvWd2g3b9D5b/cq2cGW1glbgSH74H1IXxh 5zQCnDL4g86qnjORrd9V//kmZSubaI7aiUh2gFOJEDd0w3zq3Tjns9A3IvBLFRZcomM4 YCft1zQh/N9t6CuJfuhiRM4Y+eUgCg/1rqCdynnr3c1K1riSoZsYP+PrwTcgdjCMAeRz Gstg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6NEkJsCiyEXeyvYU2Km3eijMSDhBwKPdqNY1wwXuuTc=; b=jnntXOecETwJ9+E5Pv+9OoP+ZTIDs5DPdIKa5Fs/rVkHR4Aff7yiM3TYxK1R+Cc/Gg 7EL87VqjJbzsitR2hOyhNgf+Xdi1zPEuCx6R6HIQpkLO74pwLknbAOCnjO64XSkYeFVe VU2ZKJrAhhBsp3rIjN1dEMg7Y5AntfVuVtyXM2U7ffpP6hemBEEHnaUyTMdHk+WMWPut TkiqL2Q6x4B2uSOUsbfuakF+WuCuzcJSa4oaV8HtF60Y4iLvv3q9IavpBrDwSScVykGU bem9qyPwlECmxTXty7jWglyd9xk9QP4dHYtduhNAaOiWBV1fWcRqE6gNieTkR/xs/9Vs icaA== X-Gm-Message-State: AOAM533EseoC1KPGKqjgEa2YIQYdSSHQwHJkx1xsc1/Ndt+Pi3vJXsrC qhQYtJukxBgnMBkLOJHwf9k= X-Google-Smtp-Source: ABdhPJyRLHKYTsDtz5wqN37i7lr22hS/6sJhIGcoGC7rNLCoKvrEmuIkLa4K5QCNoQJfKLQvYvh0Wg== X-Received: by 2002:a17:902:8502:b029:d5:b4f4:8555 with SMTP id bj2-20020a1709028502b02900d5b4f48555mr6117232plb.76.1604769906070; Sat, 07 Nov 2020 09:25:06 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:25:05 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 16/21] cw1200: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:47 +0000 Message-Id: <20201107172152.828-17-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: a910e4a94f69 ("cw1200: add driver for the ST-E CW1100 & CW1200 WLAN chipsets") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wireless/st/cw1200/debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/st/cw1200/debug.c b/drivers/net/wireless/st/cw1200/debug.c index 8686929c70df..bcb8757c34ae 100644 --- a/drivers/net/wireless/st/cw1200/debug.c +++ b/drivers/net/wireless/st/cw1200/debug.c @@ -355,6 +355,7 @@ static const struct file_operations fops_wsm_dumps = { .open = simple_open, .write = cw1200_wsm_dumps, .llseek = default_llseek, + .owner = THIS_MODULE, }; int cw1200_debug_init(struct cw1200_common *priv) From patchwork Sat Nov 7 17:21:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889213 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 88D0E139F for ; Sat, 7 Nov 2020 17:25:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EC7921D81 for ; Sat, 7 Nov 2020 17:25:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EzD+jM5i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728532AbgKGRZQ (ORCPT ); Sat, 7 Nov 2020 12:25:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbgKGRZP (ORCPT ); Sat, 7 Nov 2020 12:25:15 -0500 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50BB6C0613CF; Sat, 7 Nov 2020 09:25:15 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id j5so2465235plk.7; Sat, 07 Nov 2020 09:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Zrqoh3/WJKBcX4xyyt+4P+H4+q1molNmvJwrvReHC/4=; b=EzD+jM5ido10xpcSm0pa2XnLzX4WVHN4hUNd95NfxHB3ht9TSQLeHUr8Nr+/iaWXVg dL1tRgonrcxfQTlgwUFFh7e3gSXk1IS8l9GnzijLpU6UqlnndOMszxlMW9IgwC6KzsxU Ct/E92/AjuqHsz5Z8dnRvsQMTI0xkLMCPE7RR8C4GFtQ7W4eC37hH7rMvVEAYrjgnFN4 +Gn82yHPpAxMAOtXiLYUue5yR0D90gpHa4LQ6vU+XoDgnEFTSOcUd53EdgxoAWMixyZ9 WnaODPJ5oh7qP6asAHbVNJHnFchoc0R66dIWIz8xMq5yJ0XNZql7wu5eeahDIpws+BaL 1Umg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Zrqoh3/WJKBcX4xyyt+4P+H4+q1molNmvJwrvReHC/4=; b=FFTryhM/ZW6B5Pj6nxS4cytIkoIS4LDxqXKez+8zWfdg39mppXbVirv0k7ToKpJvQW RTL3WsR5C3IBbYz5+OvElp9t3XCq8BrUMiw7yZo6pKYL6H/l9xTs1WKdBXWCvJ/rg8ph m8n6sirJ8dBExidsQXUMD43YoPX4Ge08UKccwe3IC1NcSU2CPg4f3j7Y6bR0gRgipNIj aEwZD/+EI0K5JpoKAQkaSGif+pftBM4bM009LA8pYzAwjZSkycu+QPcdi/+BLBwwWZaX /7Xj1Jr4rMMP3fCf7j/F9eGktB2oscuEzqVpPNJUTeHnhaqHdSJS527wqsg4TBvdibPZ NL2Q== X-Gm-Message-State: AOAM533Wx53R6nDonBn7oyt4J/H/H06cPJwKiC0FgVPvu3AgAPJdZxHI 9HmsYMg5YytFPLtDKNHnFNk= X-Google-Smtp-Source: ABdhPJyCebAiqUjcxXBvUlVCxD45C3hnnSE4L3uLSgkhD7t6BRp74OoASFtgM2DGl+UWODFooZ/NbQ== X-Received: by 2002:a17:90a:f0f:: with SMTP id 15mr4935032pjy.127.1604769914860; Sat, 07 Nov 2020 09:25:14 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:25:14 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 17/21] brcmfmac: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:48 +0000 Message-Id: <20201107172152.828-18-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 2f8c8e62cd50 ("brcmfmac: add "reset" debugfs entry for testing reset") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c index 3dd28f5fef19..a80b28189c99 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c @@ -1188,6 +1188,7 @@ static const struct file_operations bus_reset_fops = { .open = simple_open, .llseek = no_llseek, .write = bus_reset_write, + .owner = THIS_MODULE, }; static int brcmf_bus_started(struct brcmf_pub *drvr, struct cfg80211_ops *ops) From patchwork Sat Nov 7 17:21:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889217 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F2544139F for ; Sat, 7 Nov 2020 17:25:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCAE5208FE for ; Sat, 7 Nov 2020 17:25:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JZCQkGWa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728556AbgKGRZY (ORCPT ); Sat, 7 Nov 2020 12:25:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbgKGRZY (ORCPT ); Sat, 7 Nov 2020 12:25:24 -0500 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42DA5C0613CF; Sat, 7 Nov 2020 09:25:24 -0800 (PST) Received: by mail-pf1-x441.google.com with SMTP id a18so4246856pfl.3; Sat, 07 Nov 2020 09:25:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=sWQ6+mIEaeb7hGESflLEE3hcuFCwgRIQKA3kNoiJ/ds=; b=JZCQkGWaEHWS+8iZi2/aqFIW6Igg2MwEMFDuegt2mCGVOSqpaIUgLscCRkhAmgr/JG yK+thKsG/uz+2qpCNxRvlLUhgqVh3rC0ujiNWVCkYiml56SHOXXEFrszdO090jgyeCJe oDry5QPP2pU119wfMG2U0LqK/NG/eElnqKQm8b1FrNBsKK4Yw9MhL0HqCxwaL7BWHrH9 MFLYwQk1IVIBBEwFad/8rX9AyhVjdpWrMBeajyUaGOTiqTMo5FRSW81RgVCnVuUWt/Z0 3c4z8yhPRKloGH/kPD3KwKHMHIJfdCehfoBxovQSe/34xGzTmonMx3UrFczIH+o+6NUb VtOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=sWQ6+mIEaeb7hGESflLEE3hcuFCwgRIQKA3kNoiJ/ds=; b=MkXHEqnU3TW+kUkJe2a6huSO9oJP7JmvyRMGeWrCBV53auEUw2Fy73J5SihI+pPo83 9bl5CZF0igxZMOh3w8+AJ9ha42Jp5akm9tNDBPoKg4+f44BSYr/kFvDFTa54UxGyYXYh RPYwO7grzWdwG9Ogk6TyGbxjr7ILHOGb94q+AlpRYSekdEDGp1Xi1sp1UFKKnHC4sCg5 mLicrS1q+49b8C1msLPrncNFSgNlHMb6IA0hYbZNWM9tGgoH0N8VisPY+MQ9tAESYO5q ZIP9irL4UwLl5kRbLoiOmLd/B+QifGPF2tjDRCs13iP56Y3IbnR2XwsOl1sl3Bu7E1Ys zkJg== X-Gm-Message-State: AOAM531SaTpX67HjTYDOKARG+t+xYS59MpWWJa1zeob45hZLO5mHMcAO B29Dk00ROqX1017Y2CS02ig= X-Google-Smtp-Source: ABdhPJzUR/2tceki351rShY8u3Iq4Dw70s2JbwzK9GgEd2GVdOeCaQDysl6nIqM/IitHdxfApO5zHg== X-Received: by 2002:a62:804d:0:b029:18b:9bf:2979 with SMTP id j74-20020a62804d0000b029018b09bf2979mr6741176pfd.11.1604769923854; Sat, 07 Nov 2020 09:25:23 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.25.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:25:22 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 18/21] b43legacy: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:49 +0000 Message-Id: <20201107172152.828-19-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wireless/broadcom/b43legacy/debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/b43legacy/debugfs.c b/drivers/net/wireless/broadcom/b43legacy/debugfs.c index e7e4293c01f2..7c6e7cfeb822 100644 --- a/drivers/net/wireless/broadcom/b43legacy/debugfs.c +++ b/drivers/net/wireless/broadcom/b43legacy/debugfs.c @@ -318,6 +318,7 @@ static ssize_t b43legacy_debugfs_write(struct file *file, .read = b43legacy_debugfs_read, \ .write = b43legacy_debugfs_write, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }, \ .file_struct_offset = offsetof(struct b43legacy_dfsentry, \ file_##name), \ From patchwork Sat Nov 7 17:21:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889221 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 186EA14B4 for ; Sat, 7 Nov 2020 17:25:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7519208FE for ; Sat, 7 Nov 2020 17:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j8pGdy/Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728624AbgKGRZd (ORCPT ); Sat, 7 Nov 2020 12:25:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbgKGRZd (ORCPT ); Sat, 7 Nov 2020 12:25:33 -0500 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1AFDFC0613CF; Sat, 7 Nov 2020 09:25:33 -0800 (PST) Received: by mail-pl1-x642.google.com with SMTP id j5so2465469plk.7; Sat, 07 Nov 2020 09:25:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2amA39ppsr3LBtIjpr5PbVmxsb95/8j5ztb5/6gLDc0=; b=j8pGdy/Y2XkRDXAOXTkI8sHNer4xWEnPjNxc9eJ90idf+pukg+I7NSMKtLsrZY2NWt pPd7X05CykbW3lgXeLpiORiEdXY/6Zn7ixE9xx1RNtr3VLBZgxGYEsa6zO7kFX1iixam z5WY8kgdycrE5BggnMTBaGO4tn/wh6b7p99Mw8enfrTFlcPa9UDJe89ATVrPPePnaB7y 7F+Xff8kxKrFrUjTNF3rDtHGcD5I5LWktz0Vve6yo07IGr6Bd1C94cIcXDYUz19SEnah 3WiX5VERWHLFDt4z/U4pfjxXC6wrWedR3vo0Ax3GsqvJgf7X7+vWORt09+erGAoRVTbu 0wMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2amA39ppsr3LBtIjpr5PbVmxsb95/8j5ztb5/6gLDc0=; b=niNMeM8rRMzvbqEpSTEgIzUHpiwbUTsffMH1euE1j6dx4WAgPicTwI5Kseh+wJa8ad HgA2HsnVROMz6kjN4q9bQE1b7gYZs3HIvAQAgtq6qVfoHsyEl/B/0wYmU3FtUfacDWZ5 V+ejmXgBVdPx8IZq1B1apfjO8ueg+AN3YxbY5bEFfK4bKirkwdmkK5c2KZrLW+mQeur0 BMJ37svLKRtaNRTwDZJwmcSzwChBzgWMLPFgEsj0F/x9eFeUnLt5v8gABeZb8AP3m2Bi gaNANSLK6+TQHso4PLCxWzQVU7u7khchHtsMhOOHZeNqsZtYJXrSQg0fjwDnMSB8wV/T y9GQ== X-Gm-Message-State: AOAM533obQPfrlCgS1fqluGsxtLveuESg7QJKuzw2WACkQNV4PFIxkhO 9o9zo4+EQ/VzFmaX2R+znZ0= X-Google-Smtp-Source: ABdhPJyOR4vW9Ms8W+c4vkQRPUgt3FHemCkVq5jeFZzT3s/0hsrAV6aPm9e8Mt3iWhVgfT+bVdpW1w== X-Received: by 2002:a17:90a:7d06:: with SMTP id g6mr4912750pjl.113.1604769932699; Sat, 07 Nov 2020 09:25:32 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:25:31 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 19/21] b43: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:50 +0000 Message-Id: <20201107172152.828-20-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: e4d6b7951812 ("[B43]: add mac80211-based driver for modern BCM43xx devices") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline drivers/net/wireless/broadcom/b43/debugfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/broadcom/b43/debugfs.c b/drivers/net/wireless/broadcom/b43/debugfs.c index 89a25aefb327..c0d51cb57b27 100644 --- a/drivers/net/wireless/broadcom/b43/debugfs.c +++ b/drivers/net/wireless/broadcom/b43/debugfs.c @@ -611,6 +611,7 @@ static ssize_t b43_debugfs_write(struct file *file, .read = b43_debugfs_read, \ .write = b43_debugfs_write, \ .llseek = generic_file_llseek, \ + .owner = THIS_MODULE, \ }, \ .file_struct_offset = offsetof(struct b43_dfsentry, \ file_##name), \ From patchwork Sat Nov 7 17:21:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889225 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ED7D3139F for ; Sat, 7 Nov 2020 17:25:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D2EF1208FE for ; Sat, 7 Nov 2020 17:25:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nHASIL7R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728710AbgKGRZm (ORCPT ); Sat, 7 Nov 2020 12:25:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727440AbgKGRZm (ORCPT ); Sat, 7 Nov 2020 12:25:42 -0500 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 040DAC0613CF; Sat, 7 Nov 2020 09:25:42 -0800 (PST) Received: by mail-pl1-x641.google.com with SMTP id t22so2460513plr.9; Sat, 07 Nov 2020 09:25:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3mCRQwzMlvyIXUL9jNNxjMBdUUyjiqAr7lrzvqU4ySA=; b=nHASIL7RXHI4gHQneP0FYxlVJ4fx7R5mbzGegaL1Ner9rQrSPd8p32XH6h2oqyvcTS Xa+uf9k/8FdF2rZaMQ8Q3yOzzgkAPsJ0CDWmz6p8TzOzWN07okeNsR5VjEJCDeOVHSys Sr6N6QrTALmEQkR3e/ELScthBfFDRT5e2WfHQDKZYsxiUvSHgP8j1so9UoVYPH9F2Jov +DM3PG+KHnCybCOh1SX2Vdx66VZDTlda0L4ihe/cqP+yUuo/w9kgXdDabbeEKr7Tx0e8 EIB936AgW/1/d2GnxwudNBc7K2yqARNKvNwTK5Tje67S0US30c6qXxDN4XtYdN+eBOoz ay5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3mCRQwzMlvyIXUL9jNNxjMBdUUyjiqAr7lrzvqU4ySA=; b=JrXosW8GBucIdgOwTK8e3hiRCaPOxxWilCKaxQJxnle0uBwAgjhg1KD7E3ZObtm8cd rcaYOTniap+arB7KBL21wUJ+/2fSqa9kz06arLnQ7VXC+jf3E8sODWa8LTrSuI52KFYp GHUIP5lu7gyTNRd9v5hW4a3gDCSVXmJ1m1MRKTPmI+4xaBC2slpEN7aFzFLVV9fyLB9I uCWFwVrmPuSQMBFnF1SIPZ32TP46GGlIL9+wbvQxcIJf4j0XQJb5DDvTxczZ+dDAHsNL a/TG+nFxmqDkP9lDWErMfjYGZd4VixWpIbWzI3GsBthOVERYYSTMAMohhDCy5P28B8XE Qk1g== X-Gm-Message-State: AOAM531UZdPTT61AnjmbDEg413umQqCrljxsadFq87Vmc45C9TOtVCM+ nIvdI3GNREBU0a3nR7pp2/A= X-Google-Smtp-Source: ABdhPJwQM/+tDsY/mm9rWSw88wITFlVZJLf1XLdnYL5pnL7fOvtiQ6SFPegBXj/ZDTOoeRKlP3sKdw== X-Received: by 2002:a17:902:c142:b029:d6:ac10:6d25 with SMTP id 2-20020a170902c142b02900d6ac106d25mr6198782plj.37.1604769941511; Sat, 07 Nov 2020 09:25:41 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.25.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:25:40 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 20/21] mwifiex: mwifiex: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:51 +0000 Message-Id: <20201107172152.828-21-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem drivers/net/wireless/marvell/mwifiex/debugfs.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/debugfs.c b/drivers/net/wireless/marvell/mwifiex/debugfs.c index dded92db1f37..641113260439 100644 --- a/drivers/net/wireless/marvell/mwifiex/debugfs.c +++ b/drivers/net/wireless/marvell/mwifiex/debugfs.c @@ -931,18 +931,21 @@ static const struct file_operations mwifiex_dfs_##name##_fops = { \ .read = mwifiex_##name##_read, \ .write = mwifiex_##name##_write, \ .open = simple_open, \ + .owner = THIS_MODULE, \ }; #define MWIFIEX_DFS_FILE_READ_OPS(name) \ static const struct file_operations mwifiex_dfs_##name##_fops = { \ .read = mwifiex_##name##_read, \ .open = simple_open, \ + .owner = THIS_MODULE, \ }; #define MWIFIEX_DFS_FILE_WRITE_OPS(name) \ static const struct file_operations mwifiex_dfs_##name##_fops = { \ .write = mwifiex_##name##_write, \ .open = simple_open, \ + .owner = THIS_MODULE, \ }; From patchwork Sat Nov 7 17:21:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Taehee Yoo X-Patchwork-Id: 11889227 X-Patchwork-Delegate: johannes@sipsolutions.net Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1CDA7139F for ; Sat, 7 Nov 2020 17:25:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F009E208FE for ; Sat, 7 Nov 2020 17:25:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BrNCyXb4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728491AbgKGRZv (ORCPT ); Sat, 7 Nov 2020 12:25:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727305AbgKGRZv (ORCPT ); Sat, 7 Nov 2020 12:25:51 -0500 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0510BC0613CF; Sat, 7 Nov 2020 09:25:51 -0800 (PST) Received: by mail-pj1-x1042.google.com with SMTP id r9so1007234pjl.5; Sat, 07 Nov 2020 09:25:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cGWu/C+12zss/m0Fs14PTVMmX5fXCE6aVtGhQCZq34o=; b=BrNCyXb4g1Tv9yX8NCbCTj9N0/wkp/pVCnwnxvJHoQhVve5Wa82FZkR69+bPcwfZhO e+WJQCEOIIqlQavDblv42z9898zsBSoNK8eTlePiXBrJsW0P8+Sgb2vmpHSAeR5cgIIb FqsFbBbj0Iw2lQvBo6cqTqqtrnYNnNvcu+oHQZ/piAkZwUFu7eeDG7XJSUaZ/fVXLdYM 3BAbEsKL1D405YT9k4nR2Vxh8NTZgW3wYW2IHuhd4qRml+ZxCON+gk8ay/2RSlqYf0Nf Srg0+q4oni6y/4y2nLqgRRwNjrmGQKEAAguYq+rvSx8ezBXBFhTP+bUX5SJeyJNZ+0wQ zgCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cGWu/C+12zss/m0Fs14PTVMmX5fXCE6aVtGhQCZq34o=; b=SqyJu1u6Iy833i5OUE1bBafdJf15sO1UynBW1Pwf1P2reR46piy9qE14hnAbTUsXxe 8RY5FUV3F+HV0qkCD3FlZu3FtM1QZr1yFcf1nS5RSkXp0GU//6592E/2a3w48II+Qhr5 PJICKh6O5C3Wwqp97RDRkBNkuFlJw/koy15tP2j3xB9miEZQIJ+XDYlP8ah+hS4yqAsM F9cAghkYertV2rfNEoVXH1BB2nd7N9KFw9BuUYmfVnFyH0tz5zO6woXHYt74M7KMuTzA 8nSfzF2mMcrs/L/d2V1GiEufTgq47+hTRn9kzrVb2wZlhyzA/iM4kyTRBabPyPO/IrGp zOFw== X-Gm-Message-State: AOAM532lS5dxtpzahx7F9VWEEf0JNRvCHv5QPrTWy2OgJCfVrsmkT+Sr HMB7yMmTjBzdNX1dV8uXPtM= X-Google-Smtp-Source: ABdhPJyjOKcPOkKCrNENebDqUKKscQzxaS780dS40HVKXKhagociHFkbe8+3uUtJJMNcXcfW5mMxlw== X-Received: by 2002:a17:90a:940c:: with SMTP id r12mr2595487pjo.107.1604769950389; Sat, 07 Nov 2020 09:25:50 -0800 (PST) Received: from localhost.localdomain ([180.70.143.152]) by smtp.gmail.com with ESMTPSA id m17sm4916962pgu.21.2020.11.07.09.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 09:25:49 -0800 (PST) From: Taehee Yoo To: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Cc: ap420073@gmail.com, David.Laight@aculab.com, johannes@sipsolutions.net, nstange@suse.de, derosier@gmail.com, kvalo@codeaurora.org, linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, b43-dev@lists.infradead.org, linux-bluetooth@vger.kernel.org, michael.hennerich@analog.com, linux-wpan@vger.kernel.org, stefan@datenfreihafen.org, inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, emmanuel.grumbach@intel.com, luciano.coelho@intel.com, stf_xl@wp.pl, pkshih@realtek.com, ath11k@lists.infradead.org, ath10k@lists.infradead.org, wcn36xx@lists.infradead.org, merez@codeaurora.org, pizza@shaftnet.org, Larry.Finger@lwfinger.net, amitkarwar@gmail.com, ganapathi.bhat@nxp.com, huxinming820@gmail.com, marcel@holtmann.org, johan.hedberg@gmail.com, alex.aring@gmail.com, jukka.rissanen@linux.intel.com, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com, chung-hsien.hsu@infineon.com, wright.feng@infineon.com, chi-hsien.lin@infineon.com Subject: [PATCH net v2 21/21] Bluetooth: set .owner to THIS_MODULE Date: Sat, 7 Nov 2020 17:21:52 +0000 Message-Id: <20201107172152.828-22-ap420073@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201107172152.828-1-ap420073@gmail.com> References: <20201107172152.828-1-ap420073@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org If THIS_MODULE is not set, the module would be removed while debugfs is being used. It eventually makes kernel panic. Fixes: 4b4148e9acc1 ("Bluetooth: Add support for setting DUT mode") Fixes: 4b4113d6dbdb ("Bluetooth: Add debugfs entry for setting vendor diagnostic mode") Fixes: 300acfdec916 ("Bluetooth: Introduce force_bredr_smp debugfs option for testing") Fixes: 64dd374eac15 ("Bluetooth: Export SMP selftest result in debugfs") Fixes: 0886aea6acd2 ("Bluetooth: Expose debug keys usage setting via debugfs") Fixes: 134c2a89af22 ("Bluetooth: Add debugfs entry to show Secure Connections Only mode") Fixes: b55d1abf568c ("Bluetooth: Expose quirks through debugfs") Fixes: 6e07231a80de ("Bluetooth: Expose Secure Simple Pairing debug mode setting in debugfs") Fixes: ac345813c4ac ("Bluetooth: Expose current identity information in debugfs") Fixes: c2aa30db744d ("Bluetooth: debugfs option to unset MITM flag") Fixes: 6b8d4a6a0314 ("Bluetooth: 6LoWPAN: Use connected oriented channel instead of fixed one") Fixes: 6de50f9fdb60 ("Bluetooth: Export ECDH selftest result in debugfs") Signed-off-by: Taehee Yoo --- v1 -> v2: - Change headline - Squash patches into per-driver/subsystem net/bluetooth/6lowpan.c | 1 + net/bluetooth/hci_core.c | 2 ++ net/bluetooth/hci_debugfs.c | 6 ++++++ net/bluetooth/selftest.c | 1 + net/bluetooth/smp.c | 2 ++ 5 files changed, 12 insertions(+) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index cff4944d5b66..0936184f0813 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -1214,6 +1214,7 @@ static const struct file_operations lowpan_control_fops = { .write = lowpan_control_write, .llseek = seq_lseek, .release = single_release, + .owner = THIS_MODULE, }; static void disconnect_devices(void) diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index 502552d6e9af..dba8506202ff 100644 --- a/net/bluetooth/hci_core.c +++ b/net/bluetooth/hci_core.c @@ -116,6 +116,7 @@ static const struct file_operations dut_mode_fops = { .read = dut_mode_read, .write = dut_mode_write, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t vendor_diag_read(struct file *file, char __user *user_buf, @@ -172,6 +173,7 @@ static const struct file_operations vendor_diag_fops = { .read = vendor_diag_read, .write = vendor_diag_write, .llseek = default_llseek, + .owner = THIS_MODULE, }; static void hci_debugfs_create_basic(struct hci_dev *hdev) diff --git a/net/bluetooth/hci_debugfs.c b/net/bluetooth/hci_debugfs.c index 5e8af2658e44..c9a074da16dd 100644 --- a/net/bluetooth/hci_debugfs.c +++ b/net/bluetooth/hci_debugfs.c @@ -71,6 +71,7 @@ static const struct file_operations __name ## _fops = { \ .read = __name ## _read, \ .write = __name ## _write, \ .llseek = default_llseek, \ + .owner = THIS_MODULE, \ } \ #define DEFINE_INFO_ATTRIBUTE(__name, __field) \ @@ -284,6 +285,7 @@ static const struct file_operations use_debug_keys_fops = { .open = simple_open, .read = use_debug_keys_read, .llseek = default_llseek, + .owner = THIS_MODULE, }; static ssize_t sc_only_mode_read(struct file *file, char __user *user_buf, @@ -302,6 +304,7 @@ static const struct file_operations sc_only_mode_fops = { .open = simple_open, .read = sc_only_mode_read, .llseek = default_llseek, + .owner = THIS_MODULE, }; DEFINE_INFO_ATTRIBUTE(hardware_info, hw_info); @@ -438,6 +441,7 @@ static const struct file_operations ssp_debug_mode_fops = { .open = simple_open, .read = ssp_debug_mode_read, .llseek = default_llseek, + .owner = THIS_MODULE, }; static int auto_accept_delay_set(void *data, u64 val) @@ -726,6 +730,7 @@ static const struct file_operations force_static_address_fops = { .read = force_static_address_read, .write = force_static_address_write, .llseek = default_llseek, + .owner = THIS_MODULE, }; static int white_list_show(struct seq_file *f, void *ptr) @@ -1117,6 +1122,7 @@ static const struct file_operations force_no_mitm_fops = { .read = force_no_mitm_read, .write = force_no_mitm_write, .llseek = default_llseek, + .owner = THIS_MODULE, }; DEFINE_QUIRK_ATTRIBUTE(quirk_strict_duplicate_filter, diff --git a/net/bluetooth/selftest.c b/net/bluetooth/selftest.c index f71c6fa65fb3..445ea247061b 100644 --- a/net/bluetooth/selftest.c +++ b/net/bluetooth/selftest.c @@ -194,6 +194,7 @@ static const struct file_operations test_ecdh_fops = { .open = simple_open, .read = test_ecdh_read, .llseek = default_llseek, + .owner = THIS_MODULE, }; static int __init test_ecdh(void) diff --git a/net/bluetooth/smp.c b/net/bluetooth/smp.c index bf4bef13d935..3b91f927aab5 100644 --- a/net/bluetooth/smp.c +++ b/net/bluetooth/smp.c @@ -3407,6 +3407,7 @@ static const struct file_operations force_bredr_smp_fops = { .read = force_bredr_smp_read, .write = force_bredr_smp_write, .llseek = default_llseek, + .owner = THIS_MODULE, }; int smp_register(struct hci_dev *hdev) @@ -3751,6 +3752,7 @@ static const struct file_operations test_smp_fops = { .open = simple_open, .read = test_smp_read, .llseek = default_llseek, + .owner = THIS_MODULE, }; static int __init run_selftests(struct crypto_shash *tfm_cmac,