From patchwork Mon Nov 9 13:52:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11891563 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A9E4C15E6 for ; Mon, 9 Nov 2020 13:54:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B8302068D for ; Mon, 9 Nov 2020 13:54:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TWpxsKJw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8302068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:34328 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc7cd-0004bC-Ac for patchwork-qemu-devel@patchwork.kernel.org; Mon, 09 Nov 2020 08:54:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc7bc-0002qQ-F2 for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:12 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31157) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kc7ba-00059t-Mi for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604929989; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bTBnywXLaOQMIyRP1BOGtBwgA4JsTbKiYnIyA3r8z1g=; b=TWpxsKJw76lHVZC+jKHlNM86/1DWR6IJgEpWbTk6+f7YsFWWuA1gsYw9JWk/6u83PWI0qG xZ2D9MXRukJ1DE0V4CJzeK3jNFFHYX3QN4J4yI5pUSe1MVoV+OjpuSM1ewJgFmvymdM0My rOt52vcvJtPI4B9TrjVZpwp2PL7XYuk= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-275-3xATsw58MS6htv7VgtN3VQ-1; Mon, 09 Nov 2020 08:53:08 -0500 X-MC-Unique: 3xATsw58MS6htv7VgtN3VQ-1 Received: by mail-wm1-f70.google.com with SMTP id t201so2001937wmt.1 for ; Mon, 09 Nov 2020 05:53:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bTBnywXLaOQMIyRP1BOGtBwgA4JsTbKiYnIyA3r8z1g=; b=V7yWC30WPhztc0H5olqbXUrQQALg8YAmn6X9gP9iQpr/KyfollIhN3E+41bgCt6bZl nZG5ABIT5C3zC9rF2qkrxAj2KIJk/HGKhPjCAzSoLvgmsMmslMz7mGqc6Fyv6LnWxY68 kEa5REQOa1YKdG62jHKnI3Vm0h4o2jtyWGgLXkB4cqVgPbIg5k97ij3eay1aA6fnUP4p O0E4S7/AAk6+Y42kPO7PCVuzf+vdawAeuRwAbCvGD02nW2TU4U+/T+jWdC1u1ncYwLLZ QEmet1X0VcMdh0Z+ZzZCSf6pCFvfnb6ZVPcknCt2QKeaTLijqFtMwkcYn0NBcbKV3ikO lg0g== X-Gm-Message-State: AOAM530Z+dliPLFAahfn3zt4hIzZVrA4lh7ca9WOdyjcTDcKcUDnc/d2 hkoq+rtaoNIxhf98rSxPXdEfi2FrB128DR4IbZD8f3dTbXB5eEtOy5Kc/+p2Q3+XBcX/SICHzjN Ae04hUKeW1U3uLV4= X-Received: by 2002:adf:e2c9:: with SMTP id d9mr18009974wrj.11.1604929986981; Mon, 09 Nov 2020 05:53:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJz1+hmulN5kQ0yjlLUIkXwQDlswViMOf3q0y15jRtb0PISBQWHAykNGp30Q1rBDv/c1UvgN9A== X-Received: by 2002:adf:e2c9:: with SMTP id d9mr18009961wrj.11.1604929986863; Mon, 09 Nov 2020 05:53:06 -0800 (PST) Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id i33sm13707609wri.79.2020.11.09.05.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 05:53:06 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.2 v2 1/4] hw/usb/Kconfig: Fix USB_XHCI_NEC (depends on USB_XHCI_PCI) Date: Mon, 9 Nov 2020 14:52:57 +0100 Message-Id: <20201109135300.2592982-2-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201109135300.2592982-1-philmd@redhat.com> References: <20201109135300.2592982-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 00:04:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sai Pavan Boddu , =?utf-8?q?Philippe_Mathieu?= =?utf-8?q?-Daud=C3=A9?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Since commit 755fba11fbc and 8ddab8dd3d8 we can not build USB_XHCI_NEC without USB_XHCI_PCI. Correct the Kconfig dependency. Fixes: 755fba11fbc ("usb/hcd-xhci: Move qemu-xhci device to hcd-xhci-pci.c") Reviewed-by: Sai Pavan Boddu Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/usb/Kconfig | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/Kconfig b/hw/usb/Kconfig index a674ce4c542..6a213b04758 100644 --- a/hw/usb/Kconfig +++ b/hw/usb/Kconfig @@ -42,9 +42,7 @@ config USB_XHCI_PCI config USB_XHCI_NEC bool - default y if PCI_DEVICES - depends on PCI - select USB_XHCI + select USB_XHCI_PCI config USB_XHCI_SYSBUS bool From patchwork Mon Nov 9 13:52:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11891581 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 62D3E1391 for ; Mon, 9 Nov 2020 14:00:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F027520731 for ; Mon, 9 Nov 2020 14:00:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YDeUVrH+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F027520731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:50690 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc7it-0003MJ-Rk for patchwork-qemu-devel@patchwork.kernel.org; Mon, 09 Nov 2020 09:00:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34510) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc7bh-00032T-Cq for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58111) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kc7bf-0005C6-H6 for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604929994; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0AwdT5nD9C6a2wsBgla1NUJAfuZdmUfnrRvAnSbIFbU=; b=YDeUVrH+Su3ILu0p8M27M2aRjbHpWiH2SnJ3rz9EOUhp806YjplHHDtrUBnKifEG+iL0bu ylhLMjCwPuZicUTsD4FoEvg7NPD/8qglmAoXqA0+C0fKG9PQNi+uigTSZ76AnEAIe/4Ep1 JtvuNMoun4aMwSO9UrhuwMudWXEIbIg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-356-B0sOD3WMNb2QQ58HiCS7aA-1; Mon, 09 Nov 2020 08:53:13 -0500 X-MC-Unique: B0sOD3WMNb2QQ58HiCS7aA-1 Received: by mail-wr1-f70.google.com with SMTP id f11so4353564wro.15 for ; Mon, 09 Nov 2020 05:53:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0AwdT5nD9C6a2wsBgla1NUJAfuZdmUfnrRvAnSbIFbU=; b=tryYpHjW6gB28F/KUXjOIUs3eGLaeyH2gORUHXwF27BlvH/aQeyD//uzJyhEbcNDQa 9xTkcNZPLPBQO4NAKhFN+hgQpph1zrgjvbre6Q0FfK/iDAB73jqsoE6zL3zqW3iaM0VN 3yVGltgR2Mm1Qi7hITGPI8sQUWVkDl8FgDvFjXQVNWMShXJhxIhThSmlDL7oLW4IQBHD /JmJ59L71K3LfngH1Q3m9yFKkPobfzCO6Dh3yQQ/ETnXpvHFLlnsbbNt0c9OTsy/YZeY C+ymJbuyMfHHlPX1G/hKhNrqielp6YWk5tFZsghHkatGwrmKCFqjMa3DAI3RtY3+zB07 9FhA== X-Gm-Message-State: AOAM532O1lL6BLJE692luc5iAtReeRlqnZVrHl8nyO8qnLTN3cVEovQ8 xopXEFxK1x8tAr4Tfh7NCmCpfwyTlZUOxtARRR0hAldg7MV6aJVevF8WE6vsCXAf2zUGXwYPp1r ZRtRJlN9poB9WzjM= X-Received: by 2002:adf:f4c9:: with SMTP id h9mr17434010wrp.332.1604929991700; Mon, 09 Nov 2020 05:53:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJyS13YtWVGV4xyRVW/8sdcn1Yh9NSAnalNkNNnI7imRHv0kEIVO1b6rNDIHmsB1kLS3hNASvw== X-Received: by 2002:adf:f4c9:: with SMTP id h9mr17433999wrp.332.1604929991583; Mon, 09 Nov 2020 05:53:11 -0800 (PST) Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id d63sm12759895wmd.12.2020.11.09.05.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 05:53:11 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-6.0 v2 2/4] hw/usb/hcd-xhci: Restrict TYPE_XHCI to hw/usb/ Date: Mon, 9 Nov 2020 14:52:58 +0100 Message-Id: <20201109135300.2592982-3-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201109135300.2592982-1-philmd@redhat.com> References: <20201109135300.2592982-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 01:25:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" TYPE_XHCI is not a generic device meant to be instantiated by QOM objects outside of hw/usb/. Do not expose the type in public namespace (via include/). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/usb/hcd-xhci.h | 1 + include/hw/usb/xhci.h | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-xhci.h b/hw/usb/hcd-xhci.h index ccf50ae28be..f7150a7e12b 100644 --- a/hw/usb/hcd-xhci.h +++ b/hw/usb/hcd-xhci.h @@ -27,6 +27,7 @@ #include "hw/usb/xhci.h" #include "sysemu/dma.h" +#define TYPE_XHCI "base-xhci" OBJECT_DECLARE_SIMPLE_TYPE(XHCIState, XHCI) /* Very pessimistic, let's hope it's enough for all cases */ diff --git a/include/hw/usb/xhci.h b/include/hw/usb/xhci.h index 5c90e1373e5..90b56429199 100644 --- a/include/hw/usb/xhci.h +++ b/include/hw/usb/xhci.h @@ -1,7 +1,6 @@ #ifndef HW_USB_XHCI_H #define HW_USB_XHCI_H -#define TYPE_XHCI "base-xhci" #define TYPE_NEC_XHCI "nec-usb-xhci" #define TYPE_QEMU_XHCI "qemu-xhci" #define TYPE_XHCI_SYSBUS "sysbus-xhci" From patchwork Mon Nov 9 13:52:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11891565 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AC2FE6A2 for ; Mon, 9 Nov 2020 13:55:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65CD72068D for ; Mon, 9 Nov 2020 13:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="V32yNIzi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65CD72068D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:36616 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc7dX-0005e3-Cs for patchwork-qemu-devel@patchwork.kernel.org; Mon, 09 Nov 2020 08:55:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc7bm-0003Et-Dv for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:56484) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kc7bk-0005Ea-I9 for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604929999; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=medLDSYusB8YjCm6gdZ83ILtuaQLgway4LfVPfNsVbk=; b=V32yNIziaXUL+hqVnelotKIRgrAC0GfX/VArm9ou8+KLRgzuJpCeWZq0WdiYqw3bCWlKPI cu+Y1g7O4RNRWyGcM1eQd4E7MG33JdFxXW2Cx1aezMliHP+2lRVrsarzOicV8Besn0Pcmi 2E1KUQfcxuZ6FCrfqMwlGwQqfL3o+QY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-578-CksNRRwCP5GHJB2M8RYxBw-1; Mon, 09 Nov 2020 08:53:18 -0500 X-MC-Unique: CksNRRwCP5GHJB2M8RYxBw-1 Received: by mail-wm1-f70.google.com with SMTP id 3so1995329wms.9 for ; Mon, 09 Nov 2020 05:53:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=medLDSYusB8YjCm6gdZ83ILtuaQLgway4LfVPfNsVbk=; b=flJ4SLVsnhGN/aMTiBXrNOpbPz5fvp5rf9SuWoPdLSSmG3vr5vBq55ZeUagxLCSRdG Gx1suJC1sh8zQ/P7xKEX/uXgqL/pCuRRgsV+m4sgRj6O/R2kUgPjpGOctQFxzN2jKsoM ByPgila+5YOTugACsQLwiMDr8npx/A8iRckxu/X7JW1a6FzMoDTvZ8+0RS1m59hwbPWM LCJj+WLuWgw57YDKAnb9t2sTS+9sxzgUbfGUTNOKo9Blfl5Oc3fVObggRqa3ubcv3c2P f3T2Cbba9cQ3uSnj1VkZYU8g904DzZdRc/TUks9fMMwXPl1zhyW/Ht2L2qR3oTNNxncH 8rsw== X-Gm-Message-State: AOAM530tgDNXZLizoeD/R3EUWVSbEFT0oqRRlFKL83ozKveIoWf5Kleu nagOZAaCub0xdESJR3hGGnHk0UHYmht5XRr6Xp+9VyJd0I3lSbuZmIHthVVed4z2oGAVtAw1Mrr FVTl6vJafuTmTeAY= X-Received: by 2002:a1c:a185:: with SMTP id k127mr11595274wme.23.1604929996505; Mon, 09 Nov 2020 05:53:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJzwZRPeg9uhlkjNJxEkEkU67k7KaxGBk8Tcn3XXTmhuV1WZZSRBFxC7lRp34edvMwYipRdrBg== X-Received: by 2002:a1c:a185:: with SMTP id k127mr11595254wme.23.1604929996287; Mon, 09 Nov 2020 05:53:16 -0800 (PST) Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id o7sm14093693wrp.23.2020.11.09.05.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 05:53:15 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-6.0 v2 3/4] hw/usb/hcd-xhci-pci: Use OBJECT_DECLARE_SIMPLE_TYPE() macro Date: Mon, 9 Nov 2020 14:52:59 +0100 Message-Id: <20201109135300.2592982-4-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201109135300.2592982-1-philmd@redhat.com> References: <20201109135300.2592982-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 01:25:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/usb/hcd-xhci-pci.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/usb/hcd-xhci-pci.h b/hw/usb/hcd-xhci-pci.h index aa2e890627c..cf9a180caa4 100644 --- a/hw/usb/hcd-xhci-pci.h +++ b/hw/usb/hcd-xhci-pci.h @@ -28,9 +28,7 @@ #include "hcd-xhci.h" #define TYPE_XHCI_PCI "pci-xhci" -#define XHCI_PCI(obj) \ - OBJECT_CHECK(XHCIPciState, (obj), TYPE_XHCI_PCI) - +OBJECT_DECLARE_SIMPLE_TYPE(XHCIPciState, XHCI_PCI) typedef struct XHCIPciState { /*< private >*/ From patchwork Mon Nov 9 13:53:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 11891571 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 644546A2 for ; Mon, 9 Nov 2020 13:57:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EDA0F206ED for ; Mon, 9 Nov 2020 13:57:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Nc5mPdgs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EDA0F206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Received: from localhost ([::1]:45438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc7gA-00010t-SW for patchwork-qemu-devel@patchwork.kernel.org; Mon, 09 Nov 2020 08:57:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34568) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc7bq-0003OZ-Gy for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:26 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:60537) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kc7bo-0005GC-Hz for qemu-devel@nongnu.org; Mon, 09 Nov 2020 08:53:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604930003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hJ9MpIv/7kmX06xCIU09e2TXqLlDymC3w5zG23mwJEU=; b=Nc5mPdgsMLeDY9YejvthcCpCkmPIUFWm1LD48wZZKBahRXbIORiRSXuZEQyvh+tn7QjizG m3POF+TOhZEVYqeomfuLqn7MBCDsQvkb/MJNo/KwvDeUnjTlV1EvDcAKB6vrg1An/oXn8v Nhz+SYVUkI98oTlpNe06CQTpOpmHfAM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-79-VPZwb4pdMFqkLZz2LMv4Zg-1; Mon, 09 Nov 2020 08:53:22 -0500 X-MC-Unique: VPZwb4pdMFqkLZz2LMv4Zg-1 Received: by mail-wm1-f71.google.com with SMTP id h2so2001521wmm.0 for ; Mon, 09 Nov 2020 05:53:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hJ9MpIv/7kmX06xCIU09e2TXqLlDymC3w5zG23mwJEU=; b=aj4SeuOMa3w+W0LXDcRcrebHjZcRIp8I2YwjMsf3UThduWaebr27qMrSHdX/8ae5OD NjGi32/MyL9gX1USkiJj24JdS2QouGZUtQb9AAGlIj1qGertg+F7urrE28p8UUjJ4w9D Zp7eWiClSOWGRkp/N1nO+aFZvB04peuQ1Cfi8jF6sy0A7VOuSCBlQVtPil2Q+47gc0vJ JT+zx4fFM/H2NDWzsK0c9hqc0R1pW2mgTiWYxw0wW1t83qo2IXxB6WnvHcJpfDz9tOas 9gzBPEmbxBXe33TXsxAzqbFkVE1yc3/35OFJCULfjbCNSCtsEGJ5NkQSP+jhM5ktN2L6 JeSA== X-Gm-Message-State: AOAM531txGWnzhqfcc3aw1m+HhPfQwfslmQZTO2BxCCV8Jyuidvm2iXa IFQWI8PB4NkWxwKY/MXBetDISmSNURCbEiWzz0ceFJANsjPJeb20s8H/bZSxhN8rOKWrDXGnGGw Ofjb3uH5ImLpJgs8= X-Received: by 2002:adf:fd03:: with SMTP id e3mr12519470wrr.303.1604930001117; Mon, 09 Nov 2020 05:53:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxi5nMKAbfvzEMk9GcbBEY9y64Mv+3OOCdx00CrnBNGfDTw/hRZcCDIUQ5EP5S8IlnuTFfnDQ== X-Received: by 2002:adf:fd03:: with SMTP id e3mr12519448wrr.303.1604930000927; Mon, 09 Nov 2020 05:53:20 -0800 (PST) Received: from x1w.redhat.com (234.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.234]) by smtp.gmail.com with ESMTPSA id s8sm9315798wrn.33.2020.11.09.05.53.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 05:53:20 -0800 (PST) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-6.0 v2 4/4] hw/usb/hcd-xhci-pci: Rename "pci-xhci" as TYPE_XHCI_PCI_COMMON Date: Mon, 9 Nov 2020 14:53:00 +0100 Message-Id: <20201109135300.2592982-5-philmd@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20201109135300.2592982-1-philmd@redhat.com> References: <20201109135300.2592982-1-philmd@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 00:04:29 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Gerd Hoffmann Errors-To: qemu-devel-bounces+patchwork-qemu-devel=patchwork.kernel.org@nongnu.org Sender: "Qemu-devel" Follow the code base style by using the _COMMON suffix to abstract QOM types. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/usb/hcd-xhci-pci.h | 4 ++-- hw/usb/hcd-xhci-nec.c | 2 +- hw/usb/hcd-xhci-pci.c | 16 ++++++++-------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/usb/hcd-xhci-pci.h b/hw/usb/hcd-xhci-pci.h index cf9a180caa4..c862e82d964 100644 --- a/hw/usb/hcd-xhci-pci.h +++ b/hw/usb/hcd-xhci-pci.h @@ -27,8 +27,8 @@ #include "hw/usb.h" #include "hcd-xhci.h" -#define TYPE_XHCI_PCI "pci-xhci" -OBJECT_DECLARE_SIMPLE_TYPE(XHCIPciState, XHCI_PCI) +#define TYPE_XHCI_PCI_COMMON "pci-xhci" +OBJECT_DECLARE_SIMPLE_TYPE(XHCIPciState, XHCI_PCI_COMMON) typedef struct XHCIPciState { /*< private >*/ diff --git a/hw/usb/hcd-xhci-nec.c b/hw/usb/hcd-xhci-nec.c index 5707b2cabd1..16b3b46fd59 100644 --- a/hw/usb/hcd-xhci-nec.c +++ b/hw/usb/hcd-xhci-nec.c @@ -52,7 +52,7 @@ static void nec_xhci_class_init(ObjectClass *klass, void *data) static const TypeInfo nec_xhci_info = { .name = TYPE_NEC_XHCI, - .parent = TYPE_XHCI_PCI, + .parent = TYPE_XHCI_PCI_COMMON, .class_init = nec_xhci_class_init, }; diff --git a/hw/usb/hcd-xhci-pci.c b/hw/usb/hcd-xhci-pci.c index b78fcd2bb2d..b4487cce4ba 100644 --- a/hw/usb/hcd-xhci-pci.c +++ b/hw/usb/hcd-xhci-pci.c @@ -80,14 +80,14 @@ static void xhci_pci_intr_raise(XHCIState *xhci, int n, bool level) static void xhci_pci_reset(DeviceState *dev) { - XHCIPciState *s = XHCI_PCI(dev); + XHCIPciState *s = XHCI_PCI_COMMON(dev); device_legacy_reset(DEVICE(&s->xhci)); } static int xhci_pci_vmstate_post_load(void *opaque, int version_id) { - XHCIPciState *s = XHCI_PCI(opaque); + XHCIPciState *s = XHCI_PCI_COMMON(opaque); PCIDevice *pci_dev = PCI_DEVICE(s); int intr; @@ -105,7 +105,7 @@ static void usb_xhci_pci_realize(struct PCIDevice *dev, Error **errp) { int ret; Error *err = NULL; - XHCIPciState *s = XHCI_PCI(dev); + XHCIPciState *s = XHCI_PCI_COMMON(dev); dev->config[PCI_CLASS_PROG] = 0x30; /* xHCI */ dev->config[PCI_INTERRUPT_PIN] = 0x01; /* interrupt pin 1 */ @@ -165,7 +165,7 @@ static void usb_xhci_pci_realize(struct PCIDevice *dev, Error **errp) static void usb_xhci_pci_exit(PCIDevice *dev) { - XHCIPciState *s = XHCI_PCI(dev); + XHCIPciState *s = XHCI_PCI_COMMON(dev); /* destroy msix memory region */ if (dev->msix_table && dev->msix_pba && dev->msix_entry_used) { @@ -187,7 +187,7 @@ static const VMStateDescription vmstate_xhci_pci = { static void xhci_instance_init(Object *obj) { - XHCIPciState *s = XHCI_PCI(obj); + XHCIPciState *s = XHCI_PCI_COMMON(obj); /* * QEMU_PCI_CAP_EXPRESS initialization does not depend on QEMU command * line, therefore, no need to wait to realize like other devices @@ -211,7 +211,7 @@ static void xhci_class_init(ObjectClass *klass, void *data) } static const TypeInfo xhci_pci_info = { - .name = TYPE_XHCI_PCI, + .name = TYPE_XHCI_PCI_COMMON, .parent = TYPE_PCI_DEVICE, .instance_size = sizeof(XHCIPciState), .class_init = xhci_class_init, @@ -235,7 +235,7 @@ static void qemu_xhci_class_init(ObjectClass *klass, void *data) static void qemu_xhci_instance_init(Object *obj) { - XHCIPciState *s = XHCI_PCI(obj); + XHCIPciState *s = XHCI_PCI_COMMON(obj); XHCIState *xhci = &s->xhci; s->msi = ON_OFF_AUTO_OFF; @@ -247,7 +247,7 @@ static void qemu_xhci_instance_init(Object *obj) static const TypeInfo qemu_xhci_info = { .name = TYPE_QEMU_XHCI, - .parent = TYPE_XHCI_PCI, + .parent = TYPE_XHCI_PCI_COMMON, .class_init = qemu_xhci_class_init, .instance_init = qemu_xhci_instance_init, };