From patchwork Mon Nov 9 16:56:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 11891907 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382BBC2D0A3 for ; Mon, 9 Nov 2020 16:56:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E151320789 for ; Mon, 9 Nov 2020 16:56:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jYHzo1/s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730895AbgKIQ4o (ORCPT ); Mon, 9 Nov 2020 11:56:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729776AbgKIQ4m (ORCPT ); Mon, 9 Nov 2020 11:56:42 -0500 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C162BC0613D3 for ; Mon, 9 Nov 2020 08:56:40 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id n12so10508369ioc.2 for ; Mon, 09 Nov 2020 08:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4yWrXzwfznxNU372UdbxuIAHo54u4g17q1CuRCAU4Gc=; b=jYHzo1/shxPWr7/tBwF8gfq6RrvxnXOGHH/E1Fa7/3/U7/J74dAGnw+6bPfm58XK8n ZF+CsKprjhQtuqJgD302DAM7pr6EE2hBXPfBzcT9d4M3Kwhrh7GqZYPayqPkXNGSIyD3 MYjnueSZFkrqTsjENpheg2B4xQAVsjr9v7io2CHLNjXvmHxC+xeegYgfuXNq5Q4q8tgG OHshgukqDszdWe+IY2PmP5BNiu6ZZla76vGfqwi8FvXEFtQXr0/e7z4B3hCXONTUYIhl e+y/7cT7fePz9PBc3/pFPJ9gJr8VT5u/LEYsB51DPfnXvmJ47W96xAOSDJn2kYKPhuQ0 SAnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4yWrXzwfznxNU372UdbxuIAHo54u4g17q1CuRCAU4Gc=; b=nBcJPlaA9EWJB5VweY3fw1NHoruIZKiqnow2uMYXjUCYJxTefhCCtj180Xhv07toD8 tEdmbYptwFejYvdobqeMaO2oALiYyD4VYlsiztPHGdgU/8+16yU2CyB8IUcSoJhnUltV xN9pdg+spGuXTiUV03l8bnYMXuh2+SS6ALZiFxZ1O6ucOX+pvtc8yeEh1wFneTuZiy6Q Rb98fxhFmk/j6XVeFuWjv68aOV3Ul5sAYybB8CFOex2kaNKcE9pZmjw3ORqKwWAKHPSN TKc3CjWJMxt1aViCR1DD3BGIwNLUl8thwc+MCjn/iOXi003R1ZtLEGiRfZvCw2nnGW3J 8wDw== X-Gm-Message-State: AOAM533YqJEm+EnNHHGSOT9MQIwlKnSVCrI60XIE5EBeLttp+lmeNYCz V5QYaDuLr1DjNFM8rNMAIO0AXg== X-Google-Smtp-Source: ABdhPJxvcCfXLOJfmraw+ovVfPKnpgsipKccPYgqGzi70V4WprW2vxvAfS7xedEDe5hPuFXlH8YgSQ== X-Received: by 2002:a02:cd02:: with SMTP id g2mr11928881jaq.22.1604941000087; Mon, 09 Nov 2020 08:56:40 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id j85sm7576556ilg.82.2020.11.09.08.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:56:39 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 1/4] net: ipa: don't break build on large transaction size Date: Mon, 9 Nov 2020 10:56:32 -0600 Message-Id: <20201109165635.5449-2-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201109165635.5449-1-elder@linaro.org> References: <20201109165635.5449-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The following call in ipa_validate_build() is erroneous: BUILD_BUG_ON(sizeof(struct gsi_trans) > 128); The fact is, it is not a bug for the size of a GSI transaction to be bigger than 128 bytes. The correct operation of the driver is not dependent on the size of this structure. The only consequence of the transaction being large is that the amount of memory required is larger. The problem this was trying to flag is that a *slight* increase in the size of this structure will have a disproportionate effect on the amount of memory used. E.g. if the structure grew to 132 bytes the memory requirement for the transaction arrays would be about double. With various debugging build flags enabled, the size grows to 160 bytes. But there's no reason to treat that as a build-time bug. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index a580cab794b1c..d1e582707800a 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -680,9 +680,6 @@ static void ipa_validate_build(void) */ BUILD_BUG_ON(GSI_TLV_MAX > U8_MAX); - /* Exceeding 128 bytes makes the transaction pool *much* larger */ - BUILD_BUG_ON(sizeof(struct gsi_trans) > 128); - /* This is used as a divisor */ BUILD_BUG_ON(!IPA_AGGR_GRANULARITY); From patchwork Mon Nov 9 16:56:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 11891913 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEDDCC388F7 for ; Mon, 9 Nov 2020 16:57:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91A3C20789 for ; Mon, 9 Nov 2020 16:57:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KL/auJzZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730795AbgKIQ4n (ORCPT ); Mon, 9 Nov 2020 11:56:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730765AbgKIQ4m (ORCPT ); Mon, 9 Nov 2020 11:56:42 -0500 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FE2AC0613D4 for ; Mon, 9 Nov 2020 08:56:42 -0800 (PST) Received: by mail-il1-x142.google.com with SMTP id l12so6195145ilo.1 for ; Mon, 09 Nov 2020 08:56:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=08abeJNv4qBy1pxGXBXjopswc7xkT9rkpPsBR41Sgkw=; b=KL/auJzZZwrzzz6b44y5xBOCRS7ddo7BcGzGvZoWBcYBjI0XKteyMvgudYWwFSRUUC oMRcZNeftE3rvnBFKQzreOTI6w78f/rpgka+cSUlJQqwsXYa3PYbFS+dTIRnCE2yaJUQ jHnxcoPSC90eDU8kj+QqYrwTjDD8pF+9ZVrtnNQRpxxWFX5GTJ1WM+f4QpGrnb9ouyuT RH8lEupKZpIncv80GVNnTUvx9b0foUYKdxH+J/k5X0Gjbkxzv04TKtfUAkR7mNJ+LSeg 2nPnbNcc/C6KZDnsjAkGSCmKVQMmbgal3Bx6m7YQ7OLRuswEgC8r9/1QnlEJwFxXQiJ0 UmMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=08abeJNv4qBy1pxGXBXjopswc7xkT9rkpPsBR41Sgkw=; b=JoXZ7/bsHzoHhU9FaVabSAEnWY1xu858zugYPsijWvM6G+CQwkxAykMulWgmGX/foZ tTdljzgws4HuAq5i+b2JR1MaPJb345tcBISdq/kXIfmbOSGq6LkuWbU8O4MnU/lynXZ0 +iheepOGBykJRBog9RjFfYab8/RfQV6F/9sdvfPF9Bf3daHII8CautcZiGuI+zEDIXNg Pq9FHKF4HvTvAbanLBtqLMbeFVLmftQp5CVDzZQt9MmzF9UqzCfwArWmcEvjO4qS730F PAItLnb/agOuJsbBx7Hnt/1IMRfFUK86iBmB0qZbf/+kcXNhVJu8010a65lSqDZ5k5ct WR1w== X-Gm-Message-State: AOAM532P+ekOEIfkCAc1qI43UwQsr9A297UPMBHQIHU10Op27X0UxWN1 6PRfwD7esf9m2HJMOfy1GirCIg== X-Google-Smtp-Source: ABdhPJyCbMQfcBEEJALAiGHIGlgTEHuPE3Oxu7sZGivhmdKQAZeCjpJXn/RfFguxPoD9K7s3BKZ41g== X-Received: by 2002:a92:1548:: with SMTP id v69mr9529474ilk.68.1604941001239; Mon, 09 Nov 2020 08:56:41 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id j85sm7576556ilg.82.2020.11.09.08.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:56:40 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 2/4] net: ipa: get rid of a useless line of code Date: Mon, 9 Nov 2020 10:56:33 -0600 Message-Id: <20201109165635.5449-3-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201109165635.5449-1-elder@linaro.org> References: <20201109165635.5449-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Delete a spurious line of code in ipa_hardware_config(). It reads a register value then ignores the value, so is completely unnecessary. Add a missing word in a comment. Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c index d1e582707800a..bfe95a46acaf1 100644 --- a/drivers/net/ipa/ipa_main.c +++ b/drivers/net/ipa/ipa_main.c @@ -335,7 +335,6 @@ static void ipa_hardware_config(struct ipa *ipa) ipa_hardware_config_qsb(ipa); /* Configure aggregation granularity */ - val = ioread32(ipa->reg_virt + IPA_REG_COUNTER_CFG_OFFSET); granularity = ipa_aggr_granularity_val(IPA_AGGR_GRANULARITY); val = u32_encode_bits(granularity, AGGR_GRANULARITY); iowrite32(val, ipa->reg_virt + IPA_REG_COUNTER_CFG_OFFSET); @@ -787,7 +786,7 @@ static int ipa_probe(struct platform_device *pdev) if (ret) goto err_mem_exit; - /* Result is a non-zero mask endpoints that support filtering */ + /* Result is a non-zero mask of endpoints that support filtering */ ipa->filter_map = ipa_endpoint_init(ipa, data->endpoint_count, data->endpoint_data); if (!ipa->filter_map) { From patchwork Mon Nov 9 16:56:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 11891911 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFDE4C55ABD for ; Mon, 9 Nov 2020 16:56:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9417F20789 for ; Mon, 9 Nov 2020 16:56:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mibJzcXp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730899AbgKIQ4x (ORCPT ); Mon, 9 Nov 2020 11:56:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730736AbgKIQ4o (ORCPT ); Mon, 9 Nov 2020 11:56:44 -0500 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D48EC0613D3 for ; Mon, 9 Nov 2020 08:56:43 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id s10so10523016ioe.1 for ; Mon, 09 Nov 2020 08:56:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/Vdf65yzuDCrr/hvWk0aTTXpWc5ZNNvy02Ck48ydFJk=; b=mibJzcXpvmvzLZWpCf4PGwU3zb/b293QV8UyvXMkNooM1NutYjJ1qw9av82rcrIW3j /l9dlo+1o69PfGRzbXggHMQT/Q97/M3TrkrsQIHRMoW+5d4Z03XqY73BzqhGudOBKgRU lz40pPJbQtuOY0nQ0m7dMkvI02iQ2N1UIpkB73Ok2h1FvynxocisqyhBig3jDqbeZ04n Yo5khOIdzpC8JJsCekgN0lNMAkykgpzY3M5U7WA248uwZgUuvI7vG6Vun6OYS7oGicHC Al+25ntjcAed667J28ayHlmmUgdjKsaF0Sve+1uphCEAI8tXF6rIj+DBpTgCAThXiwNb u+qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/Vdf65yzuDCrr/hvWk0aTTXpWc5ZNNvy02Ck48ydFJk=; b=tfNlYGGi/GeWUJW7G3uA3a6+SJ+hh2cAcPUFS3Rypu6YIadt3AgQljlz7biSehOlJ8 sEAFm5ZYehS5KjvugDraTy1UE28CK9NrBhO7f4UVQO5DBwzzyzoqwDtsdMkWzJHArMem uxGPQDslOJZheUsfrjcAUdy4LLnu0HEuu0HuxdVZ4eV55eeaPy7pnSkOUA7jBz1cp7GR CZaqoy6PF0E/v9W3V1SY6EC+xglIfaxse4aOsdlwIUdkEwOAOiEUz2ghF/AqtkZchCKR OKZnqUO2CB3jLJMrBiwRQaIgWIkKH3GWcv57jtKRe+rzRAgujU1o1exd0A9hig9RNvKU z4wA== X-Gm-Message-State: AOAM531+Gr6B2TT4eoAF/hD+5L7MUvOw7xsHZwf49e6OzXkQQj9P6zCo yzJPI/9xJpI5BbqyGm7m12VcJQ== X-Google-Smtp-Source: ABdhPJyCZD37+5GLNdlIUheP0c26GJSlEs5udDlo9v9agnXPx/FZTudP0vSl0QZNMsVb0i1r2UAmfA== X-Received: by 2002:a02:cb99:: with SMTP id u25mr7544235jap.73.1604941002534; Mon, 09 Nov 2020 08:56:42 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id j85sm7576556ilg.82.2020.11.09.08.56.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:56:41 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd Subject: [PATCH net-next 3/4] net: ipa: change a warning to debug Date: Mon, 9 Nov 2020 10:56:34 -0600 Message-Id: <20201109165635.5449-4-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201109165635.5449-1-elder@linaro.org> References: <20201109165635.5449-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org When we determine from hardware what the size of IPA memory is we compare it against what we learned about it from DT. If DT defines a region that's larger than actual memory, we use the smaller actual size and issue a warning. If DT defines a smaller region than actual memory we issue a warning too. But in this case the difference is harmless; so rather than issuing a warning, just provide a debug message instead. Reorder these checks so the one that matters more is done first. Reported-by: Stephen Boyd Signed-off-by: Alex Elder --- drivers/net/ipa/ipa_mem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ipa/ipa_mem.c b/drivers/net/ipa/ipa_mem.c index ecfd1f91fce3b..0cc3a3374caa2 100644 --- a/drivers/net/ipa/ipa_mem.c +++ b/drivers/net/ipa/ipa_mem.c @@ -160,13 +160,13 @@ int ipa_mem_config(struct ipa *ipa) mem_size = 8 * u32_get_bits(val, SHARED_MEM_SIZE_FMASK); /* If the sizes don't match, issue a warning */ - if (ipa->mem_offset + mem_size > ipa->mem_size) { - dev_warn(dev, "ignoring larger reported memory size: 0x%08x\n", - mem_size); - } else if (ipa->mem_offset + mem_size < ipa->mem_size) { + if (ipa->mem_offset + mem_size < ipa->mem_size) { dev_warn(dev, "limiting IPA memory size to 0x%08x\n", mem_size); ipa->mem_size = mem_size; + } else if (ipa->mem_offset + mem_size > ipa->mem_size) { + dev_dbg(dev, "ignoring larger reported memory size: 0x%08x\n", + mem_size); } /* Prealloc DMA memory for zeroing regions */ From patchwork Mon Nov 9 16:56:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 11891909 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0290C2D0A3 for ; Mon, 9 Nov 2020 16:56:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78C8720789 for ; Mon, 9 Nov 2020 16:56:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n2hLQ7PH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730984AbgKIQ4v (ORCPT ); Mon, 9 Nov 2020 11:56:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730914AbgKIQ4p (ORCPT ); Mon, 9 Nov 2020 11:56:45 -0500 Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E905C0613D4 for ; Mon, 9 Nov 2020 08:56:44 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id n12so10508612ioc.2 for ; Mon, 09 Nov 2020 08:56:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e5NRbYsOo+mspumDtpUEM/+OEsVGUUWKaYNV+1cLmV4=; b=n2hLQ7PHR3cMzHVOFkT8wDfl5WJbEyE2GW1mdy0w/0zYQtDrGdHtRa5QQkWlZxb5Hr ZiWMQ4SWjn76IQEWW6bs+66vkbmPjrt3SckLb2CZHkW+p9Wak7QEf5bBuj4VzDJAYANR 26uzhkzrwmiuiGFzwkT2T2MfSJkJlOlFCVp/kYBmRTh15+fi74ulQZ7XJvWatsnYDW0Y T2bG7COiMZqnbvoXO+dF9fb6msEE0blbS5ZJ5IFPkB5PVOHlp3sfiSmFSGsqhdje+l6q lV7Clecaxjr4+g+ck1g54xmyck3PQ7MnZd+oNon49VOoPdS5EzO3Xa5SMgMhdBJ2VOSm MYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e5NRbYsOo+mspumDtpUEM/+OEsVGUUWKaYNV+1cLmV4=; b=s1+IZCmqOO6ggY3cTlH6LvCzB/o7d2Z5n877HA+7Ap/a/aQlreIagTLt+UHT2YRl34 Q8Tf6Yw0WYGtPYj3LBo+BduZAp4XpUGTgRu0q/7T6SGjucFxgFPDry4b4JYFDl/q/Wrp ToJggIZduCp9ZvUCPlMFGhQe6tGdS1Xnxe5AT4V49UrO2Ox57DBxIMYRBR7mWvrGH5sf 8H+KDLhTSJOAtrt1vMqwKY4CWQUhDbtY0Ph3sT8GBM+M9vUHdulqlAXhbOT04re5FoWG 9Hh70b7p58t5zvL4XaD+B/3h7l/rWQDHCZOn/nsa1OX65CvDfa0whlUB9/9wSr8n2Esd +kMw== X-Gm-Message-State: AOAM530kpCBs0uWyOafukv16LOw8q+ML/EBkpB5b8FvLXPhIACMqGRgl MFRfmSrS8xb5xgRBqx81TJVsZRhwwu9uwvq8 X-Google-Smtp-Source: ABdhPJyvpQkup+PqYKcGOz1XWcaLrFZp3jPITkhcqvG5RUmPyI6LkmNKk9zVqFmftzPFPVRQpOtY+g== X-Received: by 2002:a05:6602:21c2:: with SMTP id c2mr10882933ioc.184.1604941003739; Mon, 09 Nov 2020 08:56:43 -0800 (PST) Received: from beast.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id j85sm7576556ilg.82.2020.11.09.08.56.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Nov 2020 08:56:43 -0800 (PST) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next 4/4] net: ipa: drop an error message Date: Mon, 9 Nov 2020 10:56:35 -0600 Message-Id: <20201109165635.5449-5-elder@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201109165635.5449-1-elder@linaro.org> References: <20201109165635.5449-1-elder@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org There is no need for gsi_modem_channel_halt() to report an error, because gsi_generic_command() will already have done that if the command times out. So get rid of the extra message. Signed-off-by: Alex Elder --- drivers/net/ipa/gsi.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ipa/gsi.c b/drivers/net/ipa/gsi.c index 961a11d4fb270..3a5998a037dab 100644 --- a/drivers/net/ipa/gsi.c +++ b/drivers/net/ipa/gsi.c @@ -1661,12 +1661,7 @@ static int gsi_modem_channel_alloc(struct gsi *gsi, u32 channel_id) static void gsi_modem_channel_halt(struct gsi *gsi, u32 channel_id) { - int ret; - - ret = gsi_generic_command(gsi, channel_id, GSI_GENERIC_HALT_CHANNEL); - if (ret) - dev_err(gsi->dev, "error %d halting modem channel %u\n", - ret, channel_id); + (void)gsi_generic_command(gsi, channel_id, GSI_GENERIC_HALT_CHANNEL); } /* Setup function for channels */