From patchwork Mon Jul 23 13:19:27 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540245 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A88B91822 for ; Mon, 23 Jul 2018 13:20:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9685E288DD for ; Mon, 23 Jul 2018 13:20:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 946942891B; Mon, 23 Jul 2018 13:20:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19B03288DD for ; Mon, 23 Jul 2018 13:20:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388414AbeGWOWB (ORCPT ); Mon, 23 Jul 2018 10:22:01 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46783 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388398AbeGWOWB (ORCPT ); Mon, 23 Jul 2018 10:22:01 -0400 Received: by mail-wr1-f67.google.com with SMTP id h14-v6so667710wrw.13; Mon, 23 Jul 2018 06:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pxiUBWT6StcisgZzLlqRhxNfzDdkkF/jCBxlbL42Z2A=; b=AW4KRYnoQOGUx1XBgdosv7O27ajgAbPYNSYNqND9unDnYcZjcDDLSw70F2c027S8ht 57Z4UgUCYSJZHrwi3bcITOQhxmJc45yBROY4EOFmVbPyhhlSKtsdjypUuGN+h7vJAxC3 d2TPPqg2Wic1czm9iys+B9/G21JafS1mZie0KQG+qT/dFGhlJydQwq366PFBFzjEsd1t jb6hm2dQZO+SZmKo2BEUGFHSyO4p/M2qrxGorm96ySzw9/mnVNRCybXc29FT0pE9LV6s vNBIH5h+ZOrrQGGuKKYtmrCYyfeq17Q+JSDeS1nF4d0Fvd68dI5w0aX6xd6xObRvWLni Cjlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pxiUBWT6StcisgZzLlqRhxNfzDdkkF/jCBxlbL42Z2A=; b=PuqPX16mkfqi1Z6qvVMSIbAXOJdulJPd72CIOKj6uQO9rasc2+cGOLqsjae6NYubND Uz6j1MrAje7YJLRBswKcyimAdTB0AFXkPTnc7ity+4i93agbmqUtfpEnka1h8R6NTDfr kbkQ+pcfWNlJ589CcyrDlJyREzGL4/mSu4fyndMhMMGFPQDSuc5xPWBaXjID1zlnztAx /xOlvW21HhCKRvet/4li2USxNKfbj5qoCHPcnYzuGxSLJFOjUUZvtA9WJkrHIjTnq+mY /2JzK6WqttcEygvoRugnRo9hSbbtxBlRhZRD4bn0XJDuXoKMYrnidkpgwEOiR0Foe/Rr WqSg== X-Gm-Message-State: AOUpUlHne+vXY2NokmlfwsD+kZM/nQiwJNyN4fZ39nvRVHj0Ph3QniVr fRL1Chg69l7373k+pQqBOCk= X-Google-Smtp-Source: AAOMgpfAJDu2j+JSKY8fg8gV0p4NCK7ELMBB2drrFdiWpFnQ+7xEKDCoHcqje4ef8rUB1M4vMCEe3Q== X-Received: by 2002:adf:bb08:: with SMTP id r8-v6mr8189205wrg.244.1532352046311; Mon, 23 Jul 2018 06:20:46 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:45 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 01/11] touchscreen: ft5x06: Use octal permissions Date: Mon, 23 Jul 2018 18:49:27 +0530 Message-Id: <20180723131954.30739-11-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(gain, S_IWUSR | S_IRUGO, WORK_REGISTER_GAIN, WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(offset, S_IWUSR | S_IRUGO, WORK_REGISTER_OFFSET, WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD, WARNING: Symbolic permissions 'S_IWUSR | S_IRUGO' are not preferred. Consider using octal permissions '0644'. +static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. + debugfs_create_u16("num_x", S_IRUSR, tsdata->debug_dir, &tsdata->num_x); WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. + debugfs_create_u16("num_y", S_IRUSR, tsdata->debug_dir, &tsdata->num_y); WARNING: Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'. + debugfs_create_file("mode", S_IRUSR | S_IWUSR, WARNING: Symbolic permissions 'S_IRUSR' are not preferred. Consider using octal permissions '0400'. + debugfs_create_file("raw_data", S_IRUSR, Signed-off-by: Harshit Jain --- drivers/input/touchscreen/edt-ft5x06.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c index 1e18ca0d1b4e..ea4026682e79 100644 --- a/drivers/input/touchscreen/edt-ft5x06.c +++ b/drivers/input/touchscreen/edt-ft5x06.c @@ -479,16 +479,16 @@ static ssize_t edt_ft5x06_setting_store(struct device *dev, } /* m06, m09: range 0-31, m12: range 0-5 */ -static EDT_ATTR(gain, S_IWUSR | S_IRUGO, WORK_REGISTER_GAIN, +static EDT_ATTR(gain, 0644, WORK_REGISTER_GAIN, M09_REGISTER_GAIN, 0, 31); /* m06, m09: range 0-31, m12: range 0-16 */ -static EDT_ATTR(offset, S_IWUSR | S_IRUGO, WORK_REGISTER_OFFSET, +static EDT_ATTR(offset, 0644, WORK_REGISTER_OFFSET, M09_REGISTER_OFFSET, 0, 31); /* m06: range 20 to 80, m09: range 0 to 30, m12: range 1 to 255... */ -static EDT_ATTR(threshold, S_IWUSR | S_IRUGO, WORK_REGISTER_THRESHOLD, +static EDT_ATTR(threshold, 0644, WORK_REGISTER_THRESHOLD, M09_REGISTER_THRESHOLD, 0, 255); /* m06: range 3 to 14, m12: (0x64: 100Hz) */ -static EDT_ATTR(report_rate, S_IWUSR | S_IRUGO, WORK_REGISTER_REPORT_RATE, +static EDT_ATTR(report_rate, 0644, WORK_REGISTER_REPORT_RATE, NO_REGISTER, 0, 255); static struct attribute *edt_ft5x06_attrs[] = { @@ -739,12 +739,12 @@ edt_ft5x06_ts_prepare_debugfs(struct edt_ft5x06_ts_data *tsdata, if (!tsdata->debug_dir) return; - debugfs_create_u16("num_x", S_IRUSR, tsdata->debug_dir, &tsdata->num_x); - debugfs_create_u16("num_y", S_IRUSR, tsdata->debug_dir, &tsdata->num_y); + debugfs_create_u16("num_x", 0400, tsdata->debug_dir, &tsdata->num_x); + debugfs_create_u16("num_y", 0400, tsdata->debug_dir, &tsdata->num_y); - debugfs_create_file("mode", S_IRUSR | S_IWUSR, + debugfs_create_file("mode", 0600, tsdata->debug_dir, tsdata, &debugfs_mode_fops); - debugfs_create_file("raw_data", S_IRUSR, + debugfs_create_file("raw_data", 0400, tsdata->debug_dir, tsdata, &debugfs_raw_data_fops); } From patchwork Mon Jul 23 13:19:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540231 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EFDDD13BB for ; Mon, 23 Jul 2018 13:20:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD54428897 for ; Mon, 23 Jul 2018 13:20:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BFC8728879; Mon, 23 Jul 2018 13:20:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0576E28879 for ; Mon, 23 Jul 2018 13:20:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388299AbeGWOVL (ORCPT ); Mon, 23 Jul 2018 10:21:11 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:46706 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388053AbeGWOVK (ORCPT ); Mon, 23 Jul 2018 10:21:10 -0400 Received: by mail-wr1-f67.google.com with SMTP id h14-v6so664878wrw.13; Mon, 23 Jul 2018 06:19:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=BObdpk6HN1vRa6o+1/RlFHnMb4FU0uQpaSfZRoJcZ8s=; b=DMoX2Dvewx/sZdU+jLETbYnTbdeJNDOydYlIVogh3RP/72uXXI/PIIxsH0aNm7ylUY laGSbk1SAiKsN1C1ocyAZhAZ3l00Lgufv41am9OShlFZIMV5crWPQpSvj7WuAXKebiTX 8gOZhd+pbDpEd8wKEzKPDJ56L9DRc89pTf7E0mRRtw2iq3weLqc6dJTrJrbyRSB6gkR+ pOCkxfc8HJhZpKjKRcXPQjVfSB51o8oJTrkRiV+MJiwN62ztdEET6jxErNh++pJOKBCg nvlo1wurFv4aSA3uEwmArnFCpUjfFFy1CjaHucmxdOQUSwfC/mECe1B0PRkPFyIn5R4e OUUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=BObdpk6HN1vRa6o+1/RlFHnMb4FU0uQpaSfZRoJcZ8s=; b=PYeiiMJTjSNBTqoVENBUZbqb/FYMXAUsOHW9f5cEuM3XRyb7YsWSnCRSg+DQ83eQcy UNdqRJ7BMLWwRPPDs6f1YMT9P8GmeGFKCAbVh0OGzk/1jb1yJ+hk7WiQZBcytAV9U8Rl 50Q8Sseixbu5HPDVPKjutj86LxmJIi3b3Zd7n0TN6oYtoPeQs2YSn2hAE8YP6TBuAYwE mYegX3uBGARegGEN85D+xUdE7eA2NFNSv/grQ9kAm4QYYSH9bPMbWh1yDErSToWF50PS 5ppcNUAi8YuiJhZ0lyWnXfQyXu28HekRhSn+wmYOsAjqMiJ/G5giLtB8cP/RlMa0taG0 Gmvw== X-Gm-Message-State: AOUpUlFsf6NKSrJW6ktLDi/pxf5Wm62SGozQT+tNAzKQmOiIBYq5zwP/ hSlGxAjtMDXT85JJkVzU+HY= X-Google-Smtp-Source: AAOMgpeUExfpGhaclgivaM62ji8SyjD1N9yfOu7+fcJc9Cpc6TuP+dBvw0Xac7wnxeq8x8LFw4koKQ== X-Received: by 2002:adf:96b2:: with SMTP id u47-v6mr8741890wrb.204.1532351996573; Mon, 23 Jul 2018 06:19:56 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.19.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:19:55 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Michael Hennerich , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/11] touchscreen: ad7877: Use octal permissions Date: Mon, 23 Jul 2018 18:49:17 +0530 Message-Id: <20180723131954.30739-1-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/ad7877.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ad7877.c b/drivers/input/touchscreen/ad7877.c index 5cfe477ec992..4b4a9d84195e 100644 --- a/drivers/input/touchscreen/ad7877.c +++ b/drivers/input/touchscreen/ad7877.c @@ -461,7 +461,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \ return v; \ return sprintf(buf, "%u\n", (unsigned) v); \ } \ -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); +static DEVICE_ATTR(name, 0444, name ## _show, NULL); SHOW(aux1) SHOW(aux2) From patchwork Mon Jul 23 13:19:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540253 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 397041822 for ; Mon, 23 Jul 2018 13:21:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28BB72898E for ; Mon, 23 Jul 2018 13:21:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 260E92893E; Mon, 23 Jul 2018 13:21:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C1B1E28990 for ; Mon, 23 Jul 2018 13:21:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388058AbeGWOVR (ORCPT ); Mon, 23 Jul 2018 10:21:17 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35295 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388053AbeGWOVR (ORCPT ); Mon, 23 Jul 2018 10:21:17 -0400 Received: by mail-wm0-f66.google.com with SMTP id o18-v6so1213576wmc.0; Mon, 23 Jul 2018 06:20:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6COwS89nu26Msom+rscHlSZ4QQPeZOVMv7pa6eA3eB0=; b=uJM8H7I8utIsCco9sgd5yB2PbMe3XrL1nIcTQLwnAWhXEVu6zKg16tQeLFFh2kj9Y/ YXBmykPP14UewtxlzO9FtaJHbY6CUmntNz8lYfJmnE8SNdL2vP8rIVv0dB1s52LylzBF sG0c4wIFM5RlWVjQ6Dc0Y+UBlH7kp6Qlx42705WmRi6d1+hRUtsxGbFZ89Zt83yiTXnf q9Zz4n2DNIvEztdXMyUq968OrX5N28rMXq25gm9Q1I+HC4O9xg+P7RnvbEoh7zcSa9pX PHvbCWSvm/o62Sz8Mh0PcCyKTrZnRXP9u2rQTgy4gbDO3jNl9UFibpUhZ+IqeMDK9pXz +QaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6COwS89nu26Msom+rscHlSZ4QQPeZOVMv7pa6eA3eB0=; b=JHLTZt2Aghxt1CurH+WHlcF/emMlly6JnjONT3qNk+qFM/heahH2xk4wGm8YxMYVan H5uLe2Y64DYUJv6wdN85ale2NfzCLaIfBKT8vCR2aPpedP6iOTUWPaGTpCszr/U+way5 FZuuDfJix8/xo0eKT8MlWUmH20fZHxRiuSOm1pbEjcqgRp/u0nRlHvifzltY7iT4tESw 323TVodjXBvlSjuXibcfS3m87pZfrzidcyaH2kIDVEK33xSFzWaYR2ykc8DBXUfTZc6f djb6En9jbEg5dcjASmHUOj+3qZEB9//VB927O/layZepL4sUJecyvCnTUPNDnx8p6IRa nPJw== X-Gm-Message-State: AOUpUlF5HA/487zyhx77/v2zSId8aiS1kh8UOaiqKH5ASaJByLl1H5N8 ezMSmZdrv8rbdCP5t+zE4kc= X-Google-Smtp-Source: AAOMgpdWxJkq+8eBjI6Oh8GR5Zz8qmY2hZnDkLBM+kVkg53a8LXOg/U+T32aBiZ1YbinX8yuW+/3vQ== X-Received: by 2002:a1c:e189:: with SMTP id y131-v6mr7324868wmg.44.1532352002585; Mon, 23 Jul 2018 06:20:02 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:02 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/11] touchscreen: ad7846: Use octal permissions Date: Mon, 23 Jul 2018 18:49:18 +0530 Message-Id: <20180723131954.30739-2-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(pen_down, S_IRUGO, ads7846_pen_down_show, NULL); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/ads7846.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index a2f45aefce08..7c07de0802de 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -431,7 +431,7 @@ name ## _show(struct device *dev, struct device_attribute *attr, char *buf) \ return v; \ return sprintf(buf, "%u\n", adjust(ts, v)); \ } \ -static DEVICE_ATTR(name, S_IRUGO, name ## _show, NULL); +static DEVICE_ATTR(name, 0444, name ## _show, NULL); /* Sysfs conventions report temperatures in millidegrees Celsius. @@ -561,7 +561,7 @@ static ssize_t ads7846_pen_down_show(struct device *dev, return sprintf(buf, "%u\n", ts->pendown); } -static DEVICE_ATTR(pen_down, S_IRUGO, ads7846_pen_down_show, NULL); +static DEVICE_ATTR(pen_down, 0444, ads7846_pen_down_show, NULL); static ssize_t ads7846_disable_show(struct device *dev, struct device_attribute *attr, char *buf) From patchwork Mon Jul 23 13:19:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540235 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 946B5A516 for ; Mon, 23 Jul 2018 13:20:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7295228909 for ; Mon, 23 Jul 2018 13:20:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FCAA28897; Mon, 23 Jul 2018 13:20:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 27E442886F for ; Mon, 23 Jul 2018 13:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388365AbeGWOVU (ORCPT ); Mon, 23 Jul 2018 10:21:20 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:45570 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388053AbeGWOVU (ORCPT ); Mon, 23 Jul 2018 10:21:20 -0400 Received: by mail-wr1-f65.google.com with SMTP id t13-v6so668500wrv.12; Mon, 23 Jul 2018 06:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Mp3LaNPPkhyZvfO++aStv3wm/x6qr01HzaC/J4eqGS0=; b=fkG6z/q22Nfyi0Lo4lQfKZBgQ3V1x6u67NnDKgixCvienyGfofA1vKheQ9N0o3hbi7 S9bd6XgwcGIcWcf7g7vmwo34dLr9qGji7hChvImnYCJiB/rURApFghr2PYw4Sh3DR3XQ sczo+h+CzSUs3zbeWW4LEY3yTYtjX8htvqdyFYQg9HIbzUqFDY1a0lKseZkPAHi7owYT fwLmusgGBRapdXmr/tJTFyxVY2szm6XVASAZl/FZ6d7HGvAo9RdHYe3qJvPTxongYHRu VbEgQ/OOmWGPFzfBepxex8VDwm+R5DhHVrOrzPYWwXqtyRIo5t4PCL6Da4aMjhn2j/pE t9gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Mp3LaNPPkhyZvfO++aStv3wm/x6qr01HzaC/J4eqGS0=; b=LeigdGRPgqbduuHr1F+uaYl6s46KXXTZJC6R71qoSSsuKCdA0Jm35EZei50ryXXXkS cNt6rSlJxsvqezH/ozNVPSXFbGOXfDfwtms/szzIvPQi9+t7w50WdH4g/3x3jlS4Dvzc qMTKtfEYn3OWtgRvOhAC/7zkxoedSryChI5/aMFLmmtzzMfMKLV40+IxabNEvwpHzT0r ldYbfYLSD6u11CP69pNhE/5Jjd7ou9+Z03cSfYLOe4Rzzm24WzOhVepZEPzIJu6SVBV+ FJD5nRvplx0ZRixY8CXfIhhgknfc8F2CuuyvShkxbe/W23siFA4mGJEwtCmQwhjSpYtU /tEw== X-Gm-Message-State: AOUpUlFrzQPROTNpoP5zZZ0u9xP7nuLzShzzFS/7R/Me4hOyVZ1mzkQA DiNUIeKNVxyZuT1W/w3kQF4= X-Google-Smtp-Source: AAOMgpfoHw7jRYPdRYD7n91OZf77ykQk0S89AdxVyWtLbge81dwW7fKjo9k94v1MrVKSCMRl9KE4QQ== X-Received: by 2002:a5d:61ca:: with SMTP id q10-v6mr8496673wrv.33.1532352006049; Mon, 23 Jul 2018 06:20:06 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:05 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Nick Dyer , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 04/11] touchscreen: amtel: Use octal permissions Date: Mon, 23 Jul 2018 18:49:19 +0530 Message-Id: <20180723131954.30739-3-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, mxt_fw_version_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, mxt_hw_version_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mxt_update_fw_store); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/atmel_mxt_ts.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/input/touchscreen/atmel_mxt_ts.c b/drivers/input/touchscreen/atmel_mxt_ts.c index 54fe190fd4bc..5202a8244f1d 100644 --- a/drivers/input/touchscreen/atmel_mxt_ts.c +++ b/drivers/input/touchscreen/atmel_mxt_ts.c @@ -2892,10 +2892,10 @@ static ssize_t mxt_update_fw_store(struct device *dev, return count; } -static DEVICE_ATTR(fw_version, S_IRUGO, mxt_fw_version_show, NULL); -static DEVICE_ATTR(hw_version, S_IRUGO, mxt_hw_version_show, NULL); -static DEVICE_ATTR(object, S_IRUGO, mxt_object_show, NULL); -static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mxt_update_fw_store); +static DEVICE_ATTR(fw_version, 0444, mxt_fw_version_show, NULL); +static DEVICE_ATTR(hw_version, 0444, mxt_hw_version_show, NULL); +static DEVICE_ATTR(object, 0444, mxt_object_show, NULL); +static DEVICE_ATTR(update_fw, 0200, NULL, mxt_update_fw_store); static struct attribute *mxt_attrs[] = { &dev_attr_fw_version.attr, From patchwork Mon Jul 23 13:19:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540251 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0D1C91822 for ; Mon, 23 Jul 2018 13:21:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F1A6828956 for ; Mon, 23 Jul 2018 13:21:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EF1A528974; Mon, 23 Jul 2018 13:21:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FAF428988 for ; Mon, 23 Jul 2018 13:21:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388394AbeGWOV0 (ORCPT ); Mon, 23 Jul 2018 10:21:26 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:35009 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388053AbeGWOV0 (ORCPT ); Mon, 23 Jul 2018 10:21:26 -0400 Received: by mail-wr1-f65.google.com with SMTP id a3-v6so702653wrt.2; Mon, 23 Jul 2018 06:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PXXkeOHx2j7gEKcIiCiqq0iwGaZjTCw597NbTI8OYKw=; b=KZqtpQyFmtxoZog5Q9r4DNY1x36ls5djqoV4Rt2GWTkT3ssG0D5LGIczwkbh+Gk/l9 Z+G9loS3xl79w783tBJ2AjN94MbEjodrk+8pRgXGpeLsk/Sl155vfxb5feALWFzZUEen 4mhoRLlHMly95RCliPCuvKhlMIfhqXUrZsYw/6Oax9OOb2r8+UL1yvbnRnViin2psksN pNg/k5hpn6WsHcsHGgqFF6svM4z7bY9k7DuA7AQl5cHPcwZNkp6hZL2m3k4Z18a8Zpoi aflzkiJetGwCML0bF/WaICZ6bY3U3kA5Lhaf1PEaRilIqPTyOZBAch8Oo3OPkW/SCP9I fsIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PXXkeOHx2j7gEKcIiCiqq0iwGaZjTCw597NbTI8OYKw=; b=Rmn7IuqNb7nRKGl7Q/wGUyHK2Bb3BtjwtVIHNiBvDj7yoFyrm1V2s35h21QeWxN1lQ ULD76Y4jh7TVbhs7qbYLa2xZfs9gGp6uUTrO8f42YpRq4T3QemuqRMzQVrrqWUEq2Jn4 Sh+l8SoXdNlmMgR3lqrYdGLdL5I+f4BH2KiXT8ONUZzeJCMbazJmqo0LS4MBc5+YcC2r D2YAjSeMPBLixTjp2TYZlxPa1CS8srzhMB0xPxT/VcdAH5NxAbaI+vQXl2ubKJpVzCXL 2ElEbPYcPH45UWkYZfT9DFdgDtrh56FZ3ASwZihIe579b7FfsEKBpW6y6tpuYxczTvdl TIwA== X-Gm-Message-State: AOUpUlF8GYbHYLh30Z9n01UA5Ifo+mjT319LpxpbCmIMLHA8XiYkF2zr 6a0oEP9iUFlrH6qEoR+J9fA= X-Google-Smtp-Source: AAOMgpewtDFAQyXGAbnusgP2c86ijuWilYprggzGFaH4yZr5wcsrBztnf0bhJreH1HWGQfyBRAcpjw== X-Received: by 2002:adf:c98d:: with SMTP id f13-v6mr8523872wrh.148.1532352011804; Mon, 23 Jul 2018 06:20:11 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:11 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , Greg Kroah-Hartman , Joe Perches , Guenter Roeck , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/11] touchscreen: elants: Use octal permissions Date: Mon, 23 Jul 2018 18:49:20 +0530 Message-Id: <20180723131954.30739-4-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw) WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. + .dattr = __ATTR(_field, S_IRUGO, \ Signed-off-by: Harshit Jain --- drivers/input/touchscreen/elants_i2c.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/elants_i2c.c b/drivers/input/touchscreen/elants_i2c.c index d21ca39b0fdb..9717b7c3bb6f 100644 --- a/drivers/input/touchscreen/elants_i2c.c +++ b/drivers/input/touchscreen/elants_i2c.c @@ -1000,8 +1000,8 @@ static ssize_t show_iap_mode(struct device *dev, } static DEVICE_ATTR_WO(calibrate); -static DEVICE_ATTR(iap_mode, S_IRUGO, show_iap_mode, NULL); -static DEVICE_ATTR(update_fw, S_IWUSR, NULL, write_update_fw); +static DEVICE_ATTR(iap_mode, 0444, show_iap_mode, NULL); +static DEVICE_ATTR(update_fw, 0200, NULL, write_update_fw); struct elants_version_attribute { struct device_attribute dattr; @@ -1016,7 +1016,7 @@ struct elants_version_attribute { __ELANTS_FIELD_SIZE(_field)) #define ELANTS_VERSION_ATTR(_field) \ struct elants_version_attribute elants_ver_attr_##_field = { \ - .dattr = __ATTR(_field, S_IRUGO, \ + .dattr = __ATTR(_field, 0444, \ elants_version_attribute_show, NULL), \ .field_offset = offsetof(struct elants_data, _field), \ .field_size = __ELANTS_VERIFY_SIZE(_field), \ From patchwork Mon Jul 23 13:19:21 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540233 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7046F90E3 for ; Mon, 23 Jul 2018 13:20:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 50481288DD for ; Mon, 23 Jul 2018 13:20:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4CA45288BB; Mon, 23 Jul 2018 13:20:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6B5B9288CA for ; Mon, 23 Jul 2018 13:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388466AbeGWOVc (ORCPT ); Mon, 23 Jul 2018 10:21:32 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41849 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388053AbeGWOVb (ORCPT ); Mon, 23 Jul 2018 10:21:31 -0400 Received: by mail-wr1-f66.google.com with SMTP id j5-v6so679068wrr.8; Mon, 23 Jul 2018 06:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4Xh647zvBThDev2pQsWZu7xDkeLtpoOMx3tsadwRcCw=; b=tz2f746ZzNpQOMcoUMmm/PXZD/4d53PP4bktpYiW8FDXF1/tR8YrsHPKe2v7ss+QJw 3qmYSS4x4xERtX7Pq8sAKv70a+pNUtp6WLP+KFPkE0YtzLb5P+xkhhM2alUvlFv5xnqu vsOtGaTQQTNo062Nb/dL7Sb8d1SZ245YpqERiJxPbgZ2Gt55t7mKENOtkxYR+aiqp3Wy 4uaGV68yb8DZxmNuIiqR3RPxXF7DfpuXTkwQ9O/CuvBcNeBE4Gwz4jaMU26T0Rpstlax C+v2u8CWjiQvF4Joc7dAV2iaZfl6ajKbdLXkX+OxiLvrx/UuKEx8x+e9/WlwptN7nPgC CcSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4Xh647zvBThDev2pQsWZu7xDkeLtpoOMx3tsadwRcCw=; b=fIFtisHd0Imcku28KRZocfdRkdC0Se2J9tNdinKc1VnWxclhdITfrf3XmRtkgbZ4sU nZUI/HnsWxB+9EVfumCofD2YAeCPNQzWIk9ppEpnyfUZybIkQKEFhGZAxcQ8HCSV5tKK ztUPgwEYoRrVmfxaQj6ySuj621tzzwm/BKPgxR1zl/5BYmbuK9syIFM8fT5a5z9snF48 ZNysuI1wTU3X4YIsB1QpeZ1Xs1KGgIDtKfrcXi9XenLz2cHY0IemrpRBhttyMa4klOqZ 8Ob+tKLomgVFVufeX/Obv5g+t1tf227ogwd5HhtM02vyi1R/yJQ/fXJS5FBxwE+InRJ4 1UPg== X-Gm-Message-State: AOUpUlGpo/QNusdkSTf8f84ql69vWLsae40B0G3he9bgzK00aYXiwt78 D2Oj5oI4cuW00tMGJTBmz3o= X-Google-Smtp-Source: AAOMgpduX0jXS4Ag8rnt7nW0qzNnoxraPhzShNmQtHfO/X+U4dbroGNhfdFeJp2b8ks7iqPsQgaPog== X-Received: by 2002:adf:94e2:: with SMTP id 89-v6mr8326367wrr.48.1532352017648; Mon, 23 Jul 2018 06:20:17 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:17 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] touchscreen: ili210x: Use octal permissions Date: Mon, 23 Jul 2018 18:49:21 +0530 Message-Id: <20180723131954.30739-5-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(calibrate, S_IWUSR, NULL, ili210x_calibrate); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/ili210x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ili210x.c b/drivers/input/touchscreen/ili210x.c index 6f76eeedf465..07526a6f2cb7 100644 --- a/drivers/input/touchscreen/ili210x.c +++ b/drivers/input/touchscreen/ili210x.c @@ -169,7 +169,7 @@ static ssize_t ili210x_calibrate(struct device *dev, return count; } -static DEVICE_ATTR(calibrate, S_IWUSR, NULL, ili210x_calibrate); +static DEVICE_ATTR(calibrate, 0200, NULL, ili210x_calibrate); static struct attribute *ili210x_attributes[] = { &dev_attr_calibrate.attr, From patchwork Mon Jul 23 13:19:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540249 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF1C71822 for ; Mon, 23 Jul 2018 13:21:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BF76128977 for ; Mon, 23 Jul 2018 13:21:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BD7A428916; Mon, 23 Jul 2018 13:21:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 64210288E0 for ; Mon, 23 Jul 2018 13:21:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388053AbeGWOVh (ORCPT ); Mon, 23 Jul 2018 10:21:37 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:40073 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388007AbeGWOVh (ORCPT ); Mon, 23 Jul 2018 10:21:37 -0400 Received: by mail-wr1-f65.google.com with SMTP id t6-v6so687682wrn.7; Mon, 23 Jul 2018 06:20:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=fSmEWRwUYnjsGHoSChUGuM8ZsNJS4DVqQW7Vxtno9sU=; b=AFaN895m7TYCRdHGAcgqQzkrKHb2IxQKZQhx35Bb2A78ZJGTDMXeNfbp45b9TYl/LC naOkSEPJ1KDcWh4THTNmxpPbOoBMnzuetIW4c38Bd9nBgzAT/OdVcoDZe+27PVJWL2AY E/zBdcAQOv5jTtkIpZcE5Tk5pwi0rdcGQfnCzqHqDLGqVUOFsG9C4hrpgMX+Nr4WSJBN myNYWJP8r70BaSRFjLSKfmiP00iyP66zt4+iM81yFgrbACJCl5szJPqHCmVrsD/Hg01p jvAUx8+3+N2pYOX8xiDesFhCzgfikXwXpwqg+idhjV4QSdLAXr515BPA1jSpIUdK1jAm 9HpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=fSmEWRwUYnjsGHoSChUGuM8ZsNJS4DVqQW7Vxtno9sU=; b=G9S1wf6lkBt4iUuiukrSaEHREKjiAuhtgv6b75FVkjIjZg8ecIY6BnSreNeaZfSyqi zcE3vwfTLqoCyh0MpQgxXwU4YIXwK2FOc9kUH2wQ/d7poiBjNc1TM3Gev6eOIROl0nHo TfIoGQVA6hu6Zu2VHfRQE9qcBrk779DVEJ3gdQT29KMbSQtzJYYdutMyTP/eH/4m4AfY MyuqYnhuM8pg2tLKhp0f/mychw/EgeSZXRRQjtPD4zQiML9Og0DBj+f3suFXe6egAW3y 4EGHgwjRNHmLAdMXeB4Kb75edfbXHwkaR+SxbAMmfrpvb9mWedCUE3j7VEZt4ybd7ygH 6xAQ== X-Gm-Message-State: AOUpUlHvG8xU4wNnWJbYG7fnf2ro2A6AKnYDpiJ1eHnlM3zr2zh0LXxj /14Ttdcdu+mYaq+hYzTYkF07sJ4v09Ugrqvb X-Google-Smtp-Source: AAOMgpci+IKGmFY5lORjI6dHx8vRyCygltj5jxKsOog3hRh7OZ5cEWq80xeD/4kvjWXiofGIU/AFtA== X-Received: by 2002:adf:9d81:: with SMTP id p1-v6mr8869047wre.12.1532352023125; Mon, 23 Jul 2018 06:20:23 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:22 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 07/11] touchscreen: mc13783: Use octal permissions Date: Mon, 23 Jul 2018 18:49:22 +0530 Message-Id: <20180723131954.30739-6-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO | S_IWUSR' are not preferred. Consider using octal permissions '0644'. +module_param(sample_tolerance, uint, S_IRUGO | S_IWUSR); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/mc13783_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/mc13783_ts.c b/drivers/input/touchscreen/mc13783_ts.c index ef64f36c5ffc..4e33349f101e 100644 --- a/drivers/input/touchscreen/mc13783_ts.c +++ b/drivers/input/touchscreen/mc13783_ts.c @@ -25,9 +25,9 @@ #define DEFAULT_SAMPLE_TOLERANCE 300 static unsigned int sample_tolerance = DEFAULT_SAMPLE_TOLERANCE; -module_param(sample_tolerance, uint, S_IRUGO | S_IWUSR); +module_param(sample_tolerance, uint, 0644); MODULE_PARM_DESC(sample_tolerance, - "If the minimal and maximal value read out for one axis (out " + "If the minimal and maximum value read out for one axis (out " "of three) differ by this value (default: " __stringify(DEFAULT_SAMPLE_TOLERANCE) ") or more, the reading " "is supposed to be wrong and is discarded. Set to 0 to " From patchwork Mon Jul 23 13:19:23 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540237 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E6C6913BB for ; Mon, 23 Jul 2018 13:20:36 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D632D2893B for ; Mon, 23 Jul 2018 13:20:36 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D40762890F; Mon, 23 Jul 2018 13:20:36 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 51D7E28935 for ; Mon, 23 Jul 2018 13:20:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388085AbeGWOVl (ORCPT ); Mon, 23 Jul 2018 10:21:41 -0400 Received: from mail-wr1-f67.google.com ([209.85.221.67]:37256 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388007AbeGWOVk (ORCPT ); Mon, 23 Jul 2018 10:21:40 -0400 Received: by mail-wr1-f67.google.com with SMTP id q10-v6so694570wrd.4; Mon, 23 Jul 2018 06:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2lBRNt3VS0Qb/OG643x3L/xzzUlcGhJNVOiSivemA4I=; b=d08syMKrWbhuyQ9970IhjwlhgLA7QMBT4Rghe7By7+4dYVfCYx0SEaGYIgWX8cJssS hTrdSYQcdR5psXpwPabpu9LaqfY88W+FdwXQp3zrqr9xtpFH0jK43JPT5T6jhCplce1w QKTFLKin2MNSe3hDLxKw9qeua+cWpk5hkyo/3KmvGrK1ZJfp6DzqEPVzBS6sprq3JNBU Z7EcFHBcyW4vG48MEVL9r9LBh1C1F7UsM0gCNOoBDYMDGiN/fJ4b8WtGJ5bxQQsMj3Nn /szkqV0qhyNaY8yAsXCbka5QuvRr0OhTB+/mPB8RgmmKzORzgrOMxxYFjIR4HIlCe26s vSBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2lBRNt3VS0Qb/OG643x3L/xzzUlcGhJNVOiSivemA4I=; b=a0tg7J/Z3eDVGa9ZnEa0FC5W7uQvcx58xEkT75QU6xhSe/p9a5daLuNl4w5hxRO22P OH9/UGzmG8O/k6fiR8eqpTFbobwpHvGzHswNHB1Tnz0pfNvMk9UTrb43SD5kD/pFys7g 6ISQWrFM2Btj/sDHpH4farWkqkQDGx6a9zr9IryFq+JiXY3JE+uT5yJP8xfMZUWEcwXN +/g0dzCq9D+rWZm/IraP7aiC/Ey9rGvUCcc9IIAKHdGXR3OoTzPGGJGIMU//wQiyuphU jrS3pL1ELUB57/hnAgJ2jhMGub81sOvlnvb/MxjmTKQyvT9Dntb9s5K97TjtYyjNfRTp +tqA== X-Gm-Message-State: AOUpUlEHJHqAZKdqxSNSgFiiVlF2yPFmBDr9jEx0XNd4/+SsEGYbKy32 Z/pwZT5sgC+klGnWMYWpgHc= X-Google-Smtp-Source: AAOMgpdqf1bNy7WuVpq1LFo1nEOSof0KqEW36uzxxNSqpPUURcys9Ow0aEPSiAjdZ1H+YNs3s4tSxw== X-Received: by 2002:a5d:4e92:: with SMTP id e18-v6mr790091wru.32.1532352026426; Mon, 23 Jul 2018 06:20:26 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:25 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Sangwon Jee , Simon Budig , Andi Shyti , Luca Ceresoli , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/11] touchscreen: melfas: Use octal permissions Date: Mon, 23 Jul 2018 18:49:23 +0530 Message-Id: <20180723131954.30739-7-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mip4_sysfs_fw_update); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, mip4_sysfs_read_fw_version, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, mip4_sysfs_read_hw_version, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(product_id, S_IRUGO, mip4_sysfs_read_product_id, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(ic_name, S_IRUGO, mip4_sysfs_read_ic_name, NULL); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/melfas_mip4.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c index 430a2bc5f7ca..f7fd940e61ea 100644 --- a/drivers/input/touchscreen/melfas_mip4.c +++ b/drivers/input/touchscreen/melfas_mip4.c @@ -1332,7 +1332,7 @@ static ssize_t mip4_sysfs_fw_update(struct device *dev, return count; } -static DEVICE_ATTR(update_fw, S_IWUSR, NULL, mip4_sysfs_fw_update); +static DEVICE_ATTR(update_fw, 0200, NULL, mip4_sysfs_fw_update); static ssize_t mip4_sysfs_read_fw_version(struct device *dev, struct device_attribute *attr, @@ -1354,7 +1354,7 @@ static ssize_t mip4_sysfs_read_fw_version(struct device *dev, return count; } -static DEVICE_ATTR(fw_version, S_IRUGO, mip4_sysfs_read_fw_version, NULL); +static DEVICE_ATTR(fw_version, 0444, mip4_sysfs_read_fw_version, NULL); static ssize_t mip4_sysfs_read_hw_version(struct device *dev, struct device_attribute *attr, @@ -1379,7 +1379,7 @@ static ssize_t mip4_sysfs_read_hw_version(struct device *dev, return count; } -static DEVICE_ATTR(hw_version, S_IRUGO, mip4_sysfs_read_hw_version, NULL); +static DEVICE_ATTR(hw_version, 0444, mip4_sysfs_read_hw_version, NULL); static ssize_t mip4_sysfs_read_product_id(struct device *dev, struct device_attribute *attr, @@ -1398,7 +1398,7 @@ static ssize_t mip4_sysfs_read_product_id(struct device *dev, return count; } -static DEVICE_ATTR(product_id, S_IRUGO, mip4_sysfs_read_product_id, NULL); +static DEVICE_ATTR(product_id, 0444, mip4_sysfs_read_product_id, NULL); static ssize_t mip4_sysfs_read_ic_name(struct device *dev, struct device_attribute *attr, @@ -1418,7 +1418,7 @@ static ssize_t mip4_sysfs_read_ic_name(struct device *dev, return count; } -static DEVICE_ATTR(ic_name, S_IRUGO, mip4_sysfs_read_ic_name, NULL); +static DEVICE_ATTR(ic_name, 0444, mip4_sysfs_read_ic_name, NULL); static struct attribute *mip4_attrs[] = { &dev_attr_fw_version.attr, From patchwork Mon Jul 23 13:19:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540239 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD4BA1822 for ; Mon, 23 Jul 2018 13:20:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BAADC288BE for ; Mon, 23 Jul 2018 13:20:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B4F6E288EA; Mon, 23 Jul 2018 13:20:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 472F828916 for ; Mon, 23 Jul 2018 13:20:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388517AbeGWOVq (ORCPT ); Mon, 23 Jul 2018 10:21:46 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:44745 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388156AbeGWOVq (ORCPT ); Mon, 23 Jul 2018 10:21:46 -0400 Received: by mail-wr1-f68.google.com with SMTP id r16-v6so673385wrt.11; Mon, 23 Jul 2018 06:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=yrEK7wylPi26wjkh1to8Jnf10ztAXnVDAd4Pj6MetCY=; b=mt3+iZ/7XNrg5rxmGw2Z8fFhu6SqEJf7zFxYzZb5UjD48+IZGuLU0XPcPMmZ0fK0EA ffO66TUtMGE7Hnac5/xwUWWidcLMmLBZwNGaOIDkL/x3ALphY5eJmTyXkq4E7R5Hq9aO CQjeAU4gqmx5cCPnqyNfkzJlkmo5WdlVGDYsyR3mil6lY8Wm3xWao8eBULBuVl6DHMM9 pQQBn0VdTZWsX4cb9f4Bbd8k2yw+dR8MzZQ3sgnG/c4HICSBI1AcdYNJmNJT9XFUKTEU FythQsHJ69uFU/yHA6lE6odsTyV4mzcCfDoZRWD2GILlEJPrOx9r65tBtKPc9l68rCqx dByQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=yrEK7wylPi26wjkh1to8Jnf10ztAXnVDAd4Pj6MetCY=; b=PY88lPub1XkUagMAVmotUjhOfzsi4sL3YE+0KUtIBOnbDoG3PVHS6kBkDQK3+PX9sx Y6uSb1UrwEsfAhsm92AN6IoXMQGdEIKQHSaHS16Kfzh1QB1RnJFNOeWpgbiJvW1nfOPd IIhrzSAZbXSLhytKmmh4G5A4eXdiAadmniCji7NlEYXdbuWrTc0HSTdg5CKAD9bGBoOp 69wYbzPUkjx7NcOMGIui6BCo2YYj+Q32GE4miHss6yqK99YYRJzs1WDmSUKp53Ge3X1t nxoLcNK39BWUs7B/aduJ/X/Ld7lR/zAVpge0LkpzVUL3R5/Dg16tpExRd7TT/wFqX7tw YIcg== X-Gm-Message-State: AOUpUlEhx8IZvrSGIgQJ20x3a+FpReT7vfzvu1BkBDgYB2Yvje8XVEXD BIPQ0/KgD8KolI/gTkHoQ/Y= X-Google-Smtp-Source: AAOMgpcxVgRTcDoU71YLRIT469AqwngrzENtDTCXv+GV4slnIVQa9MiW6Yx/5UxwpAtziKmcutBqGQ== X-Received: by 2002:adf:80aa:: with SMTP id 39-v6mr8799968wrl.57.1532352031921; Mon, 23 Jul 2018 06:20:31 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:31 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Simon Budig , Andi Shyti , Luca Ceresoli , Jeffrey Lin , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 09/11] touchscreen: raydium_ts: Use octal permissions Date: Mon, 23 Jul 2018 18:49:24 +0530 Message-Id: <20180723131954.30739-8-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store); WARNING: Symbolic permissions 'S_IWUSR' are not preferred. Consider using octal permissions '0200'. +static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/raydium_i2c_ts.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/input/touchscreen/raydium_i2c_ts.c b/drivers/input/touchscreen/raydium_i2c_ts.c index d1c09e6a2cb6..eddbb51e55dd 100644 --- a/drivers/input/touchscreen/raydium_i2c_ts.c +++ b/drivers/input/touchscreen/raydium_i2c_ts.c @@ -934,9 +934,9 @@ static ssize_t raydium_i2c_calibrate_store(struct device *dev, return error ?: count; } -static DEVICE_ATTR(fw_version, S_IRUGO, raydium_i2c_fw_ver_show, NULL); -static DEVICE_ATTR(hw_version, S_IRUGO, raydium_i2c_hw_ver_show, NULL); -static DEVICE_ATTR(boot_mode, S_IRUGO, raydium_i2c_boot_mode_show, NULL); +static DEVICE_ATTR(fw_version, 0444, raydium_i2c_fw_ver_show, NULL); +static DEVICE_ATTR(hw_version, 0444, raydium_i2c_hw_ver_show, NULL); +static DEVICE_ATTR(boot_mode, 0444, raydium_i2c_boot_mode_show, NULL); static DEVICE_ATTR(update_fw, S_IWUSR, NULL, raydium_i2c_update_fw_store); static DEVICE_ATTR(calibrate, S_IWUSR, NULL, raydium_i2c_calibrate_store); From patchwork Mon Jul 23 13:19:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4A95E13BB for ; Mon, 23 Jul 2018 13:21:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 39F0D288EC for ; Mon, 23 Jul 2018 13:21:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2DF95288D1; Mon, 23 Jul 2018 13:21:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C2B7228918 for ; Mon, 23 Jul 2018 13:20:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388445AbeGWOVx (ORCPT ); Mon, 23 Jul 2018 10:21:53 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34451 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388156AbeGWOVw (ORCPT ); Mon, 23 Jul 2018 10:21:52 -0400 Received: by mail-wm0-f68.google.com with SMTP id l2-v6so9744023wme.1; Mon, 23 Jul 2018 06:20:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=zCKdsHtXVLf2CBkcSFoTzZQ6PWRuNBt5KYiFA9DgkiM=; b=p+Rjyo84kz76M5ZrizuXjRJBhd7dGigPRunqMwaxUUTFSj8+Gbg/+21O5JFGZcdckk dFTHI+slVITlsqkKs0OUCwxp619mkTTGU5fUM7dg6vp+d+7KhA16IIp1uD/gwaAPu8KX GSz7INBhV5hbeS7cpGGiRTCUBC8JnpfXsL2LqmWMSiqs1cg4DAjYAx6cmRxScGsUe+uF /qKbnA0xy+6yIwNgdJfDAsREWXvjAdYDfWyOc5oZfPGuP/OQg+cIpN8BOSsRvmaOcYmK uo3LrOW4a6/pXnN4a37/aw4f3l4VLbZrhZomEIn8czimJSAQUjTIbQuXVEtP5+fUBDfC Frmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=zCKdsHtXVLf2CBkcSFoTzZQ6PWRuNBt5KYiFA9DgkiM=; b=s4FAZz+QRdUjd0J0dX8Y8HEG7Kl3RF51rMreanfn5VscpPk0IjRl3AfUPOsXR4zEHb qsfn+A1A13TiNxl5pWcajPbpCj790SEiBLPHXGipDNSUSIXyq+AYsn4qrKMZJNpFGPWO Iq/x07eLVgsJ1MIFjxjZyp4ROj4BdIxQP59idZt89egk6SqkUcIE6n0OmgXdnsaCMnA4 gK1gqS82bUyZfalyovBWq4monVKg6lGTBZ40wb+nsF6B0vE98jenVzavRbY+7ESSYtcC UTyK3hNTclHxMIiXN2roxTnIB80pfCEn4KxThiGqVC/mr/KKqShAEhVqi80FJluB7jGh f+Rg== X-Gm-Message-State: AOUpUlGPA0AwLvTcSKtQy8N4m9OcmcS0nbqonf6Sa+ChqetMaCO/7eC8 r7a6c9KTPoHbig/yExECRgU= X-Google-Smtp-Source: AAOMgpcDqapOgkS3njeZiUQYAe1e4CoXAphDmXMFMxd96xq+EKUGdnbFQKfDcZ3/bK/SlFYHchs9ZA== X-Received: by 2002:a1c:e70b:: with SMTP id e11-v6mr7213039wmh.22.1532352037581; Mon, 23 Jul 2018 06:20:37 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:37 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Maxime Ripard , Chen-Yu Tsai , Simon Budig , Andi Shyti , Luca Ceresoli , Julia Lawall , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/11] touchscreen: sun4i_ts: Use octal permissions Date: Mon, 23 Jul 2018 18:49:25 +0530 Message-Id: <20180723131954.30739-9-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/sun4i-ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/input/touchscreen/sun4i-ts.c b/drivers/input/touchscreen/sun4i-ts.c index d2e14d9e5975..78960961a524 100644 --- a/drivers/input/touchscreen/sun4i-ts.c +++ b/drivers/input/touchscreen/sun4i-ts.c @@ -230,8 +230,8 @@ static ssize_t show_temp_label(struct device *dev, return sprintf(buf, "SoC temperature\n"); } -static DEVICE_ATTR(temp1_input, S_IRUGO, show_temp, NULL); -static DEVICE_ATTR(temp1_label, S_IRUGO, show_temp_label, NULL); +static DEVICE_ATTR(temp1_input, 0444, show_temp, NULL); +static DEVICE_ATTR(temp1_label, 0444, show_temp_label, NULL); static struct attribute *sun4i_ts_attrs[] = { &dev_attr_temp1_input.attr, From patchwork Mon Jul 23 13:19:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harshit Jain X-Patchwork-Id: 10540241 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1FA4F13BB for ; Mon, 23 Jul 2018 13:20:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F6802893D for ; Mon, 23 Jul 2018 13:20:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0BE05288D7; Mon, 23 Jul 2018 13:20:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95AF32891F for ; Mon, 23 Jul 2018 13:20:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388156AbeGWOV6 (ORCPT ); Mon, 23 Jul 2018 10:21:58 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34454 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388398AbeGWOV5 (ORCPT ); Mon, 23 Jul 2018 10:21:57 -0400 Received: by mail-wm0-f68.google.com with SMTP id l2-v6so9744211wme.1; Mon, 23 Jul 2018 06:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=irpdppR069ZKaBvVKjWmi1hRxV+li+fa3T9xts+4x88=; b=eS3f7a43/C+1hK+uiyMK3m7nXPOh0wuxMSwezwMgP8NI2hiHlvN4T0uOqlfg1nz+CY dnA1A6Med3YJL9LpYcsfkAh+2kOFq7pqtGoHd1Al7R6QVuyrUN9+qV9oZUPB7TF2dGTi iDrlmD3wDUNf2AuPaF66+VvgDxRTwcqCArwktHIzLFA43q2+vUN1/xrxpfgwjPDLwRQJ WfI5FdF/8ZkvyrwELAsjgjyxpqELRummVACVs7mubx+Vbju4lUKJIezOEYZqrUv8f2OP hFKqtz1rl+lPy6Sxwspjlkz6T/BuI0kiX1uHlITcoQpD0kV4pZVX9UK+Up8oNwxBMxAW NcTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=irpdppR069ZKaBvVKjWmi1hRxV+li+fa3T9xts+4x88=; b=AqBjAxObiJI5RBTnaAskS7np4imTFw3Ta3wWz0v5xZj7qOPuYvewKgurTHHSwb0b+M ukBJ20oFXt1Rd57w2VAZ0r10mtW/oGwBtj2nZRDHyM1Khorcy8fKsSicZh3VNtpeWWnX 8gGM2yGYGo1A8VDmQrZDBfXDVExjTLe6pG7JYXg7nk8uXfjDNMUc7LCwPqvV2CBcXTGT kThlqjzp4K6RUlssRjWaHw8h5DqK6Eyxbx9/GQzPSVccJ0+cKROffm9U+Xedc4+ZLFtK 6KYnWduelfBUCXwYnbFM5DlYD7cRJ8e6T8kLbNuhwVvKtgg0AI6TencgRnpsMO2Uhmu+ IoMg== X-Gm-Message-State: AOUpUlHhWA52dokezzQHXEE8v+CYjz/irdiZ5/1J4GcN1pl1c8wCGfa2 pKz+vlpRokclu3QDIr5h3MU= X-Google-Smtp-Source: AAOMgpdu3fQfdjclTtmDxJeAHiNG4mNF7hUmpbm6Oz8V61Gy5uMN9DEGXwMtHrldUPOIkEe3QUxJ8Q== X-Received: by 2002:a1c:ec86:: with SMTP id h6-v6mr7619940wmi.53.1532352043129; Mon, 23 Jul 2018 06:20:43 -0700 (PDT) Received: from localhost.localdomain ([2a01:4f8:201:1487::2]) by smtp.gmail.com with ESMTPSA id t184-v6sm8368459wmf.18.2018.07.23.06.20.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Jul 2018 06:20:42 -0700 (PDT) From: dev-harsh1998 To: trivial@kernel.org Cc: Harshit Jain , Dmitry Torokhov , Andi Shyti , Simon Budig , Luca Ceresoli , Martin Kepplinger , Kees Cook , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/11] touchscreen: tsc200x: Use octal permissions Date: Mon, 23 Jul 2018 18:49:26 +0530 Message-Id: <20180723131954.30739-10-harshitjain6751@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180723131954.30739-1-harshitjain6751@gmail.com> References: <20180723131954.30739-1-harshitjain6751@gmail.com> Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. +static DEVICE_ATTR(selftest, S_IRUGO, tsc200x_selftest_show, NULL); Signed-off-by: Harshit Jain --- drivers/input/touchscreen/tsc200x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/tsc200x-core.c b/drivers/input/touchscreen/tsc200x-core.c index e0fde590df8e..daefeca101ff 100644 --- a/drivers/input/touchscreen/tsc200x-core.c +++ b/drivers/input/touchscreen/tsc200x-core.c @@ -336,7 +336,7 @@ static ssize_t tsc200x_selftest_show(struct device *dev, return sprintf(buf, "%d\n", success); } -static DEVICE_ATTR(selftest, S_IRUGO, tsc200x_selftest_show, NULL); +static DEVICE_ATTR(selftest, 0444, tsc200x_selftest_show, NULL); static struct attribute *tsc200x_attrs[] = { &dev_attr_selftest.attr,