From patchwork Mon Nov 16 14:41:21 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Su X-Patchwork-Id: 11908661 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D533315E6 for ; Mon, 16 Nov 2020 14:41:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 749D220789 for ; Mon, 16 Nov 2020 14:41:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=163.com header.i=@163.com header.b="b1amDDC3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 749D220789 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B5AC6B006E; Mon, 16 Nov 2020 09:41:35 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5641B6B0070; Mon, 16 Nov 2020 09:41:35 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A46A6B0071; Mon, 16 Nov 2020 09:41:35 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0199.hostedemail.com [216.40.44.199]) by kanga.kvack.org (Postfix) with ESMTP id 1DA776B006E for ; Mon, 16 Nov 2020 09:41:35 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B366B180AD807 for ; Mon, 16 Nov 2020 14:41:34 +0000 (UTC) X-FDA: 77490544908.13.range79_561853027329 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 9AAF518140B60 for ; Mon, 16 Nov 2020 14:41:34 +0000 (UTC) X-Spam-Summary: 1,0,0,db3a9e2f4736d1a7,d41d8cd98f00b204,sh_def@163.com,,RULES_HIT:41:355:379:582:800:960:966:973:988:989:1152:1260:1277:1312:1313:1314:1345:1437:1516:1518:1519:1534:1541:1593:1594:1595:1596:1711:1730:1747:1777:1792:2196:2198:2199:2200:2393:2559:2562:2692:2731:3138:3139:3140:3141:3142:3353:3865:3867:3871:4321:4385:5007:6119:6261:6653:10004:10400:11334:11658:11914:12114:12296:12297:12438:12555:12895:12986:13069:13161:13229:13311:13357:13439:13895:14096:14097:14181:14394:14721:21080:21627:21990:30054,0,RBL:220.181.12.15:@163.com:.lbl8.mailshell.net-62.50.2.100 66.100.201.100;04yronybti11sq15ricwoqh45s3gcypou43b34rpqb7chji4onejoi7bmuqbypf.jqpugpkpit3wjw14rkkuqs81nibm6y8sbmoyryzqckx5w46dbptt4am9m7zn6yy.w-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:69,LUA_SUMMARY:none X-HE-Tag: range79_561853027329 X-Filterd-Recvd-Size: 3137 Received: from m12-15.163.com (m12-15.163.com [220.181.12.15]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Nov 2020 14:41:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version; bh=TW24U 61+H3s62LaaCwaMn+eQvhUmC8wBlcrQhJZp8w0=; b=b1amDDC35moQmF/MIi4J9 GtAbOGGd1gElbKHPz/PjLQjwJdG3His/3uDP5ZNnFN/NWlNWtNZ4kKH7+l6kkUiQ XmlKz/woHCTl89Y4uJTwLviVz0iGQdLWVzmM4ZQHTFNpxnM1L/8Knd8OPiu5vOoq mHDEz33RHE5e9uVd1p5erM= Received: from localhost (unknown [101.86.213.176]) by smtp11 (Coremail) with SMTP id D8CowACH8DGRj7Jfo7uxBQ--.37360S2; Mon, 16 Nov 2020 22:41:21 +0800 (CST) Date: Mon, 16 Nov 2020 22:41:21 +0800 From: Hui Su To: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: sh_def@163.com Subject: [PATCH] mm/compaction: move compaction_suitable's comment to right place Message-ID: <20201116144121.GA385717@rlk> MIME-Version: 1.0 Content-Disposition: inline X-CM-TRANSID: D8CowACH8DGRj7Jfo7uxBQ--.37360S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7tr4fGr13CFyktFyDXFWfuFg_yoW8Wr4Dpr 1093yDJw1FqF13CrW0yF10q3W5Kr4xKFyUJw1kKw1kXw1Yk3Z2q3WktFyUCFyUX34ayr4j qFWF9Fy5tFsrAw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07UveHkUUUUU= X-Originating-IP: [101.86.213.176] X-CM-SenderInfo: xvkbvvri6rljoofrz/1tbiORHeX1XlvdzQwAAAso X-Bogosity: Ham, tests=bogofilter, spamicity=0.356814, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since commit 837d026d560c ("mm/compaction: more trace to understand when/why compaction start/finish"), the comment place is not suitable. So move compaction_suitable's comment to right place. Signed-off-by: Hui Su --- mm/compaction.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 13cb7a961b31..8bfd6e089511 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -2070,13 +2070,6 @@ static enum compact_result compact_finished(struct compact_control *cc) return ret; } -/* - * compaction_suitable: Is this suitable to run compaction on this zone now? - * Returns - * COMPACT_SKIPPED - If there are too few free pages for compaction - * COMPACT_SUCCESS - If the allocation would succeed without compaction - * COMPACT_CONTINUE - If compaction should run now - */ static enum compact_result __compaction_suitable(struct zone *zone, int order, unsigned int alloc_flags, int highest_zoneidx, @@ -2120,6 +2113,13 @@ static enum compact_result __compaction_suitable(struct zone *zone, int order, return COMPACT_CONTINUE; } +/* + * compaction_suitable: Is this suitable to run compaction on this zone now? + * Returns + * COMPACT_SKIPPED - If there are too few free pages for compaction + * COMPACT_SUCCESS - If the allocation would succeed without compaction + * COMPACT_CONTINUE - If compaction should run now + */ enum compact_result compaction_suitable(struct zone *zone, int order, unsigned int alloc_flags, int highest_zoneidx)