From patchwork Mon Nov 16 17:40:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910023 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28A4EC63697 for ; Mon, 16 Nov 2020 17:41:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC72A20B80 for ; Mon, 16 Nov 2020 17:41:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="o1UX4zCd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC72A20B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B26889FCE; Mon, 16 Nov 2020 17:41:24 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5B936E04A for ; Mon, 16 Nov 2020 17:41:21 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id d12so19618779wrr.13 for ; Mon, 16 Nov 2020 09:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qEyPNgqrCvgW7yAtw6B6vQyE222bBpFcTf7vHkr21Ko=; b=o1UX4zCdDDDNMV0OKn61RJZh5y0bXjwuSLSb/l0adES4M9qoqn7sv1BgCviUEyBC9c YkW31BulSSuyM5+eWBzeavPqQ3NlTBNZubQzQ8wtBRC/GUKmFYk3lzpk/YE3zsJ/6WBl OpKn4Wy9zyDhuplwApEWD5Sa6zKv+AxMW88gW874lf++usj3pJ6pcP4EB7aKSnEKcHnY kCasy1dCT1JGnPTFofUgrWLFptS2mPNQSJqgRojLSiEN6sitXESVrhduYN1uH3wka2Bv yg8/3HsJ4Ku+jxbJGWlvJEDL04L/+8P+k/Us8Su3EihI97fe/pyVcTBp5V8a0wj1wcDA CTmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qEyPNgqrCvgW7yAtw6B6vQyE222bBpFcTf7vHkr21Ko=; b=MelZ8tTqlufnCyI0mvEJL9jYNx244dpM9QQtf8V39MLXxAd1wi5TWjz8B7HyqqQc5f 3SzT06Xtul5Ud6Vfk1uP280XfVRfv/Job0M7NS9QKbfyM9KBr5lAM0KhoGwVDvnY6oBo BvrWprugtd3kE9g9SH4/rqOdNYQxlJwxbZUp0lruKBoka1//7zyFL5rlWhJBkW8MXWIw XulT9H3++GMZVaGRfTCxARQvmkt5rCavwiw8GC9WocW91103K6AZV1k2RbvK2QA4eF9M y/MvfpPf8N1uxQu8LmwurWVKHLV25BqQOfIQVHbO47IJ22pf0jUcHGhCy0g+mPqADIHf Ygvg== X-Gm-Message-State: AOAM532EqctdK9+5ZbHWspS1JF+qWeSmZZ8/+MXSGSIlPvtxV2nlNx7d dku0MBxIpA5EnDvOkTV8+aIK3Q== X-Google-Smtp-Source: ABdhPJzRRRIcqjO4tgQf4glCQA5hVitq6bSC5qSo/xDr9yKWinhRugh4nu2qRSQ/wCZZC7eA8JUXXA== X-Received: by 2002:adf:fd0d:: with SMTP id e13mr19708579wrr.85.1605548480370; Mon, 16 Nov 2020 09:41:20 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:19 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 01/42] drm/amd/amdgpu/atombios_encoders: Remove set but unused variable 'backlight_level' Date: Mon, 16 Nov 2020 17:40:31 +0000 Message-Id: <20201116174112.1833368-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, Luben Tuikov , dri-devel@lists.freedesktop.org, Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Also removing the call to amdgpu_atombios_encoder_get_backlight_level_from_reg() since, according to Alex Deucher, "We call it again below indirectly". Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/atombios_encoders.c: In function ‘amdgpu_atombios_encoder_init_backlight’: drivers/gpu/drm/amd/amdgpu/atombios_encoders.c:174:5: warning: variable ‘backlight_level’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Luben Tuikov Cc: amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/atombios_encoders.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c index fa817ebff9804..6134ed9640279 100644 --- a/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c +++ b/drivers/gpu/drm/amd/amdgpu/atombios_encoders.c @@ -171,7 +171,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode struct backlight_properties props; struct amdgpu_backlight_privdata *pdata; struct amdgpu_encoder_atom_dig *dig; - u8 backlight_level; char bl_name[16]; /* Mac laptops with multiple GPUs use the gmux driver for backlight @@ -207,8 +206,6 @@ void amdgpu_atombios_encoder_init_backlight(struct amdgpu_encoder *amdgpu_encode pdata->encoder = amdgpu_encoder; - backlight_level = amdgpu_atombios_encoder_get_backlight_level_from_reg(adev); - dig = amdgpu_encoder->enc_priv; dig->bl_dev = bd; From patchwork Mon Nov 16 17:40:32 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910021 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89CB2C6369E for ; Mon, 16 Nov 2020 17:41:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30B3720575 for ; Mon, 16 Nov 2020 17:41:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hy+U4SAx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30B3720575 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE01D6E0A2; Mon, 16 Nov 2020 17:41:24 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id D51DF6E04A for ; Mon, 16 Nov 2020 17:41:22 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id j7so19654430wrp.3 for ; Mon, 16 Nov 2020 09:41:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wySX8cNvv9NUCsmEXsR0JBc7XJM0MHUH49ItqBshbVE=; b=hy+U4SAx16PrqlnuxVW5U1xQBAKZb2kMB+JBT6jHCWWzrxWoYMTf/gpOSUnZWvRMBJ AV+gpm5PS/9qVYSDg82yYZi5O9uwFTk2UVpOOUA9Q4MvdxOld2ijiYRGuvNm5GalEDxs H1hQ4gnyxx6Zs2PHS9F7KXqSpGHsvqpezLeVqbrX7w7HPqWJrC6g6I8U9OhtKkHHHTNk cOjr9HODR3ivsTKLy9slgduBPEMGw2/z1aGzX4m9gECM8l81Ti37Trf+2hA7dZT2Qof5 NdJl4WjDbuuwMbqraBU2i1ZcGYRv6BvOUBLindgX0mkRR8iLqZ6+d2hsFvh9ewzYucNv wZWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wySX8cNvv9NUCsmEXsR0JBc7XJM0MHUH49ItqBshbVE=; b=DlBVuGssVvkbbf9LprRL2ePt0763kaByZUa4SyQVaXEiqNQArD2Tw7GpVwGRlmmeIs vXBeoRTkQ8MCfEbvfU1xhWFJLR3Yler9S2huWs/7x/NxxgChdujCzx08tVMBRzUOSMq5 yjoc3ns+ZyXC0Au/eeQNeaqp9wHty6C+rRh2bJrlmTk9bi9sS32M/8X5y9xrjHkCK5Mp PQB6CqRoNl2KBf4FT4omk+lRLofqBS3fSurVqqB5GOo0HoP9HsQNK1hWBTnykblVqaR/ Mc7EhaAUzAhvM6rSv5tKep6oOXoRmFICdBfZfmxXJxYIl9Jyj1NosRzBu/4mcJtgt5Pt sllg== X-Gm-Message-State: AOAM533wHdgXGxsqrXt5/bMnuRw599Vt6MYVaeXroy4OFABV4kQW6dTO caRkGKbyzbJo6MEz6RKf1QO+tQ== X-Google-Smtp-Source: ABdhPJz2NVpodSO80ODErNsO8Nnc8xpQNlSxjZjIgamuTY2aDdtYen+IQPe6zyftuY2DtfotFd1Ybw== X-Received: by 2002:adf:eb4d:: with SMTP id u13mr19723606wrn.146.1605548481587; Mon, 16 Nov 2020 09:41:21 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:21 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 02/42] drm/armada/armada_overlay: Staticify local function 'armada_overlay_duplicate_state' Date: Mon, 16 Nov 2020 17:40:32 +0000 Message-Id: <20201116174112.1833368-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Russell King Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/armada/armada_overlay.c:329:1: warning: no previous prototype for ‘armada_overlay_duplicate_state’ [-Wmissing-prototypes] Cc: Russell King Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/armada/armada_overlay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/armada/armada_overlay.c b/drivers/gpu/drm/armada/armada_overlay.c index 30e01101f59ed..6346b890279a0 100644 --- a/drivers/gpu/drm/armada/armada_overlay.c +++ b/drivers/gpu/drm/armada/armada_overlay.c @@ -325,7 +325,7 @@ static void armada_overlay_reset(struct drm_plane *plane) } } -struct drm_plane_state * +static struct drm_plane_state * armada_overlay_duplicate_state(struct drm_plane *plane) { struct armada_overlay_state *state; From patchwork Mon Nov 16 17:40:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910041 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71850C4742C for ; Mon, 16 Nov 2020 17:41:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 208AE2227F for ; Mon, 16 Nov 2020 17:41:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XGCk6s8g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 208AE2227F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A7C966E8E7; Mon, 16 Nov 2020 17:41:31 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 75C9C89FCE for ; Mon, 16 Nov 2020 17:41:24 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id p19so378382wmg.0 for ; Mon, 16 Nov 2020 09:41:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=451+tFthAljOAh2f/Wv8bktxEJYp2PVcrpZPPSF00gU=; b=XGCk6s8gC8Z7wwqz/yakD2Actx1/SDxlJWpn6VZXYaCcZgwFWPIiwikiWrSfoDH1CY eoyz/KluCphA/lJ1/dcnuK8uF1wLI4GwD2IuYSvn/QpePKLy80V5b4ResvbhO8AJSa2h AuO1DEYoX4OcOKEvamcX7MR2cFDcfgRQZD03tFja5kLg+EDyqI2PN0WelbUbGJdFWcR9 qsLBgHOvcP5PeWWLWZVF/7/MPWWr0mXikaw7doM1MvCg7vjAv9VGWYC/Q/iK7T7Cp4Kz O6mdYmXV4Nt/nd9+89fMr8shFLkuMiT9zKMRumtWDe5SfMO3vzuOjAqn2sriZEQUbxGN gsWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=451+tFthAljOAh2f/Wv8bktxEJYp2PVcrpZPPSF00gU=; b=MB8UsuhnuFV9KY7Eh8nOAJcM+jwwLxLDJEPbF2KSjBieLPCvNuTpUHBVMZsHHjynB3 kEOH6VU/EvozG6tpFN2W7OaGmSRQiLS8yOhqlJHJAM0LWPJCifLKDxRkyh/UzOAktir3 D/ZQstaa/pip52C0nuoJVoDYB3aVNtjjyxKG/CPyqoNna4O2uQhGcDinOHhDlpiSHB8O ctUzV2QuPwvI5mKHVmlOPvMSotoz7lsdmPknnJpFPfJlXWXqZuDmD4495IpWxz0WdT0Q e9VxeamampO3rLJLxIsbRH7HeCnZBtxCVayT4K1zk/JK6q8a8QyECwlIKTCgIk2GXBWR Mwmg== X-Gm-Message-State: AOAM532zH17lT4cyCGnu5Wj7TwK6WqJY0Oxs4NbKh7S5mhtKmdevEn22 DM98FhLrOx/b0G+l2QdLDAfGRA== X-Google-Smtp-Source: ABdhPJwZBZpSzy/6KpIKdwNmgKx3o+w5BcHKVqsUZqBOvYAmzytj7ySLSeOcE9qh+eybQ0AMFCy/Vw== X-Received: by 2002:a1c:b387:: with SMTP id c129mr37255wmf.58.1605548483095; Mon, 16 Nov 2020 09:41:23 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:22 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 03/42] drm/drm_dp_mst_topology: Remove set but never used variable 'len' Date: Mon, 16 Nov 2020 17:40:33 +0000 Message-Id: <20201116174112.1833368-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/drm_dp_mst_topology.c: In function ‘drm_dp_send_query_stream_enc_status’: drivers/gpu/drm/drm_dp_mst_topology.c:3263:6: warning: variable ‘len’ set but not used [-Wunused-but-set-variable] Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/drm_dp_mst_topology.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c index e875425336406..0401b2f475002 100644 --- a/drivers/gpu/drm/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/drm_dp_mst_topology.c @@ -3260,7 +3260,7 @@ int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr, { struct drm_dp_sideband_msg_tx *txmsg; u8 nonce[7]; - int len, ret; + int ret; txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); if (!txmsg) @@ -3281,7 +3281,7 @@ int drm_dp_send_query_stream_enc_status(struct drm_dp_mst_topology_mgr *mgr, */ txmsg->dst = mgr->mst_primary; - len = build_query_stream_enc_status(txmsg, port->vcpi.vcpi, nonce); + build_query_stream_enc_status(txmsg, port->vcpi.vcpi, nonce); drm_dp_queue_down_tx(mgr, txmsg); From patchwork Mon Nov 16 17:40:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 545D5C2D0A3 for ; Mon, 16 Nov 2020 17:41:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D12520B80 for ; Mon, 16 Nov 2020 17:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="K0L/9SHj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D12520B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E7A906E9E3; Mon, 16 Nov 2020 17:41:29 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1B346E9E5 for ; Mon, 16 Nov 2020 17:41:25 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id p8so19671117wrx.5 for ; Mon, 16 Nov 2020 09:41:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OKxekprTcNWz9+T5s0dM8zcd4eG/OHSFQB40CDP13bg=; b=K0L/9SHj1TE4qgK/G74Ybc4BmPXgT70P/+LQzzWk7FqljjPYxDyFVBlO0hyHH3Eok5 WcZKuIqWcNwV8S4EUwH8l7RzxNih5aR0EM9Hs7pODYsYMs9n9Ayv2dDmr2WyL5Hr0Nld dK8/Amdzuk+cPNmMGrkSlM8MIBabHVMUy5c81Qg4eiMjJsSH2tSlQAKiNc57EqDo4THe F8MYpIg2VS50N2/OpByLFDpRhEJA99set0DNg+4TdqFgqNC3Fh+c+vyJfI12wmxxqxyF VZsyoC+ZHhP+ZbBgejKK9jahMArlb3Rd3uDqr691znFoNLsleg8+x+2A6ar0ZLvs1tAK 9g+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OKxekprTcNWz9+T5s0dM8zcd4eG/OHSFQB40CDP13bg=; b=XUj1r5iLRbp8LOKsKdax/ls4OfZgaGz/TKW/of8/MHYVkmsl8Kzox/FbmBtzNXjqhg 0kiN0QdZ78g2pCrD7TAu6VQ1TukftxOqkN7tDUiwZN6sVkUJHhAIXRD4I49Zp+ZnaSUh A6/8KChCqsJLNoCZVu+MmfqAqBPp2m+PsMtPWno0XMIKpxbQI/tI3YG3/xIuu/4v3mqE wSI6gxyjfjYuW6Y+A/gxvAmejsRx4fvvwszxi66N2Cs7Py6h3vlojPBJMVk/eA9vrQW6 1KLEb0Ff+K76qpRlztTwxs/kyhjwHiWp4+G01GFM/gwcCpDNwDhoNUfnt0QE1ZJX//SG 9G8A== X-Gm-Message-State: AOAM531QVazFQ7vvKVklA8JrEEUBz7QJ0XGszvulSLIEeG/+slnOrt9j 2P+/LnCKXHlmCMYEeTAQeMBO3A== X-Google-Smtp-Source: ABdhPJyumUoV2OiCGOmwstnxb6PtqFSofQ2hgjkU4IZojdi/6zntKSiyOYzsOrC7hc8z/Pjmvb2eVw== X-Received: by 2002:a05:6000:110c:: with SMTP id z12mr20265161wrw.214.1605548484458; Mon, 16 Nov 2020 09:41:24 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:23 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 04/42] drm/exynos/exynos7_drm_decon: Supply missing description for param 'ctx' Date: Mon, 16 Nov 2020 17:40:34 +0000 Message-Id: <20201116174112.1833368-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Joonyoung Shim , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Kyungmin Park , Akshu Agarwal , dri-devel@lists.freedesktop.org, Ajay Kumar , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/exynos/exynos7_drm_decon.c:354: warning: Function parameter or member 'ctx' not described in 'decon_shadow_protect_win' Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: David Airlie Cc: Daniel Vetter Cc: Krzysztof Kozlowski Cc: Akshu Agarwal Cc: Ajay Kumar Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos7_drm_decon.c b/drivers/gpu/drm/exynos/exynos7_drm_decon.c index f2d87a7445c73..431c5d32f9a47 100644 --- a/drivers/gpu/drm/exynos/exynos7_drm_decon.c +++ b/drivers/gpu/drm/exynos/exynos7_drm_decon.c @@ -346,6 +346,7 @@ static void decon_win_set_colkey(struct decon_context *ctx, unsigned int win) /** * shadow_protect_win() - disable updating values from shadow registers at vsync * + * @ctx: display and enhancement controller context * @win: window to protect registers for * @protect: 1 to protect (disable updates) */ From patchwork Mon Nov 16 17:40:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910031 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59BB5C4742C for ; Mon, 16 Nov 2020 17:41:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02D1F222E8 for ; Mon, 16 Nov 2020 17:41:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lOXQP9/j" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02D1F222E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 155F76E9E5; Mon, 16 Nov 2020 17:41:32 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7BA516E04A for ; Mon, 16 Nov 2020 17:41:28 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id u12so12441312wrt.0 for ; Mon, 16 Nov 2020 09:41:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rT+IXEU28/HBDiXMRe74AzE+dn3RqXWDXkbUpL6OkoA=; b=lOXQP9/jWpUTVRFTXLhX/qUxrASE13UGlSufAsJNt/RZrsyQXt1Kgj/ODkG8POYrxb ttRKdLmv8vaQaTO570FUt6rkbqNvcuWrvkF5Snw1qKoDQhjK8AOAs9su2BJI1JuB/EZb Q1TX1WiamLQ6FiNETqn9/QrrR+eXntaFK0XhkR3+zIFNcM2TEjVAWAyVecWFihQAUxBd lOV9jjWhGmbs9Uz2AlzvdClkVdW46nM9LqPlEhUJp9iCuTgIjbIkvc58Ud57PxGCAv29 TUlPk5GBxi8iIKWORUS5d2nTPDhGzD7fu4rq0ki04xBP3yK3SUSSa9qwcM5TquuxW9Be ZJKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rT+IXEU28/HBDiXMRe74AzE+dn3RqXWDXkbUpL6OkoA=; b=epd+vv4OUlBB/g9driM5I0uLDSSZXPPIx1SyoAguvNOrsmIazL3rR2N3lxQozGur7S TJqrP1y95h8CBZOsMCso8j54P8OWbBoZeZVbvxHXtHa58NIlyjC9NKdTWhs5T4iesgJU qai4BEZsVYzmXjt1JxdSQw0EV1S3DYOWUXZv6FzHVkX4+U1jRoQ0tqZvm+8RoQFNacfP cpjKRqH17fP+gxyOwgsqCOg/mVaxh0SccfP0BClVGYMmD/ClyDPbvgRgyUt9q3TLYy0b EwgpnKYGmOcO/x41n3Hx8bQRDvLpvLpqKbAnEiwdkwERXlyePQN4L4mtUyYeoucMhQPw av5g== X-Gm-Message-State: AOAM532xjSLX311rWl4QLiJnPbTYYLe61WadaD/0NVMtPP4VU4ZaPHVR paJizOkaP9jNh9kLiGOMB9MRnA== X-Google-Smtp-Source: ABdhPJzk2sZtxzq55jR9/b3VYM19OME3kQ9c0B1dB6F5OZ/+fz7NgXKq2LMwoXVd4pXK97ON956dqQ== X-Received: by 2002:a5d:42c9:: with SMTP id t9mr19786159wrr.13.1605548487217; Mon, 16 Nov 2020 09:41:27 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:26 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/42] drm/exynos/exynos_drm_gsc: Supply missing description for 'num_limits' Date: Mon, 16 Nov 2020 17:40:36 +0000 Message-Id: <20201116174112.1833368-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Eunchul Kim , Joonyoung Shim , David Airlie , Seung-Woo Kim , linux-kernel@vger.kernel.org, Krzysztof Kozlowski , Jinyoung Jeon , Kyungmin Park , dri-devel@lists.freedesktop.org, Sangmin Lee , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/exynos/exynos_drm_gsc.c:129: warning: Function parameter or member 'num_limits' not described in 'gsc_driverdata' Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: David Airlie Cc: Daniel Vetter Cc: Krzysztof Kozlowski Cc: Eunchul Kim Cc: Jinyoung Jeon Cc: Sangmin Lee Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones --- drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c b/drivers/gpu/drm/exynos/exynos_drm_gsc.c index 45e9aee8366a8..b01f36e76eafd 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gsc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gsc.c @@ -118,6 +118,7 @@ struct gsc_context { * struct gsc_driverdata - per device type driver data for init time. * * @limits: picture size limits array + * @num_limits: number of items in the aforementioned array * @clk_names: names of clocks needed by this variant * @num_clocks: the number of clocks needed by this variant */ From patchwork Mon Nov 16 17:40:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910033 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B2BDC4742C for ; Mon, 16 Nov 2020 17:41:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E28C2227F for ; Mon, 16 Nov 2020 17:41:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dNwXbsPl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E28C2227F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C8086E9EB; Mon, 16 Nov 2020 17:41:32 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id E22D96E8E7 for ; Mon, 16 Nov 2020 17:41:29 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id k2so19701375wrx.2 for ; Mon, 16 Nov 2020 09:41:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NO2flJnZQ5gKgn/ih0D6aTqpwf9ViRniG5BiRkSE7jU=; b=dNwXbsPl6q1/WYDA3oEdV/zceq4tTRbwO6lTXlm5XU9tFJdlL8uLCb2UQHW6BfNZn+ mgndbZ8TvSG3mtt/+A+jocB/IQFje8yUxevFzpcVFB6E5R2NBK/G30xCQNZJztpaSFpj 7ZL6jHg4IpI1yxLcXSvFPmiWVMom49yEIm89insI5yf38ZUfud8tZbfGClv+QtqTRh8K Gq07tgEv6tNT68z5M1XbSKZVOq8SQXXWhA7Hpv/yIwvULEp8E4HTctxb8tjJFZk/4Bb/ WbgxYlrEvPj5DQjWt0ZA/cKbW6LHdSm7hTS8aDEIcN1QcPH3xmp0cy8EjLxZ15mIUZmy ZGvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NO2flJnZQ5gKgn/ih0D6aTqpwf9ViRniG5BiRkSE7jU=; b=pqkHWebDV88DzbMAJeEg82DdCouChKgJnWKlEAlnfzTVsOTxdNUeJ5mU67NtPUTO+s zC/YnDG3qVSuW+p6t/FFlKpk0b3cnOVR0ZehUtqAt0ItaLvkgY2QvuVv5ujQxvMDZIe4 skx+oxiW3MmY2kuQVyV8uFW7WwOZ6ZqjrtQl8ogmMZg2FOH8Cwf6D5ROWejxO0wLGQGj gZ0gS/e/Jjw2YyNuHoh7VB2szRzVZ+O2RIV/6Z1rvalQaxdPxM48ngrv5WlurTN/KWwD BASfyqTTMlh6JxsoP0/vipJ/dTGBIFYpBk7cvhfklhBgDr/UtLNcwDks2zxb3h8BBvGO hPpg== X-Gm-Message-State: AOAM532IShozTZcX6hrrA2ltDLYJmANKgyxvcYtoxW2DcmCuhaEoOf0T exEr3+Gfl0M4qF9Cf5nYdpOCkQ== X-Google-Smtp-Source: ABdhPJz+zBLjNMtTAkRpY8Bqlfb5jRoe4b4kXclN6HEEszc34CvpCg6cluG5/xfolZQyW6Bj4pbxTw== X-Received: by 2002:a5d:6411:: with SMTP id z17mr21002442wru.112.1605548488615; Mon, 16 Nov 2020 09:41:28 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:27 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 07/42] drm/mediatek/mtk_dpi: Remove unused struct definition 'mtk_dpi_encoder_funcs' Date: Mon, 16 Nov 2020 17:40:37 +0000 Message-Id: <20201116174112.1833368-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , Jie Qiu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_dpi.c:530:39: warning: ‘mtk_dpi_encoder_funcs’ defined but not used [-Wunused-const-variable=] Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: Jie Qiu Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_dpi.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c index cf11c4850b405..52f11a63a3304 100644 --- a/drivers/gpu/drm/mediatek/mtk_dpi.c +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c @@ -522,15 +522,6 @@ static int mtk_dpi_set_display_mode(struct mtk_dpi *dpi, return 0; } -static void mtk_dpi_encoder_destroy(struct drm_encoder *encoder) -{ - drm_encoder_cleanup(encoder); -} - -static const struct drm_encoder_funcs mtk_dpi_encoder_funcs = { - .destroy = mtk_dpi_encoder_destroy, -}; - static int mtk_dpi_bridge_attach(struct drm_bridge *bridge, enum drm_bridge_attach_flags flags) { From patchwork Mon Nov 16 17:40:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC317C2D0A3 for ; Mon, 16 Nov 2020 17:41:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98659222EC for ; Mon, 16 Nov 2020 17:41:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iE+GfQv7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98659222EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5F01A6E9EA; Mon, 16 Nov 2020 17:41:32 +0000 (UTC) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46C186E8E7 for ; Mon, 16 Nov 2020 17:41:31 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id w24so54724wmi.0 for ; Mon, 16 Nov 2020 09:41:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E894eMua3BcyVtBQpbTegYEGiTjlkwuli5uk69Q3IOw=; b=iE+GfQv7S+GSvLz2XqilNiYCnjVAF3dl0i1NdZt+LoSFIRELaZUc3+iVqUhwSYL0aL pjti1ADepOb4FJkdojySoQwMDaPrwh7j6aO88NbHuD+w84SjoGK0W2eUvbUHE5pG9eNr pViE4R8pwS1eyXthtq+uAS/Y9RT47NfD5j64F8teilBivL8FdqFk6gOihpy9n8yRTglP lisu3mYddSpY3XWHFLYoda6EU319ZkdjHtvRyPZaVUwaz1/TvNiXMv3VWuIHTWT9xLbf Rcelarr0lAeUtKHga5xymhwhANiCRxFrOKVXBl4V0qNoneN3zTpuk3fXRa9q4v3ewMbx bMTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E894eMua3BcyVtBQpbTegYEGiTjlkwuli5uk69Q3IOw=; b=kiMlXkf6SMape6lUMDACqe6RNEI8pnm0TrnQ+FBvcAkbzkJe3R1frVdJG6wEMAf3Y6 NueE2DIwpssvUlb4K+ZxOOE3ZSf+OLkdQxSmirZI6aN7RaQ5Ld++gUQ3Z7Q0Rrk3zwp8 XC6981hUsMJfZ1kOfjhp4yDBBt7X0bBZ8BPHXQRi2F7Rx2iMgFHALUb7nuqnatsB1BoW KqWerR/k6kDjDFiTkJ5hEE6FqhNG6mVakG179EpMw2ifBePe2lQWCRKh2KwnhZcDScre gx9an3SKDDo3I93roWA0ziCGCPMXsWVYoffurRf62hy7lSthbfxLCYukpst35AAF6DSk cLnw== X-Gm-Message-State: AOAM5326ON2MrCDIpWFDIdFSYlmVG8Y2VDFutdQZsjJwR4ygCevm7mkU 5d7nFAVbdoZi3Z+jwQVYPG7EwA== X-Google-Smtp-Source: ABdhPJyAtdkZ7H/8C+uFfj6r311zF9vn30gnWin/fN7tzo1uOND51VmS8moUU4d/wdcd/nghzYnvaQ== X-Received: by 2002:a1c:7202:: with SMTP id n2mr39184wmc.38.1605548489918; Mon, 16 Nov 2020 09:41:29 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:29 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 08/42] drm/mediatek/mtk_disp_color: Fix formatting and provide missing member description Date: Mon, 16 Nov 2020 17:40:38 +0000 Message-Id: <20201116174112.1833368-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_disp_color.c:40: warning: Function parameter or member 'ddp_comp' not described in 'mtk_disp_color' drivers/gpu/drm/mediatek/mtk_disp_color.c:40: warning: Function parameter or member 'crtc' not described in 'mtk_disp_color' drivers/gpu/drm/mediatek/mtk_disp_color.c:40: warning: Function parameter or member 'data' not described in 'mtk_disp_color' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_disp_color.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_color.c b/drivers/gpu/drm/mediatek/mtk_disp_color.c index 3ae9c810845bb..a788ff95ed6e4 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_color.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_color.c @@ -30,8 +30,9 @@ struct mtk_disp_color_data { /** * struct mtk_disp_color - DISP_COLOR driver structure - * @ddp_comp - structure containing type enum and hardware resources - * @crtc - associated crtc to report irq events to + * @ddp_comp: structure containing type enum and hardware resources + * @crtc: associated crtc to report irq events to + * @data: platform colour driver data */ struct mtk_disp_color { struct mtk_ddp_comp ddp_comp; From patchwork Mon Nov 16 17:40:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910049 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9C0FC2D0A3 for ; Mon, 16 Nov 2020 17:41:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7CC1E222E8 for ; Mon, 16 Nov 2020 17:41:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zrf2ywI6" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7CC1E222E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B1DE26E9ED; Mon, 16 Nov 2020 17:41:37 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC66A6E9ED for ; Mon, 16 Nov 2020 17:41:32 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id c9so33658wml.5 for ; Mon, 16 Nov 2020 09:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lV20qvkcXuKJ/8kdoQy2xSMx6pSot2KZYylCMdc97vk=; b=Zrf2ywI6nk+V0LerSSoBh85knKxg9wJ+fPH0SnSGqaqQ12rxleOIn+iiCOD32LvrWe Bkf/Wb6oGiBXh81lSfbbUzMj46qGlT4x4+1uL52OqwD66udoi+19y2OiHokqejefMpki LmeWQ+MHrkhBMuJk+MdgLyk7MESyvv31arSx0QUkqSIS1x66KRZp1d4y24TPZMNm83lQ Z/8XQ6zO07K0BXmGzG4J9egEP+HIctkyoaLLrtPIWFXQNAkfouPKrKFL3r8kdJz9S87x 0LJf4EPdEEJ9lt64nU1UXv2v/MlEJ25+E2sOtvy96/QpqSBFGgfC2NTk1OGeGMfirb+6 SY+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lV20qvkcXuKJ/8kdoQy2xSMx6pSot2KZYylCMdc97vk=; b=uXxhriVIie8zeXNs1v38Gp45TQ00RPnYflDY1F/Ok5UO8SzuXmuSip6pwlzBrv6Ucz MSPAuqzpjLkNYem+rHJPQIOOHZEGLL0DlUhZE3CdQN8JBIcKPibmRjHgy7zvBJDuW3UF 9ZrO3Z1zkSyfQSKdxZFjcfo7ZWLDffq0C7YXo9OPXrN4MdN5slYbcNegISNq1BHA1vOE V2atatobvulo/D2tT/x/YeFTVOcV796986LNSrsnsxeEl6g2f5TmsTiQNXEn2QCs656F y1OMAx3GfgawDD45T9yHxZUe/qamCRhOw+1M4PnbVBg9+rRZ6TMG+tJevwT7p7aO7/v8 ITMg== X-Gm-Message-State: AOAM531+/dItCpcw4XI47vzgF01woS5qQpR8CgVV9XIi/r12nH5bNcUA 60WX01uJUfiyv7rJZk+c3ThCKA== X-Google-Smtp-Source: ABdhPJxIdXRERwdbm0KN6pgN4q/8GjFcbWLDvydipEOB1BxVtliCNpiCbiQUfPa+193dGkiQ5Fu86A== X-Received: by 2002:a1c:658b:: with SMTP id z133mr7692wmb.1.1605548491414; Mon, 16 Nov 2020 09:41:31 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:30 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 09/42] drm/mediatek/mtk_disp_ovl: Fix formatting and provide missing member description Date: Mon, 16 Nov 2020 17:40:39 +0000 Message-Id: <20201116174112.1833368-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_disp_ovl.c:75: warning: Function parameter or member 'ddp_comp' not described in 'mtk_disp_ovl' drivers/gpu/drm/mediatek/mtk_disp_ovl.c:75: warning: Function parameter or member 'crtc' not described in 'mtk_disp_ovl' drivers/gpu/drm/mediatek/mtk_disp_ovl.c:75: warning: Function parameter or member 'data' not described in 'mtk_disp_ovl' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c index 28651bc579bc9..74ef6fc0528b6 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl.c @@ -65,8 +65,9 @@ struct mtk_disp_ovl_data { /** * struct mtk_disp_ovl - DISP_OVL driver structure - * @ddp_comp - structure containing type enum and hardware resources - * @crtc - associated crtc to report vblank events to + * @ddp_comp: structure containing type enum and hardware resources + * @crtc: associated crtc to report vblank events to + * @data: platform data */ struct mtk_disp_ovl { struct mtk_ddp_comp ddp_comp; From patchwork Mon Nov 16 17:40:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910035 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6884CC61DD8 for ; Mon, 16 Nov 2020 17:41:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01CF420B80 for ; Mon, 16 Nov 2020 17:41:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fBeX27nB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01CF420B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0F5CD6E9F0; Mon, 16 Nov 2020 17:41:38 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F0756E9ED for ; Mon, 16 Nov 2020 17:41:34 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id h21so43845wmb.2 for ; Mon, 16 Nov 2020 09:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vlKk1bN1CES0mgH+wUmCXkMlZA1CVtbOfxEG6y0GM50=; b=fBeX27nB366IYVH1W9juPZSpXK3wrkLndU8rdMtDvtddcQYffNN/LCMVS3P9DlfHOs C5uysVVIQlWEWxVvlzscOvU0YoKxFJPx62xbo8UNuLrVjxrOxb+7OsKEjsql2rq4foOz rqRfHEgrw79NMWdcMNTQ7jsrN2mAwn636r7qAAy1KiieowRf+XdzZfdU56Lu/WGbE9N9 OuDX0zw3ZCX8RMZamB2HI4m6uaOZHYIexPeAlucHjoHho9jOXQv8+wVypU0AflPNRuy6 MXcezHcvh9WjvmTZ5N/BZ44vefZaKq4vqG761nroGip4JTXBD3yPvgvqiQr4Gf1xsLc6 ESmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vlKk1bN1CES0mgH+wUmCXkMlZA1CVtbOfxEG6y0GM50=; b=ERFR0S23M+lWEDHd9fPMM2CnGb9zSDJn+IK0vmSSIFR5OznAq+HOThvrB+vdpxwixr 2udZvzJbAPCNRrso7XNLL1HCFU1ewoj6SUChiEqezuu17Ua5OB+cMUegVQHdyej6JGe2 Y9gKW6VMkvDdc4XKL8zYmYIpw9IbUemg//GgiH8S6ktq9Pz9t2g0bFjVeFVsmj9uL9hT 4mVt3p3Oter7qpBpZAJUgHnfcq+IH7bhTDcSC608r/gxp0XKR+U0Eqzya87Ln+Fo6MMz mE4PdRVhCDOSZtd/QBi92C6cGOh8zJ2716UbhatGvzFuh2Mz9jmrqXbwkcGtZPdygYAr GtdQ== X-Gm-Message-State: AOAM531tHRm++JzRD38R0wDzEpprTwRNZy2BBoBURksww/iOrMn87Rpm Ra+5Wb0G6RuM9hXZb8kRvPDYTQ== X-Google-Smtp-Source: ABdhPJx+DjhnZ+3t53J8dx2EwysUVrWUxuaviQMjGuBmn9hdukh9eFyNPCUzF5Q2JEQuhsfmK3NPfw== X-Received: by 2002:a1c:4d0f:: with SMTP id o15mr21228wmh.142.1605548493144; Mon, 16 Nov 2020 09:41:33 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:32 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 10/42] drm/mediatek/mtk_disp_rdma: Fix formatting and supply missing struct member description Date: Mon, 16 Nov 2020 17:40:40 +0000 Message-Id: <20201116174112.1833368-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_disp_rdma.c:66: warning: Function parameter or member 'ddp_comp' not described in 'mtk_disp_rdma' drivers/gpu/drm/mediatek/mtk_disp_rdma.c:66: warning: Function parameter or member 'crtc' not described in 'mtk_disp_rdma' drivers/gpu/drm/mediatek/mtk_disp_rdma.c:66: warning: Function parameter or member 'data' not described in 'mtk_disp_rdma' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c index e04319fedf463..d46b8ae1d0800 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c @@ -56,8 +56,9 @@ struct mtk_disp_rdma_data { /** * struct mtk_disp_rdma - DISP_RDMA driver structure - * @ddp_comp - structure containing type enum and hardware resources - * @crtc - associated crtc to report irq events to + * @ddp_comp: structure containing type enum and hardware resources + * @crtc: associated crtc to report irq events to + * @data: local driver data */ struct mtk_disp_rdma { struct mtk_ddp_comp ddp_comp; From patchwork Mon Nov 16 17:40:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88FB3C63697 for ; Mon, 16 Nov 2020 17:41:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 454A7241A3 for ; Mon, 16 Nov 2020 17:41:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gfFikjbN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 454A7241A3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 78AD36E9F2; Mon, 16 Nov 2020 17:41:38 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFB756E9ED for ; Mon, 16 Nov 2020 17:41:35 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id d142so38227wmd.4 for ; Mon, 16 Nov 2020 09:41:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pCTuXmjwQai/CDFPUzQ3kg8YDOVHQv+4DVCFDqYGwk4=; b=gfFikjbNe9YkvOd+VXcfbf0J4Wd2441zhnFbQBUFTSfGl/11fLgrzMNsROSrDNKZnB 56O56aOR/HmR02tQ/3tiNJAhdUCmKv3PyRLNB0tFPnqebgucJjargzJMwuSJqsg4qUDz lUADz1TsIKFAEDWw/i6YYk8HVxvDJqeRjFeh11I8P7jIVCANAQ8XqJPeo2AmjbptibFD 3BUaOo+e/x2FHDxxqyNUMx1CFmyFSNvfDMIXzxiO4enNnSLj6DwZyaW/AX6d3z+XhZkM Hol8SB/aqA0USEkFwB5UEN9vO92vFQ3LpEYj0SMeSchExJmGtxQjQooiNX6+MTrjskNO qkgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pCTuXmjwQai/CDFPUzQ3kg8YDOVHQv+4DVCFDqYGwk4=; b=uV1JMju8r0tp5CKh8LhYAkSwpSvchBsT4n5Sc4xv6o0erQ29xqVuMS1yhvF6RRKsBO TMpMPNgzt9lVvTzt13Vv9Z7G4/Fx3yBD/Ir2lfv5aLBo7q4IA/bZ1I2NB4wl8qnFIcb/ 4LN+R3tr/gKpSiZd5yoqc8+Hu1T4K4OkgUu3dHKC2CxnukB0Rlyj72AzRDq6MO0GvjCg uY0+IiFuGbAfqjJGviMUVfOoPEQZtZnEp06tz4iA41DNsF5pZlBfUo1vzxmLxCQMHeMe JAU9F2o9j5uqwYuNRYUPyDGCr8MwGH3M5oXJ1N2+4oHWggRzQhvi7Q64JW9xGEwSossi utWg== X-Gm-Message-State: AOAM5311x+SBNbZ3ZLxVmdsaePeLFv27jZH8DoEkzVNIzNpsxhky0ykm Etk1E7m4JyhCyq2doOzJ+nN1aw== X-Google-Smtp-Source: ABdhPJwrqzcWWtyPydLaEIxmPE66hOyh5iCvJ3dX8GBSzMZleXIeT0J7SjvsguKoHdDSGAfq4DLbJQ== X-Received: by 2002:a1c:9ec9:: with SMTP id h192mr48224wme.8.1605548494375; Mon, 16 Nov 2020 09:41:34 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:33 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 11/42] drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header Date: Mon, 16 Nov 2020 17:40:41 +0000 Message-Id: <20201116174112.1833368-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" This needs someone with in-depth knowledge of the driver to complete. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'pending_needs_vblank' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'event' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'layer_nr' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'pending_async_planes' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'cmdq_client' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'cmdq_event' not described in 'mtk_drm_crtc' drivers/gpu/drm/mediatek/mtk_drm_crtc.c:62: warning: Function parameter or member 'hw_lock' not described in 'mtk_drm_crtc' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 193848fd75154..bfe9942305435 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -24,7 +24,7 @@ #include "mtk_drm_gem.h" #include "mtk_drm_plane.h" -/** +/* * struct mtk_drm_crtc - MediaTek specific crtc structure. * @base: crtc object. * @enabled: records whether crtc_enable succeeded @@ -34,6 +34,8 @@ * @mutex: handle to one of the ten disp_mutex streams * @ddp_comp_nr: number of components in ddp_comp * @ddp_comp: array of pointers the mtk_ddp_comp structures used by this crtc + * + * TODO: Needs update: this header is missing a bunch of member descriptions. */ struct mtk_drm_crtc { struct drm_crtc base; From patchwork Mon Nov 16 17:40:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910051 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EFDEC6369E for ; Mon, 16 Nov 2020 17:41:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9CD422450 for ; Mon, 16 Nov 2020 17:41:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="k6Jv+7mH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B9CD422450 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 850D26E9F4; Mon, 16 Nov 2020 17:41:38 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53E896E9ED for ; Mon, 16 Nov 2020 17:41:37 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id h21so44051wmb.2 for ; Mon, 16 Nov 2020 09:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e/knA7px3ItuZjnu7kmhshhnJxUB7qJyEjkrpKqZtiA=; b=k6Jv+7mHwhLKPJA/QCG06ugtxDKWpQTKy+20nzwFKSS58MARf4S8W8ACDDJb9At+kN Zj7BRm0cL5pJuZG03JgKNEOyxkFzKQDZEoeq6JKwur3GNW3waj1+cD/cATWqphXb/N3E Hwel7NdYgPQ30GBKTzLyGySsqlcZlYoScXIJf5HNpiV7Q9NiuYvKyh5I1UrBg1kr6UbV iCLuVTvJ0zQs9VHfs2J9H/qqPEg7slFJP5MGKs7bVItDI9ChEjoM5eM4spQGw5YLHt1S zBTagqyBF4NDMKbJ0sdlBYLtRa1aopP+KNyfSJbABRD/2iFY3eTiXtqFZBU8xFpxWZ8o d/bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=e/knA7px3ItuZjnu7kmhshhnJxUB7qJyEjkrpKqZtiA=; b=giynKuwiYrE1k+WYogb58wu+W/6vHVxVnzkGMt5lhOvEzEiA+se9vwWlPTgPyn/WdD p77+Oj3eXenMUYe6cEScbiUNj9W0dvqlkiGXe0fuL7fISmjkNAYbPBjPCf3MmoZx+ugw Fw1juLxADLzmqBwHNr9Cz7YEKCiP1ternpMgZ/mTlG3YboMk35tMzZjzQGI8z+7Ur2c6 ibwq3W7xQr9CWpRITF7awwpn1/9+h1+PXylTNiSP4VGIOyx07jLtCP+vxyWRMYqD7UuM F8MlRCBhR/l/aS3xxMr8iw/Ip43OlGz5HKRtpfMz1IlbOQ1PzRDKiYNqOa8GtMu7g1Cy xDgg== X-Gm-Message-State: AOAM533pFrKIbGUu4JZ4vqDu0lkBzPejlfEM0ei6BLZ97IwF1H0xboYS Vhe1Rr3IduQIkMnB4UqFlwigFw== X-Google-Smtp-Source: ABdhPJzqHnsBJooc4S8laQMeNPmpnnuKV6rHd3UhDvssbsZxsM79tG8D8ZiF2nH5S1+VMw/gXxelZg== X-Received: by 2002:a1c:5f83:: with SMTP id t125mr30364wmb.82.1605548495973; Mon, 16 Nov 2020 09:41:35 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:35 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 12/42] drm/mediatek/mtk_drm_drv: Staticise local function invoked by reference Date: Mon, 16 Nov 2020 17:40:42 +0000 Message-Id: <20201116174112.1833368-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Chun-Kuang Hu , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?q?Ch?= =?utf-8?q?ristian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/mediatek/mtk_drm_drv.c:316:24: warning: no previous prototype for ‘mtk_drm_gem_prime_import’ [-Wmissing-prototypes] Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: Sumit Semwal Cc: "Christian König" Cc: YT SHEN Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mediatek@lists.infradead.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 2e8065b1e2bbc..401311453e7d0 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -313,8 +313,8 @@ static const struct file_operations mtk_drm_fops = { * We need to override this because the device used to import the memory is * not dev->dev, as drm_gem_prime_import() expects. */ -struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev, - struct dma_buf *dma_buf) +static struct drm_gem_object *mtk_drm_gem_prime_import(struct drm_device *dev, + struct dma_buf *dma_buf) { struct mtk_drm_private *private = dev->dev_private; From patchwork Mon Nov 16 17:40:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910045 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C296C4742C for ; Mon, 16 Nov 2020 17:41:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E019322265 for ; Mon, 16 Nov 2020 17:41:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YVgEUmjS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E019322265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BD816E9FE; Mon, 16 Nov 2020 17:41:51 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id A08C96E9F5 for ; Mon, 16 Nov 2020 17:41:38 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id o15so19658373wru.6 for ; Mon, 16 Nov 2020 09:41:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i5j9nO6ToQvZzh6GJLxxL5NsV6KcH6bI4EH07Iu89H8=; b=YVgEUmjSraSC4YQk46p6uPgedVESFPJ3UsJO7Tu4f7fuWARoplJS6YC3o97e91JkZv cBJvp40l0dgXRQaLlTpEuC2Q0uQjxFAwNIn+7nMhNDcFl9mgKct6xkqQsfkHOtazXz+2 0vtjIjV1rLHuQlghb40vINrSHBkLUdnkRlbaH3ZaQRgQRO3OPNBtpNrxK6JPR7CTnpxq tdZwoh0efmPizM+AxDTig/MH+rwvLAxSZ445H6Y9Te1xq5aiCAH4ok1RxdGRQKkSivx2 HbtPLYE+ge6oxVRG/WTMb8LBqTG8kvBwxC8wW8p0HVl4kN8Y7Tn8G1Id1wAgUtBe/mLD s0Iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i5j9nO6ToQvZzh6GJLxxL5NsV6KcH6bI4EH07Iu89H8=; b=TxeRwMobO9QMzbw7t6N3kFMbWqEP7VQ5Fw+susqvTlkzKDGAA77EnCgBuGcOL8lV9Y iOLYBqz/ROXLm80pcjRRoXqKS8IeG8X1del20eEVkv6h8/aLKv6w+P5Lum2aBkkU+ivO bVRLauJoe56+AAOb6oAD1I8s1OjbuHUIYOzDIfkupenMab38423nVgK2uKR93G04u3eP MfaBwhO8hI0x6gMzv8V9oQPK0UOb/v3g7K7By05sdZilk6pqe8J/JQJv4yktdEUxLPFl v+Y27JKr2b6VG6Xub9Sx6xi2cj89BH8+iqw0+nnmTg/cxcdVbHu9H8L66mn7vTY6I4al 46eA== X-Gm-Message-State: AOAM530Mq0ivM5wck1D65YQGQ+8xW1x91gMWrw4Kf1db4yjmGM/9h0kg 6QaewUZY6zkAjFQv9oAEjDbzsg== X-Google-Smtp-Source: ABdhPJzrDkYQrEjZLrNb+YUFl0cr5yDvtdbI8mt3oNtaaL8k2XZ9HKXWkCH/mgSrQlJyfuBrthO8LA== X-Received: by 2002:a5d:6992:: with SMTP id g18mr20417522wru.362.1605548497365; Mon, 16 Nov 2020 09:41:37 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:36 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 13/42] drm/meson/meson_venc: Make local function 'meson_venc_hdmi_get_dmt_vmode' static Date: Mon, 16 Nov 2020 17:40:43 +0000 Message-Id: <20201116174112.1833368-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Kevin Hilman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/meson/meson_venc.c:893:6: warning: no previous prototype for ‘meson_venc_hdmi_get_dmt_vmode’ [-Wmissing-prototypes] Cc: Neil Armstrong Cc: David Airlie Cc: Daniel Vetter Cc: Kevin Hilman Cc: Jerome Brunet Cc: Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org Cc: linux-amlogic@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_venc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_venc.c b/drivers/gpu/drm/meson/meson_venc.c index f93c725b6f02d..5e2236ec189fa 100644 --- a/drivers/gpu/drm/meson/meson_venc.c +++ b/drivers/gpu/drm/meson/meson_venc.c @@ -890,8 +890,8 @@ bool meson_venc_hdmi_supported_vic(int vic) } EXPORT_SYMBOL_GPL(meson_venc_hdmi_supported_vic); -void meson_venc_hdmi_get_dmt_vmode(const struct drm_display_mode *mode, - union meson_hdmi_venc_mode *dmt_mode) +static void meson_venc_hdmi_get_dmt_vmode(const struct drm_display_mode *mode, + union meson_hdmi_venc_mode *dmt_mode) { memset(dmt_mode, 0, sizeof(*dmt_mode)); From patchwork Mon Nov 16 17:40:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910069 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2340EC4742C for ; Mon, 16 Nov 2020 17:41:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D564F20B80 for ; Mon, 16 Nov 2020 17:41:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="CpSZkmo/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D564F20B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 824CD6E9F9; Mon, 16 Nov 2020 17:41:51 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 249206E9F7 for ; Mon, 16 Nov 2020 17:41:40 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id s13so33593wmh.4 for ; Mon, 16 Nov 2020 09:41:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SDDB7TiTj4Jx/yTpGVCS2uqUdyiewZ4Ioe8JHQpewVc=; b=CpSZkmo/j2Y34JQwmQr2gL++XO1KYPcKHx6aqjTMLngU/acwN4t98DrtpoEAR+uHeA LEd2aN+YIEqfjA8qJitJOl7OQDlvxN+ELOtvUyVfK6NYEUWOZlChIVs4nqcg9elGQehe Mlbh/kBNojHRJE8HUO/6j3KiFXWV/lY/H0EeqDJEMCmSSqc8uetWdcK7KC1SKun3LNfM OsAvUf3KGN8GI1Q88IWDJ4JqQ4UIzj7/9UKQN0rkBTAyNfaB9AD252Kp8BTqLX7Ree6o 9Df3tJOHKVus3QnMsM1RqTTwVDZxjAWbtxLYFmHOymQolEp5oB4vsX1J35OYld7qBk2A gtag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SDDB7TiTj4Jx/yTpGVCS2uqUdyiewZ4Ioe8JHQpewVc=; b=Kg6faPN7vKavaTsKLc0L+SbbBTXFaJWP0IudXcny/AEz8nYfeP9u3fyL6D9GskqXO2 TFSfPZwYp2e0K7FYmU/rv3fTQ1EtGrE3pLQ9ap3g8mrpFgvh8SMdD7CR4ynFj/Z26qAg OGRPTx2ArkdimCh8lj/nl9elhf8JNzWh/Vpl2kUTvZiMNuvvAKTUqW9hgZ170pids4MQ QkkPgwjdGCmPXkFshzlfEfoB1ZK0n+pjQJN+wfwNwQokkZELzg4BIXz8jn5T6oGweqE6 pYkh1EheYt1OQWWH+bvCCA+9bzsd6y2xxImauRPPIiSPkpfOCQ8kwqLXxNYMJ5zQgGCi vIig== X-Gm-Message-State: AOAM531JeaISoUi9LnEYnyyhFW2awE7BtgkKy5ev/5vZd6YU7Wy+uaud EQufw0S/lczJTnj5u9dtHY1V5Q== X-Google-Smtp-Source: ABdhPJxPbxCum/XYvUgQugDBX75aEbB+JJYQEqSRBMPO4F/I/vRzV1yTYp53NsEEXN/uJBkrtTjG5Q== X-Received: by 2002:a1c:1fcc:: with SMTP id f195mr10459841wmf.121.1605548498820; Mon, 16 Nov 2020 09:41:38 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:38 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 14/42] drm/meson/meson_vclk: Make two local functions static Date: Mon, 16 Nov 2020 17:40:44 +0000 Message-Id: <20201116174112.1833368-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Kevin Hilman , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Martin Blumenstingl , linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Jerome Brunet Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/meson/meson_vclk.c:134:6: warning: no previous prototype for ‘meson_vid_pll_set’ [-Wmissing-prototypes] drivers/gpu/drm/meson/meson_vclk.c:490:6: warning: no previous prototype for ‘meson_hdmi_pll_set_params’ [-Wmissing-prototypes] Cc: Neil Armstrong Cc: David Airlie Cc: Daniel Vetter Cc: Kevin Hilman Cc: Jerome Brunet Cc: Martin Blumenstingl Cc: dri-devel@lists.freedesktop.org Cc: linux-amlogic@lists.infradead.org Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Lee Jones Reviewed-by: Neil Armstrong --- drivers/gpu/drm/meson/meson_vclk.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/meson/meson_vclk.c b/drivers/gpu/drm/meson/meson_vclk.c index 0eb86943a3588..2a82119eb58ed 100644 --- a/drivers/gpu/drm/meson/meson_vclk.c +++ b/drivers/gpu/drm/meson/meson_vclk.c @@ -131,7 +131,7 @@ enum { VID_PLL_DIV_15, }; -void meson_vid_pll_set(struct meson_drm *priv, unsigned int div) +static void meson_vid_pll_set(struct meson_drm *priv, unsigned int div) { unsigned int shift_val = 0; unsigned int shift_sel = 0; @@ -487,9 +487,9 @@ static inline unsigned int pll_od_to_reg(unsigned int od) return 0; } -void meson_hdmi_pll_set_params(struct meson_drm *priv, unsigned int m, - unsigned int frac, unsigned int od1, - unsigned int od2, unsigned int od3) +static void meson_hdmi_pll_set_params(struct meson_drm *priv, unsigned int m, + unsigned int frac, unsigned int od1, + unsigned int od2, unsigned int od3) { unsigned int val; From patchwork Mon Nov 16 17:40:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED99C61DD8 for ; Mon, 16 Nov 2020 17:41:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28C0E20B80 for ; Mon, 16 Nov 2020 17:41:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g4UiDscw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28C0E20B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5AE36E9FF; Mon, 16 Nov 2020 17:41:51 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93F0389FED for ; Mon, 16 Nov 2020 17:41:41 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id k2so19702532wrx.2 for ; Mon, 16 Nov 2020 09:41:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tTwQDvBtnpWbM0srw/EUqdspNhCuLlcukla9ix/INuQ=; b=g4UiDscwY/1oIPlgmGmNSmsyprgvCPP0mfkN+jRO3SE5cBqae6RaGAR9IUaPSZUxof j13OCWwzarpHIiVkv/lCvijBftpfBu3CfwV0uAjtOACmRqUmmVRJlu1hHjjaEbDQlhau I3K2FUugZPw1tr7zsOT1+KjOpoBTufXi3dq7ToTrVwC/NOrUntqtEDSpKQ+AMfuu02b+ IHC2wQjp7Zo7nwOPGEe5P34uAZNk9FrdMb1xYPUHtFbeTil2AN3lzicyIi1JXHzEphOm MHsyCNW6VNsOf4OCewOVHOGuHu2VVqA3RsBCJbEMA5lv0zhTazg/R/MSD/z2Av9RU94p 3YxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tTwQDvBtnpWbM0srw/EUqdspNhCuLlcukla9ix/INuQ=; b=pDffbLvo38qJPaiin89e0zqJDW0JrVPU9qAIdT+E3ligzNUa/F0B+TSfauf6oKqUfw Agax1z3TFuJsO2TWLSbOiujsQB94pdf7YCDWwZyWacBAV7QdKI7k9evRd+ywQfZiUspz sqEEtq4hPiDSvd6pBB6LbvzP2UU0Anch2uLEcmJy2HJh0EVO/RO9BwR8MXkjYlxjRYvi hHYzCXFi5DMLtZ03yDZTpK5LBZqJQSWscqoXTGa4VV9fpugPgOS2FnvlhUKz2H6bUaBa 463qQbqM2HiU6L+o559QPMB/cZkf6MhcfXaobcWgD4DbhKJK+FtD1Yy4jHXL6YvjFYdM xaZg== X-Gm-Message-State: AOAM531TX8EyRPTMJaptgxhL2sLgY0DPTdw0U9HyXphBNb8/EQlNfhad VQ8nGivbr3altKZSl94CSDWwvA== X-Google-Smtp-Source: ABdhPJyNP2NVhgTiLMxWbWxmQP47XGLeaZhP7nL1I8MHMwAmQ8wJVsvtnCWCCTWN8bCCxgCJTJY0tw== X-Received: by 2002:a5d:4ec2:: with SMTP id s2mr20442206wrv.258.1605548500288; Mon, 16 Nov 2020 09:41:40 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:39 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 15/42] drm/msm/adreno/a6xx_gpu: Staticise local function 'a6xx_idle' Date: Mon, 16 Nov 2020 17:40:45 +0000 Message-Id: <20201116174112.1833368-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/adreno/a6xx_gpu.c:33:6: warning: no previous prototype for ‘a6xx_idle’ [-Wmissing-prototypes] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c index fcb0aabbc9852..03c2f7e0c9497 100644 --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c @@ -30,7 +30,7 @@ static inline bool _a6xx_check_idle(struct msm_gpu *gpu) A6XX_RBBM_INT_0_MASK_RBBM_HANG_DETECT); } -bool a6xx_idle(struct msm_gpu *gpu, struct msm_ringbuffer *ring) +static bool a6xx_idle(struct msm_gpu *gpu, struct msm_ringbuffer *ring) { /* wait for CP to drain ringbuffer: */ if (!adreno_idle(gpu, ring)) From patchwork Mon Nov 16 17:40:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910053 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF50CC61DD8 for ; Mon, 16 Nov 2020 17:41:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B11D20B80 for ; Mon, 16 Nov 2020 17:41:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Z4HwkZNc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8B11D20B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 593726E9F8; Mon, 16 Nov 2020 17:41:51 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5684E89FED for ; Mon, 16 Nov 2020 17:41:43 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id k2so19702693wrx.2 for ; Mon, 16 Nov 2020 09:41:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3yKXccTq4RQml8AaT9zp7DsIehEAA7Cw2xDOtV48iYo=; b=Z4HwkZNcwa5jwVBqtO868Oti/4mRDTj3PsEnbA681wpGYPCwsRjObQJnxRfXliZQaY vc7oFU5DAWujWdiXZ0C6rumJoAbS3YkpNzFM1QXAfG42OAZqPv85T0Plwmja14RlZ3al xD0uxE2BO4c4ocCIddXqvFeUFEcqfAkMSoSUf9IqsUs3p/ajB0iKERvvf49d380U2qHa tFdccMpqSYgrd8IKH4FrZ/Jd/wAXTwCB9inNdXVt0wCoLJ3/PhKfnuaVsvmjieBGmzPI TQbg8r+l+jHh1OuelXM+aj9qw11AKj3oFJjDyxwz3Jr0DsJNbd5w3Ru0OHUWBQ/dMGtF rcOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3yKXccTq4RQml8AaT9zp7DsIehEAA7Cw2xDOtV48iYo=; b=A4hKtwt39HgwnjwbsNN5bjENmK2MbAETy25jwjwBY5Wxb3gmzl+xMqNPZyxE4Rfphu 66SzFuHmKk2olAEzR0qYS5/02ojszrAZPxrHGMb2Ye7qCo4NP11wioEvBXYJlxzDIbNN +uekluJJz8lXPua5TQV1Q3B9FtsfghNju1rh29tjCREynU/JBL0tOUvPuO4kRSLXRyb/ ualw9jgcKYVj0m1cMoaS8rofbkt4bS8n9RA4JHX4wxo+74OZKoSmn26sOrfK+dyyOQhQ qV0VrKKkJjkqZIy/KQ41z4EcUa/6/hoMOb2JAvgD0qdSKtmes9eEOyizh3C4CTjfPGx4 k6xg== X-Gm-Message-State: AOAM530VGxGo69XlofRx/R/jqXvFXDuP6WjYcxHeBYzm5dFouIySMDXt 8pr4xr/qTmXlEPZD9EvpAGTFxg== X-Google-Smtp-Source: ABdhPJwINg/ac/HzXNmMAXKy2lkQiCTdKUFax/vtf42+MajVaIC/uOHsaxPcQHd5B36XPKPbQ/fE2Q== X-Received: by 2002:adf:a3d1:: with SMTP id m17mr19678094wrb.289.1605548502077; Mon, 16 Nov 2020 09:41:42 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:41 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 16/42] drm/msm/disp/mdp5/mdp5_crtc: Make local function 'mdp5_crtc_setup_pipeline()' static Date: Mon, 16 Nov 2020 17:40:46 +0000 Message-Id: <20201116174112.1833368-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar , Thomas Zimmermann , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c:581:5: warning: no previous prototype for ‘mdp5_crtc_setup_pipeline’ [-Wmissing-prototypes] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c index 79dd56faf3de0..0c8f9f88301fa 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c @@ -578,9 +578,9 @@ static void mdp5_crtc_atomic_enable(struct drm_crtc *crtc, mdp5_crtc->enabled = true; } -int mdp5_crtc_setup_pipeline(struct drm_crtc *crtc, - struct drm_crtc_state *new_crtc_state, - bool need_right_mixer) +static int mdp5_crtc_setup_pipeline(struct drm_crtc *crtc, + struct drm_crtc_state *new_crtc_state, + bool need_right_mixer) { struct mdp5_crtc_state *mdp5_cstate = to_mdp5_crtc_state(new_crtc_state); From patchwork Mon Nov 16 17:40:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910063 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80455C63697 for ; Mon, 16 Nov 2020 17:42:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 43E9420B80 for ; Mon, 16 Nov 2020 17:42:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p2MDgQX/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43E9420B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B6AAD6EA01; Mon, 16 Nov 2020 17:42:00 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id EF56C6E9F5 for ; Mon, 16 Nov 2020 17:41:46 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id c17so19627796wrc.11 for ; Mon, 16 Nov 2020 09:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nUt9W7GZWBzXYxZLOdkAJHN0947I5vPgihBPSlg9tj8=; b=p2MDgQX/wofftkkr1Hy4/72WZE0tdzpOt5FVLHl0WdVI391TYiA+wQE+3Qv15Wev+K 1C/3yMtFQfGzVbXpJ+k2jQIDu07h2B2x+BqjRUY6JXv+1njqRBOd6GBuLP6+7M8AwHDB abfRtQE9KsXwu463fk4uX/pjlR0P72t8HyIiSMtE24bHGlVed/pW5LQ/7E6culC49Cas f4Lor5+/lgetHGYXYwq3C8HCnrJqkC1PH50HCucS4EHC/XpRkJzguHigLsLHACZjdL1F wPzQvak0EVel6EWTt8s1bgoVvaENbqFgSMduIVtNtiVmW1aSRdwBOU3YeatY5V1e9PJG LUig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nUt9W7GZWBzXYxZLOdkAJHN0947I5vPgihBPSlg9tj8=; b=FT2TJFePeNoSRihGhITbhkna4hbfh/N+gXreTI2RQNrPNHUqR6Pr+3oicHeMaLRrsq n4UhOjyqdoWDfq2Oa4l4cjCy9f+MRMvRqCpTuKDJR0DWFMVprT7dBvfYKMztCDVvwtkT PFYLIEgwZGeIJII6yU4DLcKo3Jm18FJUnhAqOncXCHQYep1fiku5YhtX+y/MS92HjZvj Eem5apznR/4SO/HvM56QHJfl/iFT0JC9Y4r1k/jGRbppFDe7NmeDttqSoS8thjkzC3kN XByqa4N58IAHn2f7fkTFPSOvHxOgG8y8rgLMhdUd+JS688ou3tScBrlRi3XICoiAH/fi TeIw== X-Gm-Message-State: AOAM530RnvgLPYAvgi1UWj7rYcM7MrZ3sfaK9zdzhXIDavkYUfNPDOkq wp57JsHhwr7jJNxIA6jmpqeNFg== X-Google-Smtp-Source: ABdhPJwrJ3qM0N77lCgwewkn0o/4BJZQjYlEpD5Odpef/EinSGDz+FIBUabKsEPNOivdq3sEqD4lTg== X-Received: by 2002:a5d:4802:: with SMTP id l2mr19916658wrq.424.1605548505702; Mon, 16 Nov 2020 09:41:45 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:45 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 17/42] drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers Date: Mon, 16 Nov 2020 17:40:47 +0000 Message-Id: <20201116174112.1833368-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Very little attempt has been made to document these functions. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function parameter or member 'ctl' not described in 'mdp5_ctl_set_encoder_state' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function parameter or member 'pipeline' not described in 'mdp5_ctl_set_encoder_state' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Function parameter or member 'enabled' not described in 'mdp5_ctl_set_encoder_state' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:227: warning: Excess function parameter 'enable' description in 'mdp5_ctl_set_encoder_state' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function parameter or member 'ctl' not described in 'mdp5_ctl_commit' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function parameter or member 'pipeline' not described in 'mdp5_ctl_commit' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function parameter or member 'flush_mask' not described in 'mdp5_ctl_commit' drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c:529: warning: Function parameter or member 'start' not described in 'mdp5_ctl_commit' Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c index 030279d7b64b7..b5c40f9773629 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c @@ -213,10 +213,10 @@ static void send_start_signal(struct mdp5_ctl *ctl) spin_unlock_irqrestore(&ctl->hw_lock, flags); } -/** +/* * mdp5_ctl_set_encoder_state() - set the encoder state * - * @enable: true, when encoder is ready for data streaming; false, otherwise. + * @enabled: true, when encoder is ready for data streaming; false, otherwise. * * Note: * This encoder state is needed to trigger START signal (data path kickoff). @@ -507,7 +507,7 @@ static void fix_for_single_flush(struct mdp5_ctl *ctl, u32 *flush_mask, } } -/** +/* * mdp5_ctl_commit() - Register Flush * * The flush register is used to indicate several registers are all From patchwork Mon Nov 16 17:40:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910057 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBC36C4742C for ; Mon, 16 Nov 2020 17:41:59 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C5CC22370 for ; Mon, 16 Nov 2020 17:41:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SZzvnaPl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C5CC22370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 38C8A6E9FD; Mon, 16 Nov 2020 17:41:51 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5B4576E9F5 for ; Mon, 16 Nov 2020 17:41:48 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id j7so19656892wrp.3 for ; Mon, 16 Nov 2020 09:41:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zaOWUirapOMKdJjjw4CYfsGkQWJEzsRRXuyaScDdWWw=; b=SZzvnaPlGmKaGhwLDI8bK/PrqeAqX3Tzh3PFCfAojHswVs3cNeVXia8ZyyNr/0HKml 0Z7cEu+HZ/LfqDgJH3XVE36FVTy+hRhvEH6UZwZ2iS/UnxNr3bpr+YcDcNoJLSFym2sd enlFXh22dS+MhLz8hfl7RwQjUVJ35/+HjAKVQfY3sZi/xGOXVfq08KxiPIJiTHQFtk0O QivALG0h+IlOt2wmevscLXqGad1jp/hRwb321/w6WSfb0PErg240VG6L7pYaiGwhMDgR 3hEM11SF8rorHuesj2T5fPLYilixaTFMkw/mSdNSJzVMFQLZqGEYLLtPFfziBjOOp8/h t6NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zaOWUirapOMKdJjjw4CYfsGkQWJEzsRRXuyaScDdWWw=; b=ZdyX9li8hKVW94PtTw4Avv3odjixCKWWYN0OAwajsmB/n8/UehkGAPJblFjAxx6khD e9zJNzjo5ZSZzSBNESNznmTyDTED/nnks7kR91d4cNwwW2qMrjYLchuFh4Js6Yhn61bx xODxlX1rlX0wJTTNGFCNh3Z9Gs3ZsRimPAJzPOa3xm334XISFWfI264iuscfW3xhiwkb YZXvjKumYa8P3pPVBqm+lrbW+jcbqd+VCJweAvte2LbXqTRcJMoiqOosFKxp/i9TV01V yRGyEFJ7sdF/wTTVNEnXM2E4ozcmzyN2WXVfphCFV2lx021Aqa0P9bQojwXmzb1BfQFw geKg== X-Gm-Message-State: AOAM533uI5ZxeBb7YOt9oxMJBcXqyveJ7KGA6BgOIx09Dt+Dx6W4FkkF 8FlKX74NwR1NwftNUuFB3xeq3A== X-Google-Smtp-Source: ABdhPJwDRGMUsoxv5ZHmxzgDdOLRIafHWuBlZ52nBUgXdgXycAMRa/hoxqy8d2KU665TpEmzQkY4KQ== X-Received: by 2002:a5d:654a:: with SMTP id z10mr19192489wrv.285.1605548507104; Mon, 16 Nov 2020 09:41:47 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:46 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 18/42] drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en, dis}able()' static Date: Mon, 16 Nov 2020 17:40:48 +0000 Message-Id: <20201116174112.1833368-19-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar , Thomas Zimmermann , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:299:5: warning: no previous prototype for ‘mdp5_disable’ [-Wmissing-prototypes] drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:319:5: warning: no previous prototype for ‘mdp5_enable’ [-Wmissing-prototypes] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index b3eecf8694771..15aed45022bc8 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c @@ -296,7 +296,7 @@ static const struct mdp_kms_funcs kms_funcs = { .set_irqmask = mdp5_set_irqmask, }; -int mdp5_disable(struct mdp5_kms *mdp5_kms) +static int mdp5_disable(struct mdp5_kms *mdp5_kms) { DBG(""); @@ -316,7 +316,7 @@ int mdp5_disable(struct mdp5_kms *mdp5_kms) return 0; } -int mdp5_enable(struct mdp5_kms *mdp5_kms) +static int mdp5_enable(struct mdp5_kms *mdp5_kms) { DBG(""); From patchwork Mon Nov 16 17:40:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273AFC2D0A3 for ; Mon, 16 Nov 2020 17:41:52 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA4FC2227F for ; Mon, 16 Nov 2020 17:41:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="X+iICUpO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA4FC2227F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B27EC6E9F6; Mon, 16 Nov 2020 17:41:50 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id AD6296E9F6 for ; Mon, 16 Nov 2020 17:41:49 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id p22so45162wmg.3 for ; Mon, 16 Nov 2020 09:41:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9DOFB5vifJrGCOQSMWDE/st4cKx6AKkD/v2b5HFyfb8=; b=X+iICUpO07+6FTpBe9dc71KtGg8uVMewqxXw4D54HQsNDi4x7YTQk2GI/vSs8br2zi crL563AJExk5eH18GIwjCAD0tshWPsin4COHswwCL/nH8tx33M1PjxIOU3kiTc8Fvs/u gSRDchhQJmAEdF9gUpcdoeNucpAXAp8CNKCRwvF3+HVAfYHagK75m6m7RatkRP0atc2m 9zQwBX4MPKuBogzEL+AppX1vdWxnkxbscsUjUd8g1/tOhIMjquQ7asSMKY52j9Lc9L2n TOYOoTdPw779Nlt23XfL9DpCiipWJ7T1NQval3HatqKNeblalmvAiatADjg04bp4H9PL Wj/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9DOFB5vifJrGCOQSMWDE/st4cKx6AKkD/v2b5HFyfb8=; b=RrPxSMVYaKs28bUsr9RU/Lmh+TYNiaImRSXyQNWIaKG2PJGz7LMmQyR8XFKbskxw3w ysKDQSO54CmOJA+X7/8wDmESsecHliCw3ZWDJwqZkWL3N/GXyuOaV4O00EM9PFGiI44g Tn6It4vzIRFo7a3Ar7+2Pzi3hWTiQfIieHKnYv4+/G6f6OqyX+lfkr6TTnYeUTE0qeK3 DRgWa0q8KzPS4FuGsih10ey5vUx/CVQYUgA4FKT+rDlcFLkgCbQsmQs4aeLT2+vm0Oab yjiYhOz7NNhjcLunrnk5vo3om8YvQoNp0MA6C9mGPqiNmM3T/BW314R+tLu6W8FkBxYn fI6A== X-Gm-Message-State: AOAM532MASxaHqk2aFHME/eHBqVkknAL/8QbW5qJt3xVZExuQ6g588V4 aeA+4n1OAt2GrBL/Ybkg89msiA== X-Google-Smtp-Source: ABdhPJzQZhOALgumhAbivo10Vy33TnY2EYrd0cLJQ2AYyUelagMOBvYfUJ3vbWdMCxrsbK35mPWjMw== X-Received: by 2002:a7b:cbcf:: with SMTP id n15mr15729wmi.156.1605548508417; Mon, 16 Nov 2020 09:41:48 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:47 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 19/42] drm/msm/disp/dpu1/dpu_core_perf: Remove set but unused variable 'dpu_cstate' Date: Mon, 16 Nov 2020 17:40:49 +0000 Message-Id: <20201116174112.1833368-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar , Kalyan Thota , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c: In function ‘_dpu_core_perf_calc_crtc’: drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c:113:25: warning: variable ‘dpu_cstate’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: Kalyan Thota Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c index 37c8270681c23..36927fc04a388 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c @@ -110,14 +110,11 @@ static void _dpu_core_perf_calc_crtc(struct dpu_kms *kms, struct drm_crtc_state *state, struct dpu_core_perf_params *perf) { - struct dpu_crtc_state *dpu_cstate; - if (!kms || !kms->catalog || !crtc || !state || !perf) { DPU_ERROR("invalid parameters\n"); return; } - dpu_cstate = to_dpu_crtc_state(state); memset(perf, 0, sizeof(struct dpu_core_perf_params)); if (kms->perf.perf_tune.mode == DPU_PERF_MODE_MINIMUM) { From patchwork Mon Nov 16 17:40:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910085 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41228C2D0A3 for ; Mon, 16 Nov 2020 17:42:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED05F2344C for ; Mon, 16 Nov 2020 17:42:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mpqKiv0z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED05F2344C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 431AE6EA00; Mon, 16 Nov 2020 17:42:06 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 055636E9F9 for ; Mon, 16 Nov 2020 17:41:51 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id m6so2480280wrg.7 for ; Mon, 16 Nov 2020 09:41:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=W1MHY4aaGFabv01eWFz4IHQEmJmgXDktxmU/mwniRQM=; b=mpqKiv0z8EhJ1hkWKiD4s3yFbia9Nq2ccdMY5wK4NY+1NhTHbISUM0ZH3ZCHS26yIY 6O92czvRbWnbgPQe9WAFU9K/ifLShQgqoCdc7wLL0GhgXqzaJijOqVfYbvzNe6LIIrEV npClTG9jo/n4w5RaShICj+fD7GkqO5I7mu+U0V9gizrF3eBSNbo4+XqLYYmIaqdgUX9Q XQhvG0ntpPs8mW8I2RcJcfkUebZtEbvrmRX8nwIuOSrjkDv5t30hRk4VdnTEpzExNK9u h7JAg3+m/h/EUMPZYwgmbeUUW31PgTukkL+KomU9Y91HNvhWS1dYAqQp0E8FWX/P9HJ7 1nQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=W1MHY4aaGFabv01eWFz4IHQEmJmgXDktxmU/mwniRQM=; b=PFdAa5m1DD0WLqJawCN2fXEVcATuIcSqd3MRGIOdr9aOMfr6+qnKWB6ZCHvPh5HgPD q7e9FyU7q5kGY/EIJB0NLuvZzvkVgNiv4gMDYRDQSqz4zJ3oBvQjl+Ou3VD3HI3CymEp 1TfScgYkUjFFWucyUlqih+dgJ1RUKYllF+yS5zQhriKdbfkkgPpFdXG6C9GoajQCjOqu P1DGtrYM9K48f33DrmdKvElgV+OnfFtVjHAX40g/7hXtcg2Rv34Z6kV0eLn1vVo4CQQ1 OhrzYr6YtUNpSYhI2gs1/rWZsyIEM9HH79U5rPkrDl9BXfcua78NYz18sVFMqQyeD9b1 xfQQ== X-Gm-Message-State: AOAM530aIcmUmYPtvYj1EWrdwIUu7n5pMMZFvwG0CDEYi4BvyCGgOHsX eKP+z28Si10NjfE1vzrUWAJbKw== X-Google-Smtp-Source: ABdhPJwZ0jSj+/r94Ojpe6Rg7ZSUOee9IJj4lYLdYAt/Xz4U6G4d3Gz4HVMuhx4NAwzNQfjCx3+8NA== X-Received: by 2002:adf:dc4b:: with SMTP id m11mr19844677wrj.328.1605548509721; Mon, 16 Nov 2020 09:41:49 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:49 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 20/42] drm/msm/disp/dpu1/dpu_encoder: Remove a bunch of unused variables Date: Mon, 16 Nov 2020 17:40:50 +0000 Message-Id: <20201116174112.1833368-21-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function ‘dpu_encoder_virt_mode_set’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:981:31: warning: variable ‘num_dspp’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:976:30: warning: variable ‘topology’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function ‘_dpu_encoder_virt_enable_helper’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1099:26: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable] drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c: In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1210:18: warning: variable ‘dpu_kms’ set but not used [-Wunused-but-set-variable] Cc: Rob Clark Cc: Sean Paul Cc: David Airlie Cc: Daniel Vetter Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index f7f5c258b5537..289bfb6f1861c 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -973,12 +973,11 @@ static void dpu_encoder_virt_mode_set(struct drm_encoder *drm_enc, struct drm_crtc *drm_crtc; struct dpu_crtc_state *cstate; struct dpu_global_state *global_state; - struct msm_display_topology topology; struct dpu_hw_blk *hw_pp[MAX_CHANNELS_PER_ENC]; struct dpu_hw_blk *hw_ctl[MAX_CHANNELS_PER_ENC]; struct dpu_hw_blk *hw_lm[MAX_CHANNELS_PER_ENC]; struct dpu_hw_blk *hw_dspp[MAX_CHANNELS_PER_ENC] = { NULL }; - int num_lm, num_ctl, num_pp, num_dspp; + int num_lm, num_ctl, num_pp; int i, j; if (!drm_enc) { @@ -1020,8 +1019,6 @@ static void dpu_encoder_virt_mode_set(struct drm_encoder *drm_enc, if (drm_crtc->state->encoder_mask & drm_encoder_mask(drm_enc)) break; - topology = dpu_encoder_get_topology(dpu_enc, dpu_kms, adj_mode); - /* Query resource that have been reserved in atomic check step. */ num_pp = dpu_rm_get_assigned_resources(&dpu_kms->rm, global_state, drm_enc->base.id, DPU_HW_BLK_PINGPONG, hw_pp, @@ -1030,7 +1027,7 @@ static void dpu_encoder_virt_mode_set(struct drm_encoder *drm_enc, drm_enc->base.id, DPU_HW_BLK_CTL, hw_ctl, ARRAY_SIZE(hw_ctl)); num_lm = dpu_rm_get_assigned_resources(&dpu_kms->rm, global_state, drm_enc->base.id, DPU_HW_BLK_LM, hw_lm, ARRAY_SIZE(hw_lm)); - num_dspp = dpu_rm_get_assigned_resources(&dpu_kms->rm, global_state, + dpu_rm_get_assigned_resources(&dpu_kms->rm, global_state, drm_enc->base.id, DPU_HW_BLK_DSPP, hw_dspp, ARRAY_SIZE(hw_dspp)); @@ -1096,7 +1093,6 @@ static void dpu_encoder_virt_mode_set(struct drm_encoder *drm_enc, static void _dpu_encoder_virt_enable_helper(struct drm_encoder *drm_enc) { struct dpu_encoder_virt *dpu_enc = NULL; - struct msm_drm_private *priv; int i; if (!drm_enc || !drm_enc->dev) { @@ -1104,8 +1100,6 @@ static void _dpu_encoder_virt_enable_helper(struct drm_encoder *drm_enc) return; } - priv = drm_enc->dev->dev_private; - dpu_enc = to_dpu_encoder_virt(drm_enc); if (!dpu_enc || !dpu_enc->cur_master) { DPU_ERROR("invalid dpu encoder/master\n"); @@ -1207,7 +1201,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) { struct dpu_encoder_virt *dpu_enc = NULL; struct msm_drm_private *priv; - struct dpu_kms *dpu_kms; int i = 0; if (!drm_enc) { @@ -1225,7 +1218,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) dpu_enc->enabled = false; priv = drm_enc->dev->dev_private; - dpu_kms = to_dpu_kms(priv->kms); trace_dpu_enc_disable(DRMID(drm_enc)); From patchwork Mon Nov 16 17:40:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910067 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9FD23C61DD8 for ; Mon, 16 Nov 2020 17:42:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4B94B222E8 for ; Mon, 16 Nov 2020 17:42:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q/5s24f2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4B94B222E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2D97A6EA07; Mon, 16 Nov 2020 17:42:01 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 44EEE6EA01 for ; Mon, 16 Nov 2020 17:41:52 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id a65so49986wme.1 for ; Mon, 16 Nov 2020 09:41:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=voWmA7JwfKGhDZMYWPZkZRLYOBpcwZ/fXqx90N9cMjo=; b=Q/5s24f2J2WYaf1lDVin02W6tDLEn9ETKKVIAlSa3geYU2EDOSCN8AHyxHt4cvgOCh zTPfZjuqBYHxS2cnpdwzjJC+ZUVxIi9H4UJwrkv0ytH6ZgGUXx35pl+RRgKBsHxPcfDS yHiyh2/prpOiQauOfr6NeOlW8bUML1ksJJex8rye/wHRVQpip2qLEAyWp3kUlXJSK0Er sjLFTmYOVG3joUvxSqsetKTtYqtR6t03eAT1M00X3rfX/vlI3+doDpxEz0yyTFG0N8sw cqDeBro+6ick1o85xj9vMwMomzZ+imZLDJNd7CFBTPKTPHhQj1HKKY0tE0vry6ZKlEH4 7B1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=voWmA7JwfKGhDZMYWPZkZRLYOBpcwZ/fXqx90N9cMjo=; b=Q+GeV9ciMemo+T/IZOqJ+KVaZtCkjUfoYZHqjodhAsE/iRq46PMBho2WrO9C3MZU7u iiEwlPVSJhUrmGYSyfWUVDN+iK65XS/+CTB5jDK92eyaaNFKsUqvQ5ONPvEJAyYXWMl/ C2WCCcdWUqq/CVZRlcifIyih4BDUxltQ3NcXg27ozxJ4BzgVj4dgyDVaSBfUAdeW9HzP 0eXmEiQ51VfOpRN0PHLimhN3DtNCMVPrGkVyuHV5WViQjG0VihiaWzt2OQNkX3EcKvqP 5iCKgFJgnJPQ6N+l86h9+Z7085WLn/CW774KJmW+1FoKdYwF0OUQbUFfUYt0jA9ZYtVI X8fw== X-Gm-Message-State: AOAM532CYIoVbSNeq0jkN+hy1FfFVlyfnP9yUqjMtO+7OK1HMUXOOsW5 bU6iIvxLIMiZayKu878b1hECyw== X-Google-Smtp-Source: ABdhPJwuvAgqDWMZ3sjRi0c2yQlbytErPP7kxds1VUQAakjg1WWYvU8tM8e0449EbLG8YOVOAFyozQ== X-Received: by 2002:a7b:c18e:: with SMTP id y14mr7520926wmi.123.1605548510917; Mon, 16 Nov 2020 09:41:50 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:50 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 21/42] drm/nouveau/nvkm/core/firmware: Fix formatting, provide missing param description Date: Mon, 16 Nov 2020 17:40:51 +0000 Message-Id: <20201116174112.1833368-22-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ben Skeggs Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ... and demote non-conformant kernel-doc header. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'subdev' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'fwname' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'ver' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:71: warning: Function parameter or member 'fw' not described in 'nvkm_firmware_get' drivers/gpu/drm/nouveau/nvkm/core/firmware.c:106: warning: Function parameter or member 'fw' not described in 'nvkm_firmware_put' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: nouveau@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nvkm/core/firmware.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c index 8b25367917ca0..ca1f8463cff51 100644 --- a/drivers/gpu/drm/nouveau/nvkm/core/firmware.c +++ b/drivers/gpu/drm/nouveau/nvkm/core/firmware.c @@ -58,9 +58,10 @@ nvkm_firmware_load_blob(const struct nvkm_subdev *subdev, const char *base, /** * nvkm_firmware_get - load firmware from the official nvidia/chip/ directory - * @subdev subdevice that will use that firmware - * @fwname name of firmware file to load - * @fw firmware structure to load to + * @subdev: subdevice that will use that firmware + * @fwname: name of firmware file to load + * @ver: firmware version to load + * @fw: firmware structure to load to * * Use this function to load firmware files in the form nvidia/chip/fwname.bin. * Firmware files released by NVIDIA will always follow this format. @@ -98,7 +99,7 @@ nvkm_firmware_get(const struct nvkm_subdev *subdev, const char *fwname, int ver, return -ENOENT; } -/** +/* * nvkm_firmware_put - release firmware loaded with nvkm_firmware_get */ void From patchwork Mon Nov 16 17:40:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910061 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2D83C61DD8 for ; Mon, 16 Nov 2020 17:42:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B21BF222E8 for ; Mon, 16 Nov 2020 17:42:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rJZgv0r3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B21BF222E8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id ED9BA6EA05; Mon, 16 Nov 2020 17:42:00 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E45B6EA00 for ; Mon, 16 Nov 2020 17:41:53 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id c9so35275wml.5 for ; Mon, 16 Nov 2020 09:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+170YZVUptUVP8b8DCIuLCBL2J9gnyH4hHHhpysSOuQ=; b=rJZgv0r3y1uaooYzLQ77T067OtNBcziJ1kMk4hccmXIIg+vWYcZOw6hRxBvEbvrc0e 54BY9C/GyH3afuOmhUyh6oT2QBbXnogaeE9MwZ8W5t2+aGcJ3fqzTwm9tMeqqBDsagX9 9IkPccddWCzGVUmqxsrk1Dhwh1XIH8iyVoIKyOqo0YydsxRfN8zwh930DQ8CFItkCyld 8XlOZ70+ZtnSKmSDmqzspsXieifAqjySJVAavAWNnzUcekoawVH3eL0zRZC+k2YBSfqQ gUpEssUZXiRRFwtseSyNvOhXWtr/4Qbonpf5kRYeA35GUHQD3fpKSDAovTkR3QY/Vhag HIFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+170YZVUptUVP8b8DCIuLCBL2J9gnyH4hHHhpysSOuQ=; b=kQg1lbn8NduDq6italiPMv9FG0lE91VKECw2st3Jd8IrHxF+sp7NSA31FIJnBjQjhe 6pxnONiBOk34kr6K4cjzAewVGWAa7e+nDZtyU/dJAhVJuqqwZkUsoHD6gDWQ3Z2Y1A4W VdPooeqKygoEuP8yIBNCfqZQt1FsxXSaQtvf8/PA92qrYxGw5NCezmfmaDxyNttC1j6G /LqF1tby6kVTOBkiUBCkeZ0dedGUnBFWrsAyt5SFt76jggdLNIGTI+La3bn8bXWg2ZG3 1zdTkWlPxpn17WhUFv95g3Qu3i9aRpTEiurYbVJ7TKcoUzbnFyrukr478M9FrHtxfsfo hLLw== X-Gm-Message-State: AOAM530ZHl+lm414X9hwLuYouhunmjT41nsZojLZLCSamqXbXrLasicl /rbfG8txwlDIuPf8KXiNmexoN7qky1Vt+FWV X-Google-Smtp-Source: ABdhPJzrdNHfcckGPvTVYiKyOTyfZ8lac3YqV+u13joqzDyl9nbQ+6pDIovDVylNGHeenJsooQOrxA== X-Received: by 2002:a1c:6704:: with SMTP id b4mr28166wmc.96.1605548512097; Mon, 16 Nov 2020 09:41:52 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:51 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 22/42] drm/pl111/pl111_display: Make local function static Date: Mon, 16 Nov 2020 17:40:52 +0000 Message-Id: <20201116174112.1833368-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/pl111/pl111_display.c:356:6: warning: no previous prototype for ‘pl111_display_disable’ [-Wmissing-prototypes] Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/pl111/pl111_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c index b3e8697cafcf1..69c02e7c82b7e 100644 --- a/drivers/gpu/drm/pl111/pl111_display.c +++ b/drivers/gpu/drm/pl111/pl111_display.c @@ -353,7 +353,7 @@ static void pl111_display_enable(struct drm_simple_display_pipe *pipe, drm_crtc_vblank_on(crtc); } -void pl111_display_disable(struct drm_simple_display_pipe *pipe) +static void pl111_display_disable(struct drm_simple_display_pipe *pipe) { struct drm_crtc *crtc = &pipe->crtc; struct drm_device *drm = crtc->dev; From patchwork Mon Nov 16 17:40:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5056C2D0A3 for ; Mon, 16 Nov 2020 17:42:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 78DC720B80 for ; Mon, 16 Nov 2020 17:42:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pPumeK8M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 78DC720B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 733726EA04; Mon, 16 Nov 2020 17:42:00 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id DE9826EA08 for ; Mon, 16 Nov 2020 17:41:54 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id k2so19703868wrx.2 for ; Mon, 16 Nov 2020 09:41:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6ly2vy0YXlYaSPJSVrw6dCp9MyYzaUlBE3q9eSYRtTE=; b=pPumeK8MjgTP68BQSG7hK5qh97k6m6M3fw6z+lcvLPzvg8BTWkTZHzzkXpU7QxOXHo BNjpaSAzOgDBRdrPBcrtCR8DySCYkQDX4/MZVG76DaCUlEmmI49870pkv1EZV4xCG+RW xUkjKMIcPpgrpkYhscE9yITsWMpQmuW/CKacZfUBLt/FmxAD6478E6Bi15qz8SGIpYuX /HCT/SjC04O9zWBTy/dqDc5YderwRLjQdaOVsRKO4MH6wC7olydW+2wepE2s4TjzZQU4 2tSuihOsK2IWwV376TXT9CQEMTFzOTWhYx5vOCjVCZcjRFvbRIzFn8H2bFZdysPo46RF prWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6ly2vy0YXlYaSPJSVrw6dCp9MyYzaUlBE3q9eSYRtTE=; b=Fboej9Dxl9Zonmd3BqXB4KvTYdu9JrutIyBhzwZXGxs0lOQmlcQj09hd0uxRtL6LtL VDFd66MU3J6vHIOKxqhDyTMujTpTupfmma/oPVmFTzhMGAxJ+ReUNFKgopmriow2sgpM yYHk+pV3/H3k5F/tU18g5WAJUzhHOI+imId6fTPXrtTrI4PJq7UT6re6QbqOK5kPmeC7 yGkYtTNBOfM834854Eltp78VOPfXAz+gVkZ8IKv7fOTIgsJ7Yj3QBS7mQTApogx465Jm tP5yJRLnx3lDsCZqlJK2Byy/ZGHPOAcySXQH2H6/Fb1uYFtJFk3DHrs9nwwlXbxvabkk Pesw== X-Gm-Message-State: AOAM530JMLTVaN+SpDfOdkENXnkPhZ05p36hznm+zZsOGw7KiJseVUHy mjRDsUv6AvhKUhLb/9tllnns3w== X-Google-Smtp-Source: ABdhPJxfPlHBGHo5OFZg60I7eHKyQ/Wgn1YzLYFclvP3QpESJC/x7/DqF1YwB7WHfVgKpSGF4/ZOmg== X-Received: by 2002:a5d:410c:: with SMTP id l12mr20517364wrp.173.1605548513635; Mon, 16 Nov 2020 09:41:53 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:52 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 23/42] drm/pl111/pl111_debugfs: Make local function 'pl111_debugfs_regs()' static Date: Mon, 16 Nov 2020 17:40:53 +0000 Message-Id: <20201116174112.1833368-24-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/pl111/pl111_debugfs.c:33:5: warning: no previous prototype for ‘pl111_debugfs_regs’ [-Wmissing-prototypes] Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/pl111/pl111_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_debugfs.c b/drivers/gpu/drm/pl111/pl111_debugfs.c index 317f68abf18b0..6744fa16f4644 100644 --- a/drivers/gpu/drm/pl111/pl111_debugfs.c +++ b/drivers/gpu/drm/pl111/pl111_debugfs.c @@ -30,7 +30,7 @@ static const struct { REGDEF(CLCD_PL111_LCUR), }; -int pl111_debugfs_regs(struct seq_file *m, void *unused) +static int pl111_debugfs_regs(struct seq_file *m, void *unused) { struct drm_info_node *node = (struct drm_info_node *)m->private; struct drm_device *dev = node->minor->dev; From patchwork Mon Nov 16 17:40:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910081 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAC05C6369E for ; Mon, 16 Nov 2020 17:42:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9410620B80 for ; Mon, 16 Nov 2020 17:42:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gjEJWyJw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9410620B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E21F6EA08; Mon, 16 Nov 2020 17:42:05 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B30B6EA07 for ; Mon, 16 Nov 2020 17:41:56 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id d12so19622248wrr.13 for ; Mon, 16 Nov 2020 09:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CEyFJOSSbdvLfYxo1nswzgxPyZwwh2XfGKJvNAOyE+k=; b=gjEJWyJwzFrX7dC3f76aducJiYprGZ51SMUFwBK0DQrAv2ywbkD8FzspryEi7eqbmU NXN1+uLfqPrmytc1nA4abMsKa57dKeJvezW7Rwn+7yCHAylw/EoLcg9k6NvPlYerc67F QHekoEKTHsinLMc3sfH0j8TI3MZbJXOfA58QULxB4oq1DmI1kEj8W8/yjoiry5RfRYjb hwxFEINkJg6rRbF27qnkxPUEz2B1K+Gwpmg8fZp/SXQRDZKiHYeHpXXTyxGIKh40CdHu Wp26Nhmd141+vPVeDCootPazEl9rUNZH5qUXvPTcRM89akPJGhDuAYOv8WSU2mHvgXfy 4dkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CEyFJOSSbdvLfYxo1nswzgxPyZwwh2XfGKJvNAOyE+k=; b=RkTESOYsevcvQ5RLc8XqN3CYD50o66h8P2Fe8vTvw8fefWtJKHy+GqlOYypVUegcgI l7+Xh5+hSPi2UuXxd3DZb88NeJ6tjii48OpBfpqscN+y3XfRtMg+Mu8eaNG/a6Z9L9Vc 5qLGZHDNNbGspKD9uaTaOYr62X15Wzd3XqOpfQ+qsXNr3iufGgNUCMtTSTAspMj6GUdw 9YoddAnRx9pbOU/rUlHhV9smAvFGlzByUI2/DgytY3xpPc5VqWT65BC0Lm5/1jyFPRdj RDPmTfSs97i150bQLlqOP6RsRVA+zLx4cvFyol3D9An94z1Z6PLKo/2zWM2wk2WvMsWx gq6Q== X-Gm-Message-State: AOAM533tcUr06ahpcThxtDo93nYNbatlgSQ4Vz2tGwEdqhoEVA2km4qC GX2dw4wWolz+HGe7js/2P/LzUxQRmMZRAjJB X-Google-Smtp-Source: ABdhPJzEz6hKtbXBg6S6mlCSEzioxtEnXfOHuGEg87lALXMzEVHRmwq7gEtk9990PpeLgnNOh0pLRQ== X-Received: by 2002:adf:cf0b:: with SMTP id o11mr20117453wrj.162.1605548514868; Mon, 16 Nov 2020 09:41:54 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:54 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 24/42] drm/rockchip/dw-mipi-dsi-rockchip: Demote non-conformant kernel-doc headers Date: Mon, 16 Nov 2020 17:40:54 +0000 Message-Id: <20201116174112.1833368-25-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, Nickey Yang , Chris Zhong , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:357: warning: Function parameter or member 'dsi' not described in 'ns2bc' drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:357: warning: Function parameter or member 'ns' not described in 'ns2bc' drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:365: warning: Function parameter or member 'dsi' not described in 'ns2ui' drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c:365: warning: Function parameter or member 'ns' not described in 'ns2ui' Cc: Sandy Huang Cc: "Heiko Stübner" Cc: David Airlie Cc: Daniel Vetter Cc: Chris Zhong Cc: Nickey Yang Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c index 542dcf7eddd66..e84325e56d980 100644 --- a/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi-rockchip.c @@ -350,7 +350,7 @@ static void dw_mipi_dsi_phy_write(struct dw_mipi_dsi_rockchip *dsi, dsi_write(dsi, DSI_PHY_TST_CTRL0, PHY_TESTCLK | PHY_UNTESTCLR); } -/** +/* * ns2bc - Nanoseconds to byte clock cycles */ static inline unsigned int ns2bc(struct dw_mipi_dsi_rockchip *dsi, int ns) @@ -358,7 +358,7 @@ static inline unsigned int ns2bc(struct dw_mipi_dsi_rockchip *dsi, int ns) return DIV_ROUND_UP(ns * dsi->lane_mbps / 8, 1000); } -/** +/* * ns2ui - Nanoseconds to UI time periods */ static inline unsigned int ns2ui(struct dw_mipi_dsi_rockchip *dsi, int ns) From patchwork Mon Nov 16 17:40:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2466EC64E90 for ; Mon, 16 Nov 2020 17:42:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF8542242E for ; Mon, 16 Nov 2020 17:42:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="dJjWPHa3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF8542242E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C03976EA0A; Mon, 16 Nov 2020 17:42:05 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 61C856EA01 for ; Mon, 16 Nov 2020 17:41:57 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id b6so19669219wrt.4 for ; Mon, 16 Nov 2020 09:41:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vIBIVuzBlrGyaebIimJgPfSPXPdePz/jLOplaNl77Uc=; b=dJjWPHa3XSW+Ks76T1YqjrP8Dal9w+IUPXB7B0WHSP7xUCjZgNZc1GMjFypJy45vz9 iRTaxjVnCRfTzngcfrS/4Refr2BTlaNkKolSVU5w93MFZHZvZtYlw/GYpoPROQ3wieWI 4/bncU60X4rvtrzb0eVCC5XTG+4wcKsdWumjKq9VnsyeKq+eyPfQ/2JJAQgU/QnLrjlq wm3lnnvmPZHgysqF5d5pd3mSZMy5/H0Fco7jajp+mDVA6a1Y+Uo5R6jJtticd68vu3r0 YwT4a3Qsyysuyt2/3Xd7BVvi/t3DjsfVrjNQSldCF3NNn0JZO36Y8iz6FdKQ+aUEFuMO ektw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vIBIVuzBlrGyaebIimJgPfSPXPdePz/jLOplaNl77Uc=; b=NYY3stmerQIrDpiUym3xQlLkstIMCzyRPmokYMWIXaz2l4z1WZTDBAFhgLtOjdznJp KKqmqiSKkRQ81lSGyGUJtmIYqG/H2akzRqT5eZzOhEBm1EwapKChK+Ye5+8onQWrEQaZ KjiJ148HEKk6UcCt7FUCO/MTDzRmdw5G4RN0r/KmB/QC90udi3d5rj0FpGyu/ZapGsZz biu2IxQbaM9V/KBsDdNnGGpTBkexjjNi/mz7V0DUqqmgYZQmHUHSWlpuDZmd2pq5I9M/ Oij65VfES3dXzqMMKKV/RQkGKo4mzERbiPD3y5KBlOJR1IlVof/ly+f8fpyd9Ukgf8A5 L2kA== X-Gm-Message-State: AOAM5308CwcFF+B4kYcEjNWiGIL1oSECi+aW3faC6KGgDD0XKEPD2+ru GDhEJA7b92xNNj3V7bwzGUXybQ== X-Google-Smtp-Source: ABdhPJxDDINDffKvoqG3eEdIP5lWfvrdKvY5h8rEXr/nMWkPCPHtkoWbEr/dVNpmPZeeG4ec1Xg7cw== X-Received: by 2002:a5d:6783:: with SMTP id v3mr20186302wru.45.1605548516035; Mon, 16 Nov 2020 09:41:56 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:55 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 25/42] drm/rockchip/rockchip_rgb: Consume our own header Date: Mon, 16 Nov 2020 17:40:55 +0000 Message-Id: <20201116174112.1833368-26-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/rockchip/rockchip_rgb.c:71:22: warning: no previous prototype for ‘rockchip_rgb_init’ [-Wmissing-prototypes] drivers/gpu/drm/rockchip/rockchip_rgb.c:159:6: warning: no previous prototype for ‘rockchip_rgb_fini’ [-Wmissing-prototypes] Cc: Sandy Huang Cc: "Heiko Stübner" Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 9a771af5d0c95..c079714477d8a 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -18,6 +18,7 @@ #include "rockchip_drm_drv.h" #include "rockchip_drm_vop.h" +#include "rockchip_rgb.h" #define encoder_to_rgb(c) container_of(c, struct rockchip_rgb, encoder) From patchwork Mon Nov 16 17:40:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910065 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1245AC2D0A3 for ; Mon, 16 Nov 2020 17:42:07 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD53620B80 for ; Mon, 16 Nov 2020 17:42:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UH/wzcYn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD53620B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 105FD6EA06; Mon, 16 Nov 2020 17:42:01 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id C43E86EA00 for ; Mon, 16 Nov 2020 17:41:58 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id d142so40046wmd.4 for ; Mon, 16 Nov 2020 09:41:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+WLjHfl3orvIQYtFk8cWNm313KtEs9zxT+XRuqJ/3Ug=; b=UH/wzcYnQ6WNXlSacFEkhr/x34dgeTAKoOhIqiDcF2gN7ADQZlojGwVxCXvNJzJ42n mEQUdOT9UgO5o4h34H82pfTeRaIrEkywNTJgrSa/CdLTGZu//7j7iPIl+hayhj+5dDKJ O/VU/eKmM/U8XRLw8IM2Nzx1xzDE1NmeG3fuB6IN//4Vf9pEUsJfzqj89AxWNxMMdK4Q JfMfDxyvXpHlaBfEqDFP/hLaWM9pSDU+BzrUELdP8wKXEIwx7ZsCPR6IMvoZL8rmLtjT 68FMnR0IcHE6U8XN/RPfrb3VeIOVUGFC/Al/ooOp2IcPJMYQEL79xQ0mesjsfcUZdRC3 Wxvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+WLjHfl3orvIQYtFk8cWNm313KtEs9zxT+XRuqJ/3Ug=; b=fUjNN73NfwTp7FpFSx8nOFKj0nEIAontIfYXpGe4ioHh2ND4zDyYtzBe8EJxGmX6P6 ru0EWGlgaqNxZQt7wNvzYJv3PQ7aq8+6em7Rfd3T/HDiZe7/d1Gxc4AboxfWeJMS+O3O XIxdNJrfxqTvs3tlV6RjHhYWCJsj0I+ry0xhnMXUoAir9yN36DLz+KJ1OchyTVQQbnMy R5glVW+hUGmWTgJ9v94PkLzcXiE4KzuVaO8r5lSW5voP+x+fMIwMAQnLkknj5/By2i+z zjTeajImq9AHsqxR5xzOirXkzO3obqYbBr/zmROPJlbnlO04QnVCEcHvLDu4IUtbpszQ EJAg== X-Gm-Message-State: AOAM531RM2+gXfh9BavEyp+fFC+9BTVDR4Y0FxF9nHw6aWEA3a1ZacMj qW6a15ry7E0ojN9Savi/F5u+UoP3MbVFVFVu X-Google-Smtp-Source: ABdhPJzJ++oU+QXxqvf2YFvLPeBzaQUSNwRBGkprWJuB8Ho9MuTxldYpIomk2Fd55/9oIMXIYP7drg== X-Received: by 2002:a1c:9ec9:: with SMTP id h192mr49655wme.8.1605548517471; Mon, 16 Nov 2020 09:41:57 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 26/42] drm/rockchip/rockchip_lvds: Fix struct document formatting Date: Mon, 16 Nov 2020 17:40:56 +0000 Message-Id: <20201116174112.1833368-27-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sandy Huang , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Mark Yao Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Must start with "struct " Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/rockchip/rockchip_lvds.c:49: warning: cannot understand function prototype: 'struct rockchip_lvds_soc_data ' Cc: Sandy Huang Cc: "Heiko Stübner" Cc: David Airlie Cc: Daniel Vetter Cc: Mark Yao Cc: dri-devel@lists.freedesktop.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-rockchip@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index f292c6a6e20fb..8658ef82d937b 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -42,7 +42,7 @@ struct rockchip_lvds; container_of(c, struct rockchip_lvds, encoder) /** - * rockchip_lvds_soc_data - rockchip lvds Soc private data + * struct rockchip_lvds_soc_data - rockchip lvds Soc private data * @probe: LVDS platform probe function * @helper_funcs: LVDS connector helper functions */ From patchwork Mon Nov 16 17:40:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEBEBC64E75 for ; Mon, 16 Nov 2020 17:42:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA4D52417E for ; Mon, 16 Nov 2020 17:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jjlCCiNI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA4D52417E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9C36D6EA09; Mon, 16 Nov 2020 17:42:05 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE69D6EA01 for ; Mon, 16 Nov 2020 17:41:59 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id k2so19704384wrx.2 for ; Mon, 16 Nov 2020 09:41:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wbt6Bt9xb+nEOL+sC88FIyMMDCRwxeU6Sb1wX9bISpg=; b=jjlCCiNIxsXpA+Jb25gKyWLrqTzlSWECuVTeXlKwqjUFgAiMxr2Kg1XsOu2FBDybwM wlRkZCxOJb/RWj0i6Uh14Z8mZESJ4jsc5a5m97NFCFK10sB7oe7LWCpmkBLNACoAEDGT XsH/kfY8Xy6dWH0+U1ERkrX4+wT77JWiLWRTDYONESCjRkl7SpP+eTUmq5S69un0s8x8 tZlttEn9Mofc1vKl82qQa3htdJRCyrK6jakgRDCgIgeVn8u/bxzK6iGrPvoyWYFXKCOY U/LNolmUxpjXqFf14X66y15Q1pU0Ul51bCFk/mWMfRsyW4W+haj5BpTbHXJOfr3btsFP p8rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wbt6Bt9xb+nEOL+sC88FIyMMDCRwxeU6Sb1wX9bISpg=; b=pze/6pnAG6pop5kxwc9vfN6Iau1eZ2DuqRWMgHNeKyU1viJewnap7AQNfWpM3/aDaN /0u5s/64B88/RRzJ+qLlzUYNLMHj7Au+4eSeLvu54UoX8L8f63HA/O6qbEFz1SOBKB4z xHz6HCvXMJwVdvtxq/6AZC5lDGyyxQEMIaZwqwusGnt1A5lWnMzl5iW+cFZi7pGh+2q3 jHs5sKzAuuPjg4Rg8wl0CEdccuVrjrpIa+NnI60kswgNFZ/ahEE5DMiiKoKTOC73EmVj kPmV6+gql6N2chJuZrdUbZ641ilNzSosb5cCzZpsZVVTmx9efQ0lHaPmD91j1gxE3U1B QO6g== X-Gm-Message-State: AOAM531HeiFQmOqP+tK0nLYB7SeRT6SxQz8UhASHPlfgSZ1C1zKtVMnm Z2KjcjFwH/mROPdRW1yi671NhQ== X-Google-Smtp-Source: ABdhPJxixVTfoinJ+pbMo9gBUuK0pz4maqlEmMuGBMn7mSWL5CMNmdd/xIpmu0aAD8lk+4XYjkVVsw== X-Received: by 2002:adf:8521:: with SMTP id 30mr20985238wrh.265.1605548518655; Mon, 16 Nov 2020 09:41:58 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 27/42] drm/selftests/test-drm_mm: Mark 'hole_end' as always_unused Date: Mon, 16 Nov 2020 17:40:57 +0000 Message-Id: <20201116174112.1833368-28-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , Nirmoy Das Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In the macro drm_mm_for_each_hole() 'hole_end' is provided as a container for 'hole_start + pos->hole_size', but is not utilised in this use-case. We cannot simply delete the variable, so here we tell the compiler that we're intentionally discarding the read value. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_mm.c: In function ‘assert_no_holes’: drivers/gpu/drm/selftests/test-drm_mm.c:57:18: warning: variable ‘hole_end’ set but not used [-Wunused-but-set-variable] Cc: David Airlie Cc: Daniel Vetter Cc: "Christian König" Cc: Nirmoy Das Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/selftests/test-drm_mm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c b/drivers/gpu/drm/selftests/test-drm_mm.c index 95e212a9a74d2..b768b53c4aee3 100644 --- a/drivers/gpu/drm/selftests/test-drm_mm.c +++ b/drivers/gpu/drm/selftests/test-drm_mm.c @@ -54,7 +54,7 @@ static int igt_sanitycheck(void *ignored) static bool assert_no_holes(const struct drm_mm *mm) { struct drm_mm_node *hole; - u64 hole_start, hole_end; + u64 hole_start, __always_unused hole_end; unsigned long count; count = 0; From patchwork Mon Nov 16 17:40:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910079 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AECC3C6379F for ; Mon, 16 Nov 2020 17:42:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6348F22265 for ; Mon, 16 Nov 2020 17:42:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QlKnEKn0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6348F22265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F7A66EA10; Mon, 16 Nov 2020 17:42:09 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 727B06EA08 for ; Mon, 16 Nov 2020 17:42:01 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id j7so19658246wrp.3 for ; Mon, 16 Nov 2020 09:42:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CpDMS+RHHV1rRQnMHYAjcZzCg3wY/F0STHOFtNum/rU=; b=QlKnEKn0xfMVNLUegEwHbQJPic1l06CYGWhnCfguIw3hOMik3KVBqH/YP2yC43asib f2UuSmKRJY3ecRRD++REiBaL5pWLlMxhw1cFZQCjed41kvQSU0SGSZtp9IwUC7oTxOY+ IpjXbOfgYmytr6s4LWK+mUcADEQ3vuWFSK+Snb0r0qofwWKJlfopeqr6X/efE/o9nVwJ 4SrgKh1saEWCXQLFmnbhf6Vie+X3ikuQBxtqtUHAqCklAxucNV3+wM8pAVjlhsr+aK/V ReN+ZybmaVikrjvBfRAKqXEBrF+Xi2uq1UDMrge12cB/vdXOFlCOoJIJ4k3963py/kLv o6RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CpDMS+RHHV1rRQnMHYAjcZzCg3wY/F0STHOFtNum/rU=; b=pik1M4DUbadFzDfkTk2Dqmz5CZKwOM4whbIoZHOBlcsJoE2oJitFcboCrDHShQ+jRG jf3dPcVXYVImgC3RKFZS2KfzarR0CzYp7TEJ1C7F3biXRSblY1zbq0/WWiHHmtDwSxeL w2vzs16uN+gnfEONnyMpEBG13Naf92zvzQn30hseZ5Qoldu2XwJgi/puUjIKX/DvbWsU TSMsgkibHuvnk97c4vXaqL49+1AKzHFZ8P1+BgW8SiF9b+mOVmM/ilB7cXvhMr+QXXla M7PWPGhbPQ+KOKzkVz4YHPElHgXDqXTnggd2zW/VDPsNeJWxoXPEMdoRgy2NsQ+3+seD QwNg== X-Gm-Message-State: AOAM531recK9OKJginzwbNagmf51NdKFGzw2Y2rue27ESe53FxhKl34A baFbB3PC62Rq62MjW3VnF+FntgACHKzSRPGO X-Google-Smtp-Source: ABdhPJyX0D9RJLsPH5aoo8t225qk75KVbJPi+9yZsHZ7TD39meFO6erQN2FqkzZVH2u+74DxgOk0TQ== X-Received: by 2002:adf:c803:: with SMTP id d3mr20484445wrh.108.1605548520115; Mon, 16 Nov 2020 09:42:00 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.41.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:41:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 28/42] drm/selftests/test-drm_framebuffer: Remove set but unused variable 'fb' Date: Mon, 16 Nov 2020 17:40:58 +0000 Message-Id: <20201116174112.1833368-29-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_framebuffer.c: In function ‘execute_drm_mode_fb_cmd2’: drivers/gpu/drm/selftests/test-drm_framebuffer.c:333:26: warning: variable ‘fb’ set but not used [-Wunused-but-set-variable] Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/selftests/test-drm_framebuffer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/selftests/test-drm_framebuffer.c b/drivers/gpu/drm/selftests/test-drm_framebuffer.c index 2d29ea6f92e2a..789f22773dbc9 100644 --- a/drivers/gpu/drm/selftests/test-drm_framebuffer.c +++ b/drivers/gpu/drm/selftests/test-drm_framebuffer.c @@ -330,10 +330,9 @@ static struct drm_device mock_drm_device = { static int execute_drm_mode_fb_cmd2(struct drm_mode_fb_cmd2 *r) { int buffer_created = 0; - struct drm_framebuffer *fb; mock_drm_device.dev_private = &buffer_created; - fb = drm_internal_framebuffer_create(&mock_drm_device, r, NULL); + drm_internal_framebuffer_create(&mock_drm_device, r, NULL); return buffer_created; } From patchwork Mon Nov 16 17:40:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910071 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46649C63697 for ; Mon, 16 Nov 2020 17:42:14 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0491520B80 for ; Mon, 16 Nov 2020 17:42:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sU22MNf4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0491520B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F8D789FED; Mon, 16 Nov 2020 17:42:05 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F0FD6EA08 for ; Mon, 16 Nov 2020 17:42:03 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id b6so19669707wrt.4 for ; Mon, 16 Nov 2020 09:42:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TjcKYWuzDhqklR5qoTIUsTytnZe/lM+b0Bx4U4tTS3A=; b=sU22MNf45vVUHSsYOdy9fl9yIGywaq3clCbLYSUdwuJl0SOFI02Lsd0y793lP8J6Rk rPkBRR7UXN6FZZWxOCbado478weeCmgsuYDA2GENsiflFpTuvK+0sE2pkFQD1xqN3M63 zW6V3eyDvMX99Ec4jMu4ywyLi57RfvGLgaUwkywJ7QNJ040N40KGfN+YHqdl9CMF/z9x We/t8grpmbCU5c3UVZ1bHCbKDcJY4xcWcvl/OFHGBz9SwOE6y5t7HZyfNxZepyLrNsfx TrcS04JbRFhulNsEItHdk1Pgvb5ivEtH1MUNujY9SVgqgD+oiBNJUW4W5BuZSJ0cWA+t 1mgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TjcKYWuzDhqklR5qoTIUsTytnZe/lM+b0Bx4U4tTS3A=; b=HpGckdyFWB4hpiAMC+HSCFXKG0IU2xNoeUQHhhcYzSir0TtzFoMerIdLSJDRnxVbLL Wm6Kz8Hk1VhcKDWZGMrbU4IzUflPdsLUa/+xCumW9V3MT6CO83clB6HDM9llfhHOIxMd Nd8kDE1jKSnhE0eQcrbO/jQ5nf2a71ypqr8kMwbD5vJVSK8DTveZA2Q5oXsIRmzfpJI3 a9fH64MpwAz6hRvB3DUpkrZvWMDYSd9QnckMipLFuXqEXVKc08JN7r115xQP/IVNamTo i4BBFoIgmE5C/t2wyJ0PN23O44n/7aNYBomIj/dKeiNTYKGL8iRiLOUBUB/5ZFZgfzH9 6eLg== X-Gm-Message-State: AOAM533Ypf6U10HGMHzAqGIWp7xcrSi1snEbO3ul0JprQ2ycOrrRCN84 D0saDAIXL/P7rIFCLGOB6sgTezs4Z5l66AeW X-Google-Smtp-Source: ABdhPJy1yyaqbtAV862cd0RoEAr1Ke/mk6oE5G4P2h3GHj95qMG7W+9SB8wzWyLsernWsiTuWwQE8A== X-Received: by 2002:adf:db4a:: with SMTP id f10mr20402689wrj.420.1605548521624; Mon, 16 Nov 2020 09:42:01 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 29/42] drm/selftests/test-drm_dp_mst_helper: Place 'struct drm_dp_sideband_msg_req_body' onto the heap Date: Mon, 16 Nov 2020 17:40:59 +0000 Message-Id: <20201116174112.1833368-30-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , David Francis , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The stack is too full. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:161:1: warning: the frame size of 1176 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: David Airlie Cc: Daniel Vetter Cc: Lyude Paul Cc: David Francis Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Lyude Paul --- .../drm/selftests/test-drm_dp_mst_helper.c | 31 ++++++++++++------- 1 file changed, 20 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c index 1d696ec001cff..e00bdc557f880 100644 --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c @@ -120,44 +120,53 @@ sideband_msg_req_equal(const struct drm_dp_sideband_msg_req_body *in, static bool sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) { - struct drm_dp_sideband_msg_req_body out = {0}; + struct drm_dp_sideband_msg_req_body *out; struct drm_printer p = drm_err_printer(PREFIX_STR); struct drm_dp_sideband_msg_tx txmsg; int i, ret; + bool result = true; + + out = kzalloc(sizeof(*out), GFP_KERNEL); + if (!out) + return false; drm_dp_encode_sideband_req(in, &txmsg); - ret = drm_dp_decode_sideband_req(&txmsg, &out); + ret = drm_dp_decode_sideband_req(&txmsg, out); if (ret < 0) { drm_printf(&p, "Failed to decode sideband request: %d\n", ret); - return false; + result = false; + goto out; } - if (!sideband_msg_req_equal(in, &out)) { + if (!sideband_msg_req_equal(in, out)) { drm_printf(&p, "Encode/decode failed, expected:\n"); drm_dp_dump_sideband_msg_req_body(in, 1, &p); drm_printf(&p, "Got:\n"); - drm_dp_dump_sideband_msg_req_body(&out, 1, &p); - return false; + drm_dp_dump_sideband_msg_req_body(out, 1, &p); + result = false; + goto out; } switch (in->req_type) { case DP_REMOTE_DPCD_WRITE: - kfree(out.u.dpcd_write.bytes); + kfree(out->u.dpcd_write.bytes); break; case DP_REMOTE_I2C_READ: - for (i = 0; i < out.u.i2c_read.num_transactions; i++) - kfree(out.u.i2c_read.transactions[i].bytes); + for (i = 0; i < out->u.i2c_read.num_transactions; i++) + kfree(out->u.i2c_read.transactions[i].bytes); break; case DP_REMOTE_I2C_WRITE: - kfree(out.u.i2c_write.bytes); + kfree(out->u.i2c_write.bytes); break; } /* Clear everything but the req_type for the input */ memset(&in->u, 0, sizeof(in->u)); - return true; +out: + kfree(out); + return result; } int igt_dp_mst_sideband_msg_req_decode(void *unused) From patchwork Mon Nov 16 17:41:00 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910073 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422DBC61DD8 for ; Mon, 16 Nov 2020 17:42:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0AFE22370 for ; Mon, 16 Nov 2020 17:42:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qQWadntt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F0AFE22370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 179856EA0B; Mon, 16 Nov 2020 17:42:06 +0000 (UTC) Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id 282436EA0E for ; Mon, 16 Nov 2020 17:42:04 +0000 (UTC) Received: by mail-wr1-x442.google.com with SMTP id o15so19661008wru.6 for ; Mon, 16 Nov 2020 09:42:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SmOPpMPfhIiNWLmfD425Vh4v6mCQcNCmoMGuMYmd5/A=; b=qQWadntt/mFLB2dHX6lrFTrO+5jYltfzBzIRsvL1z5Z6vtAiX/okLVJtYTfU6M+6ZS XzZpueyoOCEm+ppetpCQb/hIf7iXx7l2KUxEI7bn55gdSyyYDPd9gZdfOyOvNWfft1SM w+iuynB+rS795d3bkOrNtC1Xrylj2zsp80gJYvH7zZSfL6Hahtp7qBLDtGOGBcpQcEFP DJViqYgYnecWKSHdDGPxR8ed0QSh4us9Z22xp+J6fICeTcd+6MkNOp86MqffqD6smjYX 23yKflHz+b2Wn4pZ9o8v5+IFG9YZ/IJ13tKgb+qBOEJgoE4oB3VoDH9y+d0FXXQ2jRgs kSzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SmOPpMPfhIiNWLmfD425Vh4v6mCQcNCmoMGuMYmd5/A=; b=FRbgo7jH1ZQNDhBLHBABc1l51Oq+TZXY9D4TpP/qiRmBL05zBCtgB5lIgROx6h+CE5 NfyFZ9NxlSv1iHsP9jT5Lhw+yj5IMbRuv0mpl/rtknbNFFPKB04dCDidqRXYoQRdkMww XYP665E9rJ8c8VFkcewuzMuMRvGZWfYrBjGXK9l7IUStlSMxxyQvHnl36AwWp48L8wn8 CkZfn2sQNl4Q+9w4Xqd7U2ApFpIFt1qYn25UBZ0bdsuQW/RLcxvQm9G/EB8IV+8OZV3w wvJNSGfQdktO0VyX3BOsGfLeuvU8I5R0U3jVBAKQ+vym626EkeMFUp8RVmS6y8i/875G fcrA== X-Gm-Message-State: AOAM533sn4JeSreSQrqxrW0AC5cZ/E4m4j6jGq7DThf8vi7rFkMg3+qt 0XFJf/hnm/8BPLYNDzB/tZyzEcuPt42LLkcp X-Google-Smtp-Source: ABdhPJwE+AiRHnGNLBkmlszJMRYyDRr3EsBayn0O2BqS6CGMXtLN5yEZ0ylGG7y5khqkG3OToESChw== X-Received: by 2002:a5d:510a:: with SMTP id s10mr20125292wrt.402.1605548522848; Mon, 16 Nov 2020 09:42:02 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 30/42] drm/selftests/test-drm_dp_mst_helper: Move 'sideband_msg_req_encode_decode' onto the heap Date: Mon, 16 Nov 2020 17:41:00 +0000 Message-Id: <20201116174112.1833368-31-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" There is too much data being stored on the stack. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c: In function ‘sideband_msg_req_encode_decode’: drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c:168:1: warning: the frame size of 1072 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c index e00bdc557f880..6b4759ed6bfd4 100644 --- a/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c +++ b/drivers/gpu/drm/selftests/test-drm_dp_mst_helper.c @@ -122,7 +122,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) { struct drm_dp_sideband_msg_req_body *out; struct drm_printer p = drm_err_printer(PREFIX_STR); - struct drm_dp_sideband_msg_tx txmsg; + struct drm_dp_sideband_msg_tx *txmsg; int i, ret; bool result = true; @@ -130,8 +130,12 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) if (!out) return false; - drm_dp_encode_sideband_req(in, &txmsg); - ret = drm_dp_decode_sideband_req(&txmsg, out); + txmsg = kzalloc(sizeof(*txmsg), GFP_KERNEL); + if (!txmsg) + return false; + + drm_dp_encode_sideband_req(in, txmsg); + ret = drm_dp_decode_sideband_req(txmsg, out); if (ret < 0) { drm_printf(&p, "Failed to decode sideband request: %d\n", ret); @@ -166,6 +170,7 @@ sideband_msg_req_encode_decode(struct drm_dp_sideband_msg_req_body *in) out: kfree(out); + kfree(txmsg); return result; } From patchwork Mon Nov 16 17:41:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910107 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85559C61DD8 for ; Mon, 16 Nov 2020 17:42:45 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26C37223C7 for ; Mon, 16 Nov 2020 17:42:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="cqmrXntl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26C37223C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C7C996EA13; Mon, 16 Nov 2020 17:42:39 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9656F6EA00 for ; Mon, 16 Nov 2020 17:42:05 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id u12so12445013wrt.0 for ; Mon, 16 Nov 2020 09:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=B656eLYjE1FZlTbAcLYHtkBSzMjn1Kq22EcK7SpZuzI=; b=cqmrXntlw3DQnt5lF1CYf3WMXHIXS25fxnTj07nOs1OnCw5c1rVANuO5n2oIQyYQHT 4Kt98XLHFVjJBheC9Pq5A3zK2E3iwNZTZW8CdMKt9h6k280mVzldBX0aBJU82KOHJNZC K4troDtjJnBrA+vQSFbOol2J/naEt2ssUlg13Qi7VjG/pkYNnTOzYXXp7Lm8orIEbBCi jUKtESeFbIhzclHqmUqIvYiMsRq5s0pj4xPEIgzIY+rs4PEQcxcSV2MODdody8XeS5vb cSeQFWCIMzTqv0c9fI8pl12oKO06x1Cyskqe0LzQ2u+ZBjSrbR5ps1YitxXAG/GrnkoQ 4p9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=B656eLYjE1FZlTbAcLYHtkBSzMjn1Kq22EcK7SpZuzI=; b=jEc+CM45M0KgYGZstg3dZ5R6nlEDHoI2TOUzGvzxRs321v5nC1FxhsLbKe7oDtpiRj h+j0f7FbrG56sTlMYbvRG99k1YHPwFbp8zlUpUAd7qN/weuoVdW9JVCoyhli0Qwtv6we nwZ0WIjjiVUXPAa8APp7Jk0TvdZkJNOc437eUZ4BN7w4B/P5YxhcrEO74bpHau24Vkbg zvTlZGxg4n4C0OgkmhBawKwfJA6aMI6rkdw56GyE7WWTKLu2yxX9UmyKmiPcmVVPXXVH TRWqZfxyKGlkFfhm+UTNizUwX0HHYf9TztgqLudEFJtMzPYNPh5fLWiy9I4/GpZGCPHb SDHg== X-Gm-Message-State: AOAM530BcyAe9h01LfqMz5CKipZvu3eKkF5TtkDHQP6yF5C6LQRnyd1d tbcORVHjoGpPrfgVCJXcUSPt9A== X-Google-Smtp-Source: ABdhPJwRo58jenu80k77aCwl2EeoUJqluDWvFSt2FOgVWWwXQC9e4UWksYqVOBVC3xnFTVOmp3u+zA== X-Received: by 2002:adf:e6c8:: with SMTP id y8mr20291446wrm.414.1605548524179; Mon, 16 Nov 2020 09:42:04 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:03 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 31/42] drm/ttm/ttm_bo: Fix one function header - demote lots of kernel-doc abuses Date: Mon, 16 Nov 2020 17:41:01 +0000 Message-Id: <20201116174112.1833368-32-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Christian Koenig , linaro-mm-sig@lists.linaro.org, Huang Rui , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_bo.c:51: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' drivers/gpu/drm/ttm/ttm_bo.c:286: warning: Function parameter or member 'bo' not described in 'ttm_bo_cleanup_memtype_use' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'bo' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'interruptible' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'no_wait_gpu' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'unlock_resv' not described in 'ttm_bo_cleanup_refs' drivers/gpu/drm/ttm/ttm_bo.c:424: warning: Function parameter or member 'bdev' not described in 'ttm_bo_delayed_delete' drivers/gpu/drm/ttm/ttm_bo.c:424: warning: Function parameter or member 'remove_all' not described in 'ttm_bo_delayed_delete' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'bo' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'ctx' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'locked' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'busy' not described in 'ttm_bo_evict_swapout_allowable' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'bo' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'man' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'mem' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'no_wait_gpu' not described in 'ttm_bo_add_move_fence' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'bo' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'place' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'mem' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'ctx' not described in 'ttm_bo_mem_force_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'bo' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'placement' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'mem' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'ctx' not described in 'ttm_bo_mem_space' drivers/gpu/drm/ttm/ttm_bo.c:1387: warning: Function parameter or member 'ctx' not described in 'ttm_bo_swapout' Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index e6bcbfe530ecc..9a03c7834b1ed 100644 --- a/drivers/gpu/drm/ttm/ttm_bo.c +++ b/drivers/gpu/drm/ttm/ttm_bo.c @@ -45,7 +45,7 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj); -/** +/* * ttm_global_mutex - protecting the global BO state */ DEFINE_MUTEX(ttm_global_mutex); @@ -278,7 +278,7 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, return ret; } -/** +/* * Call bo::reserved. * Will release GPU memory type usage on destruction. * This is the place to put in driver specific hooks to release @@ -352,9 +352,10 @@ static void ttm_bo_flush_all_fences(struct ttm_buffer_object *bo) * Must be called with lru_lock and reservation held, this function * will drop the lru lock and optionally the reservation lock before returning. * - * @interruptible Any sleeps should occur interruptibly. - * @no_wait_gpu Never wait for gpu. Return -EBUSY instead. - * @unlock_resv Unlock the reservation lock as well. + * @bo: The buffer object to clean-up + * @interruptible: Any sleeps should occur interruptibly. + * @no_wait_gpu: Never wait for gpu. Return -EBUSY instead. + * @unlock_resv: Unlock the reservation lock as well. */ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, @@ -420,7 +421,7 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, return 0; } -/** +/* * Traverse the delayed list, and call ttm_bo_cleanup_refs on all * encountered buffers. */ @@ -628,7 +629,7 @@ bool ttm_bo_eviction_valuable(struct ttm_buffer_object *bo, } EXPORT_SYMBOL(ttm_bo_eviction_valuable); -/** +/* * Check the target bo is allowable to be evicted or swapout, including cases: * * a. if share same reservation object with ctx->resv, have assumption @@ -767,7 +768,7 @@ int ttm_mem_evict_first(struct ttm_bo_device *bdev, return ret; } -/** +/* * Add the last move fence to the BO and reserve a new shared slot. */ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, @@ -803,7 +804,7 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, return 0; } -/** +/* * Repeatedly evict memory from the LRU for @mem_type until we create enough * space, or we've evicted everything and there isn't enough space. */ @@ -865,7 +866,7 @@ static int ttm_bo_mem_placement(struct ttm_buffer_object *bo, return 0; } -/** +/* * Creates space for memory region @mem according to its type. * * This function first searches for free space in compatible memory types in @@ -1430,7 +1431,7 @@ int ttm_bo_wait(struct ttm_buffer_object *bo, } EXPORT_SYMBOL(ttm_bo_wait); -/** +/* * A buffer object shrink method that tries to swap out the first * buffer object on the bo_global::swap_lru list. */ From patchwork Mon Nov 16 17:41:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910093 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416BBC63697 for ; Mon, 16 Nov 2020 17:42:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFE3822409 for ; Mon, 16 Nov 2020 17:42:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QGRS8dZa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFE3822409 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A75B66EA0E; Mon, 16 Nov 2020 17:42:11 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEF3C6EA0D for ; Mon, 16 Nov 2020 17:42:06 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id w24so57299wmi.0 for ; Mon, 16 Nov 2020 09:42:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=w5fAxh5tnngNJF2VB/FxBFEjPf9+WnphDOVk5YyhPg4=; b=QGRS8dZaH4fBWVeFr/tutZKDHKcWCbSLtvBJ+9LmydZVFOhD7SoaCJwz/AwgWnKNOI BtJRrGzbvgoEtzBAzr3h9RoBz0y8vIror5Qqj3f9+6BQuwYmegEcAX8emgB+5Da1twow ct2u0AdI9tex8VkIHsjHo/NAuIACwN9gMqK2km3XnTjhr7hGq66KQwWMIW0WChyVgaIV tISXrg5wv0aiYg/ONBv0OQwOix0LQfwBpS8KIBBd03tzn/zC4qOzJwuzTGus7dXT4eL1 nDYHFF1S8jXG02wW0XX9sfC4vRpPRo13z4F/rQ4322u/7rMXIsZmJwxfd6dAXKDoBLeD 4Kxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=w5fAxh5tnngNJF2VB/FxBFEjPf9+WnphDOVk5YyhPg4=; b=shCTUzg2MmKcgpCQ0L2YYfYQ91uXmfEyfr9vHC4QXX4KASxYI0tdDGGCf+OE3VCTbK y+QNLYWdn/0nZzkPHby2+I6CPCUlWFSNxb8klmkdL1GzvQyWWms5JYDaZLUWtZdAI8AX ugMMnJxVnDHRpfBlrUirOsWbvnt95hn8LBHF7u+ZJrNsMVbeNjsa5r75e+5D/GEoSWXR jN95Z3Rd41hRoQwN12miDDRchH9DFKaGRWK13YfvMHWlXcozl2nBtnz1+Xqiw5GCpL1k BFgMkgZAo+ee/mFp52Ui9rm1oYgwuFIVQmDJqroXxJGfPARXhJx0eEqgApCruYird5HY Kziw== X-Gm-Message-State: AOAM532JGZk9ovIsjxiK6jAt1Mh20/D9FDGk5wpe82qwOGwq84I+yVeL 5C8zSFMS+tCLvSupTY0L1ZlflQ== X-Google-Smtp-Source: ABdhPJyX+vq2jy2gK34lUOqKpajZ7ybNU67R2lMx+cLVP+zfYtJjk9BfCDO9pecgpeu16QDZ3Qry7g== X-Received: by 2002:a1c:dc43:: with SMTP id t64mr16301052wmg.93.1605548525472; Mon, 16 Nov 2020 09:42:05 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 32/42] drm/ttm/ttm_tt: Demote kernel-doc header format abuses Date: Mon, 16 Nov 2020 17:41:02 +0000 Message-Id: <20201116174112.1833368-33-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Huang Rui , Christian Koenig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'bo' not described in 'ttm_tt_create' drivers/gpu/drm/ttm/ttm_tt.c:45: warning: Function parameter or member 'zero_alloc' not described in 'ttm_tt_create' drivers/gpu/drm/ttm/ttm_tt.c:83: warning: Function parameter or member 'ttm' not described in 'ttm_tt_alloc_page_directory' Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/ttm/ttm_tt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c index cfd633c7e7643..da9eeffe0c6d7 100644 --- a/drivers/gpu/drm/ttm/ttm_tt.c +++ b/drivers/gpu/drm/ttm/ttm_tt.c @@ -38,7 +38,7 @@ #include #include -/** +/* * Allocates a ttm structure for the given BO. */ int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc) @@ -73,7 +73,7 @@ int ttm_tt_create(struct ttm_buffer_object *bo, bool zero_alloc) return 0; } -/** +/* * Allocates storage for pointers to the pages that back the ttm. */ static int ttm_tt_alloc_page_directory(struct ttm_tt *ttm) From patchwork Mon Nov 16 17:41:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2DA1C64E69 for ; Mon, 16 Nov 2020 17:42:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6CCE1238E6 for ; Mon, 16 Nov 2020 17:42:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pRWYp0XT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6CCE1238E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E134D6EA12; Mon, 16 Nov 2020 17:42:11 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E2C66EA0F for ; Mon, 16 Nov 2020 17:42:08 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id k2so19705160wrx.2 for ; Mon, 16 Nov 2020 09:42:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xPa36hbXRaCWHNKBNpsuuGTQcILERbE7+3Txd9Olckk=; b=pRWYp0XTrVtt3Xvh9YDV5tP6dikwZIDkT90eW9C2OdRoYyd2HswTEVenhb4ycBTOiv m0PyBnWv7J8AixspV9covb8JFHnTe8YM2jN84skal5ondJKls6A9lksIy6pD9EwgxGhu rZGOvxBj8p/+8YLdDB/E8ijfhC08TPNqfGpoofRbq3gc+zDXXnJaMWSM7DkwmQ8MPgv+ TqFQ4HaN6/KAC4JiaFVOqnS2icRTYJIr0TJbh3U3s7h2r0dLE4IVIFrX0EVgBgEIAaRV AN5bru5QhzF8jQZ2zWe5YmVhQMZlVkG5l/V9ybXf+8ELVTcEHTtIcpONXI3T+dCsPR4K yNvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xPa36hbXRaCWHNKBNpsuuGTQcILERbE7+3Txd9Olckk=; b=DWPLU3iFw/HJt7BKLg7kCtAHtI+Upm3Ir2eyo9qUerijkG+8sJKb9pCYhFieIvWwh5 lqswGtOc9LCyuOUUYMXLjWrEcc21J7ENRFq1hygHEgxEwxXrgXIFfYMZQG3/R68sArJ2 LcoVv9xEN6G5Y7ggdatqMGnvJXXQsZD+itzkZP6IHZJhMNZfA3DrJuiqGggbvE181jwi Joxd8AhGJCwUnlnDmDb8EHMhE1MFKZaF8PzlusBoT/+9sUdFF9Hypkzed7c80P4UNmQL BSrFizD602d/AKBkcTVQwbKE9O+QBRCML54/URtF2oIvACkjIdU1PKNsGcm00aTH/cXp 8XxQ== X-Gm-Message-State: AOAM531WAzYCRAaYD6CFiDCcDNcARwYK+5TRH7QsbF6FJDCKs+nXIkY4 zFaWJFzzUz7HNKLvPcXkv9cKOg== X-Google-Smtp-Source: ABdhPJwhedprnVRT8XYKz4ZODyRIwOSlsB9QfSG2MGDe7+rjWfM0Dx7z9ufFAbkbiueG2aby7uBBaA== X-Received: by 2002:adf:8030:: with SMTP id 45mr20573626wrk.407.1605548526801; Mon, 16 Nov 2020 09:42:06 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 33/42] drm/ttm/ttm_range_manager: Demote non-conformant kernel-doc header Date: Mon, 16 Nov 2020 17:41:03 +0000 Message-Id: <20201116174112.1833368-34-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Huang Rui , Christian Koenig Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/ttm/ttm_range_manager.c:46: warning: cannot understand function prototype: 'struct ttm_range_manager ' Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones Reviewed-by: Christian König --- drivers/gpu/drm/ttm/ttm_range_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_range_manager.c b/drivers/gpu/drm/ttm/ttm_range_manager.c index ea77919569a2e..e0952444cea93 100644 --- a/drivers/gpu/drm/ttm/ttm_range_manager.c +++ b/drivers/gpu/drm/ttm/ttm_range_manager.c @@ -37,7 +37,7 @@ #include #include -/** +/* * Currently we use a spinlock for the lock, but a mutex *may* be * more appropriate to reduce scheduling latency if the range manager * ends up with very fragmented allocation patterns. From patchwork Mon Nov 16 17:41:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910087 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57842C61DD8 for ; Mon, 16 Nov 2020 17:42:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0BC58223C7 for ; Mon, 16 Nov 2020 17:42:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KYfB0p1J" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0BC58223C7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 669856EA0C; Mon, 16 Nov 2020 17:42:11 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 991896EA03 for ; Mon, 16 Nov 2020 17:42:09 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id 19so58312wmf.1 for ; Mon, 16 Nov 2020 09:42:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CdkaNwQj8NyYLTZAwxAzCnUjBubyLoQ1IDILNJ47mBc=; b=KYfB0p1J8ty+Ajm53YV2GUUYUG37fGMs+sTFghOyy81qeMcYCCBI0/1BHv2PUUIjDE YJYsC/JCj7JtTZj3LyeZyJ1ma6n7LJCEiHH/ECiJExw5fRbRQdumA6Nqr77uK6bjFOuI BdrOz9vOe7aKsV8/DI8+LaFvwRQe2SdAvBaMINlVnHFLwMn2zrcuItOO7epWpzEzcjjy LL8GNS3NJxYFhMeaQpdHZhvjk7TSm74KER7gMmo4vmP71LM3IdxdizLCIdPV2MH7hQ17 JfRc3KXZvX7Yqz6mbHZE9RjWwh5uzsQrwJoHLX7oWExRQ5v6vbpRbZzjuFUDhyOTxtV2 42Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CdkaNwQj8NyYLTZAwxAzCnUjBubyLoQ1IDILNJ47mBc=; b=BijZSMvPxntCmdJgRABAE7I7kpOj6sIQ2l9FIN0bZvbt97xUt448GbfnvO3iA2gbTz odX39OfinhswnHoypopnCt5GMl03PYKRCbejMoRjm2lPwjIIG9Q7x1c7Px7a4OaOX/T5 fzKC0DwYSW5lU1S7ON9m+qseLMjwubEV/MDJTAc/bfdA2qN75/nwS8oVBTilAzr77+1n +qM+bcso3KE+gHLjS8vXbY6aZ2k2aXERUJnpM3LvTC/C+zrmiElD5ky24o8JA1x0TJ+x DOsPzJ0UO55s9Vv/wEHHLZ2Bw0iHm9EBNy7jHGd8DbtyYP+8IlxseJhzSh3t+9twnN9c FDbw== X-Gm-Message-State: AOAM531lAKsJSIaKzfbm/iobPyYgO2/Y44ArlEMtzjvIEpNM834FEsHy qceT3/RbN9SnpRUv5JOfw3SS3A== X-Google-Smtp-Source: ABdhPJy4j2soVkwNqRi5Mut8ukSXC78cgBDynmPGR3xvRkypNFcub1qJ/G6B6xgySH2RieWkvkMAcA== X-Received: by 2002:a7b:c145:: with SMTP id z5mr17523wmi.164.1605548528328; Mon, 16 Nov 2020 09:42:08 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:07 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 34/42] drm/v3d/v3d_drv: Remove unused static variable 'v3d_v3d_pm_ops' Date: Mon, 16 Nov 2020 17:41:04 +0000 Message-Id: <20201116174112.1833368-35-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/v3d/v3d_drv.c:73:32: warning: ‘v3d_v3d_pm_ops’ defined but not used [-Wunused-const-variable=] Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter Cc: Philipp Zabel Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/v3d/v3d_drv.c | 36 ----------------------------------- 1 file changed, 36 deletions(-) diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c index 2da0c1180bc69..42d401fd244e3 100644 --- a/drivers/gpu/drm/v3d/v3d_drv.c +++ b/drivers/gpu/drm/v3d/v3d_drv.c @@ -38,42 +38,6 @@ #define DRIVER_MINOR 0 #define DRIVER_PATCHLEVEL 0 -#ifdef CONFIG_PM -static int v3d_runtime_suspend(struct device *dev) -{ - struct drm_device *drm = dev_get_drvdata(dev); - struct v3d_dev *v3d = to_v3d_dev(drm); - - v3d_irq_disable(v3d); - - clk_disable_unprepare(v3d->clk); - - return 0; -} - -static int v3d_runtime_resume(struct device *dev) -{ - struct drm_device *drm = dev_get_drvdata(dev); - struct v3d_dev *v3d = to_v3d_dev(drm); - int ret; - - ret = clk_prepare_enable(v3d->clk); - if (ret != 0) - return ret; - - /* XXX: VPM base */ - - v3d_mmu_set_page_table(v3d); - v3d_irq_enable(v3d); - - return 0; -} -#endif - -static const struct dev_pm_ops v3d_v3d_pm_ops = { - SET_RUNTIME_PM_OPS(v3d_runtime_suspend, v3d_runtime_resume, NULL) -}; - static int v3d_get_param_ioctl(struct drm_device *dev, void *data, struct drm_file *file_priv) { From patchwork Mon Nov 16 17:41:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910101 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 296BAC61DD8 for ; Mon, 16 Nov 2020 17:42:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE20220B80 for ; Mon, 16 Nov 2020 17:42:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AZkL0vTT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE20220B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 684E56E9F7; Mon, 16 Nov 2020 17:42:38 +0000 (UTC) Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by gabe.freedesktop.org (Postfix) with ESMTPS id 46C0D6EA03 for ; Mon, 16 Nov 2020 17:42:11 +0000 (UTC) Received: by mail-wm1-x343.google.com with SMTP id s13so35749wmh.4 for ; Mon, 16 Nov 2020 09:42:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GWKMq1DqVP98QcoNoXmklvrAILj+KoFN9Nw2d/Tqn0c=; b=AZkL0vTTyxk+qn+knrS8JsKh1uX3JBdQV4cxD+BFOWtzaAEZHcJTPFTQTvPiJ+r9MB R9rVcYw0cx5xl+uHxcqnLOALxHvDCZOa8wqgvrF1rI7L1Z8dpVX4tYYGBmieDCxg6oV0 UphxExobgaBvDGn7ZVAN3hpfhT42SJ6wGLomRfx+Wt03bfTFHyOKa79p645Th2ypthB1 Mbw3pUBRrTA3DGLEu54EWLo6MlZP0u0HkSHy59FpWyhpNuciXw6YOZ+RULCIaHLnrFMJ vOwKxOCJWsEiUgbxu0qVsSV48yHmuGEll17GvLRFEncNv3ztpazHJRjLAEg/kRzW/h4O k6hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GWKMq1DqVP98QcoNoXmklvrAILj+KoFN9Nw2d/Tqn0c=; b=EHOtg1HIBrgl82Pl6/bbE3URAQq/8S5NalGE45+U5dYFgf3ddP2/AtBJvqPdW3f4bi qLHTY3R8fLAksH8zFqzOVbMB2XDUBC7e2CkZECasujxDP8bioVuwHmhu4QK0ICbINB0z tyfg3iU73FrwoWJF9UgeBiWO6QVxJ+r3aVSa00zblwWkW7VrTpw6LJ//l7+7wC0ZT2Lv 32ypFSEfJdEbBDAtWNhIAB+H5J5x0Rc7WmC9w1ejjWlZknqq/C2IcjKuNHIi/OmPUTT1 aHE8vic/em5Ezm8yGK4joEqzxwaBJbOz4qIyVY8CippcdK/rnxSHNpr9HyCTMTZ5Ghht /Tkg== X-Gm-Message-State: AOAM531VmeYgFtUeYkG/LmZ9+R5yIPUk1Lv+od/3KWxFbCq+ba1FGa1S CfZZnp0TWp7XoBshMjxOxFD1Ig== X-Google-Smtp-Source: ABdhPJxa2OYyT+kPM38xMqaqvVdak1kEsguesAO3rvzYZo5Fy8xTslicZ8z9OmMrZSCfUnFEO9Jcdw== X-Received: by 2002:a7b:c18e:: with SMTP id y14mr7522137wmi.123.1605548529946; Mon, 16 Nov 2020 09:42:09 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 35/42] drm/v3d/v3d_gem: Provide descriptions for 'v3d_lookup_bos's params Date: Mon, 16 Nov 2020 17:41:05 +0000 Message-Id: <20201116174112.1833368-36-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, =?utf-8?q?Christian_K=C3=B6nig?= , linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/v3d/v3d_gem.c:292: warning: Function parameter or member 'bo_handles' not described in 'v3d_lookup_bos' drivers/gpu/drm/v3d/v3d_gem.c:292: warning: Function parameter or member 'bo_count' not described in 'v3d_lookup_bos' Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter Cc: Philipp Zabel Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/v3d/v3d_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c index 182c586525eb8..4eb3542269725 100644 --- a/drivers/gpu/drm/v3d/v3d_gem.c +++ b/drivers/gpu/drm/v3d/v3d_gem.c @@ -275,6 +275,8 @@ v3d_lock_bo_reservations(struct v3d_job *job, * @dev: DRM device * @file_priv: DRM file for this fd * @job: V3D job being set up + * @bo_handles: GEM handles + * @bo_count: Number of GEM handles passed in * * The command validator needs to reference BOs by their index within * the submitted job's BO list. This does the validation of the job's From patchwork Mon Nov 16 17:41:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910097 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 219DEC4742C for ; Mon, 16 Nov 2020 17:42:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AFE6E22453 for ; Mon, 16 Nov 2020 17:42:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f7neOg4p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AFE6E22453 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E3C696E9FA; Mon, 16 Nov 2020 17:42:24 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE2A26EA17 for ; Mon, 16 Nov 2020 17:42:12 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id d142so41255wmd.4 for ; Mon, 16 Nov 2020 09:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4XjzABzYijzfUYSQAFjSWGgtY8O6T4iGtJT/GdPVe/g=; b=f7neOg4p2FtX/vppSn6QN4LztxxWXPO5PsEPG4P1pfWm9ayx4ZaCXP7Qy5MqXIyTJc szXloESY6VRWVHOrJFA0WDsNDfNySfQbMAttyoqqqrPShI2NHvwtsWMnnVe90jgsu6/k RfOFgRTAgrB9QnazseVDq0C31vlwqKRYp/3Iv9uR/1K+XMNC2FUSHUFAbjWZFBxEqLMJ 5yM7hZMKGVWVIANE4KarSM+svzza1WdFLdf+b51OHuQcgM4RzIu0shsgULOJyqo5wxmx EpGBaE7lPbGEd1xXXmTdM9La82KremeZzH6buoeGQECFzv4wW0EUHa3LjPQsOWRIRaD3 rhfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4XjzABzYijzfUYSQAFjSWGgtY8O6T4iGtJT/GdPVe/g=; b=Qq+Wf6fGUq97l4LVBF5exhALCJLLF6FI6y+K1sbb0MRE1o1z1cBUvzDmLNohU5j4oa QXWefwTnsVtjVs04M5rbJ2k+puftumyw77Wy7Kp1kt25flKnoqp00a6rnGZIvPutNhcA tr+U/0XAh3KVycKHoUxg4SGSaBpZeTHDJ/hF3ls8X7jG0X6P71ADVK88oBnq+Cld8+4Z QCazqhtbiTBMPmmH0RKoltIX91PoMfI6nuDCICF9qpe+9LNhAUu91cJi439acp6348Cp wayZPE75jH0vtS2/W43xc7bWaWR+VA/1OEzW3y5rDIQwkCju2mnl7rqrmrKyJMDD+6La uKZg== X-Gm-Message-State: AOAM531dD+YwWpJtE2arSiBAu4fT2DlOAAg/wpkv713D2s+82Y8XR8YC +DCU7WlDQ8xQA3QrvAkt+LqfRue/dH9eiurk X-Google-Smtp-Source: ABdhPJxD3PsXkkAcAPwL+o29CIkE9xzELIl6mVYJ526IXOd8g4jWPgod5PLCtsJAgJzqn/4rRNKQ/Q== X-Received: by 2002:a1c:c20a:: with SMTP id s10mr8267wmf.23.1605548531381; Mon, 16 Nov 2020 09:42:11 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 36/42] drm/v3d/v3d_sched: Demote non-conformant kernel-doc header Date: Mon, 16 Nov 2020 17:41:06 +0000 Message-Id: <20201116174112.1833368-37-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, =?utf-8?q?Christian_K=C3=B6nig?= , linux-media@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/v3d/v3d_sched.c:75: warning: Function parameter or member 'sched_job' not described in 'v3d_job_dependency' drivers/gpu/drm/v3d/v3d_sched.c:75: warning: Function parameter or member 's_entity' not described in 'v3d_job_dependency' Cc: Eric Anholt Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: "Christian König" Cc: dri-devel@lists.freedesktop.org Cc: linux-media@vger.kernel.org Cc: linaro-mm-sig@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/v3d/v3d_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c index 0747614a78f0b..452682e2209f4 100644 --- a/drivers/gpu/drm/v3d/v3d_sched.c +++ b/drivers/gpu/drm/v3d/v3d_sched.c @@ -63,7 +63,7 @@ v3d_job_free(struct drm_sched_job *sched_job) v3d_job_put(job); } -/** +/* * Returns the fences that the job depends on, one by one. * * If placed in the scheduler's .dependency method, the corresponding From patchwork Mon Nov 16 17:41:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910099 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37EADC4742C for ; Mon, 16 Nov 2020 17:42:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D24C020B80 for ; Mon, 16 Nov 2020 17:42:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VzWzCJBP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D24C020B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 79B366E9FC; Mon, 16 Nov 2020 17:42:38 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0594D6E9FC for ; Mon, 16 Nov 2020 17:42:14 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id c17so19630512wrc.11 for ; Mon, 16 Nov 2020 09:42:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=z9hqlcpW7hereULOoI8627Xoa15VHuxF/Ol1jNzvX80=; b=VzWzCJBPPmyM3LpM7la4ilnDI68trSv7JH2kfu2f+DU0i4SMuZmeKKXiNLD1Hu4Etc wIhTyantuHh0S7h+NwM9t/QpaHtrBiT/mhLmz2It8yTttVcJAvk3V+u2b40CnNADXgKR HA6ChwT3TtKgoqlfuS732ua9sE7/x3Av0/dDNvBe+qbOU7Qkb4DYV+WabOT4A/++AZgY urAa0e+d4vnAcXCsaIw3qiDif6pZknYz13s9Xt2VaOHpca1hEYKNdjSMuim15K33YJXr wcsFYRRcZBKmBLiqjcaZk+SZrNmLGMiuVVoTO+Hja3MJLGnOx6GDJUgm/SZVzDrPyaAJ pwiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z9hqlcpW7hereULOoI8627Xoa15VHuxF/Ol1jNzvX80=; b=rZUHILw54o+kdBUjQXSdRCgWvGYz9F8P/yWzA7xkIrsVKv99bwRJkVUyPHJ4WARuHD 6BcW0MaPee5TYheqgP26dJuPbE/Ym6W2SZdVChwZGrN4+KDbGqx3nB3mkdffimTD8UBD p1Ck5WhYQC3mAcm961ETSrmZRsws3U8Ts/5O3E7gRPBraEN3BYLdJI7iC5GQh8SZRIUW xUjRyCYn3eISiYN1Y+mQ6i5EZXSYcrR4aUbLhUpYtpGGyyqcTRy/m52gH4lb72KT4Ule 8oLbm6Bw+Fu86mILWd76z5VucRymdIvBmIGRfCu3SL5nz7b1y+tGGPOZVOjSm8swlxjr u5FA== X-Gm-Message-State: AOAM5310p5f4lZVPt4gjf+YhJAPWYvwIEGpQkM37XBl8SGRijf9hSih9 /FpeqCUhPs1ivO+Nb0U/HcqTtw== X-Google-Smtp-Source: ABdhPJwe4OeSF0fUEzmtQPCyVZBNL4CH7EopB3/QGF4xEgcwY0RS9lBoS1zjZjxDp+VwWScJhmJ/Ww== X-Received: by 2002:a05:6000:110c:: with SMTP id z12mr20268702wrw.214.1605548532636; Mon, 16 Nov 2020 09:42:12 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 37/42] drm/vc4/vc4_hdmi_regs: Mark some data sets as __maybe_unused Date: Mon, 16 Nov 2020 17:41:07 +0000 Message-Id: <20201116174112.1833368-38-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The alternative is to move them into the source file that uses then, but they are large and intrusive, so that strategy is being avoided. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vc4/vc4_hdmi_regs.h:282:39: warning: ‘vc5_hdmi_hdmi1_fields’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vc4/vc4_hdmi_regs.h:206:39: warning: ‘vc5_hdmi_hdmi0_fields’ defined but not used [-Wunused-const-variable=] drivers/gpu/drm/vc4/vc4_hdmi_regs.h:145:39: warning: ‘vc4_hdmi_fields’ defined but not used [-Wunused-const-variable=] Cc: Eric Anholt Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi_regs.h b/drivers/gpu/drm/vc4/vc4_hdmi_regs.h index 7c6b4818f2455..96d764ebfe675 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi_regs.h +++ b/drivers/gpu/drm/vc4/vc4_hdmi_regs.h @@ -142,7 +142,7 @@ struct vc4_hdmi_register { #define VC5_RAM_REG(reg, offset) _VC4_REG(VC5_RAM, reg, offset) #define VC5_RM_REG(reg, offset) _VC4_REG(VC5_RM, reg, offset) -static const struct vc4_hdmi_register vc4_hdmi_fields[] = { +static const struct vc4_hdmi_register __maybe_unused vc4_hdmi_fields[] = { VC4_HD_REG(HDMI_M_CTL, 0x000c), VC4_HD_REG(HDMI_MAI_CTL, 0x0014), VC4_HD_REG(HDMI_MAI_THR, 0x0018), @@ -203,7 +203,7 @@ static const struct vc4_hdmi_register vc4_hdmi_fields[] = { VC4_HDMI_REG(HDMI_RAM_PACKET_START, 0x0400), }; -static const struct vc4_hdmi_register vc5_hdmi_hdmi0_fields[] = { +static const struct vc4_hdmi_register __maybe_unused vc5_hdmi_hdmi0_fields[] = { VC4_HD_REG(HDMI_DVP_CTL, 0x0000), VC4_HD_REG(HDMI_MAI_CTL, 0x0010), VC4_HD_REG(HDMI_MAI_THR, 0x0014), @@ -279,7 +279,7 @@ static const struct vc4_hdmi_register vc5_hdmi_hdmi0_fields[] = { VC5_CSC_REG(HDMI_CSC_34_33, 0x018), }; -static const struct vc4_hdmi_register vc5_hdmi_hdmi1_fields[] = { +static const struct vc4_hdmi_register __maybe_unused vc5_hdmi_hdmi1_fields[] = { VC4_HD_REG(HDMI_DVP_CTL, 0x0000), VC4_HD_REG(HDMI_MAI_CTL, 0x0030), VC4_HD_REG(HDMI_MAI_THR, 0x0034), From patchwork Mon Nov 16 17:41:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910105 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97837C4742C for ; Mon, 16 Nov 2020 17:42:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E74022265 for ; Mon, 16 Nov 2020 17:42:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="TjXthjtt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E74022265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B63DC6EA16; Mon, 16 Nov 2020 17:42:40 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65D426EA14 for ; Mon, 16 Nov 2020 17:42:15 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id l1so19648266wrb.9 for ; Mon, 16 Nov 2020 09:42:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kn9g1kMG5JlU7ctdIXE2LbkwCeCLbWZDScIEWNzvtKI=; b=TjXthjttEpmJXsxziQtJEgvptDqsm2IsMdlIZDf2ll+O3GDNYuajE0ftV8lFIdMW20 sb7gHK7eew5HhS2T8VF1svXf4x6DaTH/qnWItZoXjoCQbfK5zbk/wdMR5+HAloUjJrr4 PHqMKcXYueDMUUWbuzAxxJ/L0bfnO1NIqAxF0fhT/ycL4/BRJ+ckcIHt2ZvXJyKHIYS3 UD0PCl6u6AP2alOfvZKLw2BGhLfkN/h0hlD5sTYfOvW2+jmz6mlWKhKUmQgmkEaSa8zH sXKFSFkB4u6zAygOG9BZ3+S3GBvWQpluxgeoZarTXAQ9g+epMBQDJWftsEQT7/DT/yAE Eicw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kn9g1kMG5JlU7ctdIXE2LbkwCeCLbWZDScIEWNzvtKI=; b=cFDE6QzkjQgX9w5FJLm7z4i6SJPfZ9rDzITXJocz9OWYRWmy38WSzkW6pncCq8KVAY JYibRW+3atoQEbhEzoHQ6izMH1SpJqIdHo7YpG8vHCgf9RI/ckSGrjooUiuhh7IcDbt8 T254ZtDoh1VtTlZNu5dPIr14/24qhZzu0a9zWUInftbMstWYNBJ3u+HHzyAHaSuNnd2a +WXGdfq96s0zsECumn5dklC0D+8ph1uNj0ahcbqhN0k651dDJYnRmjir5cZRWtqWTTk0 d3cl5IfYhVy0PGNOVdwWzz3zHCjbPE+cvWP/KgSo/iWdxLZ8Ar8bYMi7djW4GF2Cd5dY 7iHw== X-Gm-Message-State: AOAM5336NRZVEP6XVhnXZeUdMHLPt0o8NtfhtbAkcy6kON+5nMzCBr3e LWTpo18LyAxiEf5tIOEQULoaHw== X-Google-Smtp-Source: ABdhPJyAXVf2/cgIvwC56rcD5A8G4Ad6Kn2UAK55+eDnXsJvtjSRnX56sS6h1gKA2V+1GziFtMfVWw== X-Received: by 2002:a5d:4991:: with SMTP id r17mr20913528wrq.70.1605548534067; Mon, 16 Nov 2020 09:42:14 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:13 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 38/42] drm/vc4/vc4_hdmi: Remove set but unused variable 'ret' Date: Mon, 16 Nov 2020 17:41:08 +0000 Message-Id: <20201116174112.1833368-39-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vc4/vc4_hdmi.c: In function ‘vc4_hdmi_set_audio_infoframe’: drivers/gpu/drm/vc4/vc4_hdmi.c:334:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Cc: Eric Anholt Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: Philipp Zabel Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vc4/vc4_hdmi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 95779d50cca0b..b80eb9d3d9d5a 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c @@ -331,9 +331,8 @@ static void vc4_hdmi_set_audio_infoframe(struct drm_encoder *encoder) { struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder); union hdmi_infoframe frame; - int ret; - ret = hdmi_audio_infoframe_init(&frame.audio); + hdmi_audio_infoframe_init(&frame.audio); frame.audio.coding_type = HDMI_AUDIO_CODING_TYPE_STREAM; frame.audio.sample_frequency = HDMI_AUDIO_SAMPLE_FREQUENCY_STREAM; From patchwork Mon Nov 16 17:41:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8893EC2D0A3 for ; Mon, 16 Nov 2020 17:42:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3EF5D2231B for ; Mon, 16 Nov 2020 17:42:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="R0c1VYZ4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EF5D2231B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4ACE06E9F3; Mon, 16 Nov 2020 17:42:38 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id CC5C26EA16 for ; Mon, 16 Nov 2020 17:42:16 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id p8so19676258wrx.5 for ; Mon, 16 Nov 2020 09:42:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3dpuU5BsT173A/3X/IKJ/RVPURrpJEnyWKPfCisq40U=; b=R0c1VYZ4uhe952lSIq65QcDIkw0VaRxMNF3r12FkqKkCKP3mYeJAIhiOq132YdsaZ8 ZH1GB3ItUBwsx/qcAf9v2JrJgYX2Gx3ammOyg9wlPC9zFR8X6irCtvs/vZl47wPv0AyT YRC9sdRNT3EwxeYAFc0qhB+Ef5RwwBinY99ti9yIsaYI822N9aAqQooU3JHaEL+9n+HP Q6+FwmvbhSlkAM41JSELFusyxho3UvHUPX33fxH9hTxkXEMo04wDtOYDTQNWDl0I4ZK0 i0rj0ygI3EsYcYDEq+VF1Jy8Zd5CUxH6BCXECjSvOmwafl3PI6R0BTpY9mocgCRHPt49 49mQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3dpuU5BsT173A/3X/IKJ/RVPURrpJEnyWKPfCisq40U=; b=pU2R7YgYhIBB/ONFCksPrG57Cv7j4aAhD073iuLvitjB2VRUNfJZdmtRn/5WU1uGal CSPAGtRBg9z1q/k5pKkPGqWu/ScXD7J1T9gw/YBQNMHQ3Iup9eXt60Bp/wdOSctciwMD kBQhlpdG5rqQjIHRmjlgMGt5I1LaTUZAGPk3VNJCDYtC8rLZyx/ZJlxohO7O5Oop1ISB DiX2BH/iTyVm4SbrVpITlAFkjSVM4JW84EoGhpuJiXNLf22dniIrbb7Wyt6SZuesatxI XYzbIlnX2iaFzXPN2drtZsW1YUuMTfvjaXn3Q35PtCCDxgRdtCpMiMrb/z7sLhcoe3Pk Vg5Q== X-Gm-Message-State: AOAM531I4/9tQukaZ3ZNldoefTTxPQrCvZjJ1jb75GHUIhO6xG413ei3 PlU8MNjoR+FJJn4TVkgmhweY2g== X-Google-Smtp-Source: ABdhPJxtmaWM3VKZa7T15xSrO7rUuQXUBkW8QqK89gWx3Yq36M767nEaAOZciDjUhOSQTWtTeD/Fcw== X-Received: by 2002:adf:c847:: with SMTP id e7mr20667633wrh.346.1605548535413; Mon, 16 Nov 2020 09:42:15 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 39/42] drm/vc4/vc4_v3d: Demote non-conformant kernel-doc headers Date: Mon, 16 Nov 2020 17:41:09 +0000 Message-Id: <20201116174112.1833368-40-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vc4/vc4_v3d.c:131: warning: Function parameter or member 'vc4' not described in 'vc4_v3d_pm_get' drivers/gpu/drm/vc4/vc4_v3d.c:231: warning: Function parameter or member 'vc4' not described in 'bin_bo_alloc' Cc: Eric Anholt Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: Rob Clark Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vc4/vc4_v3d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index 65d0dac69b0bc..73d63d72575b0 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -122,7 +122,7 @@ static int vc4_v3d_debugfs_ident(struct seq_file *m, void *unused) return 0; } -/** +/* * Wraps pm_runtime_get_sync() in a refcount, so that we can reliably * get the pm_runtime refcount to 0 in vc4_reset(). */ @@ -205,7 +205,7 @@ int vc4_v3d_get_bin_slot(struct vc4_dev *vc4) return -ENOMEM; } -/** +/* * bin_bo_alloc() - allocates the memory that will be used for * tile binning. * From patchwork Mon Nov 16 17:41:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910091 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DADF5C4742C for ; Mon, 16 Nov 2020 17:42:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 855E42227F for ; Mon, 16 Nov 2020 17:42:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DKTVoYhL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 855E42227F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25CB66E9F1; Mon, 16 Nov 2020 17:42:38 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1CE3B6E9FA for ; Mon, 16 Nov 2020 17:42:18 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id l1so19648524wrb.9 for ; Mon, 16 Nov 2020 09:42:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kwAPsdpVMxl/zDOaEKrvh3eBbThND3Sgn5s6wfB0Uyk=; b=DKTVoYhLDkbUjmiKBiSxqN0EkzBLYyzyrkoqtuN6VulUimxRpI6QLv0OIHxkKaQQgU KYLrGD874Ber7KTt6OJaUpi2vEOqawPyVBFY0niR1SkoQpbH0FGG2WodY9fl8grPOC7q RqSW3DTkKBPSp1/YLd9RcWADeSJl8AGqcerHF/73w3pZyGN4NPmJ0ha5qJWTublG4eVP FvWuTMIgTQVlzi1mJLNQgc+aO/NoIPqjaxzq3VlsC2bSDchoZBkqoBcDmPKQ3X5z4eXv XWJrBqmGzKAQIh2YZjXrnie9qVgHj6SkltfZVcvXgBg7Cmg7I8oXBfuMB0NnR4ltofjK +9SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kwAPsdpVMxl/zDOaEKrvh3eBbThND3Sgn5s6wfB0Uyk=; b=B1Qmo/1r7qL7QFyC1d6FFuINvYAS1si9qT4+00lxSh+SeY59/geYvFA6LSn+5/AXH8 8J/hJueAmWPAWPbuDJBV3AuSOJv4bkXMGqqbSuGkL5fZ2zCbCOa9ze8ecn7mAeFj3HJL KfbBZfgGox0aFpVqrxdp6u6ysLDPssQhcynkuMMySOfQn9jAMxH4obk/6oAV/6+E25Er +UQ1LxAvSN/qwwEgKPBJWKSIOcSgI1Hv5hyJ8XxXnITY1HP2PCL52tIRbuU7KxcbKDPJ n/E/AOlEjz4qCNI9WRSKm5JItm1RF8jnjUYgO/5EddbRtkxozC8hSJAn2TUkx59SMm2x jiBg== X-Gm-Message-State: AOAM530msMmsdtw1CumKm/2dAl6ygjTPvwhggJ2PFlcWI8yRVk9I0NE7 O/OEirtulbTw68tUKLgjTPvBzQ== X-Google-Smtp-Source: ABdhPJxBcXflNnhznga0qA/1qGlXLsbwa73sxSXQZeI2NdqkAJACA5ixV1bOC5dXLeCi3pwSiE6mqA== X-Received: by 2002:a5d:4802:: with SMTP id l2mr19918921wrq.424.1605548536828; Mon, 16 Nov 2020 09:42:16 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:16 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 40/42] drm/vc4/vc4_debugfs: Demote non-conformant kernel-doc headers Date: Mon, 16 Nov 2020 17:41:10 +0000 Message-Id: <20201116174112.1833368-41-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/vc4/vc4_debugfs.c:25: warning: Function parameter or member 'minor' not described in 'vc4_debugfs_init' drivers/gpu/drm/vc4/vc4_debugfs.c:62: warning: Function parameter or member 'dev' not described in 'vc4_debugfs_add_file' drivers/gpu/drm/vc4/vc4_debugfs.c:62: warning: Function parameter or member 'name' not described in 'vc4_debugfs_add_file' drivers/gpu/drm/vc4/vc4_debugfs.c:62: warning: Function parameter or member 'show' not described in 'vc4_debugfs_add_file' drivers/gpu/drm/vc4/vc4_debugfs.c:62: warning: Function parameter or member 'data' not described in 'vc4_debugfs_add_file' Cc: Eric Anholt Cc: Maxime Ripard Cc: David Airlie Cc: Daniel Vetter Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vc4/vc4_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_debugfs.c b/drivers/gpu/drm/vc4/vc4_debugfs.c index 4fbbf980a299f..6da22af4ee911 100644 --- a/drivers/gpu/drm/vc4/vc4_debugfs.c +++ b/drivers/gpu/drm/vc4/vc4_debugfs.c @@ -16,7 +16,7 @@ struct vc4_debugfs_info_entry { struct drm_info_list info; }; -/** +/* * Called at drm_dev_register() time on each of the minors registered * by the DRM device, to attach the debugfs files. */ @@ -46,7 +46,7 @@ static int vc4_debugfs_regset32(struct seq_file *m, void *unused) return 0; } -/** +/* * Registers a debugfs file with a callback function for a vc4 component. * * This is like drm_debugfs_create_files(), but that can only be From patchwork Mon Nov 16 17:41:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910095 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DA9EC6369E for ; Mon, 16 Nov 2020 17:42:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 04621223BF for ; Mon, 16 Nov 2020 17:42:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y1M2raZY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04621223BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 071386EA0D; Mon, 16 Nov 2020 17:42:26 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A3B26E9FA for ; Mon, 16 Nov 2020 17:42:19 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id 19so59170wmf.1 for ; Mon, 16 Nov 2020 09:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ni2p/a1qgnbLwmmB/hD7NYV4hNmI7rYb9FSLzDt4vrQ=; b=y1M2raZYDC6gpB5Mcfn5HK0VPQYg/d3IyD5wEaZ8lpNqOJ116kFE2YrxPfyHAozLtM hEXxXKHNRbcq6vandz+s4QemQu3/P9TcUDbZ70WoYmHa8GOB46snl+Ax8TnKoHuicMGZ 91IPIjMeNrgJwGKZpTI2VyeaQGSxHmVEelyKEm9o/SMpAnxQlfbWxpn8Jr7+o+29PJW6 ubTwCOUpNz2j6ZEI2xVpMDLezNp3wZcAizCwG/68wOUAO+2R7rangWf0/PN481oDOWM9 1MQj6SKA/ZoK4skFes92k/8voPQoMJEk1u17QeonkE4xiSKLnfEonfyZzBUyVlDjAK/T uAbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ni2p/a1qgnbLwmmB/hD7NYV4hNmI7rYb9FSLzDt4vrQ=; b=IZlLl8hBKmgp8+Ox61cPhnaV7XZCxiOnoLUBsOkHhhs7g3Cz1zc4OFxzdmtam/DySA jC7YMru1A8jbqQL3cj7h2n/Z2av/6C6k22/jotsIPggBl+y5F9/aBCzJSgZR/j8mb8fb k+vXev1BZgkndXG/dG+1+a+fl5c8Q/vXJqdYc+LE6E3LIZtL7BUqmUbPttQFERtdcnoc q3H+Bq4OLqqynfddPgXnnEVj5yNlHPD9FlPB8yd0ZY81G7EfThmGcm4UAqHf2A0rhWMh PPoO+fD9joqefrDPVSzHUJsmUk+GBOnTsI3E1L1bRCN5LoX+3jW+VbWen5VRWopSgBsP R1pg== X-Gm-Message-State: AOAM5322/qqDGC0W1yMIbfW8WKPKWirkVmr9AlbPWi96Ukew9zgM0D3s xE+z8MbPqFBaVsmbtjX28bJwTU2qVxqGd5hu X-Google-Smtp-Source: ABdhPJxETsZD33sKO702FEhtaRxNZu5IBxrtx1EC2eTn8ldtL85csSK0HWNMrB9syRBqVFIZIwdWdg== X-Received: by 2002:a1c:b644:: with SMTP id g65mr15974374wmf.145.1605548538118; Mon, 16 Nov 2020 09:42:18 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 41/42] gpu/ipu-v3/ipu-di: Strip out 2 unused 'di_sync_config' entries Date: Mon, 16 Nov 2020 17:41:11 +0000 Message-Id: <20201116174112.1833368-42-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Sascha Hauer , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" They're taking up too much space on the stack. Fixes the following W=1 kernel build warning(s): drivers/gpu/ipu-v3/ipu-di.c: In function ‘ipu_di_sync_config_noninterlaced’: drivers/gpu/ipu-v3/ipu-di.c:391:1: warning: the frame size of 1064 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Philipp Zabel Cc: Sascha Hauer Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/ipu-v3/ipu-di.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/ipu-v3/ipu-di.c b/drivers/gpu/ipu-v3/ipu-di.c index b4a31d506fccf..e617f60afeea3 100644 --- a/drivers/gpu/ipu-v3/ipu-di.c +++ b/drivers/gpu/ipu-v3/ipu-di.c @@ -310,10 +310,6 @@ static void ipu_di_sync_config_noninterlaced(struct ipu_di *di, /* unused */ } , { /* unused */ - } , { - /* unused */ - } , { - /* unused */ }, }; /* can't use #7 and #8 for line active and pixel active counters */ From patchwork Mon Nov 16 17:41:12 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11910103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ADA8C2D0A3 for ; Mon, 16 Nov 2020 17:42:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9F8D22265 for ; Mon, 16 Nov 2020 17:42:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UjF5WqGy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9F8D22265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 174F16EA15; Mon, 16 Nov 2020 17:42:39 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDC826E9FA for ; Mon, 16 Nov 2020 17:42:20 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id u12so12446526wrt.0 for ; Mon, 16 Nov 2020 09:42:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AA3ifXfkFgEiPb/+ErWAHaArtQGSrp8moUYg4qmaDWk=; b=UjF5WqGyB7EH7OhySfFTVMXhaSx34pvV4mfdWl92PAWblT7uWjt4EwdhGq4opaxfLb orZ7sxKafXTs+opxYnQzhDGyotWpmYeb9VKFYp3i+810+f64cW0rKZ68feO0yDcmvLC1 S/Q/4p8zK32nfoxT6fR/BCXo/GZfP2gSDppe75Kbss/WbsbJoHmBR866lH3s/zfwKhZf IuYlJIjyzMQaEBu6dsOnwYELcHmpH4/Hb3o9cYIe+FWPQz+C+BvpuXW783/4+ZjzjPIM +8Wn80vVhpZXESufXsvdhx5gvWEKTRfxtfegS/nbCAdJUjwMpwutlXm4gYEVbmSZmHCW /k6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AA3ifXfkFgEiPb/+ErWAHaArtQGSrp8moUYg4qmaDWk=; b=p/HzWUdme/ot7ZC6BbGqhHfpOGBUXpYVSRNLPflbama/Jh919F3Or8uu+Gv1cviqyB WRsLAN+44jIkIScoZD/ecgVH9yee53igZbZrqCjg0HCmpqtDUHixaiU+cuJ1W8pFoPmX p+Op2SQVuquya28piUp63jvHBx6m76rw2iM10kVUsb/7+JPGGuA/yaXBbQwr1pfif7iv gxCYsj0VgZji5dLhXsIxK9F+MLTSZ6R0JQkaecb0tuROlrJ5vP9LVgIHMy0Wdzzh7nu/ XaeSgzhphaUchQ4tm5Bff1T/AmipQvCWtaFdi2J7SK2bfb5crB2HDSxD/Bgulrvkf4ib 9xww== X-Gm-Message-State: AOAM531Pn5k/cQDgwk7cgusPpxvbVpjs3joWt8v0aRw4zvUH8+b4DUH4 ll6/6siuuQflNdF4pgTQy4f+hg== X-Google-Smtp-Source: ABdhPJw6r7DlQ++cTDY1efHbC5r3WHHMN2X6WMtV3NiC9i0Cnqx0lR2bC+5andsXJU2Z2O4IncQtrA== X-Received: by 2002:adf:cf0b:: with SMTP id o11mr20119219wrj.162.1605548539468; Mon, 16 Nov 2020 09:42:19 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id n10sm24667224wrx.9.2020.11.16.09.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 09:42:18 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 42/42] include/drm/drm_atomic: Make use of 'new_crtc_state' Date: Mon, 16 Nov 2020 17:41:12 +0000 Message-Id: <20201116174112.1833368-43-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201116174112.1833368-1-lee.jones@linaro.org> References: <20201116174112.1833368-1-lee.jones@linaro.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Sascha Hauer , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, NXP Linux Team , Shawn Guo , Pengutronix Kernel Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided as a container for state->crtcs[i].new_state, but is not utilised in some use-cases, so we fake-use it instead. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/imx/ipuv3-plane.c: In function ‘ipu_planes_assign_pre’: drivers/gpu/drm/imx/ipuv3-plane.c:746:42: warning: variable ‘crtc_state’ set but not used [-Wunused-but-set-variable] Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Shawn Guo Cc: Sascha Hauer Cc: Pengutronix Kernel Team Cc: Fabio Estevam Cc: NXP Linux Team Cc: dri-devel@lists.freedesktop.org Signed-off-by: Lee Jones --- include/drm/drm_atomic.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index dc5e0fbecc04e..54e051a957dfc 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -783,7 +783,8 @@ void drm_state_dump(struct drm_device *dev, struct drm_printer *p); (void)(crtc) /* Only to avoid unused-but-set-variable warning */, \ (old_crtc_state) = (__state)->crtcs[__i].old_state, \ (void)(old_crtc_state) /* Only to avoid unused-but-set-variable warning */, \ - (new_crtc_state) = (__state)->crtcs[__i].new_state, 1)) + (new_crtc_state) = (__state)->crtcs[__i].new_state, \ + (void)(new_crtc_state) /* Only to avoid unused-but-set-variable warning */, 1)) /** * for_each_old_crtc_in_state - iterate over all CRTCs in an atomic update