From patchwork Thu Nov 19 14:07:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 11917493 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9617AC2D0E4 for ; Thu, 19 Nov 2020 14:07:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09D4024698 for ; Thu, 19 Nov 2020 14:07:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tWYBBjEy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09D4024698 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1C8366E52D; Thu, 19 Nov 2020 14:07:40 +0000 (UTC) Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by gabe.freedesktop.org (Postfix) with ESMTPS id C52EB6E52D for ; Thu, 19 Nov 2020 14:07:39 +0000 (UTC) Received: by mail-lf1-x141.google.com with SMTP id a9so8427523lfh.2 for ; Thu, 19 Nov 2020 06:07:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=by9rdaiSTNhh25rGcdMhydBPT1Ee6Q+Ur1BB4O7C4Tk=; b=tWYBBjEyHLLcUdZV3JTAQ8MKQEQ2kqZgcQ5MDERuYEGvL2/ppp2n5esSze20TLaGOi c4EhVEVoixCWm/H79N2t+a00SFj4PRlAhn5BU5e65yywr+THQA+MGDJqyzIRVwhJ8Ovm uuenvZ+v4MZ/Tuj/3VnUKDo/htf5Otr0n62kEZLRThkQDgNlKNTdj5+Lt89zis6Y48Lv VKggH458/phEKCV3+9wSUYCs9mvIZSPP8U8r8p0TMYcIEBjougHLM8NFPOtEww2hjN0h t5wynqI6UqxEPWEBxA6bevACRN1z9bg3enfgsJGGIa4kUDVQGT8ULyjpwrb0j5MFL5ir ZgyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=by9rdaiSTNhh25rGcdMhydBPT1Ee6Q+Ur1BB4O7C4Tk=; b=EAFJq5LNaUPfVOc2iH/k7B5pm6pBDuqDxMzm5+2MbhmLpXmael5vgJusdpif6a4NwZ Q25j7c3x5elRRw8LAiTRgsgs61DzlHyCMZnSm5YVTzbDSDZuCWVfbGNyMhw958+xM6eb uayigOdb5ksVcrLgqgmys/q5WLxNteNnEpV/bBU2+8WbZ4HGnnKyC0DZW4akgFic/Tsj DbuVmpzbgEpSo7l5fzNt8IQEnj2WY85fah1Axp8+lWgWtATaD4c6Xk334tHCh2HAruQu A6PaftL9dTtNTUswA9jS4ox8WIUB+nX6Dk/WsV64/GG96Ldp1Bgb+sCSqF3F3QBy0R7o D3+A== X-Gm-Message-State: AOAM530FcX8wcfJQDnwKXyNBQAPOEHHXGHkXlKtfYZ3JlXYWBC3ZuYGi ebvrkUhNCCB9HVg6HkZR/LEgTczM13FVUNNN X-Google-Smtp-Source: ABdhPJz16YnQNj458eZvEVvW7NxGWSmTcZqoP1RkFR1v7kfmXpaxFUlpiU33ocN4k0m+m7d3/OdQfw== X-Received: by 2002:a05:6512:3048:: with SMTP id b8mr5524416lfb.575.1605794857954; Thu, 19 Nov 2020 06:07:37 -0800 (PST) Received: from localhost.bredbandsbolaget (c-92d7225c.014-348-6c756e10.bbcust.telenor.se. [92.34.215.146]) by smtp.gmail.com with ESMTPSA id r8sm3983292lff.238.2020.11.19.06.07.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Nov 2020 06:07:29 -0800 (PST) From: Linus Walleij To: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul Subject: [PATCH] drm/mcde: Fix uninitialized value Date: Thu, 19 Nov 2020 15:07:07 +0100 Message-Id: <20201119140707.1008407-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dan Carpenter , kernel test robot , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" "val" isn't initialized on the default: errorpath. Just return from the function if this happens. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Linus Walleij Reviewed-by: Sam Ravnborg --- drivers/gpu/drm/mcde/mcde_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mcde/mcde_display.c b/drivers/gpu/drm/mcde/mcde_display.c index 192e11c88d72..d941026b940c 100644 --- a/drivers/gpu/drm/mcde/mcde_display.c +++ b/drivers/gpu/drm/mcde/mcde_display.c @@ -569,7 +569,7 @@ static void mcde_configure_channel(struct mcde *mcde, enum mcde_channel ch, default: dev_err(mcde->dev, "unknown flow mode %d\n", mcde->flow_mode); - break; + return; } writel(val, mcde->regs + sync);