From patchwork Thu Nov 26 13:31:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933949 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61758C64E75 for ; Thu, 26 Nov 2020 13:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 00DBF206F7 for ; Thu, 26 Nov 2020 13:32:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="V+CXrilh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390161AbgKZNcB (ORCPT ); Thu, 26 Nov 2020 08:32:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390034AbgKZNb7 (ORCPT ); Thu, 26 Nov 2020 08:31:59 -0500 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAEFBC0617A7 for ; Thu, 26 Nov 2020 05:31:58 -0800 (PST) Received: by mail-wr1-x442.google.com with SMTP id e7so2158961wrv.6 for ; Thu, 26 Nov 2020 05:31:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rWq4EIZLBdjUFDSSQaVD1PvQUVhVWlX38rMGrIxZmlM=; b=V+CXrilhjwCj4T6b2gK0G4kHB+E9WqcoPWO5sHkAO0mYwGJDTwIKysOOcMPrQ7g4ta cgZqRm+8L40GIBDP4lC95hryiFriui4GgqEk74cX0RearQVcu/fZv0jdkebEovrh3S5w QOW0o82Y4quszQIyb2K9ghJYZIrSe3PXLdd0UL8taINAjjHr3PxIvAtZjMm9fwuvmIwe /pGplvmZGDlkOkwfcbkOgZxiY5LuPGM+0Y7Csf5cfKX1JDQKjhiTmMaZmmETXFKVnT/9 L7qYG3+8mCXHRtjWiQzM1HZx/jwM0EtEMLuuWOCVIjV1GpewSlC8w+BMGxy7y1na56NG S+cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rWq4EIZLBdjUFDSSQaVD1PvQUVhVWlX38rMGrIxZmlM=; b=Gs++ZQnWHUBEhSiqStg3IDneHkMC8Vobvf3xKjn8m5nxPEoigNTkL8/fn/wikAATFi ABJjyDDhYMAMIQ7gtjiz1dRuCANMMylfQ/+GWe/FwnSpiNKup45hcPjh3AhttsEail9k qKKEeVh2BWOoa6Trj0AS9WeJPEO9VCmPdSBXNE2Jk3dUcCUR+4dqhs8v2hJGSmgOWmgr JsPJ4hTdf20wfJpdRp4/56dVmLIa4e8xsRD+VX1Mq+dKsoKG/Wgx1tjmY8JhIti5Ml5n akIpxgm4H8EbUntV4iJXfZ+NHAEII4fdFPWyzJK43rvpY75FYqdiBrg/pK1snuO5z7te 35GQ== X-Gm-Message-State: AOAM531/HmQPXu4SIfXBSxjrEwR5e0ZaYGP3iDUS8cF5eTYUCfy1dMfu nDnxQweYxnCpTdLUkv8CH5l3ZQ== X-Google-Smtp-Source: ABdhPJxVDvRwfMlc/6PaK6IE8voRoyyugVPW9/0sd4X8zJjnzLg8wrJ4D/LuejkqlVFimEpIiqR6Qw== X-Received: by 2002:adf:ed11:: with SMTP id a17mr3919828wro.197.1606397517455; Thu, 26 Nov 2020 05:31:57 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:31:56 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Maya Erez , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, netdev@vger.kernel.org Subject: [PATCH 01/17] wil6210: wmi: Correct misnamed function parameter 'ptr_' Date: Thu, 26 Nov 2020 13:31:36 +0000 Message-Id: <20201126133152.3211309-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Function parameter or member 'ptr_' not described in 'wmi_buffer_block' drivers/net/wireless/ath/wil6210/wmi.c:279: warning: Excess function parameter 'ptr' description in 'wmi_buffer_block' Cc: Maya Erez Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: wil6210@qti.qualcomm.com Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/wil6210/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c index 421aebbb49e54..8699f8279a8be 100644 --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -262,7 +262,7 @@ struct fw_map *wil_find_fw_mapping(const char *section) /** * Check address validity for WMI buffer; remap if needed * @wil: driver data - * @ptr: internal (linker) fw/ucode address + * @ptr_: internal (linker) fw/ucode address * @size: if non zero, validate the block does not * exceed the device memory (bar) * From patchwork Thu Nov 26 13:31:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933983 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5D57C64E7B for ; Thu, 26 Nov 2020 13:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9378A21D40 for ; Thu, 26 Nov 2020 13:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yggVGWPX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390100AbgKZNde (ORCPT ); Thu, 26 Nov 2020 08:33:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390142AbgKZNcA (ORCPT ); Thu, 26 Nov 2020 08:32:00 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24119C061A48 for ; Thu, 26 Nov 2020 05:32:00 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id a3so2411781wmb.5 for ; Thu, 26 Nov 2020 05:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AFvxbCSBD0dyE27qjUGJ2Xb0Ms2F6Ys3MDSISyE2R+M=; b=yggVGWPXHz3pJffklN/FeUMx+wBFcZjRvumVi8rpt68GuZDlqdSSGnhb5nyosks8Uv SzzGM/lUE5wPIhTQ8Rdy35FvaI0a8ZaR8KGW53v37OqdDHtFqXUgremy/v2WuKC368oQ t6pNnUyA8xklNSuZBUTWze0FsnYZ7e2CJ4lX/56T99+N1cuoXv/Nqk3Jalsk0o79qIM5 0QA65OqJzQ/b2pUNFXqIL62zwxHogADMu5Ei2Qtdc0o34mgD9+Xy7JnAerZR+BPfvMpI eow75CfVvfaArnG88cNaxdHuX/uw+6zauc3S7Q8EDYLXww8/AinOjfGSbX1qleNjTzET qyGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AFvxbCSBD0dyE27qjUGJ2Xb0Ms2F6Ys3MDSISyE2R+M=; b=ARDVIOZlTcqrQUUvdOIKuxB2ShJpN3cNuXMhBCnqN6ETi70k8LFvxKII8SvHL8k7C9 TJYtkECkhOUIal6NG+33pOc7uWllqrsfPK9Ecd+iAqT1znluBakwuxBrpkHO2iUaxsZI cEXx1Onh7D36SS+H/p98KhcbXGeYZ+WoSmdaYJ2oulNPiMgtFqSQFg0LygIGjWuz0Me5 /Kfjf55FE9/FhHooeBNeIL1CwtvlwbmCzgVlxxtmltb2poKsOg8O0isYyRdb7WSAIl/i 6AYmPdI7TXHOSW5gCZtxILMMETqzOpKt9DZ7o871W6+7jEw7Iyphsqlayc3957als9QL qKew== X-Gm-Message-State: AOAM531ViZSauEvjgi2/JEaWAbQF1RkJxWfV/PrqUzEfTx9gwinuwRhw 2ADcAO8/JsucrAaYBkdY9Rdujw== X-Google-Smtp-Source: ABdhPJwT9ejnX73uvccj3LnjaNrr2kQXFa194LRYtXV1GrJlHXUmg2jbQeHhHnvbgFRHjV+Ou22TbA== X-Received: by 2002:a05:600c:2601:: with SMTP id h1mr3467502wma.35.1606397518856; Thu, 26 Nov 2020 05:31:58 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:31:58 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 02/17] iwlwifi: mvm: rs: Demote non-conformant function documentation headers Date: Thu, 26 Nov 2020 13:31:37 +0000 Message-Id: <20201126133152.3211309-3-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Also add documentation for 'mvm'. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/mvm/rs.c:400: warning: cannot understand function prototype: 'const u16 expected_tpt_legacy[IWL_RATE_COUNT] = ' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'mvm' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'tbl' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'scale_index' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'attempts' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'successes' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:684: warning: Function parameter or member 'window' not described in '_rs_collect_tx_data' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2677: warning: duplicate section name 'NOTE' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'mvm' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'sta' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'lq_sta' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:2682: warning: Function parameter or member 'band' not described in 'rs_initialize_lq' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'mvm' not described in 'rs_program_fix_rate' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:3761: warning: Function parameter or member 'lq_sta' not described in 'rs_program_fix_rate' drivers/net/wireless/intel/iwlwifi/mvm/rs.c:4213: warning: Function parameter or member 'mvm' not described in 'iwl_mvm_tx_protection' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/mvm/rs.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c index ed7382e7ea177..91b6541d579f5 100644 --- a/drivers/net/wireless/intel/iwlwifi/mvm/rs.c +++ b/drivers/net/wireless/intel/iwlwifi/mvm/rs.c @@ -386,7 +386,7 @@ static void rs_fill_lq_cmd(struct iwl_mvm *mvm, const struct rs_rate *initial_rate); static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search); -/** +/* * The following tables contain the expected throughput metrics for all rates * * 1, 2, 5.5, 11, 6, 9, 12, 18, 24, 36, 48, 54, 60 MBits @@ -396,7 +396,6 @@ static void rs_stay_in_table(struct iwl_lq_sta *lq_sta, bool force_search); * CCK rates are only valid in legacy table and will only be used in G * (2.4 GHz) band. */ - static const u16 expected_tpt_legacy[IWL_RATE_COUNT] = { 7, 13, 35, 58, 40, 57, 72, 98, 121, 154, 177, 186, 0, 0, 0 }; @@ -670,7 +669,7 @@ static s32 get_expected_tpt(struct iwl_scale_tbl_info *tbl, int rs_index) return 0; } -/** +/* * rs_collect_tx_data - Update the success/failure sliding window * * We keep a sliding window of the last 62 packets transmitted @@ -2667,7 +2666,7 @@ void rs_update_last_rssi(struct iwl_mvm *mvm, } } -/** +/* * rs_initialize_lq - Initialize a station's hardware rate table * * The uCode's station table contains a table of fallback rates @@ -3756,7 +3755,7 @@ int rs_pretty_print_rate(char *buf, int bufsz, const u32 rate) } #ifdef CONFIG_MAC80211_DEBUGFS -/** +/* * Program the device to use fixed rate for frame transmit * This is for debugging/testing only * once the device start use fixed rate, we need to reload the module @@ -4211,6 +4210,7 @@ static int rs_drv_tx_protection(struct iwl_mvm *mvm, struct iwl_mvm_sta *mvmsta, /** * iwl_mvm_tx_protection - ask FW to enable RTS/CTS protection + * @mvm: The mvm component * @mvmsta: The station * @enable: Enable Tx protection? */ From patchwork Thu Nov 26 13:31:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933953 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 498FEC64E8A for ; Thu, 26 Nov 2020 13:32:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02899206F7 for ; Thu, 26 Nov 2020 13:32:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xBOLAMT2" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390182AbgKZNcD (ORCPT ); Thu, 26 Nov 2020 08:32:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57030 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390164AbgKZNcB (ORCPT ); Thu, 26 Nov 2020 08:32:01 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 644D7C0617A7 for ; Thu, 26 Nov 2020 05:32:01 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id k14so2177164wrn.1 for ; Thu, 26 Nov 2020 05:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pe1vvImQ7xpypNGQYr/8kYE+GlHAALRJwr38y3BS0kA=; b=xBOLAMT2rxgj5d8ZVuygANtH/u7cqIQ2rtvXsxN80c1/PNXJdJuE9AHeYuk4sIxvv3 qTwwKuam/qGYC1DCc6FmQ04FVDKi77XAw+D665o0Gr7JSzyerUsJPUwMUM+vrFEPMPeG Wdr266+x9VNUdOvWvukF8kT/hm3/HkIL1IoirrPMVNeJKDGMU+E3QlsY43rOkgsQs6U9 Z3nNnponPf30Euwdd855q9CAUxoieKkGed0HvGZKvDHSytU73fZEnXu3tAfC4jenSXJT LoQVXsKBhb4YIMu9sIIV1/VwJAHxOFcDkBpTLvJXMX70Z0QyJZQMHM3tQwnW5jmv4OwX ES3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pe1vvImQ7xpypNGQYr/8kYE+GlHAALRJwr38y3BS0kA=; b=GI0XveVVHOe/e3huoIVXjFZZYqk03GjuLkftQJIpUQtkDFWbNGZf67FXTITpjDbAwm nQjTpN/wjN3JGrsERnPDRkVkrYsj7wVL/RuaQPe6Vzl0juRHpUqPv+q3mCICDXNAVG66 iktDMT8u+/zZzN+7V1j89214PJDcEje395GWzo515CHDR7r1GP9gx/bbvzbcJmaZOB7c itnKZgcDCJXG4KGhykXM54YgAQ3W1Dw5xQNfv8Bo9wC6CF7+mp2Bt4vGSrYacYLJ8VTS LVz5GQ4VJhCBGDgIrasZBLyDanxyWhf5gUh/IsfFw1Z6XJ78UI5sZ6s9Y2K8lnF0cj5m JDIw== X-Gm-Message-State: AOAM531LkrKu0JpZB/hP6aPIj9pV1ijnn/bT6PLXoj4lRqPJRpsuv69x EqDBduw+Ugspl7boE2lq2JrOTA== X-Google-Smtp-Source: ABdhPJxU0k27+S9FFyEpO4PYw+TEqfEtY7HcfAz7bX3DOUuHdz/ZMMuwnj2b8t9DmNE6pxyhUoIWbA== X-Received: by 2002:a5d:474f:: with SMTP id o15mr3963541wrs.100.1606397520142; Thu, 26 Nov 2020 05:32:00 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:31:59 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 03/17] ath9k: ar9330_1p1_initvals: Remove unused const variable 'ar9331_common_tx_gain_offset1_1' Date: Thu, 26 Nov 2020 13:31:38 +0000 Message-Id: <20201126133152.3211309-4-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h:1013:18: warning: ‘ar9331_common_tx_gain_offset1_1’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h b/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h index 29479afbc4f10..3e783fc13553b 100644 --- a/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9330_1p1_initvals.h @@ -1010,11 +1010,4 @@ static const u32 ar9331_common_rx_gain_1p1[][2] = { {0x0000a1fc, 0x00000296}, }; -static const u32 ar9331_common_tx_gain_offset1_1[][1] = { - {0x00000000}, - {0x00000003}, - {0x00000000}, - {0x00000000}, -}; - #endif /* INITVALS_9330_1P1_H */ From patchwork Thu Nov 26 13:31:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933977 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD271C64E90 for ; Thu, 26 Nov 2020 13:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 78EB3206F7 for ; Thu, 26 Nov 2020 13:33:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Aw2WYKq1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390207AbgKZNcF (ORCPT ); Thu, 26 Nov 2020 08:32:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390187AbgKZNcE (ORCPT ); Thu, 26 Nov 2020 08:32:04 -0500 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AF90C0613D4 for ; Thu, 26 Nov 2020 05:32:02 -0800 (PST) Received: by mail-wm1-x344.google.com with SMTP id a3so2411918wmb.5 for ; Thu, 26 Nov 2020 05:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L4fJoUFxGOk+wlfr5ygIh+H6VB2oPqLC6DAqdYBw8oE=; b=Aw2WYKq1L/griid++8JF9wR9uLQT6UtxMjUKV9cH/VDrZrkFV8Ja738dkzE3vgDHRR 7N+bYJQ0do35QUMtouhdzFDaHlk+UkuTp3kWnJ3vf2UfN1uV/ieLrCxa6fgVzASC9tij Y3i+VFWMTUw+kBS2HUvxKUx8H0ub0PABDw1CWOhBihutsU18bfD4eQ6l+pZJRCYAmcMy H76zBUVnMykjeRjNuVb6MZhKQC92kQVZgErGOEga/sOInBG8+O0tvVuRqypGPRCCEUKn 6b9Y6Ql6awQ7JfnvPC0VF0EP9jlvn6E10/0WCyxbyYdCfOvOKSV89ubkxdzbs6OUfxNZ cIRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L4fJoUFxGOk+wlfr5ygIh+H6VB2oPqLC6DAqdYBw8oE=; b=b1p7e4S6LJM6D4N8Yt2Loe7kKQNccGPN7nIlO0fDfGIndv/12XpCbbQltffoHQ6n+m /3M6SLb5k2e8n5FayiP1zKu9YDh0toqR4O01n4JkGEtAyr4XCiN0c+E5/FhadD5yDMWo EB0PdT5wIosBzswfjsuc52X53vJcf8oc77E3zMcOeGioApvQ9YDnkXmDsn4loUbxLZLm Ov7qNcEkTwCh3Cy6eXl0hMkTukB+vMD0XB5WKwr1kgg75SDd27tFhjBMaX9BMb/0rfMH uoPA2jaGJfGw3CuQzk9SmDAHS0frbN3HRLcrOrhGgiBXva0Ym3uCFJdedwfGlSCaFEC2 gG5g== X-Gm-Message-State: AOAM53255oStn4vsV9GPxBm7rhtMzWV6JynQa7LIbUoYz06IgiuqF2Hv 5FwXbSI6yORLhCL2omKRc6gfnQ== X-Google-Smtp-Source: ABdhPJy97q3E2AwuqJAG4sXcv+kfnq8gVuIPFYr/QoI5SgFTD5S88BxH+XNiZZqoBdHXgyoC4KLr3g== X-Received: by 2002:a1c:2d47:: with SMTP id t68mr3494436wmt.148.1606397521363; Thu, 26 Nov 2020 05:32:01 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:00 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 04/17] ath9k: ar9340_initvals: Remove unused const variable 'ar9340Modes_ub124_tx_gain_table_1p0' Date: Thu, 26 Nov 2020 13:31:39 +0000 Message-Id: <20201126133152.3211309-5-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9340_initvals.h:624:18: warning: ‘ar9340Modes_ub124_tx_gain_table_1p0’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar9340_initvals.h | 101 ------------------ 1 file changed, 101 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9340_initvals.h b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h index 2eb163fc1c18f..3da4ea564148c 100644 --- a/drivers/net/wireless/ath/ath9k/ar9340_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9340_initvals.h @@ -621,107 +621,6 @@ static const u32 ar9340Modes_high_ob_db_tx_gain_table_1p0[][5] = { {0x00016448, 0x8e481666, 0x8e481666, 0x8e481266, 0x8e481266}, }; -static const u32 ar9340Modes_ub124_tx_gain_table_1p0[][5] = { - /* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */ - {0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8005, 0xd00a8005}, - {0x00009820, 0x206a022e, 0x206a022e, 0x206a00ae, 0x206a00ae}, - {0x00009830, 0x0000059c, 0x0000059c, 0x0000059c, 0x0000059c}, - {0x00009e10, 0x7ec88d2e, 0x7ec88d2e, 0x7ec82d2e, 0x7ec82d2e}, - {0x0000a2dc, 0xfef5d402, 0xfef5d402, 0xfdab5b52, 0xfdab5b52}, - {0x0000a2e0, 0xfe896600, 0xfe896600, 0xfd339c84, 0xfd339c84}, - {0x0000a2e4, 0xff01f800, 0xff01f800, 0xfec3e000, 0xfec3e000}, - {0x0000a2e8, 0xfffe0000, 0xfffe0000, 0xfffc0000, 0xfffc0000}, - {0x0000a410, 0x000050d8, 0x000050d8, 0x000050d9, 0x000050d9}, - {0x0000a500, 0x00002220, 0x00002220, 0x00000000, 0x00000000}, - {0x0000a504, 0x04002222, 0x04002222, 0x04000002, 0x04000002}, - {0x0000a508, 0x09002421, 0x09002421, 0x08000004, 0x08000004}, - {0x0000a50c, 0x0d002621, 0x0d002621, 0x0b000200, 0x0b000200}, - {0x0000a510, 0x13004620, 0x13004620, 0x0f000202, 0x0f000202}, - {0x0000a514, 0x19004a20, 0x19004a20, 0x11000400, 0x11000400}, - {0x0000a518, 0x1d004e20, 0x1d004e20, 0x15000402, 0x15000402}, - {0x0000a51c, 0x21005420, 0x21005420, 0x19000404, 0x19000404}, - {0x0000a520, 0x26005e20, 0x26005e20, 0x1b000603, 0x1b000603}, - {0x0000a524, 0x2b005e40, 0x2b005e40, 0x1f000a02, 0x1f000a02}, - {0x0000a528, 0x2f005e42, 0x2f005e42, 0x23000a04, 0x23000a04}, - {0x0000a52c, 0x33005e44, 0x33005e44, 0x26000a20, 0x26000a20}, - {0x0000a530, 0x38005e65, 0x38005e65, 0x2a000e20, 0x2a000e20}, - {0x0000a534, 0x3c005e69, 0x3c005e69, 0x2e000e22, 0x2e000e22}, - {0x0000a538, 0x40005e6b, 0x40005e6b, 0x31000e24, 0x31000e24}, - {0x0000a53c, 0x44005e6d, 0x44005e6d, 0x34001640, 0x34001640}, - {0x0000a540, 0x49005e72, 0x49005e72, 0x38001660, 0x38001660}, - {0x0000a544, 0x4e005eb2, 0x4e005eb2, 0x3b001861, 0x3b001861}, - {0x0000a548, 0x53005f12, 0x53005f12, 0x3e001a81, 0x3e001a81}, - {0x0000a54c, 0x59025eb5, 0x59025eb5, 0x42001a83, 0x42001a83}, - {0x0000a550, 0x5e025f12, 0x5e025f12, 0x44001c84, 0x44001c84}, - {0x0000a554, 0x61027f12, 0x61027f12, 0x48001ce3, 0x48001ce3}, - {0x0000a558, 0x6702bf12, 0x6702bf12, 0x4c001ce5, 0x4c001ce5}, - {0x0000a55c, 0x6b02bf14, 0x6b02bf14, 0x50001ce9, 0x50001ce9}, - {0x0000a560, 0x6f02bf16, 0x6f02bf16, 0x54001ceb, 0x54001ceb}, - {0x0000a564, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a568, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a56c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a570, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a574, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a578, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a57c, 0x6f02bf16, 0x6f02bf16, 0x56001eec, 0x56001eec}, - {0x0000a580, 0x00802220, 0x00802220, 0x00800000, 0x00800000}, - {0x0000a584, 0x04802222, 0x04802222, 0x04800002, 0x04800002}, - {0x0000a588, 0x09802421, 0x09802421, 0x08800004, 0x08800004}, - {0x0000a58c, 0x0d802621, 0x0d802621, 0x0b800200, 0x0b800200}, - {0x0000a590, 0x13804620, 0x13804620, 0x0f800202, 0x0f800202}, - {0x0000a594, 0x19804a20, 0x19804a20, 0x11800400, 0x11800400}, - {0x0000a598, 0x1d804e20, 0x1d804e20, 0x15800402, 0x15800402}, - {0x0000a59c, 0x21805420, 0x21805420, 0x19800404, 0x19800404}, - {0x0000a5a0, 0x26805e20, 0x26805e20, 0x1b800603, 0x1b800603}, - {0x0000a5a4, 0x2b805e40, 0x2b805e40, 0x1f800a02, 0x1f800a02}, - {0x0000a5a8, 0x2f805e42, 0x2f805e42, 0x23800a04, 0x23800a04}, - {0x0000a5ac, 0x33805e44, 0x33805e44, 0x26800a20, 0x26800a20}, - {0x0000a5b0, 0x38805e65, 0x38805e65, 0x2a800e20, 0x2a800e20}, - {0x0000a5b4, 0x3c805e69, 0x3c805e69, 0x2e800e22, 0x2e800e22}, - {0x0000a5b8, 0x40805e6b, 0x40805e6b, 0x31800e24, 0x31800e24}, - {0x0000a5bc, 0x44805e6d, 0x44805e6d, 0x34801640, 0x34801640}, - {0x0000a5c0, 0x49805e72, 0x49805e72, 0x38801660, 0x38801660}, - {0x0000a5c4, 0x4e805eb2, 0x4e805eb2, 0x3b801861, 0x3b801861}, - {0x0000a5c8, 0x53805f12, 0x53805f12, 0x3e801a81, 0x3e801a81}, - {0x0000a5cc, 0x59825eb2, 0x59825eb2, 0x42801a83, 0x42801a83}, - {0x0000a5d0, 0x5e825f12, 0x5e825f12, 0x44801c84, 0x44801c84}, - {0x0000a5d4, 0x61827f12, 0x61827f12, 0x48801ce3, 0x48801ce3}, - {0x0000a5d8, 0x6782bf12, 0x6782bf12, 0x4c801ce5, 0x4c801ce5}, - {0x0000a5dc, 0x6b82bf14, 0x6b82bf14, 0x50801ce9, 0x50801ce9}, - {0x0000a5e0, 0x6f82bf16, 0x6f82bf16, 0x54801ceb, 0x54801ceb}, - {0x0000a5e4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5e8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5ec, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5f0, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5f4, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5f8, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x0000a5fc, 0x6f82bf16, 0x6f82bf16, 0x56801eec, 0x56801eec}, - {0x00016044, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4}, - {0x00016048, 0x8e480086, 0x8e480086, 0x8e480086, 0x8e480086}, - {0x00016444, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4, 0x03b6d2e4}, - {0x00016448, 0x8e480086, 0x8e480086, 0x8e480086, 0x8e480086}, - {0x0000a600, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a604, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a608, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a60c, 0x00000000, 0x00000000, 0x00000000, 0x00000000}, - {0x0000a610, 0x00804000, 0x00804000, 0x00000000, 0x00000000}, - {0x0000a614, 0x00804201, 0x00804201, 0x01404000, 0x01404000}, - {0x0000a618, 0x0280c802, 0x0280c802, 0x01404501, 0x01404501}, - {0x0000a61c, 0x0280ca03, 0x0280ca03, 0x02008501, 0x02008501}, - {0x0000a620, 0x04c15104, 0x04c15104, 0x0280ca03, 0x0280ca03}, - {0x0000a624, 0x04c15305, 0x04c15305, 0x03010c04, 0x03010c04}, - {0x0000a628, 0x04c15305, 0x04c15305, 0x04014c04, 0x04014c04}, - {0x0000a62c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a630, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a634, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a638, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000a63c, 0x04c15305, 0x04c15305, 0x04015005, 0x04015005}, - {0x0000b2dc, 0xfef5d402, 0xfef5d402, 0xfdab5b52, 0xfdab5b52}, - {0x0000b2e0, 0xfe896600, 0xfe896600, 0xfd339c84, 0xfd339c84}, - {0x0000b2e4, 0xff01f800, 0xff01f800, 0xfec3e000, 0xfec3e000}, - {0x0000b2e8, 0xfffe0000, 0xfffe0000, 0xfffc0000, 0xfffc0000}, -}; - static const u32 ar9340Modes_low_ob_db_tx_gain_table_1p0[][5] = { /* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */ {0x0000a2dc, 0x0380c7fc, 0x0380c7fc, 0x03aaa352, 0x03aaa352}, From patchwork Thu Nov 26 13:31:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933955 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 484B4C64E90 for ; Thu, 26 Nov 2020 13:32:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF83D221E9 for ; Thu, 26 Nov 2020 13:32:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="kjVrW8dh" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390238AbgKZNcH (ORCPT ); Thu, 26 Nov 2020 08:32:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390162AbgKZNcF (ORCPT ); Thu, 26 Nov 2020 08:32:05 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B47D3C061A48 for ; Thu, 26 Nov 2020 05:32:03 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id i2so2158207wrs.4 for ; Thu, 26 Nov 2020 05:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+vFZOkUefLCl7nJCk+wo/i30e9zgv5BRI5+nbv5AY5Q=; b=kjVrW8dhiO8nZ52TeUAv9+gDBak/v52Pu4Jx7mojNyf/YW4ukLxMS81piFZUzkjm8U IDUSfX430q01/MpPLislyS6R3lSNeyE8dKk7wYA69rH+T+JFkps+XUA4JEw+BhX24SY0 Kzob0dGLZsEiEZq4ZPMJCLt9VyY6etSnfvwBJElAznIPXmBwn4h+fpzGyjGBvfuM+FT9 JbqtrS5QGq019isdVJgoT0GsdzJsf/SvSWXeTdqi0LX+QGOhapAgkXfJTSC9M6ipuUDb KR7y+Dcv1NV3fQsG4zumxkGKSjRuE/XcF3fTVK9mir/IKGn1bW/h8f03h9FxyN6Gpcpb QoPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+vFZOkUefLCl7nJCk+wo/i30e9zgv5BRI5+nbv5AY5Q=; b=ZFi+Hz7L7vyt7fLIkSS0LO505dHR35r8wy+1dO2QqkPh3dZlOwvd/wNfnH5nW8fZ47 i2ROBendYiz6I6vidEQ6Lh7lvhNYZC4lmlAp2P0uDqjJNHC+2apbXQ4BADPbA/vNlRqo 36B1sCxAZUgAwx5pXDOcX7G297EAnOzJYQ7f6sCB9uQ8WLUp502A7efjbRlpshUFRCrE ndm5sbIS2U6+Ure3aO8WhPvPFPY5EgdQmegdaNV/PTnHRdeAKzbhCMbgoYlO1MJMwYL+ n9u/8zOOLv6wYgJekcag50B4cCrv7GE9XnyRau+R7indXXnfx+MZAAzzZUMi3y0YrZ7m rdlg== X-Gm-Message-State: AOAM5307WP2WGR04cw5oyTeGSzliAE7eTSlaCTC0WnTCgmdeVwftbrnx 7un6Yywoy+2LmTbn0IoEcx+kiG7+nCFTM9yV X-Google-Smtp-Source: ABdhPJzc142GrUm38WbUb+V8FN+5I7D047T9oeIlEft7/95j5iqGh5CGV/eDsji1tke2f7iX62RrFQ== X-Received: by 2002:a5d:654b:: with SMTP id z11mr3804664wrv.291.1606397522484; Thu, 26 Nov 2020 05:32:02 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:01 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 05/17] ath9k: ar9485_initvals: Remove unused const variable 'ar9485_fast_clock_1_1_baseband_postamble' Date: Thu, 26 Nov 2020 13:31:40 +0000 Message-Id: <20201126133152.3211309-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9485_initvals.h:1009:18: warning: ‘ar9485_fast_clock_1_1_baseband_postamble’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/ar9485_initvals.h | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9485_initvals.h b/drivers/net/wireless/ath/ath9k/ar9485_initvals.h index bdf6f107f6f1e..4afe52c0456e9 100644 --- a/drivers/net/wireless/ath/ath9k/ar9485_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9485_initvals.h @@ -1006,13 +1006,6 @@ static const u32 ar9485_1_1_soc_preamble[][2] = { {0x00007048, 0x00000002}, }; -static const u32 ar9485_fast_clock_1_1_baseband_postamble[][3] = { - /* Addr 5G_HT20 5G_HT40 */ - {0x00009e00, 0x03721821, 0x03721821}, - {0x0000a230, 0x0000400b, 0x00004016}, - {0x0000a254, 0x00000898, 0x00001130}, -}; - static const u32 ar9485_1_1_baseband_postamble[][5] = { /* Addr 5G_HT20 5G_HT40 2G_HT40 2G_HT20 */ {0x00009810, 0xd00a8005, 0xd00a8005, 0xd00a8005, 0xd00a8005}, From patchwork Thu Nov 26 13:31:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933979 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1CFC8301C for ; Thu, 26 Nov 2020 13:33:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 91587206F7 for ; Thu, 26 Nov 2020 13:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pOmWFkUH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390219AbgKZNdK (ORCPT ); Thu, 26 Nov 2020 08:33:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390220AbgKZNcG (ORCPT ); Thu, 26 Nov 2020 08:32:06 -0500 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB4CBC0617A7 for ; Thu, 26 Nov 2020 05:32:04 -0800 (PST) Received: by mail-wm1-x341.google.com with SMTP id d142so2166428wmd.4 for ; Thu, 26 Nov 2020 05:32:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=64CEfunw0Swc50bQt2+cwn7fqQh5uT3oHRs6EoyWU9E=; b=pOmWFkUHC7CzRoW6X95WZ7ZM6K89FTfon68au1KVLJvq43SYoT3PggrU+fCWC+BxVH joJHsp+kLds5GXyCIlQpDs/tY4cvnuUbK2ECYQbpUifxbJelCJPq/w//4Xq1JuObVNYb MdYyJpzW0GQ9FGIPPexJbsh/N208a2/aeozAj8MHCqT5TsrIMrxUGn1dgeandT/+xCSI l/P/bXaz6rU+bvXzM17w22rr9WJg+xhmZVixK+35pOMEDeoAAx23u7OQ3/T9w5tnSnYH VcC3D2I1mato16v/TV4NnMZ78yZy9TtnKHNwc6zS0O8bA1NWsBEp8kzFjxLezNmeiETj lx1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=64CEfunw0Swc50bQt2+cwn7fqQh5uT3oHRs6EoyWU9E=; b=eSRZy1jxZ7hCd4Rr60/QmNBrnu7evWHrmjJSbmGSQiyCtKyZwFiSrBS+w9a6C6UzS9 VCdddL9hfDbkE54zpY534Zm37eaTPgopV9vrPTvj31bSC+z305aLlDDiMeGd2pxxSM7G dOVHo0AkfccUljIBwIYXj4rB5cYRcebLiMWRuguQ14z4QhBU/5MN/GnxjwrSNzUmEQlb ZUMkXiyBsqf2ysw+4Vqr3BqM0OqwjvApdrAtId618TyZGH7+faVLIuk+DkcgkHcbR6PU 6SCoroTAAOfVOlFOEjdeiqdeEG8n36B1k7r1DUVuChHAYBVtg8brupPvl7gSceBwphg4 4/Nw== X-Gm-Message-State: AOAM5305I8HNKUVc1s8aF+NVm+fatdil4quTqJ4O1vOSwzd0cf7Zoxpx zowHpwE31CfQGnuI/GwNkcSSBA== X-Google-Smtp-Source: ABdhPJyVRqv04VLkxlqsEA0K2I9YfA9rHfVGjOv/CXJMIAfm+/iU9Su9wEC8IGTawXz3owjyVgkMFg== X-Received: by 2002:a1c:6382:: with SMTP id x124mr3408119wmb.46.1606397523570; Thu, 26 Nov 2020 05:32:03 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:02 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 06/17] ath9k: ar9003_2p2_initvals: Remove unused const variables Date: Thu, 26 Nov 2020 13:31:41 +0000 Message-Id: <20201126133152.3211309-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1734:18: warning: ‘ar9300PciePhy_clkreq_disable_L1_2p2’ defined but not used [-Wunused-const-variable=] drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h:1727:18: warning: ‘ar9300PciePhy_clkreq_enable_L1_2p2’ defined but not used [-Wunused-const-variable=] Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/ath/ath9k/ar9003_2p2_initvals.h | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h index c07866a2fdf96..16d5c0c5e2a8d 100644 --- a/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h +++ b/drivers/net/wireless/ath/ath9k/ar9003_2p2_initvals.h @@ -1724,20 +1724,6 @@ static const u32 ar9300PciePhy_pll_on_clkreq_disable_L1_2p2[][2] = { {0x00004044, 0x00000000}, }; -static const u32 ar9300PciePhy_clkreq_enable_L1_2p2[][2] = { - /* Addr allmodes */ - {0x00004040, 0x0825365e}, - {0x00004040, 0x0008003b}, - {0x00004044, 0x00000000}, -}; - -static const u32 ar9300PciePhy_clkreq_disable_L1_2p2[][2] = { - /* Addr allmodes */ - {0x00004040, 0x0821365e}, - {0x00004040, 0x0008003b}, - {0x00004044, 0x00000000}, -}; - static const u32 ar9300_2p2_baseband_core_txfir_coeff_japan_2484[][2] = { /* Addr allmodes */ {0x0000a398, 0x00000000}, From patchwork Thu Nov 26 13:31:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933971 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1024FC8301D for ; Thu, 26 Nov 2020 13:33:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C9BDA21D46 for ; Thu, 26 Nov 2020 13:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fxFvY4F9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390430AbgKZNdL (ORCPT ); Thu, 26 Nov 2020 08:33:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390218AbgKZNcG (ORCPT ); Thu, 26 Nov 2020 08:32:06 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 21276C061A4F for ; Thu, 26 Nov 2020 05:32:06 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id g14so2126242wrm.13 for ; Thu, 26 Nov 2020 05:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xuBtucNK6orquLtJMKORaW0tLzjtm6vr9NLgmkKGSZ4=; b=fxFvY4F9TAI3WLouXVEDBCny/tfmKyGzUcAMYh+tZX60mwEb575ArQEYNr1as6rviJ b5iYC89cQ3hyCFHG7ZaehdrRYgrT6ouRF4gJ/jYIk3lXhlIIACIwxcmua1P/3CsedSTX m5mf8HS4rAwHshbiXkaE4dvZ8a1vJFTTjhOSJ5nijQendWJ/7lJ6iPOwW69wsFOBFNW8 rlsQlL5M1yPZwp+hIOslJDuJbVqYnwliaVqpCIZa6SI/9IV0Fa8qIe8e5pdUOMWbTUTX 1WOUoyCBbAZVcYxGie+kvw7PT0Ww8qc5rLjAS/1ykNx13GP7OOognTQk8j08i8iPRcfO 7d2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xuBtucNK6orquLtJMKORaW0tLzjtm6vr9NLgmkKGSZ4=; b=K4kyfL+RuFo1qnFaza5fn0kAZeTQBdKJDRQ6o10G8b9HbuQYsqna9oQneFx0pfrcot fUdrt0/CKVUrWBnbna5eeW+rSKPHkqJKeAEzw63mRPoBWKnoChSdmlDnw2UVVJTXgmpE vc9+1Gp1GZZwng2nBixPp36n1WgtEES5VD8HuPyiLQDXy/WgvYARBKzewjjRRYc6UuDj qScyry6cHkugEqT5X6SOFDznJ/nxCgDTsq7QMA1sImZDwNMwCs6s0FaIUjtqLoPMtRhy N32W3bfQwgKtueXiDlz3OxMdgMYF9viFMP2qSMXhCnz6my7jGv8TNcMGvW9i7RsDFdqa HVsg== X-Gm-Message-State: AOAM532gL60JihfwKWGNmhkOz8VMnPlrXFjVQnr4STsUyVNVNMph3DSX RzbnCLCxxedKP2fjhdQyv9KHHw== X-Google-Smtp-Source: ABdhPJxEqrNkgHGQvyOLo0FR6NpjjkFky++1qbEa/oplWQmxA4TLp1X2l26V0s1OnHiEeUtF4gnwCw== X-Received: by 2002:a05:6000:143:: with SMTP id r3mr3797328wrx.331.1606397524835; Thu, 26 Nov 2020 05:32:04 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:04 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 07/17] iwlwifi: iwl-eeprom-read: Demote one nonconformant function header Date: Thu, 26 Nov 2020 13:31:42 +0000 Message-Id: <20201126133152.3211309-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'trans' not described in 'iwl_read_eeprom' drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'eeprom' not described in 'iwl_read_eeprom' drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c:347: warning: Function parameter or member 'eeprom_size' not described in 'iwl_read_eeprom' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c index ad6dc4497437e..1b2d9fd82a3de 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-read.c @@ -335,7 +335,7 @@ static int iwl_find_otp_image(struct iwl_trans *trans, return -EINVAL; } -/** +/* * iwl_read_eeprom - read EEPROM contents * * Load the EEPROM contents from adapter and return it From patchwork Thu Nov 26 13:31:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933957 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3A06C64E7A for ; Thu, 26 Nov 2020 13:33:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CDFA206F7 for ; Thu, 26 Nov 2020 13:33:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="diSVxSAo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390267AbgKZNcK (ORCPT ); Thu, 26 Nov 2020 08:32:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390242AbgKZNcH (ORCPT ); Thu, 26 Nov 2020 08:32:07 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 974A5C061A48 for ; Thu, 26 Nov 2020 05:32:07 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id r3so2178463wrt.2 for ; Thu, 26 Nov 2020 05:32:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LgKtNmQfGnZeeFNwZJm+JSbHcTG8sEx1i9uktjmVfHw=; b=diSVxSAoA40tZEtS/HzleEtjZHtOlucT3xtLPjQTgjZqyNCONejvfwzDQ9rykhgSo/ EC3mKBZiW8Y5/3yHi2UXTIJGHUlJZWmhmGKEzoFG4WE77PAi2Gt1qssdtssc+4ye7qOY pOOJu38hmlttKJ/wu6A29AeM/dSRlCKiFap/M1FUM0A49ppUqc4MS/6/YZ7Ilmaon+3l ZykubvRyrnyBUVtXVW4XC2vYrPauBp/aPbGRvXo3xT80JNaEwaIuofRvLbFtOJdsF2Gb 6oJI+aIb0M4cuqnQcp21K4cd3cKvyCpJ8sim4c2daOi3LjPnapOS7eUQuEB9kOLB6Phn y6zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LgKtNmQfGnZeeFNwZJm+JSbHcTG8sEx1i9uktjmVfHw=; b=IHx4nah+fmNqyrB18IyaAEo4vq59Jy2rm6SBfc0Vgh9nQUDfyMyXyNwwExSlrIsWpN nmhDlJAa9u9xiHK1HEN4ymiu2x4F6XMOxm4kZphpSOklbzCrLV3p6H3p2Zmzz746uXcj vQogBYE15OhkQhBGEhgHU3SHna1hh0WKHM2w+lKjVb+b+07eGe7XAO8JtxupupKYKJHA wMtQXjmc0/CyNyqToS38wjdgFs4FNiAaYjgSz7RYWdFK7YjYSwl4/G8IaUUZ/ZxS1FaG z8FpXHzTITffzvHmpaWxb/x/1AeA6AbeR7Cp9GcF/9QqXufF89CdQGrACejusec/gRiu D8hg== X-Gm-Message-State: AOAM533n93kXql86sFLRh8LqdRpmExKGk/TsmHwwoCB/3QdjuETBaeHt 9VlCotjEUNzRGtEEEg4KFxLUxw== X-Google-Smtp-Source: ABdhPJxCIYT+lF7JbaW4XiyGU7BSoo+9JGKkKGnf0fEfWfYR7PXVvWXzcXpp+ZzvHC83M7okR4aAcQ== X-Received: by 2002:adf:e4d1:: with SMTP id v17mr3803758wrm.325.1606397526033; Thu, 26 Nov 2020 05:32:06 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:05 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 08/17] iwlwifi: iwl-eeprom-parse: Fix 'struct iwl_eeprom_enhanced_txpwr's header Date: Thu, 26 Nov 2020 13:31:43 +0000 Message-Id: <20201126133152.3211309-9-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c:340: warning: cannot understand function prototype: 'struct iwl_eeprom_enhanced_txpwr ' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- .../net/wireless/intel/iwlwifi/iwl-eeprom-parse.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c index cf7e2a9232e52..f29d5758c8dff 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c @@ -324,15 +324,15 @@ enum iwl_eeprom_enhanced_txpwr_flags { }; /** - * iwl_eeprom_enhanced_txpwr structure + * struct iwl_eeprom_enhanced_txpwr * @flags: entry flags * @channel: channel number - * @chain_a_max_pwr: chain a max power in 1/2 dBm - * @chain_b_max_pwr: chain b max power in 1/2 dBm - * @chain_c_max_pwr: chain c max power in 1/2 dBm + * @chain_a_max: chain a max power in 1/2 dBm + * @chain_b_max: chain b max power in 1/2 dBm + * @chain_c_max: chain c max power in 1/2 dBm * @delta_20_in_40: 20-in-40 deltas (hi/lo) - * @mimo2_max_pwr: mimo2 max power in 1/2 dBm - * @mimo3_max_pwr: mimo3 max power in 1/2 dBm + * @mimo2_max: mimo2 max power in 1/2 dBm + * @mimo3_max: mimo3 max power in 1/2 dBm * * This structure presents the enhanced regulatory tx power limit layout * in an EEPROM image. From patchwork Thu Nov 26 13:31:44 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933981 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE54C8301B for ; Thu, 26 Nov 2020 13:33:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EDCC206F7 for ; Thu, 26 Nov 2020 13:33:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zuKRkBMw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390413AbgKZNdB (ORCPT ); Thu, 26 Nov 2020 08:33:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57078 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390247AbgKZNcJ (ORCPT ); Thu, 26 Nov 2020 08:32:09 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBE12C0617A7 for ; Thu, 26 Nov 2020 05:32:08 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id k14so2177610wrn.1 for ; Thu, 26 Nov 2020 05:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NkVHgZnw6Lei6IsVvRK9pUiVE1+hhckfR+9Br4cSPrE=; b=zuKRkBMwy4QWvvpBfeIKLgYNHdWx20GaFtYVQXPS2ejG2VPOKyj03aNPOtjX+Fj0zi txJPDSzeDZUh8AxFzvuhREUkFOifNLME+G4mGIh1qsRZlj5ZKR4ZZ5TKLfU33wAjw49O WHNRmyDRN5QZytnQ0PNHwhnOaSyWjF+hyxH4DGD7epSjYqZRKDYoriPREbd1hMOTSQXz X39+Qobaoshhe8lrepXEoh9tQzPEaKyKazBTzHf8K6VTgHfQDPuKuB6Pt8ZRe8KKms2d tOq/lR/1+QXwebzXTbyIR41NGMNjl1b0m/NmtJh7lY4y8UPHc4VZST5te0Z0b/N2Qk3b ir4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NkVHgZnw6Lei6IsVvRK9pUiVE1+hhckfR+9Br4cSPrE=; b=P0NBK3oGf4WThRuRRl0KkYOVspCp0i7TPCtj5YqhtPb3lit5YwNvDBiUEudb/qS9Q6 0UJUz6k/7j7BbFWzk8RZiac+SiICs9fkOGzj0QRYxcNowxCXt3trxxbvEfOOAsByBj0V 5k3mn6N5coXqm0A21SOk6c1MTWFgKT2JL5ByRbasHCLX+WJSU3vYPjRDR8qeUcLtsFrb aK+luMcj26/+j3gS7xIH8ZI9E6lh9G9O+HfAgCe0xTxG4/K0HF8+4Mz2bGl5YJF3E57j wrWayLv7EKGhYW7oeeeL08Jc/nXEoqLupjZ0lSnNYIf6jDjetxCUfKPj5/op4P8b3R0K RdPA== X-Gm-Message-State: AOAM530EYlFRLe0GqcuzpVSC1B+btkY/4/ptQKKo9Wo7NjVQ2ZzJAdGK 0QplVHFkhO2Kybu/kvcJU9lo7Q== X-Google-Smtp-Source: ABdhPJyn9GVZS822IZ4IVqcmFXjk4DgG4O/j+RPa4fPxVi5KBq5hEWqL5eq0BDDYukOyzKbs/qm8dQ== X-Received: by 2002:adf:e801:: with SMTP id o1mr3900099wrm.3.1606397527585; Thu, 26 Nov 2020 05:32:07 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:06 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 09/17] ath: regd: Provide description for ath_reg_apply_ir_flags's 'reg' param Date: Thu, 26 Nov 2020 13:31:44 +0000 Message-Id: <20201126133152.3211309-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/regd.c:378: warning: Function parameter or member 'reg' not described in 'ath_reg_apply_ir_flags' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/regd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/regd.c b/drivers/net/wireless/ath/regd.c index bee9110b91f38..b2400e2417a55 100644 --- a/drivers/net/wireless/ath/regd.c +++ b/drivers/net/wireless/ath/regd.c @@ -360,6 +360,7 @@ ath_reg_apply_beaconing_flags(struct wiphy *wiphy, /** * ath_reg_apply_ir_flags() * @wiphy: the wiphy to use + * @reg: regulatory structure - used for country selection * @initiator: the regulatory hint initiator * * If no country IE has been received always enable passive scan From patchwork Thu Nov 26 13:31:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933973 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8C0BC83019 for ; Thu, 26 Nov 2020 13:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5482C21D46 for ; Thu, 26 Nov 2020 13:33:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KvBj7vPR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390405AbgKZNc4 (ORCPT ); Thu, 26 Nov 2020 08:32:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390250AbgKZNcK (ORCPT ); Thu, 26 Nov 2020 08:32:10 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27904C061A47 for ; Thu, 26 Nov 2020 05:32:10 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id e7so2159641wrv.6 for ; Thu, 26 Nov 2020 05:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OAyFBnkzLiaZhl/JnY/CqxtoMQBIM48e3o5HHcfQRSE=; b=KvBj7vPRJZnSo5P9Vrpd05dp/jHgMi246Xu6fMSd4mmudD6p0ToaXtzaOArSdCtl7I oNtRfXDD9BJijpm3RhSAjFAWn3uJy82DW34dQGky/LUOHTMpPEg1V3z5rY415++HISJF mza8MsVES2/1YXkXRnZYGcPi7xEJq/0AtxmNoDMGoXn2E9iTkrKR1TVYqlcQVZvAw694 E1OSTltME0XgOt4Zv1ETxpK6+CeSl0kMWVjJRyJUEE8Tg+XXs9mrLKTRmtm0YLRkMJn0 DhDaAl0VgrIJ2tgvTx9eC0fvGx3TRIcrglvOo7j9jlHPI86XURijwXBDXqcT3uxkuFD5 eqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OAyFBnkzLiaZhl/JnY/CqxtoMQBIM48e3o5HHcfQRSE=; b=eqoIsJz65/xO1KQKwwWpUWNnecY28EcJC/3vlI7WKIMGeIRUGEUdjN+aix9OUaq2IG DfYTIo6bs3X4wRhGF/IQp9k0N/Tcua+LzmUIv7EWv0NkX3o2XP9wOo/DxMK41ShenNxh yV4sNSTx2ffML0pAst1983LYNJmr2azuzdqC/bfU8PDXSPThR5/9t19bEVSVp849eSqq nweVtD7Ckxwr5YP9DFEgNfhKOBIaafIPrv0atVDFedEXfFEkONVa4aj8JZ9FuAd7+kdE 78yaTHQ/GmVEci8sFOHn9lRawX0oGySWPfGHem2o80mrKk/gqZ/kEDuijmYkl/CdGOZj XfPg== X-Gm-Message-State: AOAM533ZIKiyNmqzw4Zizg3Og1MUq/umXGRjXWM62AU96Jyxo0zevjvL E6Lnw6aM0HVVV+n564Dk0c85rNv9dxg7lALW X-Google-Smtp-Source: ABdhPJx4DWwdS4AQo1feaaXyk8LdNheDTjbG6QpSfvEBpKFfeL9xMvx2NQF9SO8N3aKOXvr8nvLBBw== X-Received: by 2002:a5d:4701:: with SMTP id y1mr3868307wrq.33.1606397528852; Thu, 26 Nov 2020 05:32:08 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:08 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, QCA ath9k Development , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 10/17] ath9k: ar5008_phy: Demote half completed function headers Date: Thu, 26 Nov 2020 13:31:45 +0000 Message-Id: <20201126133152.3211309-11-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'rfBuf' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'reg32' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'numBits' not described in 'ar5008_hw_phy_modify_rx_buffer' drivers/net/wireless/ath/ath9k/ar5008_phy.c:119: warning: Function parameter or member 'firstBit' not described in 'ar5008_hw_phy_modify_rx_buffer' Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/ar5008_phy.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/ar5008_phy.c b/drivers/net/wireless/ath/ath9k/ar5008_phy.c index 2fa30834a88db..6610d76131fa8 100644 --- a/drivers/net/wireless/ath/ath9k/ar5008_phy.c +++ b/drivers/net/wireless/ath/ath9k/ar5008_phy.c @@ -102,13 +102,8 @@ static void ar5008_write_bank6(struct ath_hw *ah, unsigned int *writecnt) REGWRITE_BUFFER_FLUSH(ah); } -/** +/* * ar5008_hw_phy_modify_rx_buffer() - perform analog swizzling of parameters - * @rfbuf: - * @reg32: - * @numBits: - * @firstBit: - * @column: * * Performs analog "swizzling" of parameters into their location. * Used on external AR2133/AR5133 radios. @@ -198,10 +193,8 @@ static void ar5008_hw_force_bias(struct ath_hw *ah, u16 synth_freq) ar5008_write_bank6(ah, ®_writes); } -/** +/* * ar5008_hw_set_channel - tune to a channel on the external AR2133/AR5133 radios - * @ah: atheros hardware structure - * @chan: * * For the external AR2133/AR5133 radios, takes the MHz channel value and set * the channel value. Assumes writes enabled to analog bus and bank6 register @@ -430,10 +423,8 @@ void ar5008_hw_cmn_spur_mitigate(struct ath_hw *ah, REG_WRITE(ah, AR_PHY_MASK2_P_61_45, tmp_mask); } -/** +/* * ar5008_hw_spur_mitigate - convert baseband spur frequency for external radios - * @ah: atheros hardware structure - * @chan: * * For non single-chip solutions. Converts to baseband spur frequency given the * input channel frequency and compute register settings below. From patchwork Thu Nov 26 13:31:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933969 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C9B1C83018 for ; Thu, 26 Nov 2020 13:33:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E296621D46 for ; Thu, 26 Nov 2020 13:33:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q8jkVen1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390005AbgKZNcu (ORCPT ); Thu, 26 Nov 2020 08:32:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390273AbgKZNcN (ORCPT ); Thu, 26 Nov 2020 08:32:13 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A2CAC061A52 for ; Thu, 26 Nov 2020 05:32:11 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id e7so2159691wrv.6 for ; Thu, 26 Nov 2020 05:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OcBd80NlVbn3uGSdfGXvocYKOP7aRNETXFKMl2YiPGc=; b=Q8jkVen12XCoRGnL4iPurJx+25LwQnN4rkU8WQh9kxbtbsrgsycqNffe2qOGBYR+7C Svfqh6UT2eGQdJXGyNyslkVr/NuOXoGtaDzSUcNQ3uptyIFnbW+fO3wzISfc1qaQsjJi 5vZlttAaVI5n5zE874WJack/ZatNl3cE9nZWW+B4v04noSvn3CuzseQtPkQTXoF5QSS9 eVRsopl+s0zomc541bDr63PewFZ8NVmVKt8HuY1l1P5/DW/m1U8JXu/MWptu1wjCpjwR abJII0TpdSoGv/qiXv3CZY+vSNLU8netmmGJxdMR4phDapNWTVDvBCXciVvU75IRIFcM 8i8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OcBd80NlVbn3uGSdfGXvocYKOP7aRNETXFKMl2YiPGc=; b=PSo8HJGbuFmET3qKfoP/M+eoomh6+P1opxg7yx7RwobraYUUbuboR/t5FIQN+E3QET WWtACdPV3I+lnXEomll4/a9WjyNyKG5FmjBY8cibbXl00Ek5kujXTTChhMsHr9aHg6js hTtDR+vE+NDeLq63Oi5yQWiaBDCG520NzSLDmqilDwwIzaI8zuDDiQ9v0KltrYWObCne 3md0oEM+FQSYwn1R+dk0TPpt63ZoO28BvBVahoxvrMEWRfduxrHp92RLKgVr0QdA66MJ 0k5MSqWvb3YaDsK17jLoD5aSAAhKRoMmL9Nhl9n/y8THuwDlCpGQamBcywkUAby5N+6H sz+w== X-Gm-Message-State: AOAM530y67qCIc1jaQzUk02w15FV7mPVsW1i6pTKC8ZCYpL8hHVcWEn2 s1MtQVZDh7o75Iw1IV0pihXB2Q== X-Google-Smtp-Source: ABdhPJwzkmAeb05I5tYzBStx7l2lOPLol3d3q+SROPVuSSvfSZQoLVYS2QldMxZ2jqVYNhsvFPWSTw== X-Received: by 2002:adf:fc49:: with SMTP id e9mr3872317wrs.31.1606397529940; Thu, 26 Nov 2020 05:32:09 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 11/17] ath: dfs_pattern_detector: Fix some function kernel-doc headers Date: Thu, 26 Nov 2020 13:31:46 +0000 Message-Id: <20201126133152.3211309-12-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/dfs_pattern_detector.c:34: warning: Function parameter or member 'region' not described in 'radar_types' drivers/net/wireless/ath/dfs_pattern_detector.c:141: warning: Function parameter or member 'region' not described in 'get_dfs_domain_radar_types' drivers/net/wireless/ath/dfs_pattern_detector.c:239: warning: Function parameter or member 'dpd' not described in 'channel_detector_get' drivers/net/wireless/ath/dfs_pattern_detector.c:239: warning: Function parameter or member 'freq' not described in 'channel_detector_get' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/dfs_pattern_detector.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/dfs_pattern_detector.c b/drivers/net/wireless/ath/dfs_pattern_detector.c index 0813473793df1..80390495ea250 100644 --- a/drivers/net/wireless/ath/dfs_pattern_detector.c +++ b/drivers/net/wireless/ath/dfs_pattern_detector.c @@ -23,7 +23,7 @@ /** * struct radar_types - contains array of patterns defined for one DFS domain - * @domain: DFS regulatory domain + * @region: regulatory DFS region * @num_radar_types: number of radar types to follow * @radar_types: radar types array */ @@ -133,8 +133,9 @@ static const struct radar_types *dfs_domains[] = { /** * get_dfs_domain_radar_types() - get radar types for a given DFS domain - * @param domain DFS domain - * @return radar_types ptr on success, NULL if DFS domain is not supported + * @region: regulatory DFS region + * + * Return value: radar_types ptr on success, NULL if DFS domain is not supported */ static const struct radar_types * get_dfs_domain_radar_types(enum nl80211_dfs_regions region) @@ -227,9 +228,10 @@ channel_detector_create(struct dfs_pattern_detector *dpd, u16 freq) /** * channel_detector_get() - get channel detector for given frequency - * @param dpd instance pointer - * @param freq frequency in MHz - * @return pointer to channel detector on success, NULL otherwise + * @dpd: DPD instance pointer + * @freq: freq frequency in MHz + * + * Return value: pointer to channel detector on success, NULL otherwise * * Return existing channel detector for the given frequency or return a * newly create one. From patchwork Thu Nov 26 13:31:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933959 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC049C63697 for ; Thu, 26 Nov 2020 13:33:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71944206F7 for ; Thu, 26 Nov 2020 13:33:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ghZh7I2g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390276AbgKZNcO (ORCPT ); Thu, 26 Nov 2020 08:32:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390243AbgKZNcN (ORCPT ); Thu, 26 Nov 2020 08:32:13 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 340ACC0617A7 for ; Thu, 26 Nov 2020 05:32:12 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id r3so2178719wrt.2 for ; Thu, 26 Nov 2020 05:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=E25/s2pmN1jYHUWPVit1bHGpEi6jEbn1M/6HbkBpU14=; b=ghZh7I2ge1DGcrfEdOn9QQfpf2S4lE4sRCwhWNIAbqweD0VZJ5aW2MLrQ3M1U5QPS9 T6pAJDHpuwlvjDev0DfaaajeTx6HZJNTfOUKd9jFcpLmhuAL4dw9pROU4JzLdRnr+nVS GnUTXR2iMIyQX0xlODvNhvrcaDWZD8EHhPCuwg89FEo57eHQygnDItIAA72Fld9+gV+1 8WLRLNXAldZgbUbhiUezL1qzrhdRbQ+cTRwl24Y0m/rTKj4QLL50sW9hWgfCjD7MvwNZ j2IZghwRkM2WeoEJnPoevWQ08nPVeZexIBWrboKaB0SEJKV5hJRvhLLSaNf+h9QNydzJ 0ZzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E25/s2pmN1jYHUWPVit1bHGpEi6jEbn1M/6HbkBpU14=; b=JCdBxYUdx0CfU2Gt/qwWt40JDY6LlQ1Jd3ItcO3LIK3/fL7ALK0G2YNCfYBsp/wlTl c92+s+HSFE29/jSBjv1UadQNzkjNkWoiUWAmpygC3shusVTOa59z93cTgLT76qwlwwnQ 52KQFzwdeQJuLeoOO03c1+f7tnhwvs/8orOkkoI49ynsYy3YyxLOgPWn7vDnxaZ+t1LT 0lM45rGf7u5+ozbQyMfIZlwjwKanrWsHJojZjec6HYiAiyg77czbbZcGDY4fMT8ZIC+m QqQeu3lKVKw7+1BRVJfUBEGS6xxEybsM2fbSrP4lCr0nLuDEqIKDvVsJNd4k5BZR0Rs2 0WDA== X-Gm-Message-State: AOAM530jAzjxewWh0u38W7uNc7oCnIohzsW1o3+jLdjU2jlJBxj3A64t kG4FPq/I3Hlqb9kRfiSSV/RYkA== X-Google-Smtp-Source: ABdhPJzGbGQMlN0MfvBGTz+3a9+vPyrAN5IP5cV1HGMaN8Z4XgGravGisSzs7eebgmtDEWS3ftsmfg== X-Received: by 2002:a5d:4d92:: with SMTP id b18mr3997659wru.260.1606397530996; Thu, 26 Nov 2020 05:32:10 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:10 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 12/17] ath: dfs_pri_detector: Demote zero/half completed kernel-doc headers Date: Thu, 26 Nov 2020 13:31:47 +0000 Message-Id: <20201126133152.3211309-13-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org There are only a couple of these and none of them are conformant. Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/dfs_pri_detector.c:39: warning: Function parameter or member 'head' not described in 'pulse_elem' drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'val' not described in 'pde_get_multiple' drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'fraction' not described in 'pde_get_multiple' drivers/net/wireless/ath/dfs_pri_detector.c:46: warning: Function parameter or member 'tolerance' not described in 'pde_get_multiple' Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/dfs_pri_detector.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/dfs_pri_detector.c b/drivers/net/wireless/ath/dfs_pri_detector.c index 05b0464c6b92c..d07c454c9c00d 100644 --- a/drivers/net/wireless/ath/dfs_pri_detector.c +++ b/drivers/net/wireless/ath/dfs_pri_detector.c @@ -29,18 +29,17 @@ struct ath_dfs_pool_stats global_dfs_pool_stats = {}; (MIN + PRI_TOLERANCE == MAX - PRI_TOLERANCE ? \ MIN + PRI_TOLERANCE : RUNTIME) -/** +/* * struct pulse_elem - elements in pulse queue - * @ts: time stamp in usecs */ struct pulse_elem { struct list_head head; u64 ts; }; -/** +/* * pde_get_multiple() - get number of multiples considering a given tolerance - * @return factor if abs(val - factor*fraction) <= tolerance, 0 otherwise + * Return value: factor if abs(val - factor*fraction) <= tolerance, 0 otherwise */ static u32 pde_get_multiple(u32 val, u32 fraction, u32 tolerance) { @@ -70,7 +69,7 @@ static u32 pde_get_multiple(u32 val, u32 fraction, u32 tolerance) return factor; } -/** +/* * DOC: Singleton Pulse and Sequence Pools * * Instances of pri_sequence and pulse_elem are kept in singleton pools to From patchwork Thu Nov 26 13:31:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933975 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91ADCC83014 for ; Thu, 26 Nov 2020 13:33:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3E8FF21D7E for ; Thu, 26 Nov 2020 13:33:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YznWFMVF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390277AbgKZNco (ORCPT ); Thu, 26 Nov 2020 08:32:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389857AbgKZNcN (ORCPT ); Thu, 26 Nov 2020 08:32:13 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99982C061A49 for ; Thu, 26 Nov 2020 05:32:13 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id x22so2152031wmc.5 for ; Thu, 26 Nov 2020 05:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=O6+Wy4iFDi+o50ayVR/RzqW4RGQ8DgYcSYBAfri+vWM=; b=YznWFMVFnrL3SHRm/qzlOafIUlBxNuihoIkIF7OlhyVT4+9ZeyqW9cBmOoMgt7pLyw T7hKhHI/quPJlot8cNCu+3XvV04sD7ckvL4b5ap7US4iZezEuhlRmDYVJ7SoTvOp5qLO 7xEHAZ4XtVDbwKVxICGgNttf3FdsRCRnwDnX9hvuMOXcBxi3c3uBNe/g9coM24UfPtcu K6yMTfbLfoEfj5XCdAEZJUvl9hNlWfTWyTwrBvrdPfpgoDLTKHB2/LFDnyF1GTiTZICM LqzrCSx4XukGOReSH+dhFXc+XF4vYzetV7RVAW1KexiAbrOKDlH6EAHyOsmRvV8BHtsZ cVEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=O6+Wy4iFDi+o50ayVR/RzqW4RGQ8DgYcSYBAfri+vWM=; b=k9LWcr8natEtiQxj6Aipeuw9ah7XPHb1vHP9pzGQsIJ1sFcV9VimYgv/BE2nVyc8I3 M4wxY/6X0YiB8iqijDjtwO/SehioytNILZy/SLANvpL8Zgr2UN8z6FwSScdHKSrjpFyb Hme8wZ5XJPh/TljKZSetqScGqt+6WqlDyEnkThqByS5exxzkU90RxyiqU/9DIIl398qz pTKwfhAgwbF36rjiLySEWxyr3UR2b62c/cKgqVDf7Bfwfp/Tv38emnaoo/GVA6rdww6k NIsF8G7uGYMUr2DxiwRq2UmSRjY07qdeuqR7UECZfjVTkRbBvAUkBEZMbGWA/7MfX8MM CKBA== X-Gm-Message-State: AOAM532UuBHERzjzIzn/T6KdNiCL8eM4XEveO9pONAgvARHufXP8EDZR +RB4D4rSv26bHsi1BORZIFTR/Q== X-Google-Smtp-Source: ABdhPJyuWp5WvGRoZZgxkoG9Oq62kxy/bru//LJwk7blbiQxWqPZlJHwxTOooVtaPi4kfalsFWJUAQ== X-Received: by 2002:a1c:ba0b:: with SMTP id k11mr3396548wmf.37.1606397532313; Thu, 26 Nov 2020 05:32:12 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:11 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 13/17] iwlwifi: iwl-phy-db: Add missing struct member description for 'trans' Date: Thu, 26 Nov 2020 13:31:48 +0000 Message-Id: <20201126133152.3211309-14-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c:97: warning: Function parameter or member 'trans' not described in 'iwl_phy_db' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c index ae83cfdb750e6..c9ce270ceee07 100644 --- a/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c +++ b/drivers/net/wireless/intel/iwlwifi/iwl-phy-db.c @@ -79,11 +79,11 @@ struct iwl_phy_db_entry { * * @cfg: phy configuration. * @calib_nch: non channel specific calibration data. - * @calib_ch: channel specific calibration data. * @n_group_papd: number of entries in papd channel group. * @calib_ch_group_papd: calibration data related to papd channel group. * @n_group_txp: number of entries in tx power channel group. * @calib_ch_group_txp: calibration data related to tx power chanel group. + * @trans: transport layer */ struct iwl_phy_db { struct iwl_phy_db_entry cfg; From patchwork Thu Nov 26 13:31:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933961 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A99CDC64E90 for ; Thu, 26 Nov 2020 13:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52B1A206F7 for ; Thu, 26 Nov 2020 13:33:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IbJpdC6i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390328AbgKZNcR (ORCPT ); Thu, 26 Nov 2020 08:32:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390307AbgKZNcP (ORCPT ); Thu, 26 Nov 2020 08:32:15 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF9ABC0617A7 for ; Thu, 26 Nov 2020 05:32:14 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id g14so2126712wrm.13 for ; Thu, 26 Nov 2020 05:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oATorMQPiNVEoXmBjgNPIPCMhMKpxL92yv6qxOrQmpk=; b=IbJpdC6i4+GdmwJWSs//6cgsZfjzcpBfm/L8Mjzto4Jo9wyyg4hd19km+JlwJHpINW f01TQrqs5iES89DzrbzYY85mFR3nKkhNsHBodFx+Jco8nrRyerd6sov+bZg9r2mlFHug IgAAGffYPn7HOkX8bvXFMUfSg87rfEKX+EcWEpydNBniojEX6wWMgDUdCIDAyu7T1nnK QsuwkRz+MNIThTRt0pTWKgi4WCYrXyr2s/AcXVl1QbpJmqyAjIenuuAEizVVVNY0+WLf +Cf5nadVwB7oYQkGGMCvCmH3pYNMFxbbLrLyxC4qJhpRiRz1UODFcA/iGtN/CwQafyDe PGTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oATorMQPiNVEoXmBjgNPIPCMhMKpxL92yv6qxOrQmpk=; b=OmBxg4jfvpJF/wntfMisQpSXMuiqAzvkU9uZSZMT3yrnx6vHyJyGVT/lLtp7i5HVAV b4Ao7DKebYakLfn05rTpRpzSed8hHxfmBDQSq6WNDQHR7gbm4bMqTXvKrU+Pzy5IJ225 +Hnw8j+fMLQQNMq9v9Kpwc1m2/uCRhyTUHAOf41ppkA/XRKudx9WvFFARkY/8f8819vV 6QzNPr3RYQRvMpfNYksMAuDM7EQ9PU/FGEACpgqH3h9ovTt3u82/4Rs0k3Jepb2x8oH0 lIk9cO8F7Cj1sOM4XQDZmHRqbPmoJASsaMkUFOmrsmdSNOIQmvom0dJo+H3cz4kMMkqR E95A== X-Gm-Message-State: AOAM5322WTBDymg1tZoDrfJWO0NjlgOHcC5HioDHx9dbZp0Ld1YYBsqG NOvrbbZvG/8D4yMM2pqvaSMfvA== X-Google-Smtp-Source: ABdhPJzar5pL8NJXSGoKYV0wnB0lIWqTVB12EIyFUGuvX5/YQrx4//RE3ORazZXu+kfKxp3kELmzfQ== X-Received: by 2002:adf:f1cb:: with SMTP id z11mr3926438wro.363.1606397533529; Thu, 26 Nov 2020 05:32:13 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:12 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , Shahar S Matityahu , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 14/17] iwlwifi: fw: dbg: Fix misspelling of 'reg_data' in function header Date: Thu, 26 Nov 2020 13:31:49 +0000 Message-Id: <20201126133152.3211309-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/fw/dbg.c:1932: warning: Function parameter or member 'reg_data' not described in 'iwl_dump_ini_mem' drivers/net/wireless/intel/iwlwifi/fw/dbg.c:1932: warning: Excess function parameter 'reg' description in 'iwl_dump_ini_mem' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Shahar S Matityahu Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c index ab4a8b942c81d..c0a180b496988 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/dbg.c @@ -1923,7 +1923,7 @@ struct iwl_dump_ini_mem_ops { * * @fwrt: fw runtime struct * @list: list to add the dump tlv to - * @reg: memory region + * @reg_data: memory region * @ops: memory dump operations */ static u32 iwl_dump_ini_mem(struct iwl_fw_runtime *fwrt, struct list_head *list, From patchwork Thu Nov 26 13:31:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933965 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4DB3C64E7B for ; Thu, 26 Nov 2020 13:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7092A21D40 for ; Thu, 26 Nov 2020 13:33:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fqv0JhXG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390378AbgKZNcd (ORCPT ); Thu, 26 Nov 2020 08:32:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390318AbgKZNcQ (ORCPT ); Thu, 26 Nov 2020 08:32:16 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B989C0617A7 for ; Thu, 26 Nov 2020 05:32:16 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id p8so2157710wrx.5 for ; Thu, 26 Nov 2020 05:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=056QqikcWr/GU3mDhY6gijUgY/LGF79OsK2zfz8G1FY=; b=fqv0JhXGTBJ6+Rj9ibArRehnnEYTflFsehO23vS9knsxbK7litwIKnbiw7ObbXfS/e f4Ir3thv79U4cTh0HGulqmvMIBVxvuEt9Dop7Zv5ht638Jx8m12KvMVS7h6Z2l+G1GkX cVFxqKHqP1xMiYcLllMxAHpUIX1LY1gs9vLRELHv6ZmUlddNzRO0eVsCq/94H2h995bM 5pPjAU9MStt8Om1c3WCFX1ENSOWaXEddv9/QhD39zVhQW2xuwwr737j16SIy/3Drbfhj oJ3+TDuW/eLNsRST+cRAuHC19XSYN6pvdJKzsOCF8y8sShpZ24tO1rVh9ubYqkjQ9S34 Eq1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=056QqikcWr/GU3mDhY6gijUgY/LGF79OsK2zfz8G1FY=; b=CdoqKv0B33NUcrGhgagwlGwPvUcB+a/2Pz9ws6HL6r2RJpSJ+d+nhfop6NJzX7CnWA c/85H4+b6WIMeqW4g56ExufYIJTOHSHeS3Emw2qm4StTL5L3ACK15v3vlUWm6peU93MM IFs3z68sllmGquNNx2bEaVTXHlBMnFgxKwDlSxMUUCUmdkcQW82sfmLsy38rfinPnzdg mcIWul3f+3qA4a7vqtUs+xys8ycU8Pd4OKWw4h0cToD9Si4OIed/qRLodxMaFM+qDKVP gTsy1XZc4tMD+tywIL8OYnVpc5BCtJUFpQA7/miu7isJvocSRzCZraMzyNZKPGH3hgVa F8cA== X-Gm-Message-State: AOAM533Gb0LRiju6YLe6bSBTCE8BqpCVJ5mbY2ddlSqti1g66h7XVRx9 KnNwZkwr8weiZRCawWtvnJFrJw== X-Google-Smtp-Source: ABdhPJzYvUJmMpBs6Uu4aktg9Hmy5bVFWzXjnfem1+AQgkKMzk6zfjUlVS+cAc7faTABkYV01/5rWQ== X-Received: by 2002:adf:dc83:: with SMTP id r3mr3769552wrj.223.1606397535117; Thu, 26 Nov 2020 05:32:15 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:14 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, QCA ath9k Development , "David S. Miller" , Jakub Kicinski , Lorenzo Bianconi , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 15/17] ath9k: dynack: Demote non-compliant function header Date: Thu, 26 Nov 2020 13:31:50 +0000 Message-Id: <20201126133152.3211309-16-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or member 'old' not described in 'ath_dynack_ewma' drivers/net/wireless/ath/ath9k/dynack.c:52: warning: Function parameter or member 'new' not described in 'ath_dynack_ewma' Cc: QCA ath9k Development Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Lorenzo Bianconi Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/ath/ath9k/dynack.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath9k/dynack.c b/drivers/net/wireless/ath/ath9k/dynack.c index fbeb4a739d321..3219715174a2f 100644 --- a/drivers/net/wireless/ath/ath9k/dynack.c +++ b/drivers/net/wireless/ath/ath9k/dynack.c @@ -44,9 +44,8 @@ static u32 ath_dynack_get_max_to(struct ath_hw *ah) return 600; } -/** +/* * ath_dynack_ewma - EWMA (Exponentially Weighted Moving Average) calculation - * */ static inline int ath_dynack_ewma(int old, int new) { From patchwork Thu Nov 26 13:31:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933963 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E889C71156 for ; Thu, 26 Nov 2020 13:33:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 14F9C21D40 for ; Thu, 26 Nov 2020 13:33:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tlDrq9iI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390362AbgKZNcU (ORCPT ); Thu, 26 Nov 2020 08:32:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390343AbgKZNcT (ORCPT ); Thu, 26 Nov 2020 08:32:19 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C00BEC061A47 for ; Thu, 26 Nov 2020 05:32:17 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id a65so2431452wme.1 for ; Thu, 26 Nov 2020 05:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SxQ9eC4olAQ/BaWiTM/LMUE/iibApHADASIQRVEODWI=; b=tlDrq9iIniydmRPORn0GM7r7Sk+AYo81IX40ePvYCs9TvW173vIQNiohrAz4S+p7IW fBy7trdzh4ocFFU0zcprItKqpZe37746Y9o6fwQklnx8oZD0QaCeL4XFot4goDfpBwfH 53tUjsuyWlWwCfrErTH1CbKfH8+iyIVScKIyqgssp2hMAtY1pFUNfnAbC7SKk94sgTKl hULP+RETO+bmAWVeli/OjyuI/FEVLsP99k8H47IgkGd1kdhiVrjftx5glDxqkgVGX6nE yMPtsfTykIcmWYbEE0peYDfCx3541qvesAGMTauB6RA9nQlWkzMgfwkOyiVKOWHsSFp1 2CmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SxQ9eC4olAQ/BaWiTM/LMUE/iibApHADASIQRVEODWI=; b=LyGFpSUe2STn+i8sAZffgTGznNe15L85TO0LvXLqLTP3pruLMkQ+eZe1niUU2BtF3h +5OMhb+vV26zJILCo+IAhcNqdVDrsSzIlgRvh+JRx/Y8msDYWWlzuR/CGS/uv6Q3QHt+ Bh/mZkH9vwXrUb9e0qPeQIkBDwRDPGbIpq1tqqQVKyCDAOsycqtu8JvtCaxRpHn4sgTw sP87noARmyvkS9xL7z+f0J+sBqyQJovIMiCRL/XeHUvOhNp2P+/B5rxskCO5G2DTzNxE bnmx8CeCd8pnrk1ADj42Nrf319F12BIGiVR3xuQIba7IOtAMQwcEF6k1lLvyoShsnSBU mw2w== X-Gm-Message-State: AOAM533qdMEAiaEfEFJV2bKXLPCO10zec79meyhsKH/zA8aDZNX4su4E caw245L7jj0nvzM/9K8yo4pPSQ== X-Google-Smtp-Source: ABdhPJwctTXOdDqXHc6BgjPWSqBZhBtIxZlS9oZ6ARvk8ICeeOJ9MLAmy1vyiW939ek2VY+8nxU0qQ== X-Received: by 2002:a1c:c343:: with SMTP id t64mr3467938wmf.140.1606397536471; Thu, 26 Nov 2020 05:32:16 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:15 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 16/17] iwlwifi: fw: acpi: Demote non-conformant function headers Date: Thu, 26 Nov 2020 13:31:51 +0000 Message-Id: <20201126133152.3211309-17-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following W=1 kernel build warning(s): drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:123: warning: Function parameter or member 'args' not described in 'iwl_acpi_get_dsm_object' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'dev' not described in 'iwl_acpi_get_dsm_u8' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'rev' not described in 'iwl_acpi_get_dsm_u8' drivers/net/wireless/intel/iwlwifi/fw/acpi.c:142: warning: Function parameter or member 'func' not described in 'iwl_acpi_get_dsm_u8' Cc: Johannes Berg Cc: Emmanuel Grumbach Cc: Luca Coelho Cc: Intel Linux Wireless Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/intel/iwlwifi/fw/acpi.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c index 3e5a35e26ad34..ab1d8b18d9976 100644 --- a/drivers/net/wireless/intel/iwlwifi/fw/acpi.c +++ b/drivers/net/wireless/intel/iwlwifi/fw/acpi.c @@ -113,11 +113,11 @@ void *iwl_acpi_get_object(struct device *dev, acpi_string method) } IWL_EXPORT_SYMBOL(iwl_acpi_get_object); -/** -* Generic function for evaluating a method defined in the device specific -* method (DSM) interface. The returned acpi object must be freed by calling -* function. -*/ +/* + * Generic function for evaluating a method defined in the device specific + * method (DSM) interface. The returned acpi object must be freed by calling + * function. + */ static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func, union acpi_object *args) { @@ -134,7 +134,7 @@ static void *iwl_acpi_get_dsm_object(struct device *dev, int rev, int func, return obj; } -/** +/* * Evaluate a DSM with no arguments and a single u8 return value (inside a * buffer object), verify and return that value. */ From patchwork Thu Nov 26 13:31:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11933967 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B7F5C8300E for ; Thu, 26 Nov 2020 13:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7A3821D40 for ; Thu, 26 Nov 2020 13:33:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="IJKrKLXl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389732AbgKZNc0 (ORCPT ); Thu, 26 Nov 2020 08:32:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390336AbgKZNcV (ORCPT ); Thu, 26 Nov 2020 08:32:21 -0500 Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F069C061A04 for ; Thu, 26 Nov 2020 05:32:20 -0800 (PST) Received: by mail-wr1-x441.google.com with SMTP id 64so2138871wra.11 for ; Thu, 26 Nov 2020 05:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=WOPpp6HIgOcad1W0yfFfa1/Wy9WX17Rmpe1tMayS4HI=; b=IJKrKLXlEdbjjcRCFvRL1iTnWYhhIqcjEsenkEgZGOdVW7caoAQZPdSzf9q+0TDL1R Rv54vzF/hbcPiBYkShfjFH+xCa/L24Iq5UV3X7aMzmfSmnl2NZ+Hfy0SAlQbpzRDhAVR 6TCbs6gTAUplQFlusL7f/X2ITdQ33zUI+qVN5ngvGv6NSNR8vpN1QYy9KV/rufaGf69O 331G6hx/qanbzDNjYqHtmsPDTPtzVPSH/Gl/X/Dnw1baucosDCBK3CrHKXzBYnvTkGdA D01pqh/BUgXlQsfdMoyDGnRHPDSJ/tHaysYsqYlxraLeHDEfUF+lTQ+vdkrSfjrc5T2c AP6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WOPpp6HIgOcad1W0yfFfa1/Wy9WX17Rmpe1tMayS4HI=; b=OTAOtto8A0lC6ugjxo9lpGvSMYUkyIqB4cqhaQrQ2fN9TOuoQM4jwdntZc+F8mI79J CqRjAXRSk1zvbETZW5rrsCiOuvBCu+Pe+JjfHTh5PpXLXhymIzczSZ09ebCctt+Tzdpi 14DdgKv9ftFsog/VIEB0IFG/p2Y5M9/uGT3U0PDhSSq7329lW71Ly8DxEfWmPsrMcOd1 +tPmUWVlIgot+SD/J9dKVp/eKLCvnDe2EbmdTPwyFOVcP9QYYCgKd4x/O8SRA/LCKS39 iZtwrKdTs0P79bVHyaQoZfG1lxdl7nz5H10DtGQH10MmZgH+pbzmn5FVIB7hOqtnj8rJ wInw== X-Gm-Message-State: AOAM531gcfETFbaCj/WMTOWe9pUo71+3BfXS2afhvSZ6JOhPA2fjg2Kg 8u1d7mf2CKKdylGGbfyhXjBXJA== X-Google-Smtp-Source: ABdhPJz5JanrQA5T2e5MhcTaKmi3Rr5awkz/j5dYdTosg06LwfkbLMK27zcgfXcL/8U30DN6fFHbeQ== X-Received: by 2002:a5d:4cca:: with SMTP id c10mr3890245wrt.176.1606397538176; Thu, 26 Nov 2020 05:32:18 -0800 (PST) Received: from dell.default ([91.110.221.235]) by smtp.gmail.com with ESMTPSA id n10sm8701001wrv.77.2020.11.26.05.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 05:32:17 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org, kvalo@codeaurora.org Cc: linux-kernel@vger.kernel.org, Yan-Hsuan Chuang , "David S. Miller" , Jakub Kicinski , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH 17/17] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown Date: Thu, 26 Nov 2020 13:31:52 +0000 Message-Id: <20201126133152.3211309-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201126133152.3211309-1-lee.jones@linaro.org> References: <20201126133152.3211309-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Also strip out other duplicates from driver specific headers. Ensure 'main.h' is explicitly included in 'pci.h' since the latter uses some defines from the former. It avoids issues like: from drivers/net/wireless/realtek/rtw88/rtw8822be.c:5: drivers/net/wireless/realtek/rtw88/pci.h:209:28: error: ‘RTK_MAX_TX_QUEUE_NUM’ undeclared here (not in a function); did you mean ‘RTK_MAX_RX_DESC_NUM’? 209 | DECLARE_BITMAP(tx_queued, RTK_MAX_TX_QUEUE_NUM); | ^~~~~~~~~~~~~~~~~~~~ Fixes the following W=1 kernel build warning(s): drivers/net/wireless/realtek/rtw88/pci.c:1488:5: warning: no previous prototype for ‘rtw_pci_probe’ [-Wmissing-prototypes] 1488 | int rtw_pci_probe(struct pci_dev *pdev, | ^~~~~~~~~~~~~ drivers/net/wireless/realtek/rtw88/pci.c:1568:6: warning: no previous prototype for ‘rtw_pci_remove’ [-Wmissing-prototypes] 1568 | void rtw_pci_remove(struct pci_dev *pdev) | ^~~~~~~~~~~~~~ drivers/net/wireless/realtek/rtw88/pci.c:1590:6: warning: no previous prototype for ‘rtw_pci_shutdown’ [-Wmissing-prototypes] 1590 | void rtw_pci_shutdown(struct pci_dev *pdev) | ^~~~~~~~~~~~~~~~ Cc: Yan-Hsuan Chuang Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: Lee Jones --- drivers/net/wireless/realtek/rtw88/pci.h | 8 ++++++++ drivers/net/wireless/realtek/rtw88/rtw8723de.c | 1 + drivers/net/wireless/realtek/rtw88/rtw8723de.h | 4 ---- drivers/net/wireless/realtek/rtw88/rtw8821ce.c | 1 + drivers/net/wireless/realtek/rtw88/rtw8821ce.h | 4 ---- drivers/net/wireless/realtek/rtw88/rtw8822be.c | 1 + drivers/net/wireless/realtek/rtw88/rtw8822be.h | 4 ---- drivers/net/wireless/realtek/rtw88/rtw8822ce.c | 1 + drivers/net/wireless/realtek/rtw88/rtw8822ce.h | 4 ---- 9 files changed, 12 insertions(+), 16 deletions(-) diff --git a/drivers/net/wireless/realtek/rtw88/pci.h b/drivers/net/wireless/realtek/rtw88/pci.h index ca17aa9cf7dc7..cda56919a5f0f 100644 --- a/drivers/net/wireless/realtek/rtw88/pci.h +++ b/drivers/net/wireless/realtek/rtw88/pci.h @@ -5,6 +5,8 @@ #ifndef __RTK_PCI_H_ #define __RTK_PCI_H_ +#include "main.h" + #define RTK_DEFAULT_TX_DESC_NUM 128 #define RTK_BEQ_TX_DESC_NUM 256 @@ -212,6 +214,12 @@ struct rtw_pci { void __iomem *mmap; }; +const struct dev_pm_ops rtw_pm_ops; + +int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); +void rtw_pci_remove(struct pci_dev *pdev); +void rtw_pci_shutdown(struct pci_dev *pdev); + static inline u32 max_num_of_tx_queue(u8 queue) { u32 max_num; diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723de.c b/drivers/net/wireless/realtek/rtw88/rtw8723de.c index c81eb4c336425..2dd689441e8dc 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8723de.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8723de.c @@ -4,6 +4,7 @@ #include #include +#include "pci.h" #include "rtw8723de.h" static const struct pci_device_id rtw_8723de_id_table[] = { diff --git a/drivers/net/wireless/realtek/rtw88/rtw8723de.h b/drivers/net/wireless/realtek/rtw88/rtw8723de.h index ba3842360c20a..2b4894846a07f 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8723de.h +++ b/drivers/net/wireless/realtek/rtw88/rtw8723de.h @@ -5,10 +5,6 @@ #ifndef __RTW_8723DE_H_ #define __RTW_8723DE_H_ -extern const struct dev_pm_ops rtw_pm_ops; extern struct rtw_chip_info rtw8723d_hw_spec; -int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); -void rtw_pci_remove(struct pci_dev *pdev); -void rtw_pci_shutdown(struct pci_dev *pdev); #endif diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821ce.c b/drivers/net/wireless/realtek/rtw88/rtw8821ce.c index 616fdcfd62c98..f34de115e4bc4 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8821ce.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8821ce.c @@ -4,6 +4,7 @@ #include #include +#include "pci.h" #include "rtw8821ce.h" static const struct pci_device_id rtw_8821ce_id_table[] = { diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821ce.h b/drivers/net/wireless/realtek/rtw88/rtw8821ce.h index 8d3eb77a876be..54142acca5344 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8821ce.h +++ b/drivers/net/wireless/realtek/rtw88/rtw8821ce.h @@ -5,10 +5,6 @@ #ifndef __RTW_8821CE_H_ #define __RTW_8821CE_H_ -extern const struct dev_pm_ops rtw_pm_ops; extern struct rtw_chip_info rtw8821c_hw_spec; -int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); -void rtw_pci_remove(struct pci_dev *pdev); -void rtw_pci_shutdown(struct pci_dev *pdev); #endif diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822be.c b/drivers/net/wireless/realtek/rtw88/rtw8822be.c index 921916ae15cab..62ee7e62cac02 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822be.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822be.c @@ -4,6 +4,7 @@ #include #include +#include "pci.h" #include "rtw8822be.h" static const struct pci_device_id rtw_8822be_id_table[] = { diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822be.h b/drivers/net/wireless/realtek/rtw88/rtw8822be.h index d823ca059f5c9..6668460d664da 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822be.h +++ b/drivers/net/wireless/realtek/rtw88/rtw8822be.h @@ -5,10 +5,6 @@ #ifndef __RTW_8822BE_H_ #define __RTW_8822BE_H_ -extern const struct dev_pm_ops rtw_pm_ops; extern struct rtw_chip_info rtw8822b_hw_spec; -int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); -void rtw_pci_remove(struct pci_dev *pdev); -void rtw_pci_shutdown(struct pci_dev *pdev); #endif diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c index 026ac49ce6e3c..3845b1333dc39 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.c @@ -4,6 +4,7 @@ #include #include +#include "pci.h" #include "rtw8822ce.h" static const struct pci_device_id rtw_8822ce_id_table[] = { diff --git a/drivers/net/wireless/realtek/rtw88/rtw8822ce.h b/drivers/net/wireless/realtek/rtw88/rtw8822ce.h index c2c0e8675d742..fee32d7a45047 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8822ce.h +++ b/drivers/net/wireless/realtek/rtw88/rtw8822ce.h @@ -5,10 +5,6 @@ #ifndef __RTW_8822CE_H_ #define __RTW_8822CE_H_ -extern const struct dev_pm_ops rtw_pm_ops; extern struct rtw_chip_info rtw8822c_hw_spec; -int rtw_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id); -void rtw_pci_remove(struct pci_dev *pdev); -void rtw_pci_shutdown(struct pci_dev *pdev); #endif